]> git.ipfire.org Git - thirdparty/suricata.git/log
thirdparty/suricata.git
9 years agosrc/: fix typo: receieved vs received 2095/head
Arturo Borrero Gonzalez [Mon, 23 May 2016 10:32:34 +0000 (12:32 +0200)] 
src/: fix typo: receieved vs received

Reported by Debian's lintian tool.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
9 years agoflow worker: set up decoder thread vars
Victor Julien [Sat, 21 May 2016 12:22:13 +0000 (14:22 +0200)] 
flow worker: set up decoder thread vars

9 years agoac: allow use of 31bits of pid space instead of 16 2092/head
Victor Julien [Fri, 22 Apr 2016 10:57:41 +0000 (12:57 +0200)] 
ac: allow use of 31bits of pid space instead of 16

9 years agodns: add support for sshfp records
Victor Julien [Wed, 23 Sep 2015 14:34:40 +0000 (16:34 +0200)] 
dns: add support for sshfp records

Update parser to process the records.

Update json output to log it.

9 years agocoverity: CID 1362011: Control flow issues (DEADCODE)
Victor Julien [Fri, 20 May 2016 16:45:16 +0000 (18:45 +0200)] 
coverity: CID 1362011: Control flow issues (DEADCODE)

9 years agocoverity: CID 1362012: Incorrect expression (EVALUATION_ORDER)
Victor Julien [Fri, 20 May 2016 16:42:46 +0000 (18:42 +0200)] 
coverity: CID 1362012: Incorrect expression (EVALUATION_ORDER)

9 years agocoverity CID 1362013: Control flow issues (NESTING_INDENT_MISMATCH)
Victor Julien [Fri, 20 May 2016 16:40:45 +0000 (18:40 +0200)] 
coverity CID 1362013: Control flow issues (NESTING_INDENT_MISMATCH)

9 years agoaf-packet: CentOS6 build fixes 2091/head
Victor Julien [Fri, 20 May 2016 08:41:45 +0000 (10:41 +0200)] 
af-packet: CentOS6 build fixes

9 years agoaf-packet: use time() instead of GetTime()
Eric Leblond [Tue, 26 Apr 2016 17:55:51 +0000 (19:55 +0200)] 
af-packet: use time() instead of GetTime()

As we only use the second we don't need GetTime() which is slower
and get us milliseconds.

9 years agoaf-packet: print errno on mmap error
Eric Leblond [Tue, 26 Apr 2016 17:46:19 +0000 (19:46 +0200)] 
af-packet: print errno on mmap error

9 years agoaf-packet: fix some typos in yaml
Eric Leblond [Fri, 22 Apr 2016 17:50:10 +0000 (19:50 +0200)] 
af-packet: fix some typos in yaml

9 years agoaf-packet: ask for hardware timestamp
Eric Leblond [Fri, 22 Apr 2016 22:30:39 +0000 (00:30 +0200)] 
af-packet: ask for hardware timestamp

9 years agoaf-packet: make mmap options parsing conditional
Eric Leblond [Mon, 18 Apr 2016 12:24:08 +0000 (14:24 +0200)] 
af-packet: make mmap options parsing conditional

Only parse them if mmap is activated.

9 years agoaf-packet: reset stats at start of capture
Eric Leblond [Tue, 12 Apr 2016 09:46:43 +0000 (11:46 +0200)] 
af-packet: reset stats at start of capture

We can loose packets during setup because we are reading nothing.
So it is logical to discard the counter at start of capture to
start from a clean state. This means we don't need to account the
drop at start. But the stats call that will reset the drop counts
will also return and reset the packets count. So we need to know
how many packets we really have. This is in fact the number of
packets coming from the stats call minus the number of discarded
packets and the drop count. All the other packets will have to be
read.

9 years agoaf-packet: use mmap capture by default
Eric Leblond [Fri, 1 Apr 2016 12:01:09 +0000 (14:01 +0200)] 
af-packet: use mmap capture by default

Update the code to use mmap capture by default even in unset in
configuration file. mmap capture is now be turned off by using
explicitely 'use-mmap: no' in configuration.

9 years agoaf-packet: detect availability of tpacket_v3
Eric Leblond [Sat, 9 Apr 2016 14:07:23 +0000 (16:07 +0200)] 
af-packet: detect availability of tpacket_v3

If TPACKET_V3 is not defined then it is not available and we should
not build anything related to tpacket_v3. This will allow us to
activate it dy default and fallback to v2 if not available.

9 years agoaf-packet: add option to use memory locked mmap
Eric Leblond [Fri, 8 Apr 2016 15:05:55 +0000 (17:05 +0200)] 
af-packet: add option to use memory locked mmap

9 years agoaf-packet: configurable tpacket_v3 block timeout
Eric Leblond [Fri, 8 Apr 2016 13:29:18 +0000 (15:29 +0200)] 
af-packet: configurable tpacket_v3 block timeout

Block timeout defines the maximum filling duration of a block.

9 years agoaf-packet: configurable tpacket_v3 block size
Eric Leblond [Fri, 8 Apr 2016 08:03:52 +0000 (10:03 +0200)] 
af-packet: configurable tpacket_v3 block size

It is used to set the block size in tpacket_v3. It will allow user
to tune the capture depending on his bandwidth.

Default block size value has been updated to a bigger value to
allow more efficient wlak on block.

9 years agoaf-packet: put ring setup in a separate function
Eric Leblond [Thu, 7 Apr 2016 19:58:48 +0000 (21:58 +0200)] 
af-packet: put ring setup in a separate function

9 years agoaf-packet: pack AFPPeer structure
Eric Leblond [Fri, 1 Apr 2016 20:52:37 +0000 (22:52 +0200)] 
af-packet: pack AFPPeer structure

9 years agoaf-packet: AFPWalkBlock error handling
Eric Leblond [Fri, 22 Apr 2016 20:15:53 +0000 (22:15 +0200)] 
af-packet: AFPWalkBlock error handling

Error handling was not done. The implementation is making the
choice to consider we must detroy the socket in case of parsing
error. The same was done for tpacket_v2.

9 years agoaf-packet: continuing cleaning and hole hunting
Eric Leblond [Fri, 1 Apr 2016 20:33:22 +0000 (22:33 +0200)] 
af-packet: continuing cleaning and hole hunting

Suppress useless fields in AFPThreadVars. This patch also get rid
of bytes counter as it was only used to display a message at exit.
Information on livedev and on packet counters are enough.

9 years agoaf-packet: cleaning and hole hunting
Eric Leblond [Fri, 1 Apr 2016 17:46:41 +0000 (19:46 +0200)] 
af-packet: cleaning and hole hunting

Reorder fields in AFPThreadVars and suppress some that were not
used elsewhere than in the initialization.

9 years agoaf-packet: tpacket_v3 implementation
Eric Leblond [Mon, 28 Oct 2013 16:19:31 +0000 (17:19 +0100)] 
af-packet: tpacket_v3 implementation

This patch adds a basic implementation of AF_PACKET tpacket v3. It
is basic in the way it is only working for 'workers' runnning mode.
If not in 'workers' mode there is a fallback to tpacket_v2. Feature
is activated via tpacket-v3 option in the af-packet section of
Suricata YAML.

9 years agoaf-packet: remove useless code
Eric Leblond [Fri, 1 Apr 2016 11:52:24 +0000 (13:52 +0200)] 
af-packet: remove useless code

No need for cooked header in the case of mmap capture.

9 years agoaf-packet: micro optimization
Eric Leblond [Fri, 1 Apr 2016 06:48:31 +0000 (08:48 +0200)] 
af-packet: micro optimization

9 years agoaf-packet: avoid test for each packet
Eric Leblond [Thu, 3 Jan 2013 19:29:54 +0000 (20:29 +0100)] 
af-packet: avoid test for each packet

9 years agospm: handle null ptrs in destroy funcs gracefully
Justin Viiret [Fri, 20 May 2016 03:31:05 +0000 (13:31 +1000)] 
spm: handle null ptrs in destroy funcs gracefully

This will handle minimal DetectEngineCtx structures (used in delayed
detect mode) safely, since they don't get SPM global contexts allocated.

Also added BUG_ON checks for valid spm_table entries.

9 years agofile: switch to streaming buffer API
Victor Julien [Mon, 30 Nov 2015 20:21:50 +0000 (21:21 +0100)] 
file: switch to streaming buffer API

Make the file storage use the streaming buffer API.

As the individual file chunks were not needed by themselves, this
approach uses a chunkless implementation.

9 years agohttp: improve body inspection
Victor Julien [Mon, 16 Nov 2015 09:05:56 +0000 (10:05 +0100)] 
http: improve body inspection

Enforce inspect window also in IDS mode. Try always to get at least
'inspect win' worth of data. In case there is more new data, take
some of the old data as well to make sure there is always some overlap.

This unifies IDS and IPS modes, the only difference left is the start
of inspection. IDS waits until min_size is available, IPS starts right
away.

9 years agohttp: make htpstate cfg ptr const
Victor Julien [Sun, 15 Nov 2015 12:21:59 +0000 (13:21 +0100)] 
http: make htpstate cfg ptr const

9 years agohttp: move body settings into per dir struct
Victor Julien [Sun, 15 Nov 2015 12:20:14 +0000 (13:20 +0100)] 
http: move body settings into per dir struct

9 years agohttp: add per direction config for body parsing
Victor Julien [Fri, 13 Nov 2015 23:14:02 +0000 (00:14 +0100)] 
http: add per direction config for body parsing

The HTPCfgDir structure is meant to contain config for per direction
body parsing parameters.

This patch stores the streaming API config.

9 years agohttp body handling: use streaming buffer API
Victor Julien [Wed, 11 Nov 2015 23:19:52 +0000 (00:19 +0100)] 
http body handling: use streaming buffer API

Convert HTTP body handling to use the Streaming Buffer API. This means
the HtpBodyChunks no longer maintain their own data segments, but
instead add their data to the StreamingBuffer instance in the HtpBody
structure.

In case the HtpBodyChunk needs to access it's data it can do so still
through the Streaming Buffer API.

Updates & simplifies the various users of the reassembled bodies:
multipart parsing and the detection engine.

9 years agostreaming: buffer API
Victor Julien [Sun, 8 Nov 2015 17:30:05 +0000 (18:30 +0100)] 
streaming: buffer API

Add a new API to store data from streaming sources, like HTTP body
processing or TCP data.

Currently most of the code uses a pattern of list of data chunks
(e.g. TcpSegment) that is reassembled into a large buffer on-demand.

The Streaming Buffer API changes the logic to store the data in
reassembled form from the start, with the segments/chunks pointing
to the reassembled data.

The main buffer storing the data slides forward, automatically or
manually. The *NoTrack calls allows for a segmentless mode of
operation.

This approach has two main advantages:

1. accessing the reassembled data is virtually cost-free
2. reduction of allocations and memory management

9 years agoautofp: update queue handlers 2089/head
Victor Julien [Tue, 17 May 2016 16:34:55 +0000 (18:34 +0200)] 
autofp: update queue handlers

Now that the flow lookup is done in the worker threads the flow
queue handlers running after the capture thread(s) no longer have
access to the flow. This limits the options of how flow balancing
can be done.

This patch removes all code that is now useless. The only 2 methods
that still make sense are 'hash' and 'ippair'.

9 years agoflow: remove dead code
Victor Julien [Tue, 17 May 2016 16:05:26 +0000 (18:05 +0200)] 
flow: remove dead code

9 years agoflowworker: initial support
Victor Julien [Tue, 19 Apr 2016 16:06:32 +0000 (18:06 +0200)] 
flowworker: initial support

Initial version of the 'FlowWorker' thread module. This module
combines Flow handling, TCP handling, App layer handling and
Detection in a single module. It does all flow related processing
under a single flow lock.

9 years agodetect: simplify flow locking
Victor Julien [Sat, 16 Apr 2016 21:06:33 +0000 (23:06 +0200)] 
detect: simplify flow locking

To simplify locking, move all locking out of the individual detect
code. Instead at the start of detection lock the flow, and at the
end of detection unlock it.

The lua code can be called without a lock still (from the output
code paths), so still pass around a lock hint to take care of this.

9 years agotime: improve offline time handling
Victor Julien [Mon, 18 Apr 2016 13:09:13 +0000 (15:09 +0200)] 
time: improve offline time handling

When we run on live traffic, time handling is simple. Packets have a
timestamp set by the capture method. Management threads can simply
use 'gettimeofday' to know the current time. There should never be
any serious gap between the two or major differnces between the
threads.

In offline mode, things are dramatically different. Here we try to keep
the time from the pcap, which means that if the packets are recorded in
2011 the log output should also reflect this. Multiple issues:

 1. merged pcaps might have huge time jumps or time going backward
 2. slowly recorded pcaps may be processed much faster than their
    'realtime'
 3. management threads need a concept of what the 'current' time is for
    enforcing timeouts
 4. due to (1) individual threads may have very different views on what
    the current time is. E.g. T1 processed packet 1 with TS X, while T2
    at the very same time processes packet 2 with TS X+100000s.

The changes in flow handling make the problems worse. The capture thread
no longer handles the flow lookup, while it did set the global 'time'.
This meant that a thread may be working on Packet 1 with TS 1, while the
capture thread already saw packet 2 with TS 10000. Management threads
would take TS 10000 as the 'current time', considering a flow created by
the first thread as timed out immediately.

This was less of a problem before the flow changes as the capture thread
would also create a flow reference for a packet, meaning the flow
couldn't time out as easily. Packets in the queues between capture
thread and workers would all hold such references.

The patch updates the time handling to be as follows.

In offline mode we keep the timestamp per thread. If a management thread
needs current time, it will get the minimum of the threads' values. This
is to avoid the problem that T2s time value might already trigger a flow
timeout as the flow lastts + 100000s is almost certainly meaning the
flow would be considered timed out.

9 years agoflow: move flow handling into worker threads
Victor Julien [Fri, 15 Apr 2016 15:08:50 +0000 (17:08 +0200)] 
flow: move flow handling into worker threads

Instead of handling the packet update during flow lookup, handle
it in the stream/detect threads. This lowers the load of the
capture thread(s) in autofp mode.

The decoders now set a flag in the packet if the packet needs a
flow lookup. Then the workers will take care of this. The decoders
also already calculate the raw flow hash value. This is so that
this value can be used in flow balancing in autofp.

Because the flow lookup/creation is now done in the worker threads,
the flow balancing can no longer use the flow. It's not yet
available. Autofp load balancing uses raw hash values instead.

In the same line, move UDP AppLayer out of the DecodeUDP module,
and also into the stream/detect threads.

Handle TCP session reuse inside the flow engine itself. If a looked up
flow matches the packet, but is a TCP stream starter, check if the
ssn needs to be reused. If that is the case handle it within the
lookup function. Simplies the locking and removes potential race
conditions.

9 years agoflow: get flow reference during lookup
Victor Julien [Tue, 17 Mar 2015 11:48:14 +0000 (12:48 +0100)] 
flow: get flow reference during lookup

Update Flow lookup functions to get a flow reference during lookup.

This reference is set under the FlowBucket lock.

This paves the way to not getting a flow lock during lookups.

9 years agodetect: split detect entry into flow/noflow
Victor Julien [Sat, 16 Apr 2016 19:30:32 +0000 (21:30 +0200)] 
detect: split detect entry into flow/noflow

This is a preparation for flow locking updates.

9 years agodetect: add (mpm) keyword for tls_sni
Mats Klepsland [Wed, 18 May 2016 11:49:47 +0000 (13:49 +0200)] 
detect: add (mpm) keyword for tls_sni

Match on server name indication (SNI) extension in TLS using tls_sni
keyword, e.g:

alert tls any any -> any any (msg:"SNI test"; tls_sni;
        content:"example.com"; sid:12345;)

9 years agotypo: SURCATA -> SURICATA 2086/head
Jason Ish [Tue, 17 May 2016 19:40:43 +0000 (13:40 -0600)] 
typo: SURCATA -> SURICATA

9 years agotypos: surictsc -> suricatasc
Jason Ish [Tue, 17 May 2016 19:40:01 +0000 (13:40 -0600)] 
typos: surictsc -> suricatasc

Reported by Markus Lude on the mailing list.

9 years agoipv6: simplify ext hdr parsing
Victor Julien [Mon, 16 May 2016 12:11:56 +0000 (14:11 +0200)] 
ipv6: simplify ext hdr parsing

9 years agodefrag: work around packet creation issues
Victor Julien [Sun, 15 May 2016 18:05:44 +0000 (20:05 +0200)] 
defrag: work around packet creation issues

Defrag tests set up packets but don't call Decode on them. Work
around failing IPv6 tests.

9 years agoipv6: simplify ext hdr parsing and storage
Victor Julien [Sun, 15 May 2016 11:35:10 +0000 (13:35 +0200)] 
ipv6: simplify ext hdr parsing and storage

This reduces size of the IPV6ExtHdr structure part of every packet
significantly.

Clean up macro's in the ipv6 header.

9 years agodetect-ipopts: optimize matching
Victor Julien [Mon, 16 May 2016 10:31:07 +0000 (12:31 +0200)] 
detect-ipopts: optimize matching

9 years agodetect-ipopts: cleanup
Victor Julien [Mon, 16 May 2016 10:26:22 +0000 (12:26 +0200)] 
detect-ipopts: cleanup

9 years agoipv4: removed unused variables
Victor Julien [Mon, 16 May 2016 10:17:38 +0000 (12:17 +0200)] 
ipv4: removed unused variables

9 years agoipv4: store ipopts as flags, not bools
Victor Julien [Mon, 16 May 2016 10:15:42 +0000 (12:15 +0200)] 
ipv4: store ipopts as flags, not bools

9 years agoipv4: shrink per packet ipopts storage
Victor Julien [Sun, 15 May 2016 16:29:25 +0000 (18:29 +0200)] 
ipv4: shrink per packet ipopts storage

9 years agoqa: update drmemory suppressions for hyperscan spm matching
Victor Julien [Fri, 13 May 2016 08:50:51 +0000 (10:50 +0200)] 
qa: update drmemory suppressions for hyperscan spm matching

9 years agospm: add "spm-algo: auto" setting
Justin Viiret [Mon, 16 May 2016 04:15:45 +0000 (14:15 +1000)] 
spm: add "spm-algo: auto" setting

This will default to Hyperscan when Suricata is built with Hyperscan
support. Otherwise, Boyer-Moore is used by default.

9 years agospm: add Hyperscan implementation
Justin Viiret [Thu, 28 Apr 2016 02:48:38 +0000 (12:48 +1000)] 
spm: add Hyperscan implementation

9 years agospm: add and use new SPM API
Justin Viiret [Wed, 11 May 2016 04:10:27 +0000 (14:10 +1000)] 
spm: add and use new SPM API

This new API allows for different SPM implementations, using a function
pointer table like that used for MPM.

This change also switches over the paths that make use of
DetectContentData (which previously used BoyerMoore directly) to the new
API.

9 years agosuricata.yaml: document spm-algo option
Justin Viiret [Thu, 12 May 2016 03:08:30 +0000 (13:08 +1000)] 
suricata.yaml: document spm-algo option

9 years agospm: add SinglePatternMatchDefaultMatcher
Justin Viiret [Thu, 28 Apr 2016 05:23:05 +0000 (15:23 +1000)] 
spm: add SinglePatternMatchDefaultMatcher

Allows selecting SPM algorithm with the 'spm-algo' value in the YAML
config file.

9 years agotcp sack: improve tests 2081/head
Victor Julien [Sat, 7 May 2016 15:22:22 +0000 (17:22 +0200)] 
tcp sack: improve tests

9 years agodetect app-layer-event: fix tests
Victor Julien [Sat, 7 May 2016 15:21:04 +0000 (17:21 +0200)] 
detect app-layer-event: fix tests

9 years agoapp-layer: test fixes
Victor Julien [Sat, 7 May 2016 15:20:12 +0000 (17:20 +0200)] 
app-layer: test fixes

9 years agothread storage: fix memset 0 after realloc
Victor Julien [Fri, 13 May 2016 16:35:26 +0000 (18:35 +0200)] 
thread storage: fix memset 0 after realloc

Thread storage expansion would not properly memset 0 the new part
of the memory.

9 years agoconfigure.ac: escape $srcdir when used in a variable
Jason Ish [Mon, 16 May 2016 07:21:33 +0000 (01:21 -0600)] 
configure.ac: escape $srcdir when used in a variable

$srcdir needs to be escaped for proper expansion when used
as part of a Makefile variable.

9 years agotlsstore: fix memleak
Mats Klepsland [Fri, 13 May 2016 06:00:19 +0000 (08:00 +0200)] 
tlsstore: fix memleak

Bug #1771.

Direct leak of 1834 byte(s) in 1 object(s) allocated from:
    #0 0x4e2e65 in realloc ??:?
    #1 0xcec27b in LogTlsLogPem /home/mats/suricata/src/log-tlsstore.c:130
    #2 0xcea4f5 in LogTlsStoreLogger /home/mats/suricata/src/log-tlsstore.c:303
    #3 0xd8b99c in OutputPacketLog /home/mats/suricata/src/output-packet.c:104

9 years agotlsstore: use TxLogger
Mats Klepsland [Thu, 12 May 2016 06:14:52 +0000 (08:14 +0200)] 
tlsstore: use TxLogger

9 years agooutput: add new tx logger to log at certain condition
Mats Klepsland [Thu, 12 May 2016 06:11:53 +0000 (08:11 +0200)] 
output: add new tx logger to log at certain condition

Some loggers needs certain conditions to be met before logging.
This enables us to use conditions on the tx logger.

9 years agotls: change flag checking in SSLParserTest23
Mats Klepsland [Wed, 27 Apr 2016 08:17:15 +0000 (10:17 +0200)] 
tls: change flag checking in SSLParserTest23

Change flag checking in SSLParserTest23 to check each flag individually
to enable adding more flags without the test failing.

9 years agooutput: allow more than one TLS logger
Mats Klepsland [Fri, 15 Apr 2016 07:19:36 +0000 (09:19 +0200)] 
output: allow more than one TLS logger

9 years agojsontls: use TxLogger
Mats Klepsland [Fri, 15 Apr 2016 07:07:09 +0000 (09:07 +0200)] 
jsontls: use TxLogger

9 years agotlslog: use TxLogger
Mats Klepsland [Thu, 14 Apr 2016 07:51:18 +0000 (09:51 +0200)] 
tlslog: use TxLogger

9 years agooutput-lua: use LuaTxLogger for TLS
Mats Klepsland [Wed, 13 Apr 2016 06:43:54 +0000 (08:43 +0200)] 
output-lua: use LuaTxLogger for TLS

9 years agooutput: add new logger to log at specified state
Mats Klepsland [Wed, 27 Apr 2016 12:13:44 +0000 (14:13 +0200)] 
output: add new logger to log at specified state

Sometimes we want to log when we reach a specified state instead of
waiting for the session to end. E.g for TLS we want to log as soon
as the handshake is done.

To do this, a new logger is added, where it is possible to specify
a custom "ProgressCompletionStatus".

9 years agotemplate: register logger functions
Mats Klepsland [Wed, 4 May 2016 11:37:04 +0000 (13:37 +0200)] 
template: register logger functions

9 years agomodbus: register logger functions
Mats Klepsland [Wed, 4 May 2016 11:25:03 +0000 (13:25 +0200)] 
modbus: register logger functions

9 years agohttp: register logger functions
Mats Klepsland [Wed, 4 May 2016 11:16:03 +0000 (13:16 +0200)] 
http: register logger functions

9 years agosmtp: register logger functions
Mats Klepsland [Wed, 4 May 2016 10:53:55 +0000 (12:53 +0200)] 
smtp: register logger functions

9 years agodns: register logger functions
Mats Klepsland [Wed, 4 May 2016 10:35:06 +0000 (12:35 +0200)] 
dns: register logger functions

9 years agotls: register logger functions
Mats Klepsland [Wed, 4 May 2016 10:14:13 +0000 (12:14 +0200)] 
tls: register logger functions

9 years agotx: add functions for logging
Mats Klepsland [Wed, 4 May 2016 09:03:57 +0000 (11:03 +0200)] 
tx: add functions for logging

Add function AppLayerParserRegisterLoggerFuncs for registering
a callback function for checking if a specific logger has logged
a transaction, and a callback function for specifying that it has.

Also add functions AppLayerParserGetTxLogged and
AppLayerParserSetTxLogged to invoke these callback functions.

9 years agotx: do not store ProgressCompletionStatus per ipproto
Mats Klepsland [Wed, 4 May 2016 08:00:26 +0000 (10:00 +0200)] 
tx: do not store ProgressCompletionStatus per ipproto

Change AppLayerParserRegisterGetStateProgressCompletionStatus to
only store one ProgressCompletionStatus callback function for each
alproto, instead of storing one for each ipproto.

This enables us to use AppLayerParserGetStateProgressCompletionStatus
in functions where we do not know the ipproto used.

9 years agotls: make TX aware
Mats Klepsland [Wed, 13 Apr 2016 06:28:16 +0000 (08:28 +0200)] 
tls: make TX aware

9 years agotls-sni: fix alignment issues 2073/head
Mats Klepsland [Thu, 12 May 2016 09:54:05 +0000 (11:54 +0200)] 
tls-sni: fix alignment issues

9 years agosources: fix netmap compilation and pcap setup 2070/head
Victor Julien [Tue, 10 May 2016 06:50:37 +0000 (08:50 +0200)] 
sources: fix netmap compilation and pcap setup

9 years agoflow queue handler: use int16_t
Victor Julien [Wed, 18 Mar 2015 10:24:26 +0000 (11:24 +0100)] 
flow queue handler: use int16_t

Use int16_t instead of int to store the autofp queue id. We should
not easily get to 32k threads so 2 bytes per flow is sufficient.

9 years agoflow: remove unused debug code
Victor Julien [Mon, 18 Apr 2016 14:26:18 +0000 (16:26 +0200)] 
flow: remove unused debug code

9 years agoflowint: redo tests
Victor Julien [Tue, 19 Apr 2016 09:38:25 +0000 (11:38 +0200)] 
flowint: redo tests

9 years agodetect: add missing sigorder case
Victor Julien [Tue, 19 Apr 2016 10:03:35 +0000 (12:03 +0200)] 
detect: add missing sigorder case

9 years agomodbus: fix AddressSanitizer error (segmentation fault) 2069/head
DIALLO David [Wed, 4 May 2016 07:58:01 +0000 (09:58 +0200)] 
modbus: fix AddressSanitizer error (segmentation fault)

In case of Mask Write register or Write single register request with
no data (malformed packet), app-layer-modbus checks response content
(data) with the none stored request content. That causes the segmentation
fault.

Before accessing to request content, app-layer-modbus checks now if
content has been previously stored. 4 unitests have been adding, 2 of them
to test the management of Mask Write register and Write single register requests,
and the 2 others to check invalid Mask Write register and Write single register
requests.

9 years agoipv6: fix alignment issue in address to string code
Victor Julien [Fri, 6 May 2016 13:18:57 +0000 (15:18 +0200)] 
ipv6: fix alignment issue in address to string code

9 years agoac-ks: fix integer handling issue
Victor Julien [Fri, 6 May 2016 13:13:21 +0000 (15:13 +0200)] 
ac-ks: fix integer handling issue

9 years agounittests: don't call memcpy on NULL-ptr
Victor Julien [Fri, 6 May 2016 13:12:29 +0000 (15:12 +0200)] 
unittests: don't call memcpy on NULL-ptr

9 years agopcre: initialize var before use
Victor Julien [Fri, 6 May 2016 13:10:42 +0000 (15:10 +0200)] 
pcre: initialize var before use

9 years agoyaml: minor cleanup
Victor Julien [Fri, 6 May 2016 13:09:52 +0000 (15:09 +0200)] 
yaml: minor cleanup

9 years agoyaml: initialize var to prevent uninitialized read
Victor Julien [Fri, 6 May 2016 13:09:36 +0000 (15:09 +0200)] 
yaml: initialize var to prevent uninitialized read

9 years agotcp sack: fix alignment issues
Victor Julien [Fri, 6 May 2016 13:04:07 +0000 (15:04 +0200)] 
tcp sack: fix alignment issues

9 years agosmb: improve integer handling
Victor Julien [Fri, 6 May 2016 13:00:10 +0000 (15:00 +0200)] 
smb: improve integer handling

9 years agodcerpc: improve integer handling
Victor Julien [Fri, 6 May 2016 12:57:55 +0000 (14:57 +0200)] 
dcerpc: improve integer handling