attach: move errno handling

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

attach: fix return value & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

af_unix: fix return value & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

lxccontainer: coding rules

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

confile_utils: fix return value & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2480 from brauner/2018-07-18/add_required_mount_flags

conf: the atime flags are locked in userns

Merge pull request #2481 from hwoarang/fix-apparmor-paths

apparmor: Allow /usr/lib* paths for mount and pivot_root

apparmor: Allow /usr/lib* paths for mount and pivot_root

openSUSE Leap 15 is using --libdir=/usr/lib64 when building for
x86_64 so we need to allow this path in the apparmor profiles.

Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1099239
Signed-off-by: Markos Chandras <mchandras@suse.de>

conf: the atime flags are locked in userns

This means they need to be added for remount and for fresh mounts.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2473 from tenforward/japanese

doc: Translate lxc.monitor.signal.pdeath into Japanese in lxc.contain…

doc: Translate lxc.monitor.signal.pdeath into Japanese in lxc.container.conf(5)

Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Merge pull request #2472 from brauner/2018-07-16/monitor_signal_pdeath

tests: add lxc.monitor.signal.pdeath

tests: add lxc.monitor.signal.pdeath

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2470 from brauner/2018-07-16/monitor_signal_pdeath

confile: add lxc.monitor.signal.pdeath

confile: add lxc.monitor.signal.pdeath

Set the signal to be sent to the container's init when the lxc monitor exits.
By default it is set to SIGKILL which will cause all container processes to be
killed when the lxc monitor process dies.
To ensure that containers stay alive even if lxc monitor dies set this to 0.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: move signal helpers to confile utils

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2469 from 2xsec/bugfix

tools: lxc-unshare: use lxc list for interface names

coverity: #1437949

Argument cannot be negative

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-unshare: use lxc list for interface names

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2468 from 2xsec/bugfix

tools: lxc-unshare: apply argument parser of lxc and log system of lxc

tools: lxc-unshare: fix wrong coding rules

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-unshare: apply argument parser of lxc and log system of lxc

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2466 from flx42/fix-define-argument

 confile: fix incorrect strncmp

confile: fix incorrect strncmp

Passing additional configuration options with "--define" was broken.

Result of git bisect:
d899f11b7bfb14c4b532bc801de89c8fb46307d4 is the first bad commit

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Merge pull request #2465 from 2xsec/bugfix

lxclock: change error log using strerror to SYSERROR

lxclock: change error log using strerror to SYSERROR

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2462 from brauner/2018-07-12/coverity

coverity

coverity: #1437935

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

coverity: #1437936

Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2459 from brauner/2018-07-11/cleanup_makefile

autotool fixes, attach cleanups

Merge pull request #2460 from brauner/2018-07-12/handle_new_mknod_smarter

conf: handle partially functional device nodes

attach: cleanup log messages in lxc_attach()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: use fd_cloexec()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: cleanup no_new_privs()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: cleanup fetch_seccomp()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: simplify lxc_attach_getpwshell()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: handle partially functional device nodes

This improves handling kernels which allow userspace to create partially
functional devices nodes.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2458 from 2xsec/bugfix

tools: lxc-ls: fix signed_to_bigger_unsigned issue

autotools: cleanup Makefile.am

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: lxc-ls: fix signed_to_bigger_unsigned issue

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2452 from brauner/2018-07-06/build_static_liblxc

static liblxc, always create /dev directory when autodev = 1, open("/dev/null") opportunistically

start: don't unconditionally open("/dev/null")

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: create /dev directory

If users specified lxc.autodev = 1 it does not make sense to skip setting up
autodev if /dev does not exist. We rather should create it.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

autotools: build both a shared and static liblxc

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Serge Hallyn <serge@hallyn.com>
Cc: Tycho Andersen <tycho@tycho.ws>

Merge pull request #2454 from 2xsec/bugfix

tools: lxc-unshare: replace write_id_mapping() to the same function in conf.c

tools: lxc-unshare: replace write_id_mapping() to the same function in conf.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2453 from 2xsec/bugfix

add namespace api

tools: lxc-unshare: replace converting standard identifiers of namespaces to api

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: lxc-attach: replace converting standard identifiers of namespaces to api

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

namespace: add api to convert namespaces to standard identifiers

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2451 from brauner/2018-07-06/bugfixes

bugfixes

tree-wide: set MSG_NOSIGNAL

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: declare int array const

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: refactor match_stdfds()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2450 from brauner/2018-07-05/use_mknod

conf: use mknod() to create dummy mount targets

terminal: don't garble output

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: use mknod() to create dummy mount targets

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2446 from brauner/2018-07-02/log_prefix

Logging and cgroup fixes

conf: use mknod() to create dummy mount target

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: safely retrieve path of slave device

openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: use fd_cloexec()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgfsng: respect lxc.cgroup.use

If lxc.cgroup.use is specified then only those controllers listed in there will
be used others will be skipped.

Closes #2447.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: remove is_crucial_cgroup_subsystem()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2448 from 2xsec/bugfix

log: remove the trailing .

log: remove the trailing .

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

log: cleanup

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: remove unneeded log prefixes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #2445 from 2xsec/bugfix

tests: cleanup source codes.

tests: cleanup state_server.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup startone.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup snapshot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup shutdowntest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup shortlived.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup saveconfig.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup reboot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: clenaup may_control.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup lxcpath.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup lxc_raw_clone.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup lxc-test-utils.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup locktests.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup list.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup getkeys.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup get_item.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup device_add_remove.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup destroytest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup criu_check_feature.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup createtest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup containertests.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup console.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup config_jump_table.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup concurrent.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup clonetest.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tests: cleanup api_reboot.c

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2444 from 2xsec/bugfix

utils: move recursive_destroy() from cfgsng to utils.

sync: modify error string

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

utils: move recursive_destroy() from cfgsng to utils.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2441 from 2xsec/coverity

coverity: #1425816

coverity: #1425816

Explicit null dereferenced

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Merge pull request #2440 from brauner/2018-06-30/console_fixes

terminal: security fixes

tests: remove duplicate file_exists() definition

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>