]> git.ipfire.org Git - thirdparty/unbound.git/log
thirdparty/unbound.git
4 years agoAdd missing prototype. 293/head
Florian Obser [Fri, 28 Aug 2020 15:31:14 +0000 (17:31 +0200)] 
Add missing prototype.

4 years ago- Review fix, doxygen and assign null in case of error free.
W.C.A. Wijngaards [Thu, 27 Aug 2020 13:27:05 +0000 (15:27 +0200)] 
- Review fix, doxygen and assign null in case of error free.

4 years agoPlease doxygen, quote the characters to stop it from parsing a doxygen command.
W.C.A. Wijngaards [Thu, 27 Aug 2020 13:12:46 +0000 (15:12 +0200)] 
Please doxygen, quote the characters to stop it from parsing a doxygen command.

4 years ago- Similar to NSD PR#113, implement that interface names can be used,
W.C.A. Wijngaards [Thu, 27 Aug 2020 12:53:33 +0000 (14:53 +0200)] 
- Similar to NSD PR#113, implement that interface names can be used,
  eg. something like interface: eth0 is resolved at server start and
  uses the IP addresses for that named interface.

4 years ago- Update documentation in python example code.
George Thessalonikefs [Wed, 26 Aug 2020 09:59:09 +0000 (11:59 +0200)] 
- Update documentation in python example code.

4 years ago- Change configure to use EVP_sha256 instead of HMAC_Update for
W.C.A. Wijngaards [Mon, 24 Aug 2020 14:13:42 +0000 (16:13 +0200)] 
- Change configure to use EVP_sha256 instead of HMAC_Update for
  openssl-3.0.0.

4 years ago- Fix to apply chroot to dnstap-socket-path, if chroot is enabled.
W.C.A. Wijngaards [Mon, 24 Aug 2020 12:55:16 +0000 (14:55 +0200)] 
- Fix to apply chroot to dnstap-socket-path, if chroot is enabled.

4 years ago- Fix that dnstap reconnects do not spam the log with the repeated
W.C.A. Wijngaards [Mon, 24 Aug 2020 07:23:36 +0000 (09:23 +0200)] 
- Fix that dnstap reconnects do not spam the log with the repeated
  attempts.  Attempts on the timer are only logged on high verbosity,
  if they produce a connection failure error.

4 years ago- Fix stats double count issue (#289).
Ralph Dolmans [Thu, 20 Aug 2020 15:54:28 +0000 (17:54 +0200)] 
- Fix stats double count issue (#289).

4 years ago- Create and init edns tags data for libunbound.
Ralph Dolmans [Thu, 13 Aug 2020 12:57:21 +0000 (14:57 +0200)] 
- Create and init edns tags data for libunbound.

4 years agoChangelog note.
W.C.A. Wijngaards [Mon, 10 Aug 2020 15:43:19 +0000 (17:43 +0200)] 
Changelog note.
- Rerun autoconf

4 years agoRerun autoconf and autoheader on configure.ac, with libtool
W.C.A. Wijngaards [Mon, 10 Aug 2020 15:42:41 +0000 (17:42 +0200)] 
Rerun autoconf and autoheader on configure.ac, with libtool

4 years agoAdd changlog entry for PR #277.
Ralph Dolmans [Mon, 10 Aug 2020 15:35:18 +0000 (17:35 +0200)] 
Add changlog entry for PR #277.

4 years agoMerge branch 'master' of github.com:NLnetLabs/unbound
Ralph Dolmans [Mon, 10 Aug 2020 15:32:00 +0000 (17:32 +0200)] 
Merge branch 'master' of github.com:NLnetLabs/unbound

4 years agoMerge branch 'ciz-openssl-3.0'
Ralph Dolmans [Mon, 10 Aug 2020 15:31:42 +0000 (17:31 +0200)] 
Merge branch 'ciz-openssl-3.0'

4 years ago - Check for existence 'EVP_MAC_CTX_set_params' function (openssl >=
Ralph Dolmans [Mon, 10 Aug 2020 15:29:06 +0000 (17:29 +0200)] 
 - Check for existence 'EVP_MAC_CTX_set_params' function (openssl >=
   3.0.0-alpha5)

4 years ago- Fix #287: doc typo: "Additionaly".
W.C.A. Wijngaards [Mon, 10 Aug 2020 06:15:06 +0000 (08:15 +0200)] 
- Fix #287: doc typo: "Additionaly".

4 years agoMerge branch 'openssl-3.0' of https://github.com/ciz/unbound into ciz-openssl-3.0
Ralph Dolmans [Thu, 6 Aug 2020 15:27:27 +0000 (17:27 +0200)] 
Merge branch 'openssl-3.0' of https://github.com/ciz/unbound into ciz-openssl-3.0

4 years agoChangelog note for #246 and #284
W.C.A. Wijngaards [Thu, 6 Aug 2020 12:23:33 +0000 (14:23 +0200)] 
Changelog note for #246 and #284
- Merge PR #284 and Fix #246: Remove DLV entirely from Unbound.
  The DLV has been decommisioned and in unbound 1.5.4, in 2015, there
  was advise to stop using it.  The current code base does not contain
  DLV code any more.  The use of dlv options displays a warning.

4 years agoMerge pull request #284 from NLnetLabs/dlv-removal
Wouter Wijngaards [Thu, 6 Aug 2020 12:21:19 +0000 (14:21 +0200)] 
Merge pull request #284 from NLnetLabs/dlv-removal

DLV removal

4 years agoMerge branch 'master' into dlv-removal 284/head
W.C.A. Wijngaards [Thu, 6 Aug 2020 12:20:42 +0000 (14:20 +0200)] 
Merge branch 'master' into dlv-removal

4 years agodlv removal, remove DLV reference from unused use in test case.
W.C.A. Wijngaards [Thu, 6 Aug 2020 12:18:16 +0000 (14:18 +0200)] 
dlv removal, remove DLV reference from unused use in test case.

4 years agodlv removal, free unused variable.
W.C.A. Wijngaards [Thu, 6 Aug 2020 06:14:14 +0000 (08:14 +0200)] 
dlv removal, free unused variable.

4 years ago- contrib/aaaa-filter-iterator.patch file renewed diff content to
W.C.A. Wijngaards [Wed, 5 Aug 2020 14:33:48 +0000 (16:33 +0200)] 
- contrib/aaaa-filter-iterator.patch file renewed diff content to
  apply cleanly to the current coderepo for the current code version.

4 years ago- Changelog entry for EDNS client tag functionality
Ralph Dolmans [Wed, 5 Aug 2020 14:10:10 +0000 (16:10 +0200)] 
- Changelog entry for EDNS client tag functionality

4 years agoMerge pull request #272 from NLnetLabs/edns-client-tag
Ralph Dolmans [Wed, 5 Aug 2020 14:07:49 +0000 (16:07 +0200)] 
Merge pull request #272 from NLnetLabs/edns-client-tag

Add EDNS client tag functionality

4 years ago- Process EDNS client tag review feedback 272/head
Ralph Dolmans [Wed, 5 Aug 2020 13:56:45 +0000 (15:56 +0200)] 
- Process EDNS client tag review feedback

4 years agodlv removal, remove DLV references from man page and pythonmod interface.
W.C.A. Wijngaards [Wed, 5 Aug 2020 08:25:56 +0000 (10:25 +0200)] 
dlv removal, remove DLV references from man page and pythonmod interface.

4 years agodlv removal, remove from comments and unused code in iterator and validator
W.C.A. Wijngaards [Tue, 4 Aug 2020 15:17:48 +0000 (17:17 +0200)] 
dlv removal, remove from comments and unused code in iterator and validator

4 years ago- Merge PR #280, Make tvOS & watchOS checks verify
George Thessalonikefs [Tue, 4 Aug 2020 14:34:55 +0000 (16:34 +0200)] 
- Merge PR #280, Make tvOS & watchOS checks verify
  truthiness as well as definedness, by Felipe Gasper (fixes #279).

4 years agoMerge branch 'issue_279_have_fork_macos' of https://github.com/FGasper/unbound into...
George Thessalonikefs [Tue, 4 Aug 2020 14:33:33 +0000 (16:33 +0200)] 
Merge branch 'issue_279_have_fork_macos' of https://github.com/FGasper/unbound into FGasper-issue_279_have_fork_macos

4 years ago- Improve error log message when inserting rpz RR.
George Thessalonikefs [Tue, 4 Aug 2020 10:49:43 +0000 (12:49 +0200)] 
- Improve error log message when inserting rpz RR.

4 years agodlv removal, remove from tests and validator state machine
W.C.A. Wijngaards [Tue, 4 Aug 2020 07:15:45 +0000 (09:15 +0200)] 
dlv removal, remove from tests and validator state machine

4 years agoDLV removal
W.C.A. Wijngaards [Tue, 4 Aug 2020 07:05:09 +0000 (09:05 +0200)] 
DLV removal

4 years ago- Fix mini_event.h on OpenBSD cannot find fd_set.
W.C.A. Wijngaards [Tue, 4 Aug 2020 06:14:25 +0000 (08:14 +0200)] 
- Fix mini_event.h on OpenBSD cannot find fd_set.

4 years agoMake tvOS & watchOS checks verify truthiness as well as definedness. 280/head
Felipe Gasper [Mon, 3 Aug 2020 18:37:00 +0000 (14:37 -0400)] 
Make tvOS & watchOS checks verify truthiness as well as definedness.

4 years agonet_help: Rename EVP_MAC_set_ctx_params to EVP_MAC_CTX_set_params 277/head
Vitezslav Cizek [Fri, 31 Jul 2020 12:44:05 +0000 (14:44 +0200)] 
net_help: Rename EVP_MAC_set_ctx_params to EVP_MAC_CTX_set_params

This fixes build with OpenSSL 3.0.0 Alpha 5.
EVP_MAC_set_ctx_params got renamed back to EVP_MAC_CTX_set_params
in https://github.com/openssl/openssl/pull/12186

4 years ago- Fix doxygen comment for no ssl for tls session ticket key callback
W.C.A. Wijngaards [Fri, 31 Jul 2020 07:10:40 +0000 (09:10 +0200)] 
- Fix doxygen comment for no ssl for tls session ticket key callback
  routine.

4 years agoMerge branch 'master' into edns-client-tag
Ralph Dolmans [Mon, 27 Jul 2020 13:54:58 +0000 (15:54 +0200)] 
Merge branch 'master' into edns-client-tag

4 years ago- Add EDNS client tag test
Ralph Dolmans [Mon, 27 Jul 2020 13:54:43 +0000 (15:54 +0200)] 
- Add EDNS client tag test

5 years ago- Merge PR #268, draft-ietf-dnsop-serve-stale-10 has become RFC 8767 on
George Thessalonikefs [Mon, 27 Jul 2020 11:08:08 +0000 (13:08 +0200)] 
- Merge PR #268, draft-ietf-dnsop-serve-stale-10 has become RFC 8767 on
March 2020, by and0x000.

5 years agoMerge branch 'master' of https://github.com/and0x000/unbound into and0x000-master
George Thessalonikefs [Mon, 27 Jul 2020 11:07:19 +0000 (13:07 +0200)] 
Merge branch 'master' of https://github.com/and0x000/unbound into and0x000-master

5 years agoChangelog note for PR #270
W.C.A. Wijngaards [Mon, 27 Jul 2020 11:02:47 +0000 (13:02 +0200)] 
Changelog note for PR #270
- Merge PR #270 from cgzones: munin plugin: always exit 0 in autoconf

5 years agoMerge pull request #270 from cgzones/munin
Wouter Wijngaards [Mon, 27 Jul 2020 11:02:30 +0000 (13:02 +0200)] 
Merge pull request #270 from cgzones/munin

munin plugin: always exit 0 in autoconf

5 years agoMerge branch 'master' of github.com:NLnetLabs/unbound
Ralph Dolmans [Mon, 27 Jul 2020 10:14:41 +0000 (12:14 +0200)] 
Merge branch 'master' of github.com:NLnetLabs/unbound

5 years ago- Merge PR #269, Fix python module len() implementations, by Torbjörn Lönnemark
Ralph Dolmans [Mon, 27 Jul 2020 10:14:08 +0000 (12:14 +0200)] 
- Merge PR #269, Fix python module len() implementations, by Torbjörn Lönnemark

5 years agoMerge pull request #269 from tobbez/python-fix-len
Ralph Dolmans [Mon, 27 Jul 2020 10:12:31 +0000 (12:12 +0200)] 
Merge pull request #269 from tobbez/python-fix-len

Fix python module len() implementations

5 years ago- branch now named 1.11.1. 1.11.0rc1 became the 1.11.0 release.
W.C.A. Wijngaards [Mon, 27 Jul 2020 10:10:28 +0000 (12:10 +0200)] 
- branch now named 1.11.1.  1.11.0rc1 became the 1.11.0 release.

5 years agoEDNS client tags - insert configured tags into tree
Ralph Dolmans [Fri, 24 Jul 2020 14:00:13 +0000 (16:00 +0200)] 
EDNS client tags - insert configured tags into tree

5 years agoAdd edns-client-tag configuration option
Ralph Dolmans [Fri, 24 Jul 2020 12:52:04 +0000 (14:52 +0200)] 
Add edns-client-tag configuration option

5 years agoStart of EDNS client tags implementation.
Ralph Dolmans [Thu, 23 Jul 2020 15:17:44 +0000 (17:17 +0200)] 
Start of EDNS client tags implementation.

5 years agomunin plugin: always exit 0 in autoconf 270/head
Christian Göttsche [Thu, 23 Jul 2020 14:04:26 +0000 (16:04 +0200)] 
munin plugin: always exit 0 in autoconf

The autoconf operation should always exit 0, also in case the answer in "no",
see https://guide.munin-monitoring.org/en/latest/develop/plugins/plugin-concise.html#autoconf

5 years agoFix python module len() implementations 269/head
Torbjörn Lönnemark [Wed, 22 Jul 2020 01:05:19 +0000 (03:05 +0200)] 
Fix python module len() implementations

They were all missing the 'self.' prefix when accessing the 'obj'
instance variable, causing the following exception when attempting to
call len() on (for example) a ReplyInfo_RRSet:

  File "/usr/lib/python3.7/site-packages/unboundmodule.py", line 377, in __len__
    def __len__(self): return obj.rrset_count
NameError: name 'obj' is not defined

5 years agodraft-ietf-dnsop-serve-stale-10 has become RFC 8767 on March 2020 268/head
and0x000 [Mon, 20 Jul 2020 16:10:21 +0000 (18:10 +0200)] 
draft-ietf-dnsop-serve-stale-10 has become RFC 8767 on March 2020

5 years ago- branch now named 1.11.0 and 1.11.0rc1 tag. release-1.11.0 release-1.11.0rc1
W.C.A. Wijngaards [Mon, 20 Jul 2020 11:02:09 +0000 (13:02 +0200)] 
- branch now named 1.11.0 and 1.11.0rc1 tag.

5 years ago- Fix contrib/fastrpz.patch to apply cleanly. It fixes for changes
W.C.A. Wijngaards [Mon, 20 Jul 2020 09:05:28 +0000 (11:05 +0200)] 
- Fix contrib/fastrpz.patch to apply cleanly.  It fixes for changes
  due to added libdynmod, but it does not compile, it conflicts with
  new rpz code.

5 years ago- Fix contrib/fastrpz.patch to apply cleanly.
W.C.A. Wijngaards [Mon, 20 Jul 2020 08:55:13 +0000 (10:55 +0200)] 
- Fix contrib/fastrpz.patch to apply cleanly.

5 years ago- Fix contrib/fastrpz.patch to apply cleanly.
W.C.A. Wijngaards [Mon, 20 Jul 2020 08:53:30 +0000 (10:53 +0200)] 
- Fix contrib/fastrpz.patch to apply cleanly.

5 years ago- Fix streamtcp to print packet data to stdout. This makes the
W.C.A. Wijngaards [Mon, 20 Jul 2020 08:34:40 +0000 (10:34 +0200)] 
- Fix streamtcp to print packet data to stdout.  This makes the
  stdout and stderr not mix together lines, when parsing its output.

5 years ago- Fix lock dependency cycle in rpz zone config setup.
W.C.A. Wijngaards [Fri, 17 Jul 2020 15:15:55 +0000 (17:15 +0200)] 
- Fix lock dependency cycle in rpz zone config setup.

5 years ago- Fix libnettle compile for session ticket key callback function
W.C.A. Wijngaards [Fri, 17 Jul 2020 14:53:52 +0000 (16:53 +0200)] 
- Fix libnettle compile for session ticket key callback function
  changes.

5 years agoMerge branch 'jcourreges-align-cmsg-buffers'
Ralph Dolmans [Fri, 17 Jul 2020 11:07:49 +0000 (13:07 +0200)] 
Merge branch 'jcourreges-align-cmsg-buffers'

5 years ago- Merge PR #234 - Ensure proper alignment of cmsg buffers by Jérémie
Ralph Dolmans [Fri, 17 Jul 2020 11:07:03 +0000 (13:07 +0200)] 
- Merge PR #234 - Ensure proper alignment of cmsg buffers by Jérémie
  Courrèges-Anglas.
- Fix PR #234 log_assert sizeof to use union buffer.

5 years agoMerge branch 'align-cmsg-buffers' of https://github.com/jcourreges/unbound into jcour...
Ralph Dolmans [Fri, 17 Jul 2020 11:01:44 +0000 (13:01 +0200)] 
Merge branch 'align-cmsg-buffers' of https://github.com/jcourreges/unbound into jcourreges-align-cmsg-buffers

5 years ago- Fix unused variable warning for clang analyzer.
W.C.A. Wijngaards [Thu, 16 Jul 2020 13:41:25 +0000 (15:41 +0200)] 
- Fix unused variable warning for clang analyzer.

5 years ago- Fix check conf test for referencing installation paths.
W.C.A. Wijngaards [Thu, 16 Jul 2020 12:47:15 +0000 (14:47 +0200)] 
- Fix check conf test for referencing installation paths.

5 years ago- Changelog entry for PR #265; include-toplevel.
George Thessalonikefs [Thu, 16 Jul 2020 11:01:14 +0000 (13:01 +0200)] 
- Changelog entry for PR #265; include-toplevel.

5 years agoMerge pull request #265 from NLnetLabs/include-toplevel
gthess [Thu, 16 Jul 2020 10:57:42 +0000 (12:57 +0200)] 
Merge pull request #265 from NLnetLabs/include-toplevel

Introduce include-toplevel configuration option; closes #161.

5 years agoMerge branch 'master' into include-toplevel 265/head
George Thessalonikefs [Thu, 16 Jul 2020 10:53:29 +0000 (12:53 +0200)] 
Merge branch 'master' into include-toplevel

5 years agoChange unbound-dnstap-socket void cast for unused parameter
Ralph Dolmans [Thu, 16 Jul 2020 10:31:30 +0000 (12:31 +0200)] 
Change unbound-dnstap-socket void cast for unused parameter

5 years ago- Add changelog entry for bidirectional frame streams support.
Ralph Dolmans [Thu, 16 Jul 2020 09:45:10 +0000 (11:45 +0200)] 
- Add changelog entry for bidirectional frame streams support.

5 years agoMerge pull request #264 from NLnetLabs/fstrm-bidi
Ralph Dolmans [Thu, 16 Jul 2020 09:42:29 +0000 (11:42 +0200)] 
Merge pull request #264 from NLnetLabs/fstrm-bidi

Bidirectional frame streams support

5 years agocorrect byte count in comment 264/head
Ralph Dolmans [Thu, 16 Jul 2020 08:54:18 +0000 (10:54 +0200)] 
correct byte count in comment

5 years agoremove unused define
Ralph Dolmans [Wed, 15 Jul 2020 21:01:13 +0000 (23:01 +0200)] 
remove unused define

5 years agodnstap log message typo fix
Ralph Dolmans [Wed, 15 Jul 2020 15:33:48 +0000 (17:33 +0200)] 
dnstap log message typo fix

5 years agoLog dnstap connection close due to unknown content type.
Ralph Dolmans [Wed, 15 Jul 2020 15:31:18 +0000 (17:31 +0200)] 
Log dnstap connection close due to unknown content type.

5 years ago- Ignore unknown frame streams control fields.
Ralph Dolmans [Wed, 15 Jul 2020 15:16:14 +0000 (17:16 +0200)] 
- Ignore unknown frame streams control fields.

5 years ago- Handle SSL_ERROR_WANT_WRITE on SSL_read for negotiation
Ralph Dolmans [Wed, 15 Jul 2020 13:49:42 +0000 (15:49 +0200)] 
- Handle SSL_ERROR_WANT_WRITE on SSL_read for negotiation
- Close connection when receiving overly large frame

5 years agoMerge branch 'master' into include-toplevel
George Thessalonikefs [Wed, 15 Jul 2020 13:17:48 +0000 (15:17 +0200)] 
Merge branch 'master' into include-toplevel

5 years agoAdd maximum to received frame streams frames.
Ralph Dolmans [Tue, 14 Jul 2020 12:29:09 +0000 (14:29 +0200)] 
Add maximum to received frame streams frames.

5 years agoMerge branch 'master' into fstrm-bidi
Ralph Dolmans [Mon, 13 Jul 2020 15:30:36 +0000 (17:30 +0200)] 
Merge branch 'master' into fstrm-bidi

5 years ago- Add option to send DNSTAP messages over bidirectional frame streams
Ralph Dolmans [Mon, 13 Jul 2020 15:28:50 +0000 (17:28 +0200)] 
- Add option to send DNSTAP messages over bidirectional frame streams

5 years ago- Fix to use SSL_CTX_set_tlsext_ticket_key_evp_cb in OpenSSL
W.C.A. Wijngaards [Wed, 8 Jul 2020 14:22:39 +0000 (16:22 +0200)] 
- Fix to use SSL_CTX_set_tlsext_ticket_key_evp_cb in OpenSSL
  3.0.0-alpha4.
- Longer keys for the test set, this avoids weak crypto errors.

5 years ago- Fix add missing DSA header, for compilation without deprecated
W.C.A. Wijngaards [Wed, 8 Jul 2020 09:43:50 +0000 (11:43 +0200)] 
- Fix add missing DSA header, for compilation without deprecated
  OpenSSL APIs.

5 years ago- Review fixes for checkconf #259 change.
W.C.A. Wijngaards [Tue, 7 Jul 2020 08:18:56 +0000 (10:18 +0200)] 
- Review fixes for checkconf #259 change.

5 years ago- Fix #259: Fix unbound-checkconf does not check view existence.
W.C.A. Wijngaards [Tue, 7 Jul 2020 07:00:04 +0000 (09:00 +0200)] 
- Fix #259: Fix unbound-checkconf does not check view existence.
  unbound-checkconf checks access-control-view, access-control-tags,
  access-control-tag-actions and access-control-tag-datas.
- Fix offset of error printout for access-control-tag-datas.

5 years ago- run_vm cleanup better and removes trailing slash on single argument.
W.C.A. Wijngaards [Mon, 6 Jul 2020 09:33:07 +0000 (11:33 +0200)] 
- run_vm cleanup better and removes trailing slash on single argument.

5 years ago- Fix tcp req info drop due to size call into mesh accounting
W.C.A. Wijngaards [Tue, 30 Jun 2020 15:22:43 +0000 (17:22 +0200)] 
- Fix tcp req info drop due to size call into mesh accounting
  removal of mesh state during mesh send reply.

5 years ago- Review fix for number of detached states due to use of variable
W.C.A. Wijngaards [Tue, 30 Jun 2020 14:35:48 +0000 (16:35 +0200)] 
- Review fix for number of detached states due to use of variable
  after end of loop.

5 years ago- Fix for mesh accounting when rpz decides to drop a reply with a
W.C.A. Wijngaards [Tue, 30 Jun 2020 14:20:09 +0000 (16:20 +0200)] 
- Fix for mesh accounting when rpz decides to drop a reply with a
  tcp stream waiting for it.

5 years ago- Also move reply list clean for mesh callbacks to the scrip callback
W.C.A. Wijngaards [Tue, 30 Jun 2020 13:48:11 +0000 (15:48 +0200)] 
- Also move reply list clean for mesh callbacks to the scrip callback
  can see the reply_info.
- Fix for mesh accounting if the reply list already empty to begin
  with.

5 years ago- Move reply list clean for serve expired mesh callback to after
W.C.A. Wijngaards [Tue, 30 Jun 2020 11:41:26 +0000 (13:41 +0200)] 
- Move reply list clean for serve expired mesh callback to after
  the reply is sent, so that script callbacks have reply_info.

5 years ago- doxygen file comments for dynlibmodule.
W.C.A. Wijngaards [Wed, 24 Jun 2020 11:37:43 +0000 (13:37 +0200)] 
- doxygen file comments for dynlibmodule.

5 years ago- iana portlist updated.
W.C.A. Wijngaards [Wed, 24 Jun 2020 11:33:47 +0000 (13:33 +0200)] 
- iana portlist updated.

5 years ago- Fix display of event loop method with libev.
W.C.A. Wijngaards [Wed, 17 Jun 2020 12:32:57 +0000 (14:32 +0200)] 
- Fix display of event loop method with libev.

5 years ago- Fix default explanation in man page for qname-minimisation-strict.
W.C.A. Wijngaards [Wed, 17 Jun 2020 06:20:52 +0000 (08:20 +0200)] 
- Fix default explanation in man page for qname-minimisation-strict.

5 years ago- Mention tls name possible when tls is enabled for stub-addr in the
W.C.A. Wijngaards [Mon, 8 Jun 2020 06:35:10 +0000 (08:35 +0200)] 
- Mention tls name possible when tls is enabled for stub-addr in the
  man page.

5 years ago- Changelog entry for PR #241.
George Thessalonikefs [Wed, 27 May 2020 16:25:29 +0000 (18:25 +0200)] 
- Changelog entry for PR #241.

5 years agoMerge pull request #241 from edmonds/edmonds/libunbound.pc/do-not-use-requires
gthess [Wed, 27 May 2020 16:21:05 +0000 (18:21 +0200)] 
Merge pull request #241 from edmonds/edmonds/libunbound.pc/do-not-use-requires

contrib/libunbound.pc.in: Do not use "Requires:"

5 years agocontrib/libunbound.pc.in: Do not use "Requires:" 241/head
Robert Edmonds [Mon, 25 May 2020 21:58:37 +0000 (17:58 -0400)] 
contrib/libunbound.pc.in: Do not use "Requires:"

This commit updates contrib/libunbound.pc.in to remove the "Requires:"
directive and move its contents to "Requires.private:".

The pkg-config manpage documents the Requires/Libs fields as follows:

   Requires:
          This is a comma-separated list of packages that are required  by
          your package. Flags from dependent packages will be merged in to
          the flags reported for your package. Optionally, you can specify
          the  version  of the required package (using the operators =, <,
          >, >=, <=); specifying a version allows  pkg-config  to  perform
          extra  sanity  checks. You may only mention the same package one
          time on the Requires: line. If the version of a package  is  un‐
          specified, any version will be used with no checking.

   Requires.private:
          A list of packages required by this package. The difference from
          Requires is that the packages listed under Requires.private  are
          not  taken into account when a flag list is computed for dynami‐
          cally linked executable (i.e., when --static was not specified).
          In  the  situation where each .pc file corresponds to a library,
          Requires.private shall be used exclusively to specify the depen‐
          dencies between the libraries.

   Libs:  This  line  should give the link flags specific to your package.
          Don't add any flags for required packages; pkg-config  will  add
          those automatically.

   Libs.private:
          This line should list any private libraries in use.  Private li‐
          braries are libraries which are not  exposed  through  your  li‐
          brary,  but  are needed in the case of static linking. This dif‐
          fers from Requires.private in that it references libraries  that
          do not have package files installed.

In other words:

1) "Requires:" should specify the name of .pc packages that are required
to be installed to compile and dynamically link against libunbound. This
corresponds to needing the -dev (or -devel) package containing the .pc
file to be installed on the system. Since libunbound's header files
actually do not have any includes on any other library's headers, the
"Requires:" directive should be empty.

2) "Requires.private:" specifies the name of .pc packages that
correspond to libraries that are required to be installed to statically
link against libunbound. E.g., if libunbound.a has undefined symbols
event_* that are in libevent.a, statically linking against libunbound.a
requires statically linking libevent.a, and because libevent has a .pc
file, this means "libevent" should appear in libunbound.pc's
"Requires.private:" directive.

3) "Libs:" specifies the link flags needed to link against libunbound,
only, not including any dependencies.

4) "Libs.private:" specifies the link flags needed to statically link
against libraries that libunbound depends on that do not have .pc files.
I think it's possible for unbound's build system to actually declare
link flags under "Libs.private:" for some libraries that do have .pc
files (e.g. libcrypto/-lcrypto, libssl/-lssl, for OpenSSL) but in
practice this appears to be harmless.

Given #1 above that libunbound does not have any header dependencies
against any other packages it does not appear that "Requires:" is needed
at all. See https://bugs.debian.org/958331 for an example of a bug
report that this causes. We should not need to install the nettle-dev
package only for building binaries that compile against the libunbound
headers and link against the libunbound library.