Ruben Kerkhof [Wed, 20 Feb 2019 10:22:30 +0000 (11:22 +0100)]
turbostat plugin: fix two compiler warnings
src/turbostat.c:1466:5: warning: no previous prototype for function 'save_affinity' [-Wmissing-prototypes]
int save_affinity(void) {
^
src/turbostat.c:1479:6: warning: no previous prototype for function 'restore_affinity' [-Wmissing-prototypes]
void restore_affinity(void) {
^
Ruben Kerkhof [Tue, 19 Feb 2019 17:53:19 +0000 (18:53 +0100)]
sensu plugin: fix compiler warning when build with --enable-debug
In file included from src/write_sensu.c:31:
src/write_sensu.c: In function ‘sensu_config’:
./src/daemon/plugin.h:398:20: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
398 | #define DEBUG(...) plugin_log(LOG_DEBUG, __VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/write_sensu.c:1227:7: note: in expansion of macro ‘DEBUG’
1227 | DEBUG("write_sensu plugin: Got tag: %s", tmp);
| ^~~~~
src/write_sensu.c:1227:43: note: format string is defined here
1227 | DEBUG("write_sensu plugin: Got tag: %s", tmp);
|
Ruben Kerkhof [Tue, 19 Feb 2019 17:27:46 +0000 (18:27 +0100)]
Don't hide errors when creating manpage
Apparently the default behaviour for pod2man changed at some point and
now it exits with a syntax error instead of exiting successfully with a
<POD ERRORS> section.
Now we do display the syntax issue:
[ruben@localhost collectd]$ make -j
POD2MAN src/collectd.conf.5
src/collectd.conf.pod around line 10361: You forgot a '=back' before '=head2'
POD document had syntax errors at /usr/bin/pod2man line 69.
make: *** [Makefile:9641: src/collectd.conf.5] Error 255
Ruben Kerkhof [Tue, 19 Feb 2019 10:58:26 +0000 (11:58 +0100)]
Reduce the nr of allocations when parsing types.db
We allocate a number of times for each line in types.db.
Since plugin_register_dataset() makes a copy of the dataset anyway, we
can create the dataset on the stack instead of the heap.
This reduces the number of calloc calls on my system from 624 to 337
when running collectd -T with the default types.db.
Ruben Kerkhof [Tue, 19 Feb 2019 09:57:03 +0000 (10:57 +0100)]
lua plugin: cleanup properly when shutting down
Found while running collectd -T under valgrind:
==25971== 75 (64 direct, 11 indirect) bytes in 1 blocks are definitely lost in loss record 154 of 274
==25971== at 0x483AB1A: calloc (vg_replace_malloc.c:762)
==25971== by 0x4854009: lua_cb_register_read (lua.c:288)
==25971== by 0x4FBE886: ???
==25971== by 0x4FD4900: ???
==25971== by 0x4FBEAD7: ???
==25971== by 0x4FBEB04: ???
==25971== by 0x4FBDF16: ???
==25971== by 0x4FBEE5E: ???
==25971== by 0x4FB53ED: ???
==25971== by 0x48536E7: lua_script_load (lua.c:465)
==25971== by 0x485387E: lua_config_script (lua.c:532)
==25971== by 0x485395E: lua_config (lua.c:557)
Ruben Kerkhof [Fri, 14 Dec 2018 16:27:44 +0000 (17:27 +0100)]
libcollectdclient: fix gcc warning
make[1]: Entering directory '/home/ruben/src/collectd'
CC src/libcollectdclient/libcollectdclient_la-network_parse.lo
In function ‘parse_string’,
inlined from ‘parse_identifier’ at src/libcollectdclient/network_parse.c:169:7,
inlined from ‘network_parse.constprop’ at src/libcollectdclient/network_parse.c:540:11:
src/libcollectdclient/network_parse.c:161:3: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
strncpy(out, in, out_size);
^~~~~~~~~~~~~~~~~~~~~~~~~~
Chris Mayo [Wed, 30 Jan 2019 20:22:47 +0000 (20:22 +0000)]
collection3: Improve index.cgi form fieldset border style
- Fit to the form contents instead of filling the page width
- Relate better to the table below by aligning the left-hand side and
increasing the space between
Manoj Srivastava [Thu, 17 Jan 2019 19:08:56 +0000 (11:08 -0800)]
[python-3.7-fix]: Allow compilation with Python 3.7
PyOS_AfterFork() is deprecated in favour of the new functions
PyOS_BeforeFork(), PyOS_AfterFork_Parent() and
PyOS_AfterFork_Child(). (Contributed by Antoine Pitrou in bpo-16500.)
Since the -Werror=deprecated-declarations flag is on, the fact that
PyOS_AfterFork is deprecated now results in a warning, and since all
warnings being treated as errors, collectd fails to compile.
This commit detects when we have python 3.7 or newer, and uses the new
replacement function.
Pavel Rochnyack [Mon, 7 May 2018 15:53:23 +0000 (22:53 +0700)]
netlink plugin: Use of less strict rules in link_filter_cb()
mnl_attr_validate2() function implements strict equality check of kernel and
userspace structures size. Additional counters was added to 4.6 Linux kernel,
sizes was changed and mismatch can occur.
This patch weakened validation.
Now Collectd just checks if structures, received from kernel space, has enough
data.
projects / thirdparty / collectd.git / log
