]> git.ipfire.org Git - thirdparty/lxc.git/log
thirdparty/lxc.git
5 years agoseccomp: remove seccomp fd from event loop after task exited 3499/head
Christian Brauner [Mon, 27 Jul 2020 08:12:16 +0000 (10:12 +0200)] 
seccomp: remove seccomp fd from event loop after task exited

Linux v5.8 will land my patch where seccomp notifies when a filter goes unused,
i.e. when the last task using a given seccomp filter has exited. This wasn't
possible before and so we accumulated file descriptors in the container's event
loop whenever we attached to the container.
I'm not sure whether the task exiting before we could handle its syscall should
cause us to report and error or not. For now, let's simply close the event loop
and not report an error.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3498 from brauner/master
Stéphane Graber [Sat, 25 Jul 2020 16:49:14 +0000 (12:49 -0400)] 
Merge pull request #3498 from brauner/master

selinux: remove security_context_t usage as it's deprecated

5 years agoselinux: remove security_context_t usage as it's deprecated 3498/head
Christian Brauner [Sat, 25 Jul 2020 09:36:46 +0000 (11:36 +0200)] 
selinux: remove security_context_t usage as it's deprecated

Link: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1888705
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3497 from brauner/2020-07-23/fix_snap_compilation
Stéphane Graber [Thu, 23 Jul 2020 16:52:37 +0000 (12:52 -0400)] 
Merge pull request #3497 from brauner/2020-07-23/fix_snap_compilation

autotools: fix Makefile

5 years agoMerge pull request #3496 from brauner/2020-07-18/mount_pid
Stéphane Graber [Thu, 23 Jul 2020 14:34:36 +0000 (10:34 -0400)] 
Merge pull request #3496 from brauner/2020-07-18/mount_pid

new mount api support: basics

5 years agoMakefile: fix Makefile 3497/head
Christian Brauner [Thu, 23 Jul 2020 08:33:33 +0000 (10:33 +0200)] 
Makefile: fix Makefile

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agolog: don't break logging by hiding symbols 3496/head
Christian Brauner [Wed, 22 Jul 2020 10:04:52 +0000 (12:04 +0200)] 
log: don't break logging by hiding symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoattach: use new mount api
Christian Brauner [Wed, 22 Jul 2020 09:47:21 +0000 (11:47 +0200)] 
attach: use new mount api

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agomount_utils: add mount_filesystem() helper
Christian Brauner [Wed, 22 Jul 2020 09:45:15 +0000 (11:45 +0200)] 
mount_utils: add mount_filesystem() helper

that translates between the two mount apis.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agomount_utils: add mount utils
Christian Brauner [Wed, 22 Jul 2020 09:32:28 +0000 (11:32 +0200)] 
mount_utils: add mount utils

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agosyscalls: add fsmount()
Christian Brauner [Wed, 22 Jul 2020 09:02:33 +0000 (11:02 +0200)] 
syscalls: add fsmount()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agosyscalls: add fsconfig()
Christian Brauner [Wed, 22 Jul 2020 08:59:49 +0000 (10:59 +0200)] 
syscalls: add fsconfig()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agosyscalls: add fspick()
Christian Brauner [Wed, 22 Jul 2020 08:54:12 +0000 (10:54 +0200)] 
syscalls: add fspick()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agosyscalls: add fsopen()
Christian Brauner [Wed, 22 Jul 2020 08:50:20 +0000 (10:50 +0200)] 
syscalls: add fsopen()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3492 from brauner/2020-07-18/visibility_hidden
Stéphane Graber [Wed, 22 Jul 2020 18:39:53 +0000 (14:39 -0400)] 
Merge pull request #3492 from brauner/2020-07-18/visibility_hidden

tree-wide: hide unnecessary symbols

5 years agoMerge pull request #3495 from siv0/boot_id_remount_apparmor_fix
Stéphane Graber [Wed, 22 Jul 2020 17:05:49 +0000 (13:05 -0400)] 
Merge pull request #3495 from siv0/boot_id_remount_apparmor_fix

apparmor: Allow ro remount of boot_id

5 years agoapparmor: Allow ro remount of boot_id 3495/head
Stoiko Ivanov [Wed, 22 Jul 2020 10:17:24 +0000 (12:17 +0200)] 
apparmor: Allow ro remount of boot_id

The rule added in 863845075d3f77d27c91bd9f47d2f8ddc4867bd5 did not cover all
necessary mount calls for /proc/sys/kernel/random/boot_id
(in src/lxc/conf.c: lxc_setup_boot_id) - the ro remount is missing.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
5 years agostart: simplify gotos 3492/head
Christian Brauner [Wed, 22 Jul 2020 08:46:05 +0000 (10:46 +0200)] 
start: simplify gotos

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agotree-wide: hide further unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 12:50:38 +0000 (14:50 +0200)] 
tree-wide: hide further unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agostorage: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 11:57:16 +0000 (13:57 +0200)] 
storage: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoarguments: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 11:45:37 +0000 (13:45 +0200)] 
arguments: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agolsm: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 11:40:57 +0000 (13:40 +0200)] 
lsm: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocgroups: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 11:28:08 +0000 (13:28 +0200)] 
cgroups: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agouuid: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 11:19:03 +0000 (13:19 +0200)] 
uuid: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoutils: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 11:15:25 +0000 (13:15 +0200)] 
utils: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoterminal: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 10:44:09 +0000 (12:44 +0200)] 
terminal: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agosync: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 10:37:28 +0000 (12:37 +0200)] 
sync: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agostate: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 10:30:53 +0000 (12:30 +0200)] 
state: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agostart: hide unnecessary symbols
Christian Brauner [Tue, 21 Jul 2020 10:24:45 +0000 (12:24 +0200)] 
start: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoringbuf: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:49:55 +0000 (18:49 +0200)] 
ringbuf: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agorexec: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:46:13 +0000 (18:46 +0200)] 
rexec: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoprocess_utils: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:45:02 +0000 (18:45 +0200)] 
process_utils: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoparse: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:38:05 +0000 (18:38 +0200)] 
parse: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agonetwork: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:25:57 +0000 (18:25 +0200)] 
network: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agonamespace: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:11:02 +0000 (18:11 +0200)] 
namespace: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agomonitor: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 16:09:19 +0000 (18:09 +0200)] 
monitor: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agomainloop: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 15:47:58 +0000 (17:47 +0200)] 
mainloop: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agolxcseccomp: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 15:26:12 +0000 (17:26 +0200)] 
lxcseccomp: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agolxclock: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 15:22:31 +0000 (17:22 +0200)] 
lxclock: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agolog: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 14:45:34 +0000 (16:45 +0200)] 
log: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoinitutils: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 14:32:52 +0000 (16:32 +0200)] 
initutils: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agofile_utils: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 14:21:38 +0000 (16:21 +0200)] 
file_utils: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoerror: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 14:11:48 +0000 (16:11 +0200)] 
error: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocriu: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 14:11:14 +0000 (16:11 +0200)] 
criu: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoconfile_utils: hide unnecessary symbols
Christian Brauner [Mon, 20 Jul 2020 14:10:28 +0000 (16:10 +0200)] 
confile_utils: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoconfile: hide unnecessary symbols
Christian Brauner [Sat, 18 Jul 2020 17:07:31 +0000 (19:07 +0200)] 
confile: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3490 from brauner/master
Stéphane Graber [Sat, 18 Jul 2020 15:09:46 +0000 (11:09 -0400)] 
Merge pull request #3490 from brauner/master

lxc-ls: bugfixes

5 years agolxc-ls: bugfixes 3490/head
Christian Brauner [Sat, 18 Jul 2020 11:27:14 +0000 (13:27 +0200)] 
lxc-ls: bugfixes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMakefile.am: Fix typo
Stéphane Graber [Fri, 17 Jul 2020 23:03:59 +0000 (19:03 -0400)] 
Makefile.am: Fix typo

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
5 years agoMerge pull request #3488 from brauner/2020-07-17/fixes
Stéphane Graber [Fri, 17 Jul 2020 22:30:47 +0000 (18:30 -0400)] 
Merge pull request #3488 from brauner/2020-07-17/fixes

hide unnecessary symbols I

5 years agoconf: hide unnecessary symbols 3488/head
Christian Brauner [Fri, 17 Jul 2020 21:50:55 +0000 (23:50 +0200)] 
conf: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocommands_utils: hide unnecessary symbols
Christian Brauner [Fri, 17 Jul 2020 21:31:33 +0000 (23:31 +0200)] 
commands_utils: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocommands: hide unnecessary symbols
Christian Brauner [Fri, 17 Jul 2020 21:26:52 +0000 (23:26 +0200)] 
commands: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocaps: hide unnecessary symbols
Christian Brauner [Fri, 17 Jul 2020 21:17:00 +0000 (23:17 +0200)] 
caps: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoattach: hide unnecessary symbols
Christian Brauner [Fri, 17 Jul 2020 21:16:08 +0000 (23:16 +0200)] 
attach: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoaf_unix: hide unnecessary symbols
Christian Brauner [Fri, 17 Jul 2020 21:14:38 +0000 (23:14 +0200)] 
af_unix: hide unnecessary symbols

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agostring_utils: make all helpers hidden
Christian Brauner [Fri, 17 Jul 2020 21:12:28 +0000 (23:12 +0200)] 
string_utils: make all helpers hidden

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocompiler: add and use __hidden visbility
Christian Brauner [Fri, 17 Jul 2020 20:50:51 +0000 (22:50 +0200)] 
compiler: add and use __hidden visbility

Closes: #3485.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agonetwork: remove unused variable
Christian Brauner [Fri, 17 Jul 2020 20:18:26 +0000 (22:18 +0200)] 
network: remove unused variable

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3487 from samboyles1/master
Christian Brauner [Fri, 17 Jul 2020 12:13:26 +0000 (14:13 +0200)] 
Merge pull request #3487 from samboyles1/master

Improve efficiency of lxc_ifname_alnum_case_sensitive

5 years agoImprove efficiency of lxc_ifname_alnum_case_sensitive 3487/head
Sam Boyles [Fri, 17 Jul 2020 02:26:51 +0000 (14:26 +1200)] 
Improve efficiency of lxc_ifname_alnum_case_sensitive

To detect if a newly generated interface name is a duplicate of an existing interface lxc_ifname_alnum_case_sensitive() currently gets a list of all interfaces using netns_getifaddrs(). When the system has a small number of interfaces this works fine, however when there are thousands or tens of thousands of interfaces this quickly becomes less than optimal.

As we only need to check if an interface name exists, and do not need the detailed information about the interfaces provided by netns_getifaddrs(), we can instead use the if_nametoindex() function, which is much more efficient.

Signed-off-by: Sam Boyles <sam.boyles@alliedtelesis.co.nz>
5 years agoMerge pull request #3486 from brauner/2020-07-16/license
Stéphane Graber [Thu, 16 Jul 2020 22:09:51 +0000 (18:09 -0400)] 
Merge pull request #3486 from brauner/2020-07-16/license

autotools: include COPYING file

5 years agoautotools: include COPYING file 3486/head
Christian Brauner [Thu, 16 Jul 2020 20:49:13 +0000 (22:49 +0200)] 
autotools: include COPYING file

Closes: #3484.
Suggested-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3480 from Drachenfels-GmbH/master
Christian Brauner [Wed, 8 Jul 2020 10:37:39 +0000 (12:37 +0200)] 
Merge pull request #3480 from Drachenfels-GmbH/master

checkconfig: Show LXC version in output.

5 years agocheckconfig: Show LXC version in output. 3480/head
Ruben Jenster [Wed, 8 Jul 2020 09:25:39 +0000 (11:25 +0200)] 
checkconfig: Show LXC version in output.

Signed-off-by: Ruben Jenster <r.jenster@drachenfels.de>
5 years agoMerge pull request #3479 from brauner/2020-07-06/fixes
Stéphane Graber [Mon, 6 Jul 2020 10:51:04 +0000 (06:51 -0400)] 
Merge pull request #3479 from brauner/2020-07-06/fixes

openpty: improve implementation and handling of platforms without it

5 years agoopenpty: improve implementation and handling of platforms without it 3479/head
Christian Brauner [Mon, 6 Jul 2020 08:54:46 +0000 (10:54 +0200)] 
openpty: improve implementation and handling of platforms without it

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3478 from brauner/2020-07-05/fixes
Stéphane Graber [Mon, 6 Jul 2020 01:14:22 +0000 (21:14 -0400)] 
Merge pull request #3478 from brauner/2020-07-05/fixes

openpty: fix faulty rename

5 years agoopenpty: fix faulty rename 3478/head
Christian Brauner [Sun, 5 Jul 2020 21:42:31 +0000 (23:42 +0200)] 
openpty: fix faulty rename

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3477 from brauner/2020-07-05/fixes
Stéphane Graber [Sun, 5 Jul 2020 21:29:32 +0000 (17:29 -0400)] 
Merge pull request #3477 from brauner/2020-07-05/fixes

tree-wide: update terminal terminology once more

5 years agotree-wide: s/pts/pty/g 3477/head
Christian Brauner [Sun, 5 Jul 2020 20:00:11 +0000 (22:00 +0200)] 
tree-wide: s/pts/pty/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agotree-wide: s/ptmx/ptx/g
Christian Brauner [Sun, 5 Jul 2020 19:54:32 +0000 (21:54 +0200)] 
tree-wide: s/ptmx/ptx/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3476 from brauner/2020-07-05/fixes
Stéphane Graber [Sun, 5 Jul 2020 19:24:23 +0000 (15:24 -0400)] 
Merge pull request #3476 from brauner/2020-07-05/fixes

cgroups: handle empty bpf log buffer

5 years agocgroups: handle empty bpf log buffer 3476/head
Christian Brauner [Sun, 5 Jul 2020 19:04:07 +0000 (21:04 +0200)] 
cgroups: handle empty bpf log buffer

Link: https://launchpadlibrarian.net/487274879/buildlog_ubuntu-eoan-amd64.lxc_1:4.0.3+master~20200705-1541-0ubuntu1~eoan_BUILDING.txt.gz
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3475 from brauner/2020-07-05/fixes
Stéphane Graber [Sun, 5 Jul 2020 15:28:48 +0000 (11:28 -0400)] 
Merge pull request #3475 from brauner/2020-07-05/fixes

cgroups: fix bpf device program generation

5 years agocgroups: fix bpf device program generation 3475/head
Christian Brauner [Sun, 5 Jul 2020 08:49:58 +0000 (10:49 +0200)] 
cgroups: fix bpf device program generation

Closes: #3473.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3474 from brauner/2020-07-03/fixes
Stéphane Graber [Fri, 3 Jul 2020 13:42:10 +0000 (09:42 -0400)] 
Merge pull request #3474 from brauner/2020-07-03/fixes

api-extensions: add seccomp_allow_deny_syntax extension

5 years agoapi-extensions: add seccomp_allow_deny_syntax extension 3474/head
Christian Brauner [Fri, 3 Jul 2020 13:14:15 +0000 (15:14 +0200)] 
api-extensions: add seccomp_allow_deny_syntax extension

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3472 from brauner/2020-07-03/fixes
Stéphane Graber [Fri, 3 Jul 2020 12:22:30 +0000 (08:22 -0400)] 
Merge pull request #3472 from brauner/2020-07-03/fixes

fixes

5 years agocgroup2_devices: fix access rule parsing 3472/head
Christian Brauner [Fri, 3 Jul 2020 11:40:28 +0000 (13:40 +0200)] 
cgroup2_devices: fix access rule parsing

Closes: #3473.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocgroups: use empty {} to initialize struct
Christian Brauner [Fri, 3 Jul 2020 11:40:12 +0000 (13:40 +0200)] 
cgroups: use empty {} to initialize struct

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoseccomp: support allowlist/denylist in profiles
Christian Brauner [Fri, 3 Jul 2020 11:18:36 +0000 (13:18 +0200)] 
seccomp: support allowlist/denylist in profiles

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocgroups: update terminology II
Christian Brauner [Fri, 3 Jul 2020 11:01:40 +0000 (13:01 +0200)] 
cgroups: update terminology II

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agocgroups: update terminology
Christian Brauner [Fri, 3 Jul 2020 10:56:48 +0000 (12:56 +0200)] 
cgroups: update terminology

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3469 from johanneskastl/20200630_Kastl_fix_gpg_option
Stéphane Graber [Wed, 1 Jul 2020 12:44:06 +0000 (08:44 -0400)] 
Merge pull request #3469 from johanneskastl/20200630_Kastl_fix_gpg_option

templates/lxc-download.in: use GPG option "--receive-keys"

5 years agotemplates/lxc-download.in: use GPG option --receive-keys instead of --recv-keys 3469/head
Johannes Kastl [Tue, 30 Jun 2020 17:13:04 +0000 (19:13 +0200)] 
templates/lxc-download.in: use GPG option --receive-keys instead of --recv-keys

Signed-off-by: Johannes Kastl <kastl@b1-systems.de>
5 years agoMerge pull request #3468 from johanneskastl/20200630_Kastl_fix_shell_download_template
Stéphane Graber [Tue, 30 Jun 2020 20:18:44 +0000 (16:18 -0400)] 
Merge pull request #3468 from johanneskastl/20200630_Kastl_fix_shell_download_template

templates/lxc-download.in: fix wrong if-condition

5 years agotemplates/lxc-download.in: make shellcheck happy 3468/head
Johannes Kastl [Tue, 30 Jun 2020 16:55:15 +0000 (18:55 +0200)] 
templates/lxc-download.in: make shellcheck happy

Signed-off-by: Johannes Kastl <kastl@b1-systems.de>
5 years agotemplates/lxc-download.in: fix wrong if condition (use the result of the gpg command...
Johannes Kastl [Tue, 30 Jun 2020 16:51:20 +0000 (18:51 +0200)] 
templates/lxc-download.in: fix wrong if condition (use the result of the gpg command, not the result when executing the result of the gpg command)

Signed-off-by: Johannes Kastl <kastl@b1-systems.de>
5 years agoMerge pull request #3466 from alivenets/fix-no-new-privs
Christian Brauner [Tue, 30 Jun 2020 08:18:01 +0000 (10:18 +0200)] 
Merge pull request #3466 from alivenets/fix-no-new-privs

attach: set no_new_privs flag after LSM label

5 years agoattach: set no_new_privs flag after LSM label 3466/head
Alexander Livenets [Mon, 29 Jun 2020 22:06:20 +0000 (00:06 +0200)] 
attach: set no_new_privs flag after LSM label

In `start.c:1284`, no_new_privs flag is set after LSM label is set.
Also, in `lxc.container.conf` documentation it is written that:
```
Note that PR_SET_NO_NEW_PRIVS is applied after the container has
changed into its intended AppArmor profile or SElinux context.
```
This commit fixes the behavior of `lxc_attach` by moving
`PR_SET_NO_NEW_PRIVS` set logic after LSM for the process is configured;

Closes #3393

Signed-off-by: Alexander Livenets <a.livenets@gmail.com>
5 years agoMerge pull request #3465 from brauner/2020-06-19/clone_into_cgroup
Stéphane Graber [Mon, 29 Jun 2020 13:24:34 +0000 (09:24 -0400)] 
Merge pull request #3465 from brauner/2020-06-19/clone_into_cgroup

clone_into_cgroup: fixes

5 years agostart: use __aligned_u64 3465/head
Christian Brauner [Mon, 29 Jun 2020 12:52:54 +0000 (14:52 +0200)] 
start: use __aligned_u64

Closes: Coverity 1465044.
Closes: Coverity 1465046.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agostart: initialize cgroup_fd
Christian Brauner [Mon, 29 Jun 2020 12:51:02 +0000 (14:51 +0200)] 
start: initialize cgroup_fd

Fixes: Coverity 1465045.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3464 from brauner/2020-06-19/clone_into_cgroup
Stéphane Graber [Mon, 29 Jun 2020 12:24:00 +0000 (08:24 -0400)] 
Merge pull request #3464 from brauner/2020-06-19/clone_into_cgroup

lxc: support CLONE_INTO_CGROUP

5 years agolxc: support CLONE_INTO_CGROUP 3464/head
Christian Brauner [Mon, 29 Jun 2020 09:34:01 +0000 (11:34 +0200)] 
lxc: support CLONE_INTO_CGROUP

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoMerge pull request #3463 from brauner/2020-06-26/fixes
Stéphane Graber [Fri, 26 Jun 2020 13:33:03 +0000 (09:33 -0400)] 
Merge pull request #3463 from brauner/2020-06-26/fixes

confile: handle overflow in lxc.time.offset.{boot,monotonic}

5 years agoMerge pull request #3462 from tenforward/japanese
Stéphane Graber [Fri, 26 Jun 2020 12:45:55 +0000 (08:45 -0400)] 
Merge pull request #3462 from tenforward/japanese

Update Japanese lxc.container.conf(5)

5 years agostart: preserve time namespace 3463/head
Christian Brauner [Fri, 26 Jun 2020 08:39:47 +0000 (10:39 +0200)] 
start: preserve time namespace

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
5 years agoconfile: handle overflow in lxc.time.offset.{boot,monotonic}
Christian Brauner [Fri, 26 Jun 2020 08:08:32 +0000 (10:08 +0200)] 
confile: handle overflow in lxc.time.offset.{boot,monotonic}

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>