]> git.ipfire.org Git - thirdparty/collectd.git/log
thirdparty/collectd.git
4 years agoMakefile.am: Remove left-over comment. 3506/head
Florian Forster [Mon, 31 Aug 2020 14:46:31 +0000 (16:46 +0200)] 
Makefile.am: Remove left-over comment.

4 years agodaemon: Remove uc_get_rate_by_name_vl().
Florian Forster [Mon, 10 Aug 2020 07:46:01 +0000 (09:46 +0200)] 
daemon: Remove uc_get_rate_by_name_vl().

The implementation has already been removed.

4 years agocmds: Disable the GETVAL test relying on the default host behavior.
Florian Forster [Mon, 10 Aug 2020 06:35:36 +0000 (08:35 +0200)] 
cmds: Disable the GETVAL test relying on the default host behavior.

4 years agoMakefile.am: Link libcommon with libmetric.
Florian Forster [Mon, 10 Aug 2020 06:35:10 +0000 (08:35 +0200)] 
Makefile.am: Link libcommon with libmetric.

4 years agocmds: Change GETVAL to use parse_legacy_identifier().
Florian Forster [Fri, 31 Jul 2020 06:53:17 +0000 (08:53 +0200)] 
cmds: Change GETVAL to use parse_legacy_identifier().

4 years agocommon: Fix a memory leak in plugin_value_list_to_metric_family().
Florian Forster [Fri, 31 Jul 2020 06:54:47 +0000 (08:54 +0200)] 
common: Fix a memory leak in plugin_value_list_to_metric_family().

The temporary metric_t needs to be reset, otherwise the labels leak.

4 years agodaemon, common: Move plugin_value_list_to_metric_family().
Florian Forster [Thu, 30 Jul 2020 16:35:00 +0000 (18:35 +0200)] 
daemon, common: Move plugin_value_list_to_metric_family().

4 years agocommon: Implement parse_legacy_identifier().
Florian Forster [Thu, 30 Jul 2020 16:31:19 +0000 (18:31 +0200)] 
common: Implement parse_legacy_identifier().

5 years agocommon: Add a "data_source" return argument to parse_identifier_vl().
Florian Forster [Thu, 30 Jul 2020 16:21:06 +0000 (18:21 +0200)] 
common: Add a "data_source" return argument to parse_identifier_vl().

5 years agocmds: Remove "data source" from the FLUSH command.
Florian Forster [Wed, 29 Jul 2020 11:45:11 +0000 (13:45 +0200)] 
cmds: Remove "data source" from the FLUSH command.

5 years agoformat_json: migrate to metric_parse_identity().
Florian Forster [Tue, 21 Jul 2020 17:05:55 +0000 (19:05 +0200)] 
format_json: migrate to metric_parse_identity().

5 years agocmds: migrate to metric_parse_identity().
Florian Forster [Tue, 21 Jul 2020 17:01:08 +0000 (19:01 +0200)] 
cmds: migrate to metric_parse_identity().

5 years agoMakefile.am: Remove libidentity.la
Florian Forster [Fri, 17 Jul 2020 11:36:25 +0000 (13:36 +0200)] 
Makefile.am: Remove libidentity.la

5 years agosrc/daemon/plugin_mock.c: Remove metrics_list_t.
Florian Forster [Fri, 17 Jul 2020 11:36:08 +0000 (13:36 +0200)] 
src/daemon/plugin_mock.c: Remove metrics_list_t.

5 years agoformat_json: s/keyval_t/label_t/g
Florian Forster [Fri, 17 Jul 2020 11:19:23 +0000 (13:19 +0200)] 
format_json: s/keyval_t/label_t/g

5 years agoformat_graphite: Remove left-over line from resolving merge conflicts.
Florian Forster [Fri, 17 Jul 2020 11:18:16 +0000 (13:18 +0200)] 
format_graphite: Remove left-over line from resolving merge conflicts.

5 years ago.travis.yml: Disable plugins that are known not to build yet.
Florian Forster [Thu, 16 Jul 2020 14:05:24 +0000 (16:05 +0200)] 
.travis.yml: Disable plugins that are known not to build yet.

5 years agoformat_graphite: Format with contrib/format.sh
Florian Forster [Fri, 17 Jul 2020 16:08:46 +0000 (18:08 +0200)] 
format_graphite: Format with contrib/format.sh

5 years agocommon: Format with contrib/format.sh
Florian Forster [Fri, 17 Jul 2020 16:08:38 +0000 (18:08 +0200)] 
common: Format with contrib/format.sh

5 years agocmds: Format with contrib/format.sh
Florian Forster [Fri, 17 Jul 2020 16:08:32 +0000 (18:08 +0200)] 
cmds: Format with contrib/format.sh

5 years agosrc/daemon/plugin_mock.c: Format with contrib/format.sh
Florian Forster [Thu, 16 Jul 2020 11:11:21 +0000 (13:11 +0200)] 
src/daemon/plugin_mock.c: Format with contrib/format.sh

5 years agoformat_graphite: Remove static buffer from unit test.
Florian Forster [Thu, 16 Jul 2020 09:59:55 +0000 (11:59 +0200)] 
format_graphite: Remove static buffer from unit test.

Some ancient GCC versions whine about a check being always true,
breaking the test.

5 years ago.cirrus.yml: Disable the "built plugins" check for now.
Florian Forster [Thu, 16 Jul 2020 09:53:01 +0000 (11:53 +0200)] 
.cirrus.yml: Disable the "built plugins" check for now.

5 years agoformat_json: Free memory allocated in the "metric_family" test.
Florian Forster [Thu, 16 Jul 2020 09:40:35 +0000 (11:40 +0200)] 
format_json: Free memory allocated in the "metric_family" test.

5 years agosrc/utils/cmds/cmds_test.c: Free memory allocated in the string buffer.
Florian Forster [Thu, 16 Jul 2020 09:40:05 +0000 (11:40 +0200)] 
src/utils/cmds/cmds_test.c: Free memory allocated in the string buffer.

5 years ago.cirrus.yml: Print test-suite.log on failure.
Florian Forster [Thu, 16 Jul 2020 09:27:01 +0000 (11:27 +0200)] 
.cirrus.yml: Print test-suite.log on failure.

5 years agometadata: Fix unit test.
Florian Forster [Wed, 15 Jul 2020 21:56:07 +0000 (23:56 +0200)] 
metadata: Fix unit test.

5 years agoRemove test_utils_metrics_list.
Florian Forster [Wed, 15 Jul 2020 21:45:28 +0000 (23:45 +0200)] 
Remove test_utils_metrics_list.

5 years agocommon: Fix unit test.
Florian Forster [Wed, 15 Jul 2020 21:38:16 +0000 (23:38 +0200)] 
common: Fix unit test.

5 years agomatch: Fix the build of the "match" utility by removing support for "absolute".
Florian Forster [Wed, 15 Jul 2020 14:24:11 +0000 (16:24 +0200)] 
match: Fix the build of the "match" utility by removing support for "absolute".

5 years agowrite_http plugin: Migrate to PUTMETRIC.
Florian Forster [Mon, 20 Jul 2020 18:51:54 +0000 (20:51 +0200)] 
write_http plugin: Migrate to PUTMETRIC.

5 years agocommon: Fix parse_identifier{,_vl}().
Florian Forster [Mon, 20 Jul 2020 18:51:35 +0000 (20:51 +0200)] 
common: Fix parse_identifier{,_vl}().

5 years agocmds: Fix the PUTVAL command.
Florian Forster [Wed, 15 Jul 2020 14:18:42 +0000 (16:18 +0200)] 
cmds: Fix the PUTVAL command.

This is a partial roll-back of previous code that tried to convert PUTVAL
to use metric_t. This role is now filled by PUTMETRIC instead.

Modifications to the "common" plugin (particularly "parse_identifier" and
"parse_identifier_vl" fix the "cmds" unit tests.

The "cmd_create_putval" function has been removed because output will use
the new metric format instead.

5 years agocmds: Implement the "PUTMETRIC" command.
Florian Forster [Wed, 15 Jul 2020 12:01:18 +0000 (14:01 +0200)] 
cmds: Implement the "PUTMETRIC" command.

5 years ago.cirrus.yml: Disable plugins that are known not to build yet.
Florian Forster [Tue, 14 Jul 2020 17:40:52 +0000 (19:40 +0200)] 
.cirrus.yml: Disable plugins that are known not to build yet.

5 years agoformat_graphite: Fix unit test.
Florian Forster [Tue, 14 Jul 2020 19:22:46 +0000 (21:22 +0200)] 
format_graphite: Fix unit test.

5 years agosrc/utils/cmds/getthreshold.c: Fix (incorrect) "missing-braces" warning.
Florian Forster [Tue, 14 Jul 2020 18:54:19 +0000 (20:54 +0200)] 
src/utils/cmds/getthreshold.c: Fix (incorrect) "missing-braces" warning.

5 years agoformat_kairosdb: Format with contrib/format.sh
Florian Forster [Fri, 17 Jul 2020 16:07:57 +0000 (18:07 +0200)] 
format_kairosdb: Format with contrib/format.sh

5 years agoformat_json: Format with contrib/format.sh
Florian Forster [Fri, 17 Jul 2020 16:07:49 +0000 (18:07 +0200)] 
format_json: Format with contrib/format.sh

5 years agocmds: Format with contrib/format.sh
Florian Forster [Fri, 17 Jul 2020 16:07:40 +0000 (18:07 +0200)] 
cmds: Format with contrib/format.sh

5 years agoFormat with contrib/format.sh
Florian Forster [Tue, 14 Jul 2020 17:42:56 +0000 (19:42 +0200)] 
Format with contrib/format.sh

5 years agoformat_json: Replace the JSON_ADD[F] macros.
Florian Forster [Thu, 9 Jul 2020 10:31:36 +0000 (12:31 +0200)] 
format_json: Replace the JSON_ADD[F] macros.

This unifies the approach taken by the format_json and format_kairosdb
packages.

5 years agoformat_json, format_kairosdb: Don't enable beatification of JSON.
Florian Forster [Thu, 9 Jul 2020 10:29:15 +0000 (12:29 +0200)] 
format_json, format_kairosdb: Don't enable beatification of JSON.

The code depends on the last character in the buffer being ']'. If
"beautification" is enabled, it will add a newline at the end, which
breaks the "append" mechanic.

5 years agowrite_http plugin: Implement support for metric_family_t.
Florian Forster [Wed, 8 Jul 2020 21:06:34 +0000 (23:06 +0200)] 
write_http plugin: Implement support for metric_family_t.

5 years agocmds: Change cmd_create_putval() to accept a strbuf_t.
Florian Forster [Wed, 8 Jul 2020 20:58:02 +0000 (22:58 +0200)] 
cmds: Change cmd_create_putval() to accept a strbuf_t.

5 years agoformat_kairosdb: Implement support for metric_family_t.
Florian Forster [Wed, 8 Jul 2020 20:55:54 +0000 (22:55 +0200)] 
format_kairosdb: Implement support for metric_family_t.

5 years agoformat_json: Add support for appending metric_family_t's to the buffer.
Florian Forster [Wed, 8 Jul 2020 20:18:04 +0000 (22:18 +0200)] 
format_json: Add support for appending metric_family_t's to the buffer.

With this change, multiple metric_family_t's can be added to a buffer
sequentially. The implementation that did not use libyajl has been
removed because it was unused (it only implemented marshalling of
value_list_t).

5 years agomemory plugin: Implement support for metric_family_t.
Florian Forster [Wed, 8 Jul 2020 07:08:18 +0000 (09:08 +0200)] 
memory plugin: Implement support for metric_family_t.

5 years agocpu plugin: Convert percent metrics to metric_family_t.
Florian Forster [Sat, 4 Jul 2020 15:59:02 +0000 (17:59 +0200)] 
cpu plugin: Convert percent metrics to metric_family_t.

5 years agometadata: Return errno values without negation.
Florian Forster [Thu, 2 Jul 2020 18:24:34 +0000 (20:24 +0200)] 
metadata: Return errno values without negation.

5 years agoformat_stackdriver: Correctly report sd_output_register_metric errors.
Florian Forster [Thu, 2 Jul 2020 18:23:55 +0000 (20:23 +0200)] 
format_stackdriver: Correctly report sd_output_register_metric errors.

5 years agowrite_stackdriver plugin: Log sd_output_register_metric errors.
Florian Forster [Thu, 2 Jul 2020 18:23:16 +0000 (20:23 +0200)] 
write_stackdriver plugin: Log sd_output_register_metric errors.

5 years agoformat_stackdriver: Check for counter reset in format_time_series().
Florian Forster [Thu, 2 Jul 2020 10:11:52 +0000 (12:11 +0200)] 
format_stackdriver: Check for counter reset in format_time_series().

Previously, this check was done in format_typed_value() when the time
series data was already partially written to the buffer. Doing the check
there would result in invalid JSON output.

Additionally, the comparison was the wrong way around, causing the
assertion to fail for all counter metrics.

5 years agowrite_stackdriver plugin: Implement support for metric_family_t.
Florian Forster [Wed, 1 Jul 2020 20:19:15 +0000 (22:19 +0200)] 
write_stackdriver plugin: Implement support for metric_family_t.

5 years agoformat_stackdriver: Fix and expand unit test.
Florian Forster [Wed, 1 Jul 2020 20:17:58 +0000 (22:17 +0200)] 
format_stackdriver: Fix and expand unit test.

5 years agoMakefile.am: Fix some linking issues with the utility libraries.
Florian Forster [Mon, 29 Jun 2020 08:43:29 +0000 (10:43 +0200)] 
Makefile.am: Fix some linking issues with the utility libraries.

5 years agocpu plugin: Actually set the metric value.
Florian Forster [Mon, 29 Jun 2020 08:35:35 +0000 (10:35 +0200)] 
cpu plugin: Actually set the metric value.

Fixes a regression introduced in 18b6e8502e6acdb79d5d55ac6dca38fc6e98dc13.

5 years agowrite_log plugin: Implement support for metric_family_t.
Florian Forster [Mon, 29 Jun 2020 08:20:09 +0000 (10:20 +0200)] 
write_log plugin: Implement support for metric_family_t.

5 years agoformat_stackdriver: Implement support for metric_family_t.
Florian Forster [Mon, 29 Jun 2020 08:03:21 +0000 (10:03 +0200)] 
format_stackdriver: Implement support for metric_family_t.

5 years agoformat_json: Implement support for metric_family_t.
Florian Forster [Sun, 28 Jun 2020 20:20:42 +0000 (22:20 +0200)] 
format_json: Implement support for metric_family_t.

5 years agoformat_graphite: Implement support for metric_family_t.
Florian Forster [Sun, 28 Jun 2020 20:20:20 +0000 (22:20 +0200)] 
format_graphite: Implement support for metric_family_t.

5 years agocmds: Implement support for metric_family_t.
Florian Forster [Sun, 28 Jun 2020 20:19:59 +0000 (22:19 +0200)] 
cmds: Implement support for metric_family_t.

5 years agocpu plugin: Convert to new metric API.
Florian Forster [Thu, 16 Jul 2020 16:18:06 +0000 (18:18 +0200)] 
cpu plugin: Convert to new metric API.

5 years agocpu plugin: Convert to the new metric_family_t structure.
Florian Forster [Fri, 17 Jul 2020 11:14:09 +0000 (13:14 +0200)] 
cpu plugin: Convert to the new metric_family_t structure.

5 years agothreshold plugin: Fix a debug message.
Florian Forster [Fri, 17 Jul 2020 11:13:18 +0000 (13:13 +0200)] 
threshold plugin: Fix a debug message.

5 years agocommon: Create the metric_family_t and metric_t types.
Florian Forster [Fri, 17 Jul 2020 11:12:33 +0000 (13:12 +0200)] 
common: Create the metric_family_t and metric_t types.

A "metric family" is a set of metrics, all with the same name (but
different labels and/or label values). The identity is split between the
two types: the "metric family" holds the "name" while the "metric" holds
the labels. Likewise, the "metric family" holds the metric type, the
"metric" holds the metric value.

This commit contains all required changes to compile the daemon, but
pretty much everything else still fails to build. The tests have not yet
updated either.

The "cpu plugin" has been updated as a proof-of-concept implementation.

# Conflicts:
# src/daemon/plugin.h

5 years agoformat_kairosdb: s/metric_t/metric_single_t/
Florian Forster [Fri, 17 Jul 2020 11:10:36 +0000 (13:10 +0200)] 
format_kairosdb: s/metric_t/metric_single_t/

5 years agoformat_json: s/metric_t/metric_single_t/
Florian Forster [Fri, 17 Jul 2020 11:10:26 +0000 (13:10 +0200)] 
format_json: s/metric_t/metric_single_t/

5 years agoformat_graphite: s/metric_t/metric_single_t/
Florian Forster [Fri, 17 Jul 2020 11:10:13 +0000 (13:10 +0200)] 
format_graphite: s/metric_t/metric_single_t/

5 years agocommon: s/metric_t/metric_single_t/
Florian Forster [Fri, 17 Jul 2020 11:10:04 +0000 (13:10 +0200)] 
common: s/metric_t/metric_single_t/

5 years agocmds: s/metric_t/metric_single_t/
Florian Forster [Fri, 17 Jul 2020 11:09:55 +0000 (13:09 +0200)] 
cmds: s/metric_t/metric_single_t/

5 years agoVarious: s/metric_t/metric_single_t/g
Florian Forster [Fri, 17 Jul 2020 11:08:51 +0000 (13:08 +0200)] 
Various: s/metric_t/metric_single_t/g

5 years agowrite_log plugin: Update to the new interfaces of format_{graphite,json}.
Florian Forster [Wed, 24 Jun 2020 20:32:31 +0000 (22:32 +0200)] 
write_log plugin: Update to the new interfaces of format_{graphite,json}.

5 years agoMakefile.am: Link libplugin_mock.la with libmetadata.la.
Florian Forster [Fri, 17 Jul 2020 11:06:38 +0000 (13:06 +0200)] 
Makefile.am: Link libplugin_mock.la with libmetadata.la.

5 years agoformat_json: Reimplement format_json_metric().
Florian Forster [Wed, 24 Jun 2020 09:08:01 +0000 (11:08 +0200)] 
format_json: Reimplement format_json_metric().

This new implementation uses the new format of the metric_t type.
It produces output that is compatible with the prometheus/prom2json
project.

5 years agocmds: Fix putval so it compiles.
Florian Forster [Tue, 23 Jun 2020 10:11:16 +0000 (12:11 +0200)] 
cmds: Fix putval so it compiles.

This is a stop-gap solution. I think we need to come up with a nicer way
of encoding the metric identity for PUTVAL commands.

5 years agoMakefile.am: Link the daemon with libmetadata.la.
Florian Forster [Tue, 23 Jun 2020 08:49:14 +0000 (10:49 +0200)] 
Makefile.am: Link the daemon with libmetadata.la.

Instead of re-compiling utils/metadata/meta_data.c.

5 years agosrc/utils/cmds/getthreshold.c: Adapt to the new metric_t structure.
Florian Forster [Sun, 21 Jun 2020 17:52:21 +0000 (19:52 +0200)] 
src/utils/cmds/getthreshold.c: Adapt to the new metric_t structure.

5 years agoVarious: Changes because src/daemon/metric.[ch] was created.
Florian Forster [Fri, 17 Jul 2020 11:21:48 +0000 (13:21 +0200)] 
Various: Changes because src/daemon/metric.[ch] was created.

5 years agowrite_graphite: Update to the new format_graphite interface.
Florian Forster [Sun, 21 Jun 2020 15:09:40 +0000 (17:09 +0200)] 
write_graphite: Update to the new format_graphite interface.

5 years agoformat_graphite: Basically a rewrite for metric_t.
Florian Forster [Sun, 21 Jun 2020 14:46:02 +0000 (16:46 +0200)] 
format_graphite: Basically a rewrite for metric_t.

5 years agocommon: Simplify notification_init_metric() so it compiles.
Florian Forster [Thu, 18 Jun 2020 07:15:50 +0000 (09:15 +0200)] 
common: Simplify notification_init_metric() so it compiles.

This function is not yet complete; a bunch of TODOs have been left in
the code.

5 years agoperl plugin: More cleanups.
Florian Forster [Fri, 17 Jul 2020 10:43:49 +0000 (12:43 +0200)] 
perl plugin: More cleanups.

*   Struct "metric_t": unnecessary fields "type", "plugin", "ds" have
    been removed. The field "value_ds_type" has been renamed to
    "value_type".
*   The reference counted, multiple instance "meta_data_list_head_t" type
    has been removed. Manually doing the reference counting all over the
    place is error prone and it seems like premature optimization.
*   The "<type>_destroy" functions must handle NULL gracefully. Removed
    NULL-checks around their invocation to improve readability.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoformat_kairosdb: More cleanups.
Florian Forster [Fri, 17 Jul 2020 10:43:34 +0000 (12:43 +0200)] 
format_kairosdb: More cleanups.

*   Struct "metric_t": unnecessary fields "type", "plugin", "ds" have
    been removed. The field "value_ds_type" has been renamed to
    "value_type".
*   The reference counted, multiple instance "meta_data_list_head_t" type
    has been removed. Manually doing the reference counting all over the
    place is error prone and it seems like premature optimization.
*   The "<type>_destroy" functions must handle NULL gracefully. Removed
    NULL-checks around their invocation to improve readability.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoformat_json: More cleanups.
Florian Forster [Fri, 17 Jul 2020 10:43:13 +0000 (12:43 +0200)] 
format_json: More cleanups.

*   Struct "metric_t": unnecessary fields "type", "plugin", "ds" have
    been removed. The field "value_ds_type" has been renamed to
    "value_type".
*   The reference counted, multiple instance "meta_data_list_head_t" type
    has been removed. Manually doing the reference counting all over the
    place is error prone and it seems like premature optimization.
*   The "<type>_destroy" functions must handle NULL gracefully. Removed
    NULL-checks around their invocation to improve readability.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoformat_graphite: More cleanups.
Florian Forster [Fri, 17 Jul 2020 10:43:01 +0000 (12:43 +0200)] 
format_graphite: More cleanups.

*   Struct "metric_t": unnecessary fields "type", "plugin", "ds" have
    been removed. The field "value_ds_type" has been renamed to
    "value_type".
*   The reference counted, multiple instance "meta_data_list_head_t" type
    has been removed. Manually doing the reference counting all over the
    place is error prone and it seems like premature optimization.
*   The "<type>_destroy" functions must handle NULL gracefully. Removed
    NULL-checks around their invocation to improve readability.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agocommon: More cleanups.
Florian Forster [Fri, 17 Jul 2020 10:42:42 +0000 (12:42 +0200)] 
common: More cleanups.

*   Struct "metric_t": unnecessary fields "type", "plugin", "ds" have
    been removed. The field "value_ds_type" has been renamed to
    "value_type".
*   The reference counted, multiple instance "meta_data_list_head_t" type
    has been removed. Manually doing the reference counting all over the
    place is error prone and it seems like premature optimization.
*   The "<type>_destroy" functions must handle NULL gracefully. Removed
    NULL-checks around their invocation to improve readability.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agobarometer, python plugins: Reworked some code in src/daemon/plugin.[ch].
Florian Forster [Fri, 17 Jul 2020 10:29:28 +0000 (12:29 +0200)] 
barometer, python plugins: Reworked some code in src/daemon/plugin.[ch].

Unfortunately it's all a bit messy and entangled. Since this is such
an early WIP, I didn't spend the (substantial) time needed to pick this
into separate changes. The changes in this commit are:

*   Create a consistent naming schema for the identity functions:
    *   Rename "create_identity" to "identity_create_legacy".
    *   Rename "clone_identity" to "identity_clone".
    *   Rename "destroy_identity" to "identity_destroy".
*   Add "identity_create" to allocate a new identity_t.
*   Copy key and value strings within "identity_add_label".
    *   Make use of "identity_create" and "identity_add_label" in
        "identity_clone", "identity_create_legacy" and others that used
        to fiddle with the AVL tree directly.
*   Remove the "_p" suffix used for pointers. This is quite unusual for
    the collectd codebase.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agocmds: Reworked some code in src/daemon/plugin.[ch].
Florian Forster [Fri, 17 Jul 2020 10:29:09 +0000 (12:29 +0200)] 
cmds: Reworked some code in src/daemon/plugin.[ch].

Unfortunately it's all a bit messy and entangled. Since this is such
an early WIP, I didn't spend the (substantial) time needed to pick this
into separate changes. The changes in this commit are:

*   Create a consistent naming schema for the identity functions:
    *   Rename "create_identity" to "identity_create_legacy".
    *   Rename "clone_identity" to "identity_clone".
    *   Rename "destroy_identity" to "identity_destroy".
*   Add "identity_create" to allocate a new identity_t.
*   Copy key and value strings within "identity_add_label".
    *   Make use of "identity_create" and "identity_add_label" in
        "identity_clone", "identity_create_legacy" and others that used
        to fiddle with the AVL tree directly.
*   Remove the "_p" suffix used for pointers. This is quite unusual for
    the collectd codebase.

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoVarious: Use metric_t internally
Florian Forster [Fri, 17 Jul 2020 10:28:07 +0000 (12:28 +0200)] 
Various: Use metric_t internally

This is a WIP

This commit is where the major transform takes palce; the internal
representation is changed, and the read plugins use that indirectly
when they submit a value list transparently.

The baromerter read plugin has been converted to using metric_t
representation natively.

The write plugins have to be adapted to use these new single data
source metrics.

Signed-off-by: Manoj Srivastava <srivasta@google.com>
Change-Id: I9bdeaa59de5c58d11c0ae0e7b55d68d9e4d77fa1

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoformat_kairosdb: Use metric_t internally
Florian Forster [Fri, 17 Jul 2020 10:27:34 +0000 (12:27 +0200)] 
format_kairosdb: Use metric_t internally

This is a WIP

This commit is where the major transform takes palce; the internal
representation is changed, and the read plugins use that indirectly
when they submit a value list transparently.

The baromerter read plugin has been converted to using metric_t
representation natively.

The write plugins have to be adapted to use these new single data
source metrics.

Signed-off-by: Manoj Srivastava <srivasta@google.com>
Change-Id: I9bdeaa59de5c58d11c0ae0e7b55d68d9e4d77fa1

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoformat_json: Use metric_t internally
Florian Forster [Fri, 17 Jul 2020 10:27:23 +0000 (12:27 +0200)] 
format_json: Use metric_t internally

This is a WIP

This commit is where the major transform takes palce; the internal
representation is changed, and the read plugins use that indirectly
when they submit a value list transparently.

The baromerter read plugin has been converted to using metric_t
representation natively.

The write plugins have to be adapted to use these new single data
source metrics.

Signed-off-by: Manoj Srivastava <srivasta@google.com>
Change-Id: I9bdeaa59de5c58d11c0ae0e7b55d68d9e4d77fa1

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agoformat_graphite: Use metric_t internally
Florian Forster [Fri, 17 Jul 2020 10:26:57 +0000 (12:26 +0200)] 
format_graphite: Use metric_t internally

This is a WIP

This commit is where the major transform takes palce; the internal
representation is changed, and the read plugins use that indirectly
when they submit a value list transparently.

The baromerter read plugin has been converted to using metric_t
representation natively.

The write plugins have to be adapted to use these new single data
source metrics.

Signed-off-by: Manoj Srivastava <srivasta@google.com>
Change-Id: I9bdeaa59de5c58d11c0ae0e7b55d68d9e4d77fa1

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agocommon: Use metric_t internally
Florian Forster [Fri, 17 Jul 2020 10:26:37 +0000 (12:26 +0200)] 
common: Use metric_t internally

This is a WIP

This commit is where the major transform takes palce; the internal
representation is changed, and the read plugins use that indirectly
when they submit a value list transparently.

The baromerter read plugin has been converted to using metric_t
representation natively.

The write plugins have to be adapted to use these new single data
source metrics.

Signed-off-by: Manoj Srivastava <srivasta@google.com>
Change-Id: I9bdeaa59de5c58d11c0ae0e7b55d68d9e4d77fa1

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agocmds: Use metric_t internally
Florian Forster [Fri, 17 Jul 2020 10:26:16 +0000 (12:26 +0200)] 
cmds: Use metric_t internally

This is a WIP

This commit is where the major transform takes palce; the internal
representation is changed, and the read plugins use that indirectly
when they submit a value list transparently.

The baromerter read plugin has been converted to using metric_t
representation natively.

The write plugins have to be adapted to use these new single data
source metrics.

Signed-off-by: Manoj Srivastava <srivasta@google.com>
Change-Id: I9bdeaa59de5c58d11c0ae0e7b55d68d9e4d77fa1

# Conflicts:
# src/daemon/metrics_list_test.c

5 years agocmds: Quick fix to get "getval" to compile.
Florian Forster [Wed, 29 Jul 2020 07:57:16 +0000 (09:57 +0200)] 
cmds: Quick fix to get "getval" to compile.

5 years agocmds: Quick fix to let "getthreshold" to compile.
Florian Forster [Wed, 29 Jul 2020 07:56:45 +0000 (09:56 +0200)] 
cmds: Quick fix to let "getthreshold" to compile.

5 years agoformat_stackdriver: Use the "uc_meta_data_{add,get}_…_vl" dummy functions.
Florian Forster [Wed, 29 Jul 2020 07:57:59 +0000 (09:57 +0200)] 
format_stackdriver: Use the "uc_meta_data_{add,get}_…_vl" dummy functions.

5 years agodaemon: Add uc_meta_data_{add,get}_…_vl dummy functions.
Florian Forster [Wed, 29 Jul 2020 07:55:20 +0000 (09:55 +0200)] 
daemon: Add uc_meta_data_{add,get}_…_vl dummy functions.

Their only purpose is to make the "format_stackdriver" utility compile.
They will be removed once the utility is updated to use metric_t instead.

5 years agodaemon: Add "plugin_instance" and "type_instance" back to threshold_t.
Florian Forster [Wed, 29 Jul 2020 07:56:05 +0000 (09:56 +0200)] 
daemon: Add "plugin_instance" and "type_instance" back to threshold_t.