]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agoremove the "Juniper-" prefix 3857/head
lyubomirtraykov [Tue, 19 Jan 2021 13:29:37 +0000 (15:29 +0200)] 
remove the "Juniper-" prefix

5 years agoUpdate dictionary.juniper
lyubomirtraykov [Tue, 19 Jan 2021 08:02:05 +0000 (10:02 +0200)] 
Update dictionary.juniper

Add Juniper-CWA-Redirect to dictionary.juniper

5 years agoNot used
Arran Cudbard-Bell [Mon, 18 Jan 2021 22:12:51 +0000 (22:12 +0000)] 
Not used

5 years agoFix various spec file issues
Arran Cudbard-Bell [Mon, 18 Jan 2021 22:11:58 +0000 (22:11 +0000)] 
Fix various spec file issues

5 years agoAdd clang format markers
Arran Cudbard-Bell [Mon, 18 Jan 2021 21:36:48 +0000 (21:36 +0000)] 
Add clang format markers

5 years agominor cleanups
Alan T. DeKok [Mon, 18 Jan 2021 17:48:02 +0000 (12:48 -0500)] 
minor cleanups

5 years agoMissing parens
Arran Cudbard-Bell [Mon, 18 Jan 2021 18:53:01 +0000 (18:53 +0000)] 
Missing parens

5 years agoCI is slow
Arran Cudbard-Bell [Mon, 18 Jan 2021 14:00:47 +0000 (14:00 +0000)] 
CI is slow

5 years agoFix issue in JSON bool evaluation
Arran Cudbard-Bell [Mon, 18 Jan 2021 13:42:14 +0000 (13:42 +0000)] 
Fix issue in JSON bool evaluation

5 years agoWe'll fix this another way...
Arran Cudbard-Bell [Mon, 18 Jan 2021 13:33:06 +0000 (13:33 +0000)] 
We'll fix this another way...

5 years agoBetter error messages in fr_pair_list_afrom_substr (#3852)
Nicolas C [Mon, 18 Jan 2021 13:14:07 +0000 (14:14 +0100)] 
Better error messages in fr_pair_list_afrom_substr (#3852)

* Better error messages in fr_pair_list_afrom_substr

Helps seeing what we did wrong when using dhcpclient or radclient

* Not const

5 years agoCI: Build with PCRE 2; Add "LIBS_ALT:yes" target; Tidier naming (#3851)
Terry Burton [Mon, 18 Jan 2021 01:10:11 +0000 (01:10 +0000)] 
CI: Build with PCRE 2; Add "LIBS_ALT:yes" target; Tidier naming (#3851)

Now build using PCRE 2 by default.

LIBS_ALT: yes will replace default libraries as follows:

  PCRE 2       -> PCRE 1
  MIT Kerberos -> Heimdal Kerberos

Add custom names for the matrix entries so that the workflow output is easier
to interpret. Reorganise the entries so that the variable components are first.

5 years agoDebian packaging: Use PCRE 2 in preference to PCRE 1, if known (#3850)
Terry Burton [Mon, 18 Jan 2021 01:09:58 +0000 (01:09 +0000)] 
Debian packaging: Use PCRE 2 in preference to PCRE 1, if known (#3850)

5 years agoTurn floating point comparison into memcmp() to silence compiler (#3849)
James Jones [Mon, 18 Jan 2021 01:09:33 +0000 (19:09 -0600)] 
Turn floating point comparison into memcmp() to silence compiler (#3849)

In numerical methods, it is indeed a bad idea to compare
floating point numbers for equality, but this just tests
that fr_dbuff_in() and fr_dbuff_out(), barring lack of space
breaking fr_dbuff_in(), are inverses for float and double.
No floating point arithmetic involved, so it's reasonable to
compare the raw bits. We'll use memcmp() to (1) emphasize that
and (2) keep the compiler from warning about comparing floating
point values for equality.

5 years agoNo longer need to do anything special with state when detaching
Arran Cudbard-Bell [Sun, 17 Jan 2021 23:52:34 +0000 (23:52 +0000)] 
No longer need to do anything special with state when detaching

5 years agoRemove (now) invalid asserts
Arran Cudbard-Bell [Sun, 17 Jan 2021 23:39:29 +0000 (23:39 +0000)] 
Remove (now) invalid asserts

5 years agoDon't leak session state
Arran Cudbard-Bell [Sun, 17 Jan 2021 22:33:45 +0000 (22:33 +0000)] 
Don't leak session state

5 years agoBad pointer to terminal elements
Arran Cudbard-Bell [Sun, 17 Jan 2021 22:05:10 +0000 (22:05 +0000)] 
Bad pointer to terminal elements

5 years agore-enable this one again for now... they can often be fixed and it's causing issues...
Arran Cudbard-Bell [Sun, 17 Jan 2021 21:41:21 +0000 (21:41 +0000)] 
re-enable this one again for now... they can often be fixed and it's causing issues with GCC

5 years agouse clang diagnostics only on clang
Alan T. DeKok [Sun, 17 Jan 2021 20:03:41 +0000 (15:03 -0500)] 
use clang diagnostics only on clang

5 years agoclear out array when it's freed
Alan T. DeKok [Sun, 17 Jan 2021 18:37:13 +0000 (13:37 -0500)] 
clear out array when it's freed

5 years agouse TEST_BIN_DIR instead of hard-coded paths
Alan T. DeKok [Sun, 17 Jan 2021 18:30:45 +0000 (13:30 -0500)] 
use TEST_BIN_DIR instead of hard-coded paths

5 years agoraw attributes have no tag
Alan T. DeKok [Sun, 17 Jan 2021 18:24:06 +0000 (13:24 -0500)] 
raw attributes have no tag

5 years agoclear out data structures that we're using
Alan T. DeKok [Sun, 17 Jan 2021 15:44:00 +0000 (10:44 -0500)] 
clear out data structures that we're using

5 years agodhcpv4 encode / decode does not support array of dns_label
Alan T. DeKok [Sun, 17 Jan 2021 15:26:29 +0000 (10:26 -0500)] 
dhcpv4 encode / decode does not support array of dns_label

once the code is fixed, we will update the dictionaries

5 years agodon't hit assert if the dictionary parser is broken
Alan T. DeKok [Sun, 17 Jan 2021 15:20:46 +0000 (10:20 -0500)] 
don't hit assert if the dictionary parser is broken

we should also fix the dictionary parser...

5 years agozero-length attributes are raw, not asserts
Alan T. DeKok [Sun, 17 Jan 2021 15:19:15 +0000 (10:19 -0500)] 
zero-length attributes are raw, not asserts

5 years agothis is a DNS label, not an array
Alan T. DeKok [Sun, 17 Jan 2021 15:19:00 +0000 (10:19 -0500)] 
this is a DNS label, not an array

5 years agocheck for empty packets
Alan T. DeKok [Sun, 17 Jan 2021 15:12:05 +0000 (10:12 -0500)] 
check for empty packets

5 years agoadd "test.fuzzer" target in order to do fuzzer tests
Alan T. DeKok [Sun, 17 Jan 2021 15:01:44 +0000 (10:01 -0500)] 
add "test.fuzzer" target in order to do fuzzer tests

5 years agobe more forgiving about fuzzer flags
Alan T. DeKok [Sun, 17 Jan 2021 14:50:18 +0000 (09:50 -0500)] 
be more forgiving about fuzzer flags

5 years agofix typo
Alan T. DeKok [Sun, 17 Jan 2021 14:39:37 +0000 (09:39 -0500)] 
fix typo

5 years agoremove extra semicolon
Alan T. DeKok [Sun, 17 Jan 2021 14:38:29 +0000 (09:38 -0500)] 
remove extra semicolon

5 years agouse pre-existing DIAG_OFF macros
Alan T. DeKok [Sun, 17 Jan 2021 14:22:46 +0000 (09:22 -0500)] 
use pre-existing DIAG_OFF macros

5 years agoturn off clang-specific complaints. The code is fine
Alan T. DeKok [Sun, 17 Jan 2021 14:07:34 +0000 (09:07 -0500)] 
turn off clang-specific complaints.  The code is fine

5 years agowrap macro in `do { ... } while (0)` to shut up compiler
Alan T. DeKok [Sun, 17 Jan 2021 14:07:14 +0000 (09:07 -0500)] 
wrap macro in `do { ... } while (0)` to shut up compiler

5 years agobetter error messages
Alan T. DeKok [Sun, 17 Jan 2021 13:38:29 +0000 (08:38 -0500)] 
better error messages

5 years agoadd missing "break".
Alan T. DeKok [Sun, 17 Jan 2021 13:38:09 +0000 (08:38 -0500)] 
add missing "break".

so we don't hit unknown packet type

5 years agoCI: Add MacOS build to the matrix
Terry Burton [Fri, 15 Jan 2021 00:02:41 +0000 (00:02 +0000)] 
CI: Add MacOS build to the matrix

No fixtures, just ordinary "make test" for now.

We disable clang static analysis scan for now to keep the runtime within that
of the other jobs.

5 years agoCI: More complete FreeBSD build and tests
Terry Burton [Sun, 17 Jan 2021 01:15:30 +0000 (01:15 +0000)] 
CI: More complete FreeBSD build and tests

5 years agoTests: There's no bash at /bin/bash on FreeBSD
Terry Burton [Sat, 16 Jan 2021 21:52:28 +0000 (21:52 +0000)] 
Tests: There's no bash at /bin/bash on FreeBSD

5 years agoshut up compiler.
Alan T. DeKok [Sun, 17 Jan 2021 12:51:16 +0000 (07:51 -0500)] 
shut up compiler.

tho arguably we should be using memcmp() i.e. *bit* comparison
instead of "==", which is more *semantic* comparison

5 years agoshut up clang about system libraries
Alan T. DeKok [Sun, 17 Jan 2021 12:40:30 +0000 (07:40 -0500)] 
shut up clang about system libraries

5 years agovariable is used
Alan T. DeKok [Sun, 17 Jan 2021 12:35:04 +0000 (07:35 -0500)] 
variable is used

5 years agoMissing break
Arran Cudbard-Bell [Sun, 17 Jan 2021 01:17:16 +0000 (01:17 +0000)] 
Missing break

5 years agoRevert back to previous way of unsetting UNENCRYPTED flag even though it shouldn...
Arran Cudbard-Bell [Sun, 17 Jan 2021 01:12:29 +0000 (01:12 +0000)] 
Revert back to previous way of unsetting  UNENCRYPTED flag even though it shouldn't be necessary?

5 years agoShould be static
Arran Cudbard-Bell [Sun, 17 Jan 2021 00:29:20 +0000 (00:29 +0000)] 
Should be static

5 years agoMore float comparisons
Arran Cudbard-Bell [Sun, 17 Jan 2021 00:19:13 +0000 (00:19 +0000)] 
More float comparisons

5 years agoMore stupid flag set/unset warnings
Arran Cudbard-Bell [Sun, 17 Jan 2021 00:06:00 +0000 (00:06 +0000)] 
More stupid flag set/unset warnings

5 years agoExtra comma
Arran Cudbard-Bell [Sat, 16 Jan 2021 23:28:30 +0000 (23:28 +0000)] 
Extra comma

5 years agoShould be static
Arran Cudbard-Bell [Sat, 16 Jan 2021 23:25:32 +0000 (23:25 +0000)] 
Should be static

5 years agoShouldn't be marked as inline
Arran Cudbard-Bell [Sat, 16 Jan 2021 23:12:48 +0000 (23:12 +0000)] 
Shouldn't be marked as inline

5 years agoUnused
Arran Cudbard-Bell [Sat, 16 Jan 2021 23:03:52 +0000 (23:03 +0000)] 
Unused

5 years agoFix more optional args
Arran Cudbard-Bell [Sat, 16 Jan 2021 23:03:47 +0000 (23:03 +0000)] 
Fix more optional args

5 years agoShould probably be exported
Arran Cudbard-Bell [Sat, 16 Jan 2021 23:03:36 +0000 (23:03 +0000)] 
Should probably be exported

5 years agoMake more things static
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:53:01 +0000 (22:53 +0000)] 
Make more things static

5 years agoBad comma
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:52:54 +0000 (22:52 +0000)] 
Bad comma

5 years agoUnused macros
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:52:43 +0000 (22:52 +0000)] 
Unused macros

5 years agoFix uninitialised fields
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:52:28 +0000 (22:52 +0000)] 
Fix uninitialised fields

5 years agoMake NULL escape rules static
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:48:10 +0000 (22:48 +0000)] 
Make NULL escape rules static

5 years agoVarious stupid issues in value.c
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:47:53 +0000 (22:47 +0000)] 
Various stupid issues in value.c

5 years agoUnused
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:36:05 +0000 (22:36 +0000)] 
Unused

5 years agoMore stupid warnings
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:35:10 +0000 (22:35 +0000)] 
More stupid warnings

5 years agoFix stupid vla warning
Arran Cudbard-Bell [Sat, 16 Jan 2021 22:09:18 +0000 (22:09 +0000)] 
Fix stupid vla warning

5 years agoPedantic
Arran Cudbard-Bell [Sat, 16 Jan 2021 21:48:10 +0000 (21:48 +0000)] 
Pedantic

5 years agoUsed arg
Arran Cudbard-Bell [Sat, 16 Jan 2021 21:44:18 +0000 (21:44 +0000)] 
Used arg

5 years agoJust toggle the individual bit
Arran Cudbard-Bell [Sat, 16 Jan 2021 21:41:28 +0000 (21:41 +0000)] 
Just toggle the individual bit

5 years agoFix stupid -Wassign-enum warning
Arran Cudbard-Bell [Sat, 16 Jan 2021 21:37:46 +0000 (21:37 +0000)] 
Fix stupid -Wassign-enum warning

5 years agoBad function cast
Arran Cudbard-Bell [Sat, 16 Jan 2021 21:24:56 +0000 (21:24 +0000)] 
Bad function cast

5 years agoFix bad terminator in par test arrays
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:18:31 +0000 (18:18 +0000)] 
Fix bad terminator in par test arrays

5 years agoMore zero length array struct members
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:16:52 +0000 (18:16 +0000)] 
More zero length array struct members

5 years agoUnused macro
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:16:39 +0000 (18:16 +0000)] 
Unused macro

5 years agoFix -Wmissing-noreturn
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:14:14 +0000 (18:14 +0000)] 
Fix -Wmissing-noreturn

5 years agoDead code
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:11:23 +0000 (18:11 +0000)] 
Dead code

5 years agoActually used
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:08:42 +0000 (18:08 +0000)] 
Actually used

5 years agoExtra semi
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:07:46 +0000 (18:07 +0000)] 
Extra semi

5 years agoMark cap table len as static
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:02:06 +0000 (18:02 +0000)] 
Mark cap table len as static

5 years agoNot inline
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:01:57 +0000 (18:01 +0000)] 
Not inline

5 years agoUnused args are used
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:01:43 +0000 (18:01 +0000)] 
Unused args are used

5 years agoFix dead code in tacacs encode
Arran Cudbard-Bell [Sat, 16 Jan 2021 18:01:33 +0000 (18:01 +0000)] 
Fix dead code in tacacs encode

5 years agoCapital W
Arran Cudbard-Bell [Sat, 16 Jan 2021 17:50:04 +0000 (17:50 +0000)] 
Capital W

5 years agoFix arguments inside of preprocessor condition warning
Arran Cudbard-Bell [Sat, 16 Jan 2021 16:27:16 +0000 (16:27 +0000)] 
Fix arguments inside of preprocessor condition warning

5 years agoTypo
Arran Cudbard-Bell [Sat, 16 Jan 2021 16:26:35 +0000 (16:26 +0000)] 
Typo

5 years agoFix various pedantic warnings
Arran Cudbard-Bell [Sat, 16 Jan 2021 16:23:47 +0000 (16:23 +0000)] 
Fix various pedantic warnings

5 years agovariable is used
Alan T. DeKok [Sat, 16 Jan 2021 16:18:25 +0000 (11:18 -0500)] 
variable is used

5 years agoremove unused macro
Alan T. DeKok [Sat, 16 Jan 2021 16:15:53 +0000 (11:15 -0500)] 
remove unused macro

5 years agoshut up stupid clang
Alan T. DeKok [Sat, 16 Jan 2021 16:15:23 +0000 (11:15 -0500)] 
shut up stupid clang

5 years agovariable is used
Alan T. DeKok [Sat, 16 Jan 2021 16:13:36 +0000 (11:13 -0500)] 
variable is used

5 years agoAlways provide a session state
Arran Cudbard-Bell [Sat, 16 Jan 2021 13:52:08 +0000 (13:52 +0000)] 
Always provide a session state

This won't matter when we use a pool of them

# Conflicts:
# src/lib/server/state.c

5 years agoApparently we have leaks
Arran Cudbard-Bell [Sat, 16 Jan 2021 12:37:26 +0000 (12:37 +0000)] 
Apparently we have leaks

5 years agoDon't leak sate ctxs and store the request ctx
Arran Cudbard-Bell [Fri, 15 Jan 2021 22:19:30 +0000 (22:19 +0000)] 
Don't leak sate ctxs and store the request ctx

5 years agocheck for child ctx
Arran Cudbard-Bell [Fri, 15 Jan 2021 22:09:52 +0000 (22:09 +0000)] 
check for child ctx

5 years agoshouldn't have been comitted
Arran Cudbard-Bell [Fri, 15 Jan 2021 21:51:26 +0000 (21:51 +0000)] 
shouldn't have been comitted

5 years agoFix more talloc parenting issues
Arran Cudbard-Bell [Fri, 15 Jan 2021 21:39:04 +0000 (21:39 +0000)] 
Fix more talloc parenting issues

5 years agoBrackets!
Arran Cudbard-Bell [Fri, 15 Jan 2021 20:57:28 +0000 (20:57 +0000)] 
Brackets!

5 years agoSwap out the list heads for pairs
Arran Cudbard-Bell [Fri, 15 Jan 2021 20:46:34 +0000 (20:46 +0000)] 
Swap out the list heads for pairs

Rework the support for child session state to make it simpler

Fix a ton of pair parenting issues

5 years agoclean up final uses of dict_attr_size
Alan T. DeKok [Fri, 15 Jan 2021 19:26:37 +0000 (14:26 -0500)] 
clean up final uses of dict_attr_size

the struct validation code now checks if (a) the da contains
a known fixed size, or (b) it's a FR_TYPE_VALUE.  That covers
the same situations as before.

It still doesn't allow for variable-sized fields like dns labels,
but that will have to be another step.

now that dict_attr_size isn't used, it's removed.

5 years agofix data types
Alan T. DeKok [Fri, 15 Jan 2021 16:42:56 +0000 (11:42 -0500)] 
fix data types

5 years agocall fr_value_box_from_network()
Alan T. DeKok [Fri, 15 Jan 2021 16:19:15 +0000 (11:19 -0500)] 
call fr_value_box_from_network()

instead of re-implementing a subset of that functionality

and add a test case for it

5 years agouse the actual length of the value box, instead of the dict size
Alan T. DeKok [Fri, 15 Jan 2021 15:56:40 +0000 (10:56 -0500)] 
use the actual length of the value box, instead of the dict size

which is more protocol-specific