]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
6 weeks agodissect: support mount options when going through mountfsd 39394/head
Luca Boccassi [Mon, 20 Oct 2025 23:39:44 +0000 (00:39 +0100)] 
dissect: support mount options when going through mountfsd

RootImageOptions=/ExtensionImages=/MountImages= all support
custom mount options, use the new mountfsd parameters to
configure them if they are specified.

This requires additioanl privileges via polkit due to security
implications of mount options, so document an example policy
that allows to use the nosuid mount option.

6 weeks agomountfsd: add support for mount options
Luca Boccassi [Mon, 20 Oct 2025 23:39:16 +0000 (00:39 +0100)] 
mountfsd: add support for mount options

RootImageOptions=/ExtensionImages=/MountImages= all support custom
mount options, but mountfsd does not support it. Add varlink
parameters to allow callers to specify mount options so that
those directives can work as expected.

Given the security implications of some mount options (e.g.: ACLs,
SELinux), require additional privileges to use custom mount options.
Pass the list of requested options to polkit details, so that the
policy can check the exact details if needed, for example to only
allow nosuid and reject the rest.

6 weeks agoman: do not manually update man/rules/meson.build
Yu Watanabe [Tue, 6 Jan 2026 18:13:52 +0000 (03:13 +0900)] 
man: do not manually update man/rules/meson.build

Follow-up for 25393c7c907b2c460a8a34d7dc6a1bdbcac8e9d4.

6 weeks agocore: change mount options settings so that last defined wins (#39449)
Yu Watanabe [Tue, 6 Jan 2026 19:11:29 +0000 (04:11 +0900)] 
core: change mount options settings so that last defined wins (#39449)

6 weeks agoDrop support for sysvinit scripts (#39770)
Yu Watanabe [Tue, 6 Jan 2026 17:51:53 +0000 (02:51 +0900)] 
Drop support for sysvinit scripts (#39770)

As announced by a few releases now, finally drop support for sysvinit scripts.

6 weeks agoNEWS: note mount image options rule changes 39449/head
Luca Boccassi [Tue, 6 Jan 2026 17:00:20 +0000 (18:00 +0100)] 
NEWS: note mount image options rule changes

6 weeks agocore: change mount options settings so that last defined wins
Luca Boccassi [Sat, 25 Oct 2025 17:40:44 +0000 (18:40 +0100)] 
core: change mount options settings so that last defined wins

Currently mount options are handled in such a way that the first
definition for a given partition wins, and documented as such.
Change them so that they behave like other options, and the
last specified wins.
Applies to RootImageOptions=, MountImages= and ExtensionImages=.
Switch from a linked list to an array indexed by the partition
specifier to store them.

6 weeks agocore: add support for disabling THPs (#39085)
Yu Watanabe [Tue, 6 Jan 2026 16:36:20 +0000 (01:36 +0900)] 
core: add support for disabling THPs (#39085)

Transparent Hugepages (THP) is a Linux kernel feature that manages
memory using larger pages (2MB on x86, compared to the default 4KB). The
main goal is to improve memory management efficiency and system
performance, especially for memory-intensive applications. However, it
can cause drawbacks in some scenarios, such as memory regression and
latency spikes. THP policy is governed for the entire system via
/sys/kernel/mm/transparent_hugepage/enabled.
However, it can be overridden for individual workloads via prctl(2) call.
MemoryTHP= is used to disable THPs at exec-invoke to stop providing THPs
for workloads where the drawbacks outweigh the advantages. When set to
"disable", MemoryTHP= disables THPs completely for the process,
irrespective of global THP controls.

[1] https://man7.org/linux/man-pages/man2/PR_SET_THP_DISABLE.2const.html
[2] https://man7.org/linux/man-pages/man2/madvise.2.html
[3] https://github.com/torvalds/linux/commit/9dc21bbd62edeae6f63e6f25e1edb7167452457b

6 weeks agohwdb: add matrix for ASUS 2-in-1 T101HA
francescoza6 [Wed, 31 Dec 2025 17:30:54 +0000 (18:30 +0100)] 
hwdb: add matrix for ASUS 2-in-1 T101HA

The matrix tested working in monitor-sensor (06 gen 2026),
corrects accel values and not just display output.

6 weeks agosrc/test: add unittest for MemoryTHP= 39085/head
Usama Arif [Sun, 21 Sep 2025 19:59:38 +0000 (20:59 +0100)] 
src/test: add unittest for MemoryTHP=

This checks if the prctl is set correctly when the property name
is passed to systemd-run.

6 weeks agocore: introduce MemoryTHP= unit file setting
Usama Arif [Mon, 15 Sep 2025 12:33:28 +0000 (13:33 +0100)] 
core: introduce MemoryTHP= unit file setting

Transparent Hugepages (THP) is a Linux kernel feature that manages
memory using larger pages (2MB on x86, compared to the default 4KB).
The main goal is to improve memory management efficiency and system
performance, especially for memory-intensive applications.
However, it can cause drawbacks in some scenarios, such as memory
regression and latency spikes. THP policy is governed for the entire
system via /sys/kernel/mm/transparent_hugepage/enabled.
However, it can be overridden for individual workloads via prctl(2)
call.
MemoryTHP= is used to disable THPs at exec-invoke to stop
providing THPs for workloads where the drawbacks outweigh the advantages.
When set to "disable", MemoryTHP= disables THPs completely for the
process, irrespecitive of global THP controls.
When set to "madvise", MemoryTHP= disables THPs for the process except
when specifically madvised by the process with MADV_HUGEPAGE or MADV_COLLAPSE.

6 weeks agoDrop support for sysvinit scripts 39770/head
Luca Boccassi [Mon, 17 Nov 2025 14:44:18 +0000 (14:44 +0000)] 
Drop support for sysvinit scripts

As announced by a few releases now, finally drop support for
sysvinit scripts.
Keep rc-local generator for now, as it's really a distinct
feature even though from the same era.

6 weeks agorc-local and sysvinit are independent, adjust meson/units/docs
Luca Boccassi [Mon, 17 Nov 2025 14:58:27 +0000 (14:58 +0000)] 
rc-local and sysvinit are independent, adjust meson/units/docs

They are separate and independent settings, so adjust meson rules
and unit files accordingly. It is possible to enable support for
rc-local script without support for sysvinit scripts, and viceversa.
This will become useful later when sysvinit scripts support is
removed.

6 weeks agohwdb: Add missing vendor names for older AYANEO devices
Derek J. Clark [Tue, 6 Jan 2026 04:07:21 +0000 (20:07 -0800)] 
hwdb: Add missing vendor names for older AYANEO devices
Adds AYADEVICE and AYA NEO vendor names. Early founders editon and 2021 models used these DMI values instead of AYANEO

6 weeks agohwdb: Add missing scancodes for Lenovo Legion devices
Derek J. Clark [Tue, 6 Jan 2026 03:01:30 +0000 (19:01 -0800)] 
hwdb: Add missing scancodes for Lenovo Legion devices

Adds missing scancodes for Lenovo Legion Go, Go S, and Go 2. When long
pressing the power button the device should issue a LEFTMETA + F16
combo. The LEFTMETA code fires properly, but the F16 is not mapped.

Go and Go S devices detect as AT Translated Set 2 Keyboard, while Go 2
detects as AT Raw Set 2 Keyboard, hence the multiple entries.

Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
6 weeks agoman/kernel-install: /proc/cmdline is not used as a fallback in container
Alexis-Emmanuel Haeringer [Mon, 5 Jan 2026 22:03:03 +0000 (23:03 +0100)] 
man/kernel-install: /proc/cmdline is not used as a fallback in container

6 weeks agoman: fix typo
Yu Watanabe [Mon, 5 Jan 2026 23:48:00 +0000 (08:48 +0900)] 
man: fix typo

6 weeks agopstore: fix typo
Yu Watanabe [Mon, 5 Jan 2026 23:45:22 +0000 (08:45 +0900)] 
pstore: fix typo

6 weeks agoimport: update comment: implementor -> implementer
Yu Watanabe [Mon, 5 Jan 2026 23:43:02 +0000 (08:43 +0900)] 
import: update comment: implementor -> implementer

Both implementor and implementer are correct, but we use implementer at
other places.

6 weeks agosysusers: document u! version support
Tobias Stoeckmann [Mon, 5 Jan 2026 21:56:17 +0000 (22:56 +0100)] 
sysusers: document u! version support

Document at which version the exclamation mark suffix is supported.
Version 215 at the end of the list item is a bit misleading.

6 weeks agoNEWS: fix typo
Zbigniew Jędrzejewski-Szmek [Mon, 5 Jan 2026 09:05:09 +0000 (10:05 +0100)] 
NEWS: fix typo

6 weeks agoTEST-13-NSPAWN: remove pulled image on exit
Yu Watanabe [Mon, 5 Jan 2026 12:21:59 +0000 (21:21 +0900)] 
TEST-13-NSPAWN: remove pulled image on exit

Otherwise, if the VM is unexpectedly rebooted, then `importctl --user pull-tar`
may fail as the file may already exist.
```
[  123.351751] TEST-13-NSPAWN.sh[3946]: + run0 -u testuser importctl --user pull-tar file:///var/tmp/image-tar/kurps.tar.gz nurps --verify=checksum -m
[  123.541603] TEST-13-NSPAWN.sh[4311]: Enqueued transfer job 3. Press C-c to continue download in background.
[  123.552456] TEST-13-NSPAWN.sh[4311]: Pulling 'file:///var/tmp/image-tar/kurps.tar.gz', saving as 'nurps'.
[  123.552788] TEST-13-NSPAWN.sh[4311]: Operating on image directory '/home/testuser/.local/state/machines'.
[  123.819942] TEST-13-NSPAWN.sh[4311]: Got 1% of file:///var/tmp/image-tar/kurps.tar.gz.
[  124.156557] TEST-13-NSPAWN.sh[4311]: * shutting down connection #0
[  124.156896] TEST-13-NSPAWN.sh[4311]: * Could not open file /var/tmp/image-tar/kurps.tar.gz.sha256
[  124.157223] TEST-13-NSPAWN.sh[4311]: * closing connection #-1
[  124.159198] TEST-13-NSPAWN.sh[4311]: * Could not open file /var/tmp/image-tar/kurps.nspawn
[  124.159493] TEST-13-NSPAWN.sh[4311]: * closing connection #-1
[  124.159818] TEST-13-NSPAWN.sh[4311]: Acquired 68.5M.
[  124.160395] TEST-13-NSPAWN.sh[4311]: Download of file:///var/tmp/image-tar/kurps.tar.gz complete.
[  124.160664] TEST-13-NSPAWN.sh[4311]: Transfer failed: Could not read a file:// file
[  124.160923] TEST-13-NSPAWN.sh[4311]: Settings file could not be retrieved, proceeding without.
[  124.404733] TEST-13-NSPAWN.sh[4311]: * shutting down connection #1
[  124.405162] TEST-13-NSPAWN.sh[4311]: Acquired 79B.
[  124.406170] TEST-13-NSPAWN.sh[4311]: Download of file:///var/tmp/image-tar/SHA256SUMS complete.
[  124.406734] TEST-13-NSPAWN.sh[4311]: SHA256 checksum of file:///var/tmp/image-tar/kurps.tar.gz is valid.
[  124.455446] TEST-13-NSPAWN.sh[4311]: Failed to rename to final image name to /home/testuser/.local/state/machines/.tar-file:\x2f\x2f\x2fvar\x2ftmp\x2fimage-tar\x2fkurps\x2etar\x2egz: File exists
[  124.457251] TEST-13-NSPAWN.sh[4311]: Exiting.
```
Workaround for issue #38240.

6 weeks agomkosi: stop using noble-proposed for qemu
Nick Rosbrook [Mon, 5 Jan 2026 14:29:53 +0000 (09:29 -0500)] 
mkosi: stop using noble-proposed for qemu

The qemu update migrated to noble-updates a couple weeks ago, so it is
no longer necessary to enable noble-proposed (or add the associated apt
pinning config).

6 weeks agojournal-remote test: add -Z in mkdir for journal-{remote,upload}.conf.d
Cathy Hu [Mon, 5 Jan 2026 15:13:15 +0000 (16:13 +0100)] 
journal-remote test: add -Z in mkdir for journal-{remote,upload}.conf.d

Otherwise on SELinux enabled systems with the "targeted" policy
the type is not set correctly when run via unconfined user and
the test fails.

6 weeks agoukify: omit .osrel section when --os-release= is empty
Nick Rosbrook [Fri, 19 Dec 2025 16:01:49 +0000 (11:01 -0500)] 
ukify: omit .osrel section when --os-release= is empty

The primary motivation for this is to allow users of ukify to build
UKI-like objects, without having them later be detected as a UKI by
tools like kernel-install and bootctl.

The common code used by these tools to determine if a PE binary is a UKI
checks that both .osrel and .linux sections are present. Hence, adding
a mechansim to skip .osrel provides a way to avoid being labeled a UKI.

6 weeks agoshared/edit-util: ignore ENOTDIR when trying editors
Pablo Fraile Alonso [Thu, 25 Dec 2025 12:32:43 +0000 (13:32 +0100)] 
shared/edit-util: ignore ENOTDIR when trying editors

6 weeks agocompress: do not call lzma_end_wrapper() when failed to load liblzma
Yu Watanabe [Mon, 5 Jan 2026 07:12:40 +0000 (16:12 +0900)] 
compress: do not call lzma_end_wrapper() when failed to load liblzma

Fixes a bug in 3fc72d54132151c131301fc7954e0b44cdd3c860 (v256).
Fixes #40277.

6 weeks agoidn: drop support for libidn
Mike Yuan [Sun, 4 Jan 2026 22:21:14 +0000 (23:21 +0100)] 
idn: drop support for libidn

The current tree doesn't even compile with libidn(1) after
2c7bdaf9f144ad339c72628579183fc849f2b794, which included
a non-existent call to check_dlopen_blocked() somehow.
Hence, it feels safe to just nuke legacy support from
our repo.

6 weeks agotest-time-util: ignore failure on MSK timezone
Yu Watanabe [Mon, 5 Jan 2026 07:01:34 +0000 (16:01 +0900)] 
test-time-util: ignore failure on MSK timezone

Ignore the following failures:
- with glibc
```
TZ=Europe/Volgograd, tzname[0]=MSK, tzname[1]=MSD
@1414277092997572 → Sun 2014-10-26 01:44:52 MSK → @1414273492000000 → Sun 2014-10-26 01:44:52 MSK
src/test/test-time-util.c:448: Assertion failed: Expected "ignore" to be true
```
- with musl
```
TZ=Europe/Kirov, tzname[0]=MSK, tzname[1]=MSK
@1414277092997572 → Sun 2014-10-26 01:44:52 MSK → @1414273492000000 → Sun 2014-10-26 01:44:52 MSK
src/test/test-time-util.c:448: Assertion failed: Expected "ignore" to be true
```

6 weeks agomeson: remove deprecated meson options
Yu Watanabe [Sun, 4 Jan 2026 20:38:06 +0000 (05:38 +0900)] 
meson: remove deprecated meson options

These options are deprecated since
87541e254f5b0f7e6c2060867bbfe095d206f573 : -Dcryptolib=
710653d3bcc46d6c45d8771e0a74c8d5f6328bc4 : -Dintegration-tests=

6 weeks agomkosi: update debian commit reference to f05328feafba2156f31e17e0e2c144cfa7c66e72
Yu Watanabe [Sun, 4 Jan 2026 22:28:39 +0000 (07:28 +0900)] 
mkosi: update debian commit reference to f05328feafba2156f31e17e0e2c144cfa7c66e72

f05328feaf Drop use of deprecated options
19ed139d85 Mark sd-userdbd as Multi-Arch: foreign

6 weeks agosysext: Get verity user certs from given --root=
Kai Lueke [Thu, 27 Nov 2025 08:49:15 +0000 (17:49 +0900)] 
sysext: Get verity user certs from given --root=

The verity user certs weren't looked up in the given --root= for
systemd-sysext which made it fail to set up extensions with a strict
image policy.
Look up verity user certs from inside the --root= when we operate on
images in it. The main use case where this matters is when the initrd
sets up the extensions for the final system and thus systemd-sysext
should do the same thing as it would do in the final system.

6 weeks agoTweak setting of boot timeout variables (#40125)
Yu Watanabe [Sun, 4 Jan 2026 21:50:49 +0000 (06:50 +0900)] 
Tweak setting of boot timeout variables (#40125)

6 weeks agocore: several follow-ups (#40140)
Yu Watanabe [Sun, 4 Jan 2026 21:31:48 +0000 (06:31 +0900)] 
core: several follow-ups (#40140)

Replaces #39925
Closes #39925

6 weeks agocore: move several checks from _start() to _test_startable() where appropriate
Mike Yuan [Wed, 17 Dec 2025 13:40:48 +0000 (14:40 +0100)] 
core: move several checks from _start() to _test_startable() where appropriate

If these basic sanity checks fail, there's no point in
bumping ratelimit.

6 weeks agoman/systemd.socket: Document JoinsNamespaceOf= support
Lucas Werkmeister [Sun, 4 Jan 2026 13:19:14 +0000 (14:19 +0100)] 
man/systemd.socket: Document JoinsNamespaceOf= support

This has been supported since systemd v242 (specifically commit
7619cb32f0 if I’m not mistaken; added to NEWS in commit 4107452e51), but
the man page still claimed otherwise.

6 weeks agonss-systemd: always fill sg_adm and sg_mem in shadow groups (#40218)
Yu Watanabe [Sun, 4 Jan 2026 18:12:26 +0000 (03:12 +0900)] 
nss-systemd: always fill sg_adm and sg_mem in shadow groups (#40218)

The `sg_adm` and `sg_mem` fields are not always set in shadow groups,
which can lead to issues with foreign tools like shadow's `sg` command.
Since other NSS implementations properly set these fields and it would
otherwise be impossible to access `administrators` and `members`
information from JSON files, it's bets to always fill these fields.

Even though `sg` is a nice example which should be already installed,
the issue itself can be reproduced with this simple program as well. It
relies on filled `sg_adm` and `sg_mem` fields just like `sg` does:

```
#include <err.h>
#include <gshadow.h>
#include <stdio.h>

int
main(int argc, char *argv[])
{
        struct sgrp *s;
        char **p;

        if (argc != 2)
                errx(1, "usage: poc group");

        s = getsgnam(argv[1]);
        printf("name: %s\n", s->sg_namp);
        printf("admins:\n");
        p = s->sg_adm;
        while (*p != NULL) {
                printf("- %s\n", *p);
                p++;
        }
        printf("members:\n");
        p = s->sg_mem;
        while (*p != NULL) {
                printf("- %s\n", *p);
                p++;
        }
}
```

Run it like this: `./poc root`

Proof of Concept (Arch Linux, which uses systemd with systemd-userdbd
and shadow's sg):

```
$ grep systemd /etc/nsswitch.conf
passwd: files systemd
group: files [SUCCESS=merge] systemd
shadow: files systemd
gshadow: files systemd
```

Issue with intrinsic groups:

Run as unprivileged user, who has no access to `/etc/gshadow` to trigger
nss-systemd (strace disables setuid of sg)
```
$ strace sg root
write(2, "sg: list.c:169: is_on_list: Asse"..., 61sg: list.c:169: is_on_list: Assertion `NULL != list' failed.
) = 61
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fa7e9c0c000
gettid()                                = 1882
getpid()                                = 1882
tgkill(1882, 1882, SIGABRT)             = 0
--- SIGABRT {si_signo=SIGABRT, si_code=SI_TKILL, si_pid=1882, si_uid=1000} ---
+++ killed by SIGABRT (core dumped) +++
Aborted                    (core dumped) strace sg root
```

Issue with groups through systemd-userdbd:

1. Create a custom group (as root)
```
cat > /etc/userdb/sg-poc.group << EOF
{
  "groupName": "sg-poc",
  "gid": 6123,
  "administrators": [
    "root"
  ],
  "members": [
    "bin"
  ]
}
EOF
ln -s sg-poc.group /etc/userdb/6123.group
```

2. Verify that group actually exists
```
$ userdbctl group sg-poc
  Group name: sg-poc
 Disposition: regular
         GID: 6123
      Admins: root
     Service: io.systemd.NameServiceSwitch
```

3. Run `sg` to switch into group `sg-poc` as regular user, this time
with setuid, i.e. no strace as before
```
$ sg sg-poc
sg: list.c:169: is_on_list: Assertion `NULL != list' failed.
Aborted                    (core dumped) sg sg-poc
```

6 weeks agoshared/install: ignore aliasing failure when doing presets
Zbigniew Jędrzejewski-Szmek [Sun, 4 Jan 2026 14:10:42 +0000 (15:10 +0100)] 
shared/install: ignore aliasing failure when doing presets

In recent Fedora, preset-all fails:
[  155s] Failed to preset unit: File '/buildroot/etc/systemd/user/dbus.service'
         already exists and is a symlink to /usr/lib/systemd/user/dbus-broker.service
[  155s] ‣ "systemctl --root=/buildroot --global preset-all" returned non-zero exit code 1.

Strictly speaking, this is an error in configuration. The presets specify that
both dbus-broker.service and dbus-daemon.service shall be enabled and they both
claim the 'dbus.service' alias. But this kind of error is very easy to make.
Failing the preset operation is too harsh, since in most cases the system will
work fine without an alias and changes in unrelated components can cause the
conflict.

Let's reuse the same logic that was added in
ad5fdd391248432e0c105003a8a13f821bde0b8e: when enabling the unit through
'preset' or 'preset-all', print the message, but suppress the error. When
enabling through 'enable', fail the operation.

6 weeks agoLogging cleanups (#40271)
Yu Watanabe [Sun, 4 Jan 2026 18:06:09 +0000 (03:06 +0900)] 
Logging cleanups (#40271)

6 weeks agonss-systemd: add unit test for sg_adm/sg_mem 40218/head
Tobias Stoeckmann [Sun, 4 Jan 2026 11:19:22 +0000 (12:19 +0100)] 
nss-systemd: add unit test for sg_adm/sg_mem

Add a test for getsgnam_r to verify that sg_adm and sg_mem always point
to a NULL-terminated string vector.

Extend the gr_mem check of struct group for non-NULL values as well.

6 weeks agonss-systemd: set sg_adm/sg_mem for all groups
Tobias Stoeckmann [Sat, 27 Dec 2025 14:27:05 +0000 (15:27 +0100)] 
nss-systemd: set sg_adm/sg_mem for all groups

Fill sg_adm and sg_mem in nss_pack_group_record_shadow to stay
compatible with other NSS getsgnam implementations which set these
members to NULL terminated string arrays.

Tools like shadow's sg would trigger a NULL pointer dereference with
groups only found through nss-systemd otherwise.

6 weeks agonss-systemd: set sg_adm/sg_mem in intrinsic groups
Tobias Stoeckmann [Sat, 27 Dec 2025 14:24:45 +0000 (15:24 +0100)] 
nss-systemd: set sg_adm/sg_mem in intrinsic groups

The sg_adm and sg_mem fields are supposed to point to a NULL terminated
string array. If these are NULL, some foreign tools like shadow's sg
trigger NULL pointer dereferences (or fortunately their asset() calls).

6 weeks agoinhibit: fix borked double logging on error 40271/head
Zbigniew Jędrzejewski-Szmek [Sun, 4 Jan 2026 11:25:32 +0000 (12:25 +0100)] 
inhibit: fix borked double logging on error

Previously, if execution failed, we'd log at error level both from the
child and the parent, and we were using a bogus variable for the argument
name:
$ build/systemd-inhibit list
Failed to execute : No such file or directory
list failed with exit status 1.

In general, we can and should assume that the program the user is calling
is well behaved, so it'll log the error on its own if appropriate. So we
shouldn't log on "normal errors", but only if the child is terminated by
a signal.

And since the program name is controlled by the user, use quotes everywhere
to avoid ambiguity.

Now:
$ build/systemd-inhibit false
(nothing)
$ build/systemd-inhibit bash -c 'kill -SEGV $$'
src/basic/process-util.c:895: 'bash' terminated by signal SEGV.

6 weeks agobasic/process-util: reduce scope of variables
Zbigniew Jędrzejewski-Szmek [Sun, 4 Jan 2026 11:21:52 +0000 (12:21 +0100)] 
basic/process-util: reduce scope of variables

6 weeks agobasic/process-util: use synthetic errno in two more places
Zbigniew Jędrzejewski-Szmek [Sun, 4 Jan 2026 11:18:38 +0000 (12:18 +0100)] 
basic/process-util: use synthetic errno in two more places

6 weeks agossh-generator: reword error message
Zbigniew Jędrzejewski-Szmek [Wed, 17 Dec 2025 21:51:26 +0000 (22:51 +0100)] 
ssh-generator: reword error message

We have two error messages with exactly the same message.
Let's change one so that it is possible to distinguish them
in logs.

6 weeks agobootctl: round the timeout up 40125/head
Zbigniew Jędrzejewski-Szmek [Fri, 21 Nov 2025 11:53:20 +0000 (12:53 +0100)] 
bootctl: round the timeout up

I think this is better: if I specify 0.5s, I'd be suprised if the
menu didn't show up at all.

6 weeks agobootctl: rework setting of menu timeout variables
Zbigniew Jędrzejewski-Szmek [Fri, 21 Nov 2025 11:32:18 +0000 (12:32 +0100)] 
bootctl: rework setting of menu timeout variables

menu-force and menu-hidden were added in 97f077df052c75224dcc73375bfaaa69af6a1c26,
menu-disable was added in 6efdd7fec5106205240332bd3b7fd2f93d4d9d4c, a year later.
So we can assume that if the feature flag is set, the other string values are
supported too. The comment that there's no way check that was added later in
5b45fad4fcfa2dd81f25b13fe8d7717f62fa5843, but it was incorrect even at that
time.

Fixes https://github.com/systemd/systemd/issues/39167. As described in the
issue, we documented various string values in the BLI, but bootctl didn't use
the string values. At the time menu-force and menu-hidden were added, using
numerical values for compatibility made sense. But that stopped being needed
when a string value that didn't have a strictly equivalent numerical value and
a feature flag were added.

When converting a large number to menu-force, message is downgraded to debug,
since the severity of the issue is very minor. Debug messages are added in
other places when the requested setting is modified too.

6 weeks agocalendarspec: day of month also needs to be reset when year is changed
Yu Watanabe [Sun, 4 Jan 2026 00:37:46 +0000 (09:37 +0900)] 
calendarspec: day of month also needs to be reset when year is changed

Fixes #40260.

6 weeks agoswitch-root: don't do rm_rf() of old superblock on switch root if pivot_root() worked
Lennart Poettering [Fri, 2 Jan 2026 15:30:58 +0000 (16:30 +0100)] 
switch-root: don't do rm_rf() of old superblock on switch root if pivot_root() worked

We do the rm_rf_children() call only because in some cases we cannot
pivot_root() and hence the orginal root superblock stays pinned, and we
thus have to empty it to minimize its memory use. But if pivot_root()
worked (and the umount() for the old root), then there's really no need
to do this work.

Dropping this codepath is useful in context of Christian's recent work
to make the original initrd tmpfs unmountable, which means pivot_root()
will work, and thus there's no need to empty the tmpfs anymore, and we
can speed up boot a bit.

Fixes: #40250
6 weeks agoanalyze: properly handle nvpcrs that have not been initialized yet
Lennart Poettering [Wed, 24 Dec 2025 07:37:22 +0000 (08:37 +0100)] 
analyze: properly handle nvpcrs that have not been initialized yet

Let's explicitly check if NvPCRs are fully set up (allocated, anchored)
before we try to show them.

Alternative to: #40184

6 weeks agocore/dynamic-user: two trivial modernizations (#40264)
Yu Watanabe [Sat, 3 Jan 2026 22:26:19 +0000 (07:26 +0900)] 
core/dynamic-user: two trivial modernizations (#40264)

6 weeks agoquirks: touchpad: Set Duet 3 bt touchpad internal
David Santamaría Rogado [Sat, 3 Jan 2026 20:52:38 +0000 (21:52 +0100)] 
quirks: touchpad: Set Duet 3 bt touchpad internal

The touchpad is in a keyboard and touchpad combo that can be attached and
detached in a convertible device.

6 weeks agocore/dynamic-user: use fd_verify_linked() 40264/head
Mike Yuan [Sat, 3 Jan 2026 19:25:53 +0000 (20:25 +0100)] 
core/dynamic-user: use fd_verify_linked()

6 weeks agorepart: Don't silence mkfs.erofs if on a tty
DaanDeMeyer [Sat, 3 Jan 2026 12:11:38 +0000 (13:11 +0100)] 
repart: Don't silence mkfs.erofs if on a tty

mkfs.erofs is only sometimes verbose when not on a TTY, so let's not
silence it if we're on a TTY.

6 weeks agomkfs-util: Add one more log message
DaanDeMeyer [Sat, 3 Jan 2026 12:00:43 +0000 (13:00 +0100)] 
mkfs-util: Add one more log message

Formatting a filesystem might take a long time, so let's also log a
message when we start formatting it.

6 weeks agocore/dynamic-user: flock() does not return EBUSY
Mike Yuan [Sat, 3 Jan 2026 19:26:27 +0000 (20:26 +0100)] 
core/dynamic-user: flock() does not return EBUSY

6 weeks agoelf-util: fix alignment
Mike Yuan [Sat, 3 Jan 2026 19:08:12 +0000 (20:08 +0100)] 
elf-util: fix alignment

6 weeks agocore: do not provide non-dynamic user through DBus/Varlink
Yu Watanabe [Sat, 3 Jan 2026 03:46:56 +0000 (12:46 +0900)] 
core: do not provide non-dynamic user through DBus/Varlink

With a service with DynamicUser= with static user or group, e.g.,
```
$ systemd-run -p DynamicUser=yes -p Group=disk sleep infinity
```
previously the lookup by name and ID through DBus/Varlink are inconsistent:
```
$ busctl call org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager LookupDynamicUserByUID "u" 6
Call failed: Dynamic user ID 6 does not exist.

$ busctl call org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager LookupDynamicUserByName "s" disk
u 6

$ userdbctl group 6
  Group name: disk
 Disposition: system
         GID: 6
   Passwords: 1
     Service: io.systemd.NameServiceSwitch

$ userdbctl group disk
  Group name: disk
 Disposition: dynamic
         GID: 6
 Description: Dynamic Group
     Service: io.systemd.DynamicUser
```

With this change, the results of these methods are consistent.

Fixes #40228.

6 weeks agoclang-tidy: Enable more warnings (#39910)
Yu Watanabe [Fri, 2 Jan 2026 21:00:30 +0000 (06:00 +0900)] 
clang-tidy: Enable more warnings (#39910)

6 weeks agotree-wide: Migrate to pidref_safe_fork() (#40170)
Daan De Meyer [Fri, 2 Jan 2026 20:12:31 +0000 (21:12 +0100)] 
tree-wide: Migrate to pidref_safe_fork() (#40170)

6 weeks agosystemctl-preset-all: do not return 0 if unit_file_preset_all() fails
Antonio Alvarez Feijoo [Fri, 2 Jan 2026 14:20:20 +0000 (15:20 +0100)] 
systemctl-preset-all: do not return 0 if unit_file_preset_all() fails

Follow-up for ae9ff778cd141f9d24dd4743489b7e1000f22347

6 weeks agoman/systemctl: fix typo
Ulrich Ölmann [Fri, 2 Jan 2026 14:50:19 +0000 (15:50 +0100)] 
man/systemctl: fix typo

6 weeks agotree-wide: Migrate to pidref_safe_fork() 40170/head
Daan De Meyer [Sat, 20 Dec 2025 13:33:35 +0000 (14:33 +0100)] 
tree-wide: Migrate to pidref_safe_fork()

Let's migrate all remaining callers of safe_fork()
to pidref_safe_fork() and get rid of safe_fork().

6 weeks agoprocess-util: Use ret as output parameter name
Daan De Meyer [Sat, 20 Dec 2025 09:48:41 +0000 (10:48 +0100)] 
process-util: Use ret as output parameter name

There's only one output parameter for all these
functions, so let's just name it ret following the
coding style.

6 weeks agopull-tar: Insist on foreign UID when copying
DaanDeMeyer [Fri, 26 Dec 2025 20:58:04 +0000 (21:58 +0100)] 
pull-tar: Insist on foreign UID when copying

If we're doing foreign UID range copying, we're going to be joining
a private user namespace before doing the copy. copy_tree() insists
on keeping all UIDs/GIDs the same when copying. Hence, all the
UIDs/GIDs of the files we're copying should be in the private UID
range, which means they need to be owned by the foreign UID range
and we always need to call mountfsd_mount_directory_fd(). So there's
no point in having a fallback path if the source directory is not
foreign UID range owned, we'd simply fail to copy it later. Hence,
insist on the source directory being foreign UID range owned.

6 weeks agoupdate TODO
Lennart Poettering [Fri, 2 Jan 2026 10:20:12 +0000 (11:20 +0100)] 
update TODO

6 weeks agoclang-tidy: Enable more warnings 39910/head
Daan De Meyer [Fri, 21 Nov 2025 08:26:32 +0000 (09:26 +0100)] 
clang-tidy: Enable more warnings

6 weeks agolinter: Remove unneeded meson options
Daan De Meyer [Sun, 14 Dec 2025 15:48:25 +0000 (16:48 +0100)] 
linter: Remove unneeded meson options

Now that clang-tidy passes regardless of whether
these options are enabled or not, let's stop
configuring them explicitly

6 weeks agoci: Add coverage for -Dcompat-mutable-uid-boundaries=true
Daan De Meyer [Mon, 15 Dec 2025 08:30:44 +0000 (09:30 +0100)] 
ci: Add coverage for -Dcompat-mutable-uid-boundaries=true

6 weeks agolocale: Gate conditional includes behind ifdef
Daan De Meyer [Sun, 14 Dec 2025 15:46:09 +0000 (16:46 +0100)] 
locale: Gate conditional includes behind ifdef

Let's make sure clang-tidy doesn't complain on
distributions without locale-gen.

6 weeks agobasic: Gate conditional includes behind ifdef
Daan De Meyer [Sun, 14 Dec 2025 15:44:48 +0000 (16:44 +0100)] 
basic: Gate conditional includes behind ifdef

6 weeks agolibudev: Fix declaration argument names
Daan De Meyer [Sun, 14 Dec 2025 15:39:49 +0000 (16:39 +0100)] 
libudev: Fix declaration argument names

Make sure these match the definition argument names.

6 weeks agosd-netlink: Use same argument name for rtnl definitions
Daan De Meyer [Sun, 14 Dec 2025 15:07:58 +0000 (16:07 +0100)] 
sd-netlink: Use same argument name for rtnl definitions

We already have the same argument name as used in the
declarations available, let's use it so the declarations
and definitions match.

6 weeks agosd-json: Fix sd_json_variant_type_to_string parameter name
Daan De Meyer [Sun, 14 Dec 2025 15:04:57 +0000 (16:04 +0100)] 
sd-json: Fix sd_json_variant_type_to_string parameter name

The definition will use i because of the macro, so
let's use i in the declaration as well. We can't
use DECLARE_STRING_TABLE_LOOKUP_TO_STRING() because
sd-json.h is a libsystemd public header.

6 weeks agosystemctl-daemon-reload: Add missing parameter name
Daan De Meyer [Sun, 14 Dec 2025 14:48:18 +0000 (15:48 +0100)] 
systemctl-daemon-reload: Add missing parameter name

6 weeks agoclang-tidy: Block system headers with errors
Daan De Meyer [Wed, 26 Nov 2025 14:52:46 +0000 (15:52 +0100)] 
clang-tidy: Block system headers with errors

blkid.h and gmessages.h both use const for arguments that are passed
by value, which is pointless and triggers clang-tidy warnings, so exclude
them from processing.

6 weeks agotree-wide: Various coding style cleanups
Daan De Meyer [Wed, 26 Nov 2025 14:21:09 +0000 (15:21 +0100)] 
tree-wide: Various coding style cleanups

6 weeks agosd-journal: Fix return value coding style
Daan De Meyer [Wed, 26 Nov 2025 10:56:11 +0000 (11:56 +0100)] 
sd-journal: Fix return value coding style

Let's always use ret, ret_data and ret_size for output arguments.

size is better than length in this case because we're dealing with
arbitrary, possibly binary, data and not strings.

6 weeks agosd-journal: Remove const from function parameter
Daan De Meyer [Mon, 15 Dec 2025 08:08:00 +0000 (09:08 +0100)] 
sd-journal: Remove const from function parameter

boot_id is already passed by value, and hence copied.
Since we don't apply const to function parameters
that are copied anywhere else, let's drop the const
here as well for consistency.

6 weeks agotree-wide: Drop NOLINTNEXTLINE comments
DaanDeMeyer [Thu, 1 Jan 2026 20:01:39 +0000 (21:01 +0100)] 
tree-wide: Drop NOLINTNEXTLINE comments

Not needed anymore after recent refactoring.

6 weeks agotree-wide: Use pamh as pam_handle_t parameter name
Daan De Meyer [Fri, 19 Dec 2025 18:43:21 +0000 (19:43 +0100)] 
tree-wide: Use pamh as pam_handle_t parameter name

libpam uses pamh in its function declarations for
the plugin API so let's use the same name in our
tree as well.

Making sure the plugin function definitions match
the plugin function declarations is required to
enable clang-tidy's
readability-inconsistent-declaration-parameter-name
check, but to keep things consistent everywhere we
opt to use pamh tree-wide.

6 weeks agotools: drop unnecessary sys/capability.h header
Yu Watanabe [Thu, 1 Jan 2026 21:20:17 +0000 (06:20 +0900)] 
tools: drop unnecessary sys/capability.h header

After 9b414a38fadb41c9ea056ed5d284ab5098251a37 (#39425), the header is
not required. And after b295c166f94526aae830893612a1584840f2f087, the
header is not installed in CI environments.

6 weeks agotools: show each command to make it easier to debug
Yu Watanabe [Thu, 1 Jan 2026 21:09:39 +0000 (06:09 +0900)] 
tools: show each command to make it easier to debug

6 weeks agotools: allow to run setup-musl-build.sh for already set up directory
Yu Watanabe [Thu, 1 Jan 2026 21:03:27 +0000 (06:03 +0900)] 
tools: allow to run setup-musl-build.sh for already set up directory

6 weeks agoRequire libxcrypt >= 4.4.0 and drop libcrypt support (#38974)
Yu Watanabe [Fri, 2 Jan 2026 05:32:12 +0000 (14:32 +0900)] 
Require libxcrypt >= 4.4.0 and drop libcrypt support (#38974)

This drops support of libcrypt provided by glibc, and always use
libxcrypt.
This also makes libxcrypt dlopen() dependency.

6 weeks agolibcrypt-util: turn into dlopen() dependency 38974/head
Yu Watanabe [Sat, 25 Oct 2025 04:41:33 +0000 (13:41 +0900)] 
libcrypt-util: turn into dlopen() dependency

Note, this drops logging only test case for crypt_preferred_method(),
as that requires explicitly dlopen() the library. But, we should test
that make_salt() and friends automatically dlopen() it.

6 weeks agolibcrypt: allow to build systemd without libcrypt/libxcrypt
Yu Watanabe [Sat, 25 Oct 2025 05:59:54 +0000 (14:59 +0900)] 
libcrypt: allow to build systemd without libcrypt/libxcrypt

libcrypt is only used by firstboot, homed, and sysusers, which can be
disabled by meson option.
Let's not require the library unconditionally.

6 weeks agoRequire libxcrypt-4.4.0 or newer and drop support of libcrypt
Yu Watanabe [Sun, 17 Aug 2025 14:03:44 +0000 (23:03 +0900)] 
Require libxcrypt-4.4.0 or newer and drop support of libcrypt

libcrypt was no longer built by default since glibc-2.38, and it has been
completely removed since glibc-2.39.

Let's always use libxcrypt, unless when building with musl. As already
major distribution already have libxcrypt-4.4.x, hence let's also bump
the required minimum version to 4.4.0.

libxcrypt cannot be built with musl, hence the previous fallback logic
in libcrypt-util.c are moved to musl/crypt.c.

Note, libxcrypt-4.4.0 was released on 2018-11-20.
See also #38608.

6 weeks agoBump required minimum version of libseccomp to 2.4.0
Yu Watanabe [Sun, 17 Aug 2025 15:58:56 +0000 (00:58 +0900)] 
Bump required minimum version of libseccomp to 2.4.0

Major distributions already have libseccomp 2.5.x or newer.
Let's bump to the required minimum version to 2.4.0, which provides
SCMP_ACT_KILL_PROCESS, SCMP_ACT_LOG, SCMP_ARCH_PARISC, and
SCMP_ARCH_PARISC64.

Note, libseccomp 2.4.0 was released on 2019-03-15.

See also #38608.

6 weeks agotest-libcrypt-util: use DEFINE_TEST_MAIN() and ASSERT_XYZ()
Yu Watanabe [Sun, 17 Aug 2025 15:13:27 +0000 (00:13 +0900)] 
test-libcrypt-util: use DEFINE_TEST_MAIN() and ASSERT_XYZ()

Also, tests for make_salt() in test-user-util.c are moved to
test-libcrypt-util.c.

6 weeks agolibcrypt-util: add missing assertions
Yu Watanabe [Tue, 18 Nov 2025 01:28:50 +0000 (10:28 +0900)] 
libcrypt-util: add missing assertions

6 weeks agolibcrypt-util: drop unused hash_passwrod_full()
Yu Watanabe [Tue, 18 Nov 2025 00:52:37 +0000 (09:52 +0900)] 
libcrypt-util: drop unused hash_passwrod_full()

It is only used by test cases. Not necessary to keep it.

6 weeks agolibcrypt-util: move looks_like_hashed_password()
Yu Watanabe [Tue, 18 Nov 2025 00:27:14 +0000 (09:27 +0900)] 
libcrypt-util: move looks_like_hashed_password()

No functional change, just preparation for later change.

6 weeks agoBump required minimum version of cryptsetup to 2.4.0
Yu Watanabe [Sun, 17 Aug 2025 12:22:16 +0000 (21:22 +0900)] 
Bump required minimum version of cryptsetup to 2.4.0

Major distributions already have cryptsetup newer than 2.4.0.
Let's bump the minimal required version.

Note, cryptsetup 2.4.0 was released on 2021-08-18.

See also #38608.

6 weeks agoBump required minimum version of elfutils to 0.177
Yu Watanabe [Sun, 17 Aug 2025 13:19:50 +0000 (22:19 +0900)] 
Bump required minimum version of elfutils to 0.177

Major distributions already have elfutils >= 0.190.
Let's bump the required minimum version.

Note, elfutils 0.177 was released on 2019-08-14.

See also #38608.

6 weeks agoBump required minimum version of blkid to 2.37
Yu Watanabe [Sun, 17 Aug 2025 13:05:53 +0000 (22:05 +0900)] 
Bump required minimum version of blkid to 2.37

Major distributions already have blkid >= 2.37.
Let's bump the minimal required version.

Note, util-linux (which provides blkid) 2.37 was released on 2021-06-01.

See also #38608.

6 weeks agoBump required minimum version of OpenSSL to 3.0.0
Yu Watanabe [Sun, 17 Aug 2025 12:41:22 +0000 (21:41 +0900)] 
Bump required minimum version of OpenSSL to 3.0.0

All major distributions have switched to OpenSSL version 3.x.
Let's drop support of OpenSSL version 1.x.

Note, OpenSSL 3.0 was released on 2021-09-07 (and will be EOL on 2026-09-07).

See also #38608.

6 weeks agoman: drop redundant 'and'
Yu Watanabe [Fri, 2 Jan 2026 00:52:28 +0000 (09:52 +0900)] 
man: drop redundant 'and'

Also swap the order of entries, to make it consistent for other unit
types.

Follow-up for 79dd24cf14adc809620479d45a7b469cf3e82892.

6 weeks agoEnable systemd-coredump for offline updates
Adam Williamson [Mon, 17 Nov 2025 22:35:11 +0000 (14:35 -0800)] 
Enable systemd-coredump for offline updates

If a crash occurs during an offline update, we do not get a
coredump, because systemd-coredump is not enabled. This of course
complicates debugging.

Signed-off-by: Adam Williamson <awilliam@redhat.com>