github: Drop 16.04 tests

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #3979 from brauner/2021-09-27.fixes

build: add commands, hooks, and templates

hooks: fix quoting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

templates: don't double quote

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add templates

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: fix remaining HAVE_* generations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix HAVE_* checks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmds: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmds: fix integer conversions

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-monitord: use {} around ;

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add cmd builds

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add hooks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: build hooks directly in their folder

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3978 from brauner/2021-09-23.fixes

build: improve meson build

build: improve meson build

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3977 from brauner/2021-09-16.fixes

build: fixes

build: use dummy config data

to avoid having to rely on newer meson features.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: expand default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add commands

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: split netns_ifaddrs into separate sources

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

hooks: use cloexec everywhere

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: fix tools build

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: fix hook program build

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3976 from stgraber/master

Don't include internal headers in external library headers

Don't include internal headers in external library headers

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #3974 from brauner/2021-09-15.fixes.2

tools: use correct include for Android

tools: use correct include for Android

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3972 from brauner/2021-09-15.fixes

build: ensure all relevant calls are checked for availability at buil…

build: support lto

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: fix declarations and headers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: ensure all relevant calls are checked for availability at build time

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3966 from denisfa/improve-bash-completion-ext

Improve bash completion - part 2.

Merge pull request #3963 from brauner/2021-09-03.build

build: add basic meson support

build: show more detailed information

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: record meson version

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: use correct minimal meson version requirement

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: remove pointless prefixdir validation

Meson will handle this internall and treat a non-absolute path as an
error.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3968 from brauner/2021-09-03.fixes.2

tests: fix config file tests

Merge pull request #3967 from brauner/2021-09-03.fixes

log: fix cross-compilation with %m modifier

tests: fix config file tests

Link: https://bugs.launchpad.net/bugs/1943441
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

log: fix cross-compilation with %m modifier

Fixes: #3961
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set more variables and print summary

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add more global config variables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set diagnostic colours directly in default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add single option directly to static library

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: remove unneeded variables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: use common dependencies variable

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: libdir and bindir are the default for shared libraries and executables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set find_library('libcap', require : false)

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: -fPIC and -shared are handled automatically

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: use dependency() where possible

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set as-needed in default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set pie in default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fix `lxc-cgroup` smart completion.

Also make bash function more readable for itself.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Refactor ` __lxc_check_name_present()`.

Print name of container found, if any.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Check completion for prefixes names.

If a name is a prefix of another word available for completion, adjust
to show all words with given prefix.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add `__lxc_cgroup_state_object()`.

Support cgroup state-object completion values for `lxc-cgroup`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Update `_lxc_usernsexec`.

Not really much can be done for this function, as `-m` requires an ID
mapping that has to be manually input, since it will use
`/etc/sub{g,u}id` if not specified.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add completion for `lxc-copy` param `--fssize`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add `__lxc_get_selinux_contexts()`.

List SElinux contexts available. Not clear if this could be only for
root or if normal user with `sudo` is also supported.

Using `Fedora34` for basic testing.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Refactor `__lxc_groups()` to `__lxc_get_groups()`.

Make code logic be more clear to what it is being done.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Another round of more bash-like syntax.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Fix `lxc-create` completion.

Do not append a name of an existing container.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add support for comma as a completion word.

For `lxc-ls --groups` and `lxc-autostart --groups`.
Support leading comma, trailing comma, embedded double comma.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Refactor `__lxc_piped_args`.

Use bash functions for common array operations. Keep code logic somewhat
easy to read for bug hunting.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Fix `lxc-snapshot` completion.

For options `-r,--restore` and `-d,--destroy`, we need the container
name to create the list of completion values.

Therefore, it is needed to scan the current command line to check if
there is a container name available.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Use more bash-like syntax.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add support for container composed names.

When a container name has whitespace in it
(e.g. created by `lxc-create -t download -n "arch linux"` ),
the completion for other commands should be able to work by adding a
backslash to escape it.

Although it may be interesting to support names between quotes, this
would probably means to have to add quotes to all names. Might not be
interesting just due to an edge case.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add completion output for `lxc-ls --fancy-format`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Improve name completion handling.

Use regex to handle short option `-n`, since short options can be
combined (e.g. `-nd`) as long as at max one requires an argument.

Also consider the case when the arg for the long option is not given
together with `--name=`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add `compopt` call to `__lxc_piped_args`.

On pair with how other functions do it. Also, be smarter about adding
whitespace when there are no more completions available for the
parameter.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Use `--running` instead of `--active`.

Commands block if container is frozen.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Fill missing commands on name completion.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

build: add tools to meson

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add meson skeleton

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: make sure _GNU_SOURCE is set

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc: remove "version.h" inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tests: include "version.h"

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix config.h inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: fix build warnings

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix lxc header inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

caps: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools/lxc_start: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

arguments: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

initutils: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

log: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

initutils: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

string_utils: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

arguments: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commands_utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

file_utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

monitor: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

nl: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

uuid: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

seccomp: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcmntent: fix fallthrough

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

netns_ifaddrs: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>