README.md: mention RISC-V architecture

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Add riscv64 to --arch parameter values

lxc-attach uses an --arch parameter. 'riscv64' should be a usable value.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Merge pull request #4000 from brauner/2021-10-18.fixes

conf: fixes

conf: don't fail umount2()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix coding style

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3997 from brauner/2021-10-15.fixes

log: fixes

caps: ensure \0-termination

Fixes: Coverity 1492865
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: improve error logging

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

af_unix: replace log_error_errno()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3996 from tych0/fix-criu-log

criu: fix error message

criu: fix error message

as of 59d8a539d106 ("criu: massage exec_criu()") I see:

In file included from criu.c:22:
criu.c: In function 'exec_criu':
log.h:376:2: error: '%s' directive argument is null [-Werror=format-overflow=]
  376 |  LXC_ERROR(&locinfo, format, ##__VA_ARGS__);   \
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
log.h:457:3: note: in expansion of macro 'ERROR'
  457 |   ERROR("%s - " format, ptr, ##__VA_ARGS__); \
      |   ^~~~~
log.h:491:3: note: in expansion of macro 'SYSERROR'
  491 |   SYSERROR(format, ##__VA_ARGS__);              \
      |   ^~~~~~~~
criu.c:325:11: note: in expansion of macro 'log_error_errno'
  325 |    return log_error_errno(-ENOMEM, ENOMEM, "Failed to remove extraneous slashes from \"%s\"", tmp);
      |           ^~~~~~~~~~~~~~~

it looks like we should be logging the string that failed, vs. tmp here.

(my log was taken from stable-4.0, but the same issue exists on master it
seems.)

Signed-off-by: Tycho Andersen <tycho@tycho.pizza>

Merge pull request #3995 from brauner/2021-10-13.fixes

tree-wide: capability tests and fixes

test: fix nested capability tests

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: improve error logging for drop_capabilities()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tests: expand capability tests

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: use __u32 for capabilities

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: use __u32 for cpumasks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3994 from brauner/2021-10-12.fixes

conf: improve and fix lxc.cap.keep

conf: improve capability handling

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tests: add test for lxc.cap.keep

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix lxc.cap.keep behavior

Fixes: ##3993
Fixes: 20ab75789eb9 ("conf: simplify and port caps to new list type")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3992 from brauner/2021-10-11.fixes

terminal: log at warning message

terminal: log at warning message

The lxc_devpts_terminal() helper is called in contexts where it can fail
due to various reasons but where we safely fallback to allocating
terminal devices on the host. Logging error messages irritates users so
just log warning messages.

Link: https://discuss.linuxcontainers.org/t/lxc-attach-error-failed-to-open-terminal-multiplexer-device
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3988 from brauner/2021-10-04.fixes

log: improve %m handling on musl

log: improve %m handling on musl

Fixes: #3961
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3987 from brauner/2021-10-01.fixes

start: make failure to apply core scheduling fatal

start: make failure to apply core scheduling fatal

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3986 from brauner/2021-10-01.fixes

lxc: core scheduling tweaks

start: use core scheduling error helper

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: don't fail when core scheduling isn't supported

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

syscall_wrappers: fix core scheduling creation helper naming

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3985 from brauner/2021-09-30.fixes.2

tree-wide: cast to core scheduling cookie to llu

tree-wide: cast to core scheduling cookie to llu

Link: https://launchpadlibrarian.net/561086365/buildlog_ubuntu-focal-ppc64el.lxc_1%3A4.0.10+master~20210930-1812-0ubuntu1~focal_BUILDING.txt.gz
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3984 from brauner/2021-09-29.core_scheduling

lxc: core scheduling support

attach: handle core scheduling

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3983 from brauner/2021-09-29.fixes

build: compiler attribute improvements

lxc: add lxc.sched.core

Core scheduling defines if the container payload is marked as being
schedulable on the same core. Doing so will cause the kernel scheduler
to ensure that tasks that are not in the same group never run
simultaneously on a core. This can serve as an extra security measure to
prevent the container payload from using cross hyper thread attacks.

The only allowed values are 0 and 1. Set this to 1 to create a core
scheduling domain for the container or 0 to not create one. If not set
explicitly no core scheduling domain will be created for the container.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

initutils: add missing prctl include

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: compiler attribute improvements

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3982 from stgraber/master

github: Drop 16.04 tests

Merge pull request #3981 from brauner/2021-09-28.fixes

build: check whether compiler supports nonnull and returns_nonnull at…

github: Drop 16.04 tests

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

build: check whether compiler supports nonnull and returns_nonnull attributes

Fixes: #3980
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3979 from brauner/2021-09-27.fixes

build: add commands, hooks, and templates

hooks: fix quoting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

templates: don't double quote

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add templates

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: fix remaining HAVE_* generations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix HAVE_* checks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmds: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmds: fix integer conversions

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-monitord: use {} around ;

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add cmd builds

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add hooks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: build hooks directly in their folder

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3978 from brauner/2021-09-23.fixes

build: improve meson build

build: improve meson build

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3977 from brauner/2021-09-16.fixes

build: fixes

build: use dummy config data

to avoid having to rely on newer meson features.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: expand default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add commands

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: split netns_ifaddrs into separate sources

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

hooks: use cloexec everywhere

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: fix tools build

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: fix hook program build

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3976 from stgraber/master

Don't include internal headers in external library headers

Don't include internal headers in external library headers

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Merge pull request #3974 from brauner/2021-09-15.fixes.2

tools: use correct include for Android

tools: use correct include for Android

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3972 from brauner/2021-09-15.fixes

build: ensure all relevant calls are checked for availability at buil…

build: support lto

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: fix declarations and headers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: ensure all relevant calls are checked for availability at build time

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3966 from denisfa/improve-bash-completion-ext

Improve bash completion - part 2.

Merge pull request #3963 from brauner/2021-09-03.build

build: add basic meson support

build: show more detailed information

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: record meson version

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: use correct minimal meson version requirement

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: remove pointless prefixdir validation

Meson will handle this internall and treat a non-absolute path as an
error.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #3968 from brauner/2021-09-03.fixes.2

tests: fix config file tests

Merge pull request #3967 from brauner/2021-09-03.fixes

log: fix cross-compilation with %m modifier

tests: fix config file tests

Link: https://bugs.launchpad.net/bugs/1943441
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

log: fix cross-compilation with %m modifier

Fixes: #3961
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set more variables and print summary

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add more global config variables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set diagnostic colours directly in default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add single option directly to static library

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: remove unneeded variables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: use common dependencies variable

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: libdir and bindir are the default for shared libraries and executables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set find_library('libcap', require : false)

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: -fPIC and -shared are handled automatically

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: use dependency() where possible

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set as-needed in default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: set pie in default_options

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fix `lxc-cgroup` smart completion.

Also make bash function more readable for itself.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Refactor ` __lxc_check_name_present()`.

Print name of container found, if any.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Check completion for prefixes names.

If a name is a prefix of another word available for completion, adjust
to show all words with given prefix.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add `__lxc_cgroup_state_object()`.

Support cgroup state-object completion values for `lxc-cgroup`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>