]>
git.ipfire.org Git - thirdparty/lxc.git/log
Christian Brauner [Wed, 20 Oct 2021 12:48:41 +0000 (14:48 +0200)]
criu: support restoring containers with pre-created veth devices
We did th CRIU and kernel work but for some reason we never did push the
LXC work.
Link: https://github.com/checkpoint-restore/criu/commit/cdb0d427020f0531f5a35146513c3a36b6eece11
commit
cdb0d427020f ("net: allow restoring of precreated veth devices")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Tue, 19 Oct 2021 15:24:26 +0000 (11:24 -0400)]
Merge pull request #4003 from brauner/2021-10-19.fixes
conf: verify that rootfs is stable after setting up mounts
Christian Brauner [Tue, 19 Oct 2021 14:57:05 +0000 (16:57 +0200)]
conf: verify that rootfs is stable after setting up mounts
Apparently some users changed their rootfs via their lxc.mount.entry
entries. Let's not allow that as that can cause confusion during
container setup. So lets verify that the rootfs is stable after setup.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Tue, 19 Oct 2021 14:58:23 +0000 (10:58 -0400)]
Merge pull request #4002 from xypron/riscv64
Riscv64
Heinrich Schuchardt [Tue, 19 Oct 2021 11:16:33 +0000 (13:16 +0200)]
README.md: mention RISC-V architecture
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Heinrich Schuchardt [Tue, 19 Oct 2021 07:56:21 +0000 (09:56 +0200)]
Add riscv64 to --arch parameter values
lxc-attach uses an --arch parameter. 'riscv64' should be a usable value.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Stéphane Graber [Mon, 18 Oct 2021 14:01:24 +0000 (10:01 -0400)]
Merge pull request #4000 from brauner/2021-10-18.fixes
conf: fixes
Christian Brauner [Mon, 18 Oct 2021 10:07:37 +0000 (12:07 +0200)]
conf: don't fail umount2()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 18 Oct 2021 09:46:16 +0000 (11:46 +0200)]
conf: fix coding style
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Fri, 15 Oct 2021 13:19:47 +0000 (09:19 -0400)]
Merge pull request #3997 from brauner/2021-10-15.fixes
log: fixes
Christian Brauner [Fri, 15 Oct 2021 09:29:27 +0000 (11:29 +0200)]
caps: ensure \0-termination
Fixes: Coverity 1492865
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 15 Oct 2021 08:06:48 +0000 (10:06 +0200)]
attach: improve error logging
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 15 Oct 2021 07:59:28 +0000 (09:59 +0200)]
af_unix: replace log_error_errno()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 14 Oct 2021 17:02:36 +0000 (13:02 -0400)]
Merge pull request #3996 from tych0/fix-criu-log
criu: fix error message
Tycho Andersen [Thu, 14 Oct 2021 16:40:08 +0000 (10:40 -0600)]
criu: fix error message
as of
59d8a539d106 ("criu: massage exec_criu()") I see:
In file included from criu.c:22:
criu.c: In function 'exec_criu':
log.h:376:2: error: '%s' directive argument is null [-Werror=format-overflow=]
376 | LXC_ERROR(&locinfo, format, ##__VA_ARGS__); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
log.h:457:3: note: in expansion of macro 'ERROR'
457 | ERROR("%s - " format, ptr, ##__VA_ARGS__); \
| ^~~~~
log.h:491:3: note: in expansion of macro 'SYSERROR'
491 | SYSERROR(format, ##__VA_ARGS__); \
| ^~~~~~~~
criu.c:325:11: note: in expansion of macro 'log_error_errno'
325 | return log_error_errno(-ENOMEM, ENOMEM, "Failed to remove extraneous slashes from \"%s\"", tmp);
| ^~~~~~~~~~~~~~~
it looks like we should be logging the string that failed, vs. tmp here.
(my log was taken from stable-4.0, but the same issue exists on master it
seems.)
Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
Stéphane Graber [Thu, 14 Oct 2021 14:38:18 +0000 (10:38 -0400)]
Merge pull request #3995 from brauner/2021-10-13.fixes
tree-wide: capability tests and fixes
Christian Brauner [Thu, 14 Oct 2021 11:59:34 +0000 (13:59 +0200)]
test: fix nested capability tests
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 14 Oct 2021 09:52:06 +0000 (11:52 +0200)]
attach: improve error logging for drop_capabilities()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 14 Oct 2021 09:17:15 +0000 (11:17 +0200)]
tests: expand capability tests
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 13 Oct 2021 16:51:48 +0000 (18:51 +0200)]
tree-wide: use __u32 for capabilities
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 13 Oct 2021 16:30:00 +0000 (18:30 +0200)]
cgroups: use __u32 for cpumasks
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 13 Oct 2021 13:25:59 +0000 (09:25 -0400)]
Merge pull request #3994 from brauner/2021-10-12.fixes
conf: improve and fix lxc.cap.keep
Christian Brauner [Wed, 13 Oct 2021 11:38:14 +0000 (13:38 +0200)]
conf: improve capability handling
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 12 Oct 2021 14:48:02 +0000 (16:48 +0200)]
tests: add test for lxc.cap.keep
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 12 Oct 2021 14:33:14 +0000 (16:33 +0200)]
conf: fix lxc.cap.keep behavior
Fixes: ##3993
Fixes: 20ab75789eb9 ("conf: simplify and port caps to new list type")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 11 Oct 2021 14:30:46 +0000 (10:30 -0400)]
Merge pull request #3992 from brauner/2021-10-11.fixes
terminal: log at warning message
Christian Brauner [Mon, 11 Oct 2021 13:21:45 +0000 (15:21 +0200)]
terminal: log at warning message
The lxc_devpts_terminal() helper is called in contexts where it can fail
due to various reasons but where we safely fallback to allocating
terminal devices on the host. Logging error messages irritates users so
just log warning messages.
Link: https://discuss.linuxcontainers.org/t/lxc-attach-error-failed-to-open-terminal-multiplexer-device
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 4 Oct 2021 13:14:18 +0000 (09:14 -0400)]
Merge pull request #3988 from brauner/2021-10-04.fixes
log: improve %m handling on musl
Christian Brauner [Mon, 4 Oct 2021 09:23:55 +0000 (11:23 +0200)]
log: improve %m handling on musl
Fixes: #3961
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Fri, 1 Oct 2021 14:33:23 +0000 (10:33 -0400)]
Merge pull request #3987 from brauner/2021-10-01.fixes
start: make failure to apply core scheduling fatal
Christian Brauner [Fri, 1 Oct 2021 08:27:04 +0000 (10:27 +0200)]
start: make failure to apply core scheduling fatal
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Fri, 1 Oct 2021 12:52:01 +0000 (08:52 -0400)]
Merge pull request #3986 from brauner/2021-10-01.fixes
lxc: core scheduling tweaks
Christian Brauner [Fri, 1 Oct 2021 08:14:08 +0000 (10:14 +0200)]
start: use core scheduling error helper
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 1 Oct 2021 08:12:43 +0000 (10:12 +0200)]
start: don't fail when core scheduling isn't supported
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 1 Oct 2021 08:12:17 +0000 (10:12 +0200)]
syscall_wrappers: fix core scheduling creation helper naming
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 30 Sep 2021 21:17:07 +0000 (17:17 -0400)]
Merge pull request #3985 from brauner/2021-09-30.fixes.2
tree-wide: cast to core scheduling cookie to llu
Christian Brauner [Thu, 30 Sep 2021 20:48:04 +0000 (22:48 +0200)]
Stéphane Graber [Thu, 30 Sep 2021 17:56:25 +0000 (13:56 -0400)]
Merge pull request #3984 from brauner/2021-09-29.core_scheduling
lxc: core scheduling support
Christian Brauner [Wed, 29 Sep 2021 12:35:41 +0000 (14:35 +0200)]
attach: handle core scheduling
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 29 Sep 2021 16:45:09 +0000 (12:45 -0400)]
Merge pull request #3983 from brauner/2021-09-29.fixes
build: compiler attribute improvements
Christian Brauner [Wed, 29 Sep 2021 11:16:26 +0000 (13:16 +0200)]
lxc: add lxc.sched.core
Core scheduling defines if the container payload is marked as being
schedulable on the same core. Doing so will cause the kernel scheduler
to ensure that tasks that are not in the same group never run
simultaneously on a core. This can serve as an extra security measure to
prevent the container payload from using cross hyper thread attacks.
The only allowed values are 0 and 1. Set this to 1 to create a core
scheduling domain for the container or 0 to not create one. If not set
explicitly no core scheduling domain will be created for the container.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 29 Sep 2021 11:16:05 +0000 (13:16 +0200)]
initutils: add missing prctl include
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 29 Sep 2021 08:02:39 +0000 (10:02 +0200)]
build: compiler attribute improvements
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 28 Sep 2021 21:09:44 +0000 (23:09 +0200)]
Merge pull request #3982 from stgraber/master
github: Drop 16.04 tests
Stéphane Graber [Tue, 28 Sep 2021 20:58:59 +0000 (16:58 -0400)]
Merge pull request #3981 from brauner/2021-09-28.fixes
build: check whether compiler supports nonnull and returns_nonnull at…
Stéphane Graber [Tue, 28 Sep 2021 20:58:44 +0000 (16:58 -0400)]
github: Drop 16.04 tests
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Christian Brauner [Tue, 28 Sep 2021 09:49:26 +0000 (11:49 +0200)]
build: check whether compiler supports nonnull and returns_nonnull attributes
Fixes: #3980
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 27 Sep 2021 13:39:39 +0000 (09:39 -0400)]
Merge pull request #3979 from brauner/2021-09-27.fixes
build: add commands, hooks, and templates
Christian Brauner [Mon, 27 Sep 2021 10:46:29 +0000 (12:46 +0200)]
hooks: fix quoting
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:42:22 +0000 (12:42 +0200)]
templates: don't double quote
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:39:10 +0000 (12:39 +0200)]
build: add templates
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:22:12 +0000 (12:22 +0200)]
build: fix remaining HAVE_* generations
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:15:05 +0000 (12:15 +0200)]
tree-wide: fix HAVE_* checks
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:09:17 +0000 (12:09 +0200)]
cmds: fix includes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:04:34 +0000 (12:04 +0200)]
cmds: fix integer conversions
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 10:03:20 +0000 (12:03 +0200)]
lxc-monitord: use {} around ;
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 09:42:58 +0000 (11:42 +0200)]
build: add cmd builds
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 09:06:50 +0000 (11:06 +0200)]
build: add hooks
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 27 Sep 2021 08:48:29 +0000 (10:48 +0200)]
build: build hooks directly in their folder
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 23 Sep 2021 21:14:05 +0000 (17:14 -0400)]
Merge pull request #3978 from brauner/2021-09-23.fixes
build: improve meson build
Christian Brauner [Thu, 23 Sep 2021 12:05:24 +0000 (14:05 +0200)]
build: improve meson build
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 16 Sep 2021 14:45:44 +0000 (10:45 -0400)]
Merge pull request #3977 from brauner/2021-09-16.fixes
build: fixes
Christian Brauner [Thu, 16 Sep 2021 14:04:33 +0000 (16:04 +0200)]
build: use dummy config data
to avoid having to rely on newer meson features.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 16 Sep 2021 13:59:49 +0000 (15:59 +0200)]
build: expand default_options
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 16 Sep 2021 13:20:13 +0000 (15:20 +0200)]
build: add commands
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 16 Sep 2021 13:19:53 +0000 (15:19 +0200)]
build: split netns_ifaddrs into separate sources
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 16 Sep 2021 12:10:56 +0000 (14:10 +0200)]
hooks: use cloexec everywhere
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 16 Sep 2021 08:54:02 +0000 (10:54 +0200)]
build: fix tools build
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 16 Sep 2021 08:48:25 +0000 (10:48 +0200)]
build: fix hook program build
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Thu, 16 Sep 2021 03:43:52 +0000 (23:43 -0400)]
Merge pull request #3976 from stgraber/master
Don't include internal headers in external library headers
Stéphane Graber [Thu, 16 Sep 2021 03:05:47 +0000 (23:05 -0400)]
Don't include internal headers in external library headers
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Stéphane Graber [Wed, 15 Sep 2021 19:15:41 +0000 (15:15 -0400)]
Merge pull request #3974 from brauner/2021-09-15.fixes.2
tools: use correct include for Android
Christian Brauner [Wed, 15 Sep 2021 18:26:11 +0000 (20:26 +0200)]
tools: use correct include for Android
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 15 Sep 2021 14:15:53 +0000 (10:15 -0400)]
Merge pull request #3972 from brauner/2021-09-15.fixes
build: ensure all relevant calls are checked for availability at buil…
Christian Brauner [Wed, 15 Sep 2021 08:42:04 +0000 (10:42 +0200)]
build: support lto
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 15 Sep 2021 08:28:50 +0000 (10:28 +0200)]
cgroups: fix declarations and headers
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 15 Sep 2021 08:12:41 +0000 (10:12 +0200)]
network: fix integer comparisons
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 15 Sep 2021 07:07:51 +0000 (09:07 +0200)]
build: ensure all relevant calls are checked for availability at build time
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Wed, 15 Sep 2021 03:33:57 +0000 (23:33 -0400)]
Merge pull request #3966 from denisfa/improve-bash-completion-ext
Improve bash completion - part 2.
Stéphane Graber [Wed, 15 Sep 2021 02:41:55 +0000 (22:41 -0400)]
Merge pull request #3963 from brauner/2021-09-03.build
build: add basic meson support
Christian Brauner [Tue, 14 Sep 2021 09:01:59 +0000 (11:01 +0200)]
build: show more detailed information
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 14 Sep 2021 08:34:05 +0000 (10:34 +0200)]
build: record meson version
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 14 Sep 2021 08:23:37 +0000 (10:23 +0200)]
build: use correct minimal meson version requirement
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Tue, 14 Sep 2021 08:03:12 +0000 (10:03 +0200)]
build: remove pointless prefixdir validation
Meson will handle this internall and treat a non-absolute path as an
error.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Mon, 13 Sep 2021 12:41:41 +0000 (08:41 -0400)]
Merge pull request #3968 from brauner/2021-09-03.fixes.2
tests: fix config file tests
Stéphane Graber [Mon, 13 Sep 2021 12:37:25 +0000 (08:37 -0400)]
Merge pull request #3967 from brauner/2021-09-03.fixes
log: fix cross-compilation with %m modifier
Christian Brauner [Mon, 13 Sep 2021 11:55:17 +0000 (13:55 +0200)]
tests: fix config file tests
Link: https://bugs.launchpad.net/bugs/1943441
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 10:29:22 +0000 (12:29 +0200)]
log: fix cross-compilation with %m modifier
Fixes: #3961
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 09:21:23 +0000 (11:21 +0200)]
build: set more variables and print summary
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 09:03:34 +0000 (11:03 +0200)]
build: add more global config variables
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 08:15:01 +0000 (10:15 +0200)]
build: set diagnostic colours directly in default_options
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 08:14:45 +0000 (10:14 +0200)]
build: add single option directly to static library
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 08:09:45 +0000 (10:09 +0200)]
build: remove unneeded variables
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 08:05:48 +0000 (10:05 +0200)]
build: use common dependencies variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 08:01:46 +0000 (10:01 +0200)]
build: libdir and bindir are the default for shared libraries and executables
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 07:58:44 +0000 (09:58 +0200)]
build: set find_library('libcap', require : false)
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 07:57:53 +0000 (09:57 +0200)]
build: -fPIC and -shared are handled automatically
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 07:54:17 +0000 (09:54 +0200)]
build: use dependency() where possible
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 07:44:32 +0000 (09:44 +0200)]
build: set as-needed in default_options
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 13 Sep 2021 07:43:29 +0000 (09:43 +0200)]
build: set pie in default_options
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>