config-bcast: fix incorrect broadcast address calculation

Signed-off-by: Irnes Mujkanovic <irnes.mujkanovic@gmail.com>

Merge pull request #4517 from mihalicyn/lxc_attach_regression_fix

lxc/attach: Revert "- LXC attach should exit on SIGCHLD"

lxc/attach: Revert "- LXC attach should exit on SIGCHLD"

This reverts commit f02158439677d0c1d4b2ed2ed1ba9bc43923a05d.

Let's revert this change as it introduces 2 regressions:
1. it's not correct to do exit(2) from a signal handler in this case,
as we skip a proper cleaning procedures like restoring PTY configuration
state (see lxc_terminal_delete()) which leads to a problem with a PTY after lxc-attach exits.

[ hint: just try to use lxc-attach on a main branch with this change and you will
see it. After lxc-attach exits you won't be able to type anything in your
current terminal session as it's messed up. ]

2. this introduces race-condition in the code which leads to a
regression on LXD/(and I believe Incus too) which can be seen as
random "Failed to retrieve PID of executing child process" errors
on "lxc exec"/"incus exec" commands. It's extremely hard to reproduce,
but my guess is that we are getting a race condition here, because
by the time when we set a new signal handler for SIGCHLD, transient process
is still alive and when it exists it generates SIGCHLD which may lead to
exit().

3. This changes a behavior of lxc-attach which was there for *years*
and it's quite scary to be honest. I'm not against having this change, but
in a different form, for example we can add a new command line parameter for
lxc-attach command which will enable this behavior.

My first attempt was to fix that change to prevent race, but then
I've noticed that we also have a more serious problem described in (1),
this requires more work to do.

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

Merge pull request #4512 from sdanailo-42/chore/add-useful-logging

conf: useful logging for capabilities

Merge pull request #4511 from sdanailo-42/fix/dbus-hard-coded-address

dbus: replace hardcoded dbus address with environment variable

conf: warn when capabilities are disabled or libcap is not found

The reason for this warning, is that the project will compile and when it does
not work, it's not clear from the logs what the reason might be.

Signed-off-by: Sotir Danailov <sndanailov@gmail.com>

dbus: replace hardcoded dbus address with environment variable

Signed-off-by: Sotir Danailov <sndanailov@gmail.com>

conf: log name of invalid capability in error

Signed-off-by: Sotir Danailov <sndanailov@gmail.com>

Merge pull request #4510 from asainkujovic/undefisnotzero

confile-vlanid: undefined is not a zero value

confile-vlanid: undefined is not a zero value

Signed-off-by: Asain Kujovic <asainnp@gmail.com>

Merge pull request #4509 from asainkujovic/lxc-attach-exit

- LXC attach should exit on SIGCHLD

- LXC attach should exit on SIGCHLD

Signed-off-by: Asain Kujovic <asainnp@gmail.com>

Merge pull request #4506 from stgraber/main

Github Actions improvements

github: Improve progress reporting

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

github: Cleanup OSS-fuzz

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

github: Rework test workflow

Introduce a main "tests" workflow which runs the LXC testsuite on both
x86_64 and aarch64, on a variety of compilers and OS as well as handling
the santizer runs.

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

github: Introduce shared testsuite logic

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

github: Introduce shared build logic

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

github: Update coverity workflow

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4491 from gjaekel/patch-2

fix return code of recursive all of cgroup_tree_prune

Merge pull request #4503 from stgraber/main

init.lxc: Tweak signal handling

lxc.init: Allow SIGHUP from outside the container

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

lxc.init: Ignore user signals coming from inside the contianer

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

lxc.init: Switch to sigaction

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4497 from ElJeffe/enter_net_before_user_ns

network config of unprivileged containers is not shown

lxccontainer: fix enter_net_ns helper to work when netns is inherited

If a network namespace is shared by setting lxc.namespace.share.net and
the container is unprivileged, then the network namespace should be
entered before entering the user namespace. However, if an unprivileged
user started a container, then the network namespace should be entered
after entering the user namespace. To solve this, we try to enter the
network namespace before entering the user namespace. If it did not
succeed, it will be tried again inside the uder namespace.

Signed-off-by: Jef Steelant <jef.steelant_ext@softathome.com>

Merge pull request #4495 from stgraber/main

lxc-net: Replace random IPv6 subnet

lxc-net: Replace random IPv6 subnet

This is meant to be a completely random ULA subnet.

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4493 from tttuuu888/work-issue-4492

meson: fix minor typo

meson: fix minor typo

Fixes: https://github.com/lxc/lxc/issues/4492
Signed-off-by: Seungki Kim <tttuuu888@gmail.com>

fix return code of recursive all of cgroup_tree_prune

Signed-off-by: Guido Jäkel <g.jaekel@dnb.de>

Merge pull request #4488 from sgalgano/fix-4476

Avoid null pointer dereference when using shared rootfs

Avoid null pointer dereference when using shared rootfs.
rootfs->storage not set by lxc_storage_prepare when using a shared
rootfs.

Fixes: https://github.com/lxc/lxc/issues/4476
Signed-off-by: Steven Galgano <sgalgano@adjacentlink.com>

Merge pull request #4487 from hallyn/kurt-cb/lxc

create_run_template: don't use txtuid and txtguid out of scope

create_run_template: don't use txtuid and txtguid out of scope

It's ok that we don't free the malloc()d space since we're
immediately exec()ing.

Originally-by: Kurt Godwin <kgodwin@itron.com>
Reported-by: Kurt Godwin <kgodwin@itron.com>
Signed-off-by: Serge Hallyn <serge@hallyn.com>

Merge pull request #4482 from hallyn/2024-09-16/static

meson.build: add -ffat-lto-objects

Merge pull request #4483 from ariel-miculas/support_puzzlefs

Add suppport for PuzzleFS images in the oci template

Add suppport for PuzzleFS images in the oci template

PuzzleFS images (media type 'application/vnd.puzzlefs.image.rootfs.v1')
can be mounted in a similar way to squashfs images, we just have to
detect the type and reuse the existing code for providing a mount
helper. PuzzleFS is a next-generation container filesystem [1] with
several benefits, such as  reduced duplication, reproducible image
builds, direct mounting support and memory safety guarantees.

Since PuzzleFS currently doesn't provide an image config, also add
support for empty image configs, they are supported by the OCI spec [2].

The MOUNT_HELPER is now passed a `--persist <upperdir>` flag, so it
knows that it needs to create an overlay. This is needed because LXC
expects a writable rootfs and both atomfs and puzzlefs are read-only
filesystems.

Example:
```
$ sudo env PATH=$PATH build/src/lxc/tools/lxc-create --name mycontainer -t \
oci -- --url oci:/$HOME/.local/share/puzzlefs/pfs_ubuntu:eg --no-cache

$ sudo build/src/lxc/tools/lxc-start --name mycontainer --foreground /bin/bash
```

--no-cache is needed for puzzlefs until [3] is solved

[1] https://github.com/project-machine/puzzlefs
[2] https://github.com/opencontainers/image-spec/blob/main/manifest.md#image-manifest
[3] https://github.com/project-machine/puzzlefs/issues/131

Signed-off-by: Ariel Miculas-Trif <amiculas@cisco.com>

meson.build: drop suggest-attribute=noreturn build option

The suggest-attribute=noreturn option marks functions which will
never return, to give the compiler some hints.  It catches all of
our src/lxc/tools/*.c *_main functions as follows:

error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn]

But if we mark those __noreturn, then  the compiler complains that:

../src/lxc/tools/lxc_attach.c:320:53: warning: ‘main’ specifies less restrictive attribute than its target ‘lxc_attach_main’: ‘noreturn’ [-Wmissi
ng-attributes]
  320 | int __attribute__((weak, alias("lxc_attach_main"))) main(int argc, char *argv[]);

This recommendation is really not very important, so let's not ask
the build to warn about it.

Signed-off-by: Serge Hallyn <serge@hallyn.com>

meson.build: add -ffat-lto-objects

Otherwise, if we generate a static library, lintian warns that
it has no code sections.  See

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977596

Signed-off-by: Serge Hallyn <serge@hallyn.com>

Merge pull request #4481 from yuncang123/main

fix possible clang compile error on AARCH

fix possible clang compile error in AARCH

Signed-off-by: yuncang123 <135211779+yuncang123@users.noreply.github.com>

Merge pull request #4475 from stgraber/main

README: Update security contact

README: Update security contact

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4472 from stgraber/main

doc: Fix definitions of get_config_path and set_config_path

doc: Fix definitions of get_config_path and set_config_path

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4462 from Jip-Hop/list-exit-code

Exit 0 when there's no error

Exit 0 when there's no error

Signed-off-by: Jip de Beer <2871973+Jip-Hop@users.noreply.github.com>

Merge pull request #4463 from stgraber/main

Reduce logging for newuidmap/newgidmap

idmap: Lower logging level of newXidmap tools to INFO

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Remove unused function

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4459 from mihalicyn/lxc_nixos_build_fix2

meson: fix build with -Dtools-multicall=true on NixOS

meson: fix build with -Dtools-multicall=true on NixOS

See also:
https://github.com/lxc/lxc/pull/4428

Fixes: #4427
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

Merge pull request #4453 from mihalicyn/update_githubci_ubuntu24

Update GitHub Actions to use Ubuntu 24.04

github: exclude clang & ubuntu-24.04 combination

Temporary workaround for:
https://bugs.launchpad.net/ubuntu/+source/llvm-toolchain-18/+bug/2064187

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

lxc/storage/zfs: ignore false-positive use-after-free warning

free(dataset) is perfecly valid after failed realloc(dataset, len) call.

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

github: properly check apparmor profile changes

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

github: start using ubuntu-24.04

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

Merge pull request #4456 from mihalicyn/apparmor_syntax_fix_fixup

AppArmor fixup

apparmor: regenerate rules

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

apparmor: use /{,**} instead of /**

It turned out, that old (and incorrect) rule:
mount options=(rw,make-slave) -> **,

is NOT equivalent to:
mount options=(rw,make-slave) -> /**,

Let's use:
mount options=(rw,make-slave) -> /{,**},

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

Merge pull request #4452 from mihalicyn/apparmor_prof_syntax_fix

Apparmor profiles syntax fixes

apparmor: regenerate rules

Follow the instruction from config/apparmor/README:

./lxc-generate-aa-rules.py container-rules.base > container-rules
cat abstractions/container-base.in container-rules > abstractions/container-base

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

apparmor: fix rule path pattern specification syntax

See also:
https://bugs.launchpad.net/lxc/+bug/2064144
https://github.com/lxc/incus/pull/889/commits/d2c13e3f6312f08750981a80a510530e881c4ec7

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

Merge pull request #4450 from jacobmcnamee/fix-local-template

lxc-local: fix broken templates processing

lxc-local: remove check for template existence before extraction

This check always fails because template files do not exist until the
rootfs is unpacked. File existence is already confirmed before replacing
variables

Signed-off-by: Jacob McNamee <jacob@jacobmcnamee.com>

lxc-local: fix incorrect path to `templates` file

Signed-off-by: Jacob McNamee <jacob@jacobmcnamee.com>

lxc-local: fix use of `LXC_PATH` before init

Signed-off-by: Jacob McNamee <jacob@jacobmcnamee.com>

Merge pull request #4446 from tenforward/japanese

Update lxc-{attach,execute}.sgml.in

Update lxc-execute.sgml.in

Update for a7aa297

Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Update lxc-{attach,execute}.sgml.in

Update for 52bf34d and a7aa297

Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Merge pull request #4441 from MMFuba/patch-2

Update lxc-execute.sgml.in

Merge pull request #4442 from MMFuba/patch-1

Update lxc-attach.sgml.in

Update lxc-execute.sgml.in

add hint to use numerical values for uid and gid

Signed-off-by: MMFuba <114305581+MMFuba@users.noreply.github.com>

Update lxc-attach.sgml.in

added hint to use numerical value for uid and gid

Signed-off-by: MMFuba <114305581+MMFuba@users.noreply.github.com>

Merge pull request #4432 from mihalicyn/ipv6_ebadf_fixup

Don't fail veth creation if ipv6 is disabled

network: netdev_configure_server_veth: reduce scope of disable_ipv6_fd/path vars

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

lxc/network: handle non-existing sysctl <ifname>/disable_ipv6

Skip writting to /proc/sys/net/ipv6/conf/<ifname>/disable_ipv6
if it does not exist.

Fixes: #4431
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

Merge pull request #4428 from mihalicyn/new_meson_build_fixup

meson: fix build on NixOS

github: test the lxc multicall binary builds too

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

meson: fix build on NixOS

Fixes: #4427
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

meson: Set DEVEL flag post release

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Release LXC 6.0.0

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4424 from stgraber/main

Cleanup MAINTAINERS, COPYING and sort out SPDX headers

lxc.spec: Align SPDX license id

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Makefile: Align SPDX license id

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

meson: Align SPDX license id

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

COPYING: Clarify licensing of files without SPDX

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

doc: Add SPDX headers and remove Author field

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

src/include: Add SPDX headers

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

src/tests: Add SPDX headers

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

hooks: Add SPDX headers

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

lxc.spec: Clear default changelog

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

lxc.spec: Use SPDX

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

template: Use SPDX

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

config/yum: Use SPDX header

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

COPYING: Remove whitespace

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

MAINTAINERS: Remove Dwight from the maintainer list

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>

Merge pull request #4377 from adamcstephens/install-options

build: add more options for customizing install

Merge pull request #4423 from stgraber/main

lxc-checkconfig improvements