]>
git.ipfire.org Git - thirdparty/suricata.git/log
Shivani Bhardwaj [Sat, 7 Mar 2020 08:23:36 +0000 (13:53 +0530)]
doc: Fix typo Generate -> Generator
Shivani Bhardwaj [Tue, 3 Mar 2020 06:10:08 +0000 (11:40 +0530)]
doc: Add chassis for dev docs
Closes redmine ticket 3344.
Philippe Antoine [Fri, 6 Mar 2020 09:45:23 +0000 (10:45 +0100)]
kerberos: fix against packet split in record size
Victor Julien [Sun, 8 Mar 2020 16:11:36 +0000 (17:11 +0100)]
krb5/tcp: remove notice logging on failed records
Philippe Antoine [Fri, 28 Feb 2020 11:03:16 +0000 (12:03 +0100)]
detect: adds icmpv6.hdr keyword
Philippe Antoine [Fri, 28 Feb 2020 11:04:00 +0000 (12:04 +0100)]
detect: fix typo for ipv6.hdr description
Philippe Antoine [Wed, 4 Mar 2020 15:43:51 +0000 (16:43 +0100)]
detect: use SC macros for IPV6 header
Philippe Antoine [Fri, 28 Feb 2020 12:37:20 +0000 (13:37 +0100)]
doc: add missing documentation for ipv6.hdr keyword
Philippe Antoine [Fri, 28 Feb 2020 13:18:32 +0000 (14:18 +0100)]
doc: fix typo in ByteExtractUint32 description
Jeff Lucovsky [Wed, 4 Mar 2020 14:37:04 +0000 (09:37 -0500)]
detect/threshold: Correct typos
Jeff Lucovsky [Wed, 4 Mar 2020 14:35:54 +0000 (09:35 -0500)]
detect/threshold: Don't allow duplicates
This commit detects duplicate threshold rule options. When duplicates
are found in a rule, an error message is displayed and the rule is
rejected.
Victor Julien [Thu, 5 Mar 2020 10:12:01 +0000 (11:12 +0100)]
pcap/file: minor code cleanups
Victor Julien [Thu, 5 Mar 2020 10:05:12 +0000 (11:05 +0100)]
threads/time: minor code cleanup
Sascha Steinbiss [Mon, 17 Feb 2020 16:29:59 +0000 (17:29 +0100)]
sip: address trailing space parsing
Jeff Lucovsky [Fri, 14 Feb 2020 13:38:53 +0000 (08:38 -0500)]
mime: Test cases for filename length limit
Jeff Lucovsky [Wed, 5 Feb 2020 14:21:05 +0000 (09:21 -0500)]
smtp/mime: Fix typos
Jeff Lucovsky [Wed, 5 Feb 2020 14:20:29 +0000 (09:20 -0500)]
smtp/mime: Set event when name exceeds limit
Jeff Lucovsky [Tue, 4 Feb 2020 15:13:49 +0000 (10:13 -0500)]
smtp/mime: Restrict file name lengths
This commit places restrictions on the length of the file name specified
in attachments (`name=` or `filename=`) to `NAME_MAX`. Names exceeding
these limits will be truncated and processing will continue with the
truncated name.
Victor Julien [Fri, 28 Feb 2020 12:17:03 +0000 (13:17 +0100)]
pcap/file: improve time handling
This patch addresses two problems.
First, various parts of the engine, but most notably the flow manager (FM),
use a minimum of the time notion of the packet threads. This did not
however, take into account the scenario where one or more of these
threads would be inactive for prolonged times. This could lead to the
time used by the FM could get stale.
This is addressed by keeping track of the last time the per thread packet
timestamp was updated, and only considering it for the 'minimum' when it
is reasonably current.
Second, there was a minor race condition at start up, where the FM would
already inspect the hash table(s) while the packet threads weren't active
yet. Since FM gets the time from the packet threads, it would use a bogus
time of 0.
This is addressed by adding a wait loop to the start of the FM that waits
for 'time' to get ready.
Victor Julien [Fri, 28 Feb 2020 12:06:09 +0000 (13:06 +0100)]
threads/time: rename ts to pktts to make purpose clear
Victor Julien [Thu, 27 Feb 2020 16:20:18 +0000 (17:20 +0100)]
pcap/file: fix race during pcap processing start
A race condition during the start of pcap file processing could cause
missed alerts and logged events. This race happens between the packet
threads and the flow manager. It was observed on slower hardware, but in
theory could happen on any machine. It required the 'autofp' runmode.
In commit
6f560144c1b9 ("time: improve offline time handling") the logic
was added to make the flow manager use a minimum of all the packet threads
perception of time.
The race condition was that the flow manager may become active _before_
all of the packet threads have started processing packets and thus setting
their timestamp. The threads that had not yet initialized their timestamp
would not be considered when calculating the minimum.
As a result of this, older packets timestamps would not yet be registered.
This would give the Flow Manager a timestamp too far in the future. While
the FM was running, the packet processing would start and a flow would
be created. This flow would then immediately be considered 'timed out' by
the FM, due to the timestamp too far in the future.
In the observed case, the thread processing packet 1 from the pcap had not
yet started processing while other threads had already started. The FM was
also already active. Due to the timestamps in the pcap this meant that the
time the FM used was about 500 seconds in the future compared to packet 1.
This patch fixes the issue by initializing all of the threads timestamps
with the timestamp value of the first packet. This way the minimum will
always consider this timestamp.
Victor Julien [Thu, 27 Feb 2020 19:27:20 +0000 (20:27 +0100)]
time: remove unused time structure
Victor Julien [Thu, 27 Feb 2020 19:20:33 +0000 (20:20 +0100)]
time: minor code cleanup
Victor Julien [Fri, 28 Feb 2020 09:22:23 +0000 (10:22 +0100)]
time: fix function name typo
Victor Julien [Fri, 28 Feb 2020 09:38:22 +0000 (10:38 +0100)]
pcap/file: fix function ptr naming
Victor Julien [Mon, 2 Mar 2020 16:18:50 +0000 (17:18 +0100)]
rust: bump minimum supported version to 1.34.2
Victor Julien [Fri, 7 Feb 2020 10:33:30 +0000 (11:33 +0100)]
rust/nfs: minor code cleanups
Victor Julien [Thu, 6 Feb 2020 10:43:17 +0000 (10:43 +0000)]
rust/rpc: add partial data tests
Pierre Chifflier [Thu, 6 Feb 2020 20:45:39 +0000 (21:45 +0100)]
rust: use the streaming version of combinators to fix incomplete reads
Pierre Chifflier [Mon, 4 Nov 2019 09:27:08 +0000 (10:27 +0100)]
rust/rdp: use the streaming version of combinators to fix incomplete reads
Pierre Chifflier [Mon, 4 Nov 2019 09:22:45 +0000 (10:22 +0100)]
rust/rdp: fix regression introduced during nom 5 upgrade
Pierre Chifflier [Thu, 31 Oct 2019 14:33:57 +0000 (15:33 +0100)]
rust: Add types annotation when required
Unfortunately, the transition to nom 5 (and functions instead of macros)
has side-effects, one of them being requiring lots of types annotations
when using a parsing, for ex in a match instruction.
Pierre Chifflier [Thu, 31 Oct 2019 09:49:20 +0000 (10:49 +0100)]
rust/ftp: upgrade to nom 5
CompleteByteSlice type has been removed, and replaced by combinators
under the nom::character::complete namespace.
Pierre Chifflier [Thu, 31 Oct 2019 08:25:58 +0000 (09:25 +0100)]
rust/rdp: add custom error handling
Pierre Chifflier [Thu, 31 Oct 2019 07:21:12 +0000 (08:21 +0100)]
rust/smb: add custom error handling
Pierre Chifflier [Wed, 30 Oct 2019 16:17:52 +0000 (17:17 +0100)]
rust: add SecBlobError custom error type for the Kerberos parser
Pierre Chifflier [Wed, 30 Oct 2019 16:17:32 +0000 (17:17 +0100)]
rust: add take_until_and_consume replacement function
Pierre Chifflier [Wed, 30 Oct 2019 12:22:22 +0000 (13:22 +0100)]
rust/dns: remove unneeded calls to closure!
Pierre Chifflier [Wed, 30 Oct 2019 12:14:07 +0000 (13:14 +0100)]
rust: upgrade all parsers to nom 5
Jason Ish [Mon, 24 Feb 2020 16:49:41 +0000 (10:49 -0600)]
log-pcap: fix log message: unified2 -> pcap
Likely a result of copy and pasted code.
Jason Ish [Fri, 8 Nov 2019 22:22:24 +0000 (16:22 -0600)]
unified2: not supported message if configured
Jason Ish [Wed, 6 Nov 2019 02:26:53 +0000 (20:26 -0600)]
unified2: remove deprecated output unified2
Ticket 2385:
https://redmine.openinfosecfoundation.org/issues/2385
Jason Ish [Wed, 6 Nov 2019 02:26:42 +0000 (20:26 -0600)]
wirefuzz: removed unified2 file removal
Jason Ish [Wed, 6 Nov 2019 02:26:27 +0000 (20:26 -0600)]
doc: removed unified2 output
Jeff Lucovsky [Wed, 19 Feb 2020 14:16:36 +0000 (09:16 -0500)]
pcre: Sticky buffer check
This commit adds logic checking if the sticky buffer in effect provides
the required content.
If the sticky buffer doesn't, the rule will not load and a diagnostic
message with follow-on steps is displayed.
Jeff Lucovsky [Wed, 19 Feb 2020 14:15:40 +0000 (09:15 -0500)]
general: Wordsmith "no rules loaded" message
William Stearns [Fri, 21 Feb 2020 16:44:08 +0000 (11:44 -0500)]
rules: fix files.rules typo
Sascha Steinbiss [Thu, 20 Feb 2020 09:47:32 +0000 (10:47 +0100)]
snmp-version: make comment more clear
Sascha Steinbiss [Thu, 20 Feb 2020 09:46:55 +0000 (10:46 +0100)]
snmp: do not set SIGMATCH_NOOPT
Jeff Lucovsky [Sat, 22 Feb 2020 18:24:45 +0000 (13:24 -0500)]
spelling: Fix spelling error
Jeff Lucovsky [Sat, 22 Feb 2020 18:24:13 +0000 (13:24 -0500)]
detect/ssl_state: Fix memory leaks from pcre_get_substring
This commit replaces usages of pcre_get_substring with
pcre_copy_substring to avoid leaking memory on error conditions.
Jeff Lucovsky [Sat, 22 Feb 2020 18:23:04 +0000 (13:23 -0500)]
detect/flowvar: Fix memory leaks from pcre_get_substring
This commit replaces usages of pcre_get_substring with
pcre_copy_substring to avoid leaking memory on error conditions.
Jeff Lucovsky [Sat, 22 Feb 2020 18:21:36 +0000 (13:21 -0500)]
detect/filestore: Fix memory leaks from pcre_get_substring
This commit replaces usages of pcre_get_substring with
pcre_copy_substring to avoid leaking memory on error conditions.
Jeff Lucovsky [Sat, 22 Feb 2020 18:19:28 +0000 (13:19 -0500)]
doc: Correct RST quote usage
Corrects misplaced backticks preventing proper formatting of `mpm-algo`
section.
Jeff Lucovsky [Sat, 22 Feb 2020 18:25:02 +0000 (13:25 -0500)]
util-error: define SC_ERR_PCRE_COPY_SUBSTRING
Jeff Lucovsky [Tue, 29 Oct 2019 10:24:53 +0000 (11:24 +0100)]
general: Convert _Bool to bool
This commit addresses task 3167 and changes usages of '_Bool` to `bool`.
The latter is included from `suricata-common.h`
Jeff Lucovsky [Sat, 21 Dec 2019 16:22:34 +0000 (11:22 -0500)]
doc/userguide: Update for dump-features
Jeff Lucovsky [Sat, 21 Dec 2019 16:16:31 +0000 (11:16 -0500)]
detect/feature: Support --dump-features
Jeff Lucovsky [Sat, 21 Dec 2019 16:15:42 +0000 (11:15 -0500)]
detect: update version comment
Jeff Lucovsky [Sat, 21 Dec 2019 16:12:30 +0000 (11:12 -0500)]
detect: Fix typos/spelling errors.
Jeff Lucovsky [Fri, 20 Dec 2019 00:51:59 +0000 (19:51 -0500)]
main: feature init and release
Jeff Lucovsky [Fri, 20 Dec 2019 00:51:08 +0000 (19:51 -0500)]
output/filestore: announce provided features
Jeff Lucovsky [Fri, 20 Dec 2019 00:50:30 +0000 (19:50 -0500)]
detect/filestore: Warn if req'd feature missing
Jeff Lucovsky [Fri, 20 Dec 2019 00:49:21 +0000 (19:49 -0500)]
detect/analysis: Warn if required feature missing
Jeff Lucovsky [Fri, 20 Dec 2019 00:48:25 +0000 (19:48 -0500)]
feature: feature tracking services
Philippe Antoine [Fri, 6 Dec 2019 07:58:56 +0000 (08:58 +0100)]
perf: optimizes alert fast log
In the case when we have multiple alerts for one packet
We suppose this happens more often than having decoder_event != 0
Phil Young [Mon, 6 Jan 2020 18:43:32 +0000 (13:43 -0500)]
napatech: add hardware based bypass support
Napatech hardware bypass support enables Suricata to utilize
capabilities of Napatech SmartNICs to selectively bypass flow-based
traffic.
Phil Young [Mon, 6 Jan 2020 18:42:05 +0000 (13:42 -0500)]
napatech: documentation hardware based bypass support
Napatech hardware bypass support enables Suricata to utilize
capabilities of Napatech SmartNICs to selectively bypass flow-based
traffic.
Andreas Herz [Fri, 31 Jan 2020 09:19:36 +0000 (10:19 +0100)]
doxygen: update config from 1.8.4 to 1.8.17
Philippe Antoine [Wed, 9 Oct 2019 14:59:13 +0000 (16:59 +0200)]
detect/parse: move spaces skip up the stack
Switch to isspace() as well.
Philippe Antoine [Tue, 18 Feb 2020 08:35:47 +0000 (09:35 +0100)]
parser: make rust probing parsers optional
Jeff Lucovsky [Sat, 28 Dec 2019 14:45:31 +0000 (09:45 -0500)]
decode: Fix typos/spelling
Jeff Lucovsky [Sat, 28 Dec 2019 14:44:56 +0000 (09:44 -0500)]
decode: Handle ERSPAN Type I
Victor Julien [Fri, 14 Feb 2020 10:07:45 +0000 (11:07 +0100)]
configure: update to match autoscan suggestions
Victor Julien [Fri, 14 Feb 2020 09:17:22 +0000 (10:17 +0100)]
configure: clean up func checks
Philippe Antoine [Wed, 22 Jan 2020 08:33:05 +0000 (09:33 +0100)]
init: move main to a separate file
so as to reuse code from suricata.c with fuzz targets
Philippe Antoine [Wed, 22 Jan 2020 08:30:51 +0000 (09:30 +0100)]
fuzz: disable signal handlers while fuzzing
Philippe Antoine [Wed, 22 Jan 2020 08:30:26 +0000 (09:30 +0100)]
init: make PostConfLoadedSetup global
to be used by fuzz targets
Philippe Antoine [Wed, 22 Jan 2020 08:28:36 +0000 (09:28 +0100)]
init: fix PostConfLoadedSetup to use local suri ptr
Philippe Antoine [Thu, 16 Jan 2020 07:49:19 +0000 (08:49 +0100)]
init: InitGlobal function
To be reused by fuzz targets
Philippe Antoine [Thu, 24 Oct 2019 12:41:21 +0000 (14:41 +0200)]
util: UTHmemsearch to use memmem if defined
Philippe Antoine [Fri, 12 Jul 2019 14:26:28 +0000 (16:26 +0200)]
check: Using const keyword for some arguments
For ConfigSetLogDirectory and PrintRawLineHexBuf
Philippe Antoine [Mon, 27 May 2019 15:00:05 +0000 (17:00 +0200)]
log: can use a file set from env variable
Enables the redirection of log to a file set by an environment
variable SC_LOG_FILE when SC_LOG_OP_IFACE=file
vanlink [Thu, 16 Jan 2020 08:27:57 +0000 (16:27 +0800)]
stream/reassembly: fix data overlap check
Fix function CheckOverlap bug.
Victor Julien [Wed, 29 Jan 2020 12:50:05 +0000 (13:50 +0100)]
tls: fix missing extern logic for cert_id tracking
Victor Julien [Wed, 29 Jan 2020 12:46:56 +0000 (13:46 +0100)]
stats: fix missing extern keyword
Victor Julien [Wed, 29 Jan 2020 12:43:49 +0000 (13:43 +0100)]
defrag: fix use of globals
Victor Julien [Wed, 29 Jan 2020 12:30:35 +0000 (13:30 +0100)]
threading: fix queue handlers globals use
Victor Julien [Wed, 29 Jan 2020 12:28:17 +0000 (13:28 +0100)]
htp: fix globals use for flags
Victor Julien [Wed, 29 Jan 2020 12:27:58 +0000 (13:27 +0100)]
proto: fix globals use
Victor Julien [Wed, 29 Jan 2020 12:23:36 +0000 (13:23 +0100)]
flow: fix global variable use
Victor Julien [Wed, 29 Jan 2020 10:55:27 +0000 (11:55 +0100)]
stream: fix global declaration of the config
Victor Julien [Wed, 29 Jan 2020 10:51:11 +0000 (11:51 +0100)]
threading/modules: fix global declarations
Victor Julien [Wed, 29 Jan 2020 09:56:54 +0000 (10:56 +0100)]
ippair: fix global declarations
Victor Julien [Wed, 29 Jan 2020 09:37:44 +0000 (10:37 +0100)]
host: fix global declarations
Victor Julien [Wed, 29 Jan 2020 09:28:16 +0000 (10:28 +0100)]
mpm: fix global declarations
Victor Julien [Wed, 29 Jan 2020 09:22:57 +0000 (10:22 +0100)]
detect: fix global declaration of sigmatch_table
Victor Julien [Wed, 29 Jan 2020 09:11:54 +0000 (10:11 +0100)]
spm: fix global declaration of spm_table
Victor Julien [Wed, 29 Jan 2020 07:33:18 +0000 (08:33 +0100)]
threading: fix global declaration of threading_set_cpu_affinity
Victor Julien [Wed, 29 Jan 2020 07:15:21 +0000 (08:15 +0100)]
unix-socket: avoid using global variable w/o extern