git.ipfire.org Git - thirdparty/zstd.git/log

preset behavior for gzip, gunzip and gzcat

when zstd is called through a link named gzip, gunzip or gzcat,
provides the same behavior as the related program.
gzip compresses using --format=gz
both gzip and gunzip enable --rm by default

commit | commitdiff | tree

Yann Collet [Tue, 14 Feb 2017 18:30:22 +0000 (10:30 -0800)]

Merge pull request #543 from inikep/gz_compress

Gz compress

commit | commitdiff | tree

Nick Terrell [Tue, 14 Feb 2017 18:08:14 +0000 (10:08 -0800)]

Don't run test-pool with QEMU

    > make test -n
    ...
    ./pool
    > make test -n QEMU_SYS=valgrind
    ...
    ./legacy
    # ./pool not run

commit | commitdiff | tree

Yann Collet [Tue, 14 Feb 2017 08:54:55 +0000 (00:54 -0800)]

Merge pull request #544 from ds77/avoid-empty

Portable way to avoid empty unit warning in threading.c

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:52:52 +0000 (09:52 +0100)]

fix LONG_SEEK

commit | commitdiff | tree

Yann Collet [Tue, 14 Feb 2017 08:49:06 +0000 (00:49 -0800)]

Merge pull request #546 from zefanxu/dev

fix memory leak

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:47:29 +0000 (09:47 +0100)]

fixed function name (2)

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:45:33 +0000 (09:45 +0100)]

Avoid fseek()'s 2GiB barrier with MacOS and *BSD

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:39:09 +0000 (09:39 +0100)]

Windows resources updated to v1.1.4

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:38:51 +0000 (09:38 +0100)]

removed UTIL_doesFileExists (replaced with UTIL_isRegFile)

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:26:03 +0000 (09:26 +0100)]

Merge remote-tracking branch 'refs/remotes/facebook/dev' into dev11

commit | commitdiff | tree

Przemyslaw Skibinski [Tue, 14 Feb 2017 08:23:32 +0000 (09:23 +0100)]

fixed function name

commit | commitdiff | tree

zefanxu2 [Tue, 14 Feb 2017 03:12:59 +0000 (21:12 -0600)]

fix memory leak

commit | commitdiff | tree

Nick Terrell [Tue, 14 Feb 2017 02:27:34 +0000 (18:27 -0800)]

[zstdmt] Fix MSAN failure with ZSTD_p_forceWindow

Reproduction steps:

```
make zstreamtest CC=clang CFLAGS="-O3 -g -fsanitize=memory -fsanitize-memory-track-origins"
./zstreamtest -vv -t4178 -i4178 -s4531
```

How to get to the error in gdb (may be a more efficient way):

* 2 breaks at zstd_compress.c:2418 -- in ZSTD_compressContinue_internal()
* 2 breaks at zstd_compress.c:2276 -- in ZSTD_compressBlock_internal()
* 1 break at zstd_compress.c:1547

Why the error occurred:

When `zc->forceWindow == 1`, after calling `ZSTD_loadDictionaryContent()` we
have `zc->loadedDictEnd == zc->nextToUpdate == 0`. But, we've really loaded up
to `iend` into the dictionary. Then in `ZSTD_compressBlock_internal()` we see
that `current > zc->nextToUpdate + 384`, so we load the last 192 bytes a second
time. In this case the bytes we are loading are a block of all 0s, starting in
the previous block. So when we are loading the last 192 bytes, we find a `match`
in the future, 183 bytes beyond `ip`. Since the block is all 0s, the match
extends to the end of the block. But in `ZSTD_count()` we only check that
`pIn < pInLoopLimit`, but since `pMatch > pIn`, `pMatch` eventually points past
the end of the buffer, causing the MSAN failure.

The fix:

The line changed sets sets `zc->nextToUpdate` to the end of the dictionary.
This is the behavior that existed before `ZSTD_p_forceWindow` was introduced.
This fixes the exposing test case. Since the code doesn't fail without
`zc->forceWindow`, it makes sense that this works. I've run the command
`./zstreamtest -T2mn` 64 times without failures. CI should also verify nothing
obvious broke.

commit | commitdiff | tree

Yann Collet [Tue, 14 Feb 2017 02:32:12 +0000 (18:32 -0800)]

push version and NEWS to v1.1.4

Mirror of https://github.com/facebook/zstd.git

RSS Atom