]> git.ipfire.org Git - thirdparty/suricata.git/log
thirdparty/suricata.git
11 years agosuricata: add -v[v] option to increase verbosity 576/head
Eric Leblond [Thu, 3 Oct 2013 12:55:35 +0000 (14:55 +0200)] 
suricata: add -v[v] option to increase verbosity

This patch adds a -v option to suricata. It increases the log level
defined in the YAML.

11 years agosuricata: info message after log init
Eric Leblond [Thu, 3 Oct 2013 11:50:09 +0000 (13:50 +0200)] 
suricata: info message after log init

This patch moves version display after log init so we can have an
homogeneous display.

11 years agosuricata: reorder start
Eric Leblond [Thu, 3 Oct 2013 11:43:58 +0000 (13:43 +0200)] 
suricata: reorder start

Initalizing output just after configuration file parsing allow to
log almost all messages accordingly to configuration.

11 years agolog: change default log level to notice
Eric Leblond [Thu, 3 Oct 2013 08:55:10 +0000 (10:55 +0200)] 
log: change default log level to notice

This patch updates the log level of meaningful start messages to
notice. It also sets the default log level to notice.

11 years agoRevert change in queue handler wait logic. Bug #988.
Victor Julien [Thu, 3 Oct 2013 08:33:56 +0000 (10:33 +0200)] 
Revert change in queue handler wait logic. Bug #988.

11 years agoImprove 'host-mode' info message
Victor Julien [Thu, 3 Oct 2013 07:58:06 +0000 (09:58 +0200)] 
Improve 'host-mode' info message

11 years agoCoverity 1100842: add missing return statement
Victor Julien [Thu, 3 Oct 2013 07:48:32 +0000 (09:48 +0200)] 
Coverity 1100842: add missing return statement

11 years agoCoverity 1100843: remove unnecessary check
Victor Julien [Thu, 3 Oct 2013 07:12:34 +0000 (09:12 +0200)] 
Coverity 1100843: remove unnecessary check

11 years agohttp: add new events for invalid host header and host part of uri
Victor Julien [Tue, 1 Oct 2013 12:08:36 +0000 (14:08 +0200)] 
http: add new events for invalid host header and host part of uri

11 years agohttp: fix some decoder events
Victor Julien [Tue, 1 Oct 2013 11:49:39 +0000 (13:49 +0200)] 
http: fix some decoder events

Some events we retrieved from error messages are flag now, so check
those. Not all can be converted though. These are no longer set:

HTTP_DECODER_EVENT_INVALID_TRANSFER_ENCODING_VALUE_IN_RESPONSE
HTTP_DECODER_EVENT_INVALID_AUTHORITY_PORT

Part of Bug #982.

11 years agohttp: update http rules
Victor Julien [Tue, 1 Oct 2013 10:20:07 +0000 (12:20 +0200)] 
http: update http rules

11 years agohttp: fix field too long events
Victor Julien [Tue, 1 Oct 2013 10:15:41 +0000 (12:15 +0200)] 
http: fix field too long events

11 years agohttp: don't call HTPHandleWarning before HTPHandleError as the latter handles warning...
Victor Julien [Tue, 1 Oct 2013 10:13:38 +0000 (12:13 +0200)] 
http: don't call HTPHandleWarning before HTPHandleError as the latter handles warnings and errors.

11 years agohttp: add test for HTTP_DECODER_EVENT_UNKNOWN_ERROR event as a result of a too long...
Victor Julien [Tue, 1 Oct 2013 09:59:42 +0000 (11:59 +0200)] 
http: add test for HTTP_DECODER_EVENT_UNKNOWN_ERROR event as a result of a too long request

11 years agoreject: try to fail more gracefully
Eric Leblond [Tue, 1 Oct 2013 14:23:47 +0000 (16:23 +0200)] 
reject: try to fail more gracefully

In the case of reject both, a failure in sending one way do not lead to
abort the reset procedure.

11 years agoreject: clean respond-reject code.
Eric Leblond [Tue, 1 Oct 2013 14:05:34 +0000 (16:05 +0200)] 
reject: clean respond-reject code.

11 years agoreject: delete debug line
Eric Leblond [Thu, 26 Sep 2013 17:57:19 +0000 (19:57 +0200)] 
reject: delete debug line

11 years agoAdd reject for IPv6
Eric Leblond [Wed, 18 Sep 2013 11:27:49 +0000 (13:27 +0200)] 
Add reject for IPv6

With this patch reject is now available in IPv6.

11 years agoconfigure: accept libnet 1.1 and 1.2.
Eric Leblond [Fri, 13 Sep 2013 11:46:19 +0000 (13:46 +0200)] 
configure: accept libnet 1.1 and 1.2.

11 years agoreject: update computation of seq and ack
Eric Leblond [Wed, 11 Sep 2013 15:52:09 +0000 (17:52 +0200)] 
reject: update computation of seq and ack

We have follow TCP RFC (http://tools.ietf.org/html/rfc793#section-3.4).
There is two cases depending on wether the original packet contains a
ACK.
If packet has no ACK, the RST seq number is 0 and the ACK is built the
standard way.
If packet has a ACK, the seq of the RST packet is equal to the ACK of
incoming packet and the ACK is build using packet sequence number and
size of the data.

Regarding standard Ack number, it is computed using seq number of captured
packet added to packet length. Finally 1 is added so we respect the
RFC:
    If the ACK control bit is set this field contains the value of the
    next sequence number the sender of the segment is expecting to
    receive.  Once a connection is established this is always sent.

With this patch we have some correct results. With the following rule:
    reject ssh any any -> 192.168.56.3 any (msg:"no SSH  way"; sid:3; rev:1;)
ssh connection to 192.168.56.3 is correctly resetted on client side.

But this is not perfect. If we have the following rule:
    reject tcp any any -> 192.168.56.3 22 (msg:"no way"; sid:2; rev:1;)
then the connection is not resetted on a standard ethernet network. But
if we introduce 20ms delay on packets, then it is correctly resetted.
This is explained when looking at the network trace. The reset is sent
as answer to the SYN packet and it is emitted after the SYN ACK from
server because the exchange is really fast. So this is discarded by the
client OS which has already seen a ACK for the same sequence number.

This should fix #895.

11 years agoreject: fix typo
Eric Leblond [Thu, 12 Sep 2013 13:17:38 +0000 (15:17 +0200)] 
reject: fix typo

11 years agoreject: use host-mode to set interface
Eric Leblond [Wed, 11 Sep 2013 15:58:28 +0000 (17:58 +0200)] 
reject: use host-mode to set interface

This patch update reject code to send the packet on the interface
it comes from when 'host-mode' is set to 'sniffer-only'. When
'host-mode' is set to 'router', the reject packet is sent via
the routing interface.

This should fix #957.

11 years agoreject: reindent and code cleaning
Eric Leblond [Wed, 11 Sep 2013 15:45:20 +0000 (17:45 +0200)] 
reject: reindent and code cleaning

Reindent file and use some switch instead of if else if.

11 years agoIntroduce host-mode.
Eric Leblond [Fri, 13 Sep 2013 10:21:04 +0000 (12:21 +0200)] 
Introduce host-mode.

This variable can be used to indicate to suricata that the host
running is running as a router or is in sniffing only mode.
This will used at least to determine which interfaces are used to
send reject message.

11 years agolocks: clean up locks declarations
Victor Julien [Wed, 2 Oct 2013 10:12:01 +0000 (12:12 +0200)] 
locks: clean up locks declarations

Split threads.h into several files, where each of these files defines
all lock types and macro's.

threads.h defines the normal case
threads-debug.h defines the debug variants
threads-profile.h defines the lock profiling variants

Finally, threads-arch-tile.h moves the Tilera specifics out

11 years agococcinelle: implement parallel check 574/head
Eric Leblond [Wed, 2 Oct 2013 10:12:29 +0000 (12:12 +0200)] 
coccinelle: implement parallel check

This patch is an implementation of parallel check of files. It uses
GNU parallel to run multiple spatch at once.
The concurrency level is set via the CONCURRENCY_LEVEL environment
variable.

11 years agoStateful detection inspection continuation API call should update per
Anoop Saldanha [Mon, 30 Sep 2013 16:22:07 +0000 (21:52 +0530)] 
Stateful detection inspection continuation API call should update per
signature's Sigmatch entry as well.

11 years agoThresholding: move parsing code into separate func
Victor Julien [Thu, 19 Sep 2013 14:41:06 +0000 (16:41 +0200)] 
Thresholding: move parsing code into separate func

11 years agoSplit Thresholds and Suppression
Victor Julien [Thu, 19 Sep 2013 14:16:50 +0000 (16:16 +0200)] 
Split Thresholds and Suppression

Thresholds and suppression can be handled independently. Suppression
only suppresses output, and is not related to Threshold state tracking.

This simplifies mixing suppression and thresholding rules.

Part of the Bug #425 effort.

11 years agoUse Spin locks on Tile
Ken Steele [Fri, 27 Sep 2013 20:27:13 +0000 (16:27 -0400)] 
Use Spin locks on Tile

On Tile, replace pthread_mutex_locks with queued spin locks (ticket
locks) for dataplane processing code. This is safe when running on
dataplane cores with one thread per core. The condition variables are
no-ops when the thread is spinning anyway.

For control plane threads, unix-manager, stats-logs, thread startup,
use pthread_mutex_locks. For these locks replaced SCMutex with SCCtrlMutex
and SCCond with SCCtrlCond.

11 years agoFix compiler warning
Victor Julien [Mon, 30 Sep 2013 15:46:32 +0000 (17:46 +0200)] 
Fix compiler warning

app-layer-parser.c: In function ‘AppLayerPPTestData’:
app-layer-parser.c:2525:9: error: variable ‘dir’ set but not used [-Werror=unused-but-set-variable]
     int dir = 0;
         ^

11 years agoImprove Signature sorting speed
Ken Steele [Sun, 29 Sep 2013 14:45:44 +0000 (10:45 -0400)] 
Improve Signature sorting speed

Changed the signature sorting code to use a a single merge sort instead
of the multiple pass sorting that was being used. This reduces startup
time on Tile by a factor of 3.

Also replace the user array of pointers to ints with a simpler array of
ints.

11 years agoDNS: copy only the length of the hardcoded string, not the length of the destination...
Victor Julien [Fri, 27 Sep 2013 15:49:56 +0000 (17:49 +0200)] 
DNS: copy only the length of the hardcoded string, not the length of the destination buffer.

11 years agoFix return value from DetectProtoParse() which is used by probing 568/head
Anoop Saldanha [Mon, 30 Sep 2013 14:51:15 +0000 (20:21 +0530)] 
Fix return value from DetectProtoParse() which is used by probing
parser.

11 years agoFix coverity scan defect #1099714.
Anoop Saldanha [Mon, 30 Sep 2013 14:17:10 +0000 (19:47 +0530)] 
Fix coverity scan defect #1099714.

Sending back uninitialized variable in DetectParseProto().

11 years agoFix a leak in probing parsers. We were freeing just the head of the list, 567/head
Anoop Saldanha [Sun, 29 Sep 2013 16:45:46 +0000 (22:15 +0530)] 
Fix a leak in probing parsers.  We were freeing just the head of the list,
instead of all the members.

11 years agoFix a leak in app layer parser proto code. Free the proto signatures
Anoop Saldanha [Sun, 29 Sep 2013 16:45:21 +0000 (22:15 +0530)] 
Fix a leak in app layer parser proto code.  Free the proto signatures
allocated internally for PM parser.

11 years agoFix mem leak in b2g.
Anoop Saldanha [Sun, 29 Sep 2013 16:41:34 +0000 (22:11 +0530)] 
Fix mem leak in b2g.

11 years agoRemove unused vars alp_content_module_handle and proto_map from
Anoop Saldanha [Sat, 28 Sep 2013 07:38:13 +0000 (13:08 +0530)] 
Remove unused vars alp_content_module_handle and proto_map from
struct AlpProtoDetectCtx.

11 years agoRemove the unused flow flags - FLOW_TS_PM_PP_ALPROTO_DETECT_DONE and
Anoop Saldanha [Sat, 28 Sep 2013 06:50:59 +0000 (12:20 +0530)] 
Remove the unused flow flags - FLOW_TS_PM_PP_ALPROTO_DETECT_DONE and
FLOW_TC_PM_PP_ALPROTO_DETECT_DONE.

11 years agoReset some flow flags when port numbers are re-used and we re-use the
Anoop Saldanha [Sat, 28 Sep 2013 03:18:47 +0000 (08:48 +0530)] 
Reset some flow flags when port numbers are re-used and we re-use the
flow as a part of a new session.

11 years agoRemove the smtp parser restriction that it accepts data only in to client
Anoop Saldanha [Thu, 12 Sep 2013 14:52:52 +0000 (20:22 +0530)] 
Remove the smtp parser restriction that it accepts data only in to client
direction first.

11 years agoFix compilation failure when we don't enable unittests. Got to #ifdef
Anoop Saldanha [Wed, 11 Sep 2013 10:00:26 +0000 (15:30 +0530)] 
Fix compilation failure when we don't enable unittests.  Got to #ifdef
ALPROTO_TEST.

11 years agoUpdate stream inline to use the improved app proto detection.
Anoop Saldanha [Wed, 11 Sep 2013 07:22:47 +0000 (12:52 +0530)] 
Update stream inline to use the improved app proto detection.

11 years agoCosmetic changes to app parser struct.
Anoop Saldanha [Mon, 9 Sep 2013 12:59:58 +0000 (18:29 +0530)] 
Cosmetic changes to app parser struct.

Removed a flag parameter introuced earlier to indicate the data
that is first acceptable by the parser.  We now use a differently
named parameter to carry out the same activity.

11 years agoCosmetic changes to code. Introduce human readabel flag values for some constants...
Anoop Saldanha [Mon, 9 Sep 2013 12:40:33 +0000 (18:10 +0530)] 
Cosmetic changes to code. Introduce human readabel flag values for some constants. Here the parameter in question is "data_first_seen_dir" for session context.

11 years agoindentation fix.
Anoop Saldanha [Mon, 9 Sep 2013 11:49:32 +0000 (17:19 +0530)] 
indentation fix.

11 years agoIf we have proto mismatch from 2 directions, use one of the protos, instead of errori...
Anoop Saldanha [Mon, 9 Sep 2013 11:25:13 +0000 (16:55 +0530)] 
If we have proto mismatch from 2 directions, use one of the protos, instead of erroring out and not sending the data further to the parser.

The logic we use currently is if we have already sent some data to
a parser before we figure out we have a proto mismatch, we use the
proto from the first direction from which we have already sent the
data to the parser, else we stick to the the to client direction.

11 years agoIntroduce convenience macro to set Stream app proto completion flag.
Anoop Saldanha [Mon, 9 Sep 2013 06:34:20 +0000 (12:04 +0530)] 
Introduce convenience macro to set Stream app proto completion flag.

11 years agoRename function pointer var to use the FuncPtr typing convention. Resupply "dns"...
Anoop Saldanha [Sat, 31 Aug 2013 02:36:26 +0000 (08:06 +0530)] 
Rename function pointer var to use the FuncPtr typing convention. Resupply "dns" as the alproto name for ALPROTO_DNS.

11 years agoAdd unittest to test for http ambiguous host header.
Anoop Saldanha [Fri, 30 Aug 2013 10:31:33 +0000 (16:01 +0530)] 
Add unittest to test for http ambiguous host header.

Previously we would not check the port part of the host from the uri
hostname, while we did use the port part from the host header, leading
to FPs.

11 years agoUpdate rule engine relationship with regard to setting ip protocol between specifying...
Anoop Saldanha [Mon, 19 Aug 2013 15:22:17 +0000 (20:52 +0530)] 
Update rule engine relationship with regard to setting ip protocol between specifying protocol after action, ip_proto and app-layer-protocol.

Now we can specify alproto, ip_proto combinations this way

alert dns (ip_proto:[tcp/udp];)
alert ip (app-layer-protocol:dns;)
alert ip (app-layer-protocol:dns; ip_proto:tcp;)
alert tcp (app-layer-protocol:dns:)

so on.  Neater than using dnstcp/dnsudp.

This is related to feature #424.

11 years agoalert ipv4 and alert ipv6 specified proto rules should be treated and PROTO_ANY just...
Anoop Saldanha [Mon, 19 Aug 2013 05:36:30 +0000 (11:06 +0530)] 
alert ipv4 and alert ipv6 specified proto rules should be treated and PROTO_ANY just like how we treat alert ip rules.

11 years agoIntroduce a separate inspection engine for app events.
Anoop Saldanha [Sun, 18 Aug 2013 14:06:55 +0000 (19:36 +0530)] 
Introduce a separate inspection engine for app events.

11 years agoUpdate htp event handler to both warning and error events regardless of any conditions.
Anoop Saldanha [Sat, 17 Aug 2013 12:19:47 +0000 (17:49 +0530)] 
Update htp event handler to both warning and error events regardless of any conditions.

11 years agoAdd app layer protocol packet event detection support.
Anoop Saldanha [Fri, 16 Aug 2013 14:38:53 +0000 (20:08 +0530)] 
Add app layer protocol packet event detection support.

11 years agoAdd and use EventGetInfo for getting info on an event.
Anoop Saldanha [Sun, 11 Aug 2013 12:46:53 +0000 (18:16 +0530)] 
Add and use EventGetInfo for getting info on an event.

Also update existing parsers and app-layer-event Setup to use this.

11 years agoFix duplicate packet decoder events. Add event entries that were missing as well.
Anoop Saldanha [Mon, 5 Aug 2013 14:37:28 +0000 (20:07 +0530)] 
Fix duplicate packet decoder events. Add event entries that were missing as well.

11 years agovalidate dns sigs that are reported as plain dns and not dnsudp or dnstcp.
Anoop Saldanha [Mon, 5 Aug 2013 13:27:44 +0000 (18:57 +0530)] 
validate dns sigs that are reported as plain dns and not dnsudp or dnstcp.

11 years agoMove app event module registration as a part of app layer proto table.
Anoop Saldanha [Mon, 5 Aug 2013 05:46:05 +0000 (11:16 +0530)] 
Move app event module registration as a part of app layer proto table.

11 years agocode cleanup.
Anoop Saldanha [Sun, 4 Aug 2013 12:08:54 +0000 (17:38 +0530)] 
code cleanup.

11 years agoApp layer protocol detection updated and improved. We now use
Anoop Saldanha [Sun, 4 Aug 2013 06:38:59 +0000 (12:08 +0530)] 
App layer protocol detection updated and improved.  We now use
confirmation from both directions and set events if there's a mismatch
between the 2 directions.

FPs from corrupt flows have disappeared with this.

11 years agoReplace ssn appproto_detection_completed flag with individual stream ones.
Anoop Saldanha [Sat, 3 Aug 2013 20:01:32 +0000 (01:31 +0530)] 
Replace ssn appproto_detection_completed flag with individual stream ones.

11 years agoProvide convenience macros for setting flow flags on protocol matching by
Anoop Saldanha [Sat, 3 Aug 2013 19:40:10 +0000 (01:10 +0530)] 
Provide convenience macros for setting flow flags on protocol matching by
PM and PP phase.

Replace the areas of the code that would otherwise rely on setting/reading
these flags with these macros.

Other minor tweaks to some api calls.

11 years agoupdate pmp to return whole set of matches, rather than a single match.
Anoop Saldanha [Sat, 3 Aug 2013 19:22:45 +0000 (00:52 +0530)] 
update pmp to return whole set of matches, rather than a single match.

11 years agocode cleanup.
Anoop Saldanha [Sat, 3 Aug 2013 18:33:46 +0000 (00:03 +0530)] 
code cleanup.

11 years agoIntroduce detection parser function pointer.
Anoop Saldanha [Sat, 3 Aug 2013 18:33:23 +0000 (00:03 +0530)] 
Introduce detection parser function pointer.

11 years agofeature #727 - Add support for app-layer-protocol:<protocol> keyword
Anoop Saldanha [Sat, 3 Aug 2013 14:16:46 +0000 (19:46 +0530)] 
feature #727 - Add support for app-layer-protocol:<protocol> keyword

11 years agoAllow detection ports for alproto to be specified via the conf file.
Anoop Saldanha [Sat, 3 Aug 2013 09:23:13 +0000 (14:53 +0530)] 
Allow detection ports for alproto to be specified via the conf file.

To understand the option have a look at the option

app-layer.protocols.tls.detection-ports

11 years agoIntroduce new options into the conf file to enable/disable -
Anoop Saldanha [Fri, 2 Aug 2013 16:12:58 +0000 (21:42 +0530)] 
Introduce new options into the conf file to enable/disable -

1. Proto detection
2. Parsers

For app layer protocols.

libhtp has now been moved to the section under app-layer.protocols.http,
but we still provide backward compatibility with older conf files.

11 years agoNow supports accepting port addresses as strings, like the ones accepted in our rules...
Anoop Saldanha [Fri, 2 Aug 2013 09:53:35 +0000 (15:23 +0530)] 
Now supports accepting port addresses as strings, like the ones accepted in our rules. As a consequence we now accept port range, and other such combination. Support PP for ports based on ipproto as well.

11 years agoProperly clean up decoder event rules
Victor Julien [Fri, 27 Sep 2013 12:59:19 +0000 (14:59 +0200)] 
Properly clean up decoder event rules

Addresses:
~~Dr.M~~ Error #3: LEAK 120 direct bytes 0x08a26ac8-0x08a26b40 + 1871 indirect bytes
~~Dr.M~~ # 0 replace_malloc                               [/work/drmemory_package/common/alloc_replace.c:2292]
~~Dr.M~~ # 1 SigGroupHeadAlloc                            [/home/victor/dev/oisf/src/detect-engine-siggroup.c:144]
~~Dr.M~~ # 2 SigGroupHeadAppendSig                        [/home/victor/dev/oisf/src/detect-engine-siggroup.c:1014]
~~Dr.M~~ # 3 DetectEngineAddDecoderEventSig               [/home/victor/dev/oisf/src/detect.c:3026]
~~Dr.M~~ # 4 SigAddressPrepareStage2                      [/home/victor/dev/oisf/src/detect.c:3075]
~~Dr.M~~ # 5 SigGroupBuild                                [/home/victor/dev/oisf/src/detect.c:4311]
~~Dr.M~~ # 6 SigLoadSignatures                            [/home/victor/dev/oisf/src/detect.c:464]
~~Dr.M~~ # 7 LoadSignatures                               [/home/victor/dev/oisf/src/suricata.c:1706]
~~Dr.M~~ # 8 main                                         [/home/victor/dev/oisf/src/suricata.c:1994]

11 years agoipproto: improve cleanup
Victor Julien [Fri, 27 Sep 2013 12:46:30 +0000 (14:46 +0200)] 
ipproto: improve cleanup

To address:
~~Dr.M~~ Error #2: LEAK 16 direct bytes 0x08399688-0x08399698 + 2 indirect bytes
~~Dr.M~~ # 0 replace_malloc                      [/work/drmemory_package/common/alloc_replace.c:2292]
~~Dr.M~~ # 1 SigMatchAlloc                       [/home/victor/dev/oisf/src/detect-parse.c:201]
~~Dr.M~~ # 2 DetectIPProtoSetup                  [/home/victor/dev/oisf/src/detect-ipproto.c:523]
~~Dr.M~~ # 3 SigParseOptions                     [/home/victor/dev/oisf/src/detect-parse.c:510]
~~Dr.M~~ # 4 SigParseOptions                     [/home/victor/dev/oisf/src/detect-parse.c:523]
~~Dr.M~~ # 5 SigParse                            [/home/victor/dev/oisf/src/detect-parse.c:881]
~~Dr.M~~ # 6 SigInitHelper                       [/home/victor/dev/oisf/src/detect-parse.c:1309]
~~Dr.M~~ # 7 SigInit                             [/home/victor/dev/oisf/src/detect-parse.c:1456]
~~Dr.M~~ # 8 DetectEngineAppendSig               [/home/victor/dev/oisf/src/detect-parse.c:1728]
~~Dr.M~~ # 9 DetectLoadSigFile                   [/home/victor/dev/oisf/src/detect.c:334]
~~Dr.M~~ #10 SigLoadSignatures                   [/home/victor/dev/oisf/src/detect.c:422]
~~Dr.M~~ #11 LoadSignatures                      [/home/victor/dev/oisf/src/suricata.c:1706]

11 years agoImprove memory cleanup for decoder-events
Victor Julien [Fri, 27 Sep 2013 12:45:37 +0000 (14:45 +0200)] 
Improve memory cleanup for decoder-events

To address:

~~Dr.M~~ Error #1: LEAK 1 direct bytes 0x0892c108-0x0892c109 + 0 indirect bytes
~~Dr.M~~ # 0 replace_malloc                        [/work/drmemory_package/common/alloc_replace.c:2292]
~~Dr.M~~ # 1 DetectEngineEventParse                [/home/victor/dev/oisf/src/detect-engine-event.c:173]
~~Dr.M~~ # 2 _DetectEngineEventSetup               [/home/victor/dev/oisf/src/detect-engine-event.c:204]
~~Dr.M~~ # 3 DetectDecodeEventSetup                [/home/victor/dev/oisf/src/detect-engine-event.c:248]
~~Dr.M~~ # 4 SigParseOptions                       [/home/victor/dev/oisf/src/detect-parse.c:510]
~~Dr.M~~ # 5 SigParseOptions                       [/home/victor/dev/oisf/src/detect-parse.c:523]
~~Dr.M~~ # 6 SigParse                              [/home/victor/dev/oisf/src/detect-parse.c:881]
~~Dr.M~~ # 7 SigInitHelper                         [/home/victor/dev/oisf/src/detect-parse.c:1309]
~~Dr.M~~ # 8 SigInit                               [/home/victor/dev/oisf/src/detect-parse.c:1456]
~~Dr.M~~ # 9 DetectEngineAppendSig                 [/home/victor/dev/oisf/src/detect-parse.c:1728]
~~Dr.M~~ #10 DetectLoadSigFile                     [/home/victor/dev/oisf/src/detect.c:334]
~~Dr.M~~ #11 SigLoadSignatures                     [/home/victor/dev/oisf/src/detect.c:422]

11 years agoAdd DrMemory suppress file
Victor Julien [Fri, 27 Sep 2013 10:13:21 +0000 (12:13 +0200)] 
Add DrMemory suppress file

The suppress file currently suppresses:
- bug #978
- bug #979

Plus a seemingly harmeless warning that happens during libmagic init.

DrMemory is a valgrind like memory checker: http://www.drmemory.org/

11 years agoFix small leak in ports validation at startup
Victor Julien [Fri, 27 Sep 2013 09:42:42 +0000 (11:42 +0200)] 
Fix small leak in ports validation at startup

11 years agoflowint: further setup fixes and cleanups
Victor Julien [Fri, 27 Sep 2013 08:19:16 +0000 (10:19 +0200)] 
flowint: further setup fixes and cleanups

11 years agocounters: consolidate counters after all ThreadInit functions of a thread have run...
Victor Julien [Thu, 26 Sep 2013 16:34:36 +0000 (18:34 +0200)] 
counters: consolidate counters after all ThreadInit functions of a thread have run. This prevents duplicate and overwriting memory allocations.

11 years agoFix tests that didn't expect radix to be freed
Victor Julien [Thu, 26 Sep 2013 16:33:33 +0000 (18:33 +0200)] 
Fix tests that didn't expect radix to be freed

11 years agoradix: actually free a tree in SCRadixReleaseRadixTree
Victor Julien [Thu, 26 Sep 2013 13:35:46 +0000 (15:35 +0200)] 
radix: actually free a tree in SCRadixReleaseRadixTree

11 years agoflowint: fix compile warning
Victor Julien [Thu, 26 Sep 2013 13:28:56 +0000 (15:28 +0200)] 
flowint: fix compile warning

11 years agoflowint: fix setup memory leaks
Victor Julien [Thu, 26 Sep 2013 13:23:48 +0000 (15:23 +0200)] 
flowint: fix setup memory leaks

11 years agossh: fix memleaks during ssh.softwareversion init and cleanup
Victor Julien [Thu, 26 Sep 2013 13:06:57 +0000 (15:06 +0200)] 
ssh: fix memleaks during ssh.softwareversion init and cleanup

11 years agourilen: fix memory leak when freeing the rule
Victor Julien [Thu, 26 Sep 2013 12:58:41 +0000 (14:58 +0200)] 
urilen: fix memory leak when freeing the rule

11 years agofix for bug #973. 561/head
Anoop Saldanha [Wed, 25 Sep 2013 17:07:57 +0000 (22:37 +0530)] 
fix for bug #973.

An alternative solution for bug #970.

For chopped patterns, which in it's whole is a duplicate of another
pattern we assign an unique content id.

11 years agoUnittest for bug #973.
Anoop Saldanha [Wed, 25 Sep 2013 17:03:57 +0000 (22:33 +0530)] 
Unittest for bug #973.

11 years agoprscript: update code following buildbot upgrade 560/head
Eric Leblond [Wed, 25 Sep 2013 19:22:11 +0000 (21:22 +0200)] 
prscript: update code following buildbot upgrade

The authentication scheme did change on the buildbot due to a
software upgrade. This patch update prscript.py to fix the build
submission.

11 years agoprscript: support bigger PR
Eric Leblond [Wed, 11 Sep 2013 10:08:52 +0000 (12:08 +0200)] 
prscript: support bigger PR

The script now looks for originan HEAD in 100 commits instead of 30.
It should be enough becasue a sane PR should not have 100 commits.

11 years agoprscript: display url where user can watch build
Eric Leblond [Wed, 11 Sep 2013 08:35:52 +0000 (10:35 +0200)] 
prscript: display url where user can watch build

11 years agopcre: check for pcre_free_study, fall back to pcre_free if it unavailable
Victor Julien [Wed, 25 Sep 2013 18:06:53 +0000 (20:06 +0200)] 
pcre: check for pcre_free_study, fall back to pcre_free if it unavailable

11 years agompm: clean up stream thread ctx
Victor Julien [Wed, 25 Sep 2013 08:49:45 +0000 (10:49 +0200)] 
mpm: clean up stream thread ctx

11 years agoprofiling: properly clean up thread local memory.
Victor Julien [Wed, 25 Sep 2013 08:26:01 +0000 (10:26 +0200)] 
profiling: properly clean up thread local memory.

11 years agoprofiling: don't alloc 0 bytes block if no rules are used
Victor Julien [Wed, 25 Sep 2013 08:21:17 +0000 (10:21 +0200)] 
profiling: don't alloc 0 bytes block if no rules are used

11 years agoProperly cleanup NSS ctx
Victor Julien [Wed, 25 Sep 2013 08:19:09 +0000 (10:19 +0200)] 
Properly cleanup NSS ctx

11 years agoChange ParseSize api to not leak memory and only setup pcre once.
Victor Julien [Wed, 25 Sep 2013 08:15:30 +0000 (10:15 +0200)] 
Change ParseSize api to not leak memory and only setup pcre once.

11 years agoDNS: free TX events using proper function
Victor Julien [Wed, 25 Sep 2013 08:14:46 +0000 (10:14 +0200)] 
DNS: free TX events using proper function

11 years agoHttp: improve tx data cleanup
Victor Julien [Tue, 24 Sep 2013 18:17:36 +0000 (20:17 +0200)] 
Http: improve tx data cleanup

11 years agostream: clean up queue list in all cases
Victor Julien [Tue, 24 Sep 2013 18:00:21 +0000 (20:00 +0200)] 
stream: clean up queue list in all cases

11 years agoHttp: fix memory leaks when cleaning up our per-tx storage
Victor Julien [Tue, 24 Sep 2013 17:59:54 +0000 (19:59 +0200)] 
Http: fix memory leaks when cleaning up our per-tx storage

11 years agoDns: fix memory leak when events are set
Victor Julien [Tue, 24 Sep 2013 17:59:07 +0000 (19:59 +0200)] 
Dns: fix memory leak when events are set