]> git.ipfire.org Git - thirdparty/suricata.git/log
thirdparty/suricata.git
3 years agogithub-ci: pin macos build to 10.15 6445/head
Jason Ish [Tue, 5 Oct 2021 16:44:03 +0000 (10:44 -0600)] 
github-ci: pin macos build to 10.15

There is currently a build failure with macos-latest (recently updated)
to 11 in the libhtp test suite code. Not sure if there are other
build issues in libhtp or Suricata at this time.

3 years agogithub-ci: use sccache for gcc in commits workflow 6444/head
Jason Ish [Tue, 5 Oct 2021 15:47:11 +0000 (09:47 -0600)] 
github-ci: use sccache for gcc in commits workflow

Previously was only used for Rust.

3 years agoflow: free spare pool more aggressively 6438/head
Victor Julien [Mon, 4 Oct 2021 14:01:47 +0000 (16:01 +0200)] 
flow: free spare pool more aggressively

The flows exceeding the spare pools config setting would be freed
per at max 100 flows a second. After a high speed test this would
lead to excessive memory use for a long time.

This patch updates the logic to free 10% of the excess flows per
run, freeing multiple blocks of flows as needed.

Bug: #4731.

3 years agothreading: force break loop on flow inject
Victor Julien [Mon, 4 Oct 2021 07:24:51 +0000 (09:24 +0200)] 
threading: force break loop on flow inject

Track availability of break loop callback to avoid overhead.

3 years agoflow: process evicted flows on low/no traffic
Victor Julien [Fri, 1 Oct 2021 11:20:02 +0000 (13:20 +0200)] 
flow: process evicted flows on low/no traffic

In a scenario where there was suddenly no more traffic flowing, flows
in a threads `flow_queue` would not be processed. The easiest way to
see this would be in a traffic replay scenario. After the replay is done
no more packets come in and these evicted flows got stuck.

In workers mode, the capture part handles timeout this was updated to
take the `ThreadVars::flow_queue` into account.

The autofp mode the logic that puts a flow into a threads `flow_queue`
would already wake a thread up, but the `flow_queue` was then ignored.
This has been updated to take the `flow_queue` into account.

In both cases a "capture timeout" packet is pushed through the pipeline
to "flush" the queues.

Bug: #4722.

3 years agothreading: minor cleanups
Victor Julien [Sun, 3 Oct 2021 12:54:17 +0000 (14:54 +0200)] 
threading: minor cleanups

3 years agounittests/template: Register template unittests 6436/head
Jeff Lucovsky [Thu, 29 Apr 2021 12:55:45 +0000 (08:55 -0400)] 
unittests/template: Register template unittests

3 years agounittests/enip: Register ENIP unittests
Jeff Lucovsky [Thu, 29 Apr 2021 12:49:50 +0000 (08:49 -0400)] 
unittests/enip: Register ENIP unittests

3 years agopcre: fixes a memory leak on alloc error 6434/head
Philippe Antoine [Fri, 1 Oct 2021 13:55:19 +0000 (15:55 +0200)] 
pcre: fixes a memory leak on alloc error

3 years agohttp2: do not try to upgrade if http2 is disabled in config 6433/head
Philippe Antoine [Wed, 15 Sep 2021 14:22:00 +0000 (16:22 +0200)] 
http2: do not try to upgrade if http2 is disabled in config

3 years agohttp2: flatten code style
Philippe Antoine [Wed, 15 Sep 2021 14:20:56 +0000 (16:20 +0200)] 
http2: flatten code style

3 years agoprotodetect: handle all gaps, even when depth is reached
Philippe Antoine [Mon, 23 Aug 2021 14:31:42 +0000 (16:31 +0200)] 
protodetect: handle all gaps, even when depth is reached

3 years agoreadthedocs: add configuration file
Jason Ish [Thu, 30 Sep 2021 14:02:03 +0000 (08:02 -0600)] 
readthedocs: add configuration file

3 years agopcre: local match data for pcrexform
Philippe Antoine [Thu, 30 Sep 2021 13:23:15 +0000 (15:23 +0200)] 
pcre: local match data for pcrexform

3 years agopcre: use thread-storage for matches
Philippe Antoine [Thu, 30 Sep 2021 13:13:13 +0000 (15:13 +0200)] 
pcre: use thread-storage for matches

3 years agopcre: using de_ctx in unit tests for free function
Philippe Antoine [Thu, 30 Sep 2021 14:25:45 +0000 (16:25 +0200)] 
pcre: using de_ctx in unit tests for free function

3 years agopcre: creates a match structure per match run
Philippe Antoine [Thu, 30 Sep 2021 07:23:46 +0000 (09:23 +0200)] 
pcre: creates a match structure per match run

So that DetectPcrePayloadMatch is thread safe
and does not rewrite a shared parse_regex.match structure

3 years agohttp: range: remove assert that can happen
Philippe Antoine [Wed, 29 Sep 2021 15:22:57 +0000 (17:22 +0200)] 
http: range: remove assert that can happen

3 years agohttp2: range: check return value when opening
Philippe Antoine [Wed, 29 Sep 2021 15:06:55 +0000 (17:06 +0200)] 
http2: range: check return value when opening

HttpRangeContainerOpenFile can return NULL
so, http2_range_open can set file_range to NULL
And we should check this before calling http2_range_close

3 years agohttp: delete obsolete range log
Philippe Antoine [Wed, 29 Sep 2021 14:33:32 +0000 (16:33 +0200)] 
http: delete obsolete range log

Commit d776d72711800168cda5d62a7cc4669abda379be
has been transfering ownership of file container

So, we cannot log it

3 years agofuzz: adds one target with predefined rules 6424/head
Philippe Antoine [Wed, 29 Sep 2021 13:44:52 +0000 (15:44 +0200)] 
fuzz: adds one target with predefined rules

3 years agolgtm: adds build instructions to get lgtm to work
Philippe Antoine [Fri, 4 Jun 2021 08:21:40 +0000 (10:21 +0200)] 
lgtm: adds build instructions to get lgtm to work

LGTM is a statis analysis tool

3 years agoaf-packet: use configured cluster-id when checking for fanout
Jason Ish [Fri, 16 Oct 2020 15:43:29 +0000 (09:43 -0600)] 
af-packet: use configured cluster-id when checking for fanout

When testing for fanout support a cluster-id of 1 was always being
used instead of the configured cluster-id. This limited fanout
support to only one Suricata instance.

Instead of hardcoding an ID of 1, use the configured cluster-id.

Also make cluster_id a uint16_t instead of an int in AFPThreadVars.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/3419

3 years agoipv6: simpler generic overlap condition
Philippe Antoine [Fri, 10 Sep 2021 12:16:57 +0000 (14:16 +0200)] 
ipv6: simpler generic overlap condition

This also changes the behavior, as the condition is checked in
every case cf ipv6-malformed-fragments-8

3 years agouserguide: update wiresharkwiki in public datasets
Juliana Fajardini [Thu, 23 Sep 2021 14:33:36 +0000 (15:33 +0100)] 
userguide: update wiresharkwiki in public datasets

3 years agodoc/devguide: add few more explanations & details
Juliana Fajardini [Thu, 23 Sep 2021 11:55:48 +0000 (12:55 +0100)] 
doc/devguide: add few more explanations & details

3 years agodevguide/app-layer: rename /img dir to /diagrams
Juliana Fajardini [Tue, 31 Aug 2021 14:37:09 +0000 (15:37 +0100)] 
devguide/app-layer: rename /img dir to /diagrams

Semantically speaking it makes more sense, because it stores `msc`
files for dynamic image generation.
Updated files that refered to `img` accordingly, too.

3 years agodevguide/transactions: add TSL_STATE enum snippet
Juliana Fajardini [Tue, 31 Aug 2021 14:22:22 +0000 (15:22 +0100)] 
devguide/transactions: add TSL_STATE enum snippet

3 years agodevguide/transactions: update & refine diagrams
Juliana Fajardini [Tue, 31 Aug 2021 10:04:53 +0000 (11:04 +0100)] 
devguide/transactions: update & refine diagrams

- DNS sequence diagram was incorrect (transactions should be
unidirectional). After changing it, it made sense to rename the file.
Adjusted spacing, too. Updated transactions.rst accordingly.
- TLS sequence diagram was refined to illustrate how Suricata actually
implements the protocol.

3 years agodevguide/transactions: fix wordings
Juliana Fajardini [Thu, 26 Aug 2021 12:30:18 +0000 (13:30 +0100)] 
devguide/transactions: fix wordings

3 years agodevguide/code-style: fix typo in banned functions
Juliana Fajardini [Thu, 26 Aug 2021 11:37:33 +0000 (12:37 +0100)] 
devguide/code-style: fix typo in banned functions

3 years agoworkflows: add mscgen to Ubuntu 18.04 Cocci builds
Juliana Fajardini [Fri, 25 Jun 2021 14:09:09 +0000 (15:09 +0100)] 
workflows: add mscgen to Ubuntu 18.04 Cocci builds

3 years agodoc/devguide: add Transactions documentation page
Juliana Fajardini [Wed, 10 Mar 2021 11:14:32 +0000 (11:14 +0000)] 
doc/devguide: add Transactions documentation page

A guide on what is a transaction for Suricata engine, focusing on
developers.
- What's the purpose of a transaction;
- transaction states and API callbacks;
- Examples and sequence diagrams.
- doc/devguide: add transactions.rst
- doc/devguide/extending/app-layer/index.rst: add transactions.rst

3 years agofuzz: updates README
Philippe Antoine [Fri, 24 Sep 2021 06:22:09 +0000 (08:22 +0200)] 
fuzz: updates README

Uses main oss-fuzz repository

More complete flags proposition for direct compilation

3 years agostyle: remove latest warnings
Philippe Antoine [Fri, 24 Sep 2021 13:42:50 +0000 (15:42 +0200)] 
style: remove latest warnings

about unused variables

3 years agoflowint: same analysis warnings as flowbits
Philippe Antoine [Fri, 24 Sep 2021 13:42:41 +0000 (15:42 +0200)] 
flowint: same analysis warnings as flowbits

3 years agopcre2: remove PCRE1 from CI 6417/head
Philippe Antoine [Tue, 28 Sep 2021 10:09:41 +0000 (12:09 +0200)] 
pcre2: remove PCRE1 from CI

3 years agopcre2: remove PCRE1 as dependency 6414/head
Philippe Antoine [Tue, 28 Sep 2021 10:10:10 +0000 (12:10 +0200)] 
pcre2: remove PCRE1 as dependency

3 years agopcre2: follow code naming style
Philippe Antoine [Mon, 20 Sep 2021 20:02:50 +0000 (22:02 +0200)] 
pcre2: follow code naming style

3 years agopcre2: only one DetectParseRegex structure
Philippe Antoine [Mon, 20 Sep 2021 20:00:00 +0000 (22:00 +0200)] 
pcre2: only one DetectParseRegex structure

3 years agopcre2: move header include to suricata-common only
Philippe Antoine [Mon, 20 Sep 2021 19:07:40 +0000 (21:07 +0200)] 
pcre2: move header include to suricata-common only

3 years agopcre2: document the behavioral changes
Philippe Antoine [Tue, 25 May 2021 11:41:02 +0000 (13:41 +0200)] 
pcre2: document the behavioral changes

3 years agopcre2: check for PCRE2_ERROR_UNSET
Philippe Antoine [Mon, 12 Apr 2021 13:41:27 +0000 (15:41 +0200)] 
pcre2: check for PCRE2_ERROR_UNSET

Needs maybe to be generalized

3 years agopcre2: migrate keywords parsing
Philippe Antoine [Sun, 11 Apr 2021 08:37:00 +0000 (10:37 +0200)] 
pcre2: migrate keywords parsing

3 years agopcre: use pcre2 to parse detect pcre itself
Philippe Antoine [Wed, 7 Apr 2021 08:58:17 +0000 (10:58 +0200)] 
pcre: use pcre2 to parse detect pcre itself

3 years agopcre: migrate detect-pcre to pcre2
Philippe Antoine [Mon, 5 Apr 2021 15:41:12 +0000 (17:41 +0200)] 
pcre: migrate detect-pcre to pcre2

pcre2 substrings need special free...

3 years agopcre2: migrate utility uses of pcre
Philippe Antoine [Tue, 13 Apr 2021 12:08:09 +0000 (14:08 +0200)] 
pcre2: migrate utility uses of pcre

3 years agopcre2: migrate transform pcrexform
Philippe Antoine [Tue, 13 Apr 2021 12:02:28 +0000 (14:02 +0200)] 
pcre2: migrate transform pcrexform

3 years agopcre2: introduce as a new depdendency
Philippe Antoine [Tue, 13 Apr 2021 12:01:49 +0000 (14:01 +0200)] 
pcre2: introduce as a new depdendency

3 years agohttp2: follow range requests 6409/head
Philippe Antoine [Tue, 7 Sep 2021 12:54:57 +0000 (14:54 +0200)] 
http2: follow range requests

Move the content-range parsing code to rust

3 years agorange: post process out of order blocks
Philippe Antoine [Tue, 7 Sep 2021 12:52:36 +0000 (14:52 +0200)] 
range: post process out of order blocks

A block is determined out of order on opening.
But on closing, the gap before it may have been filled.
So, we must post-process it, ie iterate over the red and black
tree so see what blocks we can get.

3 years agorange: no final zero in key
Philippe Antoine [Tue, 7 Sep 2021 12:50:27 +0000 (14:50 +0200)] 
range: no final zero in key

for future compatibility with rust

3 years agohttp2: better rust lifetimes
Philippe Antoine [Tue, 7 Sep 2021 12:44:25 +0000 (14:44 +0200)] 
http2: better rust lifetimes

so that borrow check gets happy

3 years agorust: rename to StreamingBufferConfig as in C
Philippe Antoine [Tue, 7 Sep 2021 12:43:16 +0000 (14:43 +0200)] 
rust: rename to StreamingBufferConfig as in C

3 years agohttp: more consistent return values for HTPFileOpenWithRange
Philippe Antoine [Thu, 2 Sep 2021 19:27:14 +0000 (21:27 +0200)] 
http: more consistent return values for HTPFileOpenWithRange

3 years agohttp: increase tracked files for ranges as well
Philippe Antoine [Thu, 2 Sep 2021 19:15:02 +0000 (21:15 +0200)] 
http: increase tracked files for ranges as well

3 years agohttp: range transfering ownership of file container
Philippe Antoine [Thu, 2 Sep 2021 15:14:50 +0000 (17:14 +0200)] 
http: range transfering ownership of file container

To make concurrency reasoning clearer

3 years agohttp: avoid one lock for range append data
Philippe Antoine [Fri, 27 Aug 2021 15:11:23 +0000 (17:11 +0200)] 
http: avoid one lock for range append data

Better structure design to ensure that one flow maximum
is owning and appending into the file, adding fileOwning field.

Adds also a gap field in a range buffer, so that we can
feed the gap on closing, when we are protected from concurrency
by a lock, (lock which got removed in the append path)

Fixes memcap when encountering a duplicate while inserting
in red and black tree

Adds many comments

3 years agothash: add debug validation check for use_cnt
Victor Julien [Tue, 17 Aug 2021 12:07:17 +0000 (14:07 +0200)] 
thash: add debug validation check for use_cnt

3 years agohttp/range: cleanup and simplification
Victor Julien [Tue, 3 Aug 2021 09:51:26 +0000 (11:51 +0200)] 
http/range: cleanup and simplification

Simplify locking by using the THashData lock instead of a separate
range lock.

Avoid size_t in function arguments.

Clean up file handling functions.

Implement handling of alloc errors.

Rename yaml entry to byterange

Unify public api naming

3 years agohttp/range: optimize struct layout
Victor Julien [Tue, 3 Aug 2021 10:21:31 +0000 (12:21 +0200)] 
http/range: optimize struct layout

3 years agohttp/range: fix memory leak on out of order ranges
Victor Julien [Mon, 2 Aug 2021 10:39:21 +0000 (12:39 +0200)] 
http/range: fix memory leak on out of order ranges

3 years agohttp/range: reassemble files from different flows with range
Philippe Antoine [Thu, 18 Feb 2021 14:03:36 +0000 (15:03 +0100)] 
http/range: reassemble files from different flows with range

adds a container, ie a thread safe hash table whose
key is the filename

keep a tree of unordered ranges, up to a memcap limit

adds HTPFileOpenWithRange to handle like HTPFileOpen
if there is a range : open 2 files, one for the whole reassembled,
and one only for the current range

3 years agoutil: export Djb2 hash string function
Philippe Antoine [Thu, 18 Feb 2021 10:44:24 +0000 (11:44 +0100)] 
util: export Djb2 hash string function

3 years agoutil: adds util function SCBufferCmp
Philippe Antoine [Tue, 18 Feb 2020 14:01:03 +0000 (15:01 +0100)] 
util: adds util function SCBufferCmp

Compares two buffers with their two sizes

3 years agodetect: suppress scan-build warning
Victor Julien [Thu, 12 Aug 2021 14:23:11 +0000 (16:23 +0200)] 
detect: suppress scan-build warning

3 years agogithub-ci: remove fedora 32 builds (eol) 6404/head
Jason Ish [Wed, 22 Sep 2021 16:48:52 +0000 (10:48 -0600)] 
github-ci: remove fedora 32 builds (eol)

Promote Fedora versions used in builds to 33 or 34.

3 years agolua: move lua includes to util-lua.h
Jason Ish [Wed, 22 Sep 2021 01:54:03 +0000 (19:54 -0600)] 
lua: move lua includes to util-lua.h

Moves Lua includes to util-lua.h instead of suricata-common
so plugins (or library users) don't need to be aware of the
Lua that Suricata was built with. Instead only source files
that need to be Lua aware can include util-lua.h.

3 years agosmb: fix broken stream depth setting 6395/head
Shivani Bhardwaj [Tue, 7 Sep 2021 12:01:04 +0000 (17:31 +0530)] 
smb: fix broken stream depth setting

The stream depth setting was broken since it was moved to Rust because
of a missing parser for memory values in configuration.
Use get_memval fn from conf.rs to calculate and fetch the correct
values.

3 years agorust/conf: add getter for memval
Shivani Bhardwaj [Thu, 9 Sep 2021 02:36:51 +0000 (08:06 +0530)] 
rust/conf: add getter for memval

Add a parser for memory values like 50kb, 20mb, etc on the Rust side.

3 years agotransform: use generic Free function
Philippe Antoine [Thu, 18 Mar 2021 15:07:55 +0000 (16:07 +0100)] 
transform: use generic Free function

to free subelements in the context structure

3 years agofuzz: fixes a leak in applayerparse target
Philippe Antoine [Mon, 20 Sep 2021 18:45:10 +0000 (20:45 +0200)] 
fuzz: fixes a leak in applayerparse target

If a protocol change was requested, the target did not handle
it as Suricata, as the target is meant to handle only one
app-layer protocol.

3 years agoplugins: check if eve file type is registered
Jason Ish [Mon, 31 May 2021 22:55:31 +0000 (16:55 -0600)] 
plugins: check if eve file type is registered

Instead of the 2 registration functions, just use one with
a utility method to check for conflicts against built-in
types.

3 years agoplugins: remove internal fields
Jason Ish [Thu, 27 May 2021 17:46:19 +0000 (11:46 -0600)] 
plugins: remove internal fields

The internal flag is not really used. This also reverts the behaviour of
the plugin refactor of passing a ConfNode based on the plugin name
instead of the eve ConfNode.

3 years agoeve/syslog: remove "plugin" naming
Jason Ish [Wed, 26 May 2021 21:25:22 +0000 (15:25 -0600)] 
eve/syslog: remove "plugin" naming

3 years agoeve: register internal output file types
Jason Ish [Wed, 26 May 2021 18:46:54 +0000 (12:46 -0600)] 
eve: register internal output file types

Register known eve output file types during eve registration. This
removes the function to load internal plugins as they are not really
plugins and moves the registration of them into their respective
subsystem.

3 years agoplugins: rename SCPLuginFileType to SCEveFileType
Jason Ish [Wed, 26 May 2021 18:26:38 +0000 (12:26 -0600)] 
plugins: rename SCPLuginFileType to SCEveFileType

With internal code using the plugin API to register an Eve
filetype, the name plugin no longer makes sense. This is
part of my idea that internal plugins aren't plugins at all,
and the plugin interface should be an abstraction over
internal APIs.

Along that idea, this is the start of a refactor of the plugin
file types to be internal, where the plugin API is just an external
interface to that internal API.

3 years agooutput/syslog: Register syslog plugin
Jeff Lucovsky [Sat, 15 May 2021 17:40:32 +0000 (13:40 -0400)] 
output/syslog: Register syslog plugin

This commit completes the syslog conversion to an internal output plugin
with registration to make it available as an output file type.

3 years agooutput/plugin: Refactor eve registration function
Jeff Lucovsky [Sat, 15 May 2021 14:38:40 +0000 (10:38 -0400)] 
output/plugin: Refactor eve registration function

3 years agooutput/syslog: Refactor syslog definitions
Jeff Lucovsky [Sat, 15 May 2021 14:13:59 +0000 (10:13 -0400)] 
output/syslog: Refactor syslog definitions

3 years agooutput/syslog: Convert syslog eve output to plugin
Jeff Lucovsky [Sat, 15 May 2021 14:08:33 +0000 (10:08 -0400)] 
output/syslog: Convert syslog eve output to plugin

This commit converts the "built-in" syslog eve output handler into an
internal plugin.

3 years agooutput/json: Refactor internal routines
Jeff Lucovsky [Sat, 15 May 2021 14:02:14 +0000 (10:02 -0400)] 
output/json: Refactor internal routines

3 years agoplugin: Refactor and create registration function
Jeff Lucovsky [Sat, 15 May 2021 13:49:23 +0000 (09:49 -0400)] 
plugin: Refactor and create registration function

This commit refactors the plugin registration code and creates an API
for plugin registration

3 years agooutput/plugin: Load internal plugins
Jeff Lucovsky [Sat, 15 May 2021 13:23:54 +0000 (09:23 -0400)] 
output/plugin: Load internal plugins

This commit adds an interface for loading plugins that are internal to
Suricata. These are always loaded and are in a modified format from
external pliguns.

3 years agoplugin: Add "not set" plugin value type
Jeff Lucovsky [Thu, 18 Mar 2021 13:27:48 +0000 (09:27 -0400)] 
plugin: Add "not set" plugin value type

This value is used as a sentinel to determine if the configured
eve.json filetype was located.

First, the built-in and internal output plugins are checked. If the
sentinel value remains set, the external plugins are searched for the
filetype.

3 years agoutil/lua-common: use lua_pushnumber for SCFileInfo 6383/head
Juliana Fajardini [Thu, 16 Sep 2021 13:48:09 +0000 (14:48 +0100)] 
util/lua-common: use lua_pushnumber for SCFileInfo

3 years agodoc/lua-functions: add sha items to SCFileInfo doc
Juliana Fajardini [Tue, 14 Sep 2021 09:04:38 +0000 (10:04 +0100)] 
doc/lua-functions: add sha items to SCFileInfo doc

3 years agoutil/lua-common: fix SCFileInfo bug & doc comment
Juliana Fajardini [Tue, 14 Sep 2021 08:49:07 +0000 (09:49 +0100)] 
util/lua-common: fix SCFileInfo bug & doc comment

The callback for FileInfo was returning the wrong value, resulting
in loss of some tuple values for one calling SCFileInfo in a script.

The documentation comment wasn't mentioning the sha items that are
pushed.

3 years agoutil/lua-common: use pushinteger w/ byte & pkt cnt
Juliana Fajardini [Tue, 7 Sep 2021 09:37:19 +0000 (10:37 +0100)] 
util/lua-common: use pushinteger w/ byte & pkt cnt

LuaCallbackStatsPushToStackFromFlow tuple is composed of integer values
not all of them had been converted to lua_pushinteger yet.

3 years agoutil/lua-common: update copyright year
Juliana Fajardini [Mon, 26 Jul 2021 14:35:40 +0000 (15:35 +0100)] 
util/lua-common: update copyright year

3 years agoutil-lua-common: use lua_pushinteger w/ int values
Juliana Fajardini [Mon, 26 Jul 2021 12:24:02 +0000 (13:24 +0100)] 
util-lua-common: use lua_pushinteger w/ int values

replace lua_pushnumber with lua_pushinteger for SCFlowStats and
SCRuleIds.

3 years agolua/output: fix typo
Juliana Fajardini [Thu, 22 Jul 2021 19:58:01 +0000 (20:58 +0100)] 
lua/output: fix typo

3 years agolua: use pushinteger for int in flow/packet tuples
Juliana Fajardini [Mon, 5 Jul 2021 11:18:41 +0000 (12:18 +0100)] 
lua: use pushinteger for int in flow/packet tuples

3 years agossh: remove futile default port setting
Shivani Bhardwaj [Tue, 7 Sep 2021 00:29:04 +0000 (05:59 +0530)] 
ssh: remove futile default port setting

3 years agosmb: remove futile default port setting
Shivani Bhardwaj [Tue, 7 Sep 2021 00:28:44 +0000 (05:58 +0530)] 
smb: remove futile default port setting

3 years agorfb: remove futile default port setting
Shivani Bhardwaj [Tue, 7 Sep 2021 00:28:13 +0000 (05:58 +0530)] 
rfb: remove futile default port setting

3 years agonfs: remove futile default port setting
Shivani Bhardwaj [Tue, 7 Sep 2021 00:27:55 +0000 (05:57 +0530)] 
nfs: remove futile default port setting

3 years agoapplayer: error if probes are null but port is not
Shivani Bhardwaj [Tue, 7 Sep 2021 00:20:11 +0000 (05:50 +0530)] 
applayer: error if probes are null but port is not

If the default port is set via the Rust registration table but the probe
fns to server and to client are set to None, the port is never used.
Setting port in such a case is useless so error out.

3 years agodcerpc: use null for default ports
Shivani Bhardwaj [Fri, 25 Jun 2021 17:56:44 +0000 (23:26 +0530)] 
dcerpc: use null for default ports

3 years agodoc: remove prelude and document as removed
Jason Ish [Tue, 7 Sep 2021 20:40:36 +0000 (14:40 -0600)] 
doc: remove prelude and document as removed