]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/log
thirdparty/foundation/foundation-sites.git
9 years agoAdd setSize handler on setSticky for having the container resizing correctly if stick... 8553/head
g.chanaud [Fri, 8 Apr 2016 17:50:29 +0000 (19:50 +0200)] 
Add setSize handler on setSticky for having the container resizing correctly if sticky and anchored height are different. Waiting for the height transition on the container to finish before firing the setSize

9 years ago[Bugfix] Sticky - sticky-container should be 0px height when children element is...
g.chanaud [Fri, 8 Apr 2016 11:29:57 +0000 (13:29 +0200)] 
[Bugfix] Sticky - sticky-container should be 0px height when children element is not displayed. It happens with a responsive dropdown/small-drilldown and a sticky dropdown

9 years agoMerge branch 'master' into develop
Kevin Ball [Thu, 7 Apr 2016 04:00:01 +0000 (21:00 -0700)] 
Merge branch 'master' into develop

9 years agoMerge pull request #8517 from tyrion273/patch-2
Kevin Ball [Wed, 6 Apr 2016 23:49:37 +0000 (16:49 -0700)] 
Merge pull request #8517 from tyrion273/patch-2

Location of settings file now clearer

9 years agoMerge pull request #8514 from tyrion273/patch-1
Kevin Ball [Wed, 6 Apr 2016 23:45:40 +0000 (16:45 -0700)] 
Merge pull request #8514 from tyrion273/patch-1

Enabling now clearer

9 years agoMerge pull request #8511 from ncoden/fix-flex-grid-nowrap
Kevin Ball [Wed, 6 Apr 2016 23:38:22 +0000 (16:38 -0700)] 
Merge pull request #8511 from ncoden/fix-flex-grid-nowrap

Fix flex-grid-column with nowrap child

9 years agoMerge pull request #8031 from cucharadepalo/patch-2
Andy Cochran [Wed, 6 Apr 2016 22:55:07 +0000 (18:55 -0400)] 
Merge pull request #8031 from cucharadepalo/patch-2

Added button-color-alt variable to mixin

9 years agoFix issue where reveal was not respecting offset data vars, with visual testcase
Kevin Ball [Wed, 6 Apr 2016 21:23:26 +0000 (14:23 -0700)] 
Fix issue where reveal was not respecting offset data vars, with visual testcase

9 years agoMerge pull request #8525 from andycochran/fixbttngrpmrg
Kevin Ball [Tue, 5 Apr 2016 22:44:23 +0000 (15:44 -0700)] 
Merge pull request #8525 from andycochran/fixbttngrpmrg

Redo clobbered non-flex Button Group styles

9 years agoMerge pull request #8445 from abdullahsalem/button-group-stacked-margin
Kevin Ball [Tue, 5 Apr 2016 18:12:43 +0000 (11:12 -0700)] 
Merge pull request #8445 from abdullahsalem/button-group-stacked-margin

Fixed the margin (separator) of the stacked button group #8444

9 years agoMerge pull request #8192 from merlinpatt/develop
Kevin Ball [Tue, 5 Apr 2016 18:02:39 +0000 (11:02 -0700)] 
Merge pull request #8192 from merlinpatt/develop

Update MediaQueries to initialize if not initialized already.

9 years agoMerge pull request #8317 from flexbox/pointer-event
Kevin Ball [Tue, 5 Apr 2016 17:31:08 +0000 (10:31 -0700)] 
Merge pull request #8317 from flexbox/pointer-event

cursor pointer need some love for disabled items

9 years agoMerge pull request #8526 from ncoden/fix_equalizer_empty
Kevin Ball [Tue, 5 Apr 2016 15:51:50 +0000 (08:51 -0700)] 
Merge pull request #8526 from ncoden/fix_equalizer_empty

Fix setting up of an empty equalized list #8521

9 years agoMerge pull request #8509 from brettdewoody/feature/add-svg-interchange
Kevin Ball [Tue, 5 Apr 2016 15:51:33 +0000 (08:51 -0700)] 
Merge pull request #8509 from brettdewoody/feature/add-svg-interchange

Add support for SVG to Interchange.

9 years agoFix setting up of an empty equalized list #8521 8526/head
Nicolas Coden [Tue, 5 Apr 2016 02:09:44 +0000 (04:09 +0200)] 
Fix setting up of an empty equalized list #8521

Fix https://github.com/zurb/foundation-sites/issues/8521

9 years agoMerge pull request #8475 from Owlbertz/dropdown-alignment
Kevin Ball [Mon, 4 Apr 2016 19:14:01 +0000 (12:14 -0700)] 
Merge pull request #8475 from Owlbertz/dropdown-alignment

Enabling floated dropdown alignment

9 years agoredo clobbered non-flex Button Group styles 8525/head
Andy Cochran [Mon, 4 Apr 2016 18:16:26 +0000 (14:16 -0400)] 
redo clobbered non-flex Button Group styles

9 years agoMerge pull request #8524 from EHackettTriCore/patch-4
Kevin Ball [Mon, 4 Apr 2016 18:08:57 +0000 (11:08 -0700)] 
Merge pull request #8524 from EHackettTriCore/patch-4

Update Panini Docs : Custom Helpers

9 years agoUpdate Panini Docs : Custom Helpers 8524/head
Ethan Hackett [Mon, 4 Apr 2016 17:41:55 +0000 (13:41 -0400)] 
Update Panini Docs : Custom Helpers

Update Panini docs https://github.com/zurb/foundation-sites/pull/8522

9 years agoUpdate sass.md 8517/head
Oliver Stapelfeldt [Sun, 3 Apr 2016 16:45:20 +0000 (18:45 +0200)] 
Update sass.md

9 years agoUpdate flexbox.md 8514/head
Oliver Stapelfeldt [Sun, 3 Apr 2016 09:24:40 +0000 (11:24 +0200)] 
Update flexbox.md

9 years agoUpdate flexbox.md
Oliver Stapelfeldt [Sun, 3 Apr 2016 08:40:42 +0000 (10:40 +0200)] 
Update flexbox.md

9 years agoMerge pull request #8506 from zurb/briantan888-patch-1
Brian Tan [Sat, 2 Apr 2016 04:39:20 +0000 (00:39 -0400)] 
Merge pull request #8506 from zurb/briantan888-patch-1

Fix slider bug when start is not 0

9 years agoFix flex-grid-column with nowrap child 8511/head
Nicolas Coden [Sat, 2 Apr 2016 01:37:51 +0000 (03:37 +0200)] 
Fix flex-grid-column with nowrap child

On the last version of chrome, the child of a `flex-grid-column(null)`
with
```css
white-space: nowrap;
overflow: hidden;
```
doesn't have a limited size, and the full content is showed in one line
exceeding the row.

`min-width: 0;` fix this problem, probably by remembering to chrome to
evaluate the column width with a `0px` content width (it's what `flex:
1 1 0px` should do).
https://stackoverflow.com/questions/34934586/white-space-nowrap-and-flex
box-did-not-work-in-chrome

9 years agoMerge pull request #8473 from Owlbertz/fix-reveal-destroy
Kevin Ball [Sat, 2 Apr 2016 00:22:29 +0000 (17:22 -0700)] 
Merge pull request #8473 from Owlbertz/fix-reveal-destroy

Fix issue with Reveal#destroy().

9 years agoMerge pull request #8477 from Owlbertz/keyboard-drilldown
Kevin Ball [Fri, 1 Apr 2016 23:11:21 +0000 (16:11 -0700)] 
Merge pull request #8477 from Owlbertz/keyboard-drilldown

Fix keyboard access for drilldown

9 years agoFix slider bug when start is not 0 8506/head
Brian Tan [Fri, 1 Apr 2016 18:06:26 +0000 (14:06 -0400)] 
Fix slider bug when start is not 0

141: pctOfBar should take account of start value
278: value should have start offset.

9 years agoMerge branch 'customizer' into develop
Kevin Ball [Fri, 1 Apr 2016 17:54:14 +0000 (10:54 -0700)] 
Merge branch 'customizer' into develop

9 years agoExplicitly add flex modules
Kevin Ball [Fri, 1 Apr 2016 17:52:26 +0000 (10:52 -0700)] 
Explicitly add flex modules

9 years agoUpdate panini and octophant dependencies, and disable automated template updates...
Geoff Kimball [Fri, 1 Apr 2016 00:32:17 +0000 (17:32 -0700)] 
Update panini and octophant dependencies, and disable automated template updates in deploy process for now

9 years agoAdd docs page for Style Sherpa
Geoff Kimball [Wed, 30 Mar 2016 20:52:31 +0000 (13:52 -0700)] 
Add docs page for Style Sherpa

9 years agofixes comment typo
Rafi [Wed, 30 Mar 2016 16:40:03 +0000 (09:40 -0700)] 
fixes comment typo

9 years agoMerge pull request #8400 from zurb/customizer
kball [Wed, 30 Mar 2016 00:01:46 +0000 (17:01 -0700)] 
Merge pull request #8400 from zurb/customizer

Customizer Updates

9 years agoIn customizer Gulp tasks, prevent build from failing if the form data JSON given... 8400/head
Geoff Kimball [Tue, 29 Mar 2016 22:24:38 +0000 (15:24 -0700)] 
In customizer Gulp tasks, prevent build from failing if the form data JSON given is missing the variables key

9 years agoFix typo in docs Sass file
Geoff Kimball [Tue, 29 Mar 2016 21:23:21 +0000 (14:23 -0700)] 
Fix typo in docs Sass file

9 years agoCopy framework-specific docs example CSS from foundation-docs repo
Geoff Kimball [Tue, 29 Mar 2016 20:43:00 +0000 (13:43 -0700)] 
Copy framework-specific docs example CSS from foundation-docs repo

9 years agoIn customizer Gulp tasks, don't print a $foundation-palette override if no color...
Geoff Kimball [Tue, 29 Mar 2016 16:32:54 +0000 (09:32 -0700)] 
In customizer Gulp tasks, don't print a $foundation-palette override if no color variables are included in the custom build definition

9 years agoIn customizer Gulpfile, ensure color variables passed in are all merged into $foundat...
Geoff Kimball [Mon, 28 Mar 2016 20:33:30 +0000 (13:33 -0700)] 
In customizer Gulpfile, ensure color variables passed in are all merged into $foundation-palette

9 years agoRemove util-map.json, the functionality of which is now covered by customizer/config.yml
Geoff Kimball [Mon, 28 Mar 2016 20:20:00 +0000 (13:20 -0700)] 
Remove util-map.json, the functionality of which is now covered by customizer/config.yml

9 years agoIn customizer Gulp task, ensure all JavaScript files are properly included
Geoff Kimball [Mon, 28 Mar 2016 20:19:15 +0000 (13:19 -0700)] 
In customizer Gulp task, ensure all JavaScript files are properly included

9 years agoIn customizer Gulp tasks, add default values for the --modules and --output flags...
Geoff Kimball [Mon, 28 Mar 2016 20:17:16 +0000 (13:17 -0700)] 
In customizer Gulp tasks, add default values for the --modules and --output flags, and ensure all files print to the correct output directory

9 years agoEnsure that customizer config presets and module list are complete
Geoff Kimball [Mon, 28 Mar 2016 20:03:20 +0000 (13:03 -0700)] 
Ensure that customizer config presets and module list are complete

9 years agoMerge pull request #8472 from colin-marshall/babel-tests
Colin Marshall [Mon, 28 Mar 2016 17:55:19 +0000 (11:55 -0600)] 
Merge pull request #8472 from colin-marshall/babel-tests

ES6/Babel in JS unit tests

9 years agoMerge pull request #8436 from JeremyEnglert/dropdown-menu-fouc
Geoff Kimball [Mon, 28 Mar 2016 17:42:05 +0000 (10:42 -0700)] 
Merge pull request #8436 from JeremyEnglert/dropdown-menu-fouc

Preventing FOUC

9 years agoApply display: block; to flex grid items with .row and .column, so the content inside...
Geoff Kimball [Mon, 28 Mar 2016 17:34:47 +0000 (10:34 -0700)] 
Apply display: block; to flex grid items with .row and .column, so the content inside flows properly

9 years agoAdd max-width: none; to nested rows to ensure they're always the full width of the...
Geoff Kimball [Mon, 28 Mar 2016 17:30:54 +0000 (10:30 -0700)] 
Add max-width: none; to nested rows to ensure they're always the full width of the parent row, closes #8304

9 years agoAdd reference to NuGet package in installation docs #8302
Geoff Kimball [Mon, 28 Mar 2016 16:41:08 +0000 (09:41 -0700)] 
Add reference to NuGet package in installation docs #8302

9 years agoFix keyboard access for drilldown 8477/head
Marius Olbertz [Mon, 28 Mar 2016 14:38:23 +0000 (16:38 +0200)] 
Fix keyboard access for drilldown

Mainly I changed the focused elements to be the `a` tags rather than the `li` tags.
I also added anchors to the menu links in the docs, so it is possible to actually click/space/enter the links to open a new page (or at least change their window's location).
The fact that the links within the menus had only pure `#`es in their `href` did not cover the real-life menu purposes and made proper testing a bit hard.

9 years agoEnabling dropdown alignment as requested in https://github.com/zurb/foundation-sites... 8475/head
Marius Olbertz [Mon, 28 Mar 2016 11:25:43 +0000 (13:25 +0200)] 
Enabling dropdown alignment as requested in https://github.com/zurb/foundation-sites/issues/7392.

Basically my former solution merged into the current state of development.

9 years agoAdded starter templates for js component unit tests 8472/head
Colin Marshall [Mon, 28 Mar 2016 02:36:15 +0000 (20:36 -0600)] 
Added starter templates for js component unit tests

9 years agoAdded multiline string to Toggler unit tests
Colin Marshall [Sun, 27 Mar 2016 22:41:07 +0000 (16:41 -0600)] 
Added multiline string to Toggler unit tests

9 years agoAdded clean step prior to transpiling js unit tests
Colin Marshall [Sun, 27 Mar 2016 22:39:43 +0000 (16:39 -0600)] 
Added clean step prior to transpiling js unit tests

9 years agoLink concatenated js unit tests in index.html
Colin Marshall [Sun, 27 Mar 2016 22:38:59 +0000 (16:38 -0600)] 
Link concatenated js unit tests in index.html

9 years agoFix issue with Reveal#destroy(). 8473/head
Marius Olbertz [Sun, 27 Mar 2016 11:23:38 +0000 (13:23 +0200)] 
Fix issue with Reveal#destroy().

Moved $element outside of $overlay to prevent error unregisterPlugin().

9 years agoAdded transpiled js tests file to gitignore
Colin Marshall [Sun, 27 Mar 2016 01:05:00 +0000 (19:05 -0600)] 
Added transpiled js tests file to gitignore

9 years agoAdded ES6/babel to JS tests, exported babel reporting
Colin Marshall [Sun, 27 Mar 2016 00:43:03 +0000 (18:43 -0600)] 
Added ES6/babel to JS tests, exported babel reporting

9 years agoAdd support for SVG to Interchange. 8468/head 8509/head
Brett DeWoody [Sat, 26 Mar 2016 14:34:15 +0000 (08:34 -0600)] 
Add support for SVG to Interchange.

9 years agoMerge pull request #8453 from Owlbertz/focus-reveal
Marius Olbertz [Thu, 24 Mar 2016 17:53:18 +0000 (18:53 +0100)] 
Merge pull request #8453 from Owlbertz/focus-reveal

Fixes issue when putting focus to an input outside of the modal.

9 years agoFixes issue when putting focus to an input outside of the modal. 8453/head
Marius Olbertz [Thu, 24 Mar 2016 08:03:19 +0000 (09:03 +0100)] 
Fixes issue when putting focus to an input outside of the modal.

9 years agofixes emails docs link
RafiBomb [Wed, 23 Mar 2016 15:18:24 +0000 (08:18 -0700)] 
fixes emails docs link

9 years agoMerge pull request #8376 from andycochran/multiselect
Andy Cochran [Tue, 22 Mar 2016 18:19:25 +0000 (14:19 -0400)] 
Merge pull request #8376 from andycochran/multiselect

Remove triangle from select elements with the multiple attribute.

9 years agoFix typo in Contributing Guidelines.
Andy Cochran [Tue, 22 Mar 2016 15:25:01 +0000 (11:25 -0400)] 
Fix typo in Contributing Guidelines.

9 years agoFixed the margin (separator) of the stacked button group 8445/head
Abdullah Salem [Tue, 22 Mar 2016 13:50:29 +0000 (16:50 +0300)] 
Fixed the margin (separator) of the stacked button group

9 years agoPreventing FOUC 8436/head
Jeremy Englert [Mon, 21 Mar 2016 01:14:23 +0000 (18:14 -0700)] 
Preventing FOUC

9 years agoAdd link to coding standards in contributing.md
Geoff Kimball [Thu, 17 Mar 2016 16:47:24 +0000 (09:47 -0700)] 
Add link to coding standards in contributing.md

9 years agoMerge branch 'designerno1-patch-1' into develop
Geoff Kimball [Thu, 17 Mar 2016 16:37:17 +0000 (09:37 -0700)] 
Merge branch 'designerno1-patch-1' into develop

9 years agoAdjust formatting of a sentence in contributing.md
Geoff Kimball [Thu, 17 Mar 2016 16:37:03 +0000 (09:37 -0700)] 
Adjust formatting of a sentence in contributing.md

9 years agoMerge branch 'patch-1' of https://github.com/designerno1/foundation-sites into design...
Geoff Kimball [Thu, 17 Mar 2016 16:35:56 +0000 (09:35 -0700)] 
Merge branch 'patch-1' of https://github.com/designerno1/foundation-sites into designerno1-patch-1

9 years agoMerge branch 'themestechnology-patch-1' into develop
Geoff Kimball [Thu, 17 Mar 2016 16:34:45 +0000 (09:34 -0700)] 
Merge branch 'themestechnology-patch-1' into develop

9 years agoAdjust formatting of complete off-canvas example in docs
Geoff Kimball [Thu, 17 Mar 2016 16:34:30 +0000 (09:34 -0700)] 
Adjust formatting of complete off-canvas example in docs

9 years agoMerge branch 'patch-1' of https://github.com/themestechnology/foundation-sites into...
Geoff Kimball [Thu, 17 Mar 2016 16:27:54 +0000 (09:27 -0700)] 
Merge branch 'patch-1' of https://github.com/themestechnology/foundation-sites into themestechnology-patch-1

9 years agoCreate individual JS files for each plugin, and add them to the dist folder. Allows...
Geoff Kimball [Thu, 17 Mar 2016 16:27:22 +0000 (09:27 -0700)] 
Create individual JS files for each plugin, and add them to the dist folder. Allows users without Babel to use individual JS plugins. Closes #8406

9 years agoUpdate CONTRIBUTING.md 8421/head
designerno1 [Wed, 16 Mar 2016 23:33:17 +0000 (00:33 +0100)] 
Update CONTRIBUTING.md

i stopped the work on Clearing, please change it to the equalizer extension i wrote thanks

9 years agoAllow paths to be passed to the --output flag of the customizer
Geoff Kimball [Wed, 16 Mar 2016 22:04:07 +0000 (15:04 -0700)] 
Allow paths to be passed to the --output flag of the customizer

9 years agoMerge branch 'develop' of https://github.com/zurb/foundation into develop
Geoff Kimball [Wed, 16 Mar 2016 16:46:06 +0000 (09:46 -0700)] 
Merge branch 'develop' of https://github.com/zurb/foundation into develop

9 years agoMerge branch 'Owlbertz-keyboard-accordion-menu' into develop
Geoff Kimball [Wed, 16 Mar 2016 16:44:01 +0000 (09:44 -0700)] 
Merge branch 'Owlbertz-keyboard-accordion-menu' into develop

9 years agoAdd test case for keyboard control on accordion menus
Geoff Kimball [Mon, 14 Mar 2016 17:43:00 +0000 (10:43 -0700)] 
Add test case for keyboard control on accordion menus

9 years agoAdd visual test for sliders with a nonzero start value
Geoff Kimball [Fri, 11 Mar 2016 19:27:26 +0000 (11:27 -0800)] 
Add visual test for sliders with a nonzero start value

9 years agofix error when -spacing is 0
Andy Cochran [Thu, 10 Mar 2016 21:47:14 +0000 (16:47 -0500)] 
fix error when -spacing is 0

9 years agoAdd visual test page to show programmatic use of close triggers
Geoff Kimball [Tue, 8 Mar 2016 22:43:20 +0000 (14:43 -0800)] 
Add visual test page to show programmatic use of close triggers

9 years agoAdd visual test for tall reveal modals, and a modal with a close button sitting over...
Geoff Kimball [Tue, 8 Mar 2016 18:36:57 +0000 (10:36 -0800)] 
Add visual test for tall reveal modals, and a modal with a close button sitting over the overlay #7875

9 years agoChange with property to max-width for <input> elements inside of a top bar, which...
Geoff Kimball [Tue, 8 Mar 2016 18:25:25 +0000 (10:25 -0800)] 
Change with property to max-width for <input> elements inside of a top bar, which restrains the width of text fields without making them crazy wide in some situations. #7451

9 years agoinclude disable-mouse-outline on default button element
Andy Cochran [Tue, 8 Mar 2016 18:22:06 +0000 (13:22 -0500)] 
include disable-mouse-outline on default button element

9 years agoPrevent dropdown panes taller than the window from resizing to be full-width, fixes...
Geoff Kimball [Tue, 8 Mar 2016 18:14:00 +0000 (10:14 -0800)] 
Prevent dropdown panes taller than the window from resizing to be full-width, fixes #7957

9 years agouse button for .menu-icon instead of span
Andy Cochran [Tue, 8 Mar 2016 18:08:12 +0000 (13:08 -0500)] 
use button for .menu-icon instead of span

9 years agoUpdate ISSUE_TEMPLATE.md
Rafi [Tue, 8 Mar 2016 17:23:39 +0000 (09:23 -0800)] 
Update ISSUE_TEMPLATE.md

9 years agoUpdate ISSUE_TEMPLATE.md
Rafi [Tue, 8 Mar 2016 17:23:16 +0000 (09:23 -0800)] 
Update ISSUE_TEMPLATE.md

9 years agoCorrect reference to wrong 'this' in Reveal JavaScript, closes zurb/motion-ui#75
Geoff Kimball [Tue, 8 Mar 2016 17:11:43 +0000 (09:11 -0800)] 
Correct reference to wrong 'this' in Reveal JavaScript, closes zurb/motion-ui#75

9 years agoRemove border radius from full-screen modal
Alexandre B [Mon, 7 Mar 2016 20:00:04 +0000 (21:00 +0100)] 
Remove border radius from full-screen modal

9 years agofix orbit navigation
xfifix [Thu, 3 Mar 2016 15:28:30 +0000 (16:28 +0100)] 
fix orbit navigation

9 years agofix orbit navigation
xfifix [Thu, 3 Mar 2016 15:17:26 +0000 (16:17 +0100)] 
fix orbit navigation

9 years agoAdd test pages for Abide validating other text input types
Geoff Kimball [Wed, 2 Mar 2016 01:38:00 +0000 (17:38 -0800)] 
Add test pages for Abide validating other text input types

9 years agoFix Abide custom patterns not validating properly #8157
Geoff Kimball [Wed, 2 Mar 2016 01:21:10 +0000 (17:21 -0800)] 
Fix Abide custom patterns not validating properly #8157

9 years agoAdd code of conduct
Geoff Kimball [Wed, 16 Mar 2016 16:25:51 +0000 (09:25 -0700)] 
Add code of conduct

9 years agoUpdate contributing guidelines to break down our new contributor program
Geoff Kimball [Wed, 16 Mar 2016 16:25:07 +0000 (09:25 -0700)] 
Update contributing guidelines to break down our new contributor program

9 years agoEnable triggering of links within menu via keyboard. 8369/head
Marius Olbertz [Wed, 16 Mar 2016 04:36:09 +0000 (05:36 +0100)] 
Enable triggering of links within menu via keyboard.

9 years agoMerge pull request #8380 from n0o0bSina/develop
Geoff Kimball [Tue, 15 Mar 2016 18:25:45 +0000 (11:25 -0700)] 
Merge pull request #8380 from n0o0bSina/develop

fix input-group(s) childs border-radius in rtl view

9 years agoMerge pull request #8318 from DaSchTour/dev/8257
Geoff Kimball [Tue, 15 Mar 2016 17:49:13 +0000 (10:49 -0700)] 
Merge pull request #8318 from DaSchTour/dev/8257

possible solution for #8257

9 years agoAdd --output flag to customizer to change output ZIP file
Geoff Kimball [Tue, 15 Mar 2016 17:10:00 +0000 (10:10 -0700)] 
Add --output flag to customizer to change output ZIP file

9 years agoGet rid of relative path stuff
Kevin Ball [Mon, 14 Mar 2016 23:54:12 +0000 (16:54 -0700)] 
Get rid of relative path stuff