Colin Marshall [Tue, 26 Apr 2016 00:32:11 +0000 (18:32 -0600)]
Merge branch 'develop' of https://github.com/zurb/foundation-sites into develop
* 'develop' of https://github.com/zurb/foundation-sites:
fixes #8643 do not reset val of radio and checkbox on reset the form reset prop checked false instead maybe a saving of the initial markup state of radio checked and checkbox checked would be great
jk [Fri, 22 Apr 2016 20:58:41 +0000 (22:58 +0200)]
fixes #8643
do not reset val of radio and checkbox on reset the form reset prop checked false instead
maybe a saving of the initial markup state of radio checked and checkbox checked would be great
Issue #7904 should be addressed by updating various ARIA related issues.
Removed aria-hidden on both the body and the overlay. Since the modals are children of both of those anything that has an aria-hidden=true will be ignored by the screen reader. This is why with a keyboard you can tab around int he modal but when you use a screen reader and you tab around you can't access the content within the modal.
I also enhanced the aria-labeledby by checking to see if the modal has a H Tag (H1,2,3,4,5,6) of sorts. If it finds a H Tag the first one found will be associated to the aria-labeledby and thus will result with that text announced to the a screen reader after opening a modal. if there is no header it will utilize the element (href, button, etc...) that opened the modal and associated itself to the aria-labeledby and thus will result with that text announced to the a screen reader after opening a modal.
jk [Wed, 13 Apr 2016 22:45:28 +0000 (00:45 +0200)]
var $body = $('body').not(_this.$wrapper);
not ignores clicks on links in the drilldown menu
fixes links with no sub and closeOnClick true doesn't fire
Issue #7904 should be addressed by updating various ARIA related issues.
Removed aria-hidden on both the body and the overlay. Since the modals are children of both of those anything that has an aria-hidden=true will be ignored by the screen reader. This is why with a keyboard you can tab around int he modal but when you use a screen reader and you tab around you can't access the content within the modal.
I also enhanced the aria-labeledby by checking to see if the modal has a H Tag (H1,2,3,4,5,6) of sorts. If it finds a H Tag the first one found will be associated to the aria-labeledby and thus will result with that text announced to the a screen reader after opening a modal. if there is no header it will utilize the element (href, button, etc...) that opened the modal and associated itself to the aria-labeledby and thus will result with that text announced to the a screen reader after opening a modal.
Marius Olbertz [Mon, 11 Apr 2016 14:27:41 +0000 (16:27 +0200)]
Enhance keyboard util.
Enhanced keyboard util by adding a parameter that is passed to the `handled` function based on the evaluation of the function that was handled.
It is now easier to only do certain actions (e.g. calling `preventDefaul()`) in the `handled` handler by letting the other function (e.g. `next`, `up`, ...) return some value, which is directly passed into `handled` as the first parameter.
I also adjusted the calls to the keyboard util for some plugins to fix issues and prevent bad behavior.
Marius Olbertz [Sat, 9 Apr 2016 10:25:49 +0000 (12:25 +0200)]
Fixed keyboard interaction for dropdown menu.
Fixes behaviour for vertical menus to be correct (switch left/right with up/down compared to horizontal menus).
Fixed usage of `e.preventDefault()` to enable opening of links in the menu.
Marius Olbertz [Sat, 9 Apr 2016 09:58:07 +0000 (11:58 +0200)]
Fix for detection of overfloating dropdown menus.
Because the selectors were not specific enough, the styles of .opens-right set by the JS in case of an overflowing sub-menu was overwritten by the parent's .open-left styles.
Added visual tests to check for this. The tests include two cases: one for a right aligned dropdown using `.top-bar-right` (which was fixed earlier already) and one that is positioned right because of content (where this fix can be tested).
Also added anchors to the menu's links to check for correct behavior of the links, e.g. when using keyboard.
Add setSize handler on setSticky for having the container resizing correctly if sticky and anchored height are different. Waiting for the height transition on the container to finish before firing the setSize
[Bugfix] Sticky - sticky-container should be 0px height when children element is not displayed. It happens with a responsive dropdown/small-drilldown and a sticky dropdown
projects / thirdparty / foundation / foundation-sites.git / log
