]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/log
thirdparty/foundation/foundation-sites.git
9 years agoFixed typo 8762/head
Daniel Schuba [Tue, 10 May 2016 18:18:09 +0000 (20:18 +0200)] 
Fixed typo

9 years agoFix for bug introduced with #8511
Daniel Schuba [Tue, 10 May 2016 12:28:58 +0000 (14:28 +0200)] 
Fix for bug introduced with #8511

9 years agoMerge pull request #8751 from designerno1/scss-lint
designerno1 [Sun, 8 May 2016 08:54:57 +0000 (10:54 +0200)] 
Merge pull request #8751 from designerno1/scss-lint

some scss-lint

9 years agoMerge pull request #8752 from zurb/visual-tests-windows
Colin Marshall [Sun, 8 May 2016 01:04:09 +0000 (19:04 -0600)] 
Merge pull request #8752 from zurb/visual-tests-windows

[Bugfix] Windows visual tests. Fixes #8749.

9 years agoRemoved motion-ui symlink from visual tests 8752/head
Colin Marshall [Sat, 7 May 2016 21:06:11 +0000 (15:06 -0600)] 
Removed motion-ui symlink from visual tests

9 years agoFixed visual tests for Windows.
Colin Marshall [Sat, 7 May 2016 20:25:47 +0000 (14:25 -0600)] 
Fixed visual tests for Windows.

9 years agosome scss-lint 8751/head
jk [Fri, 6 May 2016 21:21:55 +0000 (23:21 +0200)] 
some scss-lint

9 years agoMerge pull request #8747 from designerno1/accordionmenu-move
Kevin Ball [Thu, 5 May 2016 23:57:47 +0000 (16:57 -0700)] 
Merge pull request #8747 from designerno1/accordionmenu-move

remove Foundation.Move() fixes #8724

9 years agoremove Foundation.Move() fixes #8724 8747/head
jk [Thu, 5 May 2016 23:12:16 +0000 (01:12 +0200)] 
remove Foundation.Move() fixes #8724

9 years agoMerge pull request #8742 from colin-marshall/sticky-menu-visual-test
Kevin Ball [Thu, 5 May 2016 18:27:18 +0000 (11:27 -0700)] 
Merge pull request #8742 from colin-marshall/sticky-menu-visual-test

Added visual test for sticky vertical menus with anchors

9 years agoAdded visual test for sticky vertical menus with anchors. 8742/head
Colin Marshall [Thu, 5 May 2016 17:43:04 +0000 (11:43 -0600)] 
Added visual test for sticky vertical menus with anchors.

9 years agoMerge pull request #8740 from brettsmason/media-object-flex-fix
Kevin Ball [Thu, 5 May 2016 17:01:52 +0000 (10:01 -0700)] 
Merge pull request #8740 from brettsmason/media-object-flex-fix

Media object flexbox fixes

9 years agoMerge pull request #8741 from colin-marshall/sticky-accordion-visual-test
Kevin Ball [Thu, 5 May 2016 16:57:54 +0000 (09:57 -0700)] 
Merge pull request #8741 from colin-marshall/sticky-accordion-visual-test

Visual test for sticky accordions with anchors

9 years agoMerge pull request #8471 from Owlbertz/reveal-callout
Kevin Ball [Thu, 5 May 2016 16:54:29 +0000 (09:54 -0700)] 
Merge pull request #8471 from Owlbertz/reveal-callout

Make callouts not close the reveal they are in.

9 years agoAdjusted check if the Reveal was closed or another closable within. 8471/head
Marius Olbertz [Thu, 5 May 2016 16:37:59 +0000 (18:37 +0200)] 
Adjusted check if the Reveal was closed or another closable within.

Also added visual test.

9 years agoAdded visual test for sticky accordions with anchors. 8741/head
Colin Marshall [Thu, 5 May 2016 16:17:03 +0000 (10:17 -0600)] 
Added visual test for sticky accordions with anchors.

9 years agoMerge pull request #8688 from gapple/off-canvas-aria-expanded
Marius Olbertz [Thu, 5 May 2016 14:30:02 +0000 (16:30 +0200)] 
Merge pull request #8688 from gapple/off-canvas-aria-expanded

Toggle aria-expanded on all offcanvas triggers

9 years agoMedia object flexbox fixes 8740/head
Brett Mason [Thu, 5 May 2016 14:19:04 +0000 (15:19 +0100)] 
Media object flexbox fixes

Update `media-object-section` flex property, and wrap `stack-for-small` in zero breakpoint so it doesn't get applied to all breakpoints.

9 years agoMerge pull request #8735 from colin-marshall/sticky-docs-improvement
Colin Marshall [Wed, 4 May 2016 23:12:08 +0000 (17:12 -0600)] 
Merge pull request #8735 from colin-marshall/sticky-docs-improvement

Sticky docs examples improvement:
Moved placeholder paragraphs so the stick-to-top paragraphs had content above them. This helps visualize some of the bugs with Sticky.

9 years agoMerge branch 'gehasia-sticky-docandtest-fix' into develop 8735/head
Colin Marshall [Wed, 4 May 2016 23:04:34 +0000 (17:04 -0600)] 
Merge branch 'gehasia-sticky-docandtest-fix' into develop

* gehasia-sticky-docandtest-fix:
  Modified parapgrah placement in Sticky docs examples

9 years agoMerge pull request #8674 from gehasia/sticky-docandtest-fix
Colin Marshall [Wed, 4 May 2016 23:03:48 +0000 (17:03 -0600)] 
Merge pull request #8674 from gehasia/sticky-docandtest-fix

[Doc] Sticky : Add documentation about stick-to-bottom. Visual test f…

9 years agoModified parapgrah placement in Sticky docs examples
Colin Marshall [Wed, 4 May 2016 23:03:03 +0000 (17:03 -0600)] 
Modified parapgrah placement in Sticky docs examples

9 years agoMerge branch 'sticky-docandtest-fix' of https://github.com/gehasia/foundation-sites...
Colin Marshall [Wed, 4 May 2016 22:34:04 +0000 (16:34 -0600)] 
Merge branch 'sticky-docandtest-fix' of https://github.com/gehasia/foundation-sites into gehasia-sticky-docandtest-fix

* 'sticky-docandtest-fix' of https://github.com/gehasia/foundation-sites:
  Adding more tests
  Adding bottom margin information
  [Doc] Sticky : Add documentation about stick-to-bottom. Visual test fixed + stick-to-bottom test

9 years agoMerge pull request #8730 from coreysyms/develop
Kevin Ball [Wed, 4 May 2016 16:56:57 +0000 (09:56 -0700)] 
Merge pull request #8730 from coreysyms/develop

change default behavior of tooltips

9 years agoMerge pull request #8726 from flyingL123/flyingL123-bar-offset
Kevin Ball [Wed, 4 May 2016 16:52:07 +0000 (09:52 -0700)] 
Merge pull request #8726 from flyingL123/flyingL123-bar-offset

Account for barOffset

9 years agoMerge pull request #8712 from Owlbertz/dropdown-opens-inner
Kevin Ball [Wed, 4 May 2016 16:35:58 +0000 (09:35 -0700)] 
Merge pull request #8712 from Owlbertz/dropdown-opens-inner

Fix open inner for dropdown menu.

9 years agoMerge pull request #8567 from JamesJGarner/patch-1
Kevin Ball [Wed, 4 May 2016 15:54:56 +0000 (08:54 -0700)] 
Merge pull request #8567 from JamesJGarner/patch-1

Update foundation.tooltip.js to enable to parse a postionClass when c…

9 years agochanges to tooltip default behavior 8730/head
Corey Snyder [Tue, 3 May 2016 18:52:40 +0000 (14:52 -0400)] 
changes to tooltip default behavior

9 years agochange default behavior of tooltips
Corey Snyder [Tue, 3 May 2016 17:02:02 +0000 (13:02 -0400)] 
change default behavior of tooltips

9 years agoAccount for barOffset 8726/head
flyingL123 [Tue, 3 May 2016 02:47:55 +0000 (22:47 -0400)] 
Account for barOffset

Account for barOffset value when setting active menu item

9 years agoMerge pull request #8720 from andycochran/accordion
designerno1 [Mon, 2 May 2016 23:16:49 +0000 (01:16 +0200)] 
Merge pull request #8720 from andycochran/accordion

fix defaults for accordion content color

9 years agoMerge pull request #8704 from brettsmason/select-fix
Andy Cochran [Sun, 1 May 2016 15:01:34 +0000 (11:01 -0400)] 
Merge pull request #8704 from brettsmason/select-fix

Fix overlapping select arrow

9 years agofix defaults for accordion content color 8720/head
Andy Cochran [Sun, 1 May 2016 14:48:52 +0000 (10:48 -0400)] 
fix defaults for accordion content color

9 years agoAdding more tests 8674/head
g.chanaud [Sat, 30 Apr 2016 17:24:42 +0000 (19:24 +0200)] 
Adding more tests

9 years agoAdding bottom margin information
g.chanaud [Sat, 30 Apr 2016 12:25:56 +0000 (14:25 +0200)] 
Adding bottom margin information

9 years agoFix open inner for dropdown menu. 8712/head
Marius Olbertz [Sat, 30 Apr 2016 10:11:31 +0000 (12:11 +0200)] 
Fix open inner for dropdown menu.

9 years agoMerge pull request #8706 from andycochran/accordion
Brett Mason [Sat, 30 Apr 2016 08:01:57 +0000 (09:01 +0100)] 
Merge pull request #8706 from andycochran/accordion

fix radius and hover on Accordion

9 years agofix radius and hover on Accordion 8706/head
Andy Cochran [Fri, 29 Apr 2016 18:51:20 +0000 (14:51 -0400)] 
fix radius and hover on Accordion

9 years agoMerge pull request #8691 from zurb/IS8300-click-open-not-being-respected
Colin Marshall [Fri, 29 Apr 2016 18:17:51 +0000 (12:17 -0600)] 
Merge pull request #8691 from zurb/IS8300-click-open-not-being-respected

Fix data-click-open tooltip behavior

9 years agoMerge pull request #8686 from zurb/IS8335-handle-arrays-with-extended-prototypes
Colin Marshall [Fri, 29 Apr 2016 18:02:07 +0000 (12:02 -0600)] 
Merge pull request #8686 from zurb/IS8335-handle-arrays-with-extended-prototypes

Protect array for/in loops

9 years agoAdded padding to $global-right to allow for room for the arrow to appear without... 8704/head
Brett Mason [Fri, 29 Apr 2016 14:58:08 +0000 (15:58 +0100)] 
Added padding to $global-right to allow for room for the arrow to appear without overlapping text.

9 years agoMerge pull request #8616 from andycochran/stacked-button-group-margin
Brett Mason [Fri, 29 Apr 2016 13:50:58 +0000 (14:50 +0100)] 
Merge pull request #8616 from andycochran/stacked-button-group-margin

Fix $buttongroup-spacing

9 years agoprevent rounding bug causing last expanded button in group to wrap 8616/head
Andy Cochran [Fri, 29 Apr 2016 13:37:57 +0000 (09:37 -0400)] 
prevent rounding bug causing last expanded button in group to wrap

9 years agoMerge pull request #8503 from Owlbertz/disable-slider
Kevin Ball [Fri, 29 Apr 2016 00:14:56 +0000 (17:14 -0700)] 
Merge pull request #8503 from Owlbertz/disable-slider

Add possibility to disable slider after initialization.

9 years agoMerge pull request #8695 from andycochran/input-group-button-white-space
Kevin Ball [Thu, 28 Apr 2016 18:57:13 +0000 (11:57 -0700)] 
Merge pull request #8695 from andycochran/input-group-button-white-space

prevent input group buttons wrapping to multiple lines

9 years agoMerge pull request #8678 from zurb/IS7458-reveal-animation-speed
Kevin Ball [Thu, 28 Apr 2016 17:24:47 +0000 (10:24 -0700)] 
Merge pull request #8678 from zurb/IS7458-reveal-animation-speed

Is7458 reveal animation speed

9 years agoprevent input group buttons wrapping to multiple lines 8695/head
Andy Cochran [Thu, 28 Apr 2016 15:20:41 +0000 (11:20 -0400)] 
prevent input group buttons wrapping to multiple lines

9 years agoFix data-click-open tooltip behavior 8691/head
Kevin Ball [Wed, 27 Apr 2016 23:57:24 +0000 (16:57 -0700)] 
Fix data-click-open tooltip behavior

9 years agoToggle aria-expanded on all offcanvas triggers 8688/head
Geoff Appleby [Wed, 27 Apr 2016 22:20:52 +0000 (15:20 -0700)] 
Toggle aria-expanded on all offcanvas triggers

9 years agoProtect array for/in loops 8686/head
Kevin Ball [Wed, 27 Apr 2016 16:32:07 +0000 (09:32 -0700)] 
Protect array for/in loops

9 years agoMerge pull request #8449 from Owlbertz/touch-slider
Kevin Ball [Wed, 27 Apr 2016 16:14:20 +0000 (09:14 -0700)] 
Merge pull request #8449 from Owlbertz/touch-slider

Fixes touch interactions for slider

9 years agoMerge pull request #8683 from artursopelnik/develop
Kevin Ball [Wed, 27 Apr 2016 15:49:08 +0000 (08:49 -0700)] 
Merge pull request #8683 from artursopelnik/develop

Add inline-svg icon support

9 years agoMerge branch 'develop' into stacked-button-group-margin
Andy Cochran [Wed, 27 Apr 2016 15:31:04 +0000 (11:31 -0400)] 
Merge branch 'develop' into stacked-button-group-margin

9 years agoAdd inline-svg icon support 8683/head
ars [Wed, 27 Apr 2016 09:26:51 +0000 (11:26 +0200)] 
Add inline-svg icon support

9 years agofixes variable error in #8650
RafiBomb [Wed, 27 Apr 2016 00:00:54 +0000 (17:00 -0700)] 
fixes variable error in #8650

9 years agoMerge pull request #8679 from designerno1/drilldown-wrapper-fix
Kevin Ball [Tue, 26 Apr 2016 22:59:28 +0000 (15:59 -0700)] 
Merge pull request #8679 from designerno1/drilldown-wrapper-fix

fixes this.$wrapper return #8598

9 years agofixes this.$wrapper return #8598 8679/head
jk [Tue, 26 Apr 2016 22:31:29 +0000 (00:31 +0200)] 
fixes this.$wrapper return #8598

9 years agoMerge pull request #8650 from andycochran/disabledbuttonhover
Kevin Ball [Tue, 26 Apr 2016 22:16:31 +0000 (15:16 -0700)] 
Merge pull request #8650 from andycochran/disabledbuttonhover

prevent hover/focus effects on disabled buttons

9 years agoMerge pull request #8646 from denisahac/develop
Kevin Ball [Tue, 26 Apr 2016 22:12:41 +0000 (15:12 -0700)] 
Merge pull request #8646 from denisahac/develop

Appended "color: $accordion-content-color;" declaration in accordion-…

9 years agoMerge pull request #8642 from designerno1/fixes-8624
Kevin Ball [Tue, 26 Apr 2016 22:08:36 +0000 (15:08 -0700)] 
Merge pull request #8642 from designerno1/fixes-8624

fixes #8624 call stop on destroy

9 years agoMerge pull request #8626 from dragthor/registerPlugin-spelling-typo
Kevin Ball [Tue, 26 Apr 2016 22:04:16 +0000 (15:04 -0700)] 
Merge pull request #8626 from dragthor/registerPlugin-spelling-typo

registerPlugin unregisterPlugin spelling typo

9 years agoMerge pull request #8600 from designerno1/breakpoint-lint
Kevin Ball [Tue, 26 Apr 2016 21:54:08 +0000 (14:54 -0700)] 
Merge pull request #8600 from designerno1/breakpoint-lint

fix 3 lint issues _breakpoint.scss

9 years agoMerge pull request #8599 from designerno1/drilldown-closeOnClick
Kevin Ball [Tue, 26 Apr 2016 21:53:22 +0000 (14:53 -0700)] 
Merge pull request #8599 from designerno1/drilldown-closeOnClick

fixes closeOnClick

9 years agoMerge pull request #8673 from designerno1/equalizer-stack-fix
Kevin Ball [Tue, 26 Apr 2016 21:29:07 +0000 (14:29 -0700)] 
Merge pull request #8673 from designerno1/equalizer-stack-fix

possible fix for #8671

9 years agoAdd fast and slow classes to overlay if they exist on reveal 8678/head
Kevin Ball [Tue, 26 Apr 2016 21:22:40 +0000 (14:22 -0700)] 
Add fast and slow classes to overlay if they exist on reveal

9 years agoTest for animation of reveal
Kevin Ball [Tue, 26 Apr 2016 21:20:32 +0000 (14:20 -0700)] 
Test for animation of reveal

9 years ago[Doc] Sticky : Add documentation about stick-to-bottom. Visual test fixed + stick...
g.chanaud [Tue, 26 Apr 2016 20:01:03 +0000 (22:01 +0200)] 
[Doc] Sticky : Add documentation about stick-to-bottom. Visual test fixed + stick-to-bottom test

9 years agopossible fix for #8671 8673/head
jk [Tue, 26 Apr 2016 17:31:25 +0000 (19:31 +0200)] 
possible fix for #8671
use getBoundingClintRect().top to detect stack

9 years agoMerge branch 'develop' of https://github.com/zurb/foundation-sites into develop
Colin Marshall [Tue, 26 Apr 2016 00:32:11 +0000 (18:32 -0600)] 
Merge branch 'develop' of https://github.com/zurb/foundation-sites into develop

* 'develop' of https://github.com/zurb/foundation-sites:
  fixes #8643 do not reset val of radio and checkbox on reset the form reset prop checked false instead maybe a saving of the initial markup state of radio checked and checkbox checked would be great

9 years agoChanged title-bar menu-icon side margins to be equal
Colin Marshall [Tue, 26 Apr 2016 00:31:15 +0000 (18:31 -0600)] 
Changed title-bar menu-icon side margins to be equal

9 years agoMerge pull request #8657 from designerno1/fixes-8643
Kevin Ball [Mon, 25 Apr 2016 20:03:25 +0000 (13:03 -0700)] 
Merge pull request #8657 from designerno1/fixes-8643

fixes #8643 do not reset val of radio and checkbox on reset

9 years agoAdded better styling to sticky callouts with anchors visual test
Colin Marshall [Mon, 25 Apr 2016 18:54:59 +0000 (12:54 -0600)] 
Added better styling to sticky callouts with anchors visual test

9 years agoAdded visual test for sticky nav from @gehasia
Colin Marshall [Mon, 25 Apr 2016 18:20:30 +0000 (12:20 -0600)] 
Added visual test for sticky nav from @gehasia

9 years agoFixed bug that was causing multiple reloads to occur for 1 file change in visual...
Colin Marshall [Mon, 25 Apr 2016 18:10:19 +0000 (12:10 -0600)] 
Fixed bug that was causing multiple reloads to occur for 1 file change in visual tests

9 years agoImproved sticky callouts with anchors visual test
Colin Marshall [Mon, 25 Apr 2016 18:05:13 +0000 (12:05 -0600)] 
Improved sticky callouts with anchors visual test

9 years agoMerge branch 'develop' of https://github.com/zurb/foundation-sites into breakpoint... 8600/head
jk [Sun, 24 Apr 2016 20:37:12 +0000 (22:37 +0200)] 
Merge branch 'develop' of https://github.com/zurb/foundation-sites into breakpoint-lint

9 years agoModified gulp to watch for changes to html files in docs/assets/partials directory
Colin Marshall [Sun, 24 Apr 2016 02:58:00 +0000 (20:58 -0600)] 
Modified gulp to watch for changes to html files in docs/assets/partials directory

9 years agoAdded sticky visual test with anchors and callouts
Colin Marshall [Sun, 24 Apr 2016 02:55:23 +0000 (20:55 -0600)] 
Added sticky visual test with anchors and callouts

9 years agofixes #8643 8657/head
jk [Fri, 22 Apr 2016 20:58:41 +0000 (22:58 +0200)] 
fixes #8643
do not reset val of radio and checkbox on reset the form reset prop checked false instead
maybe a saving of the initial markup state of radio checked and checkbox checked would be great

9 years agoMerge pull request #8634 from designerno1/drilldown-docs-fix
Andy Cochran [Fri, 22 Apr 2016 15:20:38 +0000 (11:20 -0400)] 
Merge pull request #8634 from designerno1/drilldown-docs-fix

Drilldown fixes a typo and adds fires open desc

9 years agoprevent hover/focus effects on disabled buttons 8650/head
Andy Cochran [Thu, 21 Apr 2016 19:16:54 +0000 (15:16 -0400)] 
prevent hover/focus effects on disabled buttons

9 years agoAppended "color: $accordion-content-color;" declaration in accordion-content mixin 8646/head
Nordanne Isahac [Thu, 21 Apr 2016 11:20:46 +0000 (19:20 +0800)] 
Appended "color: $accordion-content-color;" declaration in accordion-content mixin

9 years agoMerge pull request #8635 from sethkane/issue-7904
Marius Olbertz [Thu, 21 Apr 2016 05:51:11 +0000 (07:51 +0200)] 
Merge pull request #8635 from sethkane/issue-7904

Issue 7904

9 years agoRemoving non needed aria from the body tag 8635/head
sethk [Wed, 20 Apr 2016 21:08:31 +0000 (16:08 -0500)] 
Removing non needed aria from the body tag

9 years agofixes #8624 call stop on destroy 8642/head
jk [Wed, 20 Apr 2016 19:27:36 +0000 (21:27 +0200)] 
fixes #8624 call stop on destroy

9 years agoRemoved automated aria-labelledby features as they aren't needed to ensure accessibility
sethk [Tue, 19 Apr 2016 21:19:30 +0000 (16:19 -0500)] 
Removed automated aria-labelledby features as they aren't needed to ensure accessibility
Added documentation to explain how to utilize aria-labelledby

9 years agofixes a typo and adds fires open desc 8634/head
jk [Tue, 19 Apr 2016 20:02:53 +0000 (22:02 +0200)] 
fixes a typo and adds fires open desc

9 years agoMerge pull request #8614 from andycochran/media-object-margin-bottom
Kevin Ball [Mon, 18 Apr 2016 23:17:30 +0000 (16:17 -0700)] 
Merge pull request #8614 from andycochran/media-object-margin-bottom

remove margin bottom from :last-child of .media-object-section

9 years agoregisterPlugin unregisterPlugin spelling typo 8626/head
Kristofer Krause [Mon, 18 Apr 2016 20:56:26 +0000 (16:56 -0400)] 
registerPlugin unregisterPlugin spelling typo

9 years agofix margin-bottom on buttons (don't use border)
Andy Cochran [Fri, 15 Apr 2016 18:35:02 +0000 (14:35 -0400)] 
fix margin-bottom on buttons (don't use border)

9 years agoremove margin bottom from :last-child of .media-object-section 8614/head
Andy Cochran [Fri, 15 Apr 2016 17:03:59 +0000 (13:03 -0400)] 
remove margin bottom from :last-child of .media-object-section

9 years agoMerge pull request #8610 from zurb/brettsmason-drilldown-visual-test
Brett Mason [Fri, 15 Apr 2016 11:20:59 +0000 (12:20 +0100)] 
Merge pull request #8610 from zurb/brettsmason-drilldown-visual-test

Create drilldown-menu-parent-link visual test

9 years agoCreate drilldown-menu-parent-link.html 8610/head
Brett Mason [Fri, 15 Apr 2016 11:09:50 +0000 (12:09 +0100)] 
Create drilldown-menu-parent-link.html

Added a visual test to check the parent link option for drilldown menus.
Added to support [8595](https://github.com/zurb/foundation-sites/pull/8595).

9 years agoMerge pull request #8595 from designerno1/fix-drilldown-parentlink
Brett Mason [Fri, 15 Apr 2016 11:07:00 +0000 (12:07 +0100)] 
Merge pull request #8595 from designerno1/fix-drilldown-parentlink

should fix #8593

9 years agoMerge pull request #8608 from colin-marshall/customizer-menu-icon
Colin Marshall [Fri, 15 Apr 2016 03:32:24 +0000 (21:32 -0600)] 
Merge pull request #8608 from colin-marshall/customizer-menu-icon

Added missing menu-icon component to customizer config

9 years agoAdded missing menu-icon component to customizer config 8608/head
Colin Marshall [Fri, 15 Apr 2016 02:51:33 +0000 (20:51 -0600)] 
Added missing menu-icon component to customizer config

9 years agoMerge pull request #8564 from Owlbertz/dropdown-menu-fixes
Kevin Ball [Fri, 15 Apr 2016 00:17:28 +0000 (17:17 -0700)] 
Merge pull request #8564 from Owlbertz/dropdown-menu-fixes

Dropdown menu fixes

9 years agoMerge pull request #8571 from Owlbertz/keyboard-enhancements
Kevin Ball [Fri, 15 Apr 2016 00:09:27 +0000 (17:09 -0700)] 
Merge pull request #8571 from Owlbertz/keyboard-enhancements

Enhance keyboard util.

9 years agoMerge branch 'issue-7904' of https://github.com/sethkane/foundation-sites into issue...
sethk [Thu, 14 Apr 2016 14:50:46 +0000 (08:50 -0600)] 
Merge branch 'issue-7904' of https://github.com/sethkane/foundation-sites into issue-7904

# Conflicts:
# js/foundation.reveal.js

9 years agoIssue #7904 should be addressed by updating various ARIA related issues.
sethk [Thu, 14 Apr 2016 14:01:57 +0000 (08:01 -0600)] 
Issue #7904 should be addressed by updating various ARIA related issues.

Removed aria-hidden on both the body and the overlay. Since the modals are children of both of those anything that has an aria-hidden=true will be ignored by the screen reader. This is why with a keyboard you can tab around int he modal but when you use a screen reader and you tab around you can't access the content within the modal.

I also enhanced the aria-labeledby by checking to see if the modal has a H Tag (H1,2,3,4,5,6) of sorts. If it finds a H Tag the first one found will be associated to the aria-labeledby and thus will result with that text announced to the a screen reader after opening a modal. if there is no header it will utilize the element (href, button, etc...) that opened the modal and associated itself to the aria-labeledby and thus will result with that text announced to the a screen reader after opening a modal.