There were two instances where the wrong case was used in the "Off-canvas Position" section of the documentation. Instead of "Split" the example had "SPlit" which would still work, but is unclean. It is also an official Off-canvas example, so it could be spreading through test code for people learning Foundation and lead to confusion. I simply made the "P" lowercase on lines 140 and 146. I quoted the code below.
Before Fix line 140:
<button type="button" class="button" data-toggle="offCanvasLeftSPlit1">Open Left</button>
Before Fix 146:
<div class="off-canvas-absolute position-left" id="offCanvasLeftSPlit1" data-off-canvas>
Marius Olbertz [Thu, 12 Jan 2017 16:37:19 +0000 (17:37 +0100)]
Fixed ESC button on drilldown menus.
Previously, _back was being called without a parameter which is both a wrong ca$
ESC is now using _hide and will place focus on the anchor that was used to open$
TBD: If hideAll should be called so all sub menus are closed using ESC.
Nicolas Coden [Sun, 25 Dec 2016 22:30:43 +0000 (23:30 +0100)]
Fix nested collapsed flex-grid row
Bug: columns in collapsed row doesn't have padding, but nested
collapsed flex-grid row still have negative margins.
Fix: apply the same path than in classic grids.
Note: Grids and flex-grids have a lot of bugs like this one and should
be refactorized. Please beat me if you see this commit 6 months later
and nothing changed.
Nicolas Coden [Sun, 25 Dec 2016 22:26:47 +0000 (23:26 +0100)]
Fix size of row nested inside collapsed (flex-)grid row.
See: https://github.com/zurb/foundation-sites/issues/9557
Problem: Every row has a max width, so when nested, it cannot be
enlarged with negative margins to handle the paddings of its columns.
Fix: expand the size of all row nested in a non-expanded row.
Note: THIS IS A TEMPORARY FIX. Grids and flex-grids have a lot of bugs
like this one and should be refactorized. Please beat me if you see
this commit 6 months later and nothing changed.
Problem: `@example` values are presented as default in the
documentation, and there is no way to get the default value
automatically. Plus, the "example" value is often not relevant at all.
> The reference section at the bottom is mostly meant to be a reference
> —key plugin options should be documented in the main body of the
> documentation, where there's more room to elaborate on things.
> -- @gakimball
Fix:
- Use `@default` instead of `@example`
- Make values in comment equal to the options default values
Warning: This require to update the value used to generate Js reference
in foundation-docs.
Replaced values:
Tooltip:
- `templateClasses`: `'my-cool-tip-class'` replaced to `''`
- `template`: `'<div class="tooltip"></div>'` replaced to
`''`
- `tip` text: `'Some cool space fact here.'` replaced to `''`
- `positionClass`: `'top'` replaced to `''`
Sticky:
- `container`: `'<div data-sticky-container class="small-6
columns"></div>'` replaced to `'<div
data-sticky-container></div>'`
- `anchor`: `'exampleId'` replaced to `''`
- `topAnchor`: `'exampleId:top'` replaced to `''`
- `btmAchor`: `'exampleId:bottom'` replaced to `''`
- `checkEvery`: `50` replaced to `-1`
Reveal:
- `animationIn`: `'slide-in-left'` replaced to `''`
- `animationOut`: `'slide-in-left'` replaced to `''`
- `showDelay`: `10` replaced to `0`
- `hideDelay`: `10` replaced to `0`
- `appendTo`: `false` replaced to `"body"`
Offcanvas:
- `transitionTime`: `500` replaced to `0`
- `forceTo`: `top` replaced to `null`
- `revealOn`: `reveal-for-large` replaced to `null`
- `revealClass`: `reveal-for` replaced to `reveal-for-`
- `trapFocus`: `false` replaced to `false`
Magelian:
- `animationEasing`: `'ease-in-out'` replaced to `linear`
- `deepLinking`: `true` replaced to `false`
- `barOffset`: `25` replaced to `0`
Equalizer:
- `equalizeOnStack`: `true` replaced to `false`
- `equalizeOn`: `'medium'` replaced to `''`
Dropdown:
- `parentClass`: `'dropdown-parent'` replaced to `null`
- `hoverPane`: `true` replaced to `false`
- `positionClass`: `'top'` replaced by `''`
- `autoFocus`: `true` replaced by `false`
Drilldrow:
- `backButton`: `'<\li><\a>Back<\/a><\/li>'` replaced by `'<li
class="js-drilldown-back"><a tabindex="0">Back</a></li>'
- `backButtonPosition`: `bottom` replaced by `top`
- `wrapper`: `<\div class="is-drilldown"><\/div>` replaced by
`'<div></div>'`
- `scrollTopOffset`: `100` replaced by `0
Don't listen to touchend events on dropdown element leafs.
The delay on touch devices between the click and touchend event
was preventing the link navigation, as browser security policies
don't allow link navigation on hidden elements.
projects / thirdparty / foundation / foundation-sites.git / log
