Darren Nickerson [Tue, 11 Nov 2003 04:17:16 +0000 (04:17 +0000)]
[Bug 468] format string vulnerability in hfaxd
See http://bugs.hylafax.org/bugzilla/show_bug.cgi?id=468
This patch fixes one serious format string issue, and tidies up three
other harmless ones for the sake of consistency.
Thanks to SuSE Security Team for the careful hfaxd code audit that
uncovered this vulnerability, and for working with us prior to the
public announcement to evaluate and certify their proposed fix.
[Bug 445] Ancient faxes get re-sent, and to the wrong people!!!
Thanks to iFAX Solutions for tracking down one of the most serious and
long-standing bugs I've ever been unfortunate enough to see happen to an
important production system. Because of blocking issues, HylaFAX was
orphaning original documents, and re-faxing them months (or years) later.
This patch removes the unnecessary blocking in cases where faxq already
has the framework to handle children properly, and prevents this situation
from ever arising.
[Bug 367] getty_ps and mgetty not suitable for incoming data connect
Prefer 'agetty' over 'getty'; note requirements for getty in documentation;
note restrictions of particular getty packages.
Thanks to Glenn Burkhardt for this submission, and for his patience as
we sought to reach a "rough concensus" ;-) -d
Lee Howard [Fri, 29 Aug 2003 22:05:33 +0000 (22:05 +0000)]
Bug 435 : Kevin Fleming correctly reports that, although tiffcheck has code to support MMR it does rejects the
command-line option. This patch fixes that oversight.
Darren Nickerson [Sun, 20 Jul 2003 22:33:47 +0000 (22:33 +0000)]
Recording 4.1.7 changes here. There won't be a CVS tag for this release
since it's only one patch, but it makes sense to update these two files
so that history reflects the release of a 4.1.7 ;-) -d
Lee Howard [Fri, 18 Jul 2003 21:53:29 +0000 (21:53 +0000)]
Bug 415: enhancement to make HylaFAX send an NSF frame in Class 1. Includes a small fix to received NSF reporting and
adds a few additional NSF stamps.
Lee Howard [Tue, 8 Jul 2003 21:32:45 +0000 (21:32 +0000)]
Bug 299. FaxSend was initializing the modem twice before dialing. This removes the second instance and will
trim sending session logs a bit and should help fax broadcasters considerably.
Darren Nickerson [Mon, 30 Jun 2003 04:51:45 +0000 (04:51 +0000)]
[Bug 267] Fix gcc warnings in -Wall mode
We broke page chopping in 4.1.6. This patch repairs the damage by making
MaxPageLength stay consistently cast as u_short. Thanks to Lee and Aidan
for getting to the bottom of this one!
Darren Nickerson [Mon, 16 Jun 2003 21:05:47 +0000 (21:05 +0000)]
[Bug 389] superfine, hyperfine, etc. resolution support
This is a very large and involved patch. Please see the included documentation
with regards to what it does and how it does it. Essentially it changes an
info entry from SupportsHighRes (boolean) to SupportsVR (integer), allows a
modem to receive all resolutions for which it is capable (all of them in Class
1), allows a user to send in extended resolutions using the JPARM USEXRES or
'sendfax -G' option (if the modem and remote supports it).
Darren Nickerson [Tue, 10 Jun 2003 03:46:44 +0000 (03:46 +0000)]
[Bug 413] faxq may not format based on modem capabilities
Extend the original fix to faxmodem, to allow faxmodem to provide valid
capabilities string to faxq. Thanks Lee!
Darren Nickerson [Fri, 16 May 2003 02:15:45 +0000 (02:15 +0000)]
[Bug 250] externalizePhoneNumber cannot be controlled server-side
Backing out this change due to security concerns with the approach as it
was contributed. Thanks to Patrice for catching this one.
Tim Rice [Tue, 6 May 2003 18:05:03 +0000 (18:05 +0000)]
Remove duplicate promptForNonNullStringParameter shell function added
by mistake.
Use promptForBooleanParameter() for changing $HFAXD_OLD_PROTOCOL, etc.
[Bug 413] faxq may not format based on modem capabilities
This fix from Lee corrects a problem, introduced when V.34 support was added,
that would result in HylaFAX scheduling (for instance) MR formatted documents
to modems that were only capable of MH. We were increasing BR_ALL ad DF_ALL
without adjusting Class2Parms::encodeCaps() and decodeCaps(). Thanks Lee!
Tim Rice [Sat, 19 Apr 2003 16:23:51 +0000 (16:23 +0000)]
Fix precedence.
"../faxd/Class20.c++", line 148: warning: == expression as operand for &
"../faxd/Class2Send.c++", line 367: warning: == expression as operand for &
Tim Rice [Fri, 18 Apr 2003 21:03:40 +0000 (21:03 +0000)]
Cast strtol to int to get rid of warnings.
"../src/faxd/ClassModem.c++", line 1092: warning: long assigned to int
"../src/faxd/ClassModem.c++", line 1118: warning: long assigned to int