]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
15 years agoimapc: Don't send broken FETCH command when we don't actually have to fetch anything.
Timo Sirainen [Thu, 20 Jan 2011 20:44:53 +0000 (22:44 +0200)] 
imapc: Don't send broken FETCH command when we don't actually have to fetch anything.

15 years agolib-storage: mailbox_alloc() now takes a virtual mailbox name and other related API...
Timo Sirainen [Thu, 20 Jan 2011 18:59:07 +0000 (20:59 +0200)] 
lib-storage: mailbox_alloc() now takes a virtual mailbox name and other related API changes.
All storage_name <-> vname conversions now go through the same two
mailbox_list methods. This has many benefits, such as:

 * listescape plugin is now much simpler and bugfree
 * allows changing lib-storage API to use UTF-8 mailbox names in future
 * allows creation of "mailbox aliases" plugin

15 years agolib-storage: Added mailbox_get_last_*error() wrappers and use them.
Timo Sirainen [Thu, 20 Jan 2011 17:21:20 +0000 (19:21 +0200)] 
lib-storage: Added mailbox_get_last_*error() wrappers and use them.

15 years agolib-storage: Crashfix on trying to create index root dir.
Timo Sirainen [Thu, 20 Jan 2011 16:17:22 +0000 (18:17 +0200)] 
lib-storage: Crashfix on trying to create index root dir.

15 years agolib-storage: Replaced mailbox_list_get_name_status() with mailbox_exists().
Timo Sirainen [Thu, 20 Jan 2011 16:14:53 +0000 (18:14 +0200)] 
lib-storage: Replaced mailbox_list_get_name_status() with mailbox_exists().

15 years agolmtp: Write "+ext" part to Delivered-To: header.
Pascal Volk [Wed, 19 Jan 2011 20:06:39 +0000 (20:06 +0000)] 
lmtp: Write "+ext" part to Delivered-To: header.
(reverted changeset 19231e3585db)

15 years agoimapc: Fixed authenticating with AUTHENTICATE command without SASL-IR.
Timo Sirainen [Tue, 18 Jan 2011 23:21:03 +0000 (01:21 +0200)] 
imapc: Fixed authenticating with AUTHENTICATE command without SASL-IR.

15 years agoimapc: Fixed sending non-syncing literals.
Timo Sirainen [Tue, 18 Jan 2011 23:20:48 +0000 (01:20 +0200)] 
imapc: Fixed sending non-syncing literals.

15 years agoauth: Logging improvement for nopassword=y.
Timo Sirainen [Tue, 18 Jan 2011 22:25:47 +0000 (00:25 +0200)] 
auth: Logging improvement for nopassword=y.

15 years agolib-index: Avoid corrupting dovecot.index file when recreating it even in case of...
Timo Sirainen [Mon, 17 Jan 2011 19:25:01 +0000 (21:25 +0200)] 
lib-index: Avoid corrupting dovecot.index file when recreating it even in case of broken file locking.

15 years agoauth: Fixed mech_winbind_ntlm by using mech_winbind_auth_initial()
Christian Wiese [Sun, 16 Jan 2011 19:47:15 +0000 (21:47 +0200)] 
auth: Fixed mech_winbind_ntlm by using mech_winbind_auth_initial()
In changeset 9002 a new function named mech_winbind_auth_initial() was
introduced, but only the mech_winbind_spnego module part was changed to finally
use this function.
The mech_winbind_ntlm module part was not properly adapted which leads to a non
functioning NTLM authentication mechanism while using winbind, because it will
never call the `ntlm_auth` helper.

The simple fix is to replace mech_generic_auth_initial() with
mech_winbind_auth_initial() as auth_initial "hook" when setting up the
mech_winbind_ntlm module, like it is done in the mech_winbind_spnego module.

References:

- Changeset 9002: http://hg.dovecot.org/dovecot-2.0/diff/9d0037a997f4/src/auth/mech-winbind.c
---
 src/auth/mech-winbind.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

15 years agoman: Updated dsync.1's -o parameter description.
Timo Sirainen [Sun, 16 Jan 2011 19:26:13 +0000 (21:26 +0200)] 
man: Updated dsync.1's -o parameter description.

15 years agoman: Added -o parameter to dovecot-lda.1
Timo Sirainen [Sun, 16 Jan 2011 19:25:34 +0000 (21:25 +0200)] 
man: Added -o parameter to dovecot-lda.1

15 years agomkdir_*chown/chgrp(): If chown() fails, rmdir() the directory.
Timo Sirainen [Sun, 16 Jan 2011 19:15:10 +0000 (21:15 +0200)] 
mkdir_*chown/chgrp(): If chown() fails, rmdir() the directory.

15 years agodsync: Fixed crash when mailbox had zero cache_fields but its array was initialized.
Timo Sirainen [Sun, 16 Jan 2011 16:53:27 +0000 (18:53 +0200)] 
dsync: Fixed crash when mailbox had zero cache_fields but its array was initialized.

15 years agoAdded initial implementation of "imapc" storage.
Timo Sirainen [Sun, 16 Jan 2011 16:08:23 +0000 (18:08 +0200)] 
Added initial implementation of "imapc" storage.
It can be used to create a "smart IMAP proxy" where Dovecot uses remote IMAP
server as a mail storage.

This is a very rough early implementation. Performance isn't good, many
required features are missing, error handling is lacking and code needs
de-uglification. Still, it should be enough for selecting INBOX and
accessing mails in it.

15 years agoAdded signature for changeset 440fcf8cb338
Timo Sirainen [Thu, 13 Jan 2011 11:18:20 +0000 (13:18 +0200)] 
Added signature for changeset 440fcf8cb338

15 years agoAdded tag 2.0.9 for changeset 440fcf8cb338
Timo Sirainen [Thu, 13 Jan 2011 11:18:17 +0000 (13:18 +0200)] 
Added tag 2.0.9 for changeset 440fcf8cb338

15 years agoReleased v2.0.9. 2.0.9
Timo Sirainen [Thu, 13 Jan 2011 11:18:17 +0000 (13:18 +0200)] 
Released v2.0.9.

15 years agoTODO updated
Timo Sirainen [Thu, 13 Jan 2011 11:08:40 +0000 (13:08 +0200)] 
TODO updated

15 years agoAdded io_loop_move_io() and io_loop_move_timeout().
Timo Sirainen [Thu, 13 Jan 2011 11:08:21 +0000 (13:08 +0200)] 
Added io_loop_move_io() and io_loop_move_timeout().

15 years agocydir: Minor fix.
Timo Sirainen [Thu, 13 Jan 2011 11:08:02 +0000 (13:08 +0200)] 
cydir: Minor fix.

15 years agoi_stream_read(): Added extra assert.
Timo Sirainen [Sun, 9 Jan 2011 21:39:00 +0000 (23:39 +0200)] 
i_stream_read(): Added extra assert.

15 years agoistream-seekable: Minor code cleanup.
Timo Sirainen [Sun, 9 Jan 2011 21:38:49 +0000 (23:38 +0200)] 
istream-seekable: Minor code cleanup.

15 years agoauth: Don't give an error if doing a passdb lookup and the result has NULL password.
Timo Sirainen [Sun, 9 Jan 2011 20:01:36 +0000 (22:01 +0200)] 
auth: Don't give an error if doing a passdb lookup and the result has NULL password.

15 years agopgsql: When executing synchronous queries, don't wrongly add a connect timeout.
Timo Sirainen [Sun, 9 Jan 2011 19:37:24 +0000 (21:37 +0200)] 
pgsql: When executing synchronous queries, don't wrongly add a connect timeout.

15 years agocydir: Minor code fix.
Timo Sirainen [Sun, 9 Jan 2011 19:13:31 +0000 (21:13 +0200)] 
cydir: Minor code fix.

15 years agoistream-seekable: Minor code cleanup.
Timo Sirainen [Sat, 8 Jan 2011 19:03:15 +0000 (21:03 +0200)] 
istream-seekable: Minor code cleanup.

15 years agodsync: Don't crash if message can't be saved to destination mailbox.
Timo Sirainen [Wed, 5 Jan 2011 18:21:38 +0000 (20:21 +0200)] 
dsync: Don't crash if message can't be saved to destination mailbox.

15 years agomdbox: Don't leave partially written messages to mdbox files.
Timo Sirainen [Wed, 5 Jan 2011 16:47:40 +0000 (18:47 +0200)] 
mdbox: Don't leave partially written messages to mdbox files.

15 years agodsync: Fixed iterating through mailboxes when using proxy.
Timo Sirainen [Wed, 5 Jan 2011 16:11:04 +0000 (18:11 +0200)] 
dsync: Fixed iterating through mailboxes when using proxy.
This fixes "Unexpected reply from server: +" errors.

15 years agoconfig: Give clear error that auth settings aren't supported inside local/remote...
Timo Sirainen [Tue, 4 Jan 2011 11:57:33 +0000 (13:57 +0200)] 
config: Give clear error that auth settings aren't supported inside local/remote blocks.

15 years agologin: ssl_require_client_cert and ssl_username_from_cert settings should have had...
Timo Sirainen [Tue, 4 Jan 2011 11:53:17 +0000 (13:53 +0200)] 
login: ssl_require_client_cert and ssl_username_from_cert settings should have had auth_ prefix.
The actual functionality was provided by the auth_* settings, but with these
duplicated settings login process didn't give as good error messages.

15 years agoauth: Minor code cleanup, use PASSWORD_HIDDEN_STR macro.
Timo Sirainen [Tue, 4 Jan 2011 11:22:20 +0000 (13:22 +0200)] 
auth: Minor code cleanup, use PASSWORD_HIDDEN_STR macro.

15 years agomaildir: Fixed renaming child mailboxes when using a namespace prefix.
Timo Sirainen [Tue, 4 Jan 2011 11:17:57 +0000 (13:17 +0200)] 
maildir: Fixed renaming child mailboxes when using a namespace prefix.

15 years agomaildir: Getting mailbox GUID unnecessarily rewrote the uidlist.
Timo Sirainen [Tue, 4 Jan 2011 10:34:48 +0000 (12:34 +0200)] 
maildir: Getting mailbox GUID unnecessarily rewrote the uidlist.

15 years agoIDLE was listed twice in capabilities.
Timo Sirainen [Tue, 4 Jan 2011 10:14:02 +0000 (12:14 +0200)] 
IDLE was listed twice in capabilities.

15 years agodsync: Saved messages' save-date was set to 1970-01-01.
Timo Sirainen [Tue, 4 Jan 2011 10:04:42 +0000 (12:04 +0200)] 
dsync: Saved messages' save-date was set to 1970-01-01.

15 years agovirtual: Fixed saving multiple mails in a transaction (e.g. copy multiple messages).
Timo Sirainen [Tue, 4 Jan 2011 09:55:36 +0000 (11:55 +0200)] 
virtual: Fixed saving multiple mails in a transaction (e.g. copy multiple messages).

15 years agolib-sql: Include Dovecot version number check when loading SQL plugins.
Timo Sirainen [Tue, 4 Jan 2011 09:44:07 +0000 (11:44 +0200)] 
lib-sql: Include Dovecot version number check when loading SQL plugins.

15 years agolib-lda: Simplified mail_deliver_deduplicate_guid_if_needed() API.
Timo Sirainen [Mon, 3 Jan 2011 17:06:49 +0000 (19:06 +0200)] 
lib-lda: Simplified mail_deliver_deduplicate_guid_if_needed() API.

15 years agolib-storage: Added mailbox_save_get_transaction().
Timo Sirainen [Mon, 3 Jan 2011 17:06:02 +0000 (19:06 +0200)] 
lib-storage: Added mailbox_save_get_transaction().

15 years agolmtp: If delivering duplicate messages to same user's INBOX, use different GUIDs.
Timo Sirainen [Mon, 3 Jan 2011 16:59:07 +0000 (18:59 +0200)] 
lmtp: If delivering duplicate messages to same user's INBOX, use different GUIDs.
This is to avoid POP3 clients getting confused with duplicate UIDLs, when
using GUIDs as UIDLs.

15 years agodbox: If mail GUID is changed for copied mail, create a new copy of it so it changes.
Timo Sirainen [Mon, 3 Jan 2011 16:57:05 +0000 (18:57 +0200)] 
dbox: If mail GUID is changed for copied mail, create a new copy of it so it changes.

15 years agoconfigure: Added a note that this is the UNSTABLE branch.
Timo Sirainen [Sat, 1 Jan 2011 14:00:01 +0000 (16:00 +0200)] 
configure: Added a note that this is the UNSTABLE branch.

15 years agoMerged fixes from v2.0 tree.
Timo Sirainen [Sat, 1 Jan 2011 13:59:02 +0000 (15:59 +0200)] 
Merged fixes from v2.0 tree.

15 years agoTODO updated.
Timo Sirainen [Sat, 1 Jan 2011 13:56:37 +0000 (15:56 +0200)] 
TODO updated.

15 years agolib-storage: Moved some items from mailbox_get_status() to a new mailbox_get_metadata().
Timo Sirainen [Sat, 1 Jan 2011 13:52:39 +0000 (15:52 +0200)] 
lib-storage: Moved some items from mailbox_get_status() to a new mailbox_get_metadata().
The idea is now that all status items are tracked all the time after mailbox
is opened and they can always be looked up without failure. The metadata
items are looked up lazily and the lookups may fail at any time.

mailbox_get_status() can be used after mailbox_alloc() to indicate that the
mailbox doesn't necessarily have to be opened, just that the status fields
get returned.

If mailbox is already known to be open, mailbox_get_open_status() can be
used. It never fails.

15 years agolib-storage: Added warning comments about mail_get_*header*utf8().
Timo Sirainen [Sat, 1 Jan 2011 12:34:14 +0000 (14:34 +0200)] 
lib-storage: Added warning comments about mail_get_*header*utf8().

15 years agolib-storage: Don't double-demimefy headers when DISPLAYFROM/DISPLAYTO sorting.
Timo Sirainen [Sat, 1 Jan 2011 11:27:16 +0000 (13:27 +0200)] 
lib-storage: Don't double-demimefy headers when DISPLAYFROM/DISPLAYTO sorting.

15 years agolib-storage: Fixed deleting symlinked mailbox.
Timo Sirainen [Thu, 30 Dec 2010 11:45:11 +0000 (13:45 +0200)] 
lib-storage: Fixed deleting symlinked mailbox.

15 years agounlink_directory(): Return ELOOP for unexpected symlinks also when O_NOFOLLOW isn...
Timo Sirainen [Thu, 30 Dec 2010 11:41:10 +0000 (13:41 +0200)] 
unlink_directory(): Return ELOOP for unexpected symlinks also when O_NOFOLLOW isn't supported.

15 years agodoveadm quota: Don't crash if quota isn't enabled.
Timo Sirainen [Thu, 30 Dec 2010 10:45:52 +0000 (12:45 +0200)] 
doveadm quota: Don't crash if quota isn't enabled.

15 years agodoveadm: Fixed mailbox-guid search key to work with shared/public mailboxes.
Timo Sirainen [Thu, 30 Dec 2010 10:40:50 +0000 (12:40 +0200)] 
doveadm: Fixed mailbox-guid search key to work with shared/public mailboxes.

15 years agovpopmail: "Service disabled" check wasn't being done correctly.
Timo Sirainen [Thu, 30 Dec 2010 10:04:30 +0000 (12:04 +0200)] 
vpopmail: "Service disabled" check wasn't being done correctly.

15 years agodoveadm user: If user isn't found, exit with status 2.
Timo Sirainen [Thu, 30 Dec 2010 09:51:59 +0000 (11:51 +0200)] 
doveadm user: If user isn't found, exit with status 2.

15 years agolib-storage: mailbox_get_status() can now fail.
Timo Sirainen [Wed, 29 Dec 2010 09:43:01 +0000 (11:43 +0200)] 
lib-storage: mailbox_get_status() can now fail.
It might have failed earlier also, but the errors were hidden from caller.

15 years agolib-storage: Crashfix for opening sdbox/mdbox mailbox.
Timo Sirainen [Wed, 29 Dec 2010 09:39:32 +0000 (11:39 +0200)] 
lib-storage: Crashfix for opening sdbox/mdbox mailbox.

15 years agolda: Removed optimization of not creating temp files for large mails when not using...
Timo Sirainen [Fri, 17 Dec 2010 13:23:07 +0000 (13:23 +0000)] 
lda: Removed optimization of not creating temp files for large mails when not using Sieve.
The backwards seeking was still needed if bouncing the mail because of
out of quota.

15 years agosnarf: Make sure destination mailbox is open when syncing it.
Timo Sirainen [Fri, 17 Dec 2010 13:16:01 +0000 (13:16 +0000)] 
snarf: Make sure destination mailbox is open when syncing it.

15 years agomaster-child API change: Use a separate fd for tracking when master dies.
Timo Sirainen [Wed, 15 Dec 2010 17:07:01 +0000 (17:07 +0000)] 
master-child API change: Use a separate fd for tracking when master dies.
This works around a Linux performance problem where when one process writes
to status fd all the other processes of the same service type wake up.

15 years agonet_listen(): If IPv6 isn't supported, don't fallback to IPv4 if my_ip is given.
Timo Sirainen [Mon, 13 Dec 2010 13:40:27 +0000 (13:40 +0000)] 
net_listen(): If IPv6 isn't supported, don't fallback to IPv4 if my_ip is given.

15 years agoquota: Quota warnings could have been executed at incorrect times with some configs.
Timo Sirainen [Mon, 13 Dec 2010 13:27:18 +0000 (13:27 +0000)] 
quota: Quota warnings could have been executed at incorrect times with some configs.
If target mailbox had quota ignored, the warning was sent if the mail would
have otherwise exceeded the warning threshold. Same when using multiple
quota roots where all of the roots weren't used for the target mailbox.

15 years agoimap: Fixed a memory leak in ESEARCH
Timo Sirainen [Thu, 9 Dec 2010 20:49:53 +0000 (20:49 +0000)] 
imap: Fixed a memory leak in ESEARCH

15 years agolib-storage: Added assert check to make sure we never do timeout_add(0)
Timo Sirainen [Thu, 9 Dec 2010 11:16:24 +0000 (11:16 +0000)] 
lib-storage: Added assert check to make sure we never do timeout_add(0)

15 years agoacl: Crashfix at deinit in some configurations.
Timo Sirainen [Wed, 8 Dec 2010 23:17:11 +0000 (23:17 +0000)] 
acl: Crashfix at deinit in some configurations.

15 years agoauth: Master user login + prefetch userdb changed username to master user.
Timo Sirainen [Tue, 7 Dec 2010 02:00:45 +0000 (02:00 +0000)] 
auth: Master user login + prefetch userdb changed username to master user.

15 years agoauth: Checkpassword's output fields are now logged with auth_debug=yes
Timo Sirainen [Tue, 7 Dec 2010 01:50:43 +0000 (01:50 +0000)] 
auth: Checkpassword's output fields are now logged with auth_debug=yes

15 years agoauth: When logging in as anonymous user, return "anonymous" userdb extra field.
Timo Sirainen [Mon, 6 Dec 2010 04:36:30 +0000 (04:36 +0000)] 
auth: When logging in as anonymous user, return "anonymous" userdb extra field.

15 years agoauth: When logging in as anonymous user, return "anonymous" userdb extra field.
Timo Sirainen [Mon, 6 Dec 2010 04:36:30 +0000 (04:36 +0000)] 
auth: When logging in as anonymous user, return "anonymous" userdb extra field.

15 years agoTODO updated.
Timo Sirainen [Mon, 6 Dec 2010 04:00:26 +0000 (04:00 +0000)] 
TODO updated.

15 years agolib-storage: Moved mailbox.save_is_attachment() to mail_save_context.part_is_attachment()
Timo Sirainen [Mon, 6 Dec 2010 03:58:17 +0000 (03:58 +0000)] 
lib-storage: Moved mailbox.save_is_attachment() to mail_save_context.part_is_attachment()

15 years agolib-storage: Unvirtualized mailbox_header_lookup_*()
Timo Sirainen [Mon, 6 Dec 2010 03:53:30 +0000 (03:53 +0000)] 
lib-storage: Unvirtualized mailbox_header_lookup_*()

15 years agolib-storage: Unvirtualized some methods from struct mailbox.
Timo Sirainen [Mon, 6 Dec 2010 03:43:23 +0000 (03:43 +0000)] 
lib-storage: Unvirtualized some methods from struct mailbox.
There was never any point in overriding or hooking into them.

15 years agolib-storage: Added missing mailbox-keywords.c for recent commit.
Timo Sirainen [Mon, 6 Dec 2010 03:41:31 +0000 (03:41 +0000)] 
lib-storage: Added missing mailbox-keywords.c for recent commit.

15 years agofts: Added missing new files for last commit.
Timo Sirainen [Mon, 6 Dec 2010 03:40:41 +0000 (03:40 +0000)] 
fts: Added missing new files for last commit.

15 years agoMoved fts/virtual plugin communication functions away from lib-storage.
Timo Sirainen [Mon, 6 Dec 2010 03:28:29 +0000 (03:28 +0000)] 
Moved fts/virtual plugin communication functions away from lib-storage.

15 years agolib-lda: duplicate_check() should return bool, not int.
Timo Sirainen [Mon, 6 Dec 2010 03:11:08 +0000 (03:11 +0000)] 
lib-lda: duplicate_check() should return bool, not int.

15 years agolib-storage: Added mailbox_list_get_root_[dir_]permissions()
Timo Sirainen [Mon, 6 Dec 2010 03:08:31 +0000 (03:08 +0000)] 
lib-storage: Added mailbox_list_get_root_[dir_]permissions()
They should be used instead of mailbox_list_get_[dir_]permissions() with
name=NULL parameter.

15 years agolib-storage: Simplified mailbox_keyword*() APIs.
Timo Sirainen [Mon, 6 Dec 2010 02:16:22 +0000 (02:16 +0000)] 
lib-storage: Simplified mailbox_keyword*() APIs.
They are no longer struct mailbox methods, because they're always implemented
as being wrappers to lib-index APIs anyway.

Also mailbox_keywords_ref/unref() no longer take mailbox parameter.

15 years agolib-storage: Removed mailbox.backend_readonly. Backends set it internally lazily...
Timo Sirainen [Mon, 6 Dec 2010 01:47:50 +0000 (01:47 +0000)] 
lib-storage: Removed mailbox.backend_readonly. Backends set it internally lazily now.

15 years agomaildir: Avoid harder to unnecessarily read uidlist when syncing mailbox.
Timo Sirainen [Mon, 6 Dec 2010 01:27:11 +0000 (01:27 +0000)] 
maildir: Avoid harder to unnecessarily read uidlist when syncing mailbox.

15 years agomaildir: Avoid harder to unnecessarily read uidlist when syncing mailbox.
Timo Sirainen [Mon, 6 Dec 2010 01:27:03 +0000 (01:27 +0000)] 
maildir: Avoid harder to unnecessarily read uidlist when syncing mailbox.

15 years agomaildir: Avoid unnecessarily reading uidlist when opening mailbox.
Timo Sirainen [Mon, 6 Dec 2010 01:20:14 +0000 (01:20 +0000)] 
maildir: Avoid unnecessarily reading uidlist when opening mailbox.

15 years agomaildir: Avoid unnecessarily reading uidlist when opening mailbox.
Timo Sirainen [Mon, 6 Dec 2010 01:19:25 +0000 (01:19 +0000)] 
maildir: Avoid unnecessarily reading uidlist when opening mailbox.

15 years agolib-storage: Moved box->private_flags_mask to mailbox_get_private_flags_mask()
Timo Sirainen [Mon, 6 Dec 2010 01:11:07 +0000 (01:11 +0000)] 
lib-storage: Moved box->private_flags_mask to mailbox_get_private_flags_mask()
This allows getting it lazily only when it's actually needed.

15 years agolib-storage: Removed subscription name validity check from lib-storage after all.
Timo Sirainen [Mon, 6 Dec 2010 00:52:42 +0000 (00:52 +0000)] 
lib-storage: Removed subscription name validity check from lib-storage after all.
It could have broken when subscriptions were being set for subscriptions=no
namespace.

15 years agolib-storage: Mailbox directory creation didn't properly enforce that the name was...
Timo Sirainen [Mon, 6 Dec 2010 00:43:28 +0000 (00:43 +0000)] 
lib-storage: Mailbox directory creation didn't properly enforce that the name was valid.
The name was checked against "valid existing name" rather than "valid create
name", which mainly meant that the name could have contained control characters
and other things that weren't really intended. This couldn't be used to
cause any security holes though.

15 years agoacl: Make the mailbox visible only when it has l/r/i right.
Timo Sirainen [Mon, 6 Dec 2010 00:42:42 +0000 (00:42 +0000)] 
acl: Make the mailbox visible only when it has l/r/i right.
This change only affects the ability to SUBSCRIBE to a mailbox. Previously
it was allowed when user had any rights at all to mailbox.

15 years agolib-storage: Removed unused mailbox_list_get_mailbox_name_status() status codes.
Timo Sirainen [Mon, 6 Dec 2010 00:37:20 +0000 (00:37 +0000)] 
lib-storage: Removed unused mailbox_list_get_mailbox_name_status() status codes.

15 years agoimap-acl, imap-quota: Compile fix for last change.
Timo Sirainen [Mon, 6 Dec 2010 00:37:09 +0000 (00:37 +0000)] 
imap-acl, imap-quota: Compile fix for last change.

15 years agoimap: Avoid using mailbox_list_get_mailbox_name_status()
Timo Sirainen [Mon, 6 Dec 2010 00:30:36 +0000 (00:30 +0000)] 
imap: Avoid using mailbox_list_get_mailbox_name_status()
The validity checks should already be done by the actual commands in most
cases (if they didn't, there would be race condition bugs). The only
exception is SUBSCRIBE. It doesn't require that the mailbox exists, but
we want to enforce that anyway via IMAP.

15 years agolib-storage: Don't allow subscribing to invalid mailbox names.
Timo Sirainen [Mon, 6 Dec 2010 00:14:25 +0000 (00:14 +0000)] 
lib-storage: Don't allow subscribing to invalid mailbox names.

15 years agolib-storage: Mailbox directory creation didn't properly enforce that the name was...
Timo Sirainen [Mon, 6 Dec 2010 00:13:28 +0000 (00:13 +0000)] 
lib-storage: Mailbox directory creation didn't properly enforce that the name was valid.
The name was checked against "valid existing name" rather than "valid create
name", which mainly meant that the name could have contained control characters
and other things that weren't really intended. This couldn't be used to
cause any security holes though.

15 years agoRemoved unused BITS_IN_UINT and CLAMP macros.
Timo Sirainen [Sun, 5 Dec 2010 23:53:47 +0000 (23:53 +0000)] 
Removed unused BITS_IN_UINT and CLAMP macros.

15 years agoUnexpand BITS_IN_SIZE_T in the only place it's used and remove the macro.
Timo Sirainen [Sun, 5 Dec 2010 23:53:25 +0000 (23:53 +0000)] 
Unexpand BITS_IN_SIZE_T in the only place it's used and remove the macro.

15 years agoMoved a global NVL() macro to the few places in lib-imap where it was actually used.
Timo Sirainen [Sun, 5 Dec 2010 23:52:37 +0000 (23:52 +0000)] 
Moved a global NVL() macro to the few places in lib-imap where it was actually used.

15 years agolib-storage: Fixed error handling when trying to delete mailbox under noinferiors...
Timo Sirainen [Sun, 5 Dec 2010 23:48:34 +0000 (23:48 +0000)] 
lib-storage: Fixed error handling when trying to delete mailbox under noinferiors mailbox.

15 years agolib-storage: Don't allocate index until mailbox_open()
Timo Sirainen [Sun, 5 Dec 2010 23:44:38 +0000 (23:44 +0000)] 
lib-storage: Don't allocate index until mailbox_open()

15 years agolib-storage: Lazily look up mailbox path and permissions. Added functions to get...
Timo Sirainen [Sun, 5 Dec 2010 23:18:55 +0000 (23:18 +0000)] 
lib-storage: Lazily look up mailbox path and permissions. Added functions to get them.