]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Stephan Bosch [Tue, 28 Nov 2023 20:54:30 +0000 (21:54 +0100)]
lib-json: json-parser - Fix stream read size calculations in JSON string istream
Stephan Bosch [Tue, 28 Nov 2023 20:59:36 +0000 (21:59 +0100)]
lib-json: json-parser - Rename local variable in json_string_istream_read()
Also restructure its use a bit to make its function more clear.
Stephan Bosch [Sun, 22 Oct 2023 23:26:08 +0000 (01:26 +0200)]
auth: auth-request - Remove auth_request_log_*()
Stephan Bosch [Sun, 22 Oct 2023 23:32:37 +0000 (01:32 +0200)]
auth: auth-request - Log about passdb skipping on main request event
Stephan Bosch [Sun, 22 Oct 2023 22:10:23 +0000 (00:10 +0200)]
auth: auth-request - Add auth_request_db_log_unknown_user() and use it
Stephan Bosch [Sun, 22 Oct 2023 22:22:25 +0000 (00:22 +0200)]
auth: auth-request - Add auth_request_db_log_password_mismatch() and use it
Stephan Bosch [Mon, 23 Oct 2023 00:03:02 +0000 (02:03 +0200)]
auth: auth-request - Add auth_request_db_log_login_failure() and use it
Stephan Bosch [Sun, 22 Oct 2023 23:13:11 +0000 (01:13 +0200)]
auth: auth-request - Add auth_request_db_password_verify*() and use them
Stephan Bosch [Sun, 22 Oct 2023 22:49:53 +0000 (00:49 +0200)]
auth: auth-request - Use event directly with auth_request_password_verify*()
Stephan Bosch [Mon, 23 Oct 2023 00:25:33 +0000 (02:25 +0200)]
auth: auth-request - Use event directly with auth_request_log_unknown_user()
Drop subsystem parameter. Caller is now providing the event.
Stephan Bosch [Sun, 22 Oct 2023 22:30:59 +0000 (00:30 +0200)]
auth: auth-request - Use event directly with auth_request_log_password_mismatch()
Drop subsystem parameter. Caller is now providing the event.
Stephan Bosch [Sun, 22 Oct 2023 22:02:36 +0000 (00:02 +0200)]
auth: auth-request - Use event directly with auth_request_log_login_failure()
Drop subsystem parameter. Caller is now providing the event.
Stephan Bosch [Sun, 22 Oct 2023 21:55:46 +0000 (23:55 +0200)]
auth: auth-request - Use event directly with log_password_failure()
Drop subsystem parameter. Caller is now providing the event.
Stephan Bosch [Sun, 22 Oct 2023 19:27:27 +0000 (21:27 +0200)]
auth: db-password-file - Replace auth_request_log_info() with e_info()
This also fixes the log prefix.
Stephan Bosch [Sun, 22 Oct 2023 19:25:14 +0000 (21:25 +0200)]
auth: auth-master-connection - Replace auth_request_log_info() with e_info()
This also fixes the log prefix.
Stephan Bosch [Sun, 22 Oct 2023 19:21:24 +0000 (21:21 +0200)]
auth: auth-master-connection - Replace auth_request_log_error() with e_error()
This also fixes the log prefix.
Stephan Bosch [Sun, 22 Oct 2023 19:13:29 +0000 (21:13 +0200)]
auth: passdb-sql - auth: mech-digest-md5 - Replace auth_request_log_error() with e_error()
Stephan Bosch [Thu, 5 Oct 2023 23:45:19 +0000 (01:45 +0200)]
auth: mech-digest-md5 - Replace auth_request_log_info() with e_info()
Stephan Bosch [Tue, 7 Mar 2023 03:22:25 +0000 (04:22 +0100)]
auth: mech-digest-md5 - Add local variables for struct auth_request
Stephan Bosch [Fri, 3 Nov 2023 19:46:24 +0000 (20:46 +0100)]
auth: auth-request - Add request ID to the event log prefix for worker requests
Stephan Bosch [Tue, 24 Oct 2023 12:07:04 +0000 (14:07 +0200)]
auth: auth-request - Add SASL state to the event log prefix
Stephan Bosch [Sun, 22 Oct 2023 21:16:22 +0000 (23:16 +0200)]
auth: auth-request - Move most of the log prefix to the main request event
This way, any request-related logging will have a prefix with all the necessary
information. Before, the main request event had no prefix and when no sub-event
was available no prefix was added to log lines, meaning that the request these
related to could not be determined. Sub-events will now have a smaller
additional prefix that relates to the subsystem alone.
Stephan Bosch [Sun, 22 Oct 2023 20:55:34 +0000 (22:55 +0200)]
auth: auth-request - Move get_log_identifier()
Stephan Bosch [Wed, 25 Oct 2023 00:58:26 +0000 (02:58 +0200)]
auth: test-mech - Run the test as a master service
Stephan Bosch [Thu, 2 Nov 2023 12:32:27 +0000 (13:32 +0100)]
auth: test-auth - Run the test as a master service
Stephan Bosch [Tue, 7 Mar 2023 03:38:56 +0000 (04:38 +0100)]
auth: Reformat mech-digest-md5.c
Stephan Bosch [Sun, 19 Nov 2023 22:07:25 +0000 (23:07 +0100)]
lib-master: master-service - Improve comment for master_service_set_killed_callback()
Timo Sirainen [Tue, 28 Nov 2023 21:01:44 +0000 (23:01 +0200)]
indexer: Remove unused worker-pool.c
Forgotten in
093b312e13700ca18a1a8b8c16480ef86565fb84
Marco Bettini [Thu, 23 Nov 2023 13:26:47 +0000 (13:26 +0000)]
fts-solr: Drop solr_old
Stephan Bosch [Fri, 24 Nov 2023 18:48:50 +0000 (19:48 +0100)]
lib-json: test-json-generator - Fix test to reach the last state
Stephan Bosch [Fri, 24 Nov 2023 18:37:41 +0000 (19:37 +0100)]
auth: auth-policy - Fix request JSON success field
It was always emitted as success = true.
Broken by
a953dbf8cce1285a27b321eb28ad83f55c083d4f .
Stephan Bosch [Fri, 24 Nov 2023 18:15:40 +0000 (19:15 +0100)]
lib-json: json-istream - Clear and dereference stream tree fields early upon error
Stephan Bosch [Fri, 24 Nov 2023 17:59:54 +0000 (18:59 +0100)]
lib-json: json-types - Rename value-get functions for consistency
Stephan Bosch [Fri, 24 Nov 2023 17:56:44 +0000 (18:56 +0100)]
lib-json: json-types - Remove stray definition
Stephan Bosch [Wed, 22 Nov 2023 00:54:53 +0000 (01:54 +0100)]
lib-json: test-json-io - Add tests for json_text_format*()
Stephan Bosch [Tue, 21 Nov 2023 18:03:36 +0000 (19:03 +0100)]
lib-json: json-ostream - Make sure ostream_r is initialized by json_ostream_open_string_stream()
Stephan Bosch [Tue, 21 Nov 2023 17:52:17 +0000 (18:52 +0100)]
lib-json: json-ostream - Fix error handling of json_ostream_write_tree()
Stephan Bosch [Tue, 21 Nov 2023 18:49:01 +0000 (19:49 +0100)]
lib-json: json-parser - Fix dead assignment in json_parser_continue()
Stephan Bosch [Tue, 21 Nov 2023 17:32:55 +0000 (18:32 +0100)]
lib-json: json-parser - Remove dead assignment in json_string_istream_read()
Stephan Bosch [Tue, 21 Nov 2023 18:48:05 +0000 (19:48 +0100)]
lib-json: json-generator - Fix dead assignment in json_generate_string_write_data()
Stephan Bosch [Tue, 21 Nov 2023 18:49:44 +0000 (19:49 +0100)]
lib-json: test-json-istream - Make string input stream tests robust to failure
Stephan Bosch [Tue, 21 Nov 2023 18:09:26 +0000 (19:09 +0100)]
lib-json: test-json-istream - Fix read result assertion in test_json_istream_error()
Stephan Bosch [Tue, 21 Nov 2023 17:28:19 +0000 (18:28 +0100)]
lib-json: test-json-istream - Fix assertion of read results
Stephan Bosch [Tue, 21 Nov 2023 17:37:20 +0000 (18:37 +0100)]
lib-json: test-json-generator - Remove dead assignment in test_json_generate_stream()
Stephan Bosch [Tue, 21 Nov 2023 17:22:28 +0000 (18:22 +0100)]
lib-json: test-json-generator - Fix return value assertions
Stephan Bosch [Tue, 21 Nov 2023 17:05:08 +0000 (18:05 +0100)]
lib-json: json-istream - Correctly handle NULL pointer for node_r in *_stream()
Stephan Bosch [Tue, 21 Nov 2023 13:01:43 +0000 (14:01 +0100)]
lib-json: json-tree - Make use of result from tree addition functions optional
Stephan Bosch [Tue, 21 Nov 2023 13:16:19 +0000 (14:16 +0100)]
lib-json: test-json-tree - Change code line breaks
Stephan Bosch [Tue, 21 Nov 2023 13:14:27 +0000 (14:14 +0100)]
lib-json: test-json-ostream - Change code line breaks
Stephan Bosch [Tue, 21 Nov 2023 13:08:38 +0000 (14:08 +0100)]
lib-json: test-json-tree - Fix dead assignments
Stephan Bosch [Tue, 21 Nov 2023 13:08:16 +0000 (14:08 +0100)]
lib-json: test-json-ostream - Fix dead assignments
Stephan Bosch [Tue, 21 Nov 2023 12:42:29 +0000 (13:42 +0100)]
lib-json: test-json-istream - Fix string stream error assertions
Stephan Bosch [Tue, 21 Nov 2023 12:41:10 +0000 (13:41 +0100)]
lib-json: json-format - Fix error handling
Stephan Bosch [Mon, 20 Nov 2023 21:40:43 +0000 (22:40 +0100)]
lib-json: Fix comments in json-types.h
Aki Tuomi [Mon, 18 Sep 2023 10:42:25 +0000 (13:42 +0300)]
doveadm: doveadm-fs - Support setting metadata in put
Aki Tuomi [Mon, 18 Sep 2023 10:42:02 +0000 (13:42 +0300)]
lib-fs: metawrap - Indicate metadata support
Forgotten in
c59b9c273b41f7bcf51f6803110b67813879ff05
Aki Tuomi [Mon, 18 Sep 2023 10:39:45 +0000 (13:39 +0300)]
fs-crypt: Limit minimum buffer size to 1k
Otherwise we might not get enough data to decrypt
the stream.
Aki Tuomi [Mon, 18 Sep 2023 10:38:50 +0000 (13:38 +0300)]
fs-compress: Limit minimum buffer size to 1k
Otherwise we might not get enough data to decompress
the stream.
Markus Valentin [Wed, 2 Aug 2023 15:07:34 +0000 (17:07 +0200)]
lib-storage: Rebuild list-index using MAILBOX_LIST_ITER_FORCE_RESYNC
In case the list index file was just created use
MAILBOX_LIST_ITER_FORCE_RESYNC to rediscover mailboxes that might have
been hidden.
Markus Valentin [Mon, 6 Nov 2023 10:50:11 +0000 (11:50 +0100)]
lib-storage: fs_list_entry() - Do not list MAILBOX_NOINFERIORS for index iterations
The index directory is only expected to contain child directories for
mailboxes. Any files in there shouldn't be listed.
Markus Valentin [Mon, 30 Oct 2023 13:52:49 +0000 (14:52 +0100)]
lib-storage: fs_list_entry() - Do not delete \Noselect leaf mailboxes with force-resync
Markus Valentin [Mon, 11 Sep 2023 06:58:00 +0000 (08:58 +0200)]
lib-storage: Allow rediscovering lost mailboxes when using ITERINDEX and LAYOUT=fs
This is meant to prevent losing mailboxes if the index directory of a
mailbox got lost. A force-resync allows to rediscover and recreate
missing directories.
Markus Valentin [Wed, 2 Aug 2023 14:58:48 +0000 (16:58 +0200)]
doveadm: cmd_force_resync_run() - Add MAILBOX_LIST_ITER_RAW_LIST
This flag makes sure existing indexes are ignored when running a
force-resync.
Markus Valentin [Mon, 11 Sep 2023 07:52:58 +0000 (09:52 +0200)]
lib-storage: Make mailbox_mkdir() public
Markus Valentin [Mon, 11 Sep 2023 06:55:29 +0000 (08:55 +0200)]
lib-storage: Set iter_from_index_dir directly on mailbox_list_iterate_context
Marco Bettini [Mon, 30 Oct 2023 16:29:13 +0000 (16:29 +0000)]
imap: Suppress permission errors when getmetadata mailbox has wildcards
When one of the mailboxes matching the wildcard has ACL permissions "l"
(only lookup, with no extra rights supporting it), it causes a PERM error
that is propagated as either untagged or last tagged response. This fix
allows to skip the offending folders rather report errors in the response.
Marco Bettini [Mon, 6 Nov 2023 11:29:47 +0000 (11:29 +0000)]
imap: Send NONEXISTENT unconditionally
The response code will always be emitted rather than checkng
for COMMAND_FLAG_USE_NONEXISTENT. Despite what RFC 5530 states,
this behavior is useful for the other commands as well, and it
also is required for imapc GETMETADATA to work properly.
Marco Bettini [Thu, 2 Nov 2023 13:06:16 +0000 (13:06 +0000)]
imapc: Implement remote getmetadata and setmetadata
Marco Bettini [Thu, 2 Nov 2023 11:02:57 +0000 (11:02 +0000)]
imapc: Add no-metadata feature
Markus Valentin [Thu, 23 Nov 2023 10:00:02 +0000 (11:00 +0100)]
lib-master: stats_client_deinit() - Unref output ostream
Markus Valentin [Thu, 23 Nov 2023 09:59:29 +0000 (10:59 +0100)]
lib-master: stats_client_init_unittest() - Set no error handling for ostream
Timo Sirainen [Tue, 21 Nov 2023 12:38:57 +0000 (14:38 +0200)]
lib-master: Add asserts to make sure error string is set
Fixes scan-build complaint.
Timo Sirainen [Tue, 21 Nov 2023 12:38:41 +0000 (14:38 +0200)]
lib-master: Fix error handling if config fd wasn't received
Timo Sirainen [Tue, 21 Nov 2023 12:34:41 +0000 (14:34 +0200)]
config: Fix potential crash with unknown settings
Timo Sirainen [Tue, 21 Nov 2023 12:32:00 +0000 (14:32 +0200)]
config: Remove dead code
Timo Sirainen [Wed, 22 Nov 2023 08:41:47 +0000 (10:41 +0200)]
config: Add data stack frame when dumping filters
Timo Sirainen [Wed, 22 Nov 2023 08:41:29 +0000 (10:41 +0200)]
lib-settings: settings_*get*() - Add data stack frame
Markus Valentin [Tue, 21 Nov 2023 10:25:35 +0000 (11:25 +0100)]
lib-master: stats_client_wait() - Distinguish between handshake and deinit
stats_client_wait() is used to wait for the handshake response as well
as waiting for the stats flushing on stats_client_deinit(). Previously
the stats_client_deinit() could easily have timed out.
This adds a specific error message for the deinit timeout as well as a
bigger timeout (30 seconds).
Timo Sirainen [Mon, 5 Jun 2023 21:07:10 +0000 (00:07 +0300)]
config: Optimize away config exporter creation when it has nothing to export
Timo Sirainen [Wed, 31 May 2023 09:31:48 +0000 (12:31 +0300)]
lib-settings: test-settings-parser - Test that invalid setting values aren't accepted
Timo Sirainen [Tue, 23 May 2023 14:49:44 +0000 (17:49 +0300)]
lib-settings, global: Skip processing unnecessary service { .. } filter blocks
Only the master process needs service blocks for other services.
We can save a lot of memory by not creating event filters for them.
Timo Sirainen [Wed, 24 May 2023 10:25:41 +0000 (13:25 +0300)]
lib: event_filter_merge*() - Fix merging filters with IP fields
Timo Sirainen [Tue, 23 May 2023 14:48:33 +0000 (17:48 +0300)]
lib: event_filter_merge*() - Fix merging filters without explicit event check
Timo Sirainen [Wed, 24 May 2023 09:03:07 +0000 (12:03 +0300)]
lib-master: Don't send unnamed events to stats
This wasn't actually happening currently, but the following
event_filter_merge() fix would have changed it.
However, test-event-stats unit test wasn't using event_filter_merge(), so it
was testing unnamed events. Changed the test to use named events intead.
Timo Sirainen [Fri, 26 May 2023 10:11:34 +0000 (13:11 +0300)]
lib-master: test-event-stats - Simplify communication with stats-client
Modify stats-client to support writing to an ostream. This way
test-event-stats doesn't need to fork and emulate a server process.
This should fix some random failures with this test.
Note that the END numbers change because server_connection_connected event
is no longer sent.
Timo Sirainen [Wed, 24 May 2023 09:03:48 +0000 (12:03 +0300)]
stats: Fix crash if exporting an unnamed event
This can't actually happen, because currently unnamed events aren't being
sent to stats.
Timo Sirainen [Tue, 23 May 2023 13:33:27 +0000 (16:33 +0300)]
lib: event_filter_find_field_exact() - Add op_not_r parameter
Timo Sirainen [Tue, 23 May 2023 10:50:28 +0000 (13:50 +0300)]
lib: event-filters - Change event_fields.value from struct to union
This reduces memory usage.
Timo Sirainen [Tue, 23 May 2023 09:53:12 +0000 (12:53 +0300)]
lib: event-filters - Keep source_filename:linenum only in a string
The source filters aren't normally used, and their performance doesn't
matter much. This change will allow the following commit to change
event_field.value into a union.
Timo Sirainen [Tue, 23 May 2023 09:49:26 +0000 (12:49 +0300)]
lib: event-filters - Use union for event_filter_node's type-specific fields
This reduces memory usage.
Timo Sirainen [Tue, 23 May 2023 09:48:09 +0000 (12:48 +0300)]
lib: event filters - Fix matching source location filename
The comparisons always used the created event's source filename rather than
e.g. event_want_debug() function's source filename.
Timo Sirainen [Tue, 23 May 2023 10:09:22 +0000 (13:09 +0300)]
lib: event-filters - Fix filter merging for IP and STRLIST types
Timo Sirainen [Tue, 23 May 2023 09:38:07 +0000 (12:38 +0300)]
lib: event-filters - Remove separate str and intmax fields from event_filter_node
Use event_field.value's equivalent fields. This reduces memory usage.
Timo Sirainen [Tue, 23 May 2023 10:49:41 +0000 (13:49 +0300)]
lib: test-event-flatten - Clarify how strlist matching works
Also remove related dead code.
Timo Sirainen [Tue, 23 May 2023 09:17:10 +0000 (12:17 +0300)]
config, lib-settings: Avoid reading settings blocks' filters into memory
They are accessed directly from the mmaped memory now. This reduces
per-process memory usage.
Timo Sirainen [Tue, 23 May 2023 08:44:57 +0000 (11:44 +0300)]
lib-settings: Use event_filter_create_with_pool() for created filters
This way there is no wasted memory with each filter creating their own pool
and using only part of it.
Timo Sirainen [Tue, 23 May 2023 08:44:48 +0000 (11:44 +0300)]
lib: Add event_filter_create_with_pool()
Timo Sirainen [Mon, 22 May 2023 22:14:25 +0000 (01:14 +0300)]
config, lib-settings: Add config filter strings only once to binary config
Add them first globally and later on inside settings blocks refer to them
with their index number. This way lib-settings also can easily allocate the
event filters just once.
Timo Sirainen [Mon, 22 May 2023 21:22:15 +0000 (00:22 +0300)]
config, lib-settings: Use index numbers for setting keys in binary config
This allows directly finding the setting with the index number without
having to find it via the key string.
Timo Sirainen [Mon, 22 May 2023 20:21:44 +0000 (23:21 +0300)]
lib-settings: Add and use settings_mmap.pool