]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
22 months agolib-dcrypt: ctx_hmac_init() - Fix memory leak if MAC initialization failed
Timo Sirainen [Fri, 2 Aug 2024 11:15:23 +0000 (14:15 +0300)] 
lib-dcrypt: ctx_hmac_init() - Fix memory leak if MAC initialization failed

22 months agolib-dcrypt: ctx_hmac_init() - Fix memory allocation failure handling with OpenSSL3
Timo Sirainen [Fri, 2 Aug 2024 11:14:14 +0000 (14:14 +0300)] 
lib-dcrypt: ctx_hmac_init() - Fix memory allocation failure handling with OpenSSL3

22 months agoconfigure: Remove extra space from capabilities
Aki Tuomi [Fri, 2 Aug 2024 07:21:38 +0000 (10:21 +0300)] 
configure: Remove extra space from capabilities

Broken in 16218e44ace1af2952b5090a4e2bb26b9495ba94

22 months agolib-dcrypt: test-stream - Test multiple ciphers
Aki Tuomi [Wed, 31 Jul 2024 06:14:55 +0000 (09:14 +0300)] 
lib-dcrypt: test-stream - Test multiple ciphers

22 months agolib-dcrypt: Add OID for chacha20-poly1305 for OpenSSL1
Aki Tuomi [Wed, 31 Jul 2024 06:13:58 +0000 (09:13 +0300)] 
lib-dcrypt: Add OID for chacha20-poly1305 for OpenSSL1

22 months agolib-dcrypt: istream-decrypt - Read more if footer has not been fully read
Aki Tuomi [Wed, 31 Jul 2024 07:19:59 +0000 (10:19 +0300)] 
lib-dcrypt: istream-decrypt - Read more if footer has not been fully read

Fixes signal 11 crash caused by decrypt_size underflowing.

Broken in 316cbe323513a0f20d1cf519fe9405e231d633e2

23 months agolib: test-file-cache - build expected error strings using strerror
Duncan Overbruck [Mon, 18 Dec 2023 15:12:22 +0000 (16:12 +0100)] 
lib: test-file-cache - build expected error strings using strerror

Different libc libraries like musl and glibc have different error
strings for the same errno's, to make the tests work as expected
with musl libc, use strerror to build the expected error string.

23 months agoglobal: Move some settings back to non-hidden for core/CE
Michael M Slusarz [Wed, 17 Jul 2024 17:03:56 +0000 (11:03 -0600)] 
global: Move some settings back to non-hidden for core/CE

23 months agolib-master, config: Add a required dovecot_storage_version setting
Timo Sirainen [Wed, 19 Jun 2024 12:41:24 +0000 (15:41 +0300)] 
lib-master, config: Add a required dovecot_storage_version setting

This setting specifies specifies the oldest Dovecot version that must be
able to read the files written by this Dovecot. This setting replaces
separate settings that are added when file formats are changed.

The intention is that when upgrading Dovecot cluster, this setting is
first kept as the old Dovecot version. Once the cluster is fully upgraded
to a new version and there is no intention to rollback to the old version
anymore, this version number can be increased.

23 months agolib-master: Add version_is_valid() and version_cmp()
Timo Sirainen [Wed, 19 Jun 2024 12:40:46 +0000 (15:40 +0300)] 
lib-master: Add version_is_valid() and version_cmp()

23 months agoconfig: doveconf - Change is_config_binary() to return TRUE
Timo Sirainen [Wed, 19 Jun 2024 19:13:25 +0000 (22:13 +0300)] 
config: doveconf - Change is_config_binary() to return TRUE

Previously only the "config" binary returned TRUE, while doveconf didn't.
The intention was always for both to return TRUE, since it's an alternative
runtime check for CONFIG_BINARY macro.

23 months agodoc/example-config: Add dovecot_config_version setting to dovecot.conf
Timo Sirainen [Wed, 19 Jun 2024 19:37:59 +0000 (22:37 +0300)] 
doc/example-config: Add dovecot_config_version setting to dovecot.conf

23 months agoconfig: doveconf - Output dovecot_config_version setting
Timo Sirainen [Wed, 19 Jun 2024 09:32:07 +0000 (12:32 +0300)] 
config: doveconf - Output dovecot_config_version setting

It is not currently output for e.g. "doveconf -d"

23 months agoconfig: Add a required dovecot_config_version setting
Timo Sirainen [Wed, 19 Jun 2024 08:24:49 +0000 (11:24 +0300)] 
config: Add a required dovecot_config_version setting

This version must now be the first setting in the configuration file.
This is just the minimal version to allow supporting backwards
compatibility better in later versions.

23 months agomaster: --build-options: Print "pro" for Pro build
Timo Sirainen [Wed, 19 Jun 2024 08:49:53 +0000 (11:49 +0300)] 
master: --build-options: Print "pro" for Pro build

23 months agoquota: Remove support for setting quota limits via dict
Timo Sirainen [Wed, 12 Jun 2024 11:01:35 +0000 (14:01 +0300)] 
quota: Remove support for setting quota limits via dict

23 months agoimap-quota: Remove support for SETQUOTA
Timo Sirainen [Wed, 12 Jun 2024 10:59:49 +0000 (13:59 +0300)] 
imap-quota: Remove support for SETQUOTA

It always now just returns "No permission".

23 months agoquota: Add quota_mailbox_count setting
Timo Sirainen [Fri, 7 Jun 2024 10:23:17 +0000 (13:23 +0300)] 
quota: Add quota_mailbox_count setting

23 months agolib-storage: Add mailbox_list_get_count()
Timo Sirainen [Fri, 7 Jun 2024 10:12:35 +0000 (13:12 +0300)] 
lib-storage: Add mailbox_list_get_count()

23 months agolib: test-ostream-multiplex - Free output2 as well
Aki Tuomi [Mon, 1 Jul 2024 19:04:25 +0000 (22:04 +0300)] 
lib: test-ostream-multiplex - Free output2 as well

23 months agolib: ostream-multiplex - Fix sign mismatch
Aki Tuomi [Mon, 1 Jul 2024 19:04:05 +0000 (22:04 +0300)] 
lib: ostream-multiplex - Fix sign mismatch

23 months agosettings: Mark various settings as advanced
Michael M Slusarz [Tue, 25 Jun 2024 22:59:16 +0000 (16:59 -0600)] 
settings: Mark various settings as advanced

23 months agoglobal: Try shutdown connections before closing
Aki Tuomi [Tue, 4 Jun 2024 08:05:47 +0000 (11:05 +0300)] 
global: Try shutdown connections before closing

This is to avoid closing connections uncleanly.

23 months agologin-common: Set correct disconnect reason if TLS handshake failed
Aki Tuomi [Tue, 4 Jun 2024 08:05:25 +0000 (11:05 +0300)] 
login-common: Set correct disconnect reason if TLS handshake failed

23 months agolib-ssl-iostream: Properly shutdown TLS connections
Aki Tuomi [Tue, 4 Jun 2024 08:04:55 +0000 (11:04 +0300)] 
lib-ssl-iostream: Properly shutdown TLS connections

23 months agolib-ssl-iostream: Do not overwrite last_error
Aki Tuomi [Mon, 20 May 2024 13:04:18 +0000 (16:04 +0300)] 
lib-ssl-iostream: Do not overwrite last_error

23 months agolib-ssl-iostream: Set correct alerts
Aki Tuomi [Tue, 14 May 2024 09:39:06 +0000 (12:39 +0300)] 
lib-ssl-iostream: Set correct alerts

23 months agolib-oauth2: Add grant_type=client_credentials method
Markus Valentin [Wed, 26 Jun 2024 11:26:26 +0000 (13:26 +0200)] 
lib-oauth2: Add grant_type=client_credentials method

23 months agolib-oauth2: oauth2_request_start() - Allow starting a request without input->token
Markus Valentin [Fri, 28 Jun 2024 10:21:21 +0000 (12:21 +0200)] 
lib-oauth2: oauth2_request_start() - Allow starting a request without input->token

This is needed for the client_credentials grant type as it does not pass
a token but a client_secret to authenticate.

23 months agodovecot-config: Add lib-oauth2 to LIBDOVECOT_INCLUDE
Markus Valentin [Wed, 26 Jun 2024 11:00:45 +0000 (13:00 +0200)] 
dovecot-config: Add lib-oauth2 to LIBDOVECOT_INCLUDE

23 months agolmtp: Add support for SMTPUTF8
Arnt Gulbrandsen [Mon, 12 Jun 2023 10:38:15 +0000 (12:38 +0200)] 
lmtp: Add support for SMTPUTF8

This is based on code from someone called 'vk'. It's incomplete (needs
RFC8265 support at least), but works for him/her.

23 months agosmtp: Add support for SMTPUTF8
Arnt Gulbrandsen [Tue, 22 Nov 2022 11:51:44 +0000 (12:51 +0100)] 
smtp: Add support for SMTPUTF8

This adds support for SMTPUTF8 (RFC 6531) to the LMTP and Submission
services. The Submission service advertises this extension only if its
upstream relay does, and takes some care to avoid a misunderstood error
message.

23 months agoimap: Add UTF8=ACCEPT capability (RFC 6855)
Arnt Gulbrandsen [Tue, 22 Nov 2022 11:38:14 +0000 (12:38 +0100)] 
imap: Add UTF8=ACCEPT capability (RFC 6855)

This adds the capability and accepts UTF8 quoted-strings.

The SEARCH command is changed as required by RFC 6855, section 3, final
paragraph. There are no changes to the searching, as 6855 only changes
changes the syntax.

This does not add any kind of downgrading. Before this change, Dovecot would
accept an APPEND of a message such as

   From: grå@grå.org
   Subject: grå
   ...

and would just-send-8 that to any IMAP clients. This change maintains that policy.

23 months agolib-mail: Make FETCH ENVELOPE and SEARCH work on the human-readable domains
Arnt Gulbrandsen [Fri, 1 Mar 2024 16:47:28 +0000 (17:47 +0100)] 
lib-mail: Make FETCH ENVELOPE and SEARCH work on the human-readable domains

This stores the unicode form of domains in all indexes, meaning that
searching uses and serverside parsing shows the human-readable form of all
addresses.

23 months agolib: Add punycode decoder
Aki Tuomi [Wed, 26 Jun 2024 19:44:32 +0000 (22:44 +0300)] 
lib: Add punycode decoder

23 months agodoc: Use stamp files to ensure man and html are downloaded once
Aki Tuomi [Fri, 28 Jun 2024 05:31:28 +0000 (08:31 +0300)] 
doc: Use stamp files to ensure man and html are downloaded once

23 months agodsync: Don't fail when metadata cannot be retrieved
Marco Bettini [Tue, 25 Jun 2024 16:01:16 +0000 (16:01 +0000)] 
dsync: Don't fail when metadata cannot be retrieved

This become necessary when imapc is accessing a backend with
no metadata capabilities as the attribute_get imap primitive
cannot reply OK when it cannot provide the requested metadata
entry (attribute_iter already iterated an emtpy set in this case).

23 months agodoc: Fix check for installed html
Aki Tuomi [Thu, 27 Jun 2024 09:44:46 +0000 (12:44 +0300)] 
doc: Fix check for installed html

23 months agoREADME: Add reference to RFC-9585
Marco Bettini [Tue, 25 Jun 2024 12:33:48 +0000 (12:33 +0000)] 
README: Add reference to RFC-9585

23 months agoREADME: Remove stray spaces
Marco Bettini [Wed, 26 Jun 2024 13:26:20 +0000 (13:26 +0000)] 
README: Remove stray spaces

23 months agodsync: Don't commit transaction after every mail on slave side
Timo Sirainen [Thu, 30 Mar 2023 09:26:52 +0000 (12:26 +0300)] 
dsync: Don't commit transaction after every mail on slave side

dsync_commit_msgs_interval setting worked only on the master side. On the
slave side it was always 0, which caused it to commit after every mail save.

Also, dsync_commit_msgs_interval should be handled independently on each
side. Master shouldn't send its dsync_commit_msgs_interval setting to the
slave side.

Broken by a76faea3eb26c4cd67886fbe02c604f74d54be8c

23 months agodoc: Get man page assets from version dependant location
Aki Tuomi [Tue, 25 Jun 2024 08:17:10 +0000 (11:17 +0300)] 
doc: Get man page assets from version dependant location

23 months agoquota: Add quota_mailbox_message_count setting
Timo Sirainen [Tue, 18 Jun 2024 09:30:28 +0000 (12:30 +0300)] 
quota: Add quota_mailbox_message_count setting

2 years agodoveadm compress: Add support for STARTTLS
Timo Sirainen [Mon, 20 May 2024 08:31:59 +0000 (11:31 +0300)] 
doveadm compress: Add support for STARTTLS

2 years agodoveadm compress: Refactor line reading
Timo Sirainen [Mon, 20 May 2024 07:57:39 +0000 (10:57 +0300)] 
doveadm compress: Refactor line reading

2 years agodoveadm compress: Move struct client earlier
Timo Sirainen [Mon, 20 May 2024 07:52:44 +0000 (10:52 +0300)] 
doveadm compress: Move struct client earlier

2 years agoimap: Add tagged reply to "Command finished" debug log line
Timo Sirainen [Thu, 16 May 2024 10:28:13 +0000 (13:28 +0300)] 
imap: Add tagged reply to "Command finished" debug log line

2 years agoimap: Don't send imap_command_finished event if command name wasn't parsed
Timo Sirainen [Thu, 16 May 2024 10:09:26 +0000 (13:09 +0300)] 
imap: Don't send imap_command_finished event if command name wasn't parsed

2 years agoimap: Don't reset "last command stats" if command name wasn't parsed
Timo Sirainen [Thu, 16 May 2024 10:08:31 +0000 (13:08 +0300)] 
imap: Don't reset "last command stats" if command name wasn't parsed

2 years agoimap: Support hibernation when COMPRESS is enabled via imap-login process
Timo Sirainen [Fri, 3 May 2024 09:40:23 +0000 (12:40 +0300)] 
imap: Support hibernation when COMPRESS is enabled via imap-login process

2 years agoimap, imap-login: Handle COMPRESS in imap-login process if possible
Timo Sirainen [Fri, 10 May 2024 10:51:01 +0000 (13:51 +0300)] 
imap, imap-login: Handle COMPRESS in imap-login process if possible

This is currently done only in the connecting Dovecot proxy's imap-login
process. If no proxying is used, the COMPRESS handling stays in the imap
process. (That could be changed with some extra work.)

2 years agologin-common: Add login_proxy_replace_client_iostream_pre/post()
Timo Sirainen [Tue, 14 May 2024 21:00:36 +0000 (00:00 +0300)] 
login-common: Add login_proxy_replace_client_iostream_pre/post()

2 years agologin-common: Add support for reading commands from multiplex side channel istream
Timo Sirainen [Fri, 3 May 2024 10:17:28 +0000 (13:17 +0300)] 
login-common: Add support for reading commands from multiplex side channel istream

2 years agologin-common: Add login_proxy_get_client_[io]stream()
Timo Sirainen [Tue, 14 May 2024 20:42:25 +0000 (23:42 +0300)] 
login-common: Add login_proxy_get_client_[io]stream()

2 years agologin-common, *-login: Rename login_proxy_get_[io]stream() to login_proxy_get_server_...
Timo Sirainen [Tue, 14 May 2024 20:39:59 +0000 (23:39 +0300)] 
login-common, *-login: Rename login_proxy_get_[io]stream() to login_proxy_get_server_[io]stream()

2 years agoimap: COMPRESS - Fail if client pipelines data without waiting for OK reply
Timo Sirainen [Fri, 3 May 2024 09:45:51 +0000 (12:45 +0300)] 
imap: COMPRESS - Fail if client pipelines data without waiting for OK reply

2 years agoimap, imap-hibernate: Preserve multiplex ostream while hibernating
Timo Sirainen [Fri, 3 May 2024 09:16:37 +0000 (12:16 +0300)] 
imap, imap-hibernate: Preserve multiplex ostream while hibernating

2 years agologin-common, imap: Allow imap process to handle multiplex ostream
Timo Sirainen [Mon, 8 Apr 2024 21:12:05 +0000 (00:12 +0300)] 
login-common, imap: Allow imap process to handle multiplex ostream

2 years agoimap: client_create*() - Change unhibernated boolean to enum flags
Timo Sirainen [Mon, 8 Apr 2024 21:06:34 +0000 (00:06 +0300)] 
imap: client_create*() - Change unhibernated boolean to enum flags

2 years agoimap-login: Support starting multiplex iostream using ID command
Timo Sirainen [Mon, 8 Apr 2024 20:08:00 +0000 (23:08 +0300)] 
imap-login: Support starting multiplex iostream using ID command

This is automatically attempted by IMAP proxying, as long as the destination
isn't untrusted.

2 years agologin-common: Add support for multiplex iostreams
Timo Sirainen [Mon, 8 Apr 2024 19:55:59 +0000 (22:55 +0300)] 
login-common: Add support for multiplex iostreams

This is an internal protocol between two trusted Dovecots.

2 years agolib: ostream-multiplex - Fix working with small buffer sizes
Timo Sirainen [Thu, 16 May 2024 12:35:54 +0000 (15:35 +0300)] 
lib: ostream-multiplex - Fix working with small buffer sizes

For example imap FETCH command sets buffer size to 0 to avoid growing the
ostream buffers. This broke ostream-multiplex, because it always needs to
buffer the data internally before sending it to parent stream. Fix this
by always keeping the internal buffer size at least IO_BLOCK_SIZE bytes.

2 years agolib: ostream-multiplex - Allow destroying with a different flush callback
Timo Sirainen [Thu, 25 Apr 2024 22:23:38 +0000 (01:23 +0300)] 
lib: ostream-multiplex - Allow destroying with a different flush callback

This is needed to fix a crash (after the changes in following commits):

 - login-proxy aborts multiplex ostream because both sides of the proxy
   want multiplexing.
 - login-proxy creates iostream-proxy, which sets ostream flush callback
 - proxy_input() had multiplex ostream still referenced, and now unrefs it
 - ostream-multiplex is destroyed with a different flush callback

2 years agolib: iostream-multiplex - Implement streaming format
Timo Sirainen [Wed, 3 Apr 2024 06:59:35 +0000 (09:59 +0300)] 
lib: iostream-multiplex - Implement streaming format

2 years agolib: ostream-multiplex - Use ostream_private.corked instead of duplicating it
Timo Sirainen [Thu, 25 Apr 2024 21:22:32 +0000 (00:22 +0300)] 
lib: ostream-multiplex - Use ostream_private.corked instead of duplicating it

This also fixes o_stream_is_corked() to work correctly.

2 years agolib: ostream-multiplex - Split off o_stream_multiplex_send_packet()
Timo Sirainen [Tue, 2 Apr 2024 11:17:42 +0000 (14:17 +0300)] 
lib: ostream-multiplex - Split off o_stream_multiplex_send_packet()

2 years agolib: ostream-multiplex - Make sure parent stream write errors are noticed early
Timo Sirainen [Tue, 2 Apr 2024 11:07:43 +0000 (14:07 +0300)] 
lib: ostream-multiplex - Make sure parent stream write errors are noticed early

2 years agolib: ostream-multiplex - Fix propagating parent stream error messages
Timo Sirainen [Tue, 2 Apr 2024 11:05:38 +0000 (14:05 +0300)] 
lib: ostream-multiplex - Fix propagating parent stream error messages

2 years agolib, global: o_stream_create_multiplex() - Add format parameter
Timo Sirainen [Tue, 2 Apr 2024 10:52:33 +0000 (13:52 +0300)] 
lib, global: o_stream_create_multiplex() - Add format parameter

2 years agolib: ostream-multiplex - Remove unused multiplex_ostream.remain
Timo Sirainen [Tue, 2 Apr 2024 10:51:12 +0000 (13:51 +0300)] 
lib: ostream-multiplex - Remove unused multiplex_ostream.remain

2 years agolib: ostream-multiplex - Remove unnecessary check
Timo Sirainen [Tue, 2 Apr 2024 11:10:00 +0000 (14:10 +0300)] 
lib: ostream-multiplex - Remove unnecessary check

It's already checked above to be >0.

2 years agolib: istream-multiplex - Split off i_stream_multiplex_add()
Timo Sirainen [Tue, 2 Apr 2024 09:53:38 +0000 (12:53 +0300)] 
lib: istream-multiplex - Split off i_stream_multiplex_add()

2 years agolib: istream-multiplex - Allow destroying stream without closing it
Timo Sirainen [Tue, 30 Apr 2024 11:17:09 +0000 (14:17 +0300)] 
lib: istream-multiplex - Allow destroying stream without closing it

2 years agolib: istream-multiplex - Fix propagating parent stream error messages
Timo Sirainen [Tue, 2 Apr 2024 08:51:14 +0000 (11:51 +0300)] 
lib: istream-multiplex - Fix propagating parent stream error messages

2 years agolib: istream-multiplex - Rename struct multiplex_istream.remain to packet_bytes_left
Timo Sirainen [Tue, 2 Apr 2024 08:20:57 +0000 (11:20 +0300)] 
lib: istream-multiplex - Rename struct multiplex_istream.remain to packet_bytes_left

2 years agolib: istream-multiplex - Rename struct multiplex_ichannel.pending_pos to pending_count
Timo Sirainen [Tue, 2 Apr 2024 08:18:50 +0000 (11:18 +0300)] 
lib: istream-multiplex - Rename struct multiplex_ichannel.pending_pos to pending_count

2 years agolib: iostream-pump - Call o_stream_finish() when input is finished
Timo Sirainen [Wed, 5 Jun 2024 11:06:57 +0000 (14:06 +0300)] 
lib: iostream-pump - Call o_stream_finish() when input is finished

This is required to cleanly finish ostreams that have "end of stream"
marker.

2 years agoREADME.md: Remove dead link to doc/documentation.txt
Martti Rannanjärvi [Wed, 12 Jun 2024 23:51:41 +0000 (02:51 +0300)] 
README.md: Remove dead link to doc/documentation.txt

2 years agolib-dns: Fix potential timeout leak
Timo Sirainen [Wed, 12 Jun 2024 12:06:38 +0000 (15:06 +0300)] 
lib-dns: Fix potential timeout leak

2 years agoREADME.md: Fix link to mailing lists
Martti Rannanjärvi [Sun, 9 Jun 2024 00:32:39 +0000 (03:32 +0300)] 
README.md: Fix link to mailing lists

2 years agolib: istream-seekable - Allow in-memory fallback only for up to 10 MB streams
Timo Sirainen [Mon, 3 Jun 2024 20:42:25 +0000 (23:42 +0300)] 
lib: istream-seekable - Allow in-memory fallback only for up to 10 MB streams

2 years agolib: istream-seekable - Improve logging after write() errors
Timo Sirainen [Mon, 3 Jun 2024 20:28:23 +0000 (23:28 +0300)] 
lib: istream-seekable - Improve logging after write() errors

Also don't silently handle out of disk space errors - log a warning instead.

2 years agolib: istream-seekable - Assert that write() won't return 0
Timo Sirainen [Mon, 3 Jun 2024 20:23:40 +0000 (23:23 +0300)] 
lib: istream-seekable - Assert that write() won't return 0

2 years agolib: istream-seekable - Fix moving stream to memory on write() failure
Timo Sirainen [Mon, 3 Jun 2024 20:05:22 +0000 (23:05 +0300)] 
lib: istream-seekable - Fix moving stream to memory on write() failure

Fixes:
Panic: file istream-seekable.c: line 238 (read_from_buffer): assertion failed: (*ret_r > 0)

2 years agodoveadm save: Fix potential assert-crash if saving failed
Timo Sirainen [Mon, 3 Jun 2024 19:46:51 +0000 (22:46 +0300)] 
doveadm save: Fix potential assert-crash if saving failed

The input stream may not have been fully read at failure time.

Fixes:
Panic: file doveadm-mail-save.c: line 91 (cmd_save_to_mailbox): assertion failed: (input->eof)

2 years agoimap: Remove unused includes from imap-settings.c
Aki Tuomi [Mon, 13 May 2024 06:39:18 +0000 (09:39 +0300)] 
imap: Remove unused includes from imap-settings.c

2 years agoimap: Enable imap hibernation in Dovecot Pro build
Aki Tuomi [Tue, 7 May 2024 05:53:04 +0000 (08:53 +0300)] 
imap: Enable imap hibernation in Dovecot Pro build

2 years agom4: Define DOVECOT_PRO_EDITION if pro build is enabled
Aki Tuomi [Tue, 4 Jun 2024 08:37:04 +0000 (11:37 +0300)] 
m4: Define DOVECOT_PRO_EDITION if pro build is enabled

2 years agolib-dns: Fix dns_lookup_abort(&NULL) to not crash
Timo Sirainen [Tue, 4 Jun 2024 08:16:01 +0000 (11:16 +0300)] 
lib-dns: Fix dns_lookup_abort(&NULL) to not crash

Broken by f9e7f71e48dd4fe2b9af23796022fc256db3866d

2 years agodict: Check that dict client provides username when using private dict keys
Timo Sirainen [Mon, 3 Jun 2024 22:04:12 +0000 (01:04 +0300)] 
dict: Check that dict client provides username when using private dict keys

Prevents assert-crashes later on.

2 years agoconfig: Fix potential crash when parsing invalid values for settings
Timo Sirainen [Mon, 3 Jun 2024 21:51:49 +0000 (00:51 +0300)] 
config: Fix potential crash when parsing invalid values for settings

2 years agoconfig: Add assert to avoid scan-build warning
Timo Sirainen [Mon, 3 Jun 2024 21:51:39 +0000 (00:51 +0300)] 
config: Add assert to avoid scan-build warning

2 years agoanvil: test-connect-limit - Add asserts to avoid scan-build warnings
Timo Sirainen [Mon, 3 Jun 2024 21:46:29 +0000 (00:46 +0300)] 
anvil: test-connect-limit - Add asserts to avoid scan-build warnings

2 years agolib-dns: Fix clearing dns requests list at disconnect
Timo Sirainen [Fri, 31 May 2024 12:16:52 +0000 (15:16 +0300)] 
lib-dns: Fix clearing dns requests list at disconnect

2 years agolib-dns: Move cache entry refreshing out of dns-client-cache
Timo Sirainen [Wed, 29 May 2024 06:23:31 +0000 (09:23 +0300)] 
lib-dns: Move cache entry refreshing out of dns-client-cache

2 years agolib-dns: Fix error handling if background dns refresh lookup fails
Timo Sirainen [Wed, 29 May 2024 06:07:33 +0000 (09:07 +0300)] 
lib-dns: Fix error handling if background dns refresh lookup fails

If we got disconnected from dns-client, the background dns refresh callback
was never called.

2 years agolib-dns: Fix error handling when disconnection aborts requests
Timo Sirainen [Wed, 29 May 2024 06:00:20 +0000 (09:00 +0300)] 
lib-dns: Fix error handling when disconnection aborts requests

2 years agolib-dns: Abort pending requests when disconnecting, even when not connected
Timo Sirainen [Wed, 29 May 2024 05:58:49 +0000 (08:58 +0300)] 
lib-dns: Abort pending requests when disconnecting, even when not connected

2 years agolib-dns: Remove lookup from linked list independently of freeing it
Timo Sirainen [Tue, 28 May 2024 23:05:44 +0000 (02:05 +0300)] 
lib-dns: Remove lookup from linked list independently of freeing it

This probably doesn't fix anything, but makes it clearer how it's intended
to work.

2 years agolib-dns: Disconnect from server on lookup timeout
Timo Sirainen [Tue, 28 May 2024 23:11:51 +0000 (02:11 +0300)] 
lib-dns: Disconnect from server on lookup timeout

Since the timeout removed the lookup from the responses linked list, any
following replies could become matched against a wrong lookup.