]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Markus Valentin [Thu, 24 Feb 2022 14:31:39 +0000 (15:31 +0100)]
imapc: Delay fetching state after untagged exists reply
Markus Valentin [Thu, 16 Dec 2021 08:11:55 +0000 (09:11 +0100)]
imapc: imapc_copy() - Make sure capabilities are known before copying
Markus Valentin [Thu, 11 Nov 2021 15:17:35 +0000 (16:17 +0100)]
imapc: Implement rollback for failed copies
Markus Valentin [Thu, 11 Nov 2021 17:31:54 +0000 (18:31 +0100)]
imapc: imapc_save_copyuid() deduplicate code
Markus Valentin [Thu, 11 Nov 2021 15:18:09 +0000 (16:18 +0100)]
imapc: Enable bulk copying if remote backend has UIDPLUS capability
Markus Valentin [Thu, 11 Nov 2021 13:52:54 +0000 (14:52 +0100)]
imapc: Implement bulk copying for imapc
Markus Valentin [Thu, 11 Nov 2021 15:10:53 +0000 (16:10 +0100)]
imapc: Extract imapc_copy_simple() from imapc_copy()
Keep the old one by one copying functionality as simple call. This will
be used if the remote backend does not have the UIDPLUS capability.
Markus Valentin [Wed, 12 Jan 2022 14:09:16 +0000 (15:09 +0100)]
lib-storage: index_save_context_free() - Add assertion on non-NULL ctx->dest_mail
Markus Valentin [Wed, 8 Dec 2021 16:17:56 +0000 (17:17 +0100)]
lib: Add seq-set-builder and tests for it
Timo Sirainen [Fri, 25 Feb 2022 20:48:10 +0000 (21:48 +0100)]
lib: json-parser - Fix detecting truncated JSON input
Based on patch by Dmitry Yakunin
Tom Sommer [Sat, 5 Sep 2020 10:55:46 +0000 (12:55 +0200)]
dovecot.service.in: Add remote-fs.target to systemd service
Christian Göttsche [Fri, 6 Aug 2021 16:08:51 +0000 (18:08 +0200)]
man: doveadm-director - drop acute accent
Found by Lintian:
This manual page uses the \' groff sequence. Usually, the intent to
generate an apostrophe, but that sequence actually renders as a an acute
accent.
For an apostrophe or a single closing quote, use plain '. For single
opening quote, i.e. a straight downward line ' like the one used in
shell commands, use \(aq.
Christian Göttsche [Fri, 6 Aug 2021 16:04:20 +0000 (18:04 +0200)]
doc/mkcert.sh: Fix variables used for paths in error messages
The used variables are by default equal, but might get distinct by
distribution patches.
Timo Sirainen [Fri, 25 Feb 2022 20:21:40 +0000 (21:21 +0100)]
auth: passdb-sql - Clear passwords from memory after use
Based on patch by Miecio Za
Timo Sirainen [Fri, 25 Feb 2022 20:03:42 +0000 (21:03 +0100)]
global: Use consistently "time moved forward"
Based on patch by Tyson Williams
luz.paz [Thu, 4 Oct 2018 22:52:16 +0000 (18:52 -0400)]
global: Fix spelling
Found via `codespell -q 3`
Timo Sirainen [Fri, 25 Feb 2022 19:47:19 +0000 (20:47 +0100)]
INSTALL.m4: Add note about autogen.sh
Based on patch by Fritz Zaucker
Duncan Bellamy [Sat, 6 Mar 2021 14:25:29 +0000 (14:25 +0000)]
imap: Shorten test-imap-client-hibernate socket path length
Jelmer Vernooij [Tue, 15 Feb 2022 22:51:07 +0000 (22:51 +0000)]
README.m4: Add a link to the GSSAPI-in-SASL spec.
Timo Sirainen [Tue, 22 Feb 2022 13:14:20 +0000 (14:14 +0100)]
director: Fix crashes caused by changing host tag
Fixes:
Panic: file director.c: line 1175 (director_move_user): assertion failed: (user->host->tag == host->tag)
Panic: file director-request.c: line 303 (director_request_continue_real): assertion failed: (user->host->tag == mail_tag)
Timo Sirainen [Tue, 22 Feb 2022 13:10:02 +0000 (14:10 +0100)]
director: Prevent loops where directors keep changing host tags
Aki Tuomi [Fri, 25 Feb 2022 08:25:58 +0000 (10:25 +0200)]
config: old-set-parser - Remove stale FIXME
Aki Tuomi [Thu, 24 Feb 2022 10:55:14 +0000 (12:55 +0200)]
config: old-set-parser - Remove ssl-parameters.dat processing
Timo Sirainen [Fri, 18 Feb 2022 16:31:43 +0000 (18:31 +0200)]
dsync: Log reason why mailbox is synced with debug logging
Timo Sirainen [Mon, 21 Feb 2022 22:07:11 +0000 (23:07 +0100)]
dsync: If modseqs aren't permanent, assume HIGHESTMODSEQ=0
Otherwise the HIGHESTMODSEQ is just whatever happens to be in the in-memory
view of the index, which most likely isn't the true HIGHESTMODSEQ. Using 0
makes it clear that the HIGHESTMODSEQ isn't valid and can't be used.
Timo Sirainen [Wed, 24 Feb 2021 16:57:24 +0000 (18:57 +0200)]
lib-storage: Fix renaming mailbox hierarchies with FULLDIRNAME
If INDEX/INDEXPVT/INDEXCACHE/CONTROL were specified separately, they
weren't being renamed correctly. This mainly meant that if there was
a "foo/bar" folder, renaming "foo" to "foo2" wouldn't work correctly.
Timo Sirainen [Fri, 18 Feb 2022 10:11:53 +0000 (12:11 +0200)]
lib-storage: Split off path_get_parent_dir()
Martti Rannanjärvi [Mon, 29 Nov 2021 20:44:04 +0000 (22:44 +0200)]
config: old-set-parser - Mark license_checksum obsolete
Karl Fleischmann [Tue, 15 Feb 2022 15:22:06 +0000 (16:22 +0100)]
lib: Remove deprecated src_pos_r parameter from base64_decode()
The src_pos_r parameter in base64_decode() has been deprecated in commit
afa3db0a6f15e1b1038cb47f0632baa8f23d0f67 and is now removed - both from
the function as well as all it's calls.
Stephan Bosch [Sat, 12 Feb 2022 14:07:39 +0000 (15:07 +0100)]
submission-login: submission-proxy - Do not include initial response in AUTH command if it is too long.
Stephan Bosch [Mon, 21 Feb 2022 20:36:55 +0000 (21:36 +0100)]
submission-login: submission-proxy - Rename local variable in proxy_send_login().
Stephan Bosch [Mon, 21 Feb 2022 20:32:45 +0000 (21:32 +0100)]
lib-smtp: smtp-client - Move SMTP_BASE_LINE_LENGTH_LIMIT definition to smtp-common.h.
Stephan Bosch [Mon, 21 Feb 2022 20:29:23 +0000 (21:29 +0100)]
lib-smtp: smtp-client-connection - Rename SMTP_CLIENT_BASE_LINE_LENGTH_LIMIT to SMTP_BASE_LINE_LENGTH_LIMIT.
Stephan Bosch [Wed, 23 Feb 2022 13:21:02 +0000 (14:21 +0100)]
lib-smtp: smtp-client-connection - Fix typo in comment.
Timo Sirainen [Tue, 22 Feb 2022 14:09:02 +0000 (15:09 +0100)]
master: Fix logging errors when service listener creation fails
Only some of the errors were logged.
Broken by
6934b81afa05e25ac919a49a7fd30acf78ffa3dd
Timo Sirainen [Tue, 22 Feb 2022 14:11:07 +0000 (15:11 +0100)]
master: service_unix_listener_listen() - Don't ignore EISDIR/ENOENT errors on reload
The listener is likely important, so failure to be able to create it
shouldn't be ignored. These errors aren't expected to happen though.
Timo Sirainen [Tue, 22 Feb 2022 11:22:02 +0000 (12:22 +0100)]
anvil: Free all memory used by still connected processes at deinit
Timo Sirainen [Tue, 22 Feb 2022 11:08:33 +0000 (12:08 +0100)]
anvil: Split off connect_limit_process_free()
Timo Sirainen [Mon, 21 Feb 2022 16:18:22 +0000 (17:18 +0100)]
anvil: Use a maximum of 100 open admin-client connections while kicking users
Timo Sirainen [Mon, 21 Feb 2022 16:10:37 +0000 (17:10 +0100)]
anvil: Split off kick_user_iter_more()
Timo Sirainen [Mon, 21 Feb 2022 16:09:30 +0000 (17:09 +0100)]
anvil: Move add_conn_guid to struct anvil_cmd_kick
Timo Sirainen [Mon, 21 Feb 2022 16:07:36 +0000 (17:07 +0100)]
anvil: Move prev_pid to struct anvil_cmd_kick
Timo Sirainen [Mon, 21 Feb 2022 15:32:15 +0000 (16:32 +0100)]
anvil: Always use a new admin-connection for KICK-USER-SIGNAL commands
Otherwise the race condition prevention doesn't work. Also it may have
attempted to send the KICK-USER-SIGNAL command to admin-client connection,
which would respond with "Unknown command".
Timo Sirainen [Mon, 21 Feb 2022 15:50:56 +0000 (16:50 +0100)]
anvil: Improve error logging if KICK-USER command fails
The kick target-specific struct will be also useful in the next commit.
Timo Sirainen [Mon, 21 Feb 2022 16:04:59 +0000 (17:04 +0100)]
anvil: Make admin_client_unref(&NULL) no-op
Timo Sirainen [Mon, 21 Feb 2022 16:02:43 +0000 (17:02 +0100)]
anvil: admin-client - Add reference counting
This allows the command callback to free the admin-client.
Timo Sirainen [Mon, 21 Feb 2022 16:59:43 +0000 (17:59 +0100)]
anvil: connect-limit - Support multiple asynchronous iterators
Timo Sirainen [Mon, 21 Feb 2022 16:51:51 +0000 (17:51 +0100)]
lib-storage: mail_user_get_anvil_session() - Add alt_usernames
Timo Sirainen [Mon, 21 Feb 2022 16:51:27 +0000 (17:51 +0100)]
lib-storage: Add mail_user_get_alt_usernames()
Stephan Bosch [Sat, 4 Aug 2018 19:41:59 +0000 (21:41 +0200)]
lib: array - Add array_get_copy() which copies the array_get() result to the provided pool.
Aki Tuomi [Tue, 22 Feb 2022 06:50:10 +0000 (08:50 +0200)]
configure: Stop using cru with ar
Fixes ar: 'u' modifier ignored since 'D' is the default (see 'U')
Aki Tuomi [Tue, 22 Feb 2022 06:23:59 +0000 (08:23 +0200)]
configure: Use silent rules by default
Aki Tuomi [Fri, 4 Feb 2022 12:12:43 +0000 (14:12 +0200)]
Makefile: Add AM_V_GEN to generated files
Aki Tuomi [Fri, 4 Feb 2022 12:06:11 +0000 (14:06 +0200)]
m4: dovecot.m4 - Bump serial
Aki Tuomi [Fri, 4 Feb 2022 12:04:07 +0000 (14:04 +0200)]
run-test.sh: Move to build-aux
Aki Tuomi [Fri, 4 Feb 2022 11:45:27 +0000 (13:45 +0200)]
m4: dovecot.m4 - Fix moduledir self-reference
Fixes distcheck by not referencing itself eventually.
Aki Tuomi [Mon, 31 Jan 2022 13:22:49 +0000 (15:22 +0200)]
configure: Use external script to determine version
Makes packaging easier
Aki Tuomi [Mon, 31 Jan 2022 13:31:21 +0000 (15:31 +0200)]
configure: Use build-aux for external scripts
Aki Tuomi [Mon, 31 Jan 2022 13:36:50 +0000 (15:36 +0200)]
autogen.sh: Do not set ACLOCAL environment variable
m4 directory is set in configure.ac
Aki Tuomi [Tue, 8 Feb 2022 11:19:41 +0000 (13:19 +0200)]
configure.ac: Add tar-ustar option to AM_INIT_AUTOMAKE
Allows using longer filenames, without it, we are limited to 99 chars.
Timo Sirainen [Sun, 6 Feb 2022 13:20:08 +0000 (14:20 +0100)]
dict: Fix potential timeout leak at deinit
The deinit code could still trigger proctitle refresh.
Timo Sirainen [Tue, 22 Feb 2022 10:23:33 +0000 (11:23 +0100)]
dict: Make sure proctitle refresh timeout goes to the main ioloop
In some situations it could have gone to dict_wait() ioloop, causing
timeout leaks or crashes.
Timo Sirainen [Mon, 7 Feb 2022 18:39:35 +0000 (19:39 +0100)]
doveadm: Remove unused doveadm_killed_signo()
Timo Sirainen [Mon, 7 Feb 2022 18:39:08 +0000 (19:39 +0100)]
doveadm sync: Remove duplicate "Killed with signal" logging
It's already logged by lib-master.
Timo Sirainen [Mon, 7 Feb 2022 18:36:27 +0000 (19:36 +0100)]
lib-master: Always log a warning if process is killed by signal
If it's not logged by a delayed signal handler, log it at deinit.
Timo Sirainen [Mon, 7 Feb 2022 18:33:28 +0000 (19:33 +0100)]
lib-master: Split off log_killed_signal()
Timo Sirainen [Mon, 7 Feb 2022 18:32:17 +0000 (19:32 +0100)]
lib-master: Use sig_delayed_ prefix for delayed signal handler functions
This makes it clearer which signal handlers are immediate and which are
delayed.
Timo Sirainen [Thu, 3 Feb 2022 20:28:20 +0000 (21:28 +0100)]
lib-storage: Interrupt long mailbox searches on signal
When interrupt signal (SIGTERM) is received, run mailbox search for 2 more
seconds until failing it with MAIL_ERROR_INTERRUPTED.
Timo Sirainen [Thu, 3 Feb 2022 19:59:46 +0000 (20:59 +0100)]
indexer: Log MAIL_ERROR_INTERRUPTED with info-level instead of error
Timo Sirainen [Thu, 3 Feb 2022 19:54:14 +0000 (20:54 +0100)]
lib-storage: Add MAIL_ERROR_INTERRUPTED
This is going to be used to interrupt operations when e.g. SIGTERM is
received.
Timo Sirainen [Thu, 3 Feb 2022 19:14:25 +0000 (20:14 +0100)]
lib-storage: Avoid transaction rollback if mailbox delete fails in the middle
Commit the changes done so far and then return failure.
Timo Sirainen [Thu, 3 Feb 2022 19:01:04 +0000 (20:01 +0100)]
imap: Don't rollback transaction if expunge search fails
Just commit the expunges done before the failure. The next EXPUNGE will
continue from there.
Timo Sirainen [Thu, 3 Feb 2022 18:59:05 +0000 (19:59 +0100)]
imap: Add comment explaining EXPUNGE batching
Timo Sirainen [Thu, 3 Feb 2022 20:54:48 +0000 (21:54 +0100)]
doveadm: Remove duplicate SIGINT/SIGTERM handlers
lib-master already handles these.
Timo Sirainen [Mon, 21 Feb 2022 07:58:36 +0000 (08:58 +0100)]
doveadm: Remove duplicate "Killed with signal" logging in user iteration
It's already logged by lib-master.
Timo Sirainen [Thu, 3 Feb 2022 22:14:27 +0000 (23:14 +0100)]
lib-master: Add master_service_get_kill_time()
Timo Sirainen [Thu, 3 Feb 2022 20:54:04 +0000 (21:54 +0100)]
lib-master: Add master_service_get_kill_signal()
Timo Sirainen [Thu, 3 Feb 2022 20:48:14 +0000 (21:48 +0100)]
lib-master: Set killed-flag immediately in standalone programs
Timo Sirainen [Thu, 3 Feb 2022 20:44:24 +0000 (21:44 +0100)]
lib-master: Set killed-flag immediately in SIGTERM handler
This allows master_service_is_killed() to return TRUE without waiting for
the next ioloop to run.
Timo Sirainen [Mon, 21 Feb 2022 11:47:29 +0000 (12:47 +0100)]
lib: If log prefix update can't be sent to log, exit with FATAL_LOGERROR
Timo Sirainen [Mon, 21 Feb 2022 11:39:02 +0000 (12:39 +0100)]
lib: Fix losing log prefix or IP change when log process is busy
The fd for writing to log process is non-blocking. When sending options
to log process, it was done with write_full(), which stopped whenever
EAGAIN was returned. This error was simply ignored, and the logging code
thought that the prefix was successfully changed (or the IP was sent).
This mainly caused a problem when processes were reused and log process
was busy. The prefix update could have failed, and the following logging
would be using the previous session's log prefix, i.e. log lines could have
been logged for the wrong user/session.
Broken by
9372e48b702a3af5705785e08fbf47b0e37f2047
Aki Tuomi [Tue, 22 Feb 2022 06:08:52 +0000 (08:08 +0200)]
configure: Remove DOVECOT_WANT_SHADOW
Forgotten in
62cde650ebc83a8af6fe23f85dc92214afee672b
Timo Sirainen [Mon, 21 Feb 2022 15:01:22 +0000 (16:01 +0100)]
lib: connection - Fix changing istream in handshake_line() or input_line()
If the istream was changed (e.g. istream-multiplex added), the following
line was still read using the previous istream.
Fixes errors caused by recent anvil changes:
anvil: Error: Anvil client sent empty line
Timo Sirainen [Mon, 21 Feb 2022 14:59:16 +0000 (15:59 +0100)]
lib: Split off connection_input_parse_lines()
Timo Sirainen [Mon, 21 Feb 2022 14:56:36 +0000 (15:56 +0100)]
anvil: Log errors using connection event
Aki Tuomi [Thu, 17 Feb 2022 08:06:40 +0000 (10:06 +0200)]
indexer: Free user after anvil disconnect
Fixes invalid use after free. Broken by
f9627ea62b5cb471d9adde0cc188ee8dea93c172
Marco Bettini [Wed, 2 Feb 2022 15:09:37 +0000 (16:09 +0100)]
fts-squat: Remove the plugin
Timo Sirainen [Tue, 25 Jan 2022 10:48:55 +0000 (11:48 +0100)]
imap-hibernate: Support kicking connections
Timo Sirainen [Tue, 8 Feb 2022 14:33:31 +0000 (15:33 +0100)]
lib-master, global: Add and use MASTER_SERVICE_SHUTTING_DOWN_MSG
Use a macro to replace "Server shutting down" texts in different services.
Timo Sirainen [Tue, 25 Jan 2022 10:41:50 +0000 (11:41 +0100)]
imap-hibernate: Send BYE message to client when process shuts down.
Since the BYE message isn't explicitly flushed, this change also disables
error handling for the client ostream to prevent assert-crash at destroy.
Timo Sirainen [Tue, 25 Jan 2022 10:39:13 +0000 (11:39 +0100)]
imap-hibernate: Use the same "Server shutting down" log message as imap
Not just "Shutting down".
Timo Sirainen [Tue, 25 Jan 2022 10:37:40 +0000 (11:37 +0100)]
imap, imap-urlauth, pop3: Remove trailing period from "Server shutting down" log message
It's a bit weird having it in the log message. It's still sent to the
client though.
Marco Bettini [Thu, 3 Feb 2022 11:02:00 +0000 (12:02 +0100)]
fts-lucene: Remove the plugin
Karl Fleischmann [Wed, 2 Feb 2022 16:25:55 +0000 (17:25 +0100)]
auth: Remove shadow passdb driver
Drop support of shadow passdb driver by removing the implementation,
relevant references, build chain entries and the example config.
Marco Bettini [Tue, 1 Feb 2022 13:22:31 +0000 (14:22 +0100)]
mail-crypt: Fix for mail being wrongly storing encrypted via LMTP
If 1st recipient has mail_crypt_save_version=2,
and 2nd recipient has mail_crypt_save_version=0,
the mail for 2nd recipient is wrongly stored encrypted.
Same happens if 2nd recipient has mail_crypt disabled
Timo Sirainen [Tue, 31 Mar 2020 10:51:09 +0000 (13:51 +0300)]
mail-crypt: Remove "plugin disabled" texts from errors
The plugin isn't just disabled, the user initialization fails entirely.
Timo Sirainen [Tue, 31 Mar 2020 10:49:28 +0000 (13:49 +0300)]
mail-crypt: Fix crash when plugin is already initialized, but not used for another user
Fixes:
Panic: Module context mail_crypt_user_module missing
Marco Bettini [Thu, 3 Feb 2022 14:08:39 +0000 (15:08 +0100)]
old-stats: Remove the plugin, lib-old-stats old-stats plugins/imap-old-stats plugins/old-stats
Marco Bettini [Wed, 16 Feb 2022 10:52:41 +0000 (11:52 +0100)]
lib-storage: Drop struct mail_user_vfuncs.stats_fill API
Marco Bettini [Thu, 3 Feb 2022 14:59:21 +0000 (15:59 +0100)]
auth: Drop auth-stat