Nicolas Coden [Fri, 6 Jul 2018 20:31:56 +0000 (22:31 +0200)]
Use pull request #11346 from ncoden/fix/gulp-deploy-task-multiple-completion-callback for v6.5.0
6cb873365 fix: fix completion callback called too many time in deploy task 9a9f0c197 style: remove unused "done" in "dist:deploy" gulp task dcd3ab813 fix: remove run-sequence from gulp `deploy:dist` task to detect its end
Nicolas Coden [Tue, 3 Jul 2018 20:03:28 +0000 (22:03 +0200)]
docs: improve gitflow model for supported versions
Currently, supported versions are hosted on `support/<version>`. This bramch is intended to receive all commits and pull requests for compatible patches in order to prepare a release. The release would be made on the same bramch.
The issue with this model is that unline latest versions, support versions are not released on a "safe" branch. In order to resolve this issue and harmonize the way versions are prepared and released, the current commit move `support/<version>` to `develop/<version>` and add `master/<version>`.
Changes:
* Update CONTRIBUTING documentation to describe the `develop/...`+`master/...` approach
* Update GitHub pull request template to advise `develop/...` instead
Nicolas Coden [Sun, 1 Jul 2018 20:00:40 +0000 (22:00 +0200)]
refactor: simplify Input Group border-radius selector
We should assume as little as possible to HTML structure inside our components. People should be able to freely use the classes of components/elements we provide without limited by self-references and dependencies.
This commit simplify the selector used to apply border-radius on Input Group childreens to make all childreens affected, with a single exception for `.input-group-button` where sub-childreens are affected too.
Nicolas Coden [Sun, 1 Jul 2018 17:46:22 +0000 (19:46 +0200)]
fix: remove run-sequence from gulp `deploy:dist` task to detect its end
`run-sequence` doesn't match well with multile streams from `gulp-filter` and prevent us to use the stream end event or gulp to automatically detect the stream end. This commit refactor the `deploy:dist` task and move its logics to `deploy:dist:files` in order to make gulp dealing directly with the `gulp-filter` stream and detect its end.
Nicolas Coden [Thu, 28 Jun 2018 17:32:12 +0000 (19:32 +0200)]
fix: remove $-zf-size from non-responsive XY Grid classes generation
`$-zf-size` is only set within breakpoints. Breakpoints are not expected to be used around the `xy-vertical-grid-classes()` mixin.
Note: a more appropriate fix would be to rely on the `xy-cell()` mixin instead of `xy-cell-static()` to fully support explicit/implicit/null breakpoint option. However this may introduce breaking changes, so this will be kept for v6.6.0.
Nicolas Coden [Tue, 26 Jun 2018 20:43:59 +0000 (22:43 +0200)]
chore: resolve jQuery devDependency CVE
Update the internal jQuery version (used for tests) to the latest version to resolve a CVE.
As Foundation supports jQuery `>=2.2.0`, the jQuery peer dependency is not changed. PeerDependencies versions in `package.json` should only reflect the actual compatibility with the package, regardless of promotion or "potential" security issue. It's up to the end developer to choose the package version corresponding to its own needs and to the risks comming with its own usage.
Nicolas Coden [Mon, 25 Jun 2018 22:55:50 +0000 (00:55 +0200)]
fix: add back Bower dependencies
Bower dependencies in `bower.json` were removed in #11073 in the migration from Bower to npm.
These dependencies should not have been removed as the Bower package still require `jquery` and `what-input`. Someone installing `foundation-sites` with bower should still have these packages included. We simply don't use Bower anymore in development mode and don't promote its usage in the documentation.
Removing `bower install` commands was sufficiant for this migration and Bower dependencies in `bower.json` were unrelated.
See https://github.com/zurb/foundation-sites/pull/11073
Nicolas Coden [Sun, 17 Jun 2018 21:52:41 +0000 (23:52 +0200)]
fix: keep a scrollbar on document when Reveal opens #7831
#11065 was intented to avoid double scrollbars from a Reveal modal, but removing all scrollbars when the modal opens changes the page content width and the content shift. This is a regression of #7831.
The current solution is a mix between the two previous fixes:
* Modal may have a scrollbar or not, following its content height
* Body has no scrollbar and prevent any scroll
* Document may have a scrollbar, following its content height (controlled in JS)
Changes:
* add the `zf-has-scroll` global html modifer and toggle it on Reveal opening/closing
* always prevent scroll on body instead of html tag like in #10583
See https://github.com/zurb/foundation-sites/issues/10791#issuecomment-377861523
Closes #7831
dependabot[bot] [Sun, 17 Jun 2018 17:33:49 +0000 (19:33 +0200)]
Use dependabot pull requests for v6.5.0
934220821 build: bump mocha from 5.0.5 to 5.1.0 c6a456739 build: bump autoprefixer from 8.2.0 to 8.3.0 a4bb6fae2 build: bump chalk from 2.3.2 to 2.4.0 ec6fef998 build: bump webpack from 4.5.0 to 4.6.0 e8455ecb1 build: bump mocha from 5.1.0 to 5.1.1 74f469eba build: bump browser-sync from 2.23.6 to 2.23.7 0bb5e3fbc build: bump mocha-headless-chrome from 1.8.3 to 2.0.0 15dbe8ac3 build: bump chalk from 2.4.0 to 2.4.1 15d30ca9c build: bump babel-core from 6.26.0 to 6.26.2 20b64ebb6 build: bump browser-sync from 2.23.7 to 2.24.1 e530be531 build: bump clipboard from 2.0.0 to 2.0.1 af26f10f8 build: bump autoprefixer from 8.3.0 to 8.4.1 7b5115317 build: bump sinon from 4.5.0 to 5.0.1 f58137d2e build: bump babel-core from 6.26.2 to 6.26.3 7ae645f56 build: bump @commitlint/cli from 6.1.3 to 6.2.0 3a15b77c6 build: bump sinon from 5.0.1 to 5.0.3 4ddcee67b build: bump browser-sync from 2.24.1 to 2.24.2 2d1ddcd19 build: bump what-input from 5.0.5 to 5.0.7 08c895bdd build: bump browser-sync from 2.24.2 to 2.24.4 2d50de586 build: bump gulp-clean-css from 3.9.3 to 3.9.4 0c00cc766 build: bump webpack from 4.6.0 to 4.7.0 a2a820fbe build: bump sinon from 5.0.3 to 5.0.5 57e5a0ce6 build: bump array-uniq from 1.0.3 to 2.0.0 bcdc081eb build: bump webpack from 4.7.0 to 4.8.3 47875fbd5 build: bump husky from 1.0.0-rc.2 to 1.0.0-rc.4 2cf410832 build: bump sinon from 5.0.5 to 5.0.7 bbef3b798 build: bump autoprefixer from 8.4.1 to 8.5.0 e720c283a build: bump gulp-rename from 1.2.2 to 1.2.3 8e3319401 build: bump mocha from 5.1.1 to 5.2.0 80fcdfa7d build: bump what-input from 5.0.7 to 5.1.0 d0fdc5974 build: bump gulp-replace from 0.6.1 to 1.0.0 4a5230a37 build: bump husky from 1.0.0-rc.4 to 1.0.0-rc.6 1b2194e11 build: bump sinon from 5.0.7 to 5.0.10 22015f4bd build: bump gulp-sass-lint from 1.3.4 to 1.4.0 b6d25277a build: bump autoprefixer from 8.5.0 to 8.5.1 447da60a0 build: bump webpack from 4.8.3 to 4.9.1 28455f90a build: bump husky from 1.0.0-rc.6 to 1.0.0-rc.8 ba39fb498 build: bump @commitlint/config-conventional from 6.1.3 to 7.0.1 369819694 build: bump inquirer from 5.2.0 to 6.0.0 44548fab2 build: bump @commitlint/cli from 6.2.0 to 7.0.0 81d18b62d build: bump webpack from 4.9.1 to 4.10.2 12b16b068 build: bump js-yaml from 3.11.0 to 3.12.0 a94d2b149 build: bump autoprefixer from 8.5.1 to 8.6.0
Note: package-lock.json and yarn.lock files were separately regenerated.
Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Nicolas Coden [Sat, 16 Jun 2018 08:54:22 +0000 (10:54 +0200)]
Use pull request #11317 from ncoden/chore/upgrade-babel-v7 for v6.5.0
4174473b3 fix: use the env babel preset for browserify transformation 07348e7e5 refactor: move all browserlist configs to .browserslistrc 1b09e3d91 chore: update Babel to v7 4a42d2a1f fix: add missing Foundation import in Touch entry
Nicolas Coden [Sat, 16 Jun 2018 08:52:10 +0000 (10:52 +0200)]
Use pull request #11315 from ncoden/fix/breakpoint-max-width-precision-11313 for v6.5.0
798377d96 fix: lower breakpoint max value precision to avoid rounding #11313 a36504ccb fix: revert mistakenly changed `$global-flexbox` setting in #11315
Nicolas Coden [Sat, 16 Jun 2018 08:17:03 +0000 (10:17 +0200)]
Use pull request #11279 from ncoden/test/fix-interchange-debonce-test-race-condition for v6.5.0
2bebd870a feat: add `testInterval` test utility ad2a282e6 test: wait for debounce for slow browsers in Interval debounce test 33d009a48 docs: add doc for "tryInterval" test utility
projects / thirdparty / foundation / foundation-sites.git / log
