Marius Olbertz [Mon, 19 Jun 2017 17:32:54 +0000 (19:32 +0200)]
Make Drilldown use tree role.
Drilldown should - like AccordionMenu - have the role tree as it consists of a hierarchical list of elements.
Sub-menus should have role group and items should have role treeitem.
Brett Mason [Fri, 16 Jun 2017 20:24:32 +0000 (21:24 +0100)]
Attempt at fixing the issue of using grid-margin-x on grid-y breaking the width, and grid-margin-y on grid-x breaking the height.
Seems to work correctly so far from testing.
SassNinja [Fri, 16 Jun 2017 09:13:20 +0000 (11:13 +0200)]
Remove the transitionend listener for the content container
Since the limited version doesn't enable push transitions for nested elements, there's no need to listen on the content because the element always gets moved.
SassNinja [Fri, 16 Jun 2017 08:20:07 +0000 (10:20 +0200)]
Restore transform scope for push transitions so transitionend works correctly
Due to the content's initial transform:none the transitionend listener didn't work for the content container.
This is fixed now by using the has-transition-push class that is also used in the positions mixin to limit the translate to push transitions.
SassNinja [Wed, 14 Jun 2017 15:59:13 +0000 (17:59 +0200)]
Remove content classes on close, fix transitionend listener & set default transform none for content
Now the content container has none transform by default so position fixed works as soon as an push off-canvas is closed.
Besides the transitionend listener is now fixed so it isn't bound to only the content or the element but to both of them.
The content classes specification is now part of the setup (this.contentClasses) for an improved readability.
SassNinja [Tue, 13 Jun 2017 07:08:29 +0000 (09:08 +0200)]
Remove deprecated wrapper inner from docs layout
Firstly the implementation was erroneous (content mustn't be a sibling of the wrapper but a child) and secondly the wrapper inner is deprecated.
Therefore I'm removing it what makes the push transitions on the off-canvas docs page working again as expected.
SassNinja [Tue, 13 Jun 2017 06:41:19 +0000 (08:41 +0200)]
Undo the wrapper inner fix
Since wrapper inner is deprecated and erroneously implemented in the docs, I'm undoing my fix.
Once the docs got fixed, the push transition is going to work as expected.
Kai Falkowski [Mon, 12 Jun 2017 05:05:59 +0000 (07:05 +0200)]
Add $wrapperInner (prior v6.3) detection + a CSS fix
Regarding the off-canvas docs setup, a detection of the prior off-canvas wrapper inner is necessary.
Besides I'm fixing some specificity issue caused by _page.scss (foundation-docs)
Kai Falkowski [Mon, 12 Jun 2017 05:04:57 +0000 (07:04 +0200)]
Force overlap transition for nested off-canvas elements to avoid transform scope issues
Using position fixed within a transform scope doesn't work and fixedPositionEmulation + position calculations don't work reliably yet.
Therefore I'm forcing overlap transition when nesting (at the moment).
David Luhr [Thu, 8 Jun 2017 17:24:36 +0000 (11:24 -0600)]
Add else statement inside of ifequal example
It is unclear that else statements are possible inside of {{#ifequal}} helpers to show HTML if the two values are not equal. Because there are {{#ifpage}} and {{#unlesspage}} as separate equal/not equal helpers, users may be confused that there is no equivalent "unlessequal" helper or "!" syntax.
I have successfully used the {{else}} Handlebars helper inside if the {{#ifequal}} Paini helper to achieve the desired "not equal" condition, but only thought to try this as a guess after a lot of unsuccessful searching through documentation on both Handlebars and Panini.
Brett Mason [Thu, 8 Jun 2017 09:01:45 +0000 (10:01 +0100)]
Change cursor for accordion submenu toggle
Noticed while testing that we don't get a pointer cursor when hovering over a new submenu toggle within accordion menu, but I think it should to give feedback to the user.