]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Jorge Pereira [Tue, 17 May 2022 14:07:20 +0000 (11:07 -0300)]
radsniff: Add '-Z' option allowing to dump the packets (#4504)
* log: Fix fr_pair_list_log() to accept level identation parameter
* log: Fix fr_log_init_file() 'fd' set
* log: Fix fr_log_close() 'dst' check
* radsniff: Add '-Z' option allowing to dump the packets
Alan T. DeKok [Tue, 17 May 2022 13:19:52 +0000 (09:19 -0400)]
return actual offset, not bumped up by 1
Alan T. DeKok [Tue, 17 May 2022 13:19:33 +0000 (09:19 -0400)]
close on error. Fixes #4518
Alan T. DeKok [Tue, 17 May 2022 13:19:16 +0000 (09:19 -0400)]
close on error. Fixes #4518
Jorge Pereira [Tue, 26 Apr 2022 23:46:44 +0000 (20:46 -0300)]
log: Fix fr_log_close() 'dst' check
Jorge Pereira [Tue, 26 Apr 2022 23:36:14 +0000 (20:36 -0300)]
log: Fix fr_log_init_file() 'fd' set
Nick Porter [Tue, 17 May 2022 07:47:04 +0000 (08:47 +0100)]
Ensure module loading errors are printed out
Alan T. DeKok [Mon, 16 May 2022 21:13:06 +0000 (17:13 -0400)]
Alan T. DeKok [Sat, 14 May 2022 17:31:44 +0000 (13:31 -0400)]
typo
Alan T. DeKok [Sat, 14 May 2022 12:46:50 +0000 (08:46 -0400)]
shut up clang scan
Alan T. DeKok [Fri, 13 May 2022 21:48:39 +0000 (17:48 -0400)]
don't free too much
Alan T. DeKok [Fri, 13 May 2022 18:31:08 +0000 (14:31 -0400)]
move xlats to dlists.
Alan T. DeKok [Thu, 12 May 2022 18:20:01 +0000 (14:20 -0400)]
clean up in preparation for moving to lists
Alan T. DeKok [Thu, 12 May 2022 18:01:52 +0000 (14:01 -0400)]
clean up so that there's less magic.
Alan T. DeKok [Thu, 12 May 2022 17:34:54 +0000 (13:34 -0400)]
remove flags from xlat expr tokenize functions.
Alan T. DeKok [Thu, 12 May 2022 02:09:13 +0000 (22:09 -0400)]
sanity check for flags
the caller should't set run-time flags.
Alan T. DeKok [Thu, 12 May 2022 01:58:40 +0000 (21:58 -0400)]
remove flags from xlat tokenize functions.
The flags are now only used for xlat registrations.
Alan T. DeKok [Thu, 12 May 2022 01:38:18 +0000 (21:38 -0400)]
start of API cleanup
Alan T. DeKok [Thu, 12 May 2022 01:34:40 +0000 (21:34 -0400)]
minor clarifications
Alan T. DeKok [Thu, 12 May 2022 01:07:19 +0000 (21:07 -0400)]
xlat tokenize functions now only need head
not ctx, out, and flags
Alan T. DeKok [Thu, 12 May 2022 00:37:52 +0000 (20:37 -0400)]
set flags correctly.
it's probably easier to do this correctly if we have a better API
Alan T. DeKok [Thu, 12 May 2022 00:50:53 +0000 (20:50 -0400)]
xlat_resolve() no longer needs flags
Alan T. DeKok [Wed, 11 May 2022 14:12:30 +0000 (10:12 -0400)]
ensiure that xlat_resolve() can always be passed NULL flags
Alan T. DeKok [Wed, 11 May 2022 13:55:16 +0000 (09:55 -0400)]
no need to pass flags here
Alan T. DeKok [Wed, 11 May 2022 02:22:12 +0000 (22:22 -0400)]
remove xlat flags from tmpl structure
Alan T. DeKok [Wed, 11 May 2022 02:16:54 +0000 (22:16 -0400)]
start of removing xlat_flags_t from tmpl
sometimes go a bit sideways to make progress.
Alan T. DeKok [Tue, 10 May 2022 21:24:31 +0000 (17:24 -0400)]
remove flags from xlat some functions.
expose an API to get at the few flags which are needed.
move tmpls to use the API
Alan T. DeKok [Wed, 11 May 2022 02:01:02 +0000 (22:01 -0400)]
set head flags, too
Jorge Pereira [Mon, 16 May 2022 18:59:48 +0000 (15:59 -0300)]
schedule: Fix potential memory-leak (#4510)
James Jones [Mon, 16 May 2022 16:54:37 +0000 (11:54 -0500)]
Check fr_value_box_from_network(), fr_value_box_cast() returns (CID #
1469115 , #
1503931 ) (#4514)
Alan T. DeKok [Mon, 16 May 2022 16:40:25 +0000 (12:40 -0400)]
re-add flags removed erroneously
Alan T. DeKok [Sun, 15 May 2022 14:09:41 +0000 (10:09 -0400)]
Add explicit paths for OSX
because apparently some of the C compilers aren't built with the
default paths for everything on the system.
Alan T. DeKok [Sat, 14 May 2022 17:37:32 +0000 (13:37 -0400)]
fix up for OSX
newer versions of clang can't find things. So we need to manually
add the paths in.
James Jones [Fri, 13 May 2022 21:30:56 +0000 (16:30 -0500)]
Catch invalid status values in tls_cache_session_ticket_app_data_get (#4509)
James Jones [Fri, 13 May 2022 21:29:49 +0000 (16:29 -0500)]
Make load_noinstall_path() free what it doesn't return (CID #
1504304 ) (#4500)
Nick Porter [Fri, 13 May 2022 21:26:54 +0000 (22:26 +0100)]
v4: Changes needed for fr_pair_list_..._by_da macros (#4508)
James Jones [Fri, 13 May 2022 21:25:13 +0000 (16:25 -0500)]
Add checks of fr_lst_insert() calls (CID #
1503950 , #
1504014 ) (#4512)
James Jones [Fri, 13 May 2022 21:24:40 +0000 (16:24 -0500)]
Check fr_minmax_heap_alloc() return value (CID #
1504069 ) (#4513)
Nick Porter [Thu, 12 May 2022 15:52:39 +0000 (16:52 +0100)]
Define macros for adding a pair to a list and assinging its value (#4507)
James Jones [Thu, 12 May 2022 14:03:46 +0000 (09:03 -0500)]
Just adjust ext when removing "mod_" (CID #
1504300 ) (#4506)
One need only adjust ext by 4 when, in truncate_dll_name(), one
removes "mod_". Then if len exceeds 8 ext still points at the
extension, and coverity can't kvetch about not checking the value
strchr() returns (Using strchr() the second time means
"mumblefrotz.foo.dll" won't behave as expected; does that ever
turn up in practice?)
James Jones [Thu, 12 May 2022 02:47:55 +0000 (21:47 -0500)]
Switch to memmove() for truncate_dll_name() (CID #
1504298 ) (#4495)
with overlapping src/dest, strcpy() gives undefined behavior
James Jones [Thu, 12 May 2022 02:47:39 +0000 (21:47 -0500)]
Remove the needless done_init variables from tests (#4505)
This change should settle CIDs
1504383 -150439, making clear to
Coverity that rand_ctx is indeed initialized.
James Jones [Wed, 11 May 2022 21:06:40 +0000 (16:06 -0500)]
Use fr_fast_rand() to select operation in burn-in (CID #
1503935 , #
1504015 ) (#4503)
James Jones [Wed, 11 May 2022 17:34:27 +0000 (12:34 -0500)]
Convert tests to use fr_fast_rand() rather than srand()/rand() (#4502)
Coverity considers rand() risky, but data structure tests don't
require cryptographically secure pseudorandom numbers. This should
take care of CIDs
1469120 ,
1469179 ,
1503927 ,
1503935 ,
1503941 ,
1503967 ,
1503977 ,
1503990 ,
1504015 ,
1504048 , and
1504054 .
James Jones [Mon, 9 May 2022 21:38:44 +0000 (16:38 -0500)]
Check value returned by fr_pair_value_mem_alloc() (CID #
1503929 ) (#4498)
James Jones [Mon, 9 May 2022 21:38:14 +0000 (16:38 -0500)]
Correct MEM() check of fr_pair_value_mem_alloc() return value (#4497)
Arran Cudbard-Bell [Thu, 5 May 2022 22:27:54 +0000 (00:27 +0200)]
Make python configure script check that it can actually link to the python libraries
Arran Cudbard-Bell [Thu, 5 May 2022 22:27:21 +0000 (00:27 +0200)]
Fix atomic queue alignment on 32bit systems
Arran Cudbard-Bell [Thu, 5 May 2022 22:27:05 +0000 (00:27 +0200)]
stderr and stdout are macros and conflict with these fields
Arran Cudbard-Bell [Thu, 5 May 2022 14:14:50 +0000 (16:14 +0200)]
Allow building without semaphores
Arran Cudbard-Bell [Thu, 5 May 2022 12:55:03 +0000 (14:55 +0200)]
Build build system libraries with HOST_CC
Arran Cudbard-Bell [Thu, 5 May 2022 12:17:00 +0000 (14:17 +0200)]
Print out canonical target names and add "darwin"
Arran Cudbard-Bell [Thu, 5 May 2022 10:39:37 +0000 (12:39 +0200)]
Allow toolset to be set explicitly
Alan T. DeKok [Sat, 7 May 2022 13:42:35 +0000 (09:42 -0400)]
remove unused variable
Alan T. DeKok [Sat, 7 May 2022 13:40:52 +0000 (09:40 -0400)]
minor cleanups
Alan T. DeKok [Sat, 7 May 2022 12:19:49 +0000 (08:19 -0400)]
add "ignore this list" entries.
If we're inserting a new structural member, then we don't need
to undo edits to any children in it's lists. Those edits will be
undone automatically when the parent pair is undone.
We keep a separate list of "lists to ignore", and check that
before doing anything. If the list can be ignored, then we
discard delete / clear / etc.
In inserts, if the VP is structural, then remember its child list,
so that we can ignore edits to it, too.
Alan T. DeKok [Sat, 7 May 2022 12:08:39 +0000 (08:08 -0400)]
rename, as there are too many "list" things here.
James Jones [Sat, 7 May 2022 01:26:16 +0000 (20:26 -0500)]
Remove initial FR_TYPE_NULL check from fr_value_box_from_substr() (CID #
1504016 ) (#4496)
Better to let it be handled in the switch statement.
James Jones [Fri, 6 May 2022 17:36:26 +0000 (12:36 -0500)]
Free result of file_name_stripped() when needed (CID #
1504303 ) (#4494)
James Jones [Thu, 5 May 2022 21:56:46 +0000 (16:56 -0500)]
fr_strerror_clear() needn't bother with fr_strerror_init() (CID #
1503892 ) (#4486)
fr_strerror_clear() already refers to fr_strerror_buffer, and might as
well use it rather than the return value from fr_sterror_init().
James Jones [Thu, 5 May 2022 21:55:00 +0000 (16:55 -0500)]
Move use of out after check for NULL (CID #
1503900 ) (#4482)
James Jones [Thu, 5 May 2022 21:54:42 +0000 (16:54 -0500)]
Wrap malloc() in MEM() to reassure coverity (CID #
1469117 ) (#4485)
James Jones [Thu, 5 May 2022 21:54:22 +0000 (16:54 -0500)]
Add check for NULL from fr_value_box_alloc_null() (CID #
1469164 ) (#4487)
James Jones [Thu, 5 May 2022 21:53:54 +0000 (16:53 -0500)]
Add another check of fr_event_fd_insert() for trunk tests (CID #
1469165 ) (#4492)
James Jones [Thu, 5 May 2022 21:53:40 +0000 (16:53 -0500)]
Correct memory leak in add_dynlink_noinstall (CID #
1504301 , #
1504306 ) (#4493)
The single check for either install_path or current_path being NULL
will leak if it passes; load_noinstall_path() doesn't have an explicit
return NULL and lt_malloc() exits if malloc() returns NULL, so
current_path is guaranteed non-NULL if load_noinstall_path() returns.
To avoid the issue, check install_path immediately after it's set.
(If coverity doesn't recognize that current_path will never be NULL,
it may need MEM().)
At the end of add_dynlink_noinstall(), both are freed.
Alan T. DeKok [Thu, 5 May 2022 12:57:38 +0000 (14:57 +0200)]
rename variables to something which makes sense
James Jones [Thu, 5 May 2022 12:52:12 +0000 (07:52 -0500)]
Remove needless check for FR_TYPE_NULL (CID #
1503975 ) (#4488)
Alan T. DeKok [Thu, 5 May 2022 12:47:05 +0000 (14:47 +0200)]
set target-specific C compiler via SRC_CC
which should usually be $(COMPILE.c)
Arran Cudbard-Bell [Thu, 5 May 2022 10:21:20 +0000 (12:21 +0200)]
More minor jlibtool fixes
Arran Cudbard-Bell [Thu, 5 May 2022 09:50:46 +0000 (11:50 +0200)]
Pass through our compiler and ranlib defs when building jlibtool
Arran Cudbard-Bell [Thu, 5 May 2022 09:36:59 +0000 (11:36 +0200)]
prctrl definitel isn't posix
Arran Cudbard-Bell [Thu, 5 May 2022 09:36:13 +0000 (11:36 +0200)]
LIBRARY_EXT is really TARGET_LIBRARY_EXT which isn't what we want
Arran Cudbard-Bell [Thu, 5 May 2022 09:35:36 +0000 (11:35 +0200)]
Set HOST_CC TARGET_CC HOST_RANLIB TARGET_RANLIB from their respective environmental variables
Arran Cudbard-Bell [Thu, 5 May 2022 09:26:34 +0000 (11:26 +0200)]
If the target is empty or set to "default" just use the host target
This makes it a little easier in the build framework
Arran Cudbard-Bell [Thu, 5 May 2022 09:14:25 +0000 (11:14 +0200)]
Don't build semaphore code under emscripten, it's not available
Arran Cudbard-Bell [Wed, 4 May 2022 23:41:34 +0000 (01:41 +0200)]
Do partial target matching in jlibtool
Arran Cudbard-Bell [Wed, 4 May 2022 13:48:48 +0000 (15:48 +0200)]
Typo
Arran Cudbard-Bell [Wed, 4 May 2022 12:25:22 +0000 (14:25 +0200)]
Avoid spurious output
Arran Cudbard-Bell [Wed, 4 May 2022 12:00:04 +0000 (14:00 +0200)]
Fixup jlibtool to allow crosscompilation without needing multiple versions of the binary
Arran Cudbard-Bell [Wed, 4 May 2022 10:14:08 +0000 (12:14 +0200)]
Control verbose flag passed to jlibtool
Alan T. DeKok [Tue, 3 May 2022 13:27:57 +0000 (15:27 +0200)]
print out build for jlibtool, etc.
Alan T. DeKok [Tue, 3 May 2022 12:20:28 +0000 (14:20 +0200)]
add "counter" flag for unsigned integers.
to enable more SNMP, and internal stats, along with automatic
aggregation of stats.
Alan T. DeKok [Tue, 3 May 2022 12:18:18 +0000 (14:18 +0200)]
show more structs
Arran Cudbard-Bell [Tue, 3 May 2022 07:52:24 +0000 (09:52 +0200)]
Revert "Fixup jlibtool to allow crosscompilation without needing multiple versions of the binary"
This reverts commit
83892e9c37da2de186afdc775e6438b02d5a35ad .
Alan T. DeKok [Tue, 3 May 2022 07:26:32 +0000 (09:26 +0200)]
export VERBOSE
Arran Cudbard-Bell [Mon, 2 May 2022 12:55:19 +0000 (14:55 +0200)]
FreeBSD uses the .so extension too
Arran Cudbard-Bell [Thu, 28 Apr 2022 18:20:12 +0000 (13:20 -0500)]
Fixup jlibtool to allow crosscompilation without needing multiple versions of the binary
github-actions[bot] [Mon, 2 May 2022 09:54:04 +0000 (09:54 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Mon, 2 May 2022 09:54:01 +0000 (09:54 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Mon, 2 May 2022 09:53:57 +0000 (09:53 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Mon, 2 May 2022 09:53:55 +0000 (09:53 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Mon, 2 May 2022 09:53:52 +0000 (09:53 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Mon, 2 May 2022 09:53:48 +0000 (09:53 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Mon, 2 May 2022 09:53:46 +0000 (09:53 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Mon, 2 May 2022 09:53:43 +0000 (09:53 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
James Jones [Fri, 29 Apr 2022 19:16:56 +0000 (14:16 -0500)]
Make minmax_heap_burn_in() exercise all operations (CID #
1503996 ) (#4478)
random choice of operation wasn't hitting all cases
James Jones [Fri, 29 Apr 2022 19:16:37 +0000 (14:16 -0500)]
Move assignment out of fr_assert_msg() to pacify Coverity (CID #
1504180 ) (#4479)
James Jones [Fri, 29 Apr 2022 19:15:36 +0000 (14:15 -0500)]
remove needless check of parent in parse_input() (CID #
1469153 (#4480)
Earlier in the code, parent->allow_unlang is tested; if parent
is NULL, it will break thre, so the later check is unnecessary.
James Jones [Fri, 29 Apr 2022 19:14:50 +0000 (14:14 -0500)]
Move use of name after NULL check in dict_by_protocol_substr (CID #
1503920 ) (#4481)
James Jones [Fri, 29 Apr 2022 12:34:30 +0000 (07:34 -0500)]
Remove needless NULL checks in cf_pair_parse_internal() (CID #
1469127 , #
1469144 ) (#4476)
array is checked for NULL, and an error returned if it is, before
the loop that fills the array, so the checks of it in the loop (and
also of entry, which can't be NULL either).