]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agoQuiet coverity (CID #1503969, #1504008) (#4475)
James Jones [Fri, 29 Apr 2022 12:34:07 +0000 (07:34 -0500)] 
Quiet coverity (CID #1503969, #1504008) (#4475)

timestr_match() converts time from the beginning of the week in
a struct tm to minutes. Coverity doesn't consider the bounds
on those values (tm_wday and tm_hour), and thus warns of possible
overflow.

4 years agosilence coverity complaint about possible overflow (CID #1469150) (#4474)
James Jones [Fri, 29 Apr 2022 12:33:43 +0000 (07:33 -0500)] 
silence coverity complaint about possible overflow (CID #1469150) (#4474)

4 years agoUpdate link to Cisco website (#4473)
NotAProfessionalDeveloper [Fri, 29 Apr 2022 12:32:24 +0000 (14:32 +0200)] 
Update link to Cisco website (#4473)

4 years agoCorrection to description of function return values (#4472)
James Jones [Fri, 29 Apr 2022 12:32:12 +0000 (07:32 -0500)] 
Correction to description of function return values (#4472)

4 years agoAdd ciena dictionary
Nick Porter [Fri, 29 Apr 2022 09:39:48 +0000 (10:39 +0100)] 
Add ciena dictionary

4 years agoset head->flags correctly, and other minor cleanups
Alan T. DeKok [Thu, 28 Apr 2022 15:39:22 +0000 (11:39 -0400)] 
set head->flags correctly, and other minor cleanups

don't set the flags repeatedly in xlat_tokenize_argv()

merge head->flags into input flags

4 years agojust call flatten_argv()
Alan T. DeKok [Thu, 28 Apr 2022 14:41:31 +0000 (10:41 -0400)] 
just call flatten_argv()

and update it's API to re-parent the nodes and free the input
list, so that there's no confusion about who owns what.

4 years agoparent things properly
Alan T. DeKok [Thu, 28 Apr 2022 14:41:04 +0000 (10:41 -0400)] 
parent things properly

4 years agoAdd covaro dictionary
Nick Porter [Thu, 28 Apr 2022 08:04:37 +0000 (09:04 +0100)] 
Add covaro dictionary

4 years agoFix potential leak (#4471)
Jorge Pereira [Thu, 28 Apr 2022 00:37:23 +0000 (21:37 -0300)] 
Fix potential leak (#4471)

4 years agofilter out for CFLAGS, too
Alan T. DeKok [Wed, 27 Apr 2022 22:37:03 +0000 (18:37 -0400)] 
filter out for CFLAGS, too

4 years agofilter out warnings for local targets, we don't care
Alan T. DeKok [Wed, 27 Apr 2022 22:07:37 +0000 (18:07 -0400)] 
filter out warnings for local targets, we don't care

4 years agouse HOST_CC
Alan T. DeKok [Wed, 27 Apr 2022 21:32:17 +0000 (17:32 -0400)] 
use HOST_CC

4 years agoRevert "Don't try and build the make support libraries if this is a WASM build.....
Alan T. DeKok [Wed, 27 Apr 2022 21:31:08 +0000 (17:31 -0400)] 
Revert "Don't try and build the make support libraries if this is a WASM build... we'll figure this out later"

This reverts commit 932bf41d78ab0c463446cdf46a8ac82812f0e2fc.

4 years agouse HOST_CC for jlibtool
Alan T. DeKok [Wed, 27 Apr 2022 21:28:39 +0000 (17:28 -0400)] 
use HOST_CC for jlibtool

as it's a local binary

4 years agomove xlat_exp_head_t to it's own data structure
Alan T. DeKok [Wed, 27 Apr 2022 17:18:22 +0000 (13:18 -0400)] 
move xlat_exp_head_t to it's own data structure

fmt and flags are not yet filled out

4 years agonode->fmt is already set above. Re-setting it mangles things
Alan T. DeKok [Wed, 27 Apr 2022 15:52:45 +0000 (11:52 -0400)] 
node->fmt is already set above.  Re-setting it mangles things

4 years agoAlternative source of sockaddr_ll for emscripten/musl
Arran Cudbard-Bell [Wed, 27 Apr 2022 20:31:54 +0000 (15:31 -0500)] 
Alternative source of sockaddr_ll for emscripten/musl

4 years agoIf we use the cache, then we don't populate CPPFLAGS on the cache run...
Arran Cudbard-Bell [Wed, 27 Apr 2022 20:30:43 +0000 (15:30 -0500)] 
If we use the cache, then we don't populate CPPFLAGS on the cache run...

4 years agoIgnore wasm build products
Arran Cudbard-Bell [Wed, 27 Apr 2022 19:48:15 +0000 (14:48 -0500)] 
Ignore wasm build products

4 years agoAdd support to jlibtool for emscripten, it's basically the same as Linux, right?
Arran Cudbard-Bell [Wed, 27 Apr 2022 19:48:05 +0000 (14:48 -0500)] 
Add support to jlibtool for emscripten, it's basically the same as Linux, right?

4 years agoEmscripten provides mallopt, but not the same knobs
Arran Cudbard-Bell [Wed, 27 Apr 2022 19:47:27 +0000 (14:47 -0500)] 
Emscripten provides mallopt, but not the same knobs

4 years agoDon't try and build the make support libraries if this is a WASM build... we'll figur...
Arran Cudbard-Bell [Wed, 27 Apr 2022 19:31:01 +0000 (14:31 -0500)] 
Don't try and build the make support libraries if this is a WASM build... we'll figure this out later

It involves using two compilers in the build process, and as EMSCRIPTEN mostly uses static linking, using dlopen to figure out symbol presence probably isn't going to work.  We'll need some higher level function that execs the wasm linker like configure does.

4 years agoMinor fixes for emscripten
Arran Cudbard-Bell [Wed, 27 Apr 2022 19:29:20 +0000 (14:29 -0500)] 
Minor fixes for emscripten

4 years agoRemove needless check for NULL fp (CID #1503900) (#4468)
James Jones [Wed, 27 Apr 2022 19:17:12 +0000 (14:17 -0500)] 
Remove needless check for NULL fp (CID #1503900) (#4468)

4 years agoRemove spurious debugging
Nick Porter [Wed, 27 Apr 2022 14:34:07 +0000 (15:34 +0100)] 
Remove spurious debugging

4 years agoAdd simultaneous use queries for MS SQL
Nick Porter [Wed, 27 Apr 2022 11:06:37 +0000 (12:06 +0100)] 
Add simultaneous use queries for MS SQL

4 years agoFix decoding of single TLV
Nick Porter [Wed, 27 Apr 2022 06:47:41 +0000 (07:47 +0100)] 
Fix decoding of single TLV

- use fr_dcursor_next_peek to check for multiple children so that the
cursor doesn't move
- extract the pair from the source list to append to the destination

4 years agoNew config.sub and config.guess
Arran Cudbard-Bell [Tue, 26 Apr 2022 13:58:31 +0000 (08:58 -0500)] 
New config.sub and config.guess

4 years agofix locking. Helps with #4465
Alan T. DeKok [Tue, 26 Apr 2022 13:00:34 +0000 (09:00 -0400)] 
fix locking.  Helps with #4465

4 years agorelease mutex before destroying it. Helps with #4465
Alan T. DeKok [Tue, 26 Apr 2022 13:00:07 +0000 (09:00 -0400)] 
release mutex before destroying it.  Helps with #4465

4 years agoFix potential leak on error
Arran Cudbard-Bell [Mon, 25 Apr 2022 17:06:04 +0000 (12:06 -0500)] 
Fix potential leak on error

4 years agoCorrect UB_EV_PERSIST check in _unbound_io_service_writable() (CID #1469157) (#4466)
James Jones [Mon, 25 Apr 2022 15:23:12 +0000 (10:23 -0500)] 
Correct UB_EV_PERSIST check in _unbound_io_service_writable() (CID #1469157) (#4466)

4 years agocrossbuild: update image prefix to remove clashes with v3
Matthew Newton [Sat, 23 Apr 2022 10:53:27 +0000 (11:53 +0100)] 
crossbuild: update image prefix to remove clashes with v3

4 years agodocker: tidy unused jenkins dockerfiles
Matthew Newton [Sat, 23 Apr 2022 10:26:11 +0000 (11:26 +0100)] 
docker: tidy unused jenkins dockerfiles

4 years agoAdd args back
Arran Cudbard-Bell [Sat, 23 Apr 2022 02:25:30 +0000 (21:25 -0500)] 
Add args back

4 years agoJust use fopen...
Arran Cudbard-Bell [Sat, 23 Apr 2022 01:18:41 +0000 (20:18 -0500)] 
Just use fopen...

4 years agoradmin isn't thread safe
Arran Cudbard-Bell [Fri, 22 Apr 2022 22:08:21 +0000 (17:08 -0500)] 
radmin isn't thread safe

4 years agoPassing back port via variables is not thread safe, so set a unique variable containi...
Arran Cudbard-Bell [Fri, 22 Apr 2022 21:38:42 +0000 (16:38 -0500)] 
Passing back port via variables is not thread safe, so set a unique variable containing the port for a given test suite

4 years agoMODULE_TEST_UNLANG is a path
Arran Cudbard-Bell [Fri, 22 Apr 2022 21:06:53 +0000 (16:06 -0500)] 
MODULE_TEST_UNLANG is a path

4 years agonot yet for this
Alan T. DeKok [Fri, 22 Apr 2022 20:53:46 +0000 (16:53 -0400)] 
not yet for this

4 years agoHorrible hacks to get EAPOL tests to run in parallel
Arran Cudbard-Bell [Fri, 22 Apr 2022 20:49:05 +0000 (15:49 -0500)] 
Horrible hacks to get EAPOL tests to run in parallel

4 years agoFix radclient tests for parallel execution
Arran Cudbard-Bell [Fri, 22 Apr 2022 17:52:29 +0000 (12:52 -0500)] 
Fix radclient tests for parallel execution

4 years agoAllow the secret and base port to be overridden from the shell
Arran Cudbard-Bell [Fri, 22 Apr 2022 17:26:56 +0000 (12:26 -0500)] 
Allow the secret and base port to be overridden from the shell

4 years agoUse the PID file to identify unique instances of FreeRADIUS if it's set
Arran Cudbard-Bell [Fri, 22 Apr 2022 17:21:24 +0000 (12:21 -0500)] 
Use the PID file to identify unique instances of FreeRADIUS if it's set

4 years agoGet rid of superfluous test in loop in command_encode_dns_label (#4463)
James Jones [Fri, 22 Apr 2022 20:23:51 +0000 (15:23 -0500)] 
Get rid of superfluous test in loop in command_encode_dns_label (#4463)

By virtue of CC_HINT(nonnull), in, and hence p, will be non-NULL
the first time through the loop. To take another iteration, next
must be non-NULL, so that p, set to next + 1, will also be non-NULL;
hence the "while (p)" is effectively "while (true)".

4 years agotypo
Alan T. DeKok [Fri, 22 Apr 2022 20:21:41 +0000 (16:21 -0400)] 
typo

4 years agouse correct data type
Alan T. DeKok [Fri, 22 Apr 2022 19:37:17 +0000 (15:37 -0400)] 
use correct data type

4 years agomove encode_array() to common function
Alan T. DeKok [Fri, 22 Apr 2022 19:14:02 +0000 (15:14 -0400)] 
move encode_array() to common function

which further shrinks and simplifies the protocol-specific
encoders.

4 years agonone of this is used, so change it to void*
Alan T. DeKok [Fri, 22 Apr 2022 18:58:58 +0000 (14:58 -0400)] 
none of this is used, so change it to void*

4 years agocatch the case of zero returns
Alan T. DeKok [Fri, 22 Apr 2022 14:49:21 +0000 (10:49 -0400)] 
catch the case of zero returns

it's either allowed, and we do nothing, or it means that we didn't
decode any data, and the input is malformed

4 years agooptions can have zero data
Alan T. DeKok [Fri, 22 Apr 2022 14:48:42 +0000 (10:48 -0400)] 
options can have zero data

4 years agoadd fake xlat_exp_head_t, which is just xlat_exp_t for now
Alan T. DeKok [Thu, 21 Apr 2022 17:43:29 +0000 (13:43 -0400)] 
add fake xlat_exp_head_t, which is just xlat_exp_t for now

and update function signatures, etc. to use it.  In preparation
for moving to tlists

4 years agodon't do N^2 checks
Alan T. DeKok [Thu, 21 Apr 2022 17:33:01 +0000 (13:33 -0400)] 
don't do N^2 checks

we just need to check if it's a value box,
xlat_is_literal() will check all subsequent nodes, and we don't
want that.

4 years agoFix parallel tests for sqlite, and enable parallel testing
Arran Cudbard-Bell [Fri, 22 Apr 2022 14:42:10 +0000 (09:42 -0500)] 
Fix parallel tests for sqlite, and enable parallel testing

4 years agoCheck fr_event_fd_insert() return value. CID #1469154 (#4461)
James Jones [Thu, 21 Apr 2022 19:18:38 +0000 (14:18 -0500)] 
Check fr_event_fd_insert() return value. CID #1469154 (#4461)

4 years agoAdd temporary thread local dbuff buffers too
Arran Cudbard-Bell [Thu, 21 Apr 2022 16:48:10 +0000 (11:48 -0500)] 
Add temporary thread local dbuff buffers too

4 years agotypo
Alan T. DeKok [Thu, 21 Apr 2022 13:56:28 +0000 (09:56 -0400)] 
typo

4 years agofor length fields, just limit work_dbuff
Alan T. DeKok [Wed, 20 Apr 2022 21:16:13 +0000 (17:16 -0400)] 
for length fields, just limit work_dbuff

instead of encoding "too much" and checking for it later

4 years agodon't need release if we also dump the parent dbuff
Alan T. DeKok [Wed, 20 Apr 2022 21:05:37 +0000 (17:05 -0400)] 
don't need release if we also dump the parent dbuff

4 years agoThese are technically linker flags
Arran Cudbard-Bell [Thu, 21 Apr 2022 13:41:53 +0000 (08:41 -0500)] 
These are technically linker flags

4 years agouse marker instead of entire dbuff
Alan T. DeKok [Wed, 20 Apr 2022 20:30:56 +0000 (16:30 -0400)] 
use marker instead of entire dbuff

4 years agomore cleanups to use macros instead of hard-coded fields
Alan T. DeKok [Wed, 20 Apr 2022 20:22:12 +0000 (16:22 -0400)] 
more cleanups to use macros instead of hard-coded fields

4 years agomove to macros for more things, instead of directly accessing fields
Alan T. DeKok [Wed, 20 Apr 2022 19:36:54 +0000 (15:36 -0400)] 
move to macros for more things, instead of directly accessing fields

in preparation for moving to tlists.

4 years agoclean up and rename
Alan T. DeKok [Wed, 20 Apr 2022 16:09:57 +0000 (12:09 -0400)] 
clean up and rename

4 years agoErrant \
Arran Cudbard-Bell [Wed, 20 Apr 2022 17:12:14 +0000 (12:12 -0500)] 
Errant \

4 years agoAlways print out the config.log
Arran Cudbard-Bell [Wed, 20 Apr 2022 16:58:10 +0000 (11:58 -0500)] 
Always print out the config.log

4 years agomove function args and groups to their own members
Alan T. DeKok [Wed, 20 Apr 2022 15:17:51 +0000 (11:17 -0400)] 
move function args and groups to their own members

in preparation for moving to tlists

4 years agomove XLAT_ALTERNATE children to type-specific fields
Alan T. DeKok [Wed, 20 Apr 2022 14:47:22 +0000 (10:47 -0400)] 
move XLAT_ALTERNATE children to type-specific fields

4 years agocheck lengths, too
Alan T. DeKok [Wed, 20 Apr 2022 12:49:21 +0000 (08:49 -0400)] 
check lengths, too

4 years agoadd verify_tlvs() function
Alan T. DeKok [Tue, 19 Apr 2022 21:58:56 +0000 (17:58 -0400)] 
add verify_tlvs() function

so we don't go crazy creating structures, only to throw them
away when we discover that something bad is going on

4 years agominor cleanups
Alan T. DeKok [Tue, 19 Apr 2022 21:33:31 +0000 (17:33 -0400)] 
minor cleanups

and create raw attributes, instead of just unknown ones for
things we don't understand

4 years agoadd option to print out VPs it's decoded
Alan T. DeKok [Tue, 19 Apr 2022 21:32:30 +0000 (17:32 -0400)] 
add option to print out VPs it's decoded

4 years agominor rearrangements
Alan T. DeKok [Tue, 19 Apr 2022 18:46:23 +0000 (14:46 -0400)] 
minor rearrangements

4 years agoremove unused assignments
Alan T. DeKok [Tue, 19 Apr 2022 18:45:49 +0000 (14:45 -0400)] 
remove unused assignments

4 years agoshut up compiler
Alan T. DeKok [Tue, 19 Apr 2022 18:38:41 +0000 (14:38 -0400)] 
shut up compiler

4 years agoincrease bounds
Alan T. DeKok [Tue, 19 Apr 2022 18:07:59 +0000 (14:07 -0400)] 
increase bounds

4 years agoinitialize slen
Alan T. DeKok [Tue, 19 Apr 2022 17:23:04 +0000 (13:23 -0400)] 
initialize slen

4 years agofix function signature to shut up compiler
Alan T. DeKok [Tue, 19 Apr 2022 16:25:35 +0000 (12:25 -0400)] 
fix function signature to shut up compiler

4 years agodecode all extended attributes at the top level
Alan T. DeKok [Tue, 19 Apr 2022 15:40:44 +0000 (11:40 -0400)] 
decode all extended attributes at the top level

4 years agoremove "concat" flag from Digest-Attributes
Alan T. DeKok [Tue, 19 Apr 2022 15:31:15 +0000 (11:31 -0400)] 
remove "concat" flag from Digest-Attributes

it's not really "concat" in the same way that EAP-Message is,
as we can't split it in the middle of sub TLVs.

4 years agostart of rewrite to be more like the other protocols
Alan T. DeKok [Tue, 19 Apr 2022 15:29:05 +0000 (11:29 -0400)] 
start of rewrite to be more like the other protocols

4 years agoadd fr_pair_dns_labels_from_network()
Alan T. DeKok [Tue, 19 Apr 2022 01:09:01 +0000 (21:09 -0400)] 
add fr_pair_dns_labels_from_network()

and make various protocols call it.

4 years agofix test.
Alan T. DeKok [Mon, 18 Apr 2022 21:24:25 +0000 (17:24 -0400)] 
fix test.

When we encode something, the decoded version should NOT be "raw"
unless something has gone seriously wrong.

4 years agomove decode_tlvs to common API
Alan T. DeKok [Mon, 18 Apr 2022 15:46:11 +0000 (11:46 -0400)] 
move decode_tlvs to common API

with a flag to see if we decode the TLVs as nested (or not)

4 years agoadd notes for DNS validation
Alan T. DeKok [Mon, 18 Apr 2022 15:45:53 +0000 (11:45 -0400)] 
add notes for DNS validation

4 years agomove to using fr_pair_raw_from_network()
Alan T. DeKok [Sun, 17 Apr 2022 23:24:08 +0000 (19:24 -0400)] 
move to using fr_pair_raw_from_network()

Insted of multiple local functions

4 years agomake fr_pair_raw_from_network() closer to other decode functions
Alan T. DeKok [Sun, 17 Apr 2022 23:16:45 +0000 (19:16 -0400)] 
make fr_pair_raw_from_network() closer to other decode functions

4 years agomove / rename "pair raw from network"
Alan T. DeKok [Sun, 17 Apr 2022 19:19:58 +0000 (15:19 -0400)] 
move / rename "pair raw from network"

so that it's in a better place, with a better name

4 years agobreak out some more test cases for clarity
Alan T. DeKok [Sun, 17 Apr 2022 19:11:38 +0000 (15:11 -0400)] 
break out some more test cases for clarity

4 years agomove decode_array() to generic fr_pair_array_from_network()
Alan T. DeKok [Sun, 17 Apr 2022 18:37:37 +0000 (14:37 -0400)] 
move decode_array() to generic fr_pair_array_from_network()

4 years agoalign fr_value_box_network_length() with to/from-network code
Alan T. DeKok [Sun, 17 Apr 2022 16:39:45 +0000 (12:39 -0400)] 
align fr_value_box_network_length() with to/from-network code

4 years agoalign encode_array() with other protocols
Alan T. DeKok [Sun, 17 Apr 2022 16:34:54 +0000 (12:34 -0400)] 
align encode_array() with other protocols

and remove yet another protocol-specific "get attr length" function

4 years agoclarify documention in to/from network functions
Alan T. DeKok [Sun, 17 Apr 2022 14:30:47 +0000 (10:30 -0400)] 
clarify documention in to/from network functions

4 years agoremove attr_sizes table and usage
Alan T. DeKok [Sun, 17 Apr 2022 14:08:58 +0000 (10:08 -0400)] 
remove attr_sizes table and usage

only the type-specific decoders need to care

4 years agoremove dead code. CID #1469168
Alan T. DeKok [Sun, 17 Apr 2022 13:45:12 +0000 (09:45 -0400)] 
remove dead code.  CID #1469168

4 years agotry to shut up coverity
Alan T. DeKok [Sun, 17 Apr 2022 05:59:46 +0000 (01:59 -0400)] 
try to shut up coverity

which thinks that fr_token_t can be between 0..63, instead of
0..48?

4 years agoremove fr_radius_attr_len() and related checks
Alan T. DeKok [Sun, 17 Apr 2022 05:50:50 +0000 (01:50 -0400)] 
remove fr_radius_attr_len() and related checks

we can just either (a) rely on the input dbuff to see when the
data is too long to encode, or (b) just check vp->vp_length

4 years agojust call fr_value_box_to_network()
Alan T. DeKok [Sun, 17 Apr 2022 05:36:54 +0000 (01:36 -0400)] 
just call fr_value_box_to_network()

4 years agoremove unused code
Alan T. DeKok [Sun, 17 Apr 2022 05:28:54 +0000 (01:28 -0400)] 
remove unused code