]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agoNotes on stdin cleanup
Arran Cudbard-Bell [Sat, 28 Aug 2021 00:10:26 +0000 (19:10 -0500)] 
Notes on stdin cleanup

4 years agoFix spurious warning
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:59:48 +0000 (18:59 -0500)] 
Fix spurious warning

4 years agoFix minor build errors
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:11:41 +0000 (18:11 -0500)] 
Fix minor build errors

4 years agopid is signed, so give it a default value of -1
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:05:13 +0000 (18:05 -0500)] 
pid is signed, so give it a default value of -1

4 years agoDeal with race between EVFILT_READ and EVFILT_PROC
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:01:59 +0000 (18:01 -0500)] 
Deal with race between EVFILT_READ and EVFILT_PROC

If EVFILT_PROC is delivered first we may never end up reading pending stdout/stderr data.

4 years agoDeal with EWOULDBLOCK gracefully in log_request_fd_event
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:00:58 +0000 (18:00 -0500)] 
Deal with EWOULDBLOCK gracefully in log_request_fd_event

4 years agoCalling __builtin_clzll with a 0 value is undefined (and it does the wrong thing)
Arran Cudbard-Bell [Fri, 27 Aug 2021 22:56:26 +0000 (17:56 -0500)] 
Calling __builtin_clzll with a 0 value is undefined (and it does the wrong thing)

4 years agoAllow users of event.c to get at the callbacks registered
Arran Cudbard-Bell [Fri, 27 Aug 2021 22:55:55 +0000 (17:55 -0500)] 
Allow users of event.c to get at the callbacks registered

This is mainly for the exec code so it can manually call the read callbacks before processes exit.

4 years agoAdd atexit.h macro for doing automatic initialisation and freeing of global resources
Arran Cudbard-Bell [Fri, 27 Aug 2021 22:52:14 +0000 (17:52 -0500)] 
Add atexit.h macro for doing automatic initialisation and freeing of global resources

Should be much cheaper than pthread_once

4 years agoAdjust initial LST pivot stack size in accordance with initial size (#4213)
James Jones [Fri, 27 Aug 2021 15:44:41 +0000 (10:44 -0500)] 
Adjust initial LST pivot stack size in accordance with initial size (#4213)

It's now initially max(1, log2(initial array size)).

4 years agoorder requests by sequence number, too
Alan T. DeKok [Fri, 27 Aug 2021 14:57:40 +0000 (10:57 -0400)] 
order requests by sequence number, too

4 years agopass fr_io_track_t to track_create function
Alan T. DeKok [Fri, 27 Aug 2021 14:40:29 +0000 (10:40 -0400)] 
pass fr_io_track_t to track_create function

so that we can free old tracking entries by just talloc_free'ing
them

4 years agopass instance / thread instance to track_create
Alan T. DeKok [Fri, 27 Aug 2021 14:22:14 +0000 (10:22 -0400)] 
pass instance / thread instance to track_create

in preparation for doing more aggressive cleanups of tracking
entries

4 years agoFix error marker check
Arran Cudbard-Bell [Fri, 27 Aug 2021 14:53:00 +0000 (09:53 -0500)] 
Fix error marker check

4 years agoMake lst_validate() consistent with current lst functions and types (#4212)
James Jones [Fri, 27 Aug 2021 04:30:45 +0000 (23:30 -0500)] 
Make lst_validate() consistent with current lst functions and types (#4212)

4 years agoRemove LOCAL_PID hacks, we'll reimplement it in libkqueue
Arran Cudbard-Bell [Fri, 27 Aug 2021 01:12:39 +0000 (20:12 -0500)] 
Remove LOCAL_PID hacks, we'll reimplement it in libkqueue

4 years agoFix event_timer_location_cmp
Arran Cudbard-Bell [Thu, 26 Aug 2021 23:32:46 +0000 (23:32 +0000)] 
Fix event_timer_location_cmp

4 years agoAdd init parameter to LST creation closes #4210
James Jones [Thu, 26 Aug 2021 16:02:56 +0000 (11:02 -0500)] 
Add init parameter to LST creation closes #4210

The parameter determines the initial capacity choice: 0 will get
the default initial capacity, while any other value will be rounded
up to a power of 2 and used as the initial capacity.

4 years agoMeant to revert the other commit
Arran Cudbard-Bell [Thu, 26 Aug 2021 18:32:49 +0000 (13:32 -0500)] 
Meant to revert the other commit

This reverts commit f1760b1302a00524c3a8cf6298b0bb0b5ea53524.

4 years agoit's now fr_unix_time_from_tm()
Alan T. DeKok [Wed, 25 Aug 2021 21:17:26 +0000 (17:17 -0400)] 
it's now fr_unix_time_from_tm()

all of the uses of it either set the time zone, or used mktime()
and then called fr_unix_time_from_timeval().  So to simplify things,
we just use fr_unix_time_from_tm()

4 years agochange to passing CONF_SECTION, and publish it
Alan T. DeKok [Wed, 25 Aug 2021 15:57:04 +0000 (11:57 -0400)] 
change to passing CONF_SECTION, and publish it

4 years agoupdate initializer
Alan T. DeKok [Wed, 25 Aug 2021 15:50:54 +0000 (11:50 -0400)] 
update initializer

4 years agopass actions to compile function
Alan T. DeKok [Wed, 25 Aug 2021 15:34:21 +0000 (11:34 -0400)] 
pass actions to compile function

in preparation for making it public

4 years agoparse "retry" subsection of "actions"
Alan T. DeKok [Wed, 25 Aug 2021 15:03:38 +0000 (11:03 -0400)] 
parse "retry" subsection of "actions"

4 years agoadd "retry" subsection to actions
Alan T. DeKok [Wed, 25 Aug 2021 13:06:23 +0000 (09:06 -0400)] 
add "retry" subsection to actions

4 years agomacro to initialize data structure
Alan T. DeKok [Wed, 25 Aug 2021 13:04:58 +0000 (09:04 -0400)] 
macro to initialize data structure

4 years agoMore fr_time_from_utc fixes
Arran Cudbard-Bell [Wed, 25 Aug 2021 20:56:10 +0000 (15:56 -0500)] 
More fr_time_from_utc fixes

4 years agoAdd safety check for mod_post_auth
Arran Cudbard-Bell [Wed, 25 Aug 2021 20:51:45 +0000 (15:51 -0500)] 
Add safety check  for mod_post_auth

4 years agoRemove perl keyword test
Arran Cudbard-Bell [Wed, 25 Aug 2021 19:17:15 +0000 (14:17 -0500)] 
Remove perl keyword test

4 years agoMove perl xlat tests into the module module
Arran Cudbard-Bell [Wed, 25 Aug 2021 18:57:14 +0000 (13:57 -0500)] 
Move perl xlat tests into the module module

4 years agoOptional modules shouldn't be in keywords
Arran Cudbard-Bell [Wed, 25 Aug 2021 18:29:41 +0000 (13:29 -0500)] 
Optional modules shouldn't be in keywords

4 years agoFix sign issue with unix time conversions
Arran Cudbard-Bell [Wed, 25 Aug 2021 18:02:45 +0000 (13:02 -0500)] 
Fix sign issue with unix time conversions

4 years agoFix unbound timeouts
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:57:48 +0000 (11:57 -0500)] 
Fix unbound timeouts

4 years agoAllow xlat calls without instance data
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:47:05 +0000 (11:47 -0500)] 
Allow xlat calls without instance data

4 years agoMore helpful TLS alert messages
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:46:51 +0000 (11:46 -0500)] 
More helpful TLS alert messages

4 years agoMove tls/utils functions into a new header
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:44:24 +0000 (11:44 -0500)] 
Move tls/utils functions into a new header

4 years agoAdd cf_log_pwarn
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:43:19 +0000 (11:43 -0500)] 
Add cf_log_pwarn

4 years agoOur version of unix time can't be negaitve
Arran Cudbard-Bell [Wed, 25 Aug 2021 02:50:03 +0000 (21:50 -0500)] 
Our version of unix time can't be negaitve

4 years agoSimpler way of getting the serial
Arran Cudbard-Bell [Wed, 25 Aug 2021 02:37:28 +0000 (21:37 -0500)] 
Simpler way of getting the serial

4 years agoCorrect uses of fr_time_from_utc
Arran Cudbard-Bell [Wed, 25 Aug 2021 02:37:00 +0000 (21:37 -0500)] 
Correct uses of fr_time_from_utc

4 years agoVerify certificates are valid
Arran Cudbard-Bell [Wed, 25 Aug 2021 02:11:57 +0000 (21:11 -0500)] 
Verify certificates are valid

Check certificate validity periods explicitly for lib/tls users and rlm_cipher

Add %(<inst>_certificate:notBefore) and %(<inst>_certificate:notAfter)

4 years agomove actions to struct
Alan T. DeKok [Wed, 25 Aug 2021 12:57:48 +0000 (08:57 -0400)] 
move actions to struct

4 years agobetter error messages. Fixes #4204
Alan T. DeKok [Wed, 25 Aug 2021 12:54:42 +0000 (08:54 -0400)] 
better error messages.  Fixes #4204

4 years agomove actions to struct
Alan T. DeKok [Wed, 25 Aug 2021 12:26:35 +0000 (08:26 -0400)] 
move actions to struct

4 years agouse typedef to simplify things
Alan T. DeKok [Wed, 25 Aug 2021 12:23:23 +0000 (08:23 -0400)] 
use typedef to simplify things

4 years agothis is "abinary"
Alan T. DeKok [Wed, 25 Aug 2021 12:16:05 +0000 (08:16 -0400)] 
this is "abinary"

ported manually from v3

4 years agoFix typo (#4208)
Jorge Pereira [Wed, 25 Aug 2021 12:06:59 +0000 (09:06 -0300)] 
Fix typo (#4208)

4 years agoAdd assert to reassure (or shut up) "make scan" (#4206)
James Jones [Tue, 24 Aug 2021 13:10:34 +0000 (08:10 -0500)] 
Add assert to reassure (or shut up) "make scan" (#4206)

4 years agoUse CMP() in _trunk_connection_order_by_shortest_queue() (#4205)
James Jones [Tue, 24 Aug 2021 12:50:44 +0000 (07:50 -0500)] 
Use CMP() in  _trunk_connection_order_by_shortest_queue() (#4205)

4 years agoenforce response_window only for synchronous requests
Alan T. DeKok [Mon, 23 Aug 2021 20:27:47 +0000 (16:27 -0400)] 
enforce response_window only for synchronous requests

4 years agoremove unused variables
Alan T. DeKok [Mon, 23 Aug 2021 20:22:41 +0000 (16:22 -0400)] 
remove unused variables

4 years agorework to respect response_window, etc.
Alan T. DeKok [Mon, 23 Aug 2021 19:49:59 +0000 (15:49 -0400)] 
rework to respect response_window, etc.

4 years agoadd and document response_window
Alan T. DeKok [Mon, 23 Aug 2021 18:41:25 +0000 (14:41 -0400)] 
add and document response_window

4 years agofix typo
Alan T. DeKok [Mon, 23 Aug 2021 18:17:14 +0000 (14:17 -0400)] 
fix typo

4 years agocleanups and corner conditions for deferred transitions
Alan T. DeKok [Mon, 23 Aug 2021 17:19:47 +0000 (13:19 -0400)] 
cleanups and corner conditions for deferred transitions

4 years agoadd support for multiple deferred state transitions
Alan T. DeKok [Mon, 23 Aug 2021 15:27:28 +0000 (11:27 -0400)] 
add support for multiple deferred state transitions

4 years agoadd signal handler
Alan T. DeKok [Thu, 19 Aug 2021 14:23:51 +0000 (10:23 -0400)] 
add signal handler

4 years agoData usage for MySQL: Run SP as invoker not definer (#4201)
Terry Burton [Fri, 20 Aug 2021 18:49:54 +0000 (19:49 +0100)] 
Data usage for MySQL: Run SP as invoker not definer (#4201)

4 years agoUsage schema extension for SQLite: Typo (#4199)
Terry Burton [Fri, 20 Aug 2021 18:49:37 +0000 (19:49 +0100)] 
Usage schema extension for SQLite: Typo (#4199)

Typo in 4c67d412956d2efed8b6ab4f216eb49abf3119c5 component of PR #3635.

4 years agoFix fr_machine_s
Arran Cudbard-Bell [Thu, 19 Aug 2021 13:14:56 +0000 (08:14 -0500)] 
Fix fr_machine_s

4 years agoRevert "LSTs likely slower when used here"
Arran Cudbard-Bell [Thu, 19 Aug 2021 02:54:05 +0000 (21:54 -0500)] 
Revert "LSTs likely slower when used here"

This reverts commit 6a88d68e3e5c4398e7feee501a855ea84a57633d.

4 years agoFree the heap
Arran Cudbard-Bell [Thu, 19 Aug 2021 01:13:47 +0000 (20:13 -0500)] 
Free the heap

4 years agoNeeds to be alloced in hp not ctx
Arran Cudbard-Bell [Thu, 19 Aug 2021 00:44:33 +0000 (19:44 -0500)] 
Needs to be alloced in hp not ctx

4 years agoShouldn't need to specify ctx... but maybe this will fix the leak?
Arran Cudbard-Bell [Thu, 19 Aug 2021 00:04:52 +0000 (19:04 -0500)] 
Shouldn't need to specify ctx... but maybe this will fix the leak?

4 years agoMove array pop code to function and prevent it being inlined
Arran Cudbard-Bell [Wed, 18 Aug 2021 22:17:48 +0000 (17:17 -0500)] 
Move array pop code to function and prevent it being inlined

4 years agoNot sure how that got there...
Arran Cudbard-Bell [Wed, 18 Aug 2021 22:14:15 +0000 (17:14 -0500)] 
Not sure how that got there...

4 years agoRecord first pop
Arran Cudbard-Bell [Wed, 18 Aug 2021 20:34:46 +0000 (15:34 -0500)] 
Record first pop

4 years ago"init" parameter isn't in LST alloc functions yet (#4195)
James Jones [Wed, 18 Aug 2021 22:12:30 +0000 (17:12 -0500)] 
"init" parameter isn't in LST alloc functions yet (#4195)

4 years agoMore fixes
Arran Cudbard-Bell [Wed, 18 Aug 2021 18:33:26 +0000 (13:33 -0500)] 
More fixes

4 years agoLess confusing way of representing struct fr_heap_s **
Arran Cudbard-Bell [Wed, 18 Aug 2021 18:25:07 +0000 (13:25 -0500)] 
Less confusing way of representing struct fr_heap_s **

4 years agoLSTs likely faster here
Arran Cudbard-Bell [Wed, 18 Aug 2021 18:10:09 +0000 (13:10 -0500)] 
LSTs likely faster here

4 years agoFix heap tests
Arran Cudbard-Bell [Wed, 18 Aug 2021 18:06:18 +0000 (13:06 -0500)] 
Fix heap tests

4 years agoLSTs likely slower when used here
Arran Cudbard-Bell [Wed, 18 Aug 2021 17:27:43 +0000 (12:27 -0500)] 
LSTs likely slower when used here

This reverts commit c59a612b93a55b130ea5fea768c76f6c661b17e0.

4 years agoFix up queue cmp tests
Arran Cudbard-Bell [Wed, 18 Aug 2021 17:26:55 +0000 (12:26 -0500)] 
Fix up queue cmp tests

4 years agoHigher memory locality gives significant performance gains for small numbers of heap...
Arran Cudbard-Bell [Wed, 18 Aug 2021 16:57:29 +0000 (11:57 -0500)] 
Higher memory locality gives significant performance gains for small numbers of heap elements

4 years agoforce link errors on OSX for unknown symbols
Alan T. DeKok [Wed, 18 Aug 2021 15:51:35 +0000 (11:51 -0400)] 
force link errors on OSX for unknown symbols

When linking binaries.  So that we get errors at compile time,
and not at run-time, or even later in CI tests.

4 years agoLink to the crypt library
Arran Cudbard-Bell [Wed, 18 Aug 2021 15:36:50 +0000 (10:36 -0500)] 
Link to the crypt library

4 years agoMinor tweaks
Arran Cudbard-Bell [Wed, 18 Aug 2021 15:11:49 +0000 (10:11 -0500)] 
Minor tweaks

4 years agocast function pointers to void*
Alan T. DeKok [Wed, 18 Aug 2021 14:42:45 +0000 (10:42 -0400)] 
cast function pointers to void*

because we're using them as placeholders.  We don't actually
care what they are

4 years agouse [] instead of [0]
Alan T. DeKok [Wed, 18 Aug 2021 14:42:16 +0000 (10:42 -0400)] 
use [] instead of [0]

4 years agoAdd lst/heap comprison test
Arran Cudbard-Bell [Wed, 18 Aug 2021 14:39:37 +0000 (09:39 -0500)] 
Add lst/heap comprison test

4 years agoTypo
Arran Cudbard-Bell [Wed, 18 Aug 2021 14:39:02 +0000 (09:39 -0500)] 
Typo

4 years agoinitial stab at generic state machine handler.
Alan T. DeKok [Wed, 18 Aug 2021 14:06:55 +0000 (10:06 -0400)] 
initial stab at generic state machine handler.

4 years agoshould not have been committed
Alan T. DeKok [Mon, 16 Aug 2021 20:24:36 +0000 (16:24 -0400)] 
should not have been committed

4 years agoMove crypt code into rlm_pap
Arran Cudbard-Bell [Wed, 18 Aug 2021 03:05:57 +0000 (22:05 -0500)] 
Move crypt code into rlm_pap

4 years agoUnused
Arran Cudbard-Bell [Wed, 18 Aug 2021 02:59:30 +0000 (21:59 -0500)] 
Unused

4 years agoFix indent
Arran Cudbard-Bell [Wed, 18 Aug 2021 02:57:42 +0000 (21:57 -0500)] 
Fix indent

4 years agoSwitch to unsigned type for fr_lst_index_t (#4190)
James Jones [Wed, 18 Aug 2021 02:27:00 +0000 (21:27 -0500)] 
Switch to unsigned type for fr_lst_index_t (#4190)

* Switch to unsigned type for fr_lst_index_t

This involves adding one to the true index when storing it in an
item, and subtracting one when reading it for use.

* Switch to unsigned type for fr_lst_index_t

This involves adding one to the true index when storing it in an
item, and subtracting one when reading it for use.

* Switch to unsigned type for fr_lst_index_t

This involves adding one to the true index when storing it in an
item, and subtracting one when reading it for use.

4 years agoRe-enable support for TLS 1.0 fixes #4191
Arran Cudbard-Bell [Wed, 18 Aug 2021 02:26:00 +0000 (21:26 -0500)] 
Re-enable support for TLS 1.0 fixes #4191

4 years agoAllocate the stack as part of the lst structure
Arran Cudbard-Bell [Wed, 18 Aug 2021 00:34:02 +0000 (19:34 -0500)] 
Allocate the stack as part of the lst structure

4 years agoControl the initial number of elements in a heap
Arran Cudbard-Bell [Tue, 17 Aug 2021 21:01:18 +0000 (16:01 -0500)] 
Control the initial number of elements in a heap

4 years agoSprinkle more unlikelys
Arran Cudbard-Bell [Tue, 17 Aug 2021 19:10:46 +0000 (14:10 -0500)] 
Sprinkle more unlikelys

4 years agoSprinkle unlikely
Arran Cudbard-Bell [Tue, 17 Aug 2021 19:06:23 +0000 (14:06 -0500)] 
Sprinkle unlikely

4 years agoPre-allocate LST stack memory
Arran Cudbard-Bell [Tue, 17 Aug 2021 17:50:17 +0000 (12:50 -0500)] 
Pre-allocate LST stack memory

This is mostly to ensure good locality

4 years agoDo talloc type checking if we have one set
Arran Cudbard-Bell [Tue, 17 Aug 2021 16:57:36 +0000 (11:57 -0500)] 
Do talloc type checking if we have one set

4 years agoUse a consistent type for representing stack indexes
Arran Cudbard-Bell [Tue, 17 Aug 2021 16:52:47 +0000 (11:52 -0500)] 
Use a consistent type for representing stack indexes

No reason for stack indexes to be signed.  There are no negative indexes.

4 years agoAdd explicit bracketing
Arran Cudbard-Bell [Tue, 17 Aug 2021 16:27:16 +0000 (11:27 -0500)] 
Add explicit bracketing

4 years agoMinor style fixes
Arran Cudbard-Bell [Tue, 17 Aug 2021 16:22:05 +0000 (11:22 -0500)] 
Minor style fixes

Doxygen function headers must start with /**

4 years agoMark up iterators as nonnull and move doxygen comments to source file
Arran Cudbard-Bell [Tue, 17 Aug 2021 16:21:43 +0000 (11:21 -0500)] 
Mark up iterators as nonnull and move doxygen comments to source file

4 years agoNumber of elements and size tracking should be unsigned integers
Arran Cudbard-Bell [Tue, 17 Aug 2021 16:20:49 +0000 (11:20 -0500)] 
Number of elements and size tracking should be unsigned integers