]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agonormalize error messages. fixes #4239
Alan T. DeKok [Wed, 22 Sep 2021 00:46:49 +0000 (20:46 -0400)] 
normalize error messages.  fixes #4239

and return on failure.

4 years agoupdates and notes from Nokia
Alan T. DeKok [Tue, 21 Sep 2021 20:44:31 +0000 (16:44 -0400)] 
updates and notes from Nokia

https://infocenter.nokia.com/public/7750SR150R5A/index.jsp?topic=%2Fcom.sr.radius%2Fhtml%2Fsros_radius_attrib.html

4 years agolet's do unlang thread initialization *after* loading virtual servers.
Alan T. DeKok [Tue, 21 Sep 2021 20:03:19 +0000 (16:03 -0400)] 
let's do unlang thread initialization *after* loading virtual servers.

4 years agocomment out perf stuff until we find out why it crashes
Alan T. DeKok [Tue, 21 Sep 2021 19:13:58 +0000 (15:13 -0400)] 
comment out perf stuff until we find out why it crashes

4 years agofix format options
Alan T. DeKok [Tue, 21 Sep 2021 17:24:40 +0000 (13:24 -0400)] 
fix format options

4 years agoprint out stats in a hokey format
Alan T. DeKok [Tue, 21 Sep 2021 16:53:56 +0000 (12:53 -0400)] 
print out stats in a hokey format

we can always change it later

4 years agostart numbering at 1
Alan T. DeKok [Tue, 21 Sep 2021 14:53:57 +0000 (10:53 -0400)] 
start numbering at 1

some "internal" instructions are build dynamically, as with
unlang_module_push().  The instruction number there will be
zero, as there's currently no way to track these dynamic instructions.

As a result, we want to reserve array entry 0 as the canonical
"dynamic" instruction number, which won't get their stats tracked.

4 years agoDon't double advance
Arran Cudbard-Bell [Tue, 21 Sep 2021 14:26:32 +0000 (09:26 -0500)] 
Don't double advance

4 years agoadd per-thread instantiation for unlang
Alan T. DeKok [Tue, 21 Sep 2021 13:06:43 +0000 (09:06 -0400)] 
add per-thread instantiation for unlang

and glue it into the various binaries

4 years agoUnwrap fr_value_box_from_network
Arran Cudbard-Bell [Tue, 21 Sep 2021 13:02:32 +0000 (08:02 -0500)] 
Unwrap fr_value_box_from_network

4 years agoFix redis ippool tests
Arran Cudbard-Bell [Mon, 20 Sep 2021 23:09:41 +0000 (18:09 -0500)] 
Fix redis ippool tests

4 years agoAllowing copying NULL boxes
Arran Cudbard-Bell [Mon, 20 Sep 2021 23:02:26 +0000 (18:02 -0500)] 
Allowing copying NULL boxes

4 years agoRemove debugging
Arran Cudbard-Bell [Mon, 20 Sep 2021 23:02:13 +0000 (18:02 -0500)] 
Remove debugging

4 years agoredis: If we don't have an explicit dst type, then write directly to out
Arran Cudbard-Bell [Mon, 20 Sep 2021 23:02:02 +0000 (18:02 -0500)] 
redis: If we don't have an explicit dst type, then write directly to out

4 years agoNeed to clean up the tmp pool on the normal path too
Arran Cudbard-Bell [Mon, 20 Sep 2021 22:27:19 +0000 (17:27 -0500)] 
Need to clean up the tmp pool on the normal path too

4 years ago...and remove the assert
Arran Cudbard-Bell [Mon, 20 Sep 2021 22:10:48 +0000 (17:10 -0500)] 
...and remove the assert

4 years agoAllow printing/parsing NULL
Arran Cudbard-Bell [Mon, 20 Sep 2021 22:04:24 +0000 (17:04 -0500)] 
Allow printing/parsing NULL

4 years agoEnable redis tests again
Arran Cudbard-Bell [Mon, 20 Sep 2021 21:42:58 +0000 (16:42 -0500)] 
Enable redis tests again

4 years agoSlave is already dead, kill the master
Arran Cudbard-Bell [Mon, 20 Sep 2021 21:39:22 +0000 (16:39 -0500)] 
Slave is already dead, kill the master

4 years agoUse common code for casting groups
Arran Cudbard-Bell [Mon, 20 Sep 2021 21:27:23 +0000 (16:27 -0500)] 
Use common code for casting groups

4 years agoUse common code for printing groups
Arran Cudbard-Bell [Mon, 20 Sep 2021 21:27:07 +0000 (16:27 -0500)] 
Use common code for printing groups

4 years agoRework list concat functions
Arran Cudbard-Bell [Mon, 20 Sep 2021 21:24:59 +0000 (16:24 -0500)] 
Rework list concat functions

4 years agocopy VALUEs too
Alan T. DeKok [Mon, 20 Sep 2021 15:49:02 +0000 (11:49 -0400)] 
copy VALUEs too

4 years agoadd enums, too
Alan T. DeKok [Mon, 20 Sep 2021 15:43:21 +0000 (11:43 -0400)] 
add enums, too

4 years agoadd code and test cases for copying enums
Alan T. DeKok [Mon, 20 Sep 2021 12:59:58 +0000 (08:59 -0400)] 
add code and test cases for copying enums

even between attributes of different data types

4 years agogive better errors early, if we can
Alan T. DeKok [Sun, 19 Sep 2021 13:40:56 +0000 (09:40 -0400)] 
give better errors early, if we can

4 years agoENUMs have values, but no children
Alan T. DeKok [Sun, 19 Sep 2021 13:40:04 +0000 (09:40 -0400)] 
ENUMs have values, but no children

and add tests

4 years agov4: Add a status to trunks and watchers on state changes (#4224)
Nick Porter [Mon, 20 Sep 2021 12:58:44 +0000 (13:58 +0100)] 
v4: Add a status to trunks and watchers on state changes (#4224)

* Define states of a trunk

* Add lookup table for names of trunk states

* Update trunk state on each call of the management timer

* Define structure and function type for trunk watchers

* Add lists of watchers to trunks

* Add functions to add / remove trunk state change watchers

* Call trunk state change watchers

4 years agoFR_TYPE_VOID is better than FR_TYPE_NULL for indicating we want to use the type from...
Arran Cudbard-Bell [Sun, 19 Sep 2021 15:27:28 +0000 (10:27 -0500)] 
FR_TYPE_VOID is better than FR_TYPE_NULL for indicating we want to use the type from Redis

4 years agoenviron isn't defined on FreeBSD either
Arran Cudbard-Bell [Sun, 19 Sep 2021 15:26:54 +0000 (10:26 -0500)] 
environ isn't defined on FreeBSD either

4 years agojson: get full attribute name
Matthew Newton [Sat, 18 Sep 2021 17:00:43 +0000 (18:00 +0100)] 
json: get full attribute name

4 years agono need to check for 'ref==NULL'
Alan T. DeKok [Sat, 18 Sep 2021 19:43:14 +0000 (15:43 -0400)] 
no need to check for 'ref==NULL'

4 years agoshut up static analyzer
Alan T. DeKok [Sat, 18 Sep 2021 18:22:59 +0000 (14:22 -0400)] 
shut up static analyzer

4 years agoadd and document ENUM
Alan T. DeKok [Sat, 18 Sep 2021 13:56:44 +0000 (09:56 -0400)] 
add and document ENUM

we'll add more complex tests later

4 years agomove self-allocated numbers to be dict-specific
Alan T. DeKok [Sat, 18 Sep 2021 13:50:09 +0000 (09:50 -0400)] 
move self-allocated numbers to be dict-specific

which has fewer opportunities for collisions

4 years ago0 and 1 are valid boolean values.
Alan T. DeKok [Sat, 18 Sep 2021 13:46:11 +0000 (09:46 -0400)] 
0 and 1 are valid boolean values.

4 years agouse local boolean.
Alan T. DeKok [Sat, 18 Sep 2021 13:19:06 +0000 (09:19 -0400)] 
use local boolean.

by the time we get to checking if attr<0, it's already been updated
and allocated.

4 years agos/fr_dict_enum_t/fr_dict_enum_value_t/
Alan T. DeKok [Fri, 17 Sep 2021 18:44:10 +0000 (14:44 -0400)] 
s/fr_dict_enum_t/fr_dict_enum_value_t/

4 years agoThis is ASCII string of MEID
Alan T. DeKok [Fri, 17 Sep 2021 17:47:18 +0000 (13:47 -0400)] 
This is ASCII string of MEID

https://www.3gpp2.org/Public_html/Specs/P.S0001-B_v2.0_041004.pdf

4 years agoUpdate Redis to parse RESP3 types
Arran Cudbard-Bell [Sat, 18 Sep 2021 03:14:19 +0000 (22:14 -0500)] 
Update Redis to parse RESP3 types

Convert redis xlat to be argument based

4 years agouse correct data type.
Alan T. DeKok [Fri, 17 Sep 2021 15:42:04 +0000 (11:42 -0400)] 
use correct data type.

Manual port of commit 622be93

4 years agodouble-check timestamp attributes
Alan T. DeKok [Fri, 17 Sep 2021 12:33:26 +0000 (08:33 -0400)] 
double-check timestamp attributes

Most should probably use the "date" data type.

4 years agochange to correct data type
Alan T. DeKok [Fri, 17 Sep 2021 12:24:36 +0000 (08:24 -0400)] 
change to correct data type

4 years agochange to correct data type
Alan T. DeKok [Fri, 17 Sep 2021 12:19:52 +0000 (08:19 -0400)] 
change to correct data type

4 years agocorrect PAC lifetime calculation
Alan T. DeKok [Fri, 17 Sep 2021 12:11:40 +0000 (08:11 -0400)] 
correct PAC lifetime calculation

the lifetime is a delta, and the "expires" field is a wall-clock
time.

4 years agoshut up scanner
Alan T. DeKok [Thu, 16 Sep 2021 19:27:33 +0000 (15:27 -0400)] 
shut up scanner

4 years agoCheck for zero tsibs and zero lcores before *sigh*
Arran Cudbard-Bell [Thu, 16 Sep 2021 23:52:17 +0000 (18:52 -0500)] 
Check for zero tsibs and zero lcores before *sigh*

4 years agoTypo
Arran Cudbard-Bell [Thu, 16 Sep 2021 19:30:01 +0000 (14:30 -0500)] 
Typo

4 years agoActually set request to new state in NDEBUG build (#4230)
Nick Porter [Thu, 16 Sep 2021 19:28:02 +0000 (20:28 +0100)] 
Actually set request to new state in NDEBUG build (#4230)

4 years agoEnsure we have more siblings than cores
Arran Cudbard-Bell [Thu, 16 Sep 2021 19:21:08 +0000 (14:21 -0500)] 
Ensure we have more siblings than cores

4 years agoIs clang scan really that braindead?
Arran Cudbard-Bell [Thu, 16 Sep 2021 14:43:49 +0000 (09:43 -0500)] 
Is clang scan really that braindead?

4 years agomove comment
Arran Cudbard-Bell [Thu, 16 Sep 2021 14:14:43 +0000 (09:14 -0500)] 
move comment

4 years agoWhitespace
Arran Cudbard-Bell [Thu, 16 Sep 2021 14:06:02 +0000 (09:06 -0500)] 
Whitespace

4 years agov4: Two CI fixes (#4229)
Nick Porter [Thu, 16 Sep 2021 12:45:02 +0000 (13:45 +0100)] 
v4: Two CI fixes (#4229)

* sysctl.h is deprecated on Linux - and not needed here

* Prevent invalid divide by zero warnings

4 years agosample cron docs
Alan T. DeKok [Thu, 16 Sep 2021 12:20:12 +0000 (08:20 -0400)] 
sample cron docs

4 years agofix typos
Alan T. DeKok [Thu, 16 Sep 2021 11:43:10 +0000 (07:43 -0400)] 
fix typos

4 years agonot actually defined anywhere?
Arran Cudbard-Bell [Thu, 16 Sep 2021 02:20:37 +0000 (21:20 -0500)] 
not actually defined anywhere?

4 years agoFix arg order
Arran Cudbard-Bell [Thu, 16 Sep 2021 02:18:55 +0000 (21:18 -0500)] 
Fix arg order

4 years ago™_mday?
Arran Cudbard-Bell [Thu, 16 Sep 2021 02:16:32 +0000 (21:16 -0500)] 
™_mday?

4 years agoWhitespace
Arran Cudbard-Bell [Thu, 16 Sep 2021 02:15:54 +0000 (21:15 -0500)] 
Whitespace

4 years agoAutomatically set the number of workers based on the physical cores available
Arran Cudbard-Bell [Thu, 16 Sep 2021 02:07:04 +0000 (21:07 -0500)] 
Automatically set the number of workers based on the physical cores available

4 years agominor fixes
Alan T. DeKok [Thu, 16 Sep 2021 01:16:43 +0000 (21:16 -0400)] 
minor fixes

4 years agosupport "day of week"
Alan T. DeKok [Thu, 16 Sep 2021 01:12:25 +0000 (21:12 -0400)] 
support "day of week"

4 years agonow we only need to pause reading
Alan T. DeKok [Thu, 16 Sep 2021 00:35:12 +0000 (20:35 -0400)] 
now we only need to pause reading

4 years agoinstead of insert everything, pause/resume writes
Alan T. DeKok [Thu, 16 Sep 2021 00:34:37 +0000 (20:34 -0400)] 
instead of insert everything, pause/resume writes

4 years agoprint out where the FD came from when doing EVENT_DEBUG
Alan T. DeKok [Thu, 16 Sep 2021 00:27:56 +0000 (20:27 -0400)] 
print out where the FD came from when doing EVENT_DEBUG

which is enormously more useful than "did fd stuff."

4 years agoupdates are "const"
Alan T. DeKok [Thu, 16 Sep 2021 00:27:40 +0000 (20:27 -0400)] 
updates are "const"

4 years agolocalize already sets 'done'
Alan T. DeKok [Wed, 15 Sep 2021 21:09:36 +0000 (17:09 -0400)] 
localize already sets 'done'

4 years agoremoved unnecessary link
Alan T. DeKok [Wed, 15 Sep 2021 19:15:14 +0000 (15:15 -0400)] 
removed unnecessary link

4 years agoThere's multiple places where we get "Failed in SSL_read"
Arran Cudbard-Bell [Wed, 15 Sep 2021 20:40:27 +0000 (15:40 -0500)] 
There's multiple places where we get "Failed in SSL_read"

4 years agoDon't include space in reason phrase
Arran Cudbard-Bell [Wed, 15 Sep 2021 20:02:48 +0000 (15:02 -0500)] 
Don't include space in reason phrase

4 years agouctx is a tls_session
Arran Cudbard-Bell [Wed, 15 Sep 2021 19:54:46 +0000 (14:54 -0500)] 
uctx is a tls_session

4 years agoNo longer true
Arran Cudbard-Bell [Wed, 15 Sep 2021 19:38:43 +0000 (14:38 -0500)] 
No longer true

4 years agoAdd more sanity checks
Arran Cudbard-Bell [Wed, 15 Sep 2021 19:37:42 +0000 (14:37 -0500)] 
Add more sanity checks

4 years agouse new macros
Alan T. DeKok [Wed, 15 Sep 2021 19:13:17 +0000 (15:13 -0400)] 
use new macros

4 years agocleanups
Alan T. DeKok [Wed, 15 Sep 2021 19:09:48 +0000 (15:09 -0400)] 
cleanups

4 years agoDon't do direct comparison with pointer
Arran Cudbard-Bell [Wed, 15 Sep 2021 19:08:13 +0000 (14:08 -0500)] 
Don't do direct comparison with pointer

4 years agoSignificantly improve state entry reuse and remove stale entries much earlier
Arran Cudbard-Bell [Wed, 15 Sep 2021 19:03:54 +0000 (14:03 -0500)] 
Significantly improve state entry reuse and remove stale entries much earlier

4 years agoadd crontab functionality.
Alan T. DeKok [Wed, 15 Sep 2021 18:18:01 +0000 (14:18 -0400)] 
add crontab functionality.

much of proto_cron.c is just a copy of proto_load.c
So we might want to have a generic "timer" front end, and then
have it do timer "load" or timer "crontab"

4 years agowe don't care about writing to the socket either
Alan T. DeKok [Wed, 15 Sep 2021 18:06:23 +0000 (14:06 -0400)] 
we don't care about writing to the socket either

4 years agoclearer message
Alan T. DeKok [Wed, 15 Sep 2021 14:04:28 +0000 (10:04 -0400)] 
clearer message

4 years agotypo
Alan T. DeKok [Wed, 15 Sep 2021 13:49:53 +0000 (09:49 -0400)] 
typo

4 years agorename for consistency
Alan T. DeKok [Tue, 14 Sep 2021 19:34:40 +0000 (15:34 -0400)] 
rename for consistency

4 years agoDon't use ROPTIONAL and RERROR in pool.c as we lose the pool prefix
Arran Cudbard-Bell [Wed, 15 Sep 2021 17:46:52 +0000 (12:46 -0500)] 
Don't use ROPTIONAL and RERROR in pool.c as we lose the pool prefix

4 years agoDelete packet type when overriding the reply code
Arran Cudbard-Bell [Wed, 15 Sep 2021 17:26:34 +0000 (12:26 -0500)] 
Delete packet type when overriding the reply code

4 years agoAdd new macros for calling the next send function and overriding reply codes
Arran Cudbard-Bell [Wed, 15 Sep 2021 17:05:49 +0000 (12:05 -0500)] 
Add new macros for calling the next send function and overriding reply codes

4 years agoSame issue for state failures with Access-Requests
Arran Cudbard-Bell [Wed, 15 Sep 2021 16:45:40 +0000 (11:45 -0500)] 
Same issue for state failures with Access-Requests

4 years agoCall send_generic and have it call the correct section and resume function
Arran Cudbard-Bell [Wed, 15 Sep 2021 16:42:07 +0000 (11:42 -0500)] 
Call send_generic and have it call the correct section and resume function

May fix infinite loop on fr_request_to_state failure

4 years agoTypo
Arran Cudbard-Bell [Wed, 15 Sep 2021 16:23:29 +0000 (11:23 -0500)] 
Typo

4 years agoSimplify error handling in eap_session_continue
Arran Cudbard-Bell [Wed, 15 Sep 2021 16:17:48 +0000 (11:17 -0500)] 
Simplify error handling in eap_session_continue

4 years agotypo
Arran Cudbard-Bell [Wed, 15 Sep 2021 15:22:26 +0000 (10:22 -0500)] 
typo

4 years agoAdd env var to disable performance tests in CI
Arran Cudbard-Bell [Wed, 15 Sep 2021 15:20:40 +0000 (10:20 -0500)] 
Add env var to disable performance tests in CI

They keep failing spuriously because the runners are slow

4 years agov4: Convert LDAP escape / unescape xlats to new API (#4227)
Nick Porter [Wed, 15 Sep 2021 15:15:40 +0000 (16:15 +0100)] 
v4: Convert LDAP escape / unescape xlats to new API (#4227)

* Update %{ldap_escape } to new xlat api

* Add tests for %{ldap_escape: }

* Convert %{ldap_unescape: } to new xlat api

* Add tests for %{ldap_unescape: }

* Look for the current character in the "specials" list, not the first

4 years agoFix signed integer promotion in a less elegant, but more functional way.
Arran Cudbard-Bell [Wed, 15 Sep 2021 15:01:36 +0000 (10:01 -0500)] 
Fix signed integer promotion in a less elegant, but more functional way.

4 years agoAdd additional tests which expose errors in the current net to signed, negative int...
Arran Cudbard-Bell [Wed, 15 Sep 2021 14:58:58 +0000 (09:58 -0500)] 
Add additional tests which expose errors in the current net to signed, negative int code

4 years agoAdd back env_escape to rlm_exec, and add env_inherit
Arran Cudbard-Bell [Wed, 15 Sep 2021 14:58:24 +0000 (09:58 -0500)] 
Add back env_escape to rlm_exec, and add env_inherit

4 years agoAdditional tests
Arran Cudbard-Bell [Wed, 15 Sep 2021 14:33:27 +0000 (09:33 -0500)] 
Additional tests

4 years agoPrint exec environment after merging
Arran Cudbard-Bell [Wed, 15 Sep 2021 06:00:38 +0000 (01:00 -0500)] 
Print exec environment after merging

4 years agoFixup environmental variable creation
Arran Cudbard-Bell [Wed, 15 Sep 2021 05:40:27 +0000 (00:40 -0500)] 
Fixup environmental variable creation

Use a thread-local buffer for envp, and to store temporary values

Don't wrap string values in env vars in quotes

4 years agoFix spurious error
Arran Cudbard-Bell [Wed, 15 Sep 2021 05:03:16 +0000 (00:03 -0500)] 
Fix spurious error