]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agoFixup references to Pool-Range
Arran Cudbard-Bell [Sun, 29 Nov 2020 20:54:18 +0000 (13:54 -0700)] 
Fixup references to Pool-Range

5 years agoFixup references to Pool-Action
Arran Cudbard-Bell [Sun, 29 Nov 2020 20:47:25 +0000 (13:47 -0700)] 
Fixup references to Pool-Action

5 years agoInvert name component order for LDAP DHCPv6 attributes
Arran Cudbard-Bell [Sun, 29 Nov 2020 20:39:36 +0000 (13:39 -0700)] 
Invert name component order for LDAP DHCPv6 attributes

5 years agoRequest CAP_NET_RAW before using SO_BINDTODEVICE
Arran Cudbard-Bell [Sun, 29 Nov 2020 20:31:15 +0000 (13:31 -0700)] 
Request CAP_NET_RAW before using SO_BINDTODEVICE

5 years agoNot needed...
Arran Cudbard-Bell [Sun, 29 Nov 2020 19:02:36 +0000 (12:02 -0700)] 
Not needed...

5 years agoFixup examples using the old list separator
Arran Cudbard-Bell [Sun, 29 Nov 2020 18:33:26 +0000 (11:33 -0700)] 
Fixup examples using the old list separator

5 years agoRemove support for old list separators
Arran Cudbard-Bell [Sun, 29 Nov 2020 17:25:56 +0000 (10:25 -0700)] 
Remove support for old list separators

There's no point in maintaining backwards compatibility when the reference syntax has changed so significantly

5 years agoalso check do_not_respond flag
Alan T. DeKok [Sun, 29 Nov 2020 17:08:08 +0000 (12:08 -0500)] 
also check do_not_respond flag

this shouldn't be strictly necesary, but it doesn't hurt

5 years agoupdate cursor only on success
Alan T. DeKok [Sun, 29 Nov 2020 17:07:53 +0000 (12:07 -0500)] 
update cursor only on success

5 years agoCreate a TLV and additional identifiers for IP-Pool attirbutes
Arran Cudbard-Bell [Sun, 29 Nov 2020 02:11:59 +0000 (19:11 -0700)] 
Create a TLV and additional identifiers for IP-Pool attirbutes

5 years agoFixup object references
Arran Cudbard-Bell [Sun, 29 Nov 2020 01:39:12 +0000 (18:39 -0700)] 
Fixup object references

5 years agovp may be NULL if we're passed a struct with no children
Alan T. DeKok [Sun, 29 Nov 2020 00:12:44 +0000 (19:12 -0500)] 
vp may be NULL if we're passed a struct with no children

5 years agoadd commas habitually
Alan T. DeKok [Sat, 28 Nov 2020 23:26:04 +0000 (18:26 -0500)] 
add commas habitually

5 years agomove common code to struct_to_network()
Alan T. DeKok [Sat, 28 Nov 2020 23:09:08 +0000 (18:09 -0500)] 
move common code to struct_to_network()

5 years agoremove unnecessary encode_struct wrapper
Alan T. DeKok [Sat, 28 Nov 2020 15:55:22 +0000 (10:55 -0500)] 
remove unnecessary encode_struct wrapper

5 years agomove encode_tlv functionality into the structure encoder
Alan T. DeKok [Sat, 28 Nov 2020 15:25:15 +0000 (10:25 -0500)] 
move encode_tlv functionality into the structure encoder

5 years agoremove _dbuff from name. And add in wrapper for encode_tlv
Alan T. DeKok [Sat, 28 Nov 2020 15:19:54 +0000 (10:19 -0500)] 
remove _dbuff from name.  And add in wrapper for encode_tlv

which isn't implemented right now, but we have plans.

5 years agoremove unused wrappers
Alan T. DeKok [Sat, 28 Nov 2020 15:13:47 +0000 (10:13 -0500)] 
remove unused wrappers

5 years agoUse field names when specifying module methods
Arran Cudbard-Bell [Sat, 28 Nov 2020 21:48:33 +0000 (14:48 -0700)] 
Use field names when specifying module methods

Allows us to add more fields later

5 years agodocs: fix simple typo, mininum -> minimum (#3772)
Tim Gates [Sat, 28 Nov 2020 21:42:11 +0000 (08:42 +1100)] 
docs: fix simple typo, mininum -> minimum (#3772)

There is a small typo in src/modules/rlm_radius/rlm_radius_udp.c.

Should read `minimum` rather than `mininum`.

5 years agoStrip DHCP prefix off of DHCP message types
Arran Cudbard-Bell [Sat, 28 Nov 2020 21:09:42 +0000 (14:09 -0700)] 
Strip DHCP prefix off of DHCP message types

5 years agowhen structs are groups, sort their children
Alan T. DeKok [Fri, 27 Nov 2020 22:25:01 +0000 (17:25 -0500)] 
when structs are groups, sort their children

so that the struct fields are encoded properly.

Note that we sort in INCREASING order.  the default pair_cmp_by_num
will sort the VPs in DECREASING order.

5 years agofix encoding of structs as groups
Alan T. DeKok [Fri, 27 Nov 2020 22:08:07 +0000 (17:08 -0500)] 
fix encoding of structs as groups

and add a test case

5 years agomore errors
Alan T. DeKok [Fri, 27 Nov 2020 21:47:01 +0000 (16:47 -0500)] 
more errors

5 years agoallow parsing of structs as groups
Alan T. DeKok [Fri, 27 Nov 2020 21:20:42 +0000 (16:20 -0500)] 
allow parsing of structs as groups

and follow references if they exist

5 years agoupdate do do encode / match / decode / match
Alan T. DeKok [Fri, 27 Nov 2020 21:19:01 +0000 (16:19 -0500)] 
update do do encode / match / decode / match

5 years agoSplit pool name attribute based on IA type
Arran Cudbard-Bell [Fri, 27 Nov 2020 19:38:08 +0000 (12:38 -0700)] 
Split pool name attribute based on IA type

5 years agoencode TLVs after structs properly
Alan T. DeKok [Fri, 27 Nov 2020 17:48:58 +0000 (12:48 -0500)] 
encode TLVs after structs properly

5 years agoset the do_not_respond flag
Alan T. DeKok [Fri, 27 Nov 2020 17:42:59 +0000 (12:42 -0500)] 
set the do_not_respond flag

5 years agoFixup ADSL forum attributes
Arran Cudbard-Bell [Fri, 27 Nov 2020 17:03:21 +0000 (10:03 -0700)] 
Fixup ADSL forum attributes

5 years agoShorten the 7750 vendor name
Arran Cudbard-Bell [Fri, 27 Nov 2020 16:46:37 +0000 (09:46 -0700)] 
Shorten the 7750 vendor name

5 years agouse atomic_fetch_add
Alan T. DeKok [Fri, 27 Nov 2020 16:21:06 +0000 (11:21 -0500)] 
use atomic_fetch_add

5 years agomake the counter global for request->number
Alan T. DeKok [Fri, 27 Nov 2020 16:15:30 +0000 (11:15 -0500)] 
make the counter global for request->number

5 years agoreply to request
Alan T. DeKok [Fri, 27 Nov 2020 14:06:49 +0000 (09:06 -0500)] 
reply to request

5 years agohack until we track down places which don't set data.enumv = vp->da
Alan T. DeKok [Fri, 27 Nov 2020 13:07:14 +0000 (08:07 -0500)] 
hack until we track down places which don't set data.enumv = vp->da

5 years agoBetter limit
Arran Cudbard-Bell [Fri, 27 Nov 2020 04:41:09 +0000 (21:41 -0700)] 
Better limit

5 years agoMight not have any pairs
Arran Cudbard-Bell [Fri, 27 Nov 2020 03:40:24 +0000 (20:40 -0700)] 
Might not have any pairs

5 years agoFix pair debug output when printing groups which have TLVlike attributes in their...
Arran Cudbard-Bell [Fri, 27 Nov 2020 03:31:37 +0000 (20:31 -0700)] 
Fix pair debug output when printing groups which have TLVlike attributes in their lineage

5 years agoFix Circuit-ID and Remote-ID references
Arran Cudbard-Bell [Fri, 27 Nov 2020 00:20:38 +0000 (17:20 -0700)] 
Fix Circuit-ID and Remote-ID references

5 years agoFix various issues with unresolved attributes
Arran Cudbard-Bell [Fri, 27 Nov 2020 00:11:16 +0000 (17:11 -0700)] 
Fix various issues with unresolved attributes

5 years agoFix NT-Password ref
Arran Cudbard-Bell [Thu, 26 Nov 2020 23:10:01 +0000 (16:10 -0700)] 
Fix NT-Password ref

5 years agoAllow tmpl_rules to be customised for each set of test cases
Arran Cudbard-Bell [Thu, 26 Nov 2020 22:41:17 +0000 (15:41 -0700)] 
Allow tmpl_rules to be customised for each set of test cases

5 years agoAllow '::'
Arran Cudbard-Bell [Thu, 26 Nov 2020 21:30:59 +0000 (14:30 -0700)] 
Allow '::'

5 years agoFix references which pass through key attributes
Arran Cudbard-Bell [Thu, 26 Nov 2020 21:28:36 +0000 (14:28 -0700)] 
Fix references which pass through key attributes

5 years agoRename macro to be more consistent with other public dict functions
Arran Cudbard-Bell [Thu, 26 Nov 2020 21:28:14 +0000 (14:28 -0700)] 
Rename macro to be more consistent with other public dict functions

5 years agoshort-circuit TLV encoder for structs
Alan T. DeKok [Thu, 26 Nov 2020 21:08:05 +0000 (16:08 -0500)] 
short-circuit TLV encoder for structs

if we're encoding a 'struct' and the last field is a TLV, then
the struct encoder can't encode it.  Because it needs to know
the sizes of "T" and "L", and it doesn't know that.

Also, if the 'struct' ends with a TLV, then the struct cannot
have a "key" field, as we don't (yet) encode sub-structs in the
middle of a struct.  Instead, the sub-struct has to be encoded
at the end of the parent struct.  Which means that the parent
can't end with a TLV.

The struct can't also have an auto-encoded 'length' field.
Because there's no way for it to be filled in with the length
of the base struct + TLVs.  If the struct_to_network() function
was passed an "encode_tlv" function, then this last restriction
could be relaxed.

5 years agoallow fr_value_box_to_network() to handle fixed-size string / octets
Alan T. DeKok [Thu, 26 Nov 2020 20:54:42 +0000 (15:54 -0500)] 
allow fr_value_box_to_network() to handle fixed-size string / octets

5 years agoset key_da before encoding
Alan T. DeKok [Thu, 26 Nov 2020 20:39:14 +0000 (15:39 -0500)] 
set key_da before encoding

in preparation for auto-filling in the key field

5 years agoallow for encoding fixed-width string / octet types
Alan T. DeKok [Thu, 26 Nov 2020 20:26:20 +0000 (15:26 -0500)] 
allow for encoding fixed-width string / octet types

which is better here than scattered throughout the code.

5 years agoprepare for nested structs.
Alan T. DeKok [Thu, 26 Nov 2020 19:57:46 +0000 (14:57 -0500)] 
prepare for nested structs.

for now, both styles (in-line, and nested) are supported.

5 years agodon't set new_track unless it's not a duplicate
Alan T. DeKok [Thu, 26 Nov 2020 19:57:30 +0000 (14:57 -0500)] 
don't set new_track unless it's not a duplicate

5 years agofree the packet context if we can't send it to the worker
Alan T. DeKok [Thu, 26 Nov 2020 19:07:25 +0000 (14:07 -0500)] 
free the packet context if we can't send it to the worker

the packet context MUST be initialized, and MUST be talloc'd

5 years agoClang scan fixes
Arran Cudbard-Bell [Thu, 26 Nov 2020 17:32:42 +0000 (10:32 -0700)] 
Clang scan fixes

5 years agoadd dependencies and clean rules
Alan T. DeKok [Thu, 26 Nov 2020 17:18:36 +0000 (12:18 -0500)] 
add dependencies and clean rules

so that the tests will be run when the code changes

5 years agoRemove generated timestamp from footer to reduce churn in docsite repo
Arran Cudbard-Bell [Thu, 26 Nov 2020 17:16:46 +0000 (10:16 -0700)] 
Remove generated timestamp from footer to reduce churn in docsite repo

5 years agoRemove "TACACS-" Prefixes from everything
Arran Cudbard-Bell [Thu, 26 Nov 2020 16:57:48 +0000 (09:57 -0700)] 
Remove "TACACS-" Prefixes from everything

5 years agoVarious clang scan fixes
Arran Cudbard-Bell [Thu, 26 Nov 2020 16:09:30 +0000 (09:09 -0700)] 
Various clang scan fixes

5 years agopass the full OID path when we go back _up_ the tree
Alan T. DeKok [Thu, 26 Nov 2020 14:38:54 +0000 (09:38 -0500)] 
pass the full OID path when we go back _up_ the tree

5 years agofix types to match everything else
Alan T. DeKok [Thu, 26 Nov 2020 14:07:26 +0000 (09:07 -0500)] 
fix types to match everything else

we should really finalize the "ref" stuff for TLVs, so that
we don't have to re-define these sub-structures.

5 years agoprint NAME of the thing we're complaining about.
Alan T. DeKok [Thu, 26 Nov 2020 13:44:21 +0000 (08:44 -0500)] 
print NAME of the thing we're complaining about.

If we're 18 levels deep in an OID string, a vague message of
"nope" doesn't tell us WHICH thing is broken.

5 years agore-run "make dictionary.format"
Alan T. DeKok [Thu, 26 Nov 2020 13:27:26 +0000 (08:27 -0500)] 
re-run "make dictionary.format"

5 years agoFix printing group traversals
Arran Cudbard-Bell [Thu, 26 Nov 2020 04:10:53 +0000 (21:10 -0700)] 
Fix printing group traversals

5 years agoName resolution fixes
Arran Cudbard-Bell [Thu, 26 Nov 2020 02:55:57 +0000 (19:55 -0700)] 
Name resolution fixes

5 years agoFix map to command resolution in SNMP
Arran Cudbard-Bell [Thu, 26 Nov 2020 02:55:46 +0000 (19:55 -0700)] 
Fix map to command resolution in SNMP

5 years agoMore name resolution fixes
Arran Cudbard-Bell [Thu, 26 Nov 2020 02:55:35 +0000 (19:55 -0700)] 
More name resolution fixes

5 years agoNo longer a valid assert
Arran Cudbard-Bell [Thu, 26 Nov 2020 02:54:54 +0000 (19:54 -0700)] 
No longer a valid assert

5 years agoVarios fixes for digest tests and others...
Arran Cudbard-Bell [Thu, 26 Nov 2020 01:40:53 +0000 (18:40 -0700)] 
Varios fixes for digest tests and others...

5 years agoFix OID component parsing function when we hit attributes which starts with a number
Arran Cudbard-Bell [Wed, 25 Nov 2020 23:04:04 +0000 (16:04 -0700)] 
Fix OID component parsing function when we hit attributes which starts with a number

Fix 'raw.' flag for known attributes

5 years ago%pV cannot be used for structural types
Alan T. DeKok [Wed, 25 Nov 2020 21:29:43 +0000 (16:29 -0500)] 
%pV cannot be used for structural types

as the "group" thing points to a fr_pair_t, and not to an
fr_value_box_t

5 years agouse pre-existing pair_list_verify function
Alan T. DeKok [Wed, 25 Nov 2020 21:23:22 +0000 (16:23 -0500)] 
use pre-existing pair_list_verify function

5 years agofollow references if they exist
Alan T. DeKok [Wed, 25 Nov 2020 21:10:00 +0000 (16:10 -0500)] 
follow references if they exist

5 years agoAutoload values for SIM xlats
Arran Cudbard-Bell [Wed, 25 Nov 2020 21:37:52 +0000 (14:37 -0700)] 
Autoload values for SIM xlats

5 years agoAdd autoloader for enumeration values
Arran Cudbard-Bell [Wed, 25 Nov 2020 21:13:20 +0000 (14:13 -0700)] 
Add autoloader for enumeration values

5 years agopoint to the '.' which is an error
Alan T. DeKok [Wed, 25 Nov 2020 20:34:26 +0000 (15:34 -0500)] 
point to the '.' which is an error

and not to the start of the attribute name.

We can't point to the parent attribute, because that information
is lost somewhere in the parser (which succeeded), and we only
know that the _next_ thing doesn't work.

5 years agoRename resolution functions
Arran Cudbard-Bell [Wed, 25 Nov 2020 19:35:17 +0000 (12:35 -0700)] 
Rename resolution functions

5 years agoresolve all attributes in an OID, not just one
Alan T. DeKok [Wed, 25 Nov 2020 18:38:51 +0000 (13:38 -0500)] 
resolve all attributes in an OID, not just one

5 years agoupdate for new names
Alan T. DeKok [Wed, 25 Nov 2020 17:57:56 +0000 (12:57 -0500)] 
update for new names

5 years agoSimplify condition
Arran Cudbard-Bell [Wed, 25 Nov 2020 17:41:49 +0000 (10:41 -0700)] 
Simplify condition

5 years agoFixup unknown parents
Arran Cudbard-Bell [Wed, 25 Nov 2020 17:38:28 +0000 (10:38 -0700)] 
Fixup unknown parents

5 years agofall back to reading attributes from the internal dictionary
Alan T. DeKok [Wed, 25 Nov 2020 15:25:33 +0000 (10:25 -0500)] 
fall back to reading attributes from the internal dictionary

helps with reading protocol AND internal attributes from files

5 years agoit helps to initialize structures
Alan T. DeKok [Wed, 25 Nov 2020 14:49:39 +0000 (09:49 -0500)] 
it helps to initialize structures

5 years agoremove radius from src/lib/util/base.h
Alan T. DeKok [Wed, 25 Nov 2020 14:14:26 +0000 (09:14 -0500)] 
remove radius from src/lib/util/base.h

and fix up everything which needs it.

5 years agono need for RADIUS here
Alan T. DeKok [Wed, 25 Nov 2020 14:14:03 +0000 (09:14 -0500)] 
no need for RADIUS here

5 years agomake it protocol agnostic
Alan T. DeKok [Wed, 25 Nov 2020 13:46:06 +0000 (08:46 -0500)] 
make it protocol agnostic

5 years agoremove unused variable
Alan T. DeKok [Tue, 24 Nov 2020 20:24:35 +0000 (15:24 -0500)] 
remove unused variable

5 years agoadd encode / decode of "raw" attributes
Alan T. DeKok [Tue, 24 Nov 2020 20:08:25 +0000 (15:08 -0500)] 
add encode / decode of "raw" attributes

something seems to not be set right.  We create

raw.NAS-Port = 0x0102

but the NAS-Port is encoded as a *normal* NAS-Port
attribute, and encoded with 4 bytes instead of 2

set flags.length=0 for unknown attributes

because they're "octets", and fixed size.  So the encoder should
not use the length from the _old_ flags (e.g. 4 for uint32)

Instead, it should just use the length of the octets.

Also corrected the tests to match.

5 years agomake it clearer what's going on
Alan T. DeKok [Tue, 24 Nov 2020 18:06:16 +0000 (13:06 -0500)] 
make it clearer what's going on

creating a "raw.26" attribute creates a "raw.26" attribute.
it doesn't resolve "26" into "Vendor-Specific"

5 years agodon't parse "3com" as "3".
Alan T. DeKok [Tue, 24 Nov 2020 16:50:28 +0000 (11:50 -0500)] 
don't parse "3com" as "3".

5 years agoupdate for new output, which is sometimes truncated...
Alan T. DeKok [Tue, 24 Nov 2020 16:48:46 +0000 (11:48 -0500)] 
update for new output, which is sometimes truncated...

the "create raw attribute" code seems to create things like

raw.parent1.child = 0xxxx

instead of

raw.parent.child.1 = 0xxxxx

as a result, when it's encoded, the "raw" portion of the data
is truncated.  This can be investigated later, as it's not
a show stopper.

See also the wimax.txt tests, which have a few @todo comments
noticing this same issue

5 years agoupdate for new names
Alan T. DeKok [Tue, 24 Nov 2020 16:14:11 +0000 (11:14 -0500)] 
update for new names

5 years agoCommit failing tests
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:23:38 +0000 (08:23 -0700)] 
Commit failing tests

5 years agoFR_TYPE_VENDOR should not be execluded from STRUTURAL_EXCEPT_VSA
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:19:18 +0000 (08:19 -0700)] 
FR_TYPE_VENDOR should not be execluded from STRUTURAL_EXCEPT_VSA

5 years agoFixup macros
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:19:01 +0000 (08:19 -0700)] 
Fixup macros

5 years agoFixup autoloader definitions
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:18:40 +0000 (08:18 -0700)] 
Fixup autoloader definitions

5 years agoFixup unknown allocation functions, and mark raw attributes as raw
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:17:32 +0000 (08:17 -0700)] 
Fixup unknown allocation functions, and mark raw attributes as raw

5 years agoDon't deconst the attribute until we're sure it's not NULL
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:16:23 +0000 (08:16 -0700)] 
Don't deconst the attribute until we're sure it's not NULL

5 years agoIf the tmpl substr function returns <= 0 it's always an error
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:15:11 +0000 (08:15 -0700)] 
If the tmpl substr function returns <= 0 it's always an error

5 years agoPrint the attribute being debugged
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:14:48 +0000 (08:14 -0700)] 
Print the attribute being debugged

5 years agoFix more of the tests to use the new names
Arran Cudbard-Bell [Tue, 24 Nov 2020 15:14:23 +0000 (08:14 -0700)] 
Fix more of the tests to use the new names

5 years agoDict unknown fixes
Arran Cudbard-Bell [Mon, 23 Nov 2020 22:06:17 +0000 (15:06 -0700)] 
Dict unknown fixes