]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agopython: Strip bad cflags
Arran Cudbard-Bell [Tue, 8 Sep 2020 14:02:26 +0000 (10:02 -0400)] 
python: Strip bad cflags

5 years agovqp: Fix missing track statement (#3624)
Jorge Pereira [Tue, 8 Sep 2020 12:57:20 +0000 (09:57 -0300)] 
vqp: Fix missing track statement (#3624)

5 years agovqp: Fix module instance (#3623)
Jorge Pereira [Tue, 8 Sep 2020 12:57:14 +0000 (09:57 -0300)] 
vqp: Fix module instance (#3623)

5 years agosbuff: Fix uninitialised error
Arran Cudbard-Bell [Mon, 7 Sep 2020 21:40:51 +0000 (17:40 -0400)] 
sbuff: Fix uninitialised error

5 years agovalue: Various cast fixes
Arran Cudbard-Bell [Mon, 7 Sep 2020 21:56:45 +0000 (17:56 -0400)] 
value: Various cast fixes

5 years agodates are always positive
Alan T. DeKok [Mon, 7 Sep 2020 21:29:35 +0000 (17:29 -0400)] 
dates are always positive

5 years agovqp: If failed, don't forget to release vp's too. (#3622)
Alan DeKok [Mon, 7 Sep 2020 19:06:39 +0000 (15:06 -0400)] 
vqp: If failed, don't forget to release vp's too. (#3622)

5 years ago:gear: vqp: If failed, don't forget to release vp's too. 3622/head
Jorge Pereira [Mon, 7 Sep 2020 19:04:32 +0000 (16:04 -0300)] 
:gear: vqp: If failed, don't forget to release vp's too.

5 years ago:gear: vqp: Fix return value in fr_vqp_ok() (#3621)
Jorge Pereira [Mon, 7 Sep 2020 19:01:53 +0000 (16:01 -0300)] 
:gear: vqp: Fix return value in fr_vqp_ok() (#3621)

5 years agovalue: Fix conversion of numeric types to dates
Arran Cudbard-Bell [Mon, 7 Sep 2020 16:17:20 +0000 (12:17 -0400)] 
value: Fix conversion of numeric types to dates

5 years agoFix NULL pointer input to hash function
Arran Cudbard-Bell [Sat, 5 Sep 2020 04:46:44 +0000 (00:46 -0400)] 
Fix NULL pointer input to hash function

5 years agoTypo
Arran Cudbard-Bell [Sat, 5 Sep 2020 04:40:21 +0000 (00:40 -0400)] 
Typo

5 years agoFix multiple issues with enumeration by value lookups
Arran Cudbard-Bell [Sat, 5 Sep 2020 04:39:15 +0000 (00:39 -0400)] 
Fix multiple issues with enumeration by value lookups

5 years agoFix debug statements in eap fast
Arran Cudbard-Bell [Fri, 4 Sep 2020 21:04:52 +0000 (17:04 -0400)] 
Fix debug statements in eap fast

5 years agoFix spelling mistake in raddb/mods-config/files/accounting (#3619)
Godwottery [Fri, 4 Sep 2020 15:10:23 +0000 (17:10 +0200)] 
Fix spelling mistake in raddb/mods-config/files/accounting (#3619)

Fix spelling mistake: s/combinasion/combination/

5 years agotacacs: Fix the encode field (#3616)
Jorge Pereira [Fri, 4 Sep 2020 12:02:09 +0000 (09:02 -0300)] 
tacacs: Fix the encode field (#3616)

If the attribute is empty, just set to 0.

5 years agosbuff: Add escaping functions
Arran Cudbard-Bell [Thu, 3 Sep 2020 04:09:27 +0000 (00:09 -0400)] 
sbuff: Add escaping functions

5 years agotacacs: Fix authorize arg_cnt field (#3615)
Jorge Pereira [Thu, 3 Sep 2020 19:41:38 +0000 (16:41 -0300)] 
tacacs: Fix authorize arg_cnt field (#3615)

if not used, it must be reset to 0

5 years agoAdd fr_struct_to_network_dbuff()
James Jones [Mon, 17 Aug 2020 14:55:03 +0000 (09:55 -0500)] 
Add fr_struct_to_network_dbuff()

We also add put_bits_dbuff() for its use, and, since it and
fr_struct_to_network() will coexist for a time, there's also a
separate typedef for an encode_value function using dbuffs.

5 years agosbuff: Add ability to move data between buffers
Arran Cudbard-Bell [Thu, 3 Sep 2020 03:41:30 +0000 (23:41 -0400)] 
sbuff: Add ability to move data between buffers

and fix the FILL_OR_GOTO_DONE macro

5 years agovalue: String is already in the correct ctx, don't increase the ref count
Arran Cudbard-Bell [Wed, 2 Sep 2020 19:13:45 +0000 (15:13 -0400)] 
value: String is already in the correct ctx, don't increase the ref count

5 years agosbuff: Simplify fr_sbuff_out_unescape_until
Arran Cudbard-Bell [Wed, 2 Sep 2020 19:00:21 +0000 (15:00 -0400)] 
sbuff: Simplify fr_sbuff_out_unescape_until

5 years agoRevert "don't do shallow copy"
Alan T. DeKok [Wed, 2 Sep 2020 18:12:21 +0000 (14:12 -0400)] 
Revert "don't do shallow copy"

This reverts commit 412fd4ff2b36c7c247091846f2bd4fbbddc1a898.

which then ends up leaking memory...

5 years agostupid typos
Alan T. DeKok [Wed, 2 Sep 2020 17:43:33 +0000 (13:43 -0400)] 
stupid typos

5 years agodelete pending events here, too
Alan T. DeKok [Wed, 2 Sep 2020 17:41:01 +0000 (13:41 -0400)] 
delete pending events here, too

5 years agodon't do shallow copy
Alan T. DeKok [Wed, 2 Sep 2020 17:38:39 +0000 (13:38 -0400)] 
don't do shallow copy

which makes the string have multiple parents, and causes
talloc complaints in xlat_eval

5 years agoreset timer on dup
Alan T. DeKok [Wed, 2 Sep 2020 17:25:25 +0000 (13:25 -0400)] 
reset timer on dup

it will be set again in mod_write()

5 years agoinitialize heap_id, and use correct error message
Alan T. DeKok [Wed, 2 Sep 2020 15:21:58 +0000 (11:21 -0400)] 
initialize heap_id, and use correct error message

5 years agoremove last vestige of avoiding libkqueue
Alan T. DeKok [Wed, 2 Sep 2020 14:46:49 +0000 (10:46 -0400)] 
remove last vestige of avoiding libkqueue

don't mark the request as resumable on close pipe.  Just wait
for the PID handler.

5 years agoclose the FD in the waitpid callback
Alan T. DeKok [Wed, 2 Sep 2020 14:46:13 +0000 (10:46 -0400)] 
close the FD in the waitpid callback

there is no requirement that we get a "read done" IO event
before the "child exited" callback

5 years agoit helps to set ev->el, especially if we dereference it
Alan T. DeKok [Wed, 2 Sep 2020 14:42:12 +0000 (10:42 -0400)] 
it helps to set ev->el, especially if we dereference it

5 years agouse bool "do_not_respond" instead of magic value
Alan T. DeKok [Wed, 2 Sep 2020 13:51:57 +0000 (09:51 -0400)] 
use bool "do_not_respond" instead of magic value

5 years agoremove linux hacks
Alan T. DeKok [Wed, 2 Sep 2020 13:47:44 +0000 (09:47 -0400)] 
remove linux hacks

as our event loop now pretends to support EVFILT_PROC on Linux

5 years agoremove duplication
Alan T. DeKok [Wed, 2 Sep 2020 00:58:02 +0000 (20:58 -0400)] 
remove duplication

between fr_network_post_event() and fr_network_write()

5 years agouse "discard" flag instead of resetting track->address
Alan T. DeKok [Wed, 2 Sep 2020 00:19:10 +0000 (20:19 -0400)] 
use "discard" flag instead of resetting track->address

5 years agomark up "track" as to be cleaned up now
Alan T. DeKok [Tue, 1 Sep 2020 23:01:14 +0000 (19:01 -0400)] 
mark up "track" as to be cleaned up now

5 years agomore cleanups and checking for corner cases
Alan T. DeKok [Tue, 1 Sep 2020 20:51:52 +0000 (16:51 -0400)] 
more cleanups and checking for corner cases

5 years agomore fixes and assertions
Alan T. DeKok [Mon, 31 Aug 2020 20:10:46 +0000 (16:10 -0400)] 
more fixes and assertions

5 years agoRevert "ensure that events are deleted, too"
Alan T. DeKok [Mon, 31 Aug 2020 19:53:14 +0000 (15:53 -0400)] 
Revert "ensure that events are deleted, too"

This reverts commit 47a6791a068fe294e90dddb4300f5ea612834efe.

5 years agoensure that events are deleted, too
Alan T. DeKok [Mon, 31 Aug 2020 19:18:43 +0000 (15:18 -0400)] 
ensure that events are deleted, too

5 years agosbuff: Cleanup extension functions
Arran Cudbard-Bell [Mon, 31 Aug 2020 14:32:46 +0000 (09:32 -0500)] 
sbuff: Cleanup extension functions

5 years agouse event API now that it fully supports EVFILT_PROC
Alan T. DeKok [Mon, 31 Aug 2020 12:14:19 +0000 (08:14 -0400)] 
use event API now that it fully supports EVFILT_PROC

So that we can waitpid() for child processes, even if we don't
define a callback.  We just want the zombie children to be
cleaned up.

5 years agohack to get EVFILT_PROC on Linux
Alan T. DeKok [Mon, 31 Aug 2020 12:12:36 +0000 (08:12 -0400)] 
hack to get EVFILT_PROC on Linux

Tested on OSX, and split out with #ifdef's.

We will try to get travis succeeding 100% of the time, even if
it means brute-force calling waitpid()

once libkqueue supports EVFILT_PROC, this hack can be removed.

5 years agouse new comparison functions for clarity
Alan T. DeKok [Sun, 30 Aug 2020 08:57:18 +0000 (04:57 -0400)] 
use new comparison functions for clarity

5 years agoadd COMPARE_PREFER_SMALLER / LARGER
Alan T. DeKok [Sun, 30 Aug 2020 08:56:59 +0000 (04:56 -0400)] 
add COMPARE_PREFER_SMALLER / LARGER

for ordered comparisons

5 years agouse stable comparison function in address_cmp()
Alan T. DeKok [Sat, 29 Aug 2020 20:00:46 +0000 (16:00 -0400)] 
use stable comparison function in address_cmp()

and go back to just using talloc_free()

5 years agodefine a stable comparison macro
Alan T. DeKok [Sat, 29 Aug 2020 19:52:12 +0000 (15:52 -0400)] 
define a stable comparison macro

so we use less code

5 years agotypo
Alan T. DeKok [Sat, 29 Aug 2020 19:25:18 +0000 (15:25 -0400)] 
typo

5 years agotemporarily copy destruct into packet_expiry_timer
Alan T. DeKok [Sat, 29 Aug 2020 18:16:13 +0000 (14:16 -0400)] 
temporarily copy destruct into packet_expiry_timer

5 years agocall fr_network_listen_send() with the correct listener
Alan T. DeKok [Sat, 29 Aug 2020 13:50:59 +0000 (09:50 -0400)] 
call fr_network_listen_send() with the correct listener

so that duplicates aren't dropped.  When we call with the child
listener, it is unknown to the network API.  Which then drops it.

We really need a way to separate dedup for RADIUS auth and acct
packets.  We do dedup for auth, but not for acct

5 years agomore checks for localized messages
Alan T. DeKok [Sat, 29 Aug 2020 13:43:18 +0000 (09:43 -0400)] 
more checks for localized messages

5 years agodelete the PID event before calling it.
Alan T. DeKok [Fri, 28 Aug 2020 16:57:58 +0000 (12:57 -0400)] 
delete the PID event before calling it.

and allow "callback" to be NULL.  In which case we just wait for
the PID, and don't run any callback

Also clean up the parent pointer when the event is freed.
Just as with the event_timer code

5 years agoreset destructor if it's not in the tree
Alan T. DeKok [Fri, 28 Aug 2020 13:59:44 +0000 (09:59 -0400)] 
reset destructor if it's not in the tree

5 years agoclean up logic around adding timer:
Alan T. DeKok [Fri, 28 Aug 2020 13:16:06 +0000 (09:16 -0400)] 
clean up logic around adding timer:

5 years agotracking tables are per-client
Alan T. DeKok [Fri, 28 Aug 2020 12:52:58 +0000 (08:52 -0400)] 
tracking tables are per-client

5 years agoclean up tracking structure
Alan T. DeKok [Fri, 28 Aug 2020 12:52:33 +0000 (08:52 -0400)] 
clean up tracking structure

we no longer use track->entry or track->in_dedup_tree

5 years agoOnly attempt to link ctxs if we have a ctx to link
Arran Cudbard-Bell [Thu, 27 Aug 2020 20:16:29 +0000 (15:16 -0500)] 
Only attempt to link ctxs if we have a ctx to link

5 years agopool: Produce error if we fail linking talloc ctxs
Arran Cudbard-Bell [Thu, 27 Aug 2020 20:15:56 +0000 (15:15 -0500)] 
pool: Produce error if we fail linking talloc ctxs

5 years agoset separate destructors for dedup and no-dedup listeners
Alan T. DeKok [Thu, 27 Aug 2020 14:22:40 +0000 (10:22 -0400)] 
set separate destructors for dedup and no-dedup listeners

5 years agore-enable test.radclient
Alan T. DeKok [Thu, 27 Aug 2020 13:35:12 +0000 (09:35 -0400)] 
re-enable test.radclient

5 years agoadd _const
Alan T. DeKok [Thu, 27 Aug 2020 12:35:50 +0000 (08:35 -0400)] 
add _const

5 years agoLet's think about things a little more
Alan T. DeKok [Thu, 27 Aug 2020 12:03:41 +0000 (08:03 -0400)] 
Let's think about things a little more

5 years agoremove debug sanity checks as not helpful
Alan T. DeKok [Thu, 27 Aug 2020 12:00:27 +0000 (08:00 -0400)] 
remove debug sanity checks as not helpful

5 years agobetter checks for duplicates
Alan T. DeKok [Thu, 27 Aug 2020 11:57:00 +0000 (07:57 -0400)] 
better checks for duplicates

it helps to initialize "is_dup" to false.
It also helps to check "is_dup" before declaring the packet
a duplicate

5 years agoMore talloc_get_type_abort where assigning from void
Jorge Pereira [Thu, 27 Aug 2020 00:45:23 +0000 (21:45 -0300)] 
More talloc_get_type_abort where assigning from void

5 years agolib/curl: add libraries for when this is being included
Matthew Newton [Thu, 27 Aug 2020 01:50:11 +0000 (02:50 +0100)] 
lib/curl: add libraries for when this is being included

Otherwise e.g. rlm_rest won't get linked against libfreeradius-json

5 years ago:dart: io/master.c: Run talloc_get_type_abort on more things
Jorge Pereira [Wed, 26 Aug 2020 22:30:22 +0000 (19:30 -0300)] 
:dart: io/master.c: Run talloc_get_type_abort on more things

5 years agotacacs: The authorization_failed() should use Authorization-Status
Jorge Pereira [Wed, 26 Aug 2020 21:10:26 +0000 (18:10 -0300)] 
tacacs: The authorization_failed() should use Authorization-Status

5 years agotacacs: Fix Authorization reply set
Jorge Pereira [Wed, 26 Aug 2020 21:07:19 +0000 (18:07 -0300)] 
tacacs: Fix Authorization reply set

5 years agoOver zealous search and replace
Arran Cudbard-Bell [Wed, 26 Aug 2020 17:51:50 +0000 (12:51 -0500)] 
Over zealous search and replace

5 years agoIn the new code "unparsed" types are actually parsed, they just have unresolved compo...
Arran Cudbard-Bell [Wed, 26 Aug 2020 17:45:10 +0000 (12:45 -0500)] 
In the new code "unparsed" types are actually parsed, they just have unresolved components

5 years agostrerror: Add marker variants for pushing markers onto the error stack
Arran Cudbard-Bell [Wed, 26 Aug 2020 17:31:06 +0000 (12:31 -0500)] 
strerror:  Add marker variants for pushing markers onto the error stack

5 years agoFix UBSAN complaint at debug level 3
Arran Cudbard-Bell [Wed, 26 Aug 2020 17:16:37 +0000 (12:16 -0500)] 
Fix UBSAN complaint at debug level 3

5 years agoallow "map foo { ...}"
Alan T. DeKok [Wed, 26 Aug 2020 17:28:01 +0000 (13:28 -0400)] 
allow "map foo { ...}"

because src/tests/modules/client/map.unlang needs it

5 years agoremove unused variable
Alan T. DeKok [Wed, 26 Aug 2020 17:25:51 +0000 (13:25 -0400)] 
remove unused variable

5 years agocheck policy names against key words
Alan T. DeKok [Wed, 26 Aug 2020 16:18:27 +0000 (12:18 -0400)] 
check policy names against key words

5 years agobetter way to do map / if / elsif
Alan T. DeKok [Wed, 26 Aug 2020 16:13:11 +0000 (12:13 -0400)] 
better way to do map / if / elsif

add a flag to the CONF_SECTION, which means that the parser
is more strict about where keywords go, and at the same time
ignores keywords like "map" when outside of the processing
sections

5 years agomap { ... } is allowed inside of a module configuration
Alan T. DeKok [Wed, 26 Aug 2020 14:31:11 +0000 (10:31 -0400)] 
map { ... } is allowed inside of a module configuration

5 years ago'map' can exist in module configurations, too
Alan T. DeKok [Wed, 26 Aug 2020 13:52:01 +0000 (09:52 -0400)] 
'map' can exist in module configurations, too

5 years agoAdd config to support DHCP-Inform packets to v4
Nick Porter [Tue, 25 Aug 2020 17:24:05 +0000 (18:24 +0100)] 
Add config to support DHCP-Inform packets to v4

5 years agoAllow the developer build macro WITH_VERIFY_PTR to be disabled
Alan T. DeKok [Tue, 25 Aug 2020 19:50:20 +0000 (15:50 -0400)] 
Allow the developer build macro WITH_VERIFY_PTR to be disabled

-DWITH_VERIFY_PTR=1 significantly scews the function call profile.

Manual port of commit #5370cbddbb9d

5 years agostrerror: Split out tests and always build them
Arran Cudbard-Bell [Tue, 25 Aug 2020 18:06:47 +0000 (13:06 -0500)] 
strerror: Split out tests and always build them

5 years agotacacs: Add state support
Jorge Pereira [Tue, 25 Aug 2020 00:58:59 +0000 (21:58 -0300)] 
tacacs: Add state support

5 years agomatch dictionary changes
Alan T. DeKok [Tue, 25 Aug 2020 12:10:55 +0000 (08:10 -0400)] 
match dictionary changes

5 years agospecfile: add missing ippool-dhcp files
Matthew Newton [Tue, 25 Aug 2020 11:56:18 +0000 (12:56 +0100)] 
specfile: add missing ippool-dhcp files

making things actually readable is nice

5 years agoadd policies to do PAP and CHAP for TACACS+
Alan T. DeKok [Tue, 25 Aug 2020 11:43:48 +0000 (07:43 -0400)] 
add policies to do PAP and CHAP for TACACS+

which converts the TACACS+ stuff to RADIUS, and then runs
PAP / CHAP / whatever

We still have to do this, as the various authentication modules
are not yet protocol agnostic.

5 years agorun "accounting %{TACACS-Accounting-Flags}" sections
Alan T. DeKok [Tue, 25 Aug 2020 00:20:55 +0000 (20:20 -0400)] 
run "accounting %{TACACS-Accounting-Flags}" sections

which do start / update / stop

5 years agoupdate various flag fields
Alan T. DeKok [Tue, 25 Aug 2020 00:10:20 +0000 (20:10 -0400)] 
update various flag fields

value 0 is "none"

as many of the flags are really bit fields, add values where
multiple bits are set.

5 years agoadd padding
Alan T. DeKok [Mon, 24 Aug 2020 23:50:32 +0000 (19:50 -0400)] 
add padding

so that virtual_server_compile_sections() gets offsets > 0

5 years agoLet's state API print the used 'da' name
Jorge Pereira [Mon, 24 Aug 2020 20:44:37 +0000 (17:44 -0300)] 
Let's state API print the used 'da' name

5 years agoremove unused variable
Alan T. DeKok [Mon, 24 Aug 2020 20:26:07 +0000 (16:26 -0400)] 
remove unused variable

5 years agocheck for "bad shared secret" is already in proto_tacacs.c
Alan T. DeKok [Mon, 24 Aug 2020 20:21:54 +0000 (16:21 -0400)] 
check for "bad shared secret" is already in proto_tacacs.c

5 years agolist tcp first
Alan T. DeKok [Mon, 24 Aug 2020 20:20:48 +0000 (16:20 -0400)] 
list tcp first

5 years agotypo
Alan T. DeKok [Mon, 24 Aug 2020 20:17:40 +0000 (16:17 -0400)] 
typo

5 years agotacacs: Add TACACS+ protocol module for accounting
Jorge Pereira [Mon, 24 Aug 2020 14:07:55 +0000 (11:07 -0300)] 
tacacs: Add TACACS+ protocol module for accounting

5 years agotacacs: Update raddb/sites-available/tacacs
Jorge Pereira [Tue, 11 Aug 2020 23:13:56 +0000 (20:13 -0300)] 
tacacs: Update raddb/sites-available/tacacs

5 years agoshut up scanner
Alan T. DeKok [Mon, 24 Aug 2020 19:29:51 +0000 (15:29 -0400)] 
shut up scanner

5 years agorealize underlying data type if we can
Alan T. DeKok [Mon, 24 Aug 2020 19:06:34 +0000 (15:06 -0400)] 
realize underlying data type if we can

5 years agoremove redundancy
Alan T. DeKok [Mon, 24 Aug 2020 18:42:12 +0000 (14:42 -0400)] 
remove redundancy

5 years agoadd fr_dns_label_from_value_box_dbuff()
Alan T. DeKok [Mon, 24 Aug 2020 18:40:25 +0000 (14:40 -0400)] 
add fr_dns_label_from_value_box_dbuff()

which returns <0 when it needs more data