]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agofall back to component method if named method doesn't exist
Alan T. DeKok [Tue, 4 Aug 2020 12:44:39 +0000 (08:44 -0400)] 
fall back to component method if named method doesn't exist

5 years agoprefer named methods instead of old-style methods
Alan T. DeKok [Tue, 4 Aug 2020 12:33:53 +0000 (08:33 -0400)] 
prefer named methods instead of old-style methods

5 years agothe PID can be zero if it timed out
Alan T. DeKok [Tue, 4 Aug 2020 12:14:20 +0000 (08:14 -0400)] 
the PID can be zero if it timed out

5 years agosave the processes exit status, not the raw one
Alan T. DeKok [Tue, 4 Aug 2020 12:10:00 +0000 (08:10 -0400)] 
save the processes exit status, not the raw one

5 years agosbuff: Simplify macros and reduce line count by using generics to make the same macro...
Arran Cudbard-Bell [Tue, 4 Aug 2020 00:52:16 +0000 (20:52 -0400)] 
sbuff: Simplify macros and reduce line count by using generics to make the same macros work with sbuffs and markers

5 years agosbuff: Unused char classes
Arran Cudbard-Bell [Mon, 3 Aug 2020 21:42:21 +0000 (17:42 -0400)] 
sbuff: Unused char classes

5 years agoremove unused variable
Alan T. DeKok [Sun, 2 Aug 2020 20:03:14 +0000 (16:03 -0400)] 
remove unused variable

5 years agoremove allocate_clear
Alan T. DeKok [Sun, 2 Aug 2020 19:16:42 +0000 (15:16 -0400)] 
remove allocate_clear

it can cause issues when SKIP_LOCKED is used.  There is also no
real reason to clear IPs before allocating a new one.  The cleared
IPs had already been expired, so clearing them does nothing other
than remove MAC / NAS / etc. information.

This change results in slightly different behavior than in v3.
In v3, expired leases were more likely to be granted new IPs.
In v3, expired leases are more likely to be granted the same IP,
if it hasn't already been reused

5 years agolooks like some versions of antora don't like this being empty
Matthew Newton [Sun, 2 Aug 2020 16:26:50 +0000 (17:26 +0100)] 
looks like some versions of antora don't like this being empty

5 years agodon't run radclient on "make test"
Alan T. DeKok [Sun, 2 Aug 2020 15:38:29 +0000 (11:38 -0400)] 
don't run radclient on "make test"

until we find out what is wrong with the acct_3 test

5 years agoremove pre-proxy and post-proxy
Alan T. DeKok [Sun, 2 Aug 2020 15:04:04 +0000 (11:04 -0400)] 
remove pre-proxy and post-proxy

mods-available/ and sites-available/ still reference pre-proxy
they need to be updated to use the new proxying methods

5 years agoremove stats from old listeners
Alan T. DeKok [Sun, 2 Aug 2020 12:49:50 +0000 (08:49 -0400)] 
remove stats from old listeners

since the old listeners are completely unused, this is fine.

these changes are part of the general "clean up the server" fixes

5 years agoremove old-old listener stats
Alan T. DeKok [Sun, 2 Aug 2020 12:48:15 +0000 (08:48 -0400)] 
remove old-old listener stats

these are unused even in v3.  So we remove them for v4

5 years agoremove held_stats
Alan T. DeKok [Sun, 2 Aug 2020 12:38:47 +0000 (08:38 -0400)] 
remove held_stats

which were updated, but never examined.

5 years agono one uses WITH_BFD
Alan T. DeKok [Sun, 2 Aug 2020 12:33:58 +0000 (08:33 -0400)] 
no one uses WITH_BFD

5 years agoremove WITH_ACCOUNTING, but keep all of the accounting code.
Alan T. DeKok [Sun, 2 Aug 2020 12:32:41 +0000 (08:32 -0400)] 
remove WITH_ACCOUNTING,  but keep all of the accounting code.

There were a number of cases where it would still build accounting
functionality even when WITH_ACCOUNTING was not used.

5 years agoremove WITH_COA
Alan T. DeKok [Sun, 2 Aug 2020 12:26:49 +0000 (08:26 -0400)] 
remove WITH_COA

which was a special hack for incoming CoA packets. Now that
all of the processing is done in standard methods, this feature
is no longer relevant.

5 years agoremoved WITH_ASCEND_BINARY
Alan T. DeKok [Sun, 2 Aug 2020 02:22:10 +0000 (22:22 -0400)] 
removed WITH_ASCEND_BINARY

5 years agoremove WITH_DYNAMIC_CLIENTS
Alan T. DeKok [Sun, 2 Aug 2020 02:18:01 +0000 (22:18 -0400)] 
remove WITH_DYNAMIC_CLIENTS

5 years agoremove WITH_DHCP
Alan T. DeKok [Sun, 2 Aug 2020 02:07:52 +0000 (22:07 -0400)] 
remove WITH_DHCP

5 years agoFormatting
Arran Cudbard-Bell [Sat, 1 Aug 2020 16:31:58 +0000 (12:31 -0400)] 
Formatting

5 years agoAdd control{} for performance testings (#3508)
Jorge Pereira [Sat, 1 Aug 2020 04:34:56 +0000 (01:34 -0300)] 
Add control{} for performance testings (#3508)

It allows us to verify connection status using radmin.

5 years agoring_buffer_test: Fix typo (#3537)
Jorge Pereira [Sat, 1 Aug 2020 04:31:39 +0000 (01:31 -0300)] 
ring_buffer_test: Fix typo (#3537)

5 years agoFix use of table name
Arran Cudbard-Bell [Sat, 1 Aug 2020 03:10:30 +0000 (23:10 -0400)] 
Fix use of table name

5 years agoBetter initialiation of connections
Arran Cudbard-Bell [Sat, 1 Aug 2020 03:02:40 +0000 (23:02 -0400)] 
Better initialiation of connections

5 years agoTables must not be NULL terminated
Arran Cudbard-Bell [Sat, 1 Aug 2020 02:54:48 +0000 (22:54 -0400)] 
Tables must not be NULL terminated

5 years agotable: Record literal string length in tables to avoid using strlen during searches
Arran Cudbard-Bell [Sat, 1 Aug 2020 02:34:09 +0000 (22:34 -0400)] 
table: Record literal string length in tables to avoid using strlen during searches

5 years agosbuff: Allow parsing bools
Arran Cudbard-Bell [Sat, 1 Aug 2020 00:44:35 +0000 (20:44 -0400)] 
sbuff: Allow parsing bools

5 years agoTypo (#3548)
Terry Burton [Sat, 1 Aug 2020 00:15:35 +0000 (01:15 +0100)] 
Typo (#3548)

5 years agoFix bad table terminators
Arran Cudbard-Bell [Fri, 31 Jul 2020 22:25:05 +0000 (18:25 -0400)] 
Fix bad table terminators

5 years agotypo
Alan T. DeKok [Fri, 31 Jul 2020 19:19:33 +0000 (15:19 -0400)] 
typo

5 years agofix up #ifdef's
Alan T. DeKok [Fri, 31 Jul 2020 18:33:11 +0000 (14:33 -0400)] 
fix up #ifdef's

5 years agouse the correct tracking data structure
Alan T. DeKok [Fri, 31 Jul 2020 18:22:29 +0000 (14:22 -0400)] 
use the correct tracking data structure

5 years agoCreate DHCPv4 and DHCPv6 LDAP attributes, and renumber OIDs
Arran Cudbard-Bell [Fri, 31 Jul 2020 17:20:15 +0000 (13:20 -0400)] 
Create DHCPv4 and DHCPv6 LDAP attributes, and renumber OIDs

5 years agosbuff: Fix use of NULL pointer
Arran Cudbard-Bell [Fri, 31 Jul 2020 15:02:09 +0000 (11:02 -0400)] 
sbuff: Fix use of NULL pointer

5 years agoremove many unused or unnecessary WITH_FOO
Alan T. DeKok [Fri, 31 Jul 2020 14:53:26 +0000 (10:53 -0400)] 
remove many unused or unnecessary WITH_FOO

we should probably just get rid of all of them, TBH.  v4 uses
dynamic libraries for features which were compile-time changes
in v3.

5 years agosbuff: Typo in safecpy check
Arran Cudbard-Bell [Fri, 31 Jul 2020 14:39:49 +0000 (10:39 -0400)] 
sbuff: Typo in safecpy check

5 years agohex: Add allocating version of fr_bin2hex
Arran Cudbard-Bell [Fri, 31 Jul 2020 14:27:30 +0000 (10:27 -0400)] 
hex: Add allocating version of fr_bin2hex

5 years agodon't need to take address of ipaddr
Alan T. DeKok [Fri, 31 Jul 2020 13:51:21 +0000 (09:51 -0400)] 
don't need to take address of ipaddr

it's already a pointer

5 years agolog text on failure, too
Alan T. DeKok [Fri, 31 Jul 2020 13:40:39 +0000 (09:40 -0400)] 
log text on failure, too

5 years agoclean up and fix build
Alan T. DeKok [Fri, 31 Jul 2020 13:34:44 +0000 (09:34 -0400)] 
clean up and fix build

5 years agofix status code return
Alan T. DeKok [Fri, 31 Jul 2020 13:24:48 +0000 (09:24 -0400)] 
fix status code return

5 years agosimplify compile_call()
Alan T. DeKok [Fri, 31 Jul 2020 12:45:10 +0000 (08:45 -0400)] 
simplify compile_call()

so that it uses fewer special APIs

5 years agosimplify compile_call()
Alan T. DeKok [Fri, 31 Jul 2020 12:40:24 +0000 (08:40 -0400)] 
simplify compile_call()

so that it uses fewer special APIs

5 years agotravis fixes
Alan T. DeKok [Fri, 31 Jul 2020 11:41:19 +0000 (07:41 -0400)] 
travis fixes

5 years agoadd missing ;
Alan T. DeKok [Fri, 31 Jul 2020 11:34:25 +0000 (07:34 -0400)] 
add missing ;

5 years agocheck length of data copied
Alan T. DeKok [Fri, 31 Jul 2020 11:33:56 +0000 (07:33 -0400)] 
check length of data copied

5 years agoactually set YIADDR. Oops.
Alan T. DeKok [Fri, 31 Jul 2020 11:19:55 +0000 (07:19 -0400)] 
actually set YIADDR.  Oops.

And rearrange code so that the success case is first, which makes
it a bit easier to understand

5 years agoadd missing parameter
Alan T. DeKok [Fri, 31 Jul 2020 11:15:42 +0000 (07:15 -0400)] 
add missing parameter

5 years agomove "add arp entry" to arp library.
Alan T. DeKok [Fri, 31 Jul 2020 11:15:06 +0000 (07:15 -0400)] 
move "add arp entry" to arp library.

5 years agoclean up and enable updating ARP table entries.
Alan T. DeKok [Fri, 31 Jul 2020 11:03:46 +0000 (07:03 -0400)] 
clean up and enable updating ARP table entries.

5 years agows
Arran Cudbard-Bell [Fri, 31 Jul 2020 04:28:04 +0000 (00:28 -0400)] 
ws

5 years agosbuff: Simplify macros
Arran Cudbard-Bell [Fri, 31 Jul 2020 04:24:50 +0000 (00:24 -0400)] 
sbuff: Simplify macros

5 years agosbuff: Use preprocessor to figure out the length of terminal elements
Arran Cudbard-Bell [Fri, 31 Jul 2020 04:14:44 +0000 (00:14 -0400)] 
sbuff: Use preprocessor to figure out the length of terminal elements

Saves using strlen

5 years agosbuff: Add support for multibyte terminal chars
Arran Cudbard-Bell [Fri, 31 Jul 2020 03:38:48 +0000 (23:38 -0400)] 
sbuff: Add support for multibyte terminal chars

5 years agosbuff: Fix issue with buffer extensions
Arran Cudbard-Bell [Fri, 31 Jul 2020 03:38:29 +0000 (23:38 -0400)] 
sbuff: Fix issue with buffer extensions

5 years agoclean up and clarify the logic for sending DHCP replies
Alan T. DeKok [Thu, 30 Jul 2020 23:23:57 +0000 (19:23 -0400)] 
clean up and clarify the logic for sending DHCP replies

5 years agoprint out header attributes, too
Alan T. DeKok [Thu, 30 Jul 2020 20:55:16 +0000 (16:55 -0400)] 
print out header attributes, too

5 years agofix fr_dhcp_print_hex() to work
Alan T. DeKok [Thu, 30 Jul 2020 20:42:44 +0000 (16:42 -0400)] 
fix fr_dhcp_print_hex() to work

5 years agoclean up compile_empty()
Alan T. DeKok [Thu, 30 Jul 2020 19:59:53 +0000 (15:59 -0400)] 
clean up compile_empty()

so that it no longer needs fr_cond_type_t.

And clean up the various uses of "skipping if / elsif" so that
it makes more sense

5 years agosbuff: Fix integer output when next char is not terminal
Arran Cudbard-Bell [Thu, 30 Jul 2020 20:08:42 +0000 (16:08 -0400)] 
sbuff: Fix integer output when next char is not terminal

5 years agosbuff: Add overflow checks to advance and simplify setting marker positions
Arran Cudbard-Bell [Thu, 30 Jul 2020 18:14:09 +0000 (14:14 -0400)] 
sbuff: Add overflow checks to advance and simplify setting marker positions

5 years agoippool - mysql: Fix and comment SKIP LOCKED usage (#3544)
Thomas Faller [Thu, 30 Jul 2020 18:30:14 +0000 (20:30 +0200)] 
ippool - mysql: Fix and comment SKIP LOCKED usage (#3544)

5 years agodon't build VPs from NULL value box. Fixes #3545
Alan T. DeKok [Thu, 30 Jul 2020 12:10:30 +0000 (08:10 -0400)] 
don't build VPs from NULL value box.  Fixes #3545

5 years agodon't leave dangling pointers around
Alan T. DeKok [Wed, 29 Jul 2020 11:34:50 +0000 (07:34 -0400)] 
don't leave dangling pointers around

5 years agodbuff: fr_sbuff_set needs explicit cast for some operands
Arran Cudbard-Bell [Tue, 28 Jul 2020 21:34:47 +0000 (17:34 -0400)] 
dbuff: fr_sbuff_set needs explicit cast for some operands

5 years agoquiet clang scan
Arran Cudbard-Bell [Tue, 28 Jul 2020 19:54:05 +0000 (15:54 -0400)] 
quiet clang scan

5 years agoprint: Deal with empty octets boxes
Arran Cudbard-Bell [Tue, 28 Jul 2020 19:50:50 +0000 (15:50 -0400)] 
print: Deal with empty octets boxes

5 years agofix sign
Arran Cudbard-Bell [Tue, 28 Jul 2020 19:24:15 +0000 (15:24 -0400)] 
fix sign

5 years agohex: Fix clang scan issues
Arran Cudbard-Bell [Tue, 28 Jul 2020 18:40:54 +0000 (14:40 -0400)] 
hex: Fix clang scan issues

5 years agohex: Add explicit error checks
Arran Cudbard-Bell [Tue, 28 Jul 2020 18:23:03 +0000 (14:23 -0400)] 
hex: Add explicit error checks

5 years agoQuiet compiler
Arran Cudbard-Bell [Tue, 28 Jul 2020 17:44:03 +0000 (13:44 -0400)] 
Quiet compiler

5 years agoCan't set void to NULL
Arran Cudbard-Bell [Tue, 28 Jul 2020 17:22:02 +0000 (13:22 -0400)] 
Can't set void to NULL

5 years agoNot being able to alloc an array is an error
Arran Cudbard-Bell [Tue, 28 Jul 2020 17:05:40 +0000 (13:05 -0400)] 
Not being able to alloc an array is an error

5 years agosbuff: Convert hex functions
Arran Cudbard-Bell [Tue, 28 Jul 2020 04:53:27 +0000 (00:53 -0400)] 
sbuff: Convert hex functions

5 years agotypo
Alan T. DeKok [Tue, 28 Jul 2020 16:20:29 +0000 (12:20 -0400)] 
typo

5 years agotrack lease queries by giaddr, not chaddr
Alan T. DeKok [Tue, 28 Jul 2020 15:57:34 +0000 (11:57 -0400)] 
track lease queries by giaddr, not chaddr

5 years agosbuff: Switch to distinct in/out initialisers
Arran Cudbard-Bell [Tue, 28 Jul 2020 04:44:56 +0000 (00:44 -0400)] 
sbuff: Switch to distinct in/out initialisers

5 years agosbuff: typo
Arran Cudbard-Bell [Tue, 28 Jul 2020 04:09:01 +0000 (00:09 -0400)] 
sbuff: typo

5 years agosbuff: Quiet compiler
Arran Cudbard-Bell [Tue, 28 Jul 2020 03:31:59 +0000 (23:31 -0400)] 
sbuff: Quiet compiler

5 years agos/tmpl_unknown_attr_add/tmpl_define_unknown_attr/g
Arran Cudbard-Bell [Tue, 28 Jul 2020 03:23:39 +0000 (23:23 -0400)] 
s/tmpl_unknown_attr_add/tmpl_define_unknown_attr/g

5 years agosbuff: Fix operations on overlapping buffers
Arran Cudbard-Bell [Tue, 28 Jul 2020 03:09:18 +0000 (23:09 -0400)] 
sbuff: Fix operations on overlapping buffers

5 years agovalue/tmp/redis/unit: Fixup uses of fr_value_str_unescape which now uses sbuffs
Arran Cudbard-Bell [Mon, 27 Jul 2020 23:14:14 +0000 (19:14 -0400)] 
value/tmp/redis/unit: Fixup uses of fr_value_str_unescape which now uses sbuffs

5 years agosbuff: Fix trailing num char detection
Arran Cudbard-Bell [Mon, 27 Jul 2020 22:36:33 +0000 (18:36 -0400)] 
sbuff: Fix trailing num char detection

5 years agoRevert "round robin among network threads"
Arran Cudbard-Bell [Mon, 27 Jul 2020 19:48:58 +0000 (15:48 -0400)] 
Revert "round robin among network threads"

This reverts commit 6f9baf3fa57a03ace86404cd747a1806bd6eee64.

5 years agosbuff: Check for double escapes
Arran Cudbard-Bell [Mon, 27 Jul 2020 20:23:32 +0000 (16:23 -0400)] 
sbuff: Check for double escapes

5 years agosbuff: Always produce buffer for alloc sbuff functions
Arran Cudbard-Bell [Mon, 27 Jul 2020 20:14:04 +0000 (16:14 -0400)] 
sbuff: Always produce buffer for alloc sbuff functions

5 years agolibjson-c5 just landed in Debian
Herwin Weststrate [Mon, 27 Jul 2020 19:19:35 +0000 (21:19 +0200)] 
libjson-c5 just landed in Debian

5 years agoHandle SQLITE_BUSY as an error (#3539)
Nick Porter [Mon, 27 Jul 2020 19:35:59 +0000 (20:35 +0100)] 
Handle SQLITE_BUSY as an error (#3539)

Exclusive locks can cause SQLite to return an SQLITE_BUSY error.
Treating this as an error causes processing of the current packet to be
abandoned complete with clearing up of the query.  Previously it was
being treated as a need for a reconnect which was causing a memory leak
as the existing connection was not cleared before reconnecting.

5 years agosbuff: Unescape function should return the number of bytes written
Arran Cudbard-Bell [Mon, 27 Jul 2020 19:15:55 +0000 (15:15 -0400)] 
sbuff: Unescape function should return the number of bytes written

Like any well behaved function which writes out string data

5 years agosbuff: Trim talloced buffers
Arran Cudbard-Bell [Mon, 27 Jul 2020 19:04:52 +0000 (15:04 -0400)] 
sbuff: Trim talloced buffers

5 years agosbuff: Better formatting
Arran Cudbard-Bell [Mon, 27 Jul 2020 19:04:30 +0000 (15:04 -0400)] 
sbuff: Better formatting

5 years agosbuff: Add the ability to interpret certain escape characters, but not transform...
Arran Cudbard-Bell [Mon, 27 Jul 2020 17:14:55 +0000 (13:14 -0400)] 
sbuff: Add the ability to interpret certain escape characters, but not transform them

5 years agosbuff: Add the ability to process escape character sequences like \x<hex><hex> and...
Arran Cudbard-Bell [Mon, 27 Jul 2020 16:44:25 +0000 (12:44 -0400)] 
sbuff: Add the ability to process escape character sequences like \x<hex><hex> and \000

5 years agoround robin among network threads
Alan T. DeKok [Mon, 27 Jul 2020 12:59:39 +0000 (08:59 -0400)] 
round robin among network threads

5 years agosbuff: Add support for parsing unsigned integers passed as octal or hex
Arran Cudbard-Bell [Sun, 26 Jul 2020 02:34:10 +0000 (22:34 -0400)] 
sbuff: Add support for parsing unsigned integers passed as octal or hex

5 years agosbuff: I suppose we should use standard names
Arran Cudbard-Bell [Sat, 25 Jul 2020 22:13:34 +0000 (18:13 -0400)] 
sbuff: I suppose we should use standard names

5 years agosbuff: Add function to de-escape strings when copying them out of an sbuff
Arran Cudbard-Bell [Sat, 25 Jul 2020 22:09:57 +0000 (18:09 -0400)] 
sbuff: Add function to de-escape strings when copying them out of an sbuff

This makes dealing with config strings easier

5 years agosbuff: Protect against errant copies
Arran Cudbard-Bell [Sat, 25 Jul 2020 22:09:23 +0000 (18:09 -0400)] 
sbuff: Protect against errant copies

5 years agosbuff: Verify length constrained functions terminate output on zero length input
Arran Cudbard-Bell [Sat, 25 Jul 2020 21:34:31 +0000 (17:34 -0400)] 
sbuff: Verify length constrained functions terminate output on zero length input