]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoradsniff: Fix crash on exit.
Arran Cudbard-Bell [Thu, 14 May 2020 22:17:14 +0000 (17:17 -0500)] 
radsniff: Fix crash on exit.

6 years agoAdd HEX_MARKER macros
Arran Cudbard-Bell [Thu, 14 May 2020 20:29:08 +0000 (15:29 -0500)] 
Add HEX_MARKER macros

6 years agoradsniff: Fix event expiry, and "Waking up in" debug
Arran Cudbard-Bell [Thu, 14 May 2020 20:23:13 +0000 (15:23 -0500)] 
radsniff: Fix event expiry, and "Waking up in" debug

6 years agoevent: Only call talloc_get_type_abort when we know we have an event to check *sigh*
Arran Cudbard-Bell [Thu, 14 May 2020 19:53:20 +0000 (14:53 -0500)] 
event: Only call talloc_get_type_abort when we know we have an event to check *sigh*

6 years agodbuff: Move the condition inside of the compound literal in FR_DBUFF_RESERVE
Arran Cudbard-Bell [Thu, 14 May 2020 18:26:08 +0000 (13:26 -0500)] 
dbuff: Move the condition inside of the compound literal in FR_DBUFF_RESERVE

6 years agoCorrect FR_DBUF_MAX macro and add tests for it. (#3452)
James Jones [Thu, 14 May 2020 18:25:40 +0000 (13:25 -0500)] 
Correct FR_DBUF_MAX macro and add tests for it. (#3452)

6 years agoevent: Tidy up report output, and stop reports being quite so badly interleaved
Arran Cudbard-Bell [Thu, 14 May 2020 18:17:50 +0000 (13:17 -0500)] 
event: Tidy up report output, and stop reports being quite so badly interleaved

6 years agoevent: Fix various issues with reporting, closes #3451
Arran Cudbard-Bell [Thu, 14 May 2020 17:46:04 +0000 (12:46 -0500)] 
event: Fix various issues with reporting, closes #3451

6 years agos/rbtree_create/rbtree_alloc/ s/heap_create/heap_alloc/
Arran Cudbard-Bell [Thu, 14 May 2020 16:49:00 +0000 (11:49 -0500)] 
s/rbtree_create/rbtree_alloc/ s/heap_create/heap_alloc/

6 years agoevent: report function - remove magic numbers, fix build issue
Arran Cudbard-Bell [Thu, 14 May 2020 16:44:28 +0000 (11:44 -0500)] 
event: report function - remove magic numbers, fix build issue

6 years agoadd information on timers in the heap
Alan T. DeKok [Thu, 14 May 2020 16:17:47 +0000 (12:17 -0400)] 
add information on timers in the heap

6 years agoheap: Typo (#3450)
Jorge Pereira [Thu, 14 May 2020 13:59:47 +0000 (10:59 -0300)] 
heap: Typo (#3450)

6 years agodbuff: Dedup dbuff code
Arran Cudbard-Bell [Wed, 13 May 2020 20:49:53 +0000 (15:49 -0500)] 
dbuff: Dedup dbuff code

6 years agoAdd the ability to move signed integers into dbuffs. (#3446)
James Jones [Wed, 13 May 2020 19:07:04 +0000 (14:07 -0500)] 
Add the ability to move signed integers into dbuffs. (#3446)

6 years agoadd missing FALL-THROUGH
Alan T. DeKok [Wed, 13 May 2020 14:26:52 +0000 (10:26 -0400)] 
add missing FALL-THROUGH

6 years agotrunk: Don't call trunk_manage directly
Arran Cudbard-Bell [Tue, 12 May 2020 21:07:25 +0000 (16:07 -0500)] 
trunk: Don't call trunk_manage directly

6 years agotrunk: re-calculate the ratios when we're rebalancing
Arran Cudbard-Bell [Tue, 12 May 2020 18:52:01 +0000 (13:52 -0500)] 
trunk: re-calculate the ratios when we're rebalancing

6 years agotrunk: Change the way we assert in trunk_requests_per_conn
Arran Cudbard-Bell [Tue, 12 May 2020 17:36:51 +0000 (12:36 -0500)] 
trunk: Change the way we assert in trunk_requests_per_conn

6 years agotrunk: Add comments
Arran Cudbard-Bell [Tue, 12 May 2020 17:12:19 +0000 (12:12 -0500)] 
trunk: Add comments

6 years agoRevert "Sync conditions with trunk_manage"
Arran Cudbard-Bell [Tue, 12 May 2020 17:07:07 +0000 (12:07 -0500)] 
Revert "Sync conditions with trunk_manage"

This reverts commit 21da2ae9a510b95d10f1300730188ffbbc255dd1.

6 years agotrunk.c: s/_per_connnection/_per_connection/g
Jorge Pereira [Tue, 12 May 2020 01:35:34 +0000 (22:35 -0300)] 
trunk.c: s/_per_connnection/_per_connection/g

6 years agoSync conditions with trunk_manage
Arran Cudbard-Bell [Tue, 12 May 2020 14:18:07 +0000 (09:18 -0500)] 
Sync conditions with trunk_manage

6 years agofix scan warnings
Alan T. DeKok [Mon, 11 May 2020 21:30:31 +0000 (17:30 -0400)] 
fix scan warnings

6 years agoshut up compiler about alignment
Alan T. DeKok [Mon, 11 May 2020 21:26:52 +0000 (17:26 -0400)] 
shut up compiler about alignment

6 years agovalue: Don't zero out structures and then immdiately write data to them
Arran Cudbard-Bell [Mon, 11 May 2020 18:35:44 +0000 (13:35 -0500)] 
value: Don't zero out structures and then immdiately write data to them

...and as for uninitialised fields in compound literals containing garbage, c99 states that shouldn't be the case.

http://c0x.coding-guidelines.com/6.7.8.html 1677.

6 years agoif the dictionary has octets[n], then it's invalid for length != n
Alan T. DeKok [Mon, 11 May 2020 15:42:07 +0000 (11:42 -0400)] 
if the dictionary has octets[n], then it's invalid for length != n

6 years agoAdd ubuntu20 Dockerfiles
Matthew Newton [Mon, 11 May 2020 10:29:36 +0000 (11:29 +0100)] 
Add ubuntu20 Dockerfiles

6 years agocleanup
Alan T. DeKok [Sun, 10 May 2020 20:01:04 +0000 (16:01 -0400)] 
cleanup

6 years agoone more UNUSED
Alan T. DeKok [Sun, 10 May 2020 19:10:34 +0000 (15:10 -0400)] 
one more UNUSED

6 years agofix UNUSED
Alan T. DeKok [Sun, 10 May 2020 16:27:53 +0000 (12:27 -0400)] 
fix UNUSED

6 years agoupdated comments
Alan T. DeKok [Sun, 10 May 2020 16:17:56 +0000 (12:17 -0400)] 
updated comments

6 years agofor ICMPV6, also calculate checksum over the IPv6 pseudo-header
Alan T. DeKok [Sun, 10 May 2020 16:06:10 +0000 (12:06 -0400)] 
for ICMPV6, also calculate checksum over the IPv6 pseudo-header

6 years agoadd fr_ip6_pesudo_header_checksum()
Alan T. DeKok [Sun, 10 May 2020 15:57:47 +0000 (11:57 -0400)] 
add fr_ip6_pesudo_header_checksum()

6 years agomake rlm_icmp support ICMPv6
Alan T. DeKok [Sun, 10 May 2020 15:08:02 +0000 (11:08 -0400)] 
make rlm_icmp support ICMPv6

not (quite) tested yet.  But ICMPv4 still works

6 years agoadd fr_cap_net_raw() and use it
Alan T. DeKok [Sun, 10 May 2020 14:04:11 +0000 (10:04 -0400)] 
add fr_cap_net_raw() and use it

This function sets CAP_NET_RAW if possible.

6 years agouse fr_socket_bind() which does all necessary magic
Alan T. DeKok [Sun, 10 May 2020 12:57:12 +0000 (08:57 -0400)] 
use fr_socket_bind() which does all necessary magic

6 years agoemulate SO_BINDTODEVICE on systems which do not support it
Alan T. DeKok [Sun, 10 May 2020 12:56:36 +0000 (08:56 -0400)] 
emulate SO_BINDTODEVICE on systems which do not support it

6 years agoallow fr_socket_bind() to take NULL for src_ipaddr.
Alan T. DeKok [Sun, 10 May 2020 12:18:14 +0000 (08:18 -0400)] 
allow fr_socket_bind() to take NULL for src_ipaddr.

In which case it just tries to bind to the interface via
system-agnostic methods

6 years agoadded warning for unsupported configurations
Alan T. DeKok [Sat, 9 May 2020 19:29:36 +0000 (15:29 -0400)] 
added warning for unsupported configurations

6 years agocall destroy functions before talloc_free
Alan T. DeKok [Sat, 9 May 2020 19:26:48 +0000 (15:26 -0400)] 
call destroy functions before talloc_free

6 years agoallow icmp to bind to a source IP, too
Alan T. DeKok [Sat, 9 May 2020 19:04:53 +0000 (15:04 -0400)] 
allow icmp to bind to a source IP, too

6 years agoadd a unique counter
Alan T. DeKok [Sat, 9 May 2020 15:58:02 +0000 (11:58 -0400)] 
add a unique counter

so that multiple requests can ping the same IP address without
interfering with each other.

6 years agoand HTML-ize this, too
Alan T. DeKok [Sat, 9 May 2020 15:36:56 +0000 (11:36 -0400)] 
and HTML-ize this, too

6 years agofix asciidoc typo
Alan T. DeKok [Sat, 9 May 2020 15:36:31 +0000 (11:36 -0400)] 
fix asciidoc typo

6 years agotypo
Alan T. DeKok [Sat, 9 May 2020 15:35:31 +0000 (11:35 -0400)] 
typo

6 years agoAdd ICMP "ping" support
Alan T. DeKok [Sat, 9 May 2020 15:32:38 +0000 (11:32 -0400)] 
Add ICMP "ping" support

6 years agoensure that _all_ fields of vb_ip are initialized
Alan T. DeKok [Sat, 9 May 2020 15:25:11 +0000 (11:25 -0400)] 
ensure that _all_ fields of vb_ip are initialized

otherwise the struct has random garbage in it, and then
fr_value_box_cmp() doesn't work.  Because it just uses memcmp()
on the struct, and doesn't look at the fields.

6 years agoNo reason to be lazy...
Arran Cudbard-Bell [Sat, 9 May 2020 15:16:23 +0000 (10:16 -0500)] 
No reason to be lazy...

6 years agotmpl: More macro renaming
Arran Cudbard-Bell [Sat, 9 May 2020 15:13:03 +0000 (10:13 -0500)] 
tmpl: More macro renaming

6 years agojust use talloc. Fixes #3444
Alan T. DeKok [Sat, 9 May 2020 12:47:20 +0000 (08:47 -0400)] 
just use talloc. Fixes #3444

And use inst->filter for 'and %s', instead of the "filter"

6 years agoIP header length is in 32-bit words
Alan T. DeKok [Fri, 8 May 2020 19:26:10 +0000 (15:26 -0400)] 
IP header length is in 32-bit words

6 years agotmpl: Fix other weirdly named accessors
Arran Cudbard-Bell [Fri, 8 May 2020 23:54:54 +0000 (18:54 -0500)] 
tmpl: Fix other weirdly named accessors

6 years agotmpl: Fix type check macro name
Arran Cudbard-Bell [Fri, 8 May 2020 23:52:52 +0000 (18:52 -0500)] 
tmpl: Fix type check macro name

6 years agotmpl: quiet clang
Arran Cudbard-Bell [Fri, 8 May 2020 23:52:00 +0000 (18:52 -0500)] 
tmpl: quiet clang

6 years agotmpl: Account for TMPL_TYPE_MAX in switch statements
Arran Cudbard-Bell [Fri, 8 May 2020 21:35:35 +0000 (16:35 -0500)] 
tmpl:  Account for TMPL_TYPE_MAX in switch statements

6 years agotmpl: Fix consistency check
Arran Cudbard-Bell [Fri, 8 May 2020 21:31:52 +0000 (16:31 -0500)] 
tmpl: Fix consistency check

6 years agotmpl: Remove bad asserts
Arran Cudbard-Bell [Fri, 8 May 2020 21:24:05 +0000 (16:24 -0500)] 
tmpl: Remove bad asserts

6 years agos/FR_TOKEN/fr_token_t/
Arran Cudbard-Bell [Fri, 8 May 2020 21:20:45 +0000 (16:20 -0500)] 
s/FR_TOKEN/fr_token_t/

6 years agoone more...
Arran Cudbard-Bell [Fri, 8 May 2020 21:10:22 +0000 (16:10 -0500)] 
one more...

6 years agorename more tmpl types to be consistent
Arran Cudbard-Bell [Fri, 8 May 2020 21:09:03 +0000 (16:09 -0500)] 
rename more tmpl types to be consistent

6 years agoTMPL_TYPE_XLAT is the normal state, TMPL_TYPE_XLAT_UNPARSED is the exceptional one
Arran Cudbard-Bell [Fri, 8 May 2020 20:49:55 +0000 (15:49 -0500)] 
TMPL_TYPE_XLAT is the normal state, TMPL_TYPE_XLAT_UNPARSED is the exceptional one

6 years agoremove more proxy stuff
Arran Cudbard-Bell [Fri, 8 May 2020 19:43:46 +0000 (14:43 -0500)] 
remove more proxy stuff

6 years agoinclude header file
Alan T. DeKok [Fri, 8 May 2020 18:54:26 +0000 (14:54 -0400)] 
include header file

6 years agocURL: Fix type conflation with curl_multi_add_handle()
Terry Burton [Fri, 8 May 2020 15:40:14 +0000 (16:40 +0100)] 
cURL: Fix type conflation with curl_multi_add_handle()

6 years agomove to unlang_interpret_frame_talloc_ctx()
Alan T. DeKok [Fri, 8 May 2020 18:12:23 +0000 (14:12 -0400)] 
move to unlang_interpret_frame_talloc_ctx()

instead of unlang_module_frame_talloc_ctx()

the new function is more generic, and can be used in more places.

6 years agoadd timeouts to child ctx
Alan T. DeKok [Fri, 8 May 2020 18:05:20 +0000 (14:05 -0400)] 
add timeouts to child ctx

so that we can delete it when the frame is popped, or when the
xlat is resumed or cancelled.

There isn't really any good reason to keep the timeouts for
longer than that.

6 years agoMySQL: Use correct syntax for creating the radius user
Terry Burton [Fri, 8 May 2020 12:30:38 +0000 (13:30 +0100)] 
MySQL: Use correct syntax for creating the radius user

6 years agoStart stripping proxy lists
Arran Cudbard-Bell [Fri, 8 May 2020 18:07:27 +0000 (13:07 -0500)] 
Start stripping proxy lists

6 years agoattribute 999 is invalid for RADIUS
Alan T. DeKok [Fri, 8 May 2020 17:27:54 +0000 (13:27 -0400)] 
attribute 999 is invalid for RADIUS

there isn't much point in creating unknown attributes which
can't be sent on the wire.

6 years agomissed this
Alan T. DeKok [Fri, 8 May 2020 14:16:46 +0000 (10:16 -0400)] 
missed this

6 years agodecode attributes for unknown vendors
Alan T. DeKok [Fri, 8 May 2020 14:09:33 +0000 (10:09 -0400)] 
decode attributes for unknown vendors

the code was there, but no test case

6 years agorerun the tests if `radiusd.conf` changes, too
Alan T. DeKok [Fri, 8 May 2020 12:47:23 +0000 (08:47 -0400)] 
rerun the tests if `radiusd.conf` changes, too

6 years agoadd tests for actually sending invalid attributes
Alan T. DeKok [Fri, 8 May 2020 12:39:20 +0000 (08:39 -0400)] 
add tests for actually sending invalid attributes

If an attribute is unknown, it's type MUST be octets.  AND we can
encode it.  In fact, we generally MUST encode it, as the admin
is trying to work around stupid vendor issues.

<cough> SUPERMICRO </cough>

6 years agouse standard names
Alan T. DeKok [Thu, 7 May 2020 22:20:13 +0000 (18:20 -0400)] 
use standard names

6 years agoremove the "touch" file on error
Alan T. DeKok [Thu, 7 May 2020 19:43:59 +0000 (15:43 -0400)] 
remove the "touch" file on error

6 years agofix typo
Alan T. DeKok [Thu, 7 May 2020 19:35:28 +0000 (15:35 -0400)] 
fix typo

6 years agoadd output "touch" files for each test
Alan T. DeKok [Thu, 7 May 2020 19:23:28 +0000 (15:23 -0400)] 
add output "touch" files for each test

which should permit inter-test dependencies

6 years agoRename fr_dict_parent_common
Arran Cudbard-Bell [Thu, 7 May 2020 19:24:06 +0000 (14:24 -0500)] 
Rename fr_dict_parent_common

6 years agodlist: Add fr_dlist_talloc_reverse_free
Arran Cudbard-Bell [Thu, 7 May 2020 19:04:51 +0000 (14:04 -0500)] 
dlist: Add fr_dlist_talloc_reverse_free

Useful for freeing items which were parented by the previous item in the list.

6 years agoAdd talloc bstrdup
Arran Cudbard-Bell [Thu, 7 May 2020 19:04:19 +0000 (14:04 -0500)] 
Add talloc bstrdup

6 years agoUnused signals
Arran Cudbard-Bell [Thu, 7 May 2020 19:04:02 +0000 (14:04 -0500)] 
Unused signals

6 years agotests which use radiusd / radmin / radclient depend on the binaries, too
Alan T. DeKok [Thu, 7 May 2020 13:39:30 +0000 (09:39 -0400)] 
tests which use radiusd / radmin / radclient depend on the binaries, too

6 years agoMake the actual fr_value_box_to_network_dbuff() visible (#3435)
James Jones [Wed, 6 May 2020 22:28:09 +0000 (17:28 -0500)] 
Make the actual fr_value_box_to_network_dbuff() visible (#3435)

We also get rid of the internal protocol's dbuff wrapper around
fr_value_box_to_network(); we leave fr_value_box_to_network()
(itself now a wrapper around the dbuff version) in place so we can
move other protocols to dbuff one at a time.

6 years agoallow the module to process ARP replies, too
Alan T. DeKok [Wed, 6 May 2020 22:18:43 +0000 (18:18 -0400)] 
allow the module to process ARP replies, too

and it then doesn't reply, and doesn't run "send do-not-respond"

6 years agoMake ethernet.h the sole definer of ethernet_header_t
James Jones [Wed, 6 May 2020 14:22:45 +0000 (09:22 -0500)] 
Make ethernet.h the sole definer of ethernet_header_t

Member name references are now consistent with the now-sole definition.

6 years agotest.conf: Typo
Jorge Pereira [Wed, 6 May 2020 19:22:08 +0000 (16:22 -0300)] 
test.conf: Typo

6 years ago:gear: Fix 'make test.radiusd-c'
Jorge Pereira [Wed, 6 May 2020 18:29:17 +0000 (15:29 -0300)] 
:gear: Fix 'make test.radiusd-c'

It fixes the file stamp related to that test.

6 years agoTurn fr_value_box_to_network() into wrapper around dbuff version (#3425)
James Jones [Wed, 6 May 2020 19:09:58 +0000 (14:09 -0500)] 
Turn fr_value_box_to_network() into wrapper around dbuff version (#3425)

6 years ago:gear: Fix 'make test.modules' verbosity
Jorge Pereira [Wed, 6 May 2020 18:40:21 +0000 (15:40 -0300)] 
:gear: Fix 'make test.modules' verbosity

Lets keep the same behavior for all tests/modules/$name targets
whitout that 'OK' message.

6 years agofix typo.
Alan T. DeKok [Wed, 6 May 2020 12:13:09 +0000 (08:13 -0400)] 
fix typo.

We want to re-run the tests if the radmin binary changes

6 years agomove "copy data from request" to arp encoder
Alan T. DeKok [Tue, 5 May 2020 18:38:36 +0000 (14:38 -0400)] 
move "copy data from request" to arp encoder

which is really where it belongs

6 years agoFix 'make test.digest' build
Jorge Pereira [Wed, 6 May 2020 00:00:30 +0000 (21:00 -0300)] 
Fix 'make test.digest' build

6 years agoFix 'make test.radmin' build
Jorge Pereira [Tue, 5 May 2020 23:57:47 +0000 (20:57 -0300)] 
Fix 'make test.radmin' build

6 years agoFix 'make test.radclient' build
Jorge Pereira [Tue, 5 May 2020 23:34:35 +0000 (20:34 -0300)] 
Fix 'make test.radclient' build

6 years agoradiusd.mk: Fix missing .PHONY for 'make test.${name}.radiusd_start'
Jorge Pereira [Tue, 5 May 2020 23:34:04 +0000 (20:34 -0300)] 
radiusd.mk: Fix missing .PHONY for 'make test.${name}.radiusd_start'

6 years agotmpl: Have tmpl_value "return" a pointer to the box
Arran Cudbard-Bell [Tue, 5 May 2020 22:38:35 +0000 (17:38 -0500)] 
tmpl: Have tmpl_value "return" a pointer to the box

Makes it behave more like a function

6 years agotmpl: Switch to "getter" style tmpl macros in preparation for nested attribute refer...
Arran Cudbard-Bell [Tue, 5 May 2020 22:27:12 +0000 (17:27 -0500)] 
tmpl:  Switch to "getter" style tmpl macros in preparation for nested attribute references

6 years agoSQL IP pools howto: Reference the no-skip-locked SP for MariaDB and old MySQL
Terry Burton [Tue, 5 May 2020 19:10:57 +0000 (20:10 +0100)] 
SQL IP pools howto: Reference the no-skip-locked SP for MariaDB and old MySQL

6 years agoFix digest dictionary attributes
Jorge Pereira [Tue, 5 May 2020 19:11:18 +0000 (16:11 -0300)] 
Fix digest dictionary attributes

6 years agoTypo
Arran Cudbard-Bell [Tue, 5 May 2020 20:50:46 +0000 (15:50 -0500)] 
Typo