]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoscheduler: Debugging improvements
Arran Cudbard-Bell [Mon, 6 Apr 2020 16:54:45 +0000 (11:54 -0500)] 
scheduler: Debugging improvements

6 years agoInterpreter: Debugging improvements
Arran Cudbard-Bell [Mon, 6 Apr 2020 16:54:15 +0000 (11:54 -0500)] 
Interpreter: Debugging improvements

6 years agoworker: Debugging improvements
Arran Cudbard-Bell [Mon, 6 Apr 2020 16:53:55 +0000 (11:53 -0500)] 
worker: Debugging improvements

6 years agochannel: Expose signal names table
Arran Cudbard-Bell [Mon, 6 Apr 2020 02:55:49 +0000 (21:55 -0500)] 
channel: Expose signal names table

6 years agotypo in comments
Arran Cudbard-Bell [Mon, 6 Apr 2020 02:55:34 +0000 (21:55 -0500)] 
typo in comments

6 years agoevent: Defer event loop exit
Arran Cudbard-Bell [Mon, 6 Apr 2020 02:26:25 +0000 (21:26 -0500)] 
event: Defer event loop exit

Only process the exit on the next call to fr_event_corral to make exits more orderly and predictable.

6 years agorlm_radius: Remove invalid assert
Arran Cudbard-Bell [Mon, 6 Apr 2020 02:25:44 +0000 (21:25 -0500)] 
rlm_radius: Remove invalid assert

6 years agorlm_radius: There's a macro for that...
Arran Cudbard-Bell [Mon, 6 Apr 2020 02:25:24 +0000 (21:25 -0500)] 
rlm_radius: There's a macro for that...

6 years agodots and dashes are allowed
Alan T. DeKok [Mon, 6 Apr 2020 16:36:46 +0000 (12:36 -0400)] 
dots and dashes are allowed

6 years agodisallow '.' in attribute names
Alan T. DeKok [Mon, 6 Apr 2020 15:30:08 +0000 (11:30 -0400)] 
disallow '.' in attribute names

except for unknown attrs with OIDs: Attr-1.2.2.3

6 years agowe no longer need RADIUS attributes
Alan T. DeKok [Mon, 6 Apr 2020 13:14:06 +0000 (09:14 -0400)] 
we no longer need RADIUS attributes

6 years agoskip sending reply if we're exiting
Alan T. DeKok [Sat, 4 Apr 2020 19:46:53 +0000 (15:46 -0400)] 
skip sending reply if we're exiting

6 years agofix typo and simplify
Alan T. DeKok [Fri, 3 Apr 2020 22:20:01 +0000 (18:20 -0400)] 
fix typo and simplify

6 years agotrunk: Allow management whilst in a handler, but don't allow connections to be freed
Arran Cudbard-Bell [Sat, 4 Apr 2020 03:03:52 +0000 (21:03 -0600)] 
trunk: Allow management whilst in a handler, but don't allow connections to be freed

6 years agotrunk: Implement deferred connection freeing, and report if a connection has been...
Arran Cudbard-Bell [Sat, 4 Apr 2020 02:07:58 +0000 (20:07 -0600)] 
trunk: Implement deferred connection freeing, and report if a connection has been moved to the halted state from within the pop functions.

6 years agotrunk: Move request state log printing into a callable function
Arran Cudbard-Bell [Sat, 4 Apr 2020 02:06:19 +0000 (20:06 -0600)] 
trunk: Move request state log printing into a callable function

6 years agoconnection: Allow modification of watchers without re-insertion
Arran Cudbard-Bell [Sat, 4 Apr 2020 02:05:31 +0000 (20:05 -0600)] 
connection: Allow modification of watchers without re-insertion

Prevent multiple nested calls to the deferred signal processing function.

Fix issue with memory usage after stack frame returned

6 years agoglobal: Explicitly initialise instance counts
Arran Cudbard-Bell [Fri, 3 Apr 2020 23:23:58 +0000 (17:23 -0600)] 
global: Explicitly initialise instance counts

It really doesn't matter, but it means all the code looks the same...

6 years agoglobal: Have instance_count underflow if the free function is called too many times...
Arran Cudbard-Bell [Fri, 3 Apr 2020 23:22:41 +0000 (17:22 -0600)] 
global: Have instance_count underflow if the free function is called too many times...

6 years agotls: Don't need more indirection...
Arran Cudbard-Bell [Fri, 3 Apr 2020 23:10:41 +0000 (17:10 -0600)] 
tls: Don't need more indirection...

6 years agotls: Rename OpenSSL specific functions to fr_openssl_ and generic tls functions to...
Arran Cudbard-Bell [Fri, 3 Apr 2020 22:40:57 +0000 (16:40 -0600)] 
tls: Rename OpenSSL specific functions to fr_openssl_ and generic tls functions to fr_tls_

OpenSSL isn't great about prefixing its internal functions, and this helps when we're looking at stack traces.

6 years agoadd tests for fr_cursor_intersect* functions
James Jones [Fri, 3 Apr 2020 16:01:26 +0000 (11:01 -0500)] 
add tests for fr_cursor_intersect* functions

6 years agorun miscellaneous tests early in the game.
Alan T. DeKok [Fri, 3 Apr 2020 14:07:52 +0000 (10:07 -0400)] 
run miscellaneous tests early in the game.

right now it's just cursors, which are needed for the
unit tests.

6 years agoadded wrapper for miscellaneous tests
Alan T. DeKok [Fri, 3 Apr 2020 13:54:31 +0000 (09:54 -0400)] 
added wrapper for miscellaneous tests

6 years agorlm_radius: Disassociate the REQUEST * with its treq on completion
Arran Cudbard-Bell [Thu, 2 Apr 2020 23:45:39 +0000 (17:45 -0600)] 
rlm_radius: Disassociate the REQUEST * with its treq on completion

Issues with treqs being signalled after they're no longer being bound to a REQUEST *.

6 years agotrunk: Write out a message if the request state log was empty
Arran Cudbard-Bell [Thu, 2 Apr 2020 23:22:47 +0000 (17:22 -0600)] 
trunk: Write out a message if the request state log was empty

6 years agoconnection: make the deferred signal processor immune to the connection being freed...
Arran Cudbard-Bell [Thu, 2 Apr 2020 23:15:41 +0000 (17:15 -0600)] 
connection: make the deferred signal processor immune to the connection being freed out from under it...

6 years agotrunk_tests: Fix clang scan issue
Arran Cudbard-Bell [Thu, 2 Apr 2020 22:47:48 +0000 (16:47 -0600)] 
trunk_tests: Fix clang scan issue

6 years agocursor: Fix merge tests
Arran Cudbard-Bell [Thu, 2 Apr 2020 22:15:38 +0000 (16:15 -0600)] 
cursor: Fix merge tests

6 years agotrunk: Typo
Arran Cudbard-Bell [Thu, 2 Apr 2020 21:52:25 +0000 (15:52 -0600)] 
trunk: Typo

6 years agomake dhcpv4 use an iterator. This includes making dhcpv4_encode_xlat() only
James Jones [Thu, 2 Apr 2020 14:48:54 +0000 (09:48 -0500)] 
make dhcpv4 use an iterator. This includes making dhcpv4_encode_xlat() only
pass dhcpv4-encodable items to fr_dhcpv4_encode_option().

6 years agoconnection: Fix missed state transition
Arran Cudbard-Bell [Thu, 2 Apr 2020 21:17:58 +0000 (15:17 -0600)] 
connection: Fix missed state transition

6 years agoconnection: Pause all signals, not just the deferred ones
Arran Cudbard-Bell [Thu, 2 Apr 2020 21:14:53 +0000 (15:14 -0600)] 
connection: Pause all signals, not just the deferred ones

6 years agotrunk: Add a log of state transitions to debug builds
Arran Cudbard-Bell [Thu, 2 Apr 2020 20:38:45 +0000 (14:38 -0600)] 
trunk: Add a log of state transitions to debug builds

6 years agocursor: Deal with the case where a and b are out of sync
Arran Cudbard-Bell [Thu, 2 Apr 2020 20:09:25 +0000 (14:09 -0600)] 
cursor: Deal with the case where a and b are out of sync

This allows something else to advance a, and then fr_cursor_intersect_next, to select the next pair in both sets.

6 years agotrunk: Fix unassigned/init assert
Arran Cudbard-Bell [Thu, 2 Apr 2020 20:07:06 +0000 (14:07 -0600)] 
trunk: Fix unassigned/init assert

6 years agocursor: Add note and guard for fr_cursor_intersect_* functions
Arran Cudbard-Bell [Thu, 2 Apr 2020 16:34:31 +0000 (10:34 -0600)] 
cursor: Add note and guard for fr_cursor_intersect_* functions

6 years agotest_point: Add missing field
Arran Cudbard-Bell [Thu, 2 Apr 2020 16:12:03 +0000 (10:12 -0600)] 
test_point: Add missing field

6 years agocursor: Add intersection functions
Arran Cudbard-Bell [Thu, 2 Apr 2020 15:06:00 +0000 (09:06 -0600)] 
cursor: Add intersection functions

6 years agoFix uint128_to_64 on systems without uint128_t
Herwin Weststrate [Thu, 2 Apr 2020 08:37:01 +0000 (10:37 +0200)] 
Fix uint128_to_64 on systems without uint128_t

6 years agoremove extraneous dependency
Alan T. DeKok [Wed, 1 Apr 2020 21:33:05 +0000 (17:33 -0400)] 
remove extraneous dependency

the PRE notation is for tests in the same directory, and we
don't need that here

6 years agofix encode / decode of boolean
Alan T. DeKok [Wed, 1 Apr 2020 21:26:19 +0000 (17:26 -0400)] 
fix encode / decode of boolean

Rapid-Commit should be boolean, not empty octets.

Encoding was correct, in that it skipped encoding the value.

Decoding was wrong, in that it called the standard "from network"
code, which looked for one byte of a boolean value.

6 years agoexport next_encodable, and use in tests
Alan T. DeKok [Wed, 1 Apr 2020 21:19:07 +0000 (17:19 -0400)] 
export next_encodable, and use in tests

6 years agoconvert dhcpv6 to use iterator
James Jones [Wed, 1 Apr 2020 18:10:33 +0000 (13:10 -0500)] 
convert dhcpv6 to use iterator

6 years agointernal: Decode multiple nested grouped VPs correctly
Arran Cudbard-Bell [Wed, 1 Apr 2020 19:59:53 +0000 (13:59 -0600)] 
internal: Decode multiple nested grouped VPs correctly

6 years agorest: Don't pass void *s around for the request handle
Arran Cudbard-Bell [Wed, 1 Apr 2020 19:59:37 +0000 (13:59 -0600)] 
rest: Don't pass void *s around for the request handle

We now have fr_curl_io_request_t so it makes much more sense to use that.  I'm not sure why we ever used void *.

6 years agoupdate comments
Alan T. DeKok [Wed, 1 Apr 2020 17:42:59 +0000 (13:42 -0400)] 
update comments

6 years agoadd PUSH_CHILD_GROUP for XLAT_CHILD
Alan T. DeKok [Wed, 1 Apr 2020 14:49:22 +0000 (10:49 -0400)] 
add PUSH_CHILD_GROUP for XLAT_CHILD

6 years agosupport using a smaller DH_KEY_SIZE when building docker containers ('dev' mode) 3343/head
Alexander Clouter [Wed, 1 Apr 2020 10:49:39 +0000 (11:49 +0100)] 
support using a smaller DH_KEY_SIZE when building docker containers ('dev' mode)

6 years agomake docker build faster and download less
Alexander Clouter [Sun, 29 Mar 2020 18:18:13 +0000 (19:18 +0100)] 
make docker build faster and download less

6 years agodockerbuild support to pass in build args for source (and branch)
Alexander Clouter [Mon, 30 Mar 2020 14:48:29 +0000 (15:48 +0100)] 
dockerbuild support to pass in build args for source (and branch)

6 years agodebian/sid uses libjson-c4
Alexander Clouter [Sun, 29 Mar 2020 14:15:28 +0000 (15:15 +0100)] 
debian/sid uses libjson-c4

6 years agodocker RIP Debian 'jessie' 8 (requires 1.0.2+ SSL for v4 build)
Alexander Clouter [Mon, 30 Mar 2020 14:47:04 +0000 (15:47 +0100)] 
docker RIP Debian 'jessie' 8 (requires 1.0.2+ SSL for v4 build)

6 years agodockerbuild script should die on error and not just blindly continue
Alexander Clouter [Sun, 29 Mar 2020 14:01:53 +0000 (15:01 +0100)] 
dockerbuild script should die on error and not just blindly continue

6 years agointernal: Last of the decoder fixes
Arran Cudbard-Bell [Wed, 1 Apr 2020 03:07:59 +0000 (21:07 -0600)] 
internal: Last of the decoder fixes

VP printing functions need fixing next....

6 years agointernal: Missed break
Arran Cudbard-Bell [Wed, 1 Apr 2020 03:00:15 +0000 (21:00 -0600)] 
internal: Missed break

6 years agointernal: Encode correct length
Arran Cudbard-Bell [Wed, 1 Apr 2020 03:00:02 +0000 (21:00 -0600)] 
internal: Encode correct length

6 years agointernal: Various decode fixes
Arran Cudbard-Bell [Wed, 1 Apr 2020 01:48:36 +0000 (19:48 -0600)] 
internal: Various decode fixes

6 years agoproto: Add hex marker macro
Arran Cudbard-Bell [Wed, 1 Apr 2020 01:34:29 +0000 (19:34 -0600)] 
proto: Add hex marker macro

6 years agolog: Fix marker indentation in fr_log_hex_marker
Arran Cudbard-Bell [Wed, 1 Apr 2020 01:34:14 +0000 (19:34 -0600)] 
log: Fix marker indentation in fr_log_hex_marker

6 years agointernal: Modify decode to produce TLV VPs sparingly...
Arran Cudbard-Bell [Wed, 1 Apr 2020 00:58:05 +0000 (18:58 -0600)] 
internal: Modify decode to produce TLV VPs sparingly...

6 years agoUsed
Arran Cudbard-Bell [Tue, 31 Mar 2020 22:30:14 +0000 (16:30 -0600)] 
Used

6 years agodhcpv6: Fix issue encoding groups (and reporting errors)
Arran Cudbard-Bell [Tue, 31 Mar 2020 22:24:58 +0000 (16:24 -0600)] 
dhcpv6: Fix issue encoding groups (and reporting errors)

6 years agouint128: Add explicit cast function for 128bit -> 64bit conversion
Arran Cudbard-Bell [Tue, 31 Mar 2020 20:59:51 +0000 (14:59 -0600)] 
uint128: Add explicit cast function for 128bit -> 64bit conversion

6 years agomove xlat code to unlang
Alan T. DeKok [Tue, 31 Mar 2020 20:43:35 +0000 (16:43 -0400)] 
move xlat code to unlang

because it's only ever used dynamically at run time.

And its needed for handling XLAT_CHILD as FR_TYPE_GROUP

6 years agointernal: More travis fixes....
Arran Cudbard-Bell [Tue, 31 Mar 2020 18:41:23 +0000 (12:41 -0600)] 
internal: More travis fixes....

6 years agonet: Although, yes, technically we don't need any bytes to represent zero, it's proba...
Arran Cudbard-Bell [Tue, 31 Mar 2020 18:41:01 +0000 (12:41 -0600)] 
net: Although, yes, technically we don't need any bytes to represent zero, it's probably still a good idea we write out one.

6 years agoglobal: Put FR_TYPE_GROUP in the correct group of enum values
Arran Cudbard-Bell [Tue, 31 Mar 2020 14:49:18 +0000 (08:49 -0600)] 
global: Put FR_TYPE_GROUP in the correct group of enum values

6 years agointernal: Fix iterating over children
Arran Cudbard-Bell [Tue, 31 Mar 2020 14:47:57 +0000 (08:47 -0600)] 
internal: Fix iterating over children

6 years agouse standard macro to skip whitespace
Alan T. DeKok [Tue, 31 Mar 2020 13:48:51 +0000 (09:48 -0400)] 
use standard macro to skip whitespace

6 years agowe should pretty much NEVER use "*++p". Instead, use *(p++)
Alan T. DeKok [Tue, 31 Mar 2020 13:46:30 +0000 (09:46 -0400)] 
we should pretty much NEVER use "*++p".  Instead, use *(p++)

The first one increments 'p' BEFORE assigning.  Which results
in uninitialized memory.

The second on increments 'p' AFTER assigning.  Which is what we want

6 years agocurl: Fix minor cosmetic issues
Arran Cudbard-Bell [Mon, 30 Mar 2020 20:31:57 +0000 (14:31 -0600)] 
curl: Fix minor cosmetic issues

6 years agotypo --> fr_dict_t
Alan T. DeKok [Fri, 27 Mar 2020 19:52:46 +0000 (15:52 -0400)] 
typo --> fr_dict_t

6 years agointernal: Fix failing test
Arran Cudbard-Bell [Sat, 28 Mar 2020 23:26:30 +0000 (17:26 -0600)] 
internal: Fix failing test

We don't automatically aggregate TLVs.

6 years agointernal: New encoder/decoder for IPC and serialisation
Arran Cudbard-Bell [Sat, 28 Mar 2020 22:05:29 +0000 (16:05 -0600)] 
internal: New encoder/decoder for IPC and serialisation

6 years agomisc: We want the position of the highest bit, not the highest bit itself
Arran Cudbard-Bell [Sat, 28 Mar 2020 04:04:23 +0000 (22:04 -0600)] 
misc: We want the position of the highest bit, not the highest bit itself

6 years agonet: Fix fr_net_from_uint64v
Arran Cudbard-Bell [Sat, 28 Mar 2020 04:03:58 +0000 (22:03 -0600)] 
net: Fix fr_net_from_uint64v

Start the copy from the right position

6 years agoradius: Should start encoding current position not head
Arran Cudbard-Bell [Fri, 27 Mar 2020 23:47:32 +0000 (17:47 -0600)] 
radius:  Should start encoding current position not head

6 years agounit_test_attribute: Switch to using iterator in encode_pair function
Arran Cudbard-Bell [Fri, 27 Mar 2020 23:45:10 +0000 (17:45 -0600)] 
unit_test_attribute: Switch to using iterator in encode_pair function

6 years agocurl: ignore all.mk
Arran Cudbard-Bell [Fri, 27 Mar 2020 22:58:52 +0000 (16:58 -0600)] 
curl: ignore all.mk

6 years agoExtend module tests for rlm_files (#3341)
Terry Burton [Fri, 27 Mar 2020 16:46:47 +0000 (16:46 +0000)] 
Extend module tests for rlm_files (#3341)

Test control and reply list modification operations.

6 years agoradius: Move to using an iterator for skipping non-encodable attributes
Arran Cudbard-Bell [Fri, 27 Mar 2020 14:29:18 +0000 (08:29 -0600)] 
radius: Move to using an iterator for skipping non-encodable attributes

6 years agopair: Add macro for checking for sufficient space in encode buffer
Arran Cudbard-Bell [Thu, 26 Mar 2020 22:26:45 +0000 (16:26 -0600)] 
pair: Add macro for checking for sufficient space in encode buffer

6 years agopair: Remove useless fields
Arran Cudbard-Bell [Thu, 26 Mar 2020 22:26:21 +0000 (16:26 -0600)] 
pair: Remove useless fields

6 years agomake {dhcpv[46], radius}/encode.c encodability functions as similar as possible
James Jones [Fri, 27 Mar 2020 12:58:26 +0000 (07:58 -0500)] 
make {dhcpv[46], radius}/encode.c encodability functions as similar as possible

6 years agoenocders: Create a struct for da_stack which includes depth.
Arran Cudbard-Bell [Thu, 26 Mar 2020 22:24:46 +0000 (16:24 -0600)] 
enocders: Create a struct for da_stack which includes depth.

Means we no longer have to memset the entire stack on each rebuild.

6 years agos/tlv_stack/da_stack/g
Arran Cudbard-Bell [Thu, 26 Mar 2020 21:32:51 +0000 (15:32 -0600)] 
s/tlv_stack/da_stack/g

It's used for more than TLVs

6 years agoscripts: Fix extraction destination
Arran Cudbard-Bell [Thu, 26 Mar 2020 21:31:48 +0000 (15:31 -0600)] 
scripts: Fix extraction destination

6 years agostop fighting with travis && just revert for now
Alan T. DeKok [Thu, 26 Mar 2020 17:28:13 +0000 (13:28 -0400)] 
stop fighting with travis && just revert for now

6 years agoadd for testing
Alan T. DeKok [Thu, 26 Mar 2020 17:28:02 +0000 (13:28 -0400)] 
add for testing

6 years agoone more dependency
Alan T. DeKok [Thu, 26 Mar 2020 16:43:32 +0000 (12:43 -0400)] 
one more dependency

it's still not clear why it runs multiple rules in parallel,
even when the rules say "don't do that"

6 years agoallow value box groups to be cast to strvalue / octets
Alan T. DeKok [Thu, 26 Mar 2020 16:39:19 +0000 (12:39 -0400)] 
allow value box groups to be cast to strvalue / octets

and printed

6 years agoUpdates dictionary.bskyb (#3340)
shaunmiles [Thu, 26 Mar 2020 16:07:37 +0000 (16:07 +0000)] 
Updates dictionary.bskyb (#3340)

* adds new attributes required by the business

Co-authored-by: Shaun Miles <shaun.miles@bskyb.com>
6 years agomore cleanups
Alan T. DeKok [Thu, 26 Mar 2020 15:56:48 +0000 (11:56 -0400)] 
more cleanups

6 years agogeneralize parsing of special tokens
Alan T. DeKok [Thu, 26 Mar 2020 14:29:19 +0000 (10:29 -0400)] 
generalize parsing of special tokens

6 years agoalso make ca.crt, what the heck
Alan T. DeKok [Thu, 26 Mar 2020 13:46:37 +0000 (09:46 -0400)] 
also make ca.crt, what the heck

6 years agoclean up rules so that they don't run all of the time
Alan T. DeKok [Thu, 26 Mar 2020 13:43:04 +0000 (09:43 -0400)] 
clean up rules so that they don't run all of the time

6 years agoclient, server, and ocsp need the ca crt
Alan T. DeKok [Wed, 25 Mar 2020 20:48:30 +0000 (16:48 -0400)] 
client, server, and ocsp need the ca crt

6 years agotrunk: Add state machine diagram for trunk connections
Arran Cudbard-Bell [Wed, 25 Mar 2020 21:36:27 +0000 (15:36 -0600)] 
trunk: Add state machine diagram for trunk connections

6 years agoscripts: Override fetchexclude when we're pulling from within the install_deps.sh...
Arran Cudbard-Bell [Wed, 25 Mar 2020 20:24:22 +0000 (14:24 -0600)] 
scripts: Override fetchexclude when we're pulling from within the install_deps.sh script