]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoDon't allow fr_trunk_connection_requests_requeue to run on draining or draining_to_free
Arran Cudbard-Bell [Fri, 21 Feb 2020 09:40:25 +0000 (10:40 +0100)] 
Don't allow fr_trunk_connection_requests_requeue to run on draining or draining_to_free

6 years agoDon't assume anything about the tconn state
Arran Cudbard-Bell [Fri, 21 Feb 2020 09:32:06 +0000 (10:32 +0100)] 
Don't assume anything about the tconn state

Kicks the can down the road for callers on trunk_connection_requests_requeue, but oh well

6 years agoUse correct enum value
Arran Cudbard-Bell [Thu, 20 Feb 2020 10:38:44 +0000 (11:38 +0100)] 
Use correct enum value

6 years agoAdd asserts around connection state
Arran Cudbard-Bell [Thu, 20 Feb 2020 08:16:00 +0000 (09:16 +0100)] 
Add asserts around connection state

6 years agos/trunk/pool - Should use the same config option for both pools and trunks (#3297)
Jorge Pereira [Thu, 20 Feb 2020 07:47:41 +0000 (04:47 -0300)] 
s/trunk/pool  - Should use the same config option for both pools and trunks (#3297)

6 years agos/trunk/pool - Should use the same config option for both pools and trunks
Arran Cudbard-Bell [Wed, 19 Feb 2020 16:58:52 +0000 (17:58 +0100)] 
s/trunk/pool  - Should use the same config option for both pools and trunks

6 years agoSingularise
Arran Cudbard-Bell [Wed, 19 Feb 2020 16:51:14 +0000 (17:51 +0100)] 
Singularise

6 years agoDeal with req_cleanup_delay == 0
Arran Cudbard-Bell [Wed, 19 Feb 2020 16:46:46 +0000 (17:46 +0100)] 
Deal with req_cleanup_delay == 0

6 years agoAllow fr_dlist_entry_in_list to work with "uninitialised" (but zeroed) list headers
Arran Cudbard-Bell [Wed, 19 Feb 2020 16:35:46 +0000 (17:35 +0100)] 
Allow fr_dlist_entry_in_list to work with "uninitialised" (but zeroed) list headers

6 years agoCleanup event code slightly
Arran Cudbard-Bell [Wed, 19 Feb 2020 14:03:38 +0000 (15:03 +0100)] 
Cleanup event code slightly

6 years agoCheck if timer is in pending list
Arran Cudbard-Bell [Wed, 19 Feb 2020 14:03:22 +0000 (15:03 +0100)] 
Check if timer is in pending list

6 years agoEnable corruption/type checking for event.c dlsts
Arran Cudbard-Bell [Wed, 19 Feb 2020 13:42:05 +0000 (14:42 +0100)] 
Enable corruption/type checking for event.c dlsts

6 years agoupdate cursor comments
Matthew Newton [Tue, 18 Feb 2020 17:23:23 +0000 (17:23 +0000)] 
update cursor comments

6 years agoRemove extraneous call to check_for_zombie, have check_for_zombie take tconn instead...
Arran Cudbard-Bell [Sun, 16 Feb 2020 19:01:37 +0000 (13:01 -0600)] 
Remove extraneous call to check_for_zombie, have check_for_zombie take tconn instead of h

6 years agos/udp_rcode_t/udp_result_t/ otherwise we have rcode->rcode everywhere which looks...
Arran Cudbard-Bell [Sun, 16 Feb 2020 18:02:14 +0000 (12:02 -0600)] 
s/udp_rcode_t/udp_result_t/ otherwise we have rcode->rcode everywhere which looks really dumb

6 years agoFix some magic numbers
Arran Cudbard-Bell [Sun, 16 Feb 2020 17:58:50 +0000 (11:58 -0600)] 
Fix some magic numbers

6 years agorevert until we find out why its failing
Alan T. DeKok [Sun, 16 Feb 2020 22:30:16 +0000 (17:30 -0500)] 
revert until we find out why its failing

this change appears to yield loops in pair lists?

6 years agoone last check for is_root
Alan T. DeKok [Sun, 16 Feb 2020 18:57:24 +0000 (13:57 -0500)] 
one last check for is_root

6 years agocheck for is_root here, too
Alan T. DeKok [Sun, 16 Feb 2020 16:10:15 +0000 (11:10 -0500)] 
check for is_root here, too

6 years agouse da->dict, to avoid talloc_parent
Alan T. DeKok [Sun, 16 Feb 2020 14:24:34 +0000 (09:24 -0500)] 
use da->dict, to avoid talloc_parent

6 years agoSlightly more meaningful goto
Arran Cudbard-Bell [Sat, 15 Feb 2020 18:58:03 +0000 (12:58 -0600)] 
Slightly more meaningful goto

Do all state signalling at the same call level

6 years agoAllow bound requests to survive requeue
Arran Cudbard-Bell [Sat, 15 Feb 2020 18:57:15 +0000 (12:57 -0600)] 
Allow bound requests to survive requeue

6 years agoremove unnecessary code
Alan T. DeKok [Sat, 15 Feb 2020 16:56:17 +0000 (11:56 -0500)] 
remove unnecessary code

6 years agojust use dlists...
Alan T. DeKok [Fri, 14 Feb 2020 21:25:33 +0000 (16:25 -0500)] 
just use dlists...

6 years agobe more accepting of corner cases
Alan T. DeKok [Fri, 14 Feb 2020 21:18:26 +0000 (16:18 -0500)] 
be more accepting of corner cases

6 years agoremove from ev_to_add on free, if necessary
Alan T. DeKok [Fri, 14 Feb 2020 21:05:45 +0000 (16:05 -0500)] 
remove from ev_to_add on free, if necessary

6 years agoShuffle function order
Arran Cudbard-Bell [Fri, 14 Feb 2020 18:59:57 +0000 (12:59 -0600)] 
Shuffle function order

6 years agoAdd public function to allow enqueuing on specific connections
Arran Cudbard-Bell [Fri, 14 Feb 2020 18:58:25 +0000 (12:58 -0600)] 
Add public function to allow enqueuing on specific connections

Allow requests to be requeued on an "inactive" connection.

6 years agoMake type name agree with enum values
Arran Cudbard-Bell [Fri, 14 Feb 2020 18:04:21 +0000 (12:04 -0600)] 
Make type name agree with enum values

6 years agoEnums before structs
Arran Cudbard-Bell [Fri, 14 Feb 2020 18:00:37 +0000 (12:00 -0600)] 
Enums before structs

6 years agoUpdate the auto-generated .adoc files
Jorge Pereira [Tue, 11 Feb 2020 02:30:30 +0000 (23:30 -0300)] 
Update the auto-generated .adoc files

6 years agoerrors can be at end of string
Alan T. DeKok [Thu, 13 Feb 2020 15:25:30 +0000 (10:25 -0500)] 
errors can be at end of string

6 years agoremove redunant declaration
Alan T. DeKok [Thu, 13 Feb 2020 15:04:14 +0000 (10:04 -0500)] 
remove redunant declaration

6 years agoset the FD to be readable when we're doing status checks
Alan T. DeKok [Thu, 13 Feb 2020 14:29:39 +0000 (09:29 -0500)] 
set the FD to be readable when we're doing status checks

6 years agostatus server checks should be sent more often
Alan T. DeKok [Thu, 13 Feb 2020 14:28:53 +0000 (09:28 -0500)] 
status server checks should be sent more often

6 years agowe don't need to wrong times
Alan T. DeKok [Wed, 12 Feb 2020 21:27:58 +0000 (16:27 -0500)] 
we don't need to wrong times

we don't need 9 digits of accuracy for max_request_time messages

we don't need to show how "cleanup - now" time.  That's the time
we over-ran max_request_time.  The user doesn't know what that
means.

6 years agodon't free rctx, it will die when the request dies
Alan T. DeKok [Wed, 12 Feb 2020 21:26:25 +0000 (16:26 -0500)] 
don't free rctx, it will die when the request dies

6 years agomore cleanups and corner cases
Alan T. DeKok [Wed, 12 Feb 2020 20:50:23 +0000 (15:50 -0500)] 
more cleanups and corner cases

6 years agofix checks for zombie period
Alan T. DeKok [Wed, 12 Feb 2020 20:05:37 +0000 (15:05 -0500)] 
fix checks for zombie period

there are many possible failure conditions, so we have to check
for them all, and handle them all.

6 years agodon't add multiples of the same attributes
Alan T. DeKok [Wed, 12 Feb 2020 19:56:04 +0000 (14:56 -0500)] 
don't add multiples of the same attributes

6 years agoIgnore leaks in getaddrinfo() at /usr/lib/system/libsystem_info.dylib (#3292)
Jorge Pereira [Wed, 12 Feb 2020 20:11:14 +0000 (17:11 -0300)] 
Ignore leaks in getaddrinfo() at /usr/lib/system/libsystem_info.dylib (#3292)

The leak is happening only on OSX >= Catalina + Clang8.

6 years agoDon't need accessor anymore
Arran Cudbard-Bell [Wed, 12 Feb 2020 15:12:50 +0000 (09:12 -0600)] 
Don't need accessor anymore

6 years agomake enums public, so callers can use them
Alan T. DeKok [Tue, 11 Feb 2020 21:19:40 +0000 (16:19 -0500)] 
make enums public, so callers can use them

6 years agofewer calls to fr_time()
Alan T. DeKok [Sat, 8 Feb 2020 14:07:41 +0000 (09:07 -0500)] 
fewer calls to fr_time()

6 years agocache "last updated" time
Alan T. DeKok [Sat, 8 Feb 2020 14:06:40 +0000 (09:06 -0500)] 
cache "last updated" time

6 years agoBackport dictionary changes from v3.0.x (#3276)
Jorge Pereira [Tue, 11 Feb 2020 01:09:12 +0000 (22:09 -0300)] 
Backport dictionary changes from v3.0.x (#3276)

6 years agoAdd Arista VSA 6-9
Hua Zhong [Thu, 6 Feb 2020 03:21:36 +0000 (19:21 -0800)] 
Add Arista VSA 6-9

6 years agoUpdate dictionary.wimax attributes (#3283)
Jorge Pereira [Fri, 7 Feb 2020 19:21:29 +0000 (16:21 -0300)] 
Update dictionary.wimax attributes (#3283)

It was based on the image "[0105] FIG. 9" in https://patents.google.com/patent/WO2009155120A2/en

Backport from v3.0.x #3282

6 years agodocument revive_interval
Alan T. DeKok [Fri, 7 Feb 2020 17:31:57 +0000 (12:31 -0500)] 
document revive_interval

6 years agoadd revive_interval
Alan T. DeKok [Fri, 7 Feb 2020 17:27:21 +0000 (12:27 -0500)] 
add revive_interval

6 years agoone last one
Alan T. DeKok [Fri, 7 Feb 2020 16:06:33 +0000 (11:06 -0500)] 
one last one

6 years agoFix WiMAX-MSK attribute
Jorge Pereira [Thu, 6 Feb 2020 23:50:36 +0000 (20:50 -0300)] 
Fix WiMAX-MSK attribute

6 years agosometimes the scanner is smart, too!
Alan T. DeKok [Fri, 7 Feb 2020 15:35:26 +0000 (10:35 -0500)] 
sometimes the scanner is smart, too!

6 years agocleanups and try to shut up scanner
Alan T. DeKok [Fri, 7 Feb 2020 15:15:07 +0000 (10:15 -0500)] 
cleanups and try to shut up scanner

6 years agomake status checks work
Alan T. DeKok [Fri, 7 Feb 2020 14:54:22 +0000 (09:54 -0500)] 
make status checks work

6 years agoabstract ID clearing for simplicity
Alan T. DeKok [Thu, 6 Feb 2020 20:12:48 +0000 (15:12 -0500)] 
abstract ID clearing for simplicity

6 years agobe better about zombies
Alan T. DeKok [Thu, 6 Feb 2020 14:44:03 +0000 (09:44 -0500)] 
be better about zombies

6 years agouse treq->rctx
Alan T. DeKok [Thu, 6 Feb 2020 14:19:04 +0000 (09:19 -0500)] 
use treq->rctx

6 years agocrash less often at exit
Alan T. DeKok [Thu, 6 Feb 2020 14:14:36 +0000 (09:14 -0500)] 
crash less often at exit

6 years agocheck for min before check for no requests
Alan T. DeKok [Thu, 6 Feb 2020 14:06:00 +0000 (09:06 -0500)] 
check for min before check for no requests

6 years agocleanups so it doesn't crash.
Alan T. DeKok [Thu, 6 Feb 2020 13:35:42 +0000 (08:35 -0500)] 
cleanups so it doesn't crash.

move "rcode" to udp_rctx_t
point to rctx from preq, otherwise it's impossible to update
rcode

6 years agojust use STRINGIFY, and revert previous changes
Alan T. DeKok [Wed, 5 Feb 2020 14:49:37 +0000 (09:49 -0500)] 
just use STRINGIFY, and revert previous changes

6 years agomore checks for zombie connections
Alan T. DeKok [Wed, 5 Feb 2020 14:08:15 +0000 (09:08 -0500)] 
more checks for zombie connections

6 years agopoint to the correct field
Alan T. DeKok [Wed, 5 Feb 2020 13:35:07 +0000 (08:35 -0500)] 
point to the correct field

6 years agojust use "4" instead of more magic. Fixes #3277
Alan T. DeKok [Wed, 5 Feb 2020 00:40:46 +0000 (19:40 -0500)] 
just use "4" instead of more magic.  Fixes #3277

6 years agoupdate and document
Alan T. DeKok [Tue, 4 Feb 2020 21:38:55 +0000 (16:38 -0500)] 
update and document

6 years agoclean up
Alan T. DeKok [Tue, 4 Feb 2020 21:10:17 +0000 (16:10 -0500)] 
clean up

6 years agobetter checks for zombie period
Alan T. DeKok [Sun, 2 Feb 2020 02:31:20 +0000 (21:31 -0500)] 
better checks for zombie period

don't start if there's been a long delay since we last sent
a packet.

And if we haven't seen any replies, start zombie_period from
when we last sent a packet.

6 years agomove zombie checks to request_timer
Alan T. DeKok [Sun, 2 Feb 2020 02:22:58 +0000 (21:22 -0500)] 
move zombie checks to request_timer

so that they're only run when a request times out

6 years agoFix cancellation function to do the right think on requeue
Arran Cudbard-Bell [Sat, 1 Feb 2020 22:42:36 +0000 (17:42 -0500)] 
Fix cancellation function to do the right think on requeue

6 years agoRemove treq and request from the udp_request
Arran Cudbard-Bell [Sat, 1 Feb 2020 21:17:35 +0000 (16:17 -0500)] 
Remove treq and request from the udp_request

Fix parenting of the udp_request.  Should be parented from the treq because its lifetime is bound to the treq, not to the REQUEST *.

It doesn't _really_ matter here, but it does mean we can take advantage of the talloc_pool/freelist in the trunk.

Where it does matter is for trunk protocols which do cancellations, as the REQUEST * and the rctx might go away, but the preq needs to live on so we can cancel any upstream queries.

6 years agoExpose the tconn's underlying conn
Arran Cudbard-Bell [Sat, 1 Feb 2020 21:15:51 +0000 (16:15 -0500)] 
Expose the tconn's underlying conn

6 years agoNot needed
Arran Cudbard-Bell [Sat, 1 Feb 2020 20:21:54 +0000 (15:21 -0500)] 
Not needed

6 years agoMake additional fields in conns and treqs public
Arran Cudbard-Bell [Sat, 1 Feb 2020 20:20:13 +0000 (15:20 -0500)] 
Make additional fields in conns and treqs public

6 years agoand another one...
Arran Cudbard-Bell [Sat, 1 Feb 2020 17:11:08 +0000 (12:11 -0500)] 
and another one...

6 years agoFix more NULL issues
Arran Cudbard-Bell [Sat, 1 Feb 2020 16:53:31 +0000 (11:53 -0500)] 
Fix more NULL issues

6 years agoSprinkle nonnull
Arran Cudbard-Bell [Sat, 1 Feb 2020 16:28:53 +0000 (11:28 -0500)] 
Sprinkle nonnull

6 years agoRemove duplicate dst_ipaddr/dst_port fields
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:59:53 +0000 (10:59 -0500)] 
Remove duplicate dst_ipaddr/dst_port fields

6 years agoTypo
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:56:45 +0000 (10:56 -0500)] 
Typo

6 years agoPrint the connection name on failure
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:49:43 +0000 (10:49 -0500)] 
Print the connection name on failure

6 years agoUse the provided el in more places
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:47:34 +0000 (10:47 -0500)] 
Use the provided el in more places

One more to go....

6 years agoFixup I/O functions to use the tconn
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:46:48 +0000 (10:46 -0500)] 
Fixup I/O functions to use the tconn

Yes it makes the error case more complex, oh well.

6 years agoGet the conn from the tconn
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:45:25 +0000 (10:45 -0500)] 
Get the conn from the tconn

6 years agoAdd argument to test muxer
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:00:27 +0000 (10:00 -0500)] 
Add argument to test muxer

6 years agoPass el to the muxer so that it can set timers.
Arran Cudbard-Bell [Sat, 1 Feb 2020 14:57:38 +0000 (09:57 -0500)] 
Pass el to the muxer so that it can set timers.

6 years agoupdate format of Proxy-State
Alan T. DeKok [Sat, 1 Feb 2020 14:31:28 +0000 (09:31 -0500)] 
update format of Proxy-State

4 octets of "my" random number
1 octet of how many of "my" Proxy-State we saw

this lets us know not only the admin configured a proxy loop,
but lets the module be doubly sure that it's a loop

6 years agoremove unused variable
Alan T. DeKok [Sat, 1 Feb 2020 14:24:05 +0000 (09:24 -0500)] 
remove unused variable

6 years agoremove unused variables
Alan T. DeKok [Sat, 1 Feb 2020 14:15:46 +0000 (09:15 -0500)] 
remove unused variables

6 years agomove zombie checks to request_fail
Alan T. DeKok [Sat, 1 Feb 2020 14:14:00 +0000 (09:14 -0500)] 
move zombie checks to request_fail

6 years agomove to use udp_connection_t
Alan T. DeKok [Sat, 1 Feb 2020 13:49:22 +0000 (08:49 -0500)] 
move to use udp_connection_t

as udp_handle_t may change over the lifetime of the request

6 years agoFix clang scan issues in the trunk code
Arran Cudbard-Bell [Sat, 1 Feb 2020 01:37:53 +0000 (20:37 -0500)] 
Fix clang scan issues in the trunk code

6 years agoNow used
Arran Cudbard-Bell [Sat, 1 Feb 2020 00:12:28 +0000 (19:12 -0500)] 
Now used

6 years agoRemove unused macro
Arran Cudbard-Bell [Fri, 31 Jan 2020 23:54:00 +0000 (18:54 -0500)] 
Remove unused macro

6 years agoAdd noreturn in acutest.h
Arran Cudbard-Bell [Fri, 31 Jan 2020 23:53:16 +0000 (18:53 -0500)] 
Add noreturn in acutest.h

6 years agoFix incompatible conversion (#3274)
Jorge Pereira [Fri, 31 Jan 2020 23:38:09 +0000 (20:38 -0300)] 
Fix incompatible conversion (#3274)

The udp_request_free() returns integer.

6 years agoFix typo with 'uctx' (#3275)
Jorge Pereira [Fri, 31 Jan 2020 23:25:15 +0000 (20:25 -0300)] 
Fix typo with 'uctx' (#3275)

6 years agofr_event_timer_delete doesn't need to take el
Arran Cudbard-Bell [Fri, 31 Jan 2020 22:35:52 +0000 (17:35 -0500)] 
fr_event_timer_delete doesn't need to take el

We should probably figure out something for the file descriptors too

6 years agoUse el where already available
Arran Cudbard-Bell [Fri, 31 Jan 2020 22:32:10 +0000 (17:32 -0500)] 
Use el where already available

6 years agomassive changes to switch to trunk API
Alan T. DeKok [Fri, 31 Jan 2020 19:12:55 +0000 (14:12 -0500)] 
massive changes to switch to trunk API

* basic send / receive works
* configuration works, but needs to be cleanup up and normalized
  * the mods-enabled/radius default config hasn't yet been updated
* zombie checks should work
* status-server should work

* it does not yet track "open to fail" states.  i.e. when it has
  multiple open / active connections that all fail, it should
  refuse to open new connections until one connection responds
  to status-server.

6 years agouse uint128.h
Alan T. DeKok [Thu, 30 Jan 2020 20:17:59 +0000 (15:17 -0500)] 
use uint128.h