]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agomove commonly used fields to the start of the struct
Alan T. DeKok [Fri, 10 Jan 2020 14:55:31 +0000 (09:55 -0500)] 
move commonly used fields to the start of the struct

this helps with cache lines and general organization

6 years agoremove unused macros
Alan T. DeKok [Thu, 9 Jan 2020 22:32:57 +0000 (17:32 -0500)] 
remove unused macros

6 years agomove EAP-TLS to common API
Alan T. DeKok [Thu, 9 Jan 2020 22:32:19 +0000 (17:32 -0500)] 
move EAP-TLS to common API

6 years agomove AKA' to common API
Alan T. DeKok [Thu, 9 Jan 2020 22:29:21 +0000 (17:29 -0500)] 
move AKA' to common API

6 years agouse the correct name for debugging
Alan T. DeKok [Thu, 9 Jan 2020 22:27:53 +0000 (17:27 -0500)] 
use the correct name for debugging

6 years agomove AKA to using common API
Alan T. DeKok [Thu, 9 Jan 2020 22:26:32 +0000 (17:26 -0500)] 
move AKA to using common API

6 years agomove EAP-SIM to using data structures and a common function
Alan T. DeKok [Thu, 9 Jan 2020 21:46:24 +0000 (16:46 -0500)] 
move EAP-SIM to using data structures and a common function

in preparation for further cleanup

6 years agoreturn the instruction if asked
Alan T. DeKok [Thu, 9 Jan 2020 21:41:31 +0000 (16:41 -0500)] 
return the instruction if asked

it's OK to compile the same section twice, but we should also
return the compiled instruction if asked

6 years agoreturn the number of compiled sections
Alan T. DeKok [Thu, 9 Jan 2020 21:33:38 +0000 (16:33 -0500)] 
return the number of compiled sections

6 years agoallocate the thing from the parent CONF_SECTION
Alan T. DeKok [Thu, 9 Jan 2020 18:27:10 +0000 (13:27 -0500)] 
allocate the thing from the parent CONF_SECTION

the previous changes should fix ordering issues

6 years agofix up dict / namespace checks
Alan T. DeKok [Thu, 9 Jan 2020 18:03:12 +0000 (13:03 -0500)] 
fix up dict / namespace checks

use correct type for dictionary lookups in cf_data_find()

if there's no listener, we MUST have a known dictionary

6 years agothis function should return 'const'
Alan T. DeKok [Thu, 9 Jan 2020 15:43:00 +0000 (10:43 -0500)] 
this function should return 'const'

6 years agofree the intermediate struct, too
Alan T. DeKok [Thu, 9 Jan 2020 15:39:05 +0000 (10:39 -0500)] 
free the intermediate struct, too

6 years agovns_tree may be NULL
Alan T. DeKok [Thu, 9 Jan 2020 15:08:30 +0000 (10:08 -0500)] 
vns_tree may be NULL

6 years agouse app->dict instead of more complex logic
Alan T. DeKok [Thu, 9 Jan 2020 14:56:08 +0000 (09:56 -0500)] 
use app->dict instead of more complex logic

remove namespace_on_read(), and add check for dictionary to
listen_on_read().

Also update the virtual_servers_instantiate() to look in the
vns_tree only if a dictionary was not previously defined.

6 years agorevert
Alan T. DeKok [Thu, 9 Jan 2020 14:29:19 +0000 (09:29 -0500)] 
revert

6 years agovns_tree MUST be created before we instantiate the virtual servers
Alan T. DeKok [Thu, 9 Jan 2020 14:26:55 +0000 (09:26 -0500)] 
vns_tree MUST be created before we instantiate the virtual servers

6 years agonamespace might not be in the vns tree
Alan T. DeKok [Thu, 9 Jan 2020 14:25:13 +0000 (09:25 -0500)] 
namespace might not be in the vns tree

6 years agoadd dict pointer to proto modules
Alan T. DeKok [Thu, 9 Jan 2020 14:08:09 +0000 (09:08 -0500)] 
add dict pointer to proto modules

6 years agoadd dict pointer
Alan T. DeKok [Thu, 9 Jan 2020 14:08:00 +0000 (09:08 -0500)] 
add dict pointer

6 years agoremove incorrect example
Alan T. DeKok [Thu, 9 Jan 2020 14:06:45 +0000 (09:06 -0500)] 
remove incorrect example

6 years agoAdd missing 'Profile' links
Jorge Pereira [Wed, 8 Jan 2020 00:23:34 +0000 (21:23 -0300)] 
Add missing 'Profile' links

6 years agoAt a broad overview of what happens on request enqueue
Arran Cudbard-Bell [Tue, 7 Jan 2020 22:00:17 +0000 (16:00 -0600)] 
At a broad overview of what happens on request enqueue

6 years agoDoxygen fixes
Arran Cudbard-Bell [Tue, 7 Jan 2020 21:33:38 +0000 (15:33 -0600)] 
Doxygen fixes

6 years agoUpdate doxyfile
Arran Cudbard-Bell [Tue, 7 Jan 2020 20:52:56 +0000 (14:52 -0600)] 
Update doxyfile

6 years agoFix the trunk API docs to make them a bit easier to understand
Arran Cudbard-Bell [Tue, 7 Jan 2020 18:55:19 +0000 (12:55 -0600)] 
Fix the trunk API docs to make them a bit easier to understand

6 years agodoxygen
Alan T. DeKok [Tue, 7 Jan 2020 18:21:27 +0000 (13:21 -0500)] 
doxygen

6 years agoThis too...
Arran Cudbard-Bell [Tue, 7 Jan 2020 17:58:35 +0000 (11:58 -0600)] 
This too...

6 years agoUse correct options for specifying signing CA in rlm_rest Closes #3237
Arran Cudbard-Bell [Tue, 7 Jan 2020 17:54:43 +0000 (11:54 -0600)] 
Use correct options for specifying signing CA in rlm_rest Closes #3237

6 years agomove scheduler to using config struct, instead of CONF_SECTION
Alan T. DeKok [Tue, 7 Jan 2020 14:36:45 +0000 (09:36 -0500)] 
move scheduler to using config struct, instead of CONF_SECTION

6 years agothese were deprecated in v3. They can be deleted in v4
Alan T. DeKok [Tue, 7 Jan 2020 13:42:17 +0000 (08:42 -0500)] 
these were deprecated in v3.  They can be deleted in v4

6 years agothere's no need for a header to include itself
Alan T. DeKok [Tue, 7 Jan 2020 13:39:55 +0000 (08:39 -0500)] 
there's no need for a header to include itself

6 years agoDisambiguate BPF vs RADIUS attribute filters in radsniff manpage (#3236)
Terry Burton [Mon, 6 Jan 2020 16:36:45 +0000 (16:36 +0000)] 
Disambiguate BPF vs RADIUS attribute filters in radsniff manpage (#3236)

6 years agoadd URL
Alan T. DeKok [Sat, 4 Jan 2020 14:03:39 +0000 (09:03 -0500)] 
add URL

6 years agobusy-loop processing requests for 0.1ms
Alan T. DeKok [Sat, 4 Jan 2020 14:01:37 +0000 (09:01 -0500)] 
busy-loop processing requests for 0.1ms

which means we're not polling the event loop after every request
has yielded.  Instead, run more requests until we spend 0.1ms
total processing requests.  This process significantly lowers
response latency in performance tests.

6 years agoonly resume if the request was stopped
Alan T. DeKok [Sat, 4 Jan 2020 13:57:24 +0000 (08:57 -0500)] 
only resume if the request was stopped

6 years agoallow load up to 400K PPS
Alan T. DeKok [Sat, 4 Jan 2020 13:53:46 +0000 (08:53 -0500)] 
allow load up to 400K PPS

6 years agoBackport policy OIDs from v3. ref #3230
Jorge Pereira [Fri, 3 Jan 2020 14:30:51 +0000 (11:30 -0300)] 
Backport policy OIDs from v3. ref #3230

6 years agoupdate copyright dates
Alan T. DeKok [Fri, 3 Jan 2020 02:02:55 +0000 (21:02 -0500)] 
update copyright dates

6 years agorun through reformatter
Alan T. DeKok [Fri, 3 Jan 2020 02:02:36 +0000 (21:02 -0500)] 
run through reformatter

6 years agoupdate "now" after running multiple timers
Alan T. DeKok [Thu, 2 Jan 2020 00:42:21 +0000 (19:42 -0500)] 
update "now" after running multiple timers

6 years agoremove unnecessary API
Alan T. DeKok [Thu, 2 Jan 2020 00:22:07 +0000 (19:22 -0500)] 
remove unnecessary API

6 years agosimplify logic
Alan T. DeKok [Wed, 1 Jan 2020 17:39:27 +0000 (12:39 -0500)] 
simplify logic

so that pop / run of request is all handled in one function

6 years agoAruba RADIUS dictionary update v2020-01
Tim Cappalli [Fri, 3 Jan 2020 00:20:44 +0000 (19:20 -0500)] 
Aruba RADIUS dictionary update v2020-01

6 years agoRevert "simplify logic a bit"
Alan T. DeKok [Mon, 30 Dec 2019 15:35:56 +0000 (10:35 -0500)] 
Revert "simplify logic a bit"

This reverts commit da1bdc2ef9e12cbc6ce82a7aa1c10a33c99476f0.

6 years agodon't print out -1 as a large positive number
Alan T. DeKok [Mon, 30 Dec 2019 15:13:02 +0000 (10:13 -0500)] 
don't print out -1 as a large positive number

6 years agosimplify logic a bit
Alan T. DeKok [Mon, 30 Dec 2019 15:08:18 +0000 (10:08 -0500)] 
simplify logic a bit

6 years agosimplify logic
Alan T. DeKok [Mon, 30 Dec 2019 15:04:29 +0000 (10:04 -0500)] 
simplify logic

if (!a || (a && b))

is really just

if (!a || b)

As "a is true" is implied by "!a" being false.

Found by PVS Studio

6 years agoAdd more tests for "radmin> set module"
Jorge Pereira [Thu, 26 Dec 2019 21:52:27 +0000 (18:52 -0300)] 
Add more tests for "radmin> set module"

6 years agomatch partial commands, too
Alan T. DeKok [Sun, 29 Dec 2019 14:25:23 +0000 (09:25 -0500)] 
match partial commands, too

6 years agostructs can have "length=uint16" too
Alan T. DeKok [Sun, 29 Dec 2019 13:47:49 +0000 (08:47 -0500)] 
structs can have "length=uint16" too

6 years agoslen can't be zero. Found by PVS Studio
Alan T. DeKok [Sun, 29 Dec 2019 13:45:25 +0000 (08:45 -0500)] 
slen can't be zero.  Found by PVS Studio

6 years agofix use of mod_rcode_table
Alan T. DeKok [Fri, 27 Dec 2019 13:53:48 +0000 (08:53 -0500)] 
fix use of mod_rcode_table

the definition for it shouldn't be in src/lib/server, but in
src/lib/unlang, where it's defined.

Since that definition has move, update the rest of the server
to use the src/lib/server "rcode_table", instead of the
unlang-specific "mod_rcode_table".

We should probably just get rid of the mod_rcode_table entirely,
unless we want unlang tests which don't include any server
functionality

6 years agouse one rcode_table, not two
Alan T. DeKok [Fri, 27 Dec 2019 13:45:55 +0000 (08:45 -0500)] 
use one rcode_table, not two

6 years agocatch run-time errors
Alan T. DeKok [Fri, 27 Dec 2019 13:44:01 +0000 (08:44 -0500)] 
catch run-time errors

6 years agolet's just add commas
Alan T. DeKok [Fri, 27 Dec 2019 13:43:19 +0000 (08:43 -0500)] 
let's just add commas

there's no error if the last field includes a comma, so we
should likely just add them everywhere

6 years agoorder these alphabetically, too
Alan T. DeKok [Fri, 27 Dec 2019 13:42:07 +0000 (08:42 -0500)] 
order these alphabetically, too

6 years agotable should be lexigraphically sorted
Alan T. DeKok [Fri, 27 Dec 2019 13:39:51 +0000 (08:39 -0500)] 
table should be lexigraphically sorted

6 years agostupid compilers don't complain if uint64_t is used as a ptr
Alan T. DeKok [Thu, 26 Dec 2019 19:47:47 +0000 (14:47 -0500)] 
stupid compilers don't complain if uint64_t is used as a ptr

6 years agouse correct (i.e. request) time for NAKs
Alan T. DeKok [Thu, 26 Dec 2019 19:46:52 +0000 (14:46 -0500)] 
use correct (i.e. request) time for NAKs

6 years agosimplify code and clean up error message
Alan T. DeKok [Thu, 26 Dec 2019 19:30:58 +0000 (14:30 -0500)] 
simplify code and clean up error message

6 years agoremove unused structure
Alan T. DeKok [Thu, 26 Dec 2019 19:25:14 +0000 (14:25 -0500)] 
remove unused structure

6 years agoset max_request_timer only when there's a request
Alan T. DeKok [Thu, 26 Dec 2019 19:24:36 +0000 (14:24 -0500)] 
set max_request_timer only when there's a request

6 years agowhen matching help, show help about children too
Alan T. DeKok [Thu, 26 Dec 2019 19:05:49 +0000 (14:05 -0500)] 
when matching help, show help about children too

6 years agofix this, too
Alan T. DeKok [Thu, 26 Dec 2019 18:41:43 +0000 (13:41 -0500)] 
fix this, too

6 years agoremove unused field and use correct data types for time delta
Alan T. DeKok [Thu, 26 Dec 2019 18:05:11 +0000 (13:05 -0500)] 
remove unused field and use correct data types for time delta

6 years agoremove "original_recv_time", and fix APIs using it
Alan T. DeKok [Thu, 26 Dec 2019 18:02:33 +0000 (13:02 -0500)] 
remove "original_recv_time", and fix APIs using it

we should rely on dedup trees, instead of reaching across
threads.

6 years agowe already have proto_vmps_udp.c
Alan T. DeKok [Thu, 26 Dec 2019 17:00:21 +0000 (12:00 -0500)] 
we already have proto_vmps_udp.c

This file doesn't belong

6 years agoremove field which is not needed
Alan T. DeKok [Thu, 26 Dec 2019 16:46:16 +0000 (11:46 -0500)] 
remove field which is not needed

6 years agoclarify the logic in run_request
Alan T. DeKok [Thu, 26 Dec 2019 16:42:49 +0000 (11:42 -0500)] 
clarify the logic in run_request

if the channel isn't active, we can cancel the request, but
there's no point in sending the reply.

6 years agoAdd tests for 'radmin> stats network'
Jorge Pereira [Tue, 24 Dec 2019 20:10:53 +0000 (17:10 -0300)] 
Add tests for 'radmin> stats network'

6 years agoAdd tests for 'radmin> stats'
Jorge Pereira [Tue, 24 Dec 2019 19:57:18 +0000 (16:57 -0300)] 
Add tests for 'radmin> stats'

6 years agoFix float point exception in radmin
Jorge Pereira [Tue, 24 Dec 2019 19:56:56 +0000 (16:56 -0300)] 
Fix float point exception in radmin

6 years agowhoops, set status, too
Alan T. DeKok [Tue, 24 Dec 2019 19:26:43 +0000 (14:26 -0500)] 
whoops, set status, too

6 years agosend ACK on empty packets
Alan T. DeKok [Tue, 24 Dec 2019 19:16:18 +0000 (14:16 -0500)] 
send ACK on empty packets

6 years agodon't run blank commands
Alan T. DeKok [Tue, 24 Dec 2019 19:14:37 +0000 (14:14 -0500)] 
don't run blank commands

6 years agoprint out better stats
Alan T. DeKok [Sun, 22 Dec 2019 17:41:41 +0000 (12:41 -0500)] 
print out better stats

6 years agoformat output consistently
Alan T. DeKok [Sun, 22 Dec 2019 17:35:36 +0000 (12:35 -0500)] 
format output consistently

6 years agospelling mistake
Alan T. DeKok [Sun, 22 Dec 2019 16:32:42 +0000 (11:32 -0500)] 
spelling mistake

6 years agoupdate run_time to not be always zero.
Alan T. DeKok [Sun, 22 Dec 2019 16:31:43 +0000 (11:31 -0500)] 
update run_time to not be always zero.

6 years agoupdate wait time correctly
Alan T. DeKok [Sun, 22 Dec 2019 16:30:25 +0000 (11:30 -0500)] 
update wait time correctly

6 years agocalculate run time from when we last resumed
Alan T. DeKok [Sun, 22 Dec 2019 16:27:55 +0000 (11:27 -0500)] 
calculate run time from when we last resumed

6 years agoclarifying comments
Alan T. DeKok [Sun, 22 Dec 2019 12:37:24 +0000 (07:37 -0500)] 
clarifying comments

6 years agounused variable
Alan T. DeKok [Sat, 21 Dec 2019 14:29:41 +0000 (09:29 -0500)] 
unused variable

6 years agoadd pre_event for single-threaded mode
Alan T. DeKok [Sat, 21 Dec 2019 13:43:09 +0000 (08:43 -0500)] 
add pre_event for single-threaded mode

so that the worker can restart yielded / resumed requests

6 years agoFix memory leak in radmin
Jorge Pereira [Fri, 20 Dec 2019 20:37:02 +0000 (17:37 -0300)] 
Fix memory leak in radmin

my_readline() needs radmin_free() to avoid leaks.

6 years agoAdd radmin tests for 'show profile'
Jorge Pereira [Fri, 20 Dec 2019 17:08:54 +0000 (14:08 -0300)] 
Add radmin tests for 'show profile'

6 years agovariable is unused
Alan T. DeKok [Fri, 20 Dec 2019 17:22:46 +0000 (12:22 -0500)] 
variable is unused

6 years agoadd post-event only for single-threaded mode
Alan T. DeKok [Fri, 20 Dec 2019 16:51:14 +0000 (11:51 -0500)] 
add post-event only for single-threaded mode

6 years agodon't spam the output with 1000's of similar debug messages
Alan T. DeKok [Fri, 20 Dec 2019 16:45:16 +0000 (11:45 -0500)] 
don't spam the output with 1000's of similar debug messages

6 years agowhitespace
Alan T. DeKok [Fri, 20 Dec 2019 16:07:26 +0000 (11:07 -0500)] 
whitespace

6 years agomove "run request" to the main worker loop
Alan T. DeKok [Fri, 20 Dec 2019 16:04:25 +0000 (11:04 -0500)] 
move "run request" to the main worker loop

and out of the post_event handler.

6 years agoget rid of "to_decode" heap.
Alan T. DeKok [Fri, 20 Dec 2019 15:58:43 +0000 (10:58 -0500)] 
get rid of "to_decode" heap.

Just immediately decode packets, and put them into the runnable queue.

6 years agoremove 'localized' heap.
Alan T. DeKok [Fri, 20 Dec 2019 15:53:10 +0000 (10:53 -0500)] 
remove 'localized' heap.

If the worker is busy, it's not servicing ANY packets. So we don't
need this heap.

6 years agoBetter fixes. Helps with #3219
Alan T. DeKok [Fri, 20 Dec 2019 13:32:12 +0000 (08:32 -0500)] 
Better fixes.  Helps with #3219

6 years agoadd "show profile", and don't allow "profile on" multiple times
Alan T. DeKok [Fri, 20 Dec 2019 13:26:51 +0000 (08:26 -0500)] 
add "show profile", and don't allow "profile on" multiple times

6 years agoavoid cursors where they're not necessary
Alan T. DeKok [Thu, 19 Dec 2019 21:36:20 +0000 (16:36 -0500)] 
avoid cursors where they're not necessary

6 years agoDon't hardcode the src ip address
Arran Cudbard-Bell [Fri, 20 Dec 2019 02:08:31 +0000 (18:08 -0800)] 
Don't hardcode the src ip address

The DHCPv4 code has multiple ways of discovering the correct src IP.  Hardcoding the src IP to 127.0.0.1 means sending responses will fail will obscure errors, which is frustrating.

The server works out-of-the-box biding to '*'.

6 years agoQuiet compiler
Arran Cudbard-Bell [Fri, 20 Dec 2019 00:45:14 +0000 (16:45 -0800)] 
Quiet compiler

6 years agoThis is only an indication *IF* we're waiting
Arran Cudbard-Bell [Thu, 19 Dec 2019 23:24:34 +0000 (15:24 -0800)] 
This is only an indication *IF* we're waiting