]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoPort unit changes from v3.0.x
Arran Cudbard-Bell [Sat, 7 Sep 2019 18:20:08 +0000 (13:20 -0500)] 
Port unit changes from v3.0.x

6 years agoMore unwind tests
Arran Cudbard-Bell [Sat, 7 Sep 2019 17:11:03 +0000 (12:11 -0500)] 
More unwind tests

6 years agoFix multiple issues in return/unwind
Arran Cudbard-Bell [Sat, 7 Sep 2019 16:46:22 +0000 (11:46 -0500)] 
Fix multiple issues in return/unwind

6 years agoConvert the macros to inline functions
Arran Cudbard-Bell [Sat, 7 Sep 2019 14:46:06 +0000 (09:46 -0500)] 
Convert the macros to inline functions

Better type warnings, and slightly cleaner use of "unwind_to_*"

6 years agojenkins: The 'QA_RPATHS' is already in 'make rpm' target
Jorge Pereira [Fri, 6 Sep 2019 17:55:49 +0000 (14:55 -0300)] 
jenkins: The 'QA_RPATHS' is already in 'make rpm' target

6 years agoFix missing free() in 'decode-tacacs' decode
Jorge Pereira [Fri, 6 Sep 2019 20:12:26 +0000 (17:12 -0300)] 
Fix missing free() in 'decode-tacacs' decode

6 years agoConsistent case
Arran Cudbard-Bell [Sat, 7 Sep 2019 05:28:20 +0000 (00:28 -0500)] 
Consistent case

6 years agoI guess we just can't use an enum for flag fields anymore...
Arran Cudbard-Bell [Sat, 7 Sep 2019 05:19:55 +0000 (00:19 -0500)] 
I guess we just can't use an enum for flag fields anymore...

6 years agoQuiet the compiler?
Arran Cudbard-Bell [Sat, 7 Sep 2019 04:53:32 +0000 (23:53 -0500)] 
Quiet the compiler?

6 years agoDifferent way of managing where to unwind to
Arran Cudbard-Bell [Sat, 7 Sep 2019 02:28:57 +0000 (21:28 -0500)] 
Different way of managing where to unwind to

6 years agoParent the VPs from the frame state for easy cleanup
Arran Cudbard-Bell [Sat, 7 Sep 2019 00:00:48 +0000 (19:00 -0500)] 
Parent the VPs from the frame state for easy cleanup

this possibly wasn't there before, because there used to be a union in the frame to hold instruction specific data

6 years agoSwitch to using a flags field, and set flags in the correct places, i.e. within the...
Arran Cudbard-Bell [Fri, 6 Sep 2019 23:18:06 +0000 (18:18 -0500)] 
Switch to using a flags field, and set flags in the correct places, i.e. within the foreach and policy keyword functions

6 years agoFix stupid hacks in foreach code
Arran Cudbard-Bell [Fri, 6 Sep 2019 17:54:50 +0000 (12:54 -0500)] 
Fix stupid hacks in foreach code

6 years agoadd test for `foo = #`, which shouldn't be allowed
Alan T. DeKok [Fri, 6 Sep 2019 17:37:17 +0000 (13:37 -0400)] 
add test for `foo = #`, which shouldn't be allowed

6 years agomove "map" processing to its own function
Alan T. DeKok [Fri, 6 Sep 2019 17:36:43 +0000 (13:36 -0400)] 
move "map" processing to its own function

6 years agomove "if / elsif" handling to its own function
Alan T. DeKok [Fri, 6 Sep 2019 17:17:55 +0000 (13:17 -0400)] 
move "if / elsif" handling to its own function

6 years agotry to have most goto's going forward
Alan T. DeKok [Fri, 6 Sep 2019 17:06:14 +0000 (13:06 -0400)] 
try to have most goto's going forward

6 years agomove $TEMPLATE handling to a separate function
Alan T. DeKok [Fri, 6 Sep 2019 17:04:50 +0000 (13:04 -0400)] 
move $TEMPLATE handling to a separate function

6 years agomove $INCLUDE handling into its own function
Alan T. DeKok [Fri, 6 Sep 2019 16:57:57 +0000 (12:57 -0400)] 
move $INCLUDE handling into its own function

6 years agoremove unused assignment
Alan T. DeKok [Fri, 6 Sep 2019 15:49:08 +0000 (11:49 -0400)] 
remove unused assignment

6 years agoclean up and clarify parser
Alan T. DeKok [Fri, 6 Sep 2019 15:21:13 +0000 (11:21 -0400)] 
clean up and clarify parser

foo = # stuff

is now a parse error.  Previously it did who knows what. :(

and two "switch" statements have been changed to one, with
a subsequent "expand variables" stage.

6 years agouse "op_token" for clarity
Alan T. DeKok [Fri, 6 Sep 2019 14:52:13 +0000 (10:52 -0400)] 
use "op_token" for clarity

this doesn't change the code, but it makes it easier to read

6 years agorename t1, t2, t3 to something more reasonable
Alan T. DeKok [Fri, 6 Sep 2019 14:48:46 +0000 (10:48 -0400)] 
rename t1, t2, t3 to something more reasonable

because 20 years of t1 t2 and t3 are hurting my brain

6 years agoMove unwind to be part of the stack, not part of a frame
Arran Cudbard-Bell [Fri, 6 Sep 2019 12:44:40 +0000 (07:44 -0500)] 
Move unwind to be part of the stack, not part of a frame

6 years agouse condition as talloc_ctx
Alan T. DeKok [Thu, 5 Sep 2019 23:13:50 +0000 (19:13 -0400)] 
use condition as talloc_ctx

to avoid leaking memory.  It's leaked only in the tests,
but whatever.

6 years agoempty strings are OK
Alan T. DeKok [Thu, 5 Sep 2019 22:24:29 +0000 (18:24 -0400)] 
empty strings are OK

with tests

6 years agoallow $ENV{...} too
Alan T. DeKok [Thu, 5 Sep 2019 20:07:25 +0000 (16:07 -0400)] 
allow $ENV{...} too

6 years agofilter out sha2 at the make stage
Alan T. DeKok [Thu, 5 Sep 2019 20:01:31 +0000 (16:01 -0400)] 
filter out sha2 at the make stage

because even if we have `if (0) { ... }` in the unlang policies,
the inner policies are still getting evaluated.

This fix is the right one, but we still need to add tests for
*not* compiling the contents of `if (0)`

6 years agonope. that didn't work
Alan T. DeKok [Thu, 5 Sep 2019 19:27:59 +0000 (15:27 -0400)] 
nope.  that didn't work

6 years agotypo
Alan T. DeKok [Thu, 5 Sep 2019 19:05:50 +0000 (15:05 -0400)] 
typo

6 years agoshow OpenSSL libs for travis
Alan T. DeKok [Thu, 5 Sep 2019 18:45:20 +0000 (14:45 -0400)] 
show OpenSSL libs for travis

6 years agopassword_process_sha3() Fix the talloc_list_free() call (#2956)
Jorge Pereira [Thu, 5 Sep 2019 17:52:28 +0000 (14:52 -0300)] 
password_process_sha3() Fix the talloc_list_free() call (#2956)

It expects reference instead of value.

6 years agoExtra check for returning inside subrequests
Arran Cudbard-Bell [Thu, 5 Sep 2019 15:53:26 +0000 (10:53 -0500)] 
Extra check for returning inside subrequests

6 years agonope... try more debugging
Matthew Newton [Thu, 5 Sep 2019 15:40:00 +0000 (16:40 +0100)] 
nope... try more debugging

6 years agoDebian packaging: Add builddep on asciidoctor and pandoc for man pages
Terry Burton [Thu, 5 Sep 2019 00:46:14 +0000 (01:46 +0100)] 
Debian packaging: Add builddep on asciidoctor and pandoc for man pages

Minimal fix only for the moment...

Add builddep on asciidoc and pandoc so that we can build the man pages
that were previously source files.

6 years agotravis is broken
Matthew Newton [Thu, 5 Sep 2019 14:31:52 +0000 (15:31 +0100)] 
travis is broken

It's been chopping off debug output for months. See if this hack
from https://github.com/travis-ci/travis-ci/issues/8920 helps

6 years agoRevert "Add openssl-perl as a BuildRequires in the Redhat spec file"
Alan T. DeKok [Thu, 5 Sep 2019 14:23:25 +0000 (10:23 -0400)] 
Revert "Add openssl-perl as a BuildRequires in the Redhat spec file"

This reverts commit d7cdb717fc336f68ed8faea7278468c4881c4eae.

revert this for now as docker isn't picking up the package.
Which then lets us see / fix other potential build failures

6 years agofix patch for new docs
Alan T. DeKok [Thu, 5 Sep 2019 14:22:52 +0000 (10:22 -0400)] 
fix patch for new docs

6 years agowe cannot use "break" alone inside of a policy
Alan T. DeKok [Thu, 5 Sep 2019 14:02:34 +0000 (10:02 -0400)] 
we cannot use "break" alone inside of a policy

if a policy is largely like a function, then we cannot put a
"foreach" outside of the policy, and then inside of the policy
use "break" to get out of the "foreach" loop

6 years agonote new behavior of "return"
Alan T. DeKok [Thu, 5 Sep 2019 13:55:41 +0000 (09:55 -0400)] 
note new behavior of "return"

6 years agoset and use return point for policies.
Alan T. DeKok [Thu, 5 Sep 2019 13:47:26 +0000 (09:47 -0400)] 
set and use return point for policies.

Pushing a policy onto the stack sets the return_point.

When popping the stack, check for break/return in the child,
and a break/return point in the parent.  If so, stop unwinding
the stack

6 years agodon't set unwind on BREAK
Alan T. DeKok [Thu, 5 Sep 2019 13:45:10 +0000 (09:45 -0400)] 
don't set unwind on BREAK

the previous break / return already set it to break / return.

6 years agocompile policies as UNLANG_TYPE_POLICY
Alan T. DeKok [Thu, 5 Sep 2019 13:44:18 +0000 (09:44 -0400)] 
compile policies as UNLANG_TYPE_POLICY

which is treated the same as GROUP for most purposes.  Except for
"return"

6 years agoprint policies as groups, because they have no g->vpt
Alan T. DeKok [Thu, 5 Sep 2019 13:43:59 +0000 (09:43 -0400)] 
print policies as groups, because they have no g->vpt

6 years agoclarify comments
Alan T. DeKok [Thu, 5 Sep 2019 13:43:35 +0000 (09:43 -0400)] 
clarify comments

6 years agodebug braces for policies.
Alan T. DeKok [Thu, 5 Sep 2019 13:43:08 +0000 (09:43 -0400)] 
debug braces for policies.

Not sure why we have "policy" as a keyword, but whatever

6 years agoadd break_point and return_point to interpreter
Alan T. DeKok [Thu, 5 Sep 2019 12:56:41 +0000 (08:56 -0400)] 
add break_point and return_point to interpreter

top frames are now both, just for sanity.

break points are "foreach" instructions.  Which SHOULD be
verified by the compiler, but it doesn't hurt to have a sanity
check.

return points are (for now) only top frames.  But marking them
up this way means that we may be able to have return points which
are in policies

6 years agoremove debug message
Alan T. DeKok [Thu, 5 Sep 2019 12:35:58 +0000 (08:35 -0400)] 
remove debug message

6 years agoremove debug messages
Alan T. DeKok [Wed, 4 Sep 2019 20:36:40 +0000 (16:36 -0400)] 
remove debug messages

6 years agoTables no longer null terminated
Arran Cudbard-Bell [Wed, 4 Sep 2019 19:51:46 +0000 (15:51 -0400)] 
Tables no longer null terminated

6 years agoAdd openssl-perl as a BuildRequires in the Redhat spec file
Terry Burton [Wed, 4 Sep 2019 17:31:28 +0000 (18:31 +0100)] 
Add openssl-perl as a BuildRequires in the Redhat spec file

Docker crossbuilds are broken because c_rehash is missing. The Docker build
images obtain their package list from the spec file.

6 years agodynamically expand strings as necessary.
Alan T. DeKok [Wed, 4 Sep 2019 19:52:57 +0000 (15:52 -0400)] 
dynamically expand strings as necessary.

This would be a lot easier if cf_expand_variables() took a length
We can add that to the "todo" list

6 years agoif we run out of braces, anything other that ' ' or '{' is bad
Alan T. DeKok [Wed, 4 Sep 2019 19:52:38 +0000 (15:52 -0400)] 
if we run out of braces, anything other that ' ' or '{' is bad

6 years agoparse the text AFTER the input, not after the rhs string
Alan T. DeKok [Wed, 4 Sep 2019 19:52:18 +0000 (15:52 -0400)] 
parse the text AFTER the input, not after the rhs string

6 years agowipe out text as we go back up the stack
Alan T. DeKok [Wed, 4 Sep 2019 19:20:20 +0000 (15:20 -0400)] 
wipe out text as we go back up the stack

6 years agoallow ${...} variable definitions in tmpl_preparse()
Alan T. DeKok [Wed, 4 Sep 2019 19:15:40 +0000 (15:15 -0400)] 
allow ${...} variable definitions in tmpl_preparse()

which is the simplest way of dealing with this issue.

6 years agoadd parameters in preparation for local variable expansion
Alan T. DeKok [Wed, 4 Sep 2019 19:01:36 +0000 (15:01 -0400)] 
add parameters in preparation for local variable expansion

6 years agodon't do two parsing of conditions
Alan T. DeKok [Wed, 4 Sep 2019 18:46:35 +0000 (14:46 -0400)] 
don't do two parsing of conditions

and remove call to cf_expand_variables() from cf_file.c

That expansion should be called from the conditional parser,
which actually understands what it's doing, and when things are done.

6 years agoremove unused flags parameter
Alan T. DeKok [Wed, 4 Sep 2019 18:30:26 +0000 (14:30 -0400)] 
remove unused flags parameter

6 years agoFix request logging
Arran Cudbard-Bell [Wed, 4 Sep 2019 18:21:47 +0000 (14:21 -0400)] 
Fix request logging

6 years agoDon't have radclient.1 anymore
Arran Cudbard-Bell [Wed, 4 Sep 2019 17:38:58 +0000 (13:38 -0400)] 
Don't have radclient.1 anymore

6 years agoREADME.md no longer exists...
Arran Cudbard-Bell [Wed, 4 Sep 2019 17:32:29 +0000 (13:32 -0400)] 
README.md no longer exists...

6 years agoOne log level global to rule them all...
Arran Cudbard-Bell [Wed, 4 Sep 2019 17:06:41 +0000 (13:06 -0400)] 
One log level global to rule them all...

6 years agoradmin: Fix 'debug level'
Jorge Pereira [Wed, 4 Sep 2019 01:16:59 +0000 (22:16 -0300)] 
radmin: Fix 'debug level'

Missing '\n' output format.

6 years agocheck len, and remove help message. Fixes #2952
Alan T. DeKok [Wed, 4 Sep 2019 02:08:02 +0000 (22:08 -0400)] 
check len, and remove help message.  Fixes #2952

6 years agoradmin: The cmd_copy() returns sszie_t
Jorge Pereira [Tue, 3 Sep 2019 22:10:47 +0000 (19:10 -0300)] 
radmin: The cmd_copy() returns sszie_t

6 years agoallow trailing space for tab completion
Alan T. DeKok [Tue, 3 Sep 2019 21:57:52 +0000 (17:57 -0400)] 
allow trailing space for tab completion

6 years agomash trailing spaces
Alan T. DeKok [Tue, 3 Sep 2019 21:49:18 +0000 (17:49 -0400)] 
mash trailing spaces

6 years agoPut back the subrequest code that allows subrequests to be created programatically
Arran Cudbard-Bell [Tue, 3 Sep 2019 21:16:28 +0000 (17:16 -0400)] 
Put back the subrequest code that allows subrequests to be created programatically

This reverts commit 357946056cd772591084fa1d0e1927abae12918f.

6 years agoremove "WITH_PROXY" in EAP code
Arran Cudbard-Bell [Tue, 3 Sep 2019 20:26:56 +0000 (16:26 -0400)] 
remove "WITH_PROXY" in EAP code

6 years agoRemove reference to request->username
Arran Cudbard-Bell [Tue, 3 Sep 2019 20:31:01 +0000 (16:31 -0400)] 
Remove reference to request->username

6 years agoThis debug info will be printed elsewhere...
Arran Cudbard-Bell [Tue, 3 Sep 2019 20:24:55 +0000 (16:24 -0400)] 
This debug info will be printed elsewhere...

6 years agoDon't return NULL from radmin_help
Arran Cudbard-Bell [Tue, 3 Sep 2019 20:05:55 +0000 (16:05 -0400)] 
Don't return NULL from radmin_help

rl_bind_key says any non-zero return value indicates error

6 years agoFix redundant declarations
Arran Cudbard-Bell [Tue, 3 Sep 2019 20:03:22 +0000 (16:03 -0400)] 
Fix redundant declarations

6 years agoToo soon...
Arran Cudbard-Bell [Tue, 3 Sep 2019 19:50:47 +0000 (15:50 -0400)] 
Too soon...

6 years agoadd partial commands to radmin
Alan T. DeKok [Tue, 3 Sep 2019 19:42:44 +0000 (15:42 -0400)] 
add partial commands to radmin

with tab completion and help

6 years agodon't save exit / quit / secret / etc. in history file
Alan T. DeKok [Tue, 3 Sep 2019 17:57:16 +0000 (13:57 -0400)] 
don't save exit / quit / secret / etc. in history file

6 years agoFix assert in dlist.h
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:53:25 +0000 (14:53 -0400)] 
Fix assert in dlist.h

6 years agoAllow namespaces to be registered for virtual servers
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:25:42 +0000 (14:25 -0400)] 
Allow namespaces to be registered for virtual servers

6 years agos/TLS-Session-Data/Session-Data/ s/TLS-Session-ID/Session-ID/
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:24:09 +0000 (14:24 -0400)] 
s/TLS-Session-Data/Session-Data/ s/TLS-Session-ID/Session-ID/

6 years agoNewlineify module build list
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:01:32 +0000 (14:01 -0400)] 
Newlineify module build list

6 years agoSplit request_data functions out and teach them about parent/child relationships
Arran Cudbard-Bell [Tue, 3 Sep 2019 17:55:28 +0000 (13:55 -0400)] 
Split request_data functions out and teach them about parent/child relationships

6 years agoMore TLS handshake information
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:02:14 +0000 (14:02 -0400)] 
More TLS handshake information

6 years agoUse full paths for headers. This fixes some issues with stale symlinks in package...
Arran Cudbard-Bell [Tue, 3 Sep 2019 17:52:40 +0000 (13:52 -0400)] 
Use full paths for headers.  This fixes some issues with stale symlinks in package build directories, and generally makes things more robust.

6 years agoAdd implementation of memrchr
Arran Cudbard-Bell [Tue, 3 Sep 2019 17:43:50 +0000 (13:43 -0400)] 
Add implementation of memrchr

6 years agoReduce truncation trigger length when printing config files
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:01:51 +0000 (14:01 -0400)] 
Reduce truncation trigger length when printing config files

6 years agoDon't prefix attributes with '&'. Tends to lead to '&&'
Arran Cudbard-Bell [Tue, 3 Sep 2019 18:03:54 +0000 (14:03 -0400)] 
Don't prefix attributes with '&'.  Tends to lead to '&&'

6 years agoradsqlrelay: Remove references to rlm_sql_log
Jorge Pereira [Tue, 3 Sep 2019 11:26:20 +0000 (07:26 -0400)] 
radsqlrelay: Remove references to rlm_sql_log

6 years agoradmin: Add support to keep the history in ~/.radmin_history
Jorge Pereira [Fri, 30 Aug 2019 21:14:41 +0000 (18:14 -0300)] 
radmin: Add support to keep the history in ~/.radmin_history

6 years agoradmin: Fix missing \n
Jorge Pereira [Mon, 2 Sep 2019 17:21:12 +0000 (14:21 -0300)] 
radmin: Fix missing \n

6 years agoRevert "...and some more"
Arran Cudbard-Bell [Mon, 2 Sep 2019 16:07:15 +0000 (12:07 -0400)] 
Revert "...and some more"

This reverts commit 087cb06426b2b5a6e696d80f6cd5f3713b5aa375.

6 years agoREADME: fix link to Network RADIUS
Koichiro IWAO [Mon, 2 Sep 2019 10:24:05 +0000 (19:24 +0900)] 
README: fix link to Network RADIUS

SSL certificate is not issued to www.networkradius.com but
networkradius.org. Link to www.networkradius.com will cause SSL
certificate verification failure.

6 years ago...and some more
Arran Cudbard-Bell [Mon, 2 Sep 2019 04:35:59 +0000 (00:35 -0400)] 
...and some more

6 years agoStart removing stupid inst->name boilerplate from all the modules
Arran Cudbard-Bell [Mon, 2 Sep 2019 03:59:55 +0000 (23:59 -0400)] 
Start removing stupid inst->name boilerplate from all the modules

6 years agoPrint what password we're going to be using and what type of password it is
Arran Cudbard-Bell [Mon, 2 Sep 2019 02:57:32 +0000 (22:57 -0400)] 
Print what password we're going to be using and what type of password it is

6 years agoBuild utility code for eap_pwd.c
Arran Cudbard-Bell [Sat, 31 Aug 2019 02:35:47 +0000 (22:35 -0400)] 
Build utility code for eap_pwd.c

6 years agoCall password_find function in rlm_eap_md5 and rlm_eap_pwd
Arran Cudbard-Bell [Fri, 30 Aug 2019 21:28:33 +0000 (17:28 -0400)] 
Call password_find function in rlm_eap_md5 and rlm_eap_pwd

6 years agoChap doesn't need normalise, as we don't try to normalise cleartext passwords
Arran Cudbard-Bell [Fri, 30 Aug 2019 21:27:59 +0000 (17:27 -0400)] 
Chap doesn't need normalise, as we don't try to normalise cleartext passwords

6 years agoAdd all.mk for EAP-PWD
Arran Cudbard-Bell [Fri, 30 Aug 2019 21:26:39 +0000 (17:26 -0400)] 
Add all.mk for EAP-PWD

6 years agoradmin: The 'stats memory <option>' needs the server started with '-M'
Jorge Pereira [Fri, 30 Aug 2019 20:15:28 +0000 (17:15 -0300)] 
radmin: The 'stats memory <option>' needs the server started with '-M'

therefore, let the use aware of it instead of see '0' values.