]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
7 years agoCorrect format specifier
Arran Cudbard-Bell [Fri, 4 Jan 2019 14:46:52 +0000 (22:46 +0800)] 
Correct format specifier

7 years agoCatch bad secret values
Arran Cudbard-Bell [Fri, 4 Jan 2019 14:01:31 +0000 (22:01 +0800)] 
Catch bad secret values

fff

7 years agoDisable foreign attribute check
Arran Cudbard-Bell [Fri, 4 Jan 2019 09:00:56 +0000 (17:00 +0800)] 
Disable foreign attribute check

7 years agoCheck rad_debug_lvl correctly, so the messages are enabled/disabled based on request...
Arran Cudbard-Bell [Fri, 4 Jan 2019 07:30:09 +0000 (15:30 +0800)] 
Check rad_debug_lvl correctly, so the messages are enabled/disabled based on request specific debug levels

Reduce manual calls to hex printing functions

7 years agoCode should always execute. WARNings are always emitted, and code applies fixup...
Arran Cudbard-Bell [Fri, 4 Jan 2019 07:07:19 +0000 (15:07 +0800)] 
Code should always execute.  WARNings are always emitted, and code applies fixup to VPs that shouldn't just be applied if debugging is enabled.

7 years agoclarify message
Alan T. DeKok [Mon, 31 Dec 2018 15:57:06 +0000 (10:57 -0500)] 
clarify message

7 years agoremove unused assignment
Alan T. DeKok [Mon, 31 Dec 2018 16:14:21 +0000 (11:14 -0500)] 
remove unused assignment

7 years agoword smithing
Alan T. DeKok [Thu, 20 Dec 2018 16:30:30 +0000 (11:30 -0500)] 
word smithing

7 years agoUse newer ephemeral struct init syntax
Arran Cudbard-Bell [Wed, 26 Dec 2018 02:07:19 +0000 (10:07 +0800)] 
Use newer ephemeral struct init syntax

7 years agoTypo
Arran Cudbard-Bell [Wed, 26 Dec 2018 01:53:15 +0000 (09:53 +0800)] 
Typo

7 years agoCleanup minor issues with attribute search functions
Arran Cudbard-Bell [Wed, 26 Dec 2018 01:39:25 +0000 (09:39 +0800)] 
Cleanup minor issues with attribute search functions

7 years agoProbably not a useful test anymore
Arran Cudbard-Bell [Thu, 20 Dec 2018 00:53:32 +0000 (08:53 +0800)] 
Probably not a useful test anymore

7 years agoMake it easier to see the ref count in a debugger
Arran Cudbard-Bell [Thu, 20 Dec 2018 00:46:06 +0000 (08:46 +0800)] 
Make it easier to see the ref count in a debugger

7 years agoConvert pairs xlat to new async API 2379/head
Philippe Wooding [Fri, 7 Dec 2018 14:32:50 +0000 (15:32 +0100)] 
Convert pairs xlat to new async API

7 years agoUpdate concat xlat to use separator
Philippe Wooding [Fri, 7 Dec 2018 14:09:34 +0000 (15:09 +0100)] 
Update concat xlat to use separator

7 years agoBug fix in fr_value_box_bstrsnteal.
Philippe Wooding [Fri, 7 Dec 2018 14:01:56 +0000 (15:01 +0100)] 
Bug fix in fr_value_box_bstrsnteal.
'len' is not updated when talloc_realloc_size is called.

7 years agoFix memory leak in xlat_base64
Philippe Wooding [Fri, 7 Dec 2018 13:52:25 +0000 (14:52 +0100)] 
Fix memory leak in xlat_base64

7 years agoReplace base64tohex with base64decode using new async API
Philippe Wooding [Fri, 7 Dec 2018 13:50:40 +0000 (14:50 +0100)] 
Replace base64tohex with base64decode using new async API

7 years agodoxygen
Alan T. DeKok [Thu, 20 Dec 2018 12:44:41 +0000 (07:44 -0500)] 
doxygen

7 years agodon't increase refcount on first autoload
Alan T. DeKok [Thu, 20 Dec 2018 12:04:43 +0000 (07:04 -0500)] 
don't increase refcount on first autoload

because the manual load of the dictionaries doesn't result in
a manual unload.  so the autoload has to auto-unload it for us

7 years agoFix NAS port struct
Arran Cudbard-Bell [Thu, 20 Dec 2018 00:07:43 +0000 (08:07 +0800)] 
Fix NAS port struct

7 years agoFree resources on failure in unit_test_map
Arran Cudbard-Bell [Wed, 19 Dec 2018 23:47:03 +0000 (15:47 -0800)] 
Free resources on failure in unit_test_map

7 years agoAnonymise structs
Arran Cudbard-Bell [Wed, 19 Dec 2018 23:26:35 +0000 (15:26 -0800)] 
Anonymise structs

7 years agomake sim/base.h
Alan T. DeKok [Wed, 19 Dec 2018 22:25:35 +0000 (17:25 -0500)] 
make sim/base.h

7 years agoclang scan fixes (hopefully)
Alan T. DeKok [Wed, 19 Dec 2018 22:10:08 +0000 (17:10 -0500)] 
clang scan fixes (hopefully)

7 years agoif `dict` can't be NULL, no need to check for NULL
Alan T. DeKok [Wed, 19 Dec 2018 21:57:14 +0000 (16:57 -0500)] 
if `dict` can't be NULL, no need to check for NULL

7 years agodoxygen
Alan T. DeKok [Wed, 19 Dec 2018 21:54:15 +0000 (16:54 -0500)] 
doxygen

7 years agoMarkup nonnull arguments of fr_dict_attr_add
Arran Cudbard-Bell [Wed, 19 Dec 2018 19:07:30 +0000 (11:07 -0800)] 
Markup nonnull arguments of fr_dict_attr_add

7 years agofix auto-creation of Vendor-Specific
Alan T. DeKok [Wed, 19 Dec 2018 18:06:46 +0000 (13:06 -0500)] 
fix auto-creation of Vendor-Specific

it was created and added by number, but not by name.  That's wrong.

And arguably we should only do this for the RADIUS dictionary...

7 years agosuppress duplicate attribute definitions
Alan T. DeKok [Wed, 19 Dec 2018 18:05:44 +0000 (13:05 -0500)] 
suppress duplicate attribute definitions

We don't want to replace them, as they may have values, children,
etc.  Once an attribute is replaced, the old children, etc. cannot
be found.

7 years agoupdate comment and add "type" to list of things we check
Alan T. DeKok [Wed, 19 Dec 2018 18:05:06 +0000 (13:05 -0500)] 
update comment and add "type" to list of things we check

7 years agothis should not have been committed
Alan T. DeKok [Wed, 19 Dec 2018 18:04:02 +0000 (13:04 -0500)] 
this should not have been committed

7 years agothis dictionary is for RADIUS
Alan T. DeKok [Wed, 19 Dec 2018 18:03:27 +0000 (13:03 -0500)] 
this dictionary is for RADIUS

7 years agoremoved duplicate / conflicting attribute definition
Alan T. DeKok [Wed, 19 Dec 2018 18:02:39 +0000 (13:02 -0500)] 
removed duplicate / conflicting attribute definition

7 years agomark up autoloaded dictionaries vs manual ones
Alan T. DeKok [Wed, 19 Dec 2018 13:26:13 +0000 (08:26 -0500)] 
mark up autoloaded dictionaries vs manual ones

So that dictionaries can be manually loaded from raddb/dictionary,
and we can later still autoload the various protocol dictionaries

The only downside is that src/tests/Makefile still fails.
The server loads the test dictionary and parses the config files
correctly.  radclient loads the test dictionary and sends the
attributes correctly.

But somehow (magically) when the server receives the packets, it
can't find the test vendor, and prints out all of the attributes
as raw ones...

7 years agocapture stdout && stderr to the log file, too
Alan T. DeKok [Wed, 19 Dec 2018 13:25:59 +0000 (08:25 -0500)] 
capture stdout && stderr to the log file, too

7 years agoprint out correct arguments
Alan T. DeKok [Wed, 19 Dec 2018 12:49:33 +0000 (07:49 -0500)] 
print out correct arguments

7 years agowe don't need to regenerate this any more
Alan T. DeKok [Wed, 19 Dec 2018 12:49:13 +0000 (07:49 -0500)] 
we don't need to regenerate this any more

7 years agowhen refactoring, copy code instead of re-typing it.
Alan T. DeKok [Wed, 19 Dec 2018 12:13:57 +0000 (07:13 -0500)] 
when refactoring, copy code instead of re-typing it.

and building it is good, too

7 years agoBSD fixes
Alan T. DeKok [Wed, 19 Dec 2018 12:11:22 +0000 (07:11 -0500)] 
BSD fixes

7 years agoMerge pull request #2378 from manu0401/master
Alan DeKok [Wed, 19 Dec 2018 12:08:53 +0000 (07:08 -0500)] 
Merge pull request #2378 from manu0401/master

Fix startup crash when running outside of gdb on BSD systems

7 years agoFix startup crash when running outside of gdb on BSD systems 2378/head
Emmanuel Dreyfus [Wed, 19 Dec 2018 10:11:16 +0000 (11:11 +0100)] 
Fix startup crash when running outside of gdb on BSD systems

On BSD systems, ptrace(PT_DETACH) uses a third argument for
resume address, with the magic value (void *)1 to resume where
process stopped. Specifying NULL there leads to a crash because
process resumes at address 0.

We introduce an OS-dependent _PTRACE_DETACH macro to specify
third argument as NULL on Linux and (void *)1 on other systems.
Always using (void *)1 could be another solution, since basic
tests suggests passing (void *)1 as third argument on Linux
does not cause harm.

7 years agoDoxygen headers in rlm_eap_ttls
Arran Cudbard-Bell [Wed, 19 Dec 2018 02:12:49 +0000 (21:12 -0500)] 
Doxygen headers in rlm_eap_ttls

7 years agoMove EAP and SIM libraries into src/lib
Arran Cudbard-Bell [Wed, 19 Dec 2018 02:04:55 +0000 (21:04 -0500)] 
Move EAP and SIM libraries into src/lib

7 years agouse top_srcdir for references to source files
Alan T. DeKok [Wed, 19 Dec 2018 01:05:44 +0000 (20:05 -0500)] 
use top_srcdir for references to source files

7 years agoprint "AUTH-TEST" to make it clear which test is what
Alan T. DeKok [Wed, 19 Dec 2018 00:49:15 +0000 (19:49 -0500)] 
print "AUTH-TEST" to make it clear which test is what

7 years agouse radius as root for decoding TTLS, not internal dictionary
Alan T. DeKok [Wed, 19 Dec 2018 00:00:03 +0000 (19:00 -0500)] 
use radius as root for decoding TTLS, not internal dictionary

7 years agoRemove freedhcp dictionary Closes #2376
Arran Cudbard-Bell [Tue, 18 Dec 2018 23:34:37 +0000 (18:34 -0500)] 
Remove freedhcp dictionary Closes #2376

7 years agoQuotes
Arran Cudbard-Bell [Tue, 18 Dec 2018 23:22:58 +0000 (18:22 -0500)] 
Quotes

7 years agoRearrange so we don't make validating pairs conditional on running in debug mode
Arran Cudbard-Bell [Tue, 18 Dec 2018 23:20:33 +0000 (18:20 -0500)] 
Rearrange so we don't make validating pairs conditional on running in debug mode

7 years agoMS-CHAP-Password is a FreeRADIUS thingy
Alan T. DeKok [Tue, 18 Dec 2018 23:15:09 +0000 (18:15 -0500)] 
MS-CHAP-Password is a FreeRADIUS thingy

7 years agoMS-CHAP stuff is in radius dictionary, not freeradius
Alan T. DeKok [Tue, 18 Dec 2018 21:20:06 +0000 (16:20 -0500)] 
MS-CHAP stuff is in radius dictionary, not freeradius

7 years ago'&' for the win
Alan T. DeKok [Tue, 18 Dec 2018 20:50:58 +0000 (15:50 -0500)] 
'&' for the win

7 years agodictionaries are now autoloaded
Alan T. DeKok [Tue, 18 Dec 2018 18:25:08 +0000 (13:25 -0500)] 
dictionaries are now autoloaded

don't manually include any of them

7 years agoprint name for duplicate
Alan T. DeKok [Tue, 18 Dec 2018 18:20:10 +0000 (13:20 -0500)] 
print name for duplicate

7 years agoadd AUTO here, too
Alan T. DeKok [Tue, 18 Dec 2018 17:29:23 +0000 (12:29 -0500)] 
add AUTO here, too

7 years agobetter fix for previous patch
Alan T. DeKok [Tue, 18 Dec 2018 16:42:24 +0000 (11:42 -0500)] 
better fix for previous patch

7 years agoRevert "add '&' if it's not already there"
Alan T. DeKok [Tue, 18 Dec 2018 16:41:39 +0000 (11:41 -0500)] 
Revert "add '&' if it's not already there"

This reverts commit 8966bfdf901c06c84762ae8aaa0d37084f9eb0b4.

7 years agoprint out VP names if they exist, too
Alan T. DeKok [Tue, 18 Dec 2018 16:23:52 +0000 (11:23 -0500)] 
print out VP names if they exist, too

7 years agorearrange so that we're only doing debug work if we're debugging
Alan T. DeKok [Tue, 18 Dec 2018 16:23:32 +0000 (11:23 -0500)] 
rearrange so that we're only doing debug work if we're debugging

7 years agohandle the case where the LHS isn't a properly formed attribute
Alan T. DeKok [Tue, 18 Dec 2018 16:12:44 +0000 (11:12 -0500)] 
handle the case where the LHS isn't a properly formed attribute

which isn't *strictly* needed due to the previous patch.
However... it should do the Right Thing even if the data in LDAP
doesn't start with '&'

7 years agoadd '&' if it's not already there
Alan T. DeKok [Tue, 18 Dec 2018 16:11:51 +0000 (11:11 -0500)] 
add '&' if it's not already there

as a hack so that the user doesn't have to put '&' in all of the
LDAP entries.  We KNOW they're supposed to be attributes, so we
might as well FORCE them to be attributes.

7 years agouse the correct parenting for the attributes
Alan T. DeKok [Tue, 18 Dec 2018 16:09:47 +0000 (11:09 -0500)] 
use the correct parenting for the attributes

7 years agofix looping code so that it doesn't skip dictionaries
Alan T. DeKok [Mon, 17 Dec 2018 19:53:48 +0000 (14:53 -0500)] 
fix looping code so that it doesn't skip dictionaries

7 years agoTypo
Arran Cudbard-Bell [Mon, 17 Dec 2018 19:54:53 +0000 (14:54 -0500)] 
Typo

7 years agoTypo
Arran Cudbard-Bell [Mon, 17 Dec 2018 18:28:31 +0000 (13:28 -0500)] 
Typo

7 years agoEAP-AKA-Subtype is in the EAP-AKA dictionary
Arran Cudbard-Bell [Sun, 16 Dec 2018 22:38:27 +0000 (17:38 -0500)] 
EAP-AKA-Subtype is in the EAP-AKA dictionary

7 years agoAutoload sigtran dictionaries and attributes
Arran Cudbard-Bell [Sun, 16 Dec 2018 01:39:45 +0000 (20:39 -0500)] 
Autoload sigtran dictionaries and attributes

7 years agoUpdate systemd units to depend on network-online
Alexander Scheel [Fri, 14 Dec 2018 16:49:12 +0000 (11:49 -0500)] 
Update systemd units to depend on network-online

Due to the use of SO_BINDTODEVICE, FreeRADIUS requires the address to be
up when binding to a specific IP address. In systemd, depending on
network.target is not sufficient to require the network to be up, so
FreeRADIUS can still fail to bind; instead, network-online.target is
required if the network is required to be online.

This manifests in errors such as:

Error: Failed binding to auth address x.x.x.x port 1812 bound to
       server default: Cannot assign requested address

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1637275
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
7 years agoMerge pull request #2375 from horsitis/patch-2
Arran Cudbard-Bell [Sat, 15 Dec 2018 16:00:23 +0000 (11:00 -0500)] 
Merge pull request #2375 from horsitis/patch-2

Add support for Downloadable user roles

7 years agoAdd support for Clearpass Downloadable roles 2375/head
horsitis [Sat, 15 Dec 2018 15:27:04 +0000 (17:27 +0200)] 
Add support for Clearpass Downloadable roles

7 years agoif it's a raw attribute, don't look it up in the global dict
Alan T. DeKok [Fri, 14 Dec 2018 20:09:44 +0000 (15:09 -0500)] 
if it's a raw attribute, don't look it up in the global dict

it's known, but badly formed.  So it's not really known.

7 years agoset unknown_da, too
Alan T. DeKok [Fri, 14 Dec 2018 20:09:32 +0000 (15:09 -0500)] 
set unknown_da, too

7 years agoAdd HP-User-Role. Fixes #2372
Alan T. DeKok [Fri, 14 Dec 2018 19:38:11 +0000 (14:38 -0500)] 
Add HP-User-Role.  Fixes #2372

7 years agoFix typo. Fixes #2374
Alan T. DeKok [Fri, 14 Dec 2018 19:36:34 +0000 (14:36 -0500)] 
Fix typo.  Fixes #2374

7 years agoallow Attr-oid.str here, too
Alan T. DeKok [Fri, 14 Dec 2018 19:35:30 +0000 (14:35 -0500)] 
allow Attr-oid.str here, too

7 years agoDoxygen
Arran Cudbard-Bell [Fri, 14 Dec 2018 17:47:07 +0000 (12:47 -0500)] 
Doxygen

7 years agoTypo
Arran Cudbard-Bell [Fri, 14 Dec 2018 17:45:55 +0000 (12:45 -0500)] 
Typo

7 years agotypo
Alan T. DeKok [Wed, 5 Dec 2018 14:20:24 +0000 (09:20 -0500)] 
typo

# Conflicts:
# src/modules/rlm_mschap/opendir.c

7 years agosimplify ntlm_auth error output checks
Alan T. DeKok [Fri, 23 Nov 2018 16:33:01 +0000 (11:33 -0500)] 
simplify ntlm_auth error output checks

In most cases, the error output will contain "0xC0000", in which case
we can take a fast path

# Conflicts:
# src/modules/rlm_mschap/rlm_mschap.c

7 years agoCheck for error conditions when loading test points
Arran Cudbard-Bell [Fri, 14 Dec 2018 17:01:15 +0000 (12:01 -0500)] 
Check for error conditions when loading test points

7 years agoUse constants for errors
Arran Cudbard-Bell [Fri, 14 Dec 2018 16:32:21 +0000 (11:32 -0500)] 
Use constants for errors

7 years agoUse more compact, inline variable initialisation syntax where appropriate
Arran Cudbard-Bell [Fri, 14 Dec 2018 16:31:53 +0000 (11:31 -0500)] 
Use more compact, inline variable initialisation syntax where appropriate

7 years agodon't over-write pragma once
Alan T. DeKok [Fri, 14 Dec 2018 14:52:03 +0000 (09:52 -0500)] 
don't over-write pragma once

7 years agotr fixes for Linux
Alan T. DeKok [Fri, 14 Dec 2018 14:44:42 +0000 (09:44 -0500)] 
tr fixes for Linux

'-' only means itself when it's at the end of a sequence

7 years agoRevert "include dictionary for FR_USER_NAME"
Alan T. DeKok [Fri, 14 Dec 2018 14:43:57 +0000 (09:43 -0500)] 
Revert "include dictionary for FR_USER_NAME"

This reverts commit 3df2a92b04b2d256bf77dbdd8bd99c063b57de4f.

7 years agoinclude dictionary for FR_USER_NAME
Alan T. DeKok [Fri, 14 Dec 2018 13:39:54 +0000 (08:39 -0500)] 
include dictionary for FR_USER_NAME

7 years agoautoload SNMP attributes, too
Alan T. DeKok [Fri, 14 Dec 2018 13:12:12 +0000 (08:12 -0500)] 
autoload SNMP attributes, too

7 years agodon't need to set this
Alan T. DeKok [Fri, 14 Dec 2018 12:50:21 +0000 (07:50 -0500)] 
don't need to set this

7 years agosearch over all of the protocols for attributes
Alan T. DeKok [Fri, 14 Dec 2018 12:36:08 +0000 (07:36 -0500)] 
search over all of the protocols for attributes

by using the new has iteration function.

This search is only done if `fallback = true`.  The search also
skips `dict_def`, as that has already been searched.

7 years agoset fallback=true
Alan T. DeKok [Fri, 14 Dec 2018 12:31:59 +0000 (07:31 -0500)] 
set fallback=true

so that we can look up key fields in the internal dictionaries, too

7 years agoHash iteration functions
Arran Cudbard-Bell [Fri, 14 Dec 2018 03:54:11 +0000 (22:54 -0500)] 
Hash iteration functions

7 years agoMake the data in the hash entry unconst
Arran Cudbard-Bell [Fri, 14 Dec 2018 03:49:26 +0000 (22:49 -0500)] 
Make the data in the hash entry unconst

7 years agoMinor cleanups
Arran Cudbard-Bell [Fri, 14 Dec 2018 01:25:32 +0000 (20:25 -0500)] 
Minor cleanups

7 years agoskip '.' after protocol name
Alan T. DeKok [Thu, 13 Dec 2018 21:20:56 +0000 (16:20 -0500)] 
skip '.' after protocol name

7 years agodictionary is radius
Alan T. DeKok [Thu, 13 Dec 2018 20:41:01 +0000 (15:41 -0500)] 
dictionary is radius

7 years agomore cleanups... hope this works
Alan T. DeKok [Thu, 13 Dec 2018 20:40:28 +0000 (15:40 -0500)] 
more cleanups... hope this works

7 years agoadd dict to pairlist_read()
Alan T. DeKok [Thu, 13 Dec 2018 20:39:52 +0000 (15:39 -0500)] 
add dict to pairlist_read()

7 years agoadd &
Alan T. DeKok [Thu, 13 Dec 2018 20:06:19 +0000 (15:06 -0500)] 
add &

7 years agotypo
Alan T. DeKok [Thu, 13 Dec 2018 20:05:13 +0000 (15:05 -0500)] 
typo