]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
7 years agoFixup integer tests
Arran Cudbard-Bell [Thu, 8 Nov 2018 22:02:40 +0000 (17:02 -0500)] 
Fixup integer tests

7 years agoCall string in update sections in the strings test
Arran Cudbard-Bell [Thu, 8 Nov 2018 21:59:17 +0000 (16:59 -0500)] 
Call string in update sections in the strings test

7 years agoPrint integer strings as integers and not whatever the heck it was doing
Arran Cudbard-Bell [Thu, 8 Nov 2018 21:58:58 +0000 (16:58 -0500)] 
Print integer strings as integers and not whatever the heck it was doing

7 years agoDetect integer overflows when converting from strings
Arran Cudbard-Bell [Thu, 8 Nov 2018 21:55:43 +0000 (16:55 -0500)] 
Detect integer overflows when converting from strings

7 years agoUse the unsigned integer parser to parse unsigned integers
Arran Cudbard-Bell [Thu, 8 Nov 2018 21:55:07 +0000 (16:55 -0500)] 
Use the unsigned integer parser to parse unsigned integers

7 years agoRename integer casting function
Arran Cudbard-Bell [Thu, 8 Nov 2018 21:54:45 +0000 (16:54 -0500)] 
Rename integer casting function

7 years agoEscape tmpl names correctly when printing errors
Arran Cudbard-Bell [Thu, 8 Nov 2018 20:43:02 +0000 (15:43 -0500)] 
Escape tmpl names correctly when printing errors

7 years agoConvert "%{string:}" to use async API
Arran Cudbard-Bell [Thu, 8 Nov 2018 20:04:23 +0000 (15:04 -0500)] 
Convert "%{string:}" to use async API

7 years agoSwap ok/updated action priorities
Arran Cudbard-Bell [Wed, 7 Nov 2018 22:00:44 +0000 (17:00 -0500)] 
Swap ok/updated action priorities

7 years agosigned / unsigned issue
Alan T. DeKok [Wed, 7 Nov 2018 21:37:41 +0000 (16:37 -0500)] 
signed / unsigned issue

7 years agoBalance RINDENT and REXDENT in fr_ldap_timeout_debug
Arran Cudbard-Bell [Wed, 7 Nov 2018 21:15:19 +0000 (16:15 -0500)] 
Balance RINDENT and REXDENT in fr_ldap_timeout_debug

7 years agoFix json code so mapped value is the raw value
Arran Cudbard-Bell [Wed, 7 Nov 2018 21:01:22 +0000 (16:01 -0500)] 
Fix json code so mapped value is the raw value

7 years agoArg...
Arran Cudbard-Bell [Wed, 7 Nov 2018 20:21:05 +0000 (15:21 -0500)] 
Arg...

7 years agoclean up proxy / message authenticator handling
Alan T. DeKok [Wed, 7 Nov 2018 20:12:52 +0000 (15:12 -0500)] 
clean up proxy / message authenticator handling

7 years agore-arrange and clean up
Alan T. DeKok [Wed, 7 Nov 2018 19:37:38 +0000 (14:37 -0500)] 
re-arrange and clean up

in preparation for abstracting it to separate outbound IO from
RADIUS work

7 years agoremove unnecessary UNUSED
Alan T. DeKok [Mon, 5 Nov 2018 21:12:07 +0000 (16:12 -0500)] 
remove unnecessary UNUSED

7 years agorename packet states for clarity
Alan T. DeKok [Mon, 5 Nov 2018 21:11:38 +0000 (16:11 -0500)] 
rename packet states for clarity

7 years agoQuiet compiler
Arran Cudbard-Bell [Wed, 7 Nov 2018 20:15:00 +0000 (15:15 -0500)] 
Quiet compiler

7 years agoStart of the rlm_rediswho structure should be the standard config struct, not a point...
Arran Cudbard-Bell [Wed, 7 Nov 2018 20:11:01 +0000 (15:11 -0500)] 
Start of the rlm_rediswho structure should be the standard config struct, not a pointer fixes #2350

7 years agoQuiet compiler
Arran Cudbard-Bell [Wed, 7 Nov 2018 20:10:36 +0000 (15:10 -0500)] 
Quiet compiler

ssshh

7 years agocli not global
Arran Cudbard-Bell [Wed, 7 Nov 2018 19:53:28 +0000 (14:53 -0500)] 
cli not global

7 years agoOnly try and join the cli pthread if we're running with the cli
Arran Cudbard-Bell [Wed, 7 Nov 2018 19:48:46 +0000 (14:48 -0500)] 
Only try and join the cli pthread if we're running with the cli

7 years agoMerge pull request #2349 from mattrose/master
Arran Cudbard-Bell [Mon, 5 Nov 2018 17:42:18 +0000 (12:42 -0500)] 
Merge pull request #2349 from mattrose/master

added docker scripts for ubuntu bionic

7 years agoadded docker scripts for ubuntu bionic 2349/head
Matt Rose [Mon, 5 Nov 2018 16:20:45 +0000 (11:20 -0500)] 
added docker scripts for ubuntu bionic

7 years agoMerge pull request #2347 from herwinw/compile_fix_sha3_512
Alan DeKok [Fri, 2 Nov 2018 18:39:00 +0000 (14:39 -0400)] 
Merge pull request #2347 from herwinw/compile_fix_sha3_512

Compile fixes for HAVE_EVP_SHA3_512

7 years agoremove rlm_radius_link_t
Alan T. DeKok [Fri, 2 Nov 2018 18:21:50 +0000 (14:21 -0400)] 
remove rlm_radius_link_t

which is one less data structure per request.

7 years agomove "resume" to rlm_radius_udp
Alan T. DeKok [Fri, 2 Nov 2018 18:07:45 +0000 (14:07 -0400)] 
move "resume" to rlm_radius_udp

in preparation for getting rid of "link"

7 years agoCompile fixes for HAVE_EVP_SHA3_512 2347/head
Herwin Weststrate [Fri, 2 Nov 2018 17:24:08 +0000 (18:24 +0100)] 
Compile fixes for HAVE_EVP_SHA3_512

7 years agofix argument ordering
Alan T. DeKok [Fri, 2 Nov 2018 15:50:20 +0000 (11:50 -0400)] 
fix argument ordering

7 years agowe shouldn't track which requests are using this module
Alan T. DeKok [Fri, 2 Nov 2018 15:24:13 +0000 (11:24 -0400)] 
we shouldn't track which requests are using this module

the unlang interpreter does that.  The rest of the code should
guarantee that all requests are stopped / freed before a module
is detached.

7 years agotypo
Alan T. DeKok [Fri, 2 Nov 2018 15:25:09 +0000 (11:25 -0400)] 
typo

7 years agomore travis fixes
Alan T. DeKok [Fri, 2 Nov 2018 14:58:34 +0000 (10:58 -0400)] 
more travis fixes

7 years agobuild fixes for capabilities
Alan T. DeKok [Fri, 2 Nov 2018 14:27:07 +0000 (10:27 -0400)] 
build fixes for capabilities

7 years agostop radmin only if it was started
Alan T. DeKok [Fri, 2 Nov 2018 13:43:21 +0000 (09:43 -0400)] 
stop radmin only if it was started

7 years agoOnly do cap checks if we're not root
Arran Cudbard-Bell [Fri, 2 Nov 2018 13:37:15 +0000 (09:37 -0400)] 
Only do cap checks if we're not root

Create an error stack so that if the bind *does* fail, then there are helpful hints about what to do.

7 years agofix for map_afrom_cs
Alan T. DeKok [Fri, 2 Nov 2018 13:33:03 +0000 (09:33 -0400)] 
fix for map_afrom_cs

7 years agofix my email address from ox.org to freeradius.org
Alan T. DeKok [Fri, 2 Nov 2018 12:26:36 +0000 (08:26 -0400)] 
fix my email address from ox.org to freeradius.org

7 years agoadd suid up/down for DHCP
Alan T. DeKok [Fri, 2 Nov 2018 12:17:19 +0000 (08:17 -0400)] 
add suid up/down for DHCP

7 years agomake map_afrom_cs() take a TALLOC_CTX argument
Alan T. DeKok [Thu, 1 Nov 2018 19:05:35 +0000 (15:05 -0400)] 
make map_afrom_cs() take a TALLOC_CTX argument

so that the maps aren't always allocated from the CONF_SECTION

Which is useful in some cases, and means that the API is similar
to other functions.  e.g. map_afrom_cp()

7 years agodon't allow rlm_always to change it's running config
Alan T. DeKok [Thu, 1 Nov 2018 18:41:35 +0000 (14:41 -0400)] 
don't allow rlm_always to change it's running config

it was only used for one module test.  We can now do the same
thing directly in unlang.

7 years agoCheck if we have the CAP_NET_BIND_SERVICE capability
Arran Cudbard-Bell [Fri, 2 Nov 2018 01:27:58 +0000 (21:27 -0400)] 
Check if we have the CAP_NET_BIND_SERVICE capability

If we don't, error out, and say how to set it

7 years agoRename some variables in fr_get_debug_state
Arran Cudbard-Bell [Fri, 2 Nov 2018 01:27:12 +0000 (21:27 -0400)] 
Rename some variables in fr_get_debug_state

7 years agoFixup argument names to be consistent between xlat functions
Arran Cudbard-Bell [Thu, 1 Nov 2018 19:04:05 +0000 (15:04 -0400)] 
Fixup argument names to be consistent between xlat functions

7 years agoUnused but needed for dictionary work
Arran Cudbard-Bell [Thu, 1 Nov 2018 17:48:28 +0000 (13:48 -0400)] 
Unused but needed for dictionary work

7 years agoRename modules.[ch] to module.[ch]
Arran Cudbard-Bell [Thu, 1 Nov 2018 17:47:13 +0000 (13:47 -0400)] 
Rename modules.[ch] to module.[ch]

7 years agore-add module_thread_instance_by_data()
Alan T. DeKok [Thu, 1 Nov 2018 16:39:56 +0000 (12:39 -0400)] 
re-add module_thread_instance_by_data()

7 years agoremove "ctx" from fr_pair_list_move()
Alan T. DeKok [Thu, 1 Nov 2018 15:50:54 +0000 (11:50 -0400)] 
remove "ctx" from fr_pair_list_move()

all of the callers already allocated the VPs from the correct
ctx, so there's no need to call fr_pair_steal(), which means
there's no need for the ctx

7 years agoremove unused functions
Alan T. DeKok [Thu, 1 Nov 2018 15:29:45 +0000 (11:29 -0400)] 
remove unused functions

7 years agouse the correct parent, instead of calling steal()
Alan T. DeKok [Thu, 1 Nov 2018 15:22:31 +0000 (11:22 -0400)] 
use the correct parent, instead of calling steal()

7 years agothere's no need to talloc_steal() here.
Alan T. DeKok [Thu, 1 Nov 2018 15:02:36 +0000 (11:02 -0400)] 
there's no need to talloc_steal() here.

The entry is parented from the instance anyways, so there's no
need to reparent the entry to be from the tree.  The lifetime of
all of those objects is the same anyways: the lifetime of the
instance data.

7 years agouse an array in each thread for module instances
Alan T. DeKok [Thu, 1 Nov 2018 14:41:06 +0000 (10:41 -0400)] 
use an array in each thread for module instances

which should be faster and simpler.

7 years agorename
Alan T. DeKok [Thu, 1 Nov 2018 14:10:14 +0000 (10:10 -0400)] 
rename

because everything else is "foo.c" and "foo.h"

7 years agoallocate dl_loader from a new context
Alan T. DeKok [Thu, 1 Nov 2018 14:03:25 +0000 (10:03 -0400)] 
allocate dl_loader from a new context

because we reference count proto_foo_* as new connections are
opened.

7 years agouse correct parent for talloc
Alan T. DeKok [Thu, 1 Nov 2018 13:06:58 +0000 (09:06 -0400)] 
use correct parent for talloc

7 years agoforce all users of master IO to be thread-safe
Alan T. DeKok [Tue, 30 Oct 2018 19:24:47 +0000 (15:24 -0400)] 
force all users of master IO to be thread-safe

7 years agouse 2M of mprotected memory for travis builds
Alan T. DeKok [Tue, 30 Oct 2018 19:20:12 +0000 (15:20 -0400)] 
use 2M of mprotected memory for travis builds

7 years agouse NULL as talloc parent for thread_instance
Alan T. DeKok [Tue, 30 Oct 2018 15:43:52 +0000 (11:43 -0400)] 
use NULL as talloc parent for thread_instance

7 years agodon't reset work_io_instance. It's now "const"
Alan T. DeKok [Tue, 30 Oct 2018 15:28:28 +0000 (11:28 -0400)] 
don't reset work_io_instance.  It's now "const"

7 years agomove mutex into thread instance of the file reader
Alan T. DeKok [Tue, 30 Oct 2018 15:23:31 +0000 (11:23 -0400)] 
move mutex into thread instance of the file reader

7 years agonotes on listener being thread-safe here
Alan T. DeKok [Tue, 30 Oct 2018 15:14:38 +0000 (11:14 -0400)] 
notes on listener being thread-safe here

7 years agomove prototype
Alan T. DeKok [Tue, 30 Oct 2018 15:08:56 +0000 (11:08 -0400)] 
move prototype

7 years agoallocate thread_instance from NULL ctx
Alan T. DeKok [Tue, 30 Oct 2018 15:07:21 +0000 (11:07 -0400)] 
allocate thread_instance from NULL ctx

and add a destructor

7 years agorename "live" to "thread" for consistency
Alan T. DeKok [Tue, 30 Oct 2018 15:05:00 +0000 (11:05 -0400)] 
rename "live" to "thread" for consistency

7 years agoBetter error
Arran Cudbard-Bell [Tue, 30 Oct 2018 13:52:07 +0000 (09:52 -0400)] 
Better error

7 years agoRemove spurious warning
Arran Cudbard-Bell [Mon, 29 Oct 2018 23:05:28 +0000 (19:05 -0400)] 
Remove spurious warning

7 years agolldb doesn't like this *sigh*
Arran Cudbard-Bell [Mon, 29 Oct 2018 22:59:43 +0000 (18:59 -0400)] 
lldb doesn't like this *sigh*

7 years agoTweak error
Arran Cudbard-Bell [Mon, 29 Oct 2018 22:52:25 +0000 (18:52 -0400)] 
Tweak error

7 years agoTerminate category
Arran Cudbard-Bell [Mon, 29 Oct 2018 22:20:54 +0000 (18:20 -0400)] 
Terminate category

7 years agothis variable exists only in some builds
Alan T. DeKok [Mon, 29 Oct 2018 20:07:32 +0000 (16:07 -0400)] 
this variable exists only in some builds

7 years agono one uses this
Alan T. DeKok [Mon, 29 Oct 2018 19:24:26 +0000 (15:24 -0400)] 
no one uses this

so we delete it.  There's no tests, no example module config,
no documentation, etc.

7 years agoremove last vestiges of struct signing
Alan T. DeKok [Mon, 29 Oct 2018 19:22:37 +0000 (15:22 -0400)] 
remove last vestiges of struct signing

7 years agowe now always build with threads
Alan T. DeKok [Mon, 29 Oct 2018 19:20:52 +0000 (15:20 -0400)] 
we now always build with threads

7 years agoremove WITH_TCP flag.
Alan T. DeKok [Mon, 29 Oct 2018 19:20:26 +0000 (15:20 -0400)] 
remove WITH_TCP flag.

We always build with TCP

7 years agoFix invalid/spurious leaks emitted from LSAN when test processes are forked
Arran Cudbard-Bell [Mon, 29 Oct 2018 17:08:54 +0000 (13:08 -0400)] 
Fix invalid/spurious leaks emitted from LSAN when test processes are forked

7 years agoalways set src/dst ip/port
Alan T. DeKok [Sun, 28 Oct 2018 17:41:25 +0000 (13:41 -0400)] 
always set src/dst ip/port

manual port of commit 1d090986ad0

7 years agotravis fixes
Alan T. DeKok [Fri, 26 Oct 2018 17:12:52 +0000 (13:12 -0400)] 
travis fixes

7 years agoconvert detail reader to thread-safe.
Alan T. DeKok [Fri, 26 Oct 2018 16:37:40 +0000 (12:37 -0400)] 
convert detail reader to thread-safe.

And fix bug where when mod_write() unpauses the socket, it also
seeks to the start of the file.  This ensures that if there is
leftover data in the buffer, mod_read() will be called again.

We can't rely on network.c to check "leftover", because it has
no idea if the socket "no data ready" means we should still call
mod_read().  For detail, yes.  For other protocols, maybe no.

Also fix the work instantiation so that it's done once, and not
multiple times.

7 years agomake proto_control_unix thread-safe
Alan T. DeKok [Thu, 25 Oct 2018 19:01:18 +0000 (15:01 -0400)] 
make proto_control_unix thread-safe

7 years agowe need "const", too
Alan T. DeKok [Thu, 25 Oct 2018 18:52:57 +0000 (14:52 -0400)] 
we need "const", too

7 years agoremove proto_control_tcp
Alan T. DeKok [Thu, 25 Oct 2018 18:46:34 +0000 (14:46 -0400)] 
remove proto_control_tcp

proto_control_unix has many more features and works.
proto_control_tcp is missing many things.

Once proto_control_unix is finished, we can look at re-enabling
proto_control_tcp

7 years agomake proto_vmps_udp thread-safe
Alan T. DeKok [Thu, 25 Oct 2018 18:45:23 +0000 (14:45 -0400)] 
make proto_vmps_udp thread-safe

7 years agocleanups
Alan T. DeKok [Thu, 25 Oct 2018 18:40:26 +0000 (14:40 -0400)] 
cleanups

7 years agocleanups, and convert TCP to thread-safe
Alan T. DeKok [Thu, 25 Oct 2018 18:39:55 +0000 (14:39 -0400)] 
cleanups, and convert TCP to thread-safe

7 years agoError out if parse callbacks fail or we can't push rules
Arran Cudbard-Bell [Wed, 24 Oct 2018 22:39:18 +0000 (18:39 -0400)] 
Error out if parse callbacks fail or we can't push rules

7 years agoPacket-Type is in ther internal dictionary
Arran Cudbard-Bell [Fri, 19 Oct 2018 01:32:16 +0000 (21:32 -0400)] 
Packet-Type is in ther internal dictionary

7 years agoFix typo in error
Arran Cudbard-Bell [Fri, 19 Oct 2018 01:41:47 +0000 (21:41 -0400)] 
Fix typo in error

7 years agoTLVs can be encrypted
Arran Cudbard-Bell [Fri, 19 Oct 2018 14:39:21 +0000 (10:39 -0400)] 
TLVs can be encrypted

7 years agoFixup tmpl validation
Arran Cudbard-Bell [Fri, 19 Oct 2018 14:46:31 +0000 (10:46 -0400)] 
Fixup tmpl validation

This checks that DAs are rooted correctly, and various other weird edge cases.

7 years agoMissed free-on-error
Arran Cudbard-Bell [Wed, 17 Oct 2018 19:12:53 +0000 (15:12 -0400)] 
Missed free-on-error

7 years agoProvide a case insensitive hash function
Arran Cudbard-Bell [Wed, 24 Oct 2018 17:20:07 +0000 (13:20 -0400)] 
Provide a case insensitive hash function

7 years agoMark VALUE_PAIR *req as unused in winbind_group_cmp
Arran Cudbard-Bell [Wed, 24 Oct 2018 17:25:06 +0000 (13:25 -0400)] 
Mark VALUE_PAIR *req as unused in winbind_group_cmp

7 years agolast_attr must be dictionary specific
Arran Cudbard-Bell [Wed, 24 Oct 2018 17:22:41 +0000 (13:22 -0400)] 
last_attr must be dictionary specific

7 years agofix const / threading issues
Alan T. DeKok [Wed, 24 Oct 2018 17:07:46 +0000 (13:07 -0400)] 
fix const / threading issues

7 years agouse thread-specific instance data
Alan T. DeKok [Wed, 24 Oct 2018 16:41:13 +0000 (12:41 -0400)] 
use thread-specific instance data

7 years agoAdd more types in by default
Arran Cudbard-Bell [Wed, 24 Oct 2018 16:21:34 +0000 (12:21 -0400)] 
Add more types in by default

7 years agouse thread-specific instance data
Alan T. DeKok [Wed, 24 Oct 2018 16:11:07 +0000 (12:11 -0400)] 
use thread-specific instance data

7 years agoadd thread_inst_size for app_io, and allocations for it.
Alan T. DeKok [Wed, 24 Oct 2018 15:26:30 +0000 (11:26 -0400)] 
add thread_inst_size for app_io, and allocations for it.

Nothing uses that field, so this commit is safe.

The next set of commits will split out the thread/socket data
from the constant configuration data.

7 years agocomments on where / how sockets are opened
Alan T. DeKok [Wed, 24 Oct 2018 15:24:04 +0000 (11:24 -0400)] 
comments on where / how sockets are opened

so that the documentation points to the correct location of the
source

7 years agoMerge pull request #2336 from KI4STU/patch-1
Arran Cudbard-Bell [Mon, 22 Oct 2018 20:48:03 +0000 (16:48 -0400)] 
Merge pull request #2336 from KI4STU/patch-1

Update filter: reject double dots

7 years agoUpdate filter: reject double dots 2336/head
Detrick [Mon, 22 Oct 2018 18:33:58 +0000 (14:33 -0400)] 
Update filter: reject double dots

Edit Module-Failure-Message to add clarity. Previous message ended with ".." which looks somewhat like an ellipsis giving the impression that the message has been truncated. New message replaces ".." with the word "dots" and adds an example.