]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
7 years agonotes on ldapsearch
Alan T. DeKok [Thu, 30 Aug 2018 02:10:39 +0000 (22:10 -0400)] 
notes on ldapsearch

7 years agoUpdate comments in LDAP module config (mainly for AD)
Matthew Newton [Thu, 30 Aug 2018 16:11:28 +0000 (17:11 +0100)] 
Update comments in LDAP module config (mainly for AD)

7 years agoclean up and simplify
Alan T. DeKok [Thu, 30 Aug 2018 15:53:56 +0000 (11:53 -0400)] 
clean up and simplify

so that it looks for commented out config sections, and prints
them as commented out raw text.

7 years agouse correct name for attribute
Alan T. DeKok [Wed, 29 Aug 2018 18:42:52 +0000 (14:42 -0400)] 
use correct name for attribute

7 years agocheck log_auth parameter
Alan T. DeKok [Tue, 28 Aug 2018 19:40:00 +0000 (15:40 -0400)] 
check log_auth parameter

7 years agomove macros to common header file
Alan T. DeKok [Tue, 28 Aug 2018 19:32:34 +0000 (15:32 -0400)] 
move macros to common header file

7 years agoset TLS-Session-Version and TLS-Session-Cipher-Suite
Alan T. DeKok [Tue, 28 Aug 2018 18:27:49 +0000 (14:27 -0400)] 
set TLS-Session-Version and TLS-Session-Cipher-Suite

as per similar code in v3

7 years agoclean up debug messages
Alan T. DeKok [Sat, 25 Aug 2018 20:14:27 +0000 (16:14 -0400)] 
clean up debug messages

7 years agotypo
Alan T. DeKok [Sat, 25 Aug 2018 12:26:58 +0000 (08:26 -0400)] 
typo

7 years agoNeed the hash functions in the dictionary...
Arran Cudbard-Bell [Fri, 24 Aug 2018 23:11:03 +0000 (19:11 -0400)] 
Need the hash functions in the dictionary...

7 years agoBetter "un-xlating" of value pairs where xlat is not supported 2290/head
nchaigne [Fri, 24 Aug 2018 15:33:14 +0000 (17:33 +0200)] 
Better "un-xlating" of value pairs where xlat is not supported

All kind of value pairs attributes can be VT_XLAT when read from input. We cannot assume they are strings or octets.
Better fail explicitly if the conversion is not possible.

For example, we will have:

dhcpclient: Invalid integer value "%{something}"

I fixed this issue in dhcpclient, radclient, and radsniff.

In addition, I corrected inaccurate comments in value.c about formats.

7 years agomove out of ifdef
Alan T. DeKok [Fri, 24 Aug 2018 12:09:58 +0000 (08:09 -0400)] 
move out of ifdef

7 years agouse real paths
Alan T. DeKok [Wed, 22 Aug 2018 16:37:02 +0000 (12:37 -0400)] 
use real paths

$(DIR) is relative (or absolute) randomly, depending on GNU make

7 years agoTypo
Arran Cudbard-Bell [Wed, 22 Aug 2018 16:09:38 +0000 (12:09 -0400)] 
Typo

7 years agoMerge pull request #2279 from mjducharme/master
Alan DeKok [Tue, 21 Aug 2018 12:24:53 +0000 (08:24 -0400)] 
Merge pull request #2279 from mjducharme/master

Added support for IPv6 RADIUS accounting in SQL - 4.0.x

7 years agoMerge pull request #2281 from lemenkov/dict_fixes
Alan DeKok [Tue, 21 Aug 2018 12:24:29 +0000 (08:24 -0400)] 
Merge pull request #2281 from lemenkov/dict_fixes

Several small dictionary fixes

7 years agoProper letter case 2281/head
Peter Lemenkov [Sun, 19 Aug 2018 18:44:06 +0000 (20:44 +0200)] 
Proper letter case

IP-TOS-Field was renamed to IP-Tos-Field in commit
c6670b1ac3e137df8f0af47103a82d1a575330f3. Let's rename it back to avoid
any confusion.

Similar changes for 3GPP-RAT-Type in dictionary.3gpp and for
Unisphere-PPP-Protocol in dictionary.unisphere.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
7 years agoValues should go after the attr declaration
Peter Lemenkov [Sun, 19 Aug 2018 18:27:43 +0000 (20:27 +0200)] 
Values should go after the attr declaration

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
7 years agoLooks like this attribute should be 70
Peter Lemenkov [Sun, 19 Aug 2018 17:37:08 +0000 (19:37 +0200)] 
Looks like this attribute should be 70

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
7 years agoRemove duplicated attribute definitions
Peter Lemenkov [Sun, 19 Aug 2018 17:36:47 +0000 (19:36 +0200)] 
Remove duplicated attribute definitions

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
7 years agoAdded support for IPv6 RADIUS accounting in SQL 2279/head
Michael Ducharme [Fri, 17 Aug 2018 23:09:37 +0000 (16:09 -0700)] 
Added support for IPv6 RADIUS accounting in SQL

7 years agouse new HEADERS rule for installing headers
Alan T. DeKok [Fri, 17 Aug 2018 16:26:31 +0000 (12:26 -0400)] 
use new HEADERS rule for installing headers

which (for now) finds all *.h files instead of being selective.
So if there's an extra one around, the build may break.

We can always fix that later

7 years agoprint out the directory, too
Alan T. DeKok [Fri, 17 Aug 2018 16:26:09 +0000 (12:26 -0400)] 
print out the directory, too

7 years agobetter way to install headers
Alan T. DeKok [Fri, 17 Aug 2018 16:08:50 +0000 (12:08 -0400)] 
better way to install headers

7 years agouse new ALL_HEADERS rule for installing headers
Alan T. DeKok [Fri, 17 Aug 2018 15:52:37 +0000 (11:52 -0400)] 
use new ALL_HEADERS rule for installing headers

7 years agonew ADD_INSTALL_RULE.h
Alan T. DeKok [Fri, 17 Aug 2018 15:35:24 +0000 (11:35 -0400)] 
new ADD_INSTALL_RULE.h

for installing header files

7 years agoclean up make rules
Alan T. DeKok [Fri, 17 Aug 2018 15:07:22 +0000 (11:07 -0400)] 
clean up make rules

in preparation for having automatic installation of header files

7 years agoMerge pull request #2276 from lemenkov/travelping_update_2017_06_22
Arran Cudbard-Bell [Fri, 17 Aug 2018 15:30:52 +0000 (11:30 -0400)] 
Merge pull request #2276 from lemenkov/travelping_update_2017_06_22

Travelping dictionary update

7 years agoAdd TP-Trace-Id to Travelping dictionary 2276/head
Yury Gargay [Thu, 22 Jun 2017 12:49:43 +0000 (14:49 +0200)] 
Add TP-Trace-Id to Travelping dictionary

May be used to share some OpenTracing id between components.

7 years agoAdd new travelping attributes to dictionary
0xAX [Tue, 5 Apr 2016 14:20:33 +0000 (20:20 +0600)] 
Add new travelping attributes to dictionary

7 years agoadd vendor values for Framed-Protocol and Service-Type
Andreas Schultz [Thu, 19 Feb 2015 15:59:18 +0000 (16:59 +0100)] 
add vendor values for Framed-Protocol and Service-Type

7 years agofix case of CAPWAP Power attributes in Travelping dictionary
Andreas Schultz [Thu, 5 Feb 2015 09:57:15 +0000 (10:57 +0100)] 
fix case of CAPWAP Power attributes in Travelping dictionary

7 years agoremove unused code
Alan T. DeKok [Fri, 17 Aug 2018 11:27:43 +0000 (07:27 -0400)] 
remove unused code

7 years agotypo
Alan T. DeKok [Thu, 16 Aug 2018 19:59:36 +0000 (15:59 -0400)] 
typo

7 years agodoxygen
Alan T. DeKok [Thu, 16 Aug 2018 19:05:21 +0000 (15:05 -0400)] 
doxygen

7 years agodoxygen
Alan T. DeKok [Thu, 16 Aug 2018 18:59:13 +0000 (14:59 -0400)] 
doxygen

7 years agoreturn NULL, not -1
Alan T. DeKok [Thu, 16 Aug 2018 18:58:04 +0000 (14:58 -0400)] 
return NULL, not -1

7 years agoapparently we need this, too...
Alan T. DeKok [Thu, 16 Aug 2018 18:32:57 +0000 (14:32 -0400)] 
apparently we need this, too...

7 years agoquiet clang scan
Alan T. DeKok [Thu, 16 Aug 2018 18:32:26 +0000 (14:32 -0400)] 
quiet clang scan

7 years agoclean up this for inst->name, too
Alan T. DeKok [Thu, 16 Aug 2018 17:30:47 +0000 (13:30 -0400)] 
clean up this for inst->name, too

7 years agouse new API to get socket name
Alan T. DeKok [Thu, 16 Aug 2018 17:27:11 +0000 (13:27 -0400)] 
use new API to get socket name

7 years agoadd app_io.c and function to create socket name
Alan T. DeKok [Thu, 16 Aug 2018 17:19:09 +0000 (13:19 -0400)] 
add app_io.c and function to create socket name

in a standard format

7 years agoput brackets around macro arguments
Alan T. DeKok [Thu, 16 Aug 2018 17:18:45 +0000 (13:18 -0400)] 
put brackets around macro arguments

7 years agoremove unused header
Alan T. DeKok [Thu, 16 Aug 2018 17:10:15 +0000 (13:10 -0400)] 
remove unused header

7 years agoremove unused detach() function
Alan T. DeKok [Thu, 16 Aug 2018 17:05:23 +0000 (13:05 -0400)] 
remove unused detach() function

7 years agoadd fd_set API
Alan T. DeKok [Thu, 16 Aug 2018 16:57:17 +0000 (12:57 -0400)] 
add fd_set API

7 years agoremove debug message
Alan T. DeKok [Thu, 16 Aug 2018 16:52:05 +0000 (12:52 -0400)] 
remove debug message

7 years agodo connect() here, instead of the UDP module
Alan T. DeKok [Thu, 16 Aug 2018 16:45:52 +0000 (12:45 -0400)] 
do connect() here, instead of the UDP module

7 years agomove set name out of instantiate for RADIUS
Alan T. DeKok [Thu, 16 Aug 2018 16:45:44 +0000 (12:45 -0400)] 
move set name out of instantiate for RADIUS

and stop doing connect() here

7 years agomove set name out of instantiate for RADIUS
Alan T. DeKok [Thu, 16 Aug 2018 14:07:42 +0000 (10:07 -0400)] 
move set name out of instantiate for RADIUS

7 years agomove set name out of instantiate
Alan T. DeKok [Thu, 16 Aug 2018 13:58:51 +0000 (09:58 -0400)] 
move set name out of instantiate

7 years agomove set name out of instantiate
Alan T. DeKok [Thu, 16 Aug 2018 13:53:55 +0000 (09:53 -0400)] 
move set name out of instantiate

7 years agouse get_name if available for connection name
Alan T. DeKok [Thu, 16 Aug 2018 13:52:46 +0000 (09:52 -0400)] 
use get_name if available for connection name

7 years agorearrange documentation
Alan T. DeKok [Thu, 16 Aug 2018 13:52:33 +0000 (09:52 -0400)] 
rearrange documentation

7 years agoverify connect_set is available
Alan T. DeKok [Thu, 16 Aug 2018 13:34:04 +0000 (09:34 -0400)] 
verify connect_set is available

and only call instantiate if it exists

7 years agothis needs to be socket_instance for now
Alan T. DeKok [Thu, 16 Aug 2018 13:28:38 +0000 (09:28 -0400)] 
this needs to be socket_instance for now

7 years agomove set name to open function
Alan T. DeKok [Thu, 16 Aug 2018 12:49:55 +0000 (08:49 -0400)] 
move set name to open function

7 years agostart of separation of config && thread data for network IO
Alan T. DeKok [Wed, 15 Aug 2018 18:39:40 +0000 (14:39 -0400)] 
start of separation of config && thread data for network IO

we now have "app_io_instance" which is the parsed configuration
data.

And we also have "socket_instance", which is the data that changes
at run-time.  e.g. socket FD, list of dynamic clients, statistics,
etc.

This commit just adds the API capabilities. The next few commits
should start separating the responsibilities of the various pieces
of information.

7 years agorename socket_add to listen_add
Alan T. DeKok [Mon, 13 Aug 2018 17:54:09 +0000 (13:54 -0400)] 
rename socket_add to listen_add

7 years agoone ifdef is needed
Alan T. DeKok [Mon, 13 Aug 2018 14:34:17 +0000 (10:34 -0400)] 
one ifdef is needed

7 years agomove tls_free() to header definition
Alan T. DeKok [Mon, 13 Aug 2018 12:55:40 +0000 (08:55 -0400)] 
move tls_free() to header definition

so that there are fewer ifdef's in the code

7 years agoremove tls_free if not available. Fixes #2272
Alan T. DeKok [Sat, 11 Aug 2018 01:27:35 +0000 (21:27 -0400)] 
remove tls_free if not available.  Fixes #2272

7 years agowe need to track our own parent for get_inst
Alan T. DeKok [Fri, 10 Aug 2018 15:32:34 +0000 (11:32 -0400)] 
we need to track our own parent for get_inst

7 years agoremove calls to talloc_parent()
Alan T. DeKok [Fri, 10 Aug 2018 15:15:56 +0000 (11:15 -0400)] 
remove calls to talloc_parent()

as it's fugly

7 years agomove each client to it's own talloc context
Alan T. DeKok [Fri, 10 Aug 2018 15:13:57 +0000 (11:13 -0400)] 
move each client to it's own talloc context

because each client can have many thousands of packets associated
with it, and we want to avoid O(N) issues in talloc

7 years agoRevert "show full log"
Alan T. DeKok [Fri, 10 Aug 2018 11:14:25 +0000 (07:14 -0400)] 
Revert "show full log"

This reverts commit d8514645242f2bf96cb0c2032e6fdbb0604943ba.

7 years agoparsed is not referenced
Alan T. DeKok [Fri, 10 Aug 2018 01:33:04 +0000 (21:33 -0400)] 
parsed is not referenced

referencing an item shouldn't prevent it from being parsed

7 years agoshow full log
Alan T. DeKok [Thu, 9 Aug 2018 19:14:19 +0000 (15:14 -0400)] 
show full log

7 years agotypo
Alan T. DeKok [Thu, 9 Aug 2018 18:50:35 +0000 (14:50 -0400)] 
typo

7 years agoDon't leave hanging message in non-debug builds
Arran Cudbard-Bell [Thu, 9 Aug 2018 18:48:16 +0000 (14:48 -0400)] 
Don't leave hanging message in non-debug builds

7 years agoprint out number of network / workers on error
Alan T. DeKok [Thu, 9 Aug 2018 18:35:01 +0000 (14:35 -0400)] 
print out number of network / workers on error

7 years agoprint out error message on failure
Alan T. DeKok [Thu, 9 Aug 2018 18:34:47 +0000 (14:34 -0400)] 
print out error message on failure

7 years agodon't call talloc_parent()
Alan T. DeKok [Thu, 9 Aug 2018 18:02:21 +0000 (14:02 -0400)] 
don't call talloc_parent()

instead, cache ef->el for FDs

7 years agouse 'nr' instead of 'rc'
Alan T. DeKok [Thu, 9 Aug 2018 18:01:51 +0000 (14:01 -0400)] 
use 'nr' instead of 'rc'

and pass 'nr' when adding network commands

7 years agocache event list in event_timer_t
Alan T. DeKok [Thu, 9 Aug 2018 17:22:52 +0000 (13:22 -0400)] 
cache event list in event_timer_t

because talloc_parent() is O(N) in the number of objects
in the talloc context.  Which is slow as heck, especially
if you're looping over events and deleting them one by one.

At that point, it becomes O(N^2), and all kinds of bad things
start happening.

7 years agorevert debug thread code
Alan T. DeKok [Thu, 9 Aug 2018 17:20:48 +0000 (13:20 -0400)] 
revert debug thread code

it's not the problem

7 years agogo to error instead of exit
Alan T. DeKok [Wed, 8 Aug 2018 19:24:12 +0000 (15:24 -0400)] 
go to error instead of exit

7 years agobe more stringent on allow varargs
Alan T. DeKok [Wed, 8 Aug 2018 18:34:31 +0000 (14:34 -0400)] 
be more stringent on allow varargs

7 years agotypo
Alan T. DeKok [Wed, 8 Aug 2018 18:33:44 +0000 (14:33 -0400)] 
typo

7 years agomight as well check all API calls, too
Alan T. DeKok [Wed, 8 Aug 2018 18:16:20 +0000 (14:16 -0400)] 
might as well check all API calls, too

7 years agotry to catch possible threading issues?
Alan T. DeKok [Wed, 8 Aug 2018 18:11:58 +0000 (14:11 -0400)] 
try to catch possible threading issues?

7 years agobump up max_workers
Alan T. DeKok [Wed, 8 Aug 2018 15:25:33 +0000 (11:25 -0400)] 
bump up max_workers

and ensure that the limit in the main config is the same
as in the network code

7 years agoallow any name2 for thread section
Alan T. DeKok [Wed, 8 Aug 2018 15:15:20 +0000 (11:15 -0400)] 
allow any name2 for thread section

7 years agouse num_workers here, too
Alan T. DeKok [Wed, 8 Aug 2018 14:56:20 +0000 (10:56 -0400)] 
use num_workers here, too

7 years agoset 1 spare
Alan T. DeKok [Wed, 8 Aug 2018 14:26:25 +0000 (10:26 -0400)] 
set 1 spare

7 years agouse num_workers in pool instead of min/max/spare servers
Alan T. DeKok [Wed, 8 Aug 2018 13:57:33 +0000 (09:57 -0400)] 
use num_workers in pool instead of min/max/spare servers

We've got to clean up the connection pool code, too...

7 years agoRevert "this might work around the assertion"
Alan T. DeKok [Wed, 8 Aug 2018 13:53:20 +0000 (09:53 -0400)] 
Revert "this might work around the assertion"

This reverts commit 78387637e068d1a8c34dce24c0147851a6da8ae5.

nope.

7 years agodelete old documentation and write new docs
Alan T. DeKok [Wed, 8 Aug 2018 13:26:49 +0000 (09:26 -0400)] 
delete old documentation and write new docs

for network / worker threads

7 years agoqualify ms == 1ms
Alan T. DeKok [Tue, 7 Aug 2018 20:00:00 +0000 (16:00 -0400)] 
qualify ms == 1ms

7 years agonote that some things aren't thread-safe in the future
Alan T. DeKok [Tue, 7 Aug 2018 19:35:53 +0000 (15:35 -0400)] 
note that some things aren't thread-safe in the future

7 years agoallow for finer-grained selection of worker stats
Alan T. DeKok [Tue, 7 Aug 2018 19:35:08 +0000 (15:35 -0400)] 
allow for finer-grained selection of worker stats

7 years agobe more careful about valid UTF-8 names
Alan T. DeKok [Tue, 7 Aug 2018 19:34:20 +0000 (15:34 -0400)] 
be more careful about valid UTF-8 names

and validate the name in the table

7 years agoremove "expiry_time IS NULL" from update query. Fixes #2262
Alan T. DeKok [Tue, 7 Aug 2018 19:11:04 +0000 (15:11 -0400)] 
remove "expiry_time IS NULL" from update query.  Fixes #2262

Oracle and PostgreSQL already had that change made.

7 years agocheck for NULL variable
Alan T. DeKok [Tue, 7 Aug 2018 18:23:14 +0000 (14:23 -0400)] 
check for NULL variable

7 years agothis might work around the assertion
Alan T. DeKok [Tue, 7 Aug 2018 18:21:44 +0000 (14:21 -0400)] 
this might work around the assertion

7 years agoadd assert for pre-existing ev
Alan T. DeKok [Tue, 7 Aug 2018 18:19:12 +0000 (14:19 -0400)] 
add assert for pre-existing ev

7 years agorename again
Alan T. DeKok [Tue, 7 Aug 2018 15:25:54 +0000 (11:25 -0400)] 
rename again

7 years agodon't write zero bytes, write a space instead
Alan T. DeKok [Tue, 7 Aug 2018 15:20:07 +0000 (11:20 -0400)] 
don't write zero bytes, write a space instead

7 years agobe a little more specific about the output
Alan T. DeKok [Tue, 7 Aug 2018 15:09:33 +0000 (11:09 -0400)] 
be a little more specific about the output

7 years agoadd more worker stats
Alan T. DeKok [Tue, 7 Aug 2018 15:00:29 +0000 (11:00 -0400)] 
add more worker stats