]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoRename some macros and move uid/gid parsing into callbacks
Arran Cudbard-Bell [Tue, 10 Jul 2018 20:26:19 +0000 (16:26 -0400)] 
Rename some macros and move uid/gid parsing into callbacks

8 years agoRevert "fopencookie API"
Alan T. DeKok [Tue, 10 Jul 2018 15:54:35 +0000 (11:54 -0400)] 
Revert "fopencookie API"

This reverts commit a8f1a8bdab50f99b2eb48c6531b63e5fb5ab517b.

nope

8 years agofopencookie API
Alan T. DeKok [Tue, 10 Jul 2018 15:32:10 +0000 (11:32 -0400)] 
fopencookie API

8 years agodoxygen
Alan T. DeKok [Tue, 10 Jul 2018 15:31:15 +0000 (11:31 -0400)] 
doxygen

8 years agodon't need stdout && stderr for the main listen socket
Alan T. DeKok [Tue, 10 Jul 2018 15:06:41 +0000 (11:06 -0400)] 
don't need stdout && stderr for the main listen socket

8 years agoarguments for fopencookie are a bit different
Alan T. DeKok [Tue, 10 Jul 2018 15:04:01 +0000 (11:04 -0400)] 
arguments for fopencookie are a bit different

8 years agoadd and check for read_only commands
Alan T. DeKok [Tue, 10 Jul 2018 15:01:29 +0000 (11:01 -0400)] 
add and check for read_only commands

8 years agohacks to get radmin sockets working.
Alan T. DeKok [Tue, 10 Jul 2018 14:43:24 +0000 (10:43 -0400)] 
hacks to get radmin sockets working.

The main thread just calls fr_radmin_run() directly.  Likely
not optimal, but it works for now.

8 years agoexpose "info init" and do more cleanups
Alan T. DeKok [Tue, 10 Jul 2018 14:34:39 +0000 (10:34 -0400)] 
expose "info init" and do more cleanups

8 years agojust mangle the command in-place
Alan T. DeKok [Tue, 10 Jul 2018 14:26:57 +0000 (10:26 -0400)] 
just mangle the command in-place

8 years agoflush fp's after running the command
Alan T. DeKok [Tue, 10 Jul 2018 14:22:30 +0000 (10:22 -0400)] 
flush fp's after running the command

so that the output goes somewhere immediately

8 years agoadd fr_radmin_run() which runs a particular radmin command
Alan T. DeKok [Tue, 10 Jul 2018 13:56:24 +0000 (09:56 -0400)] 
add fr_radmin_run() which runs a particular radmin command

It should probably take fr_cmd_info_t pointer, so that it doesn't
allocate that every time.

8 years agoprovisions for showing the name of the command
Alan T. DeKok [Tue, 10 Jul 2018 12:55:58 +0000 (08:55 -0400)] 
provisions for showing the name of the command

when listing them all, and their help text

8 years agoMove syslog facility parsing into a callback
Arran Cudbard-Bell [Mon, 9 Jul 2018 23:51:00 +0000 (19:51 -0400)] 
Move syslog facility parsing into a callback

8 years agoadded simple tests for alternation and optional things
Alan T. DeKok [Mon, 9 Jul 2018 19:48:03 +0000 (15:48 -0400)] 
added simple tests for alternation and optional things

8 years agoclarify tab_expand
Alan T. DeKok [Mon, 9 Jul 2018 19:43:16 +0000 (15:43 -0400)] 
clarify tab_expand

8 years agosearch for the command in info->cmd
Alan T. DeKok [Mon, 9 Jul 2018 19:27:51 +0000 (15:27 -0400)] 
search for the command in info->cmd

and assume that we don't need to call fr_command_find() again

8 years agosimple checks for (sort of) thread safety
Alan T. DeKok [Mon, 9 Jul 2018 17:24:27 +0000 (13:24 -0400)] 
simple checks for (sort of) thread safety

Only if people execute commands before the server has started running.

8 years agoswap around registration hooks
Alan T. DeKok [Mon, 9 Jul 2018 17:15:44 +0000 (13:15 -0400)] 
swap around registration hooks

so that they're in command.c, and radmin.c can swap it to
whatever it wants

8 years agooops
Alan T. DeKok [Mon, 9 Jul 2018 16:04:55 +0000 (12:04 -0400)] 
oops

8 years agolook at argv[1] not 0
Alan T. DeKok [Mon, 9 Jul 2018 15:48:00 +0000 (11:48 -0400)] 
look at argv[1] not 0

8 years agofix "help all"
Alan T. DeKok [Mon, 9 Jul 2018 15:43:59 +0000 (11:43 -0400)] 
fix "help all"

8 years agoallocate and fill in value boxes if required
Alan T. DeKok [Mon, 9 Jul 2018 15:39:25 +0000 (11:39 -0400)] 
allocate and fill in value boxes if required

8 years agoclear out value boxes in preparation for filling them in
Alan T. DeKok [Mon, 9 Jul 2018 15:20:26 +0000 (11:20 -0400)] 
clear out value boxes in preparation for filling them in

8 years agomove radmin to it's own header file
Alan T. DeKok [Mon, 9 Jul 2018 13:26:03 +0000 (09:26 -0400)] 
move radmin to it's own header file

8 years agodon't coninue on error, goto next
Alan T. DeKok [Mon, 9 Jul 2018 12:57:28 +0000 (08:57 -0400)] 
don't coninue on error, goto next

8 years agoreset argc to context after running command
Alan T. DeKok [Mon, 9 Jul 2018 12:36:49 +0000 (08:36 -0400)] 
reset argc to context after running command

8 years agoadded more commands and more help
Alan T. DeKok [Sun, 8 Jul 2018 23:50:38 +0000 (19:50 -0400)] 
added more commands and more help

so that the poor admin knows what to do

8 years agoadd more help text and commands
Alan T. DeKok [Sun, 8 Jul 2018 19:21:39 +0000 (15:21 -0400)] 
add more help text and commands

8 years agoallow help for commands with callbacks
Alan T. DeKok [Sun, 8 Jul 2018 19:21:05 +0000 (15:21 -0400)] 
allow help for commands with callbacks

which just prints the syntax for now

8 years agoprint out only one layer of help at a time
Alan T. DeKok [Sun, 8 Jul 2018 13:23:28 +0000 (09:23 -0400)] 
print out only one layer of help at a time

8 years agomake "info" global in preparation for context-specific help
Alan T. DeKok [Sat, 7 Jul 2018 12:10:36 +0000 (08:10 -0400)] 
make "info" global in preparation for context-specific help

8 years agouse standard macro
Alan T. DeKok [Fri, 6 Jul 2018 23:26:18 +0000 (19:26 -0400)] 
use standard macro

8 years agoFix off by one issue in cursor code
Arran Cudbard-Bell [Fri, 6 Jul 2018 20:22:38 +0000 (16:22 -0400)] 
Fix off by one issue in cursor code

8 years agoimplement show / set module status
Alan T. DeKok [Fri, 6 Jul 2018 19:43:37 +0000 (15:43 -0400)] 
implement show / set module status

8 years agoclean up function
Alan T. DeKok [Fri, 6 Jul 2018 19:07:11 +0000 (15:07 -0400)] 
clean up function

8 years agoremove unused variable
Alan T. DeKok [Fri, 6 Jul 2018 19:00:10 +0000 (15:00 -0400)] 
remove unused variable

8 years agostupid hooks to get it building and linking
Alan T. DeKok [Fri, 6 Jul 2018 18:40:28 +0000 (14:40 -0400)] 
stupid hooks to get it building and linking

8 years agoRevert "add stub functions"
Alan T. DeKok [Fri, 6 Jul 2018 18:31:36 +0000 (14:31 -0400)] 
Revert "add stub functions"

This reverts commit 1016e2847e68767ea2e6cf101a2957bf9f3faf62.

nope x2

8 years agoRevert "add local prototypes"
Alan T. DeKok [Fri, 6 Jul 2018 18:31:26 +0000 (14:31 -0400)] 
Revert "add local prototypes"

This reverts commit a4b06ed1f4ba3857bb6ff51b9da3f87b7912541c.

nope

8 years agoadd local prototypes
Alan T. DeKok [Fri, 6 Jul 2018 18:10:21 +0000 (14:10 -0400)] 
add local prototypes

8 years agoprint syntax if it exists, otherwise name.
Alan T. DeKok [Fri, 6 Jul 2018 17:53:12 +0000 (13:53 -0400)] 
print syntax if it exists, otherwise name.

8 years agoadd stub functions
Alan T. DeKok [Fri, 6 Jul 2018 17:45:32 +0000 (13:45 -0400)] 
add stub functions

8 years agoRevert "move radmin to libfreeradius-server"
Alan T. DeKok [Fri, 6 Jul 2018 17:42:20 +0000 (13:42 -0400)] 
Revert "move radmin to libfreeradius-server"

This reverts commit 44c9c958ded01601cd50565b9007dfd6af59581f.

nope, that's worse...

8 years agomove "parents" to a simple string
Alan T. DeKok [Fri, 6 Jul 2018 17:40:15 +0000 (13:40 -0400)] 
move "parents" to a simple string

8 years agoadd commands to show / set debug level
Alan T. DeKok [Fri, 6 Jul 2018 17:27:59 +0000 (13:27 -0400)] 
add commands to show / set debug level

8 years agomove radmin to libfreeradius-server
Alan T. DeKok [Fri, 6 Jul 2018 17:13:47 +0000 (13:13 -0400)] 
move radmin to libfreeradius-server

8 years agouse fr_command_list()
Alan T. DeKok [Fri, 6 Jul 2018 16:29:45 +0000 (12:29 -0400)] 
use fr_command_list()

8 years agoadd fr_command_list()
Alan T. DeKok [Fri, 6 Jul 2018 16:29:25 +0000 (12:29 -0400)] 
add fr_command_list()

which lists commands and their syntax

8 years agoadd "show module config MODULE" and "show module list"
Alan T. DeKok [Fri, 6 Jul 2018 16:16:59 +0000 (12:16 -0400)] 
add "show module config MODULE" and "show module list"

Woo!  Commands are useful

8 years agoexpose cf_section_write()
Alan T. DeKok [Fri, 6 Jul 2018 15:48:43 +0000 (11:48 -0400)] 
expose cf_section_write()

8 years agofirst command cannot be optional
Alan T. DeKok [Fri, 6 Jul 2018 15:01:43 +0000 (11:01 -0400)] 
first command cannot be optional

8 years agouse fr_command_verify_arg() instead of hand-rolled checks
Alan T. DeKok [Fri, 6 Jul 2018 15:01:06 +0000 (11:01 -0400)] 
use fr_command_verify_arg() instead of hand-rolled checks

8 years agoverify arguments properly while tab expanding
Alan T. DeKok [Fri, 6 Jul 2018 14:46:01 +0000 (10:46 -0400)] 
verify arguments properly while tab expanding

8 years agoremove unused assignment
Alan T. DeKok [Fri, 6 Jul 2018 14:33:49 +0000 (10:33 -0400)] 
remove unused assignment

8 years agoadded talloc debugging
Alan T. DeKok [Fri, 6 Jul 2018 13:57:34 +0000 (09:57 -0400)] 
added talloc debugging

which likely doesn't work as well as it should, because the
necessary talloc contexts are hidden...

8 years agofix alternation, and allow nested alternation
Alan T. DeKok [Fri, 6 Jul 2018 13:31:20 +0000 (09:31 -0400)] 
fix alternation, and allow nested alternation

update the parser to count () when looking for |

update the alternation children to be CHOICE, so that their children
can have "next" pointers without screwing up the alternation list
itself.

8 years agoUse the reference implementation in milenage.c for quintuplet to sim folding
Arran Cudbard-Bell [Thu, 5 Jul 2018 23:55:07 +0000 (19:55 -0400)] 
Use the reference implementation in milenage.c for quintuplet to sim folding

...it might actually work, unlike mine which doesn't.

8 years agoMerge pull request #2259 from cnelissen/master
Arran Cudbard-Bell [Thu, 5 Jul 2018 21:58:15 +0000 (17:58 -0400)] 
Merge pull request #2259 from cnelissen/master

Adding new Nomadix VSA’s and use official names

8 years agoAdding new Nomadix VSA’s and use official names 2259/head
Clint Nelissen [Thu, 5 Jul 2018 17:25:01 +0000 (10:25 -0700)] 
Adding new Nomadix VSA’s and use official names

8 years agoOne more...
Arran Cudbard-Bell [Thu, 5 Jul 2018 17:50:57 +0000 (13:50 -0400)] 
One more...

8 years agoRemove more uses of request
Arran Cudbard-Bell [Thu, 5 Jul 2018 17:50:24 +0000 (13:50 -0400)] 
Remove more uses of request

8 years agoRemover partial line?
Arran Cudbard-Bell [Thu, 5 Jul 2018 17:48:44 +0000 (13:48 -0400)] 
Remover partial line?

8 years agoBe extremely cautious about accessing the request in the osmocom thread
Arran Cudbard-Bell [Thu, 5 Jul 2018 17:19:38 +0000 (13:19 -0400)] 
Be extremely cautious about accessing the request in the osmocom thread

The issue here is that if any of these logging functions use the request for temporary storage, and the requests are modified asynchronously, or have a common parent in the worker, then subtle TALLOC corruption could result, which would explain all the random crashes we see.

8 years agoalternation works in simple tests
Alan T. DeKok [Thu, 5 Jul 2018 15:34:37 +0000 (11:34 -0400)] 
alternation works in simple tests

8 years agosupport nested optional strings
Alan T. DeKok [Thu, 5 Jul 2018 13:22:12 +0000 (09:22 -0400)] 
support nested optional strings

8 years agoclosing brace must be the last thing in the name
Alan T. DeKok [Thu, 5 Jul 2018 13:21:11 +0000 (09:21 -0400)] 
closing brace must be the last thing in the name

8 years agoIgnore run.sh
Arran Cudbard-Bell [Thu, 5 Jul 2018 15:18:31 +0000 (11:18 -0400)] 
Ignore run.sh

8 years agoRevert "Actuall free the link"
Arran Cudbard-Bell [Thu, 5 Jul 2018 15:16:22 +0000 (11:16 -0400)] 
Revert "Actuall free the link"

This reverts commit 2da8dcc5706dbc4807dcdcb779463bd8dc76d182.

# Conflicts:
# src/modules/rlm_sigtran/event.c

8 years agoTemporarily disable until we can debug the osmocom code
Arran Cudbard-Bell [Thu, 5 Jul 2018 15:15:16 +0000 (11:15 -0400)] 
Temporarily disable until we can debug the osmocom code

8 years agoExit gracefully on radmin error
Arran Cudbard-Bell [Thu, 5 Jul 2018 13:30:46 +0000 (09:30 -0400)] 
Exit gracefully on radmin error

8 years agoTypo
Arran Cudbard-Bell [Thu, 5 Jul 2018 13:01:28 +0000 (09:01 -0400)] 
Typo

8 years agoActuall free the link
Arran Cudbard-Bell [Thu, 5 Jul 2018 02:27:52 +0000 (22:27 -0400)] 
Actuall free the link

8 years agoNeed to tear down the control pipe too
Arran Cudbard-Bell [Thu, 5 Jul 2018 02:08:46 +0000 (22:08 -0400)] 
Need to tear down the control pipe too

8 years agotry and defer the exit to give us enough time to signal we're going down
Arran Cudbard-Bell [Thu, 5 Jul 2018 02:00:01 +0000 (22:00 -0400)] 
try and defer the exit to give us enough time to signal we're going down

8 years agoTypos
Arran Cudbard-Bell [Thu, 5 Jul 2018 00:53:15 +0000 (20:53 -0400)] 
Typos

8 years agoAttempt at geting osmocom to send a proper aspdn
Arran Cudbard-Bell [Thu, 5 Jul 2018 00:44:39 +0000 (20:44 -0400)] 
Attempt at geting osmocom to send a proper aspdn

8 years agoFix issues with sigtran not gracefully exiting
Arran Cudbard-Bell [Wed, 4 Jul 2018 22:21:51 +0000 (18:21 -0400)] 
Fix issues with sigtran not gracefully exiting

8 years agoInclude scheduler header
Arran Cudbard-Bell [Wed, 4 Jul 2018 22:16:07 +0000 (18:16 -0400)] 
Include scheduler header

8 years agoToo verbose
Arran Cudbard-Bell [Wed, 4 Jul 2018 22:14:45 +0000 (18:14 -0400)] 
Too verbose

8 years agoMust be malloced
Arran Cudbard-Bell [Wed, 4 Jul 2018 20:36:47 +0000 (16:36 -0400)] 
Must be malloced

8 years agopthread_sigmask needs to be called inside the new thread
Arran Cudbard-Bell [Wed, 4 Jul 2018 20:21:23 +0000 (16:21 -0400)] 
pthread_sigmask needs to be called inside the new thread

...duh.

8 years agoUse central thread creation function that prevents signals being delivered to pthreads
Arran Cudbard-Bell [Wed, 4 Jul 2018 20:06:27 +0000 (16:06 -0400)] 
Use central thread creation function that prevents signals being delivered to pthreads

8 years agofix test backto just command
Alan T. DeKok [Wed, 4 Jul 2018 19:11:19 +0000 (15:11 -0400)] 
fix test backto just command

8 years agomake optional matching work
Alan T. DeKok [Wed, 4 Jul 2018 19:05:40 +0000 (15:05 -0400)] 
make optional matching work

commands are parsed and run.  But tab completion isn't tested.

8 years agoprint out error when we receive it
Alan T. DeKok [Wed, 4 Jul 2018 17:10:04 +0000 (13:10 -0400)] 
print out error when we receive it

8 years agomove tab expand argv to it's own function
Alan T. DeKok [Wed, 4 Jul 2018 17:00:02 +0000 (13:00 -0400)] 
move tab expand argv to it's own function

8 years agomove to linked list / tree for syntax arguments
Alan T. DeKok [Wed, 4 Jul 2018 15:32:25 +0000 (11:32 -0400)] 
move to linked list / tree for syntax arguments

in preparation for allowing alternation && optional arguments

8 years ago..and more
Arran Cudbard-Bell [Wed, 4 Jul 2018 01:10:56 +0000 (21:10 -0400)] 
..and more

8 years ago..and some more
Arran Cudbard-Bell [Wed, 4 Jul 2018 01:07:13 +0000 (21:07 -0400)] 
..and some more

8 years agoPrefix more log messages
Arran Cudbard-Bell [Wed, 4 Jul 2018 01:03:41 +0000 (21:03 -0400)] 
Prefix more log messages

8 years agoBetter debug messages
Arran Cudbard-Bell [Wed, 4 Jul 2018 00:51:21 +0000 (20:51 -0400)] 
Better debug messages

8 years agoDocument DNS config items
Arran Cudbard-Bell [Wed, 4 Jul 2018 00:31:21 +0000 (20:31 -0400)] 
Document DNS config items

8 years agoWe should allow hostname lookups by default
Arran Cudbard-Bell [Wed, 4 Jul 2018 00:13:58 +0000 (20:13 -0400)] 
We should allow hostname lookups by default

8 years agoEmit error if asked to resolve a hostname, and hostname resolution is disabled
Arran Cudbard-Bell [Wed, 4 Jul 2018 00:13:46 +0000 (20:13 -0400)] 
Emit error if asked to resolve a hostname, and hostname resolution is disabled

8 years agoremove unused assignment
Alan T. DeKok [Tue, 3 Jul 2018 19:25:42 +0000 (15:25 -0400)] 
remove unused assignment

8 years agorun split differently based on syntax or user-supplied string
Alan T. DeKok [Tue, 3 Jul 2018 19:23:42 +0000 (15:23 -0400)] 
run split differently based on syntax or user-supplied string

8 years agomove parsing of syntax to using fr_cmd_argv_t
Alan T. DeKok [Tue, 3 Jul 2018 18:53:55 +0000 (14:53 -0400)] 
move parsing of syntax to using fr_cmd_argv_t

8 years agomove argv/types to it's own data structure
Alan T. DeKok [Tue, 3 Jul 2018 18:27:12 +0000 (14:27 -0400)] 
move argv/types to it's own data structure

in preparation for allowing alternation, etc.

8 years agoclean up re-use of data types
Alan T. DeKok [Tue, 3 Jul 2018 17:43:16 +0000 (13:43 -0400)] 
clean up re-use of data types

in preparation for allowing alternation, etc.