]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
9 months agocompare "major" to "type", and not "major" to "major"
Alan T. DeKok [Tue, 12 Nov 2024 00:22:04 +0000 (19:22 -0500)] 
compare "major" to "type", and not "major" to "major"

9 months agoadd cbor corpus, and run the fuzzer tests
Alan T. DeKok [Tue, 12 Nov 2024 00:03:28 +0000 (19:03 -0500)] 
add cbor corpus, and run the fuzzer tests

9 months agocheck value to quiet coverity
Alan T. DeKok [Mon, 11 Nov 2024 21:18:50 +0000 (16:18 -0500)] 
check value to quiet coverity

the dbuff code ensures that we don't loop over too much data, but
Coverity doesn't know that.

9 months agoallow actions {...} in more sections
Alan T. DeKok [Mon, 11 Nov 2024 21:15:01 +0000 (16:15 -0500)] 
allow actions {...} in more sections

and document why they can't be in redundant, etc.

9 months agoUse %sql.fetch() and %sql.modify() in SQL xlat tests
Nick Porter [Tue, 12 Nov 2024 09:25:20 +0000 (09:25 +0000)] 
Use %sql.fetch() and %sql.modify() in SQL xlat tests

9 months agoAdd %sql.fetch() and %sql.modify() xlats
Nick Porter [Tue, 12 Nov 2024 08:29:13 +0000 (08:29 +0000)] 
Add %sql.fetch() and %sql.modify() xlats

The generic %sql() xlat attempts to determine whether a query is
expected to return data based on the initial key word in the statement.

That is not guarunteed to be correct in all situations, e.g. `UPDATE ...
RETURNING ...` does return data unlike other queries starting `UPDATE`

%sql.fetch() is expected to return data.
%sql.modify() is expected to return the number of rows affected.

9 months agoAdd finalisation safety checks
Arran Cudbard-Bell [Mon, 11 Nov 2024 23:17:33 +0000 (17:17 -0600)] 
Add finalisation safety checks

9 months agoBe _EXPLICIT_ about when we want to refer to attributes primarily by name
Arran Cudbard-Bell [Mon, 11 Nov 2024 22:40:33 +0000 (16:40 -0600)] 
Be _EXPLICIT_ about when we want to refer to attributes primarily by name

9 months agoWe can't _rely_ on deffered cloning to make this work anymore
Arran Cudbard-Bell [Mon, 11 Nov 2024 21:05:32 +0000 (15:05 -0600)] 
We can't _rely_ on deffered cloning to make this work anymore

9 months agoApply clone fixups immediately if possible
Arran Cudbard-Bell [Mon, 11 Nov 2024 20:12:35 +0000 (14:12 -0600)] 
Apply clone fixups immediately if possible

9 months agoDon't automatically enter sections for deferred attributes (they don't exist yet)
Arran Cudbard-Bell [Mon, 11 Nov 2024 19:13:56 +0000 (13:13 -0600)] 
Don't automatically enter sections for deferred attributes (they don't exist yet)

9 months agoDon't duplicate the enum copying code
Arran Cudbard-Bell [Mon, 11 Nov 2024 19:26:26 +0000 (13:26 -0600)] 
Don't duplicate the enum copying code

9 months agoHave dict_attr_flags_valid operate on a da
Arran Cudbard-Bell [Mon, 11 Nov 2024 20:27:09 +0000 (14:27 -0600)] 
Have dict_attr_flags_valid operate on a da

Allow internal with has_value

9 months agobetter errors for double loads
Alan T. DeKok [Mon, 11 Nov 2024 20:17:12 +0000 (15:17 -0500)] 
better errors for double loads

9 months agoallow deferred siblings
Alan T. DeKok [Mon, 11 Nov 2024 19:08:35 +0000 (14:08 -0500)] 
allow deferred siblings

9 months agodon't push NULL relative attributes
Alan T. DeKok [Mon, 11 Nov 2024 19:03:48 +0000 (14:03 -0500)] 
don't push NULL relative attributes

9 months agocheck for zero-length strings and octets
Alan T. DeKok [Mon, 11 Nov 2024 16:08:45 +0000 (11:08 -0500)] 
check for zero-length strings and octets

9 months agodecode and encode unknown (raw), but typed data
Alan T. DeKok [Mon, 11 Nov 2024 15:32:51 +0000 (10:32 -0500)] 
decode and encode unknown (raw), but typed data

9 months agoallow casts in RHS of raw attributes
Alan T. DeKok [Mon, 11 Nov 2024 14:04:56 +0000 (09:04 -0500)] 
allow casts in RHS of raw attributes

so that we can set the data type

9 months agodisallow changing types in raw / unknown attributes
Alan T. DeKok [Mon, 11 Nov 2024 12:33:11 +0000 (07:33 -0500)] 
disallow changing types in raw / unknown attributes

raw.User-Name = 0xabcdef

is OK

raw.User-Name = (ipv4addr) 192.0.2.1

is not OK.

9 months agoallow passing type to "unknown from OID string"
Alan T. DeKok [Mon, 11 Nov 2024 12:09:57 +0000 (07:09 -0500)] 
allow passing type to "unknown from OID string"

9 months agounknown / raw pairs can now be typed.
Alan T. DeKok [Mon, 11 Nov 2024 11:45:17 +0000 (06:45 -0500)] 
unknown / raw pairs can now be typed.

9 months agoguess the data type of unknown attributes
Alan T. DeKok [Mon, 11 Nov 2024 00:37:45 +0000 (19:37 -0500)] 
guess the data type of unknown attributes

9 months agopoint more clearly to the docs
Alan T. DeKok [Mon, 11 Nov 2024 11:25:27 +0000 (06:25 -0500)] 
point more clearly to the docs

9 months agowe're not smurfs. Module module module module is annoying
Alan T. DeKok [Mon, 11 Nov 2024 11:22:45 +0000 (06:22 -0500)] 
we're not smurfs.  Module module module module is annoying

9 months agoDon't return on `notfound` module codes in accounting
Nick Porter [Mon, 11 Nov 2024 12:32:18 +0000 (12:32 +0000)] 
Don't return on `notfound` module codes in accounting

It's perfectly valid to return `notfound` when looking up a user in
accounting, and still carry on processing.

9 months agoadd support for encode / decode of time_delta
Alan T. DeKok [Sun, 10 Nov 2024 21:55:39 +0000 (16:55 -0500)] 
add support for encode / decode of time_delta

9 months agohandle raw / unknown attributes
Alan T. DeKok [Sun, 10 Nov 2024 15:30:38 +0000 (10:30 -0500)] 
handle raw / unknown attributes

with a "todo" to discover the actual type

9 months agoclean up to quit static analyzer
Alan T. DeKok [Sun, 10 Nov 2024 14:29:43 +0000 (09:29 -0500)] 
clean up to quit static analyzer

9 months agoinitialize output to shut up clang scan
Alan T. DeKok [Sun, 10 Nov 2024 14:28:29 +0000 (09:28 -0500)] 
initialize output to shut up clang scan

it doesn't see that the memcpy() call either initialized the
output, or fails.  So just poke it to quiet the analyzer.

However, we don't want to do this in a normal build.

9 months agoinstall libfreeradius-cbor
Alan T. DeKok [Sun, 10 Nov 2024 14:00:31 +0000 (09:00 -0500)] 
install libfreeradius-cbor

9 months agoadd enumv to value box decode
Alan T. DeKok [Sun, 10 Nov 2024 13:34:55 +0000 (08:34 -0500)] 
add enumv to value box decode

9 months agoshut up static analyzer
Alan T. DeKok [Sun, 10 Nov 2024 13:07:24 +0000 (08:07 -0500)] 
shut up static analyzer

9 months agocopy before assigning to value-box
Alan T. DeKok [Sat, 9 Nov 2024 17:56:17 +0000 (12:56 -0500)] 
copy before assigning to value-box

9 months agomore stupid format arg fixes
Alan T. DeKok [Sat, 9 Nov 2024 17:26:42 +0000 (12:26 -0500)] 
more stupid format arg fixes

9 months agoencode / decode data type 'group'
Alan T. DeKok [Sat, 9 Nov 2024 16:51:42 +0000 (11:51 -0500)] 
encode / decode data type 'group'

9 months agoadd %cbor.encode(), %cbor.decode(), and associated tests
Alan T. DeKok [Sat, 9 Nov 2024 16:45:21 +0000 (11:45 -0500)] 
add %cbor.encode(), %cbor.decode(), and associated tests

9 months agoadd decoding of ethernet, IPv4, IPv6, etc.
Alan T. DeKok [Sat, 9 Nov 2024 14:00:20 +0000 (14:00 +0000)] 
add decoding of ethernet, IPv4, IPv6, etc.

9 months agostupid local compiler
Alan T. DeKok [Fri, 8 Nov 2024 16:28:45 +0000 (16:28 +0000)] 
stupid local compiler

9 months agoadd fake cbor protocol, only for testing. and add cbor tests
Alan T. DeKok [Fri, 8 Nov 2024 16:21:50 +0000 (16:21 +0000)] 
add fake cbor protocol, only for testing. and add cbor tests

9 months agoadd cbor encoder and decoder
Alan T. DeKok [Fri, 8 Nov 2024 16:21:09 +0000 (16:21 +0000)] 
add cbor encoder and decoder

9 months agoDon't use memcpy when grabbing single bytes from the buffer
Arran Cudbard-Bell [Sun, 10 Nov 2024 14:27:55 +0000 (08:27 -0600)] 
Don't use memcpy when grabbing single bytes from the buffer

9 months agoAllow multiple different auto-merge behaviours
Arran Cudbard-Bell [Sun, 10 Nov 2024 14:01:53 +0000 (08:01 -0600)] 
Allow multiple different auto-merge behaviours

9 months agoRemove taint support from regexes, and add regex.safe()
Arran Cudbard-Bell [Sat, 9 Nov 2024 23:13:11 +0000 (17:13 -0600)] 
Remove taint support from regexes, and add regex.safe()

9 months agoFix "too many args" error
Arran Cudbard-Bell [Sat, 9 Nov 2024 22:13:12 +0000 (16:13 -0600)] 
Fix "too many args" error

9 months agoReport push failures
Arran Cudbard-Bell [Sat, 9 Nov 2024 22:02:19 +0000 (16:02 -0600)] 
Report push failures

9 months agoMerge instead of rebase, to keep signatures intact, and avoid local conflicts
Arran Cudbard-Bell [Sat, 9 Nov 2024 20:54:20 +0000 (14:54 -0600)] 
Merge instead of rebase, to keep signatures intact, and avoid local conflicts

9 months agoAttempt to get auto-rebase and merge working again
Arran Cudbard-Bell [Sat, 9 Nov 2024 17:47:27 +0000 (11:47 -0600)] 
Attempt to get auto-rebase and merge working again

9 months agoFix custom values for dynamic clients
Arran Cudbard-Bell [Sat, 9 Nov 2024 14:58:02 +0000 (08:58 -0600)] 
Fix custom values for dynamic clients

9 months agoOutput test ports from the openresty-setup script
Arran Cudbard-Bell [Sat, 9 Nov 2024 14:57:36 +0000 (08:57 -0600)] 
Output test ports from the openresty-setup script

9 months agoUse current argument parser for rest xlat, instead of rolling our own weird thing...
Arran Cudbard-Bell [Sat, 9 Nov 2024 05:04:18 +0000 (23:04 -0600)] 
Use current argument parser for rest xlat, instead of rolling our own weird thing...

9 months agoAdvance arg in the xlat argument tokenizer...
Arran Cudbard-Bell [Sat, 9 Nov 2024 14:57:17 +0000 (08:57 -0600)] 
Advance arg in the xlat argument tokenizer...

9 months agoAdd RuntimeDirectoryPreserve=yes to systemd service definitions
Nick Porter [Fri, 8 Nov 2024 08:23:18 +0000 (08:23 +0000)] 
Add RuntimeDirectoryPreserve=yes to systemd service definitions

Control socket virtual servers typically create files in the runtime
directory.
If this is not kept, FreeRADIUS can't be started in debug mode if those
virtual servers are enabled.

9 months agoCorrect debian systemd service file to grant capabilities
Nick Porter [Fri, 8 Nov 2024 08:11:30 +0000 (08:11 +0000)] 
Correct debian systemd service file to grant capabilities

AmbientCapablilites grants capabilities
CapablilityBoudingSet limits, but does not grant

9 months agounused is used
Alan T. DeKok [Thu, 7 Nov 2024 13:07:16 +0000 (13:07 +0000)] 
unused is used

9 months agodoxygen fixes
Alan T. DeKok [Thu, 7 Nov 2024 12:58:09 +0000 (12:58 +0000)] 
doxygen fixes

9 months agoPacify Coverity (CID #1634478)
Nick Porter [Wed, 6 Nov 2024 07:50:17 +0000 (07:50 +0000)] 
Pacify Coverity (CID #1634478)

9 months agoAdd Samba to the list of identified LDAP directories
Nick Porter [Tue, 5 Nov 2024 16:27:32 +0000 (16:27 +0000)] 
Add Samba to the list of identified LDAP directories

It's behaviour is a mimic of AD, so the same warnings apply

9 months agoSimpler checking for password attributes now all lists are nested
Nick Porter [Tue, 5 Nov 2024 15:50:57 +0000 (15:50 +0000)] 
Simpler checking for password attributes now all lists are nested

Previous switch of search list was transitional when both nested and
flat lists were in place.

9 months agoUpdate warnings to reflect v4 process section names
Nick Porter [Tue, 5 Nov 2024 15:46:25 +0000 (15:46 +0000)] 
Update warnings to reflect v4 process section names

9 months agoTypo
Nick Porter [Tue, 5 Nov 2024 14:55:47 +0000 (14:55 +0000)] 
Typo

9 months agoRemove references to old style proxy in tests
Nick Porter [Tue, 5 Nov 2024 13:20:31 +0000 (13:20 +0000)] 
Remove references to old style proxy in tests

9 months agoNo need for comments about OpenSSL 1.x 5457/head
Nick Porter [Mon, 4 Nov 2024 16:17:13 +0000 (16:17 +0000)] 
No need for comments about OpenSSL 1.x

We only support OpenSSL 3.x now

9 months agoEnable EAP-TTLS tests
Nick Porter [Fri, 1 Nov 2024 15:40:16 +0000 (15:40 +0000)] 
Enable EAP-TTLS tests

9 months agoAdd config for each of the EAP-TTLS tests
Nick Porter [Fri, 1 Nov 2024 15:34:57 +0000 (15:34 +0000)] 
Add config for each of the EAP-TTLS tests

9 months agoDon't check content type if it wasn't set by a received message
Nick Porter [Fri, 1 Nov 2024 14:59:36 +0000 (14:59 +0000)] 
Don't check content type if it wasn't set by a received message

This is seen in EAP-TTLS-MSCHAPv2, where the final client -> server
message is an ACK with zero data length.

9 months agoCopy certificate pairs to verify certificate virtual server
Nick Porter [Fri, 1 Nov 2024 14:50:33 +0000 (14:50 +0000)] 
Copy certificate pairs to verify certificate virtual server

9 months agoRework rlm_eap_ttls to work as module methods
Nick Porter [Fri, 1 Nov 2024 14:49:18 +0000 (14:49 +0000)] 
Rework rlm_eap_ttls to work as module methods

9 months agoIf a subrequest does not set the rcode, use noop
Nick Porter [Fri, 1 Nov 2024 13:58:39 +0000 (13:58 +0000)] 
If a subrequest does not set the rcode, use noop

9 months agoDon't store session state for child requests
Nick Porter [Tue, 5 Nov 2024 08:52:48 +0000 (08:52 +0000)] 
Don't store session state for child requests

This allows the parent request to use fr_state_store_in_parent to store
the child's session state.

9 months agoUpdate EAP methods that use eap_virutal_server()
Nick Porter [Mon, 4 Nov 2024 17:32:37 +0000 (17:32 +0000)] 
Update EAP methods that use eap_virutal_server()

Resolve the virtual server once during instantiation

9 months agoRe-work eap_virtual_server to work async
Nick Porter [Fri, 1 Nov 2024 13:55:53 +0000 (13:55 +0000)] 
Re-work eap_virtual_server to work async

Using the correct method to call a virtual server rather than the
deprecated rad_virtual_server

9 months agoWe expect inner identities to be user@realm format
Nick Porter [Fri, 1 Nov 2024 12:23:51 +0000 (12:23 +0000)] 
We expect inner identities to be user@realm format

9 months agoAdd sample verify certificate section
Nick Porter [Wed, 30 Oct 2024 11:15:49 +0000 (11:15 +0000)] 
Add sample verify certificate section

9 months agoAlign section names with module compile list
Nick Porter [Wed, 30 Oct 2024 10:54:29 +0000 (10:54 +0000)] 
Align section names with module compile list

9 months agoCorrect name of sample virtual server for stateful tls cache
Nick Porter [Wed, 30 Oct 2024 08:25:10 +0000 (08:25 +0000)] 
Correct name of sample virtual server for stateful tls cache

9 months agoCorrect namespace for tls cache virtual server
Nick Porter [Wed, 30 Oct 2024 08:24:28 +0000 (08:24 +0000)] 
Correct namespace for tls cache virtual server

9 months agoUse correct function to trim strings
Nick Porter [Tue, 29 Oct 2024 14:57:40 +0000 (14:57 +0000)] 
Use correct function to trim strings

9 months agoDecode EAP ttls data to nested attributes
Nick Porter [Tue, 29 Oct 2024 14:56:48 +0000 (14:56 +0000)] 
Decode EAP ttls data to nested attributes

9 months agoMatch the RADIUS instance with the whole test name
Nick Porter [Mon, 28 Oct 2024 17:42:54 +0000 (17:42 +0000)] 
Match the RADIUS instance with the whole test name

9 months agoRe-name eap tests
Nick Porter [Mon, 28 Oct 2024 17:42:09 +0000 (17:42 +0000)] 
Re-name eap tests

Some test configs are <method>.conf others are <method>-<inner
method>.conf

We need to distinguish between them correctly for determining the
dependency (e.g. there is an rlm_eap_aka_prime.la, but not an rlm
_eap_ttls_pap.la)

9 months agoRemove un-used auto loaded dict attrs
Nick Porter [Thu, 24 Oct 2024 18:22:55 +0000 (19:22 +0100)] 
Remove un-used auto loaded dict attrs

9 months agoEnsure rlm_sql_mysql logs have an appropraite prefix
Nick Porter [Mon, 4 Nov 2024 10:00:50 +0000 (10:00 +0000)] 
Ensure rlm_sql_mysql logs have an appropraite prefix

Use the connection name if available, the instance name before the
connection is made, and fall back to rlm_sql_mysql for library loading.

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Mon, 4 Nov 2024 09:35:14 +0000 (09:35 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Mon, 4 Nov 2024 09:35:07 +0000 (09:35 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:52 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:49 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:35 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

9 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Mon, 4 Nov 2024 09:34:29 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

9 months agoExplicitly ensure this is \0 terminated
Arran Cudbard-Bell [Mon, 4 Nov 2024 05:22:34 +0000 (07:22 +0200)] 
Explicitly ensure this is \0 terminated

9 months agoSimplify dynamic client generation code
Arran Cudbard-Bell [Sun, 3 Nov 2024 08:03:29 +0000 (10:03 +0200)] 
Simplify dynamic client generation code

9 months agoCheck return code
Arran Cudbard-Bell [Sun, 3 Nov 2024 07:54:28 +0000 (09:54 +0200)] 
Check return code

9 months agoRemove sprintf as macOS (rightly) deprecates its use
Arran Cudbard-Bell [Sun, 3 Nov 2024 07:48:55 +0000 (09:48 +0200)] 
Remove sprintf as macOS (rightly) deprecates its use

9 months agoHomebrew is dropping support for macos-12
Arran Cudbard-Bell [Sun, 3 Nov 2024 07:34:38 +0000 (09:34 +0200)] 
Homebrew is dropping support for macos-12

9 months agoUpdate copyrights on code that was substantially modified during the dictionary fixup...
Arran Cudbard-Bell [Sun, 3 Nov 2024 06:22:45 +0000 (08:22 +0200)] 
Update copyrights on code that was substantially modified during the dictionary fixup work

9 months agoLine numbers are no longer common to all fixup types
Arran Cudbard-Bell [Sun, 3 Nov 2024 06:20:39 +0000 (08:20 +0200)] 
Line numbers are no longer common to all fixup types

9 months agoUse common parsing functions for all references.
Arran Cudbard-Bell [Sun, 3 Nov 2024 05:43:22 +0000 (07:43 +0200)] 
Use common parsing functions for all references.

Add support for '@', so that '..' works as one would expect.

Stop clones adding a pre-cloned version of the attribute to the dictionary.

Allow clones, and enum references to reference foreign attributes, but only when they share the same base protocol.

Use the file and line numbers from refs, instead of from the fixup structs.