]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agotravis issues
Alan T. DeKok [Wed, 18 Apr 2018 11:58:39 +0000 (07:58 -0400)] 
travis issues

8 years agodon't rely on "echo" supporting \n
Alan T. DeKok [Wed, 18 Apr 2018 11:55:15 +0000 (07:55 -0400)] 
don't rely on "echo" supporting \n

8 years agoDon't leak the first unknown attribute in an unknown attribute hierarchy
Arran Cudbard-Bell [Wed, 18 Apr 2018 02:18:51 +0000 (14:18 +1200)] 
Don't leak the first unknown attribute in an unknown attribute hierarchy

8 years agoFix leak in anything that used fr_value_box_from_fmt
Arran Cudbard-Bell [Wed, 18 Apr 2018 00:26:51 +0000 (12:26 +1200)] 
Fix leak in anything that used fr_value_box_from_fmt

8 years agodoxygen
Alan T. DeKok [Tue, 17 Apr 2018 20:19:15 +0000 (16:19 -0400)] 
doxygen

8 years agoremove unused variable
Alan T. DeKok [Tue, 17 Apr 2018 20:17:45 +0000 (16:17 -0400)] 
remove unused variable

8 years agoremove unused variables
Alan T. DeKok [Tue, 17 Apr 2018 20:06:42 +0000 (16:06 -0400)] 
remove unused variables

8 years ago%zd -> %u
Alan T. DeKok [Tue, 17 Apr 2018 20:05:35 +0000 (16:05 -0400)] 
%zd -> %u

8 years agodoxygen
Alan T. DeKok [Tue, 17 Apr 2018 20:05:18 +0000 (16:05 -0400)] 
doxygen

8 years agoalways one thing I missed..
Alan T. DeKok [Tue, 17 Apr 2018 19:45:06 +0000 (15:45 -0400)] 
always one thing I missed..

8 years agoRewrite proto_radius to be not insane.
Alan T. DeKok [Tue, 17 Apr 2018 19:37:42 +0000 (15:37 -0400)] 
Rewrite proto_radius to be not insane.

proto_radius_udp now ONLY does UDP reads/writes (and open/close)
it does not track packets, do dedup, etc.

All of the packet trackign has been moved to io.c, in proto_radius.
That function tracks pending packets, does dedup, etc.

The IO is bounced through io.c, which does the heavy lifting.
Then, if it actually needs to read/write packets to the network,
it calls the underlying app_io.

This means that RADIUS over TCP should be not much larger than
RADIUS over UDP.  There will need to be some additional work to
get accepted sockets in, but the base work for connections exists.

As a plus, you can now define a dynamic client and mark it as
using connected sockets.  Which means that NAT gateways can now
exist as dynamic clients, AND they can have connected sockets
behind them.  i.e. each connection through a NAT gateway can
have a different shared secret.

8 years agono longer look at client->network.
Alan T. DeKok [Tue, 17 Apr 2018 19:30:25 +0000 (15:30 -0400)] 
no longer look at client->network.

It's only used for proto_radius, and should never have been here.

8 years agouse IP address as part of client name for debugging
Alan T. DeKok [Tue, 17 Apr 2018 19:30:00 +0000 (15:30 -0400)] 
use IP address as part of client name for debugging

8 years agoundefined fields aren't assertions
Alan T. DeKok [Tue, 17 Apr 2018 19:28:22 +0000 (15:28 -0400)] 
undefined fields aren't assertions

8 years agocopy the memory for the new entry
Alan T. DeKok [Tue, 17 Apr 2018 19:27:50 +0000 (15:27 -0400)] 
copy the memory for the new entry

8 years agoset packet event list AFTER inserting the FD into the event loop
Alan T. DeKok [Tue, 17 Apr 2018 17:49:11 +0000 (13:49 -0400)] 
set packet event list AFTER inserting the FD into the event loop

so that the module can pause (or do whatever) to the FD as necessary

8 years agotell dynamic client code if the socket is connected
Alan T. DeKok [Tue, 17 Apr 2018 17:11:04 +0000 (13:11 -0400)] 
tell dynamic client code if the socket is connected

8 years agonotes on low priority of detail file reading
Alan T. DeKok [Mon, 16 Apr 2018 19:53:08 +0000 (15:53 -0400)] 
notes on low priority of detail file reading

8 years agoconstify lookup functions
Alan T. DeKok [Sun, 15 Apr 2018 21:40:54 +0000 (17:40 -0400)] 
constify lookup functions

8 years agodon't pass a "free" function
Alan T. DeKok [Fri, 13 Apr 2018 19:55:13 +0000 (15:55 -0400)] 
don't pass a "free" function

the stats info is parented from the rbtree, so using a free
function results in a double free.

8 years agoadd provisions for private APIs
Alan T. DeKok [Fri, 13 Apr 2018 17:37:50 +0000 (13:37 -0400)] 
add provisions for private APIs

8 years agoadd connection tracking to clients.
Alan T. DeKok [Fri, 13 Apr 2018 13:08:29 +0000 (09:08 -0400)] 
add connection tracking to clients.

8 years agomagic for network write
Alan T. DeKok [Thu, 12 Apr 2018 14:37:41 +0000 (10:37 -0400)] 
magic for network write

8 years agopass packet_ct to NAK routine
Alan T. DeKok [Thu, 12 Apr 2018 14:10:40 +0000 (10:10 -0400)] 
pass packet_ct to NAK routine

8 years agoFixup odd output from format.pl
Arran Cudbard-Bell [Mon, 16 Apr 2018 11:20:08 +0000 (23:20 +1200)] 
Fixup odd output from format.pl

Probably something about fixing up the DHCPv4 dictionaries, will look when we have proper protocol dictionaries.

8 years agoExit cleanly from unit_test_attribute to avoid pages and pages of memory leak output
Arran Cudbard-Bell [Mon, 16 Apr 2018 11:17:25 +0000 (23:17 +1200)] 
Exit cleanly from unit_test_attribute to avoid pages and pages of memory leak output

8 years agoUse MEM to check allocation
Arran Cudbard-Bell [Mon, 16 Apr 2018 08:12:28 +0000 (20:12 +1200)] 
Use MEM to check allocation

8 years agoAdd IEC dictionary to help out with https://stackoverflow.com/questions/47052503...
Arran Cudbard-Bell [Mon, 16 Apr 2018 08:09:22 +0000 (20:09 +1200)] 
Add IEC dictionary to help out with https://stackoverflow.com/questions/47052503/radius-and-iec-62351?rq=1

8 years agoFormat dictionary files
Arran Cudbard-Bell [Mon, 16 Apr 2018 08:07:03 +0000 (20:07 +1200)] 
Format dictionary files

8 years agoAutoload eap.c attributes
Arran Cudbard-Bell [Fri, 13 Apr 2018 06:41:02 +0000 (12:41 +0600)] 
Autoload eap.c attributes

8 years agos/network_id/network_name/ to be consistent with RFC 5448
Arran Cudbard-Bell [Fri, 13 Apr 2018 05:13:28 +0000 (11:13 +0600)] 
s/network_id/network_name/ to be consistent with RFC 5448

8 years ago...and a few more
Arran Cudbard-Bell [Thu, 12 Apr 2018 06:49:02 +0000 (12:49 +0600)] 
...and a few more

8 years agoOnce more pragma fixup
Arran Cudbard-Bell [Thu, 12 Apr 2018 06:37:59 +0000 (12:37 +0600)] 
Once more pragma fixup

8 years agoMore sign fixes
Arran Cudbard-Bell [Thu, 12 Apr 2018 06:12:33 +0000 (12:12 +0600)] 
More sign fixes

8 years agoFixupup rlm_mschap Auth-Type enumv and the last few pair_make calls
Arran Cudbard-Bell [Thu, 12 Apr 2018 06:10:54 +0000 (12:10 +0600)] 
Fixupup rlm_mschap Auth-Type enumv and the last few pair_make calls

8 years agoTypo
Arran Cudbard-Bell [Thu, 12 Apr 2018 05:40:00 +0000 (11:40 +0600)] 
Typo

8 years agoFix sign
Arran Cudbard-Bell [Thu, 12 Apr 2018 05:37:43 +0000 (11:37 +0600)] 
Fix sign

8 years agoSwitch to #pragma once
Arran Cudbard-Bell [Thu, 12 Apr 2018 05:31:35 +0000 (11:31 +0600)] 
Switch to #pragma once

8 years agoAutoload rlm_mschap attributes
Arran Cudbard-Bell [Thu, 12 Apr 2018 04:20:35 +0000 (10:20 +0600)] 
Autoload rlm_mschap attributes

8 years agoFormatting
Arran Cudbard-Bell [Thu, 12 Apr 2018 02:51:16 +0000 (08:51 +0600)] 
Formatting

8 years agoAutoload rlm_logintime attrs
Arran Cudbard-Bell [Thu, 12 Apr 2018 02:33:19 +0000 (08:33 +0600)] 
Autoload rlm_logintime attrs

8 years agoUse same logic as logintime
Arran Cudbard-Bell [Thu, 12 Apr 2018 02:32:53 +0000 (08:32 +0600)] 
Use same logic as logintime

8 years agoAutoload rlm_ldap attributes
Arran Cudbard-Bell [Thu, 12 Apr 2018 02:12:46 +0000 (08:12 +0600)] 
Autoload rlm_ldap attributes

8 years agorlm_unix: remove pair_make_config
Matthew Newton [Wed, 11 Apr 2018 15:03:16 +0000 (16:03 +0100)] 
rlm_unix: remove pair_make_config

8 years agorlm_winbind: remove pair_make_config
Matthew Newton [Wed, 11 Apr 2018 14:53:38 +0000 (15:53 +0100)] 
rlm_winbind: remove pair_make_config

8 years agomore rlm_yubikey dict updates, remove pair_make
Matthew Newton [Wed, 11 Apr 2018 14:49:08 +0000 (15:49 +0100)] 
more rlm_yubikey dict updates, remove pair_make

8 years agoif replicating, always return OK
Alan T. DeKok [Wed, 11 Apr 2018 14:54:39 +0000 (10:54 -0400)] 
if replicating, always return OK

8 years agoRedundant condition
Arran Cudbard-Bell [Wed, 11 Apr 2018 10:10:21 +0000 (16:10 +0600)] 
Redundant condition

8 years agoAutoload rlm_files attributes
Arran Cudbard-Bell [Wed, 11 Apr 2018 10:09:15 +0000 (16:09 +0600)] 
Autoload rlm_files attributes

8 years agoAutoload rlm_expiration attributes
Arran Cudbard-Bell [Wed, 11 Apr 2018 10:03:32 +0000 (16:03 +0600)] 
Autoload rlm_expiration attributes

8 years agoAcct-Unique-Session-Id is internal
Matthew Newton [Wed, 11 Apr 2018 09:22:12 +0000 (10:22 +0100)] 
Acct-Unique-Session-Id is internal

8 years agoUse %pV when printing dates
Arran Cudbard-Bell [Wed, 11 Apr 2018 08:42:59 +0000 (14:42 +0600)] 
Use %pV when printing dates

8 years agoCorrect type
Arran Cudbard-Bell [Wed, 11 Apr 2018 08:41:10 +0000 (14:41 +0600)] 
Correct type

8 years agoAutoload rlm_example attributes
Arran Cudbard-Bell [Wed, 11 Apr 2018 08:34:25 +0000 (14:34 +0600)] 
Autoload rlm_example attributes

8 years agoAutoload rlm_eap attributes
Arran Cudbard-Bell [Wed, 11 Apr 2018 08:19:51 +0000 (14:19 +0600)] 
Autoload rlm_eap attributes

8 years agoLoad CA file into the RSA chain too (else we get validation errors)
Arran Cudbard-Bell [Wed, 11 Apr 2018 08:19:33 +0000 (14:19 +0600)] 
Load CA file into the RSA chain too (else we get validation errors)

8 years agoUse common field names
Arran Cudbard-Bell [Wed, 11 Apr 2018 08:19:15 +0000 (14:19 +0600)] 
Use common field names

8 years agoRemove pre-proxy from rlm_chap. This is now handled by rlm_radius.
Arran Cudbard-Bell [Wed, 11 Apr 2018 03:56:52 +0000 (09:56 +0600)] 
Remove pre-proxy from rlm_chap.  This is now handled by rlm_radius.

8 years agoSASL: Let configure SASL_SECPROPS per LDAP instance
Isaac Boukris [Tue, 10 Apr 2018 15:36:15 +0000 (18:36 +0300)] 
SASL: Let configure SASL_SECPROPS per LDAP instance

Active-Directory does not allow to use GSS-API signing / sealing when
over TLS (to avoid double encryption?).
While SASL_SECPROPS (or maxssf) coul be set globally via system's
ldap.conf, it is not enough if you want one instead to work with
TLS and the other without TLS but with signing and sealing of GSS-API.

Add a directive sasl_secprops, to allow setting it per instance.

8 years agoAutoload rlm_soh attributes
Matthew Newton [Wed, 11 Apr 2018 00:49:17 +0000 (01:49 +0100)] 
Autoload rlm_soh attributes

8 years agoAutoload rlm_sql attributes
Matthew Newton [Wed, 11 Apr 2018 00:29:01 +0000 (01:29 +0100)] 
Autoload rlm_sql attributes

8 years agoAutoload rlm_sqlcounter attributes
Matthew Newton [Tue, 10 Apr 2018 23:51:17 +0000 (00:51 +0100)] 
Autoload rlm_sqlcounter attributes

8 years agoAutoload rlm_sqlhpwippool attributes
Matthew Newton [Tue, 10 Apr 2018 23:41:03 +0000 (00:41 +0100)] 
Autoload rlm_sqlhpwippool attributes

8 years agoAutoload rlm_sqlippool attributes
Matthew Newton [Tue, 10 Apr 2018 23:08:07 +0000 (00:08 +0100)] 
Autoload rlm_sqlippool attributes

8 years agodocumentation helps
Alan T. DeKok [Mon, 9 Apr 2018 17:51:33 +0000 (13:51 -0400)] 
documentation helps

8 years agoadd rules to build only libs / programs in a subdirectory
Alan T. DeKok [Sat, 7 Apr 2018 13:49:03 +0000 (09:49 -0400)] 
add rules to build only libs / programs in a subdirectory

8 years agoAutoload rlm_test attributes
Matthew Newton [Mon, 9 Apr 2018 20:12:12 +0000 (21:12 +0100)] 
Autoload rlm_test attributes

8 years agoAutoload rlm_unix attributes
Matthew Newton [Mon, 9 Apr 2018 18:46:01 +0000 (19:46 +0100)] 
Autoload rlm_unix attributes

8 years agoAutoload rlm_winbind attributes
Matthew Newton [Mon, 9 Apr 2018 17:39:05 +0000 (18:39 +0100)] 
Autoload rlm_winbind attributes

8 years agoAutoload rlm_yubikey attributes
Matthew Newton [Mon, 9 Apr 2018 17:21:21 +0000 (18:21 +0100)] 
Autoload rlm_yubikey attributes

8 years agoBump to clang/llvm 6 (same as homebrew)
Arran Cudbard-Bell [Tue, 10 Apr 2018 06:16:00 +0000 (12:16 +0600)] 
Bump to clang/llvm 6 (same as homebrew)

8 years agoSet WITH_VERIFY_PTR during clang scan so that NULL code paths result in exit
Arran Cudbard-Bell [Tue, 10 Apr 2018 05:50:17 +0000 (11:50 +0600)] 
Set WITH_VERIFY_PTR during clang scan so that NULL code paths result in exit

8 years agos/VERIFY_DA/DA_VERIFY/
Arran Cudbard-Bell [Tue, 10 Apr 2018 05:46:08 +0000 (11:46 +0600)] 
s/VERIFY_DA/DA_VERIFY/

8 years agoFix scoping
Arran Cudbard-Bell [Tue, 10 Apr 2018 05:45:50 +0000 (11:45 +0600)] 
Fix scoping

8 years agofd not used so no need to set to -1
Arran Cudbard-Bell [Tue, 10 Apr 2018 05:03:27 +0000 (11:03 +0600)] 
fd not used so no need to set to -1

8 years agoAdd fr_pair_add_by_da
Arran Cudbard-Bell [Tue, 10 Apr 2018 04:40:39 +0000 (10:40 +0600)] 
Add fr_pair_add_by_da

8 years agoif ((typo) {}
Matthew Newton [Mon, 9 Apr 2018 13:49:27 +0000 (14:49 +0100)] 
if ((typo) {}

8 years agoIgnore missing prototype warning for __lsan_is_turned_off
Arran Cudbard-Bell [Mon, 9 Apr 2018 13:28:58 +0000 (19:28 +0600)] 
Ignore missing prototype warning for __lsan_is_turned_off

8 years agoFormatting
Arran Cudbard-Bell [Mon, 9 Apr 2018 13:25:14 +0000 (19:25 +0600)] 
Formatting

8 years agoLeave events in the rbtree if they were not removed from kevent
Arran Cudbard-Bell [Mon, 9 Apr 2018 13:24:39 +0000 (19:24 +0600)] 
Leave events in the rbtree if they were not removed from kevent

Distinguish between deferred frees and kevent errors in fr_event_fd_delete.

8 years agoMerge pull request #2210 from nchaigne/4.0.x-201804-dhcpv4-suboption-test
Alan DeKok [Mon, 9 Apr 2018 12:04:01 +0000 (08:04 -0400)] 
Merge pull request #2210 from nchaigne/4.0.x-201804-dhcpv4-suboption-test

Test DHCP encoding of two sub-options which don't fit in a single option

8 years agoTest DHCP encoding of two sub-options which don't fit in a single option 2210/head
nchaigne [Mon, 9 Apr 2018 09:54:34 +0000 (11:54 +0200)] 
Test DHCP encoding of two sub-options which don't fit in a single option

Added unit test following https://github.com/FreeRADIUS/freeradius-server/pull/2209

8 years agoMerge pull request #2209 from nchaigne/4.0.x-201804-dhcp-encode-suboption
Alan DeKok [Fri, 6 Apr 2018 18:19:50 +0000 (14:19 -0400)] 
Merge pull request #2209 from nchaigne/4.0.x-201804-dhcp-encode-suboption

Fix to DHCP encoding error when sub-option doesn't fit

8 years agoFix to DHCP encoding error when sub-option doesn't fit 2209/head
nchaigne [Fri, 6 Apr 2018 18:14:25 +0000 (20:14 +0200)] 
Fix to DHCP encoding error when sub-option doesn't fit

Ask FreeRADIUS to encode several sub-options too long to fit in one option.
Then the first option is not properly encoded. There are two octets leftover (the beginning of the second sub-option).

Here is a fix.

8 years agoadd CC_HINT nonnull
Alan T. DeKok [Fri, 6 Apr 2018 14:42:31 +0000 (10:42 -0400)] 
add CC_HINT nonnull

and remove "inline" which does nothing

8 years agoda->parent may be NULL
Alan T. DeKok [Fri, 6 Apr 2018 14:42:15 +0000 (10:42 -0400)] 
da->parent may be NULL

8 years agocheck for duplicate NAK clients
Alan T. DeKok [Thu, 5 Apr 2018 16:54:57 +0000 (12:54 -0400)] 
check for duplicate NAK clients

8 years agoIf not running under valgrind AND not running under LSAN dlclose()
Arran Cudbard-Bell [Thu, 5 Apr 2018 14:38:05 +0000 (15:38 +0100)] 
If not running under valgrind AND not running under LSAN dlclose()

8 years agoAdd features for running under valgrind, lsan and gdb/lldb
Arran Cudbard-Bell [Thu, 5 Apr 2018 14:29:43 +0000 (15:29 +0100)] 
Add features for running under valgrind, lsan and gdb/lldb

8 years agoDon't dlclose if we're running under LSAN
Arran Cudbard-Bell [Thu, 5 Apr 2018 13:59:59 +0000 (14:59 +0100)] 
Don't dlclose if we're running under LSAN

8 years agoCache fr_get_lsan_state results
Arran Cudbard-Bell [Thu, 5 Apr 2018 13:59:42 +0000 (14:59 +0100)] 
Cache fr_get_lsan_state results

8 years agoAt function to determine if we're running under LSAN
Arran Cudbard-Bell [Thu, 5 Apr 2018 13:50:41 +0000 (14:50 +0100)] 
At function to determine if we're running under LSAN

8 years agoDoxygen
Arran Cudbard-Bell [Thu, 5 Apr 2018 13:50:23 +0000 (14:50 +0100)] 
Doxygen

8 years agoDisable stupidly pedantic warnings
Arran Cudbard-Bell [Thu, 5 Apr 2018 13:49:51 +0000 (14:49 +0100)] 
Disable stupidly pedantic warnings

8 years agofix assertion
Alan T. DeKok [Thu, 5 Apr 2018 13:48:33 +0000 (09:48 -0400)] 
fix assertion

8 years agoRevert "remove unnecessary check. CID #1433563"
Arran Cudbard-Bell [Thu, 5 Apr 2018 12:43:27 +0000 (13:43 +0100)] 
Revert "remove unnecessary check.  CID #1433563"

Check is necessary.

8 years agoRevert "sizeof(struct) not sizeof(struct *). CID #1433557"
Alan T. DeKok [Thu, 5 Apr 2018 12:48:14 +0000 (08:48 -0400)] 
Revert "sizeof(struct) not sizeof(struct *).  CID #1433557"

This reverts commit 24326dff862bab6561b43bc058792780d1a335c2.

they are intended to be pointers

8 years agoRevert "sizeof(struct) not sizeof(struct *). CID #1433559"
Alan T. DeKok [Thu, 5 Apr 2018 12:47:57 +0000 (08:47 -0400)] 
Revert "sizeof(struct) not sizeof(struct *).  CID #1433559"

This reverts commit 57b3d362f4463195ccb53b1eaace37ab9bd7e528.

they are intended to be pointers

8 years agore-allow cast from uint64 to ethernet. CID #1409865
Alan T. DeKok [Thu, 5 Apr 2018 12:44:30 +0000 (08:44 -0400)] 
re-allow cast from uint64 to ethernet. CID #1409865

8 years agoUnset ASAN_OPTIONS and LSAN_OPTIONS so they're not passed to scripts called from...
Arran Cudbard-Bell [Thu, 5 Apr 2018 12:39:34 +0000 (13:39 +0100)] 
Unset ASAN_OPTIONS and LSAN_OPTIONS so they're not passed to scripts called from configure

Leaving them enabled messes with some of the tests