]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agodriver_inst can't be NULL here. CID #1414433
Alan T. DeKok [Thu, 19 Oct 2017 19:53:59 +0000 (15:53 -0400)] 
driver_inst can't be NULL here.  CID #1414433

8 years agoclose socket on error. CID #1419878
Alan T. DeKok [Thu, 19 Oct 2017 19:52:11 +0000 (15:52 -0400)] 
close socket on error.  CID #1419878

8 years agowe don't care if write() fails here. CID #1414420
Alan T. DeKok [Thu, 19 Oct 2017 19:45:04 +0000 (15:45 -0400)] 
we don't care if write() fails here.  CID #1414420

8 years agouse correct number of arguments. CID #1419884
Alan T. DeKok [Thu, 19 Oct 2017 19:43:44 +0000 (15:43 -0400)] 
use correct number of arguments.  CID #1419884

8 years agocheck both workers... CID #1419881
Alan T. DeKok [Thu, 19 Oct 2017 19:41:51 +0000 (15:41 -0400)] 
check both workers... CID #1419881

8 years agohandle dup() failure. CID #1419880
Alan T. DeKok [Thu, 19 Oct 2017 19:41:07 +0000 (15:41 -0400)] 
handle dup() failure.  CID #1419880

8 years agoapp_io must be set. CID #1419879
Alan T. DeKok [Thu, 19 Oct 2017 19:37:48 +0000 (15:37 -0400)] 
app_io must be set.  CID #1419879

8 years agofix args to printf. CID #1419885
Alan T. DeKok [Thu, 19 Oct 2017 19:36:14 +0000 (15:36 -0400)] 
fix args to printf.  CID #1419885

8 years agocheck correct values. CID #1419876
Alan T. DeKok [Thu, 19 Oct 2017 19:34:56 +0000 (15:34 -0400)] 
check correct values.  CID #1419876

This might explain why some events are odd..

8 years agochannel recv_time cannot be NULL. CID #1419871
Alan T. DeKok [Thu, 19 Oct 2017 19:33:43 +0000 (15:33 -0400)] 
channel recv_time cannot be NULL.  CID #1419871

8 years agofix assertion. CID #1419870
Alan T. DeKok [Thu, 19 Oct 2017 19:29:16 +0000 (15:29 -0400)] 
fix assertion. CID #1419870

8 years agoset time to now. CID #1419868
Alan T. DeKok [Thu, 19 Oct 2017 19:28:24 +0000 (15:28 -0400)] 
set time to now.  CID #1419868

8 years agocheck before dreference. CID #1414436
Alan T. DeKok [Thu, 19 Oct 2017 19:26:57 +0000 (15:26 -0400)] 
check before dreference.  CID #1414436

8 years agofr_scoket_client_tcp() can fail. CID #1414430
Alan T. DeKok [Thu, 19 Oct 2017 19:25:36 +0000 (15:25 -0400)] 
fr_scoket_client_tcp() can fail.  CID #1414430

8 years agodriver_inst is already checked, and can't be NULL
Alan T. DeKok [Thu, 19 Oct 2017 19:24:01 +0000 (15:24 -0400)] 
driver_inst is already checked, and can't be NULL

8 years agodelete lock after using it. CID #141442
Alan T. DeKok [Thu, 19 Oct 2017 19:22:54 +0000 (15:22 -0400)] 
delete lock after using it.  CID #141442

8 years agouse success / fail instead of empty sections
Alan T. DeKok [Thu, 19 Oct 2017 19:19:43 +0000 (15:19 -0400)] 
use success / fail instead of empty sections

8 years agodocument new detail file reader
Alan T. DeKok [Thu, 19 Oct 2017 19:19:30 +0000 (15:19 -0400)] 
document new detail file reader

8 years agoadd "send fail"
Alan T. DeKok [Thu, 19 Oct 2017 19:05:38 +0000 (15:05 -0400)] 
add "send fail"

8 years agonotes on retransmissions for failure
Alan T. DeKok [Thu, 19 Oct 2017 19:01:21 +0000 (15:01 -0400)] 
notes on retransmissions for failure

8 years agoclean up and double-check
Alan T. DeKok [Thu, 19 Oct 2017 18:59:00 +0000 (14:59 -0400)] 
clean up and double-check

if there's a good reply, run send { ... }

if there's a bad reply, run send Do-Not-Respond { ... }

8 years agoadd synonym
Alan T. DeKok [Thu, 19 Oct 2017 18:58:48 +0000 (14:58 -0400)] 
add synonym

8 years agoremove notes about v2
Alan T. DeKok [Thu, 19 Oct 2017 18:38:14 +0000 (14:38 -0400)] 
remove notes about v2

8 years agoifdef out variables for assertions
Alan T. DeKok [Thu, 19 Oct 2017 18:29:26 +0000 (14:29 -0400)] 
ifdef out variables for assertions

8 years agoset the backlog from the parent who has it
Alan T. DeKok [Thu, 19 Oct 2017 18:16:52 +0000 (14:16 -0400)] 
set the backlog from the parent who has it

8 years agozero out memory so the event handler doesn't get excited
Alan T. DeKok [Thu, 19 Oct 2017 18:13:26 +0000 (14:13 -0400)] 
zero out memory so the event handler doesn't get excited

over garbage memory

8 years agomore sanity checks in unlang_resumable()
Alan T. DeKok [Thu, 19 Oct 2017 17:56:56 +0000 (13:56 -0400)] 
more sanity checks in unlang_resumable()

8 years agobacklog can be NULL if the request wasn't detached
Alan T. DeKok [Thu, 19 Oct 2017 17:56:30 +0000 (13:56 -0400)] 
backlog can be NULL if the request wasn't detached

8 years agodetach before freeing child
Alan T. DeKok [Thu, 19 Oct 2017 17:55:06 +0000 (13:55 -0400)] 
detach before freeing child

8 years agochild requests are never in the runnable queue
Alan T. DeKok [Thu, 19 Oct 2017 17:43:35 +0000 (13:43 -0400)] 
child requests are never in the runnable queue

8 years agoclean up unlang_resumable()
Alan T. DeKok [Thu, 19 Oct 2017 17:40:06 +0000 (13:40 -0400)] 
clean up unlang_resumable()

8 years agoone more assertion
Alan T. DeKok [Thu, 19 Oct 2017 15:53:47 +0000 (11:53 -0400)] 
one more assertion

8 years agocheck for thing before freeing it
Alan T. DeKok [Thu, 19 Oct 2017 15:37:44 +0000 (11:37 -0400)] 
check for thing before freeing it

8 years agomore assertions and checks
Alan T. DeKok [Thu, 19 Oct 2017 15:24:31 +0000 (11:24 -0400)] 
more assertions and checks

8 years agoassert that the request isn't in the runnable queue
Alan T. DeKok [Thu, 19 Oct 2017 15:22:40 +0000 (11:22 -0400)] 
assert that the request isn't in the runnable queue

8 years agomore assertions
Alan T. DeKok [Thu, 19 Oct 2017 15:00:30 +0000 (11:00 -0400)] 
more assertions

8 years agoremove "runnable" requests from the runnable queue
Alan T. DeKok [Thu, 19 Oct 2017 14:57:24 +0000 (10:57 -0400)] 
remove "runnable" requests from the runnable queue

8 years agoset default for "track" and "poll_interval"
Alan T. DeKok [Thu, 19 Oct 2017 14:51:41 +0000 (10:51 -0400)] 
set default for "track" and "poll_interval"

8 years agoclarify how thngs work
Alan T. DeKok [Thu, 19 Oct 2017 14:33:12 +0000 (10:33 -0400)] 
clarify how thngs work

8 years agochild created detachable is always detachable
Alan T. DeKok [Thu, 19 Oct 2017 14:29:35 +0000 (10:29 -0400)] 
child created detachable is always detachable

8 years agoclean up children immediately on "return"
Alan T. DeKok [Thu, 19 Oct 2017 13:30:07 +0000 (09:30 -0400)] 
clean up children immediately on "return"

8 years agoadd configurable poll_interval
Alan T. DeKok [Thu, 19 Oct 2017 12:36:45 +0000 (08:36 -0400)] 
add configurable poll_interval

8 years agocast usec to int, too
Alan T. DeKok [Wed, 18 Oct 2017 19:15:06 +0000 (15:15 -0400)] 
cast usec to int, too

8 years agouse state transition function for u, too
Alan T. DeKok [Wed, 18 Oct 2017 19:13:50 +0000 (15:13 -0400)] 
use state transition function for u, too

8 years agodo polling for detail files
Alan T. DeKok [Wed, 18 Oct 2017 18:08:53 +0000 (14:08 -0400)] 
do polling for detail files

8 years agoassert that packets which have replies were actually sent
Alan T. DeKok [Wed, 18 Oct 2017 18:08:21 +0000 (14:08 -0400)] 
assert that packets which have replies were actually sent

i.e. once we have a reply, the packet is no longer sent,
it's done.

8 years agoset work_io_instance=NULL in file, not worker
Alan T. DeKok [Tue, 17 Oct 2017 20:48:50 +0000 (16:48 -0400)] 
set work_io_instance=NULL in file, not worker

because many things can cause the file to be deleted...

8 years agomore cleanups on error, and deletion of detail.work
Alan T. DeKok [Tue, 17 Oct 2017 20:16:02 +0000 (16:16 -0400)] 
more cleanups on error, and deletion of detail.work

8 years agoalloc a worker and run it
Alan T. DeKok [Tue, 17 Oct 2017 20:00:20 +0000 (16:00 -0400)] 
alloc a worker and run it

8 years agoadd decode & write
Alan T. DeKok [Tue, 17 Oct 2017 19:58:57 +0000 (15:58 -0400)] 
add decode & write

which bounces through to proto_detail_work, which does the
actual work.

We should probably have a way to pass the fr_listen_t to proto_detail,
so it can use it's app_io, instead of the one in the proto_detail
instance

8 years agofree the worker if we're closing the FD
Alan T. DeKok [Tue, 17 Oct 2017 19:57:52 +0000 (15:57 -0400)] 
free the worker if we're closing the FD

and if the flag tells us to

8 years agominor cleanups
Alan T. DeKok [Tue, 17 Oct 2017 19:41:09 +0000 (15:41 -0400)] 
minor cleanups

add "self" for linking issues.
parent is not "const"
move fr_schedule_t to proto_detail_t, not proto_detail_work_t

and initialize the entries

8 years agoclean up to allow proto_detail_file to call us
Alan T. DeKok [Tue, 17 Oct 2017 19:40:46 +0000 (15:40 -0400)] 
clean up to allow proto_detail_file to call us

8 years agominor cleanups
Alan T. DeKok [Tue, 17 Oct 2017 18:18:37 +0000 (14:18 -0400)] 
minor cleanups

filename.work is no longer mandatory.  If it isn't defined,
we'll just create it.

If detail.work does exist, watch for it's deletion

8 years agomore than one NOTE can be returned
Alan T. DeKok [Tue, 17 Oct 2017 18:18:22 +0000 (14:18 -0400)] 
more than one NOTE can be returned

8 years agoopen RDWR if tracking, else RDONLY
Alan T. DeKok [Tue, 17 Oct 2017 17:48:37 +0000 (13:48 -0400)] 
open RDWR if tracking, else RDONLY

8 years agoclear out el->events[] for an FD when the event is deleted
Alan T. DeKok [Tue, 17 Oct 2017 17:32:07 +0000 (13:32 -0400)] 
clear out el->events[] for an FD when the event is deleted

8 years agouse -, not a-b
Alan T. DeKok [Tue, 17 Oct 2017 14:49:10 +0000 (10:49 -0400)] 
use -, not a-b

8 years agodon't use t->pending, just rely on heap size
Alan T. DeKok [Tue, 17 Oct 2017 13:12:51 +0000 (09:12 -0400)] 
don't use t->pending, just rely on heap size

if there are two things showing the same information, it's possible
for them to get out of sync.  So... one way to rule them all.

8 years agoset t->pending only if there's pending packets
Alan T. DeKok [Tue, 17 Oct 2017 13:08:28 +0000 (09:08 -0400)] 
set t->pending only if there's pending packets

8 years agohandle 'close' as a separate function
Alan T. DeKok [Mon, 16 Oct 2017 19:31:00 +0000 (15:31 -0400)] 
handle 'close' as a separate function

so we can catch it, and inform our parent instance that it
needs to rescan the directory

8 years agoinstance isn't 'const' in close
Alan T. DeKok [Mon, 16 Oct 2017 19:30:40 +0000 (15:30 -0400)] 
instance isn't 'const' in close

8 years agoauto-create "work" configuration
Alan T. DeKok [Mon, 16 Oct 2017 19:18:27 +0000 (15:18 -0400)] 
auto-create "work" configuration

to simplify the users life

8 years agonote recent changes
Alan T. DeKok [Mon, 16 Oct 2017 19:18:16 +0000 (15:18 -0400)] 
note recent changes

8 years ago/ may occur in dictionary names, too
Alan T. DeKok [Mon, 16 Oct 2017 18:55:24 +0000 (14:55 -0400)] 
/ may occur in dictionary names, too

so we can't put it into the comments in the file

8 years agocast to long double
Alan T. DeKok [Mon, 16 Oct 2017 18:53:39 +0000 (14:53 -0400)] 
cast to long double

8 years ago%f is double
Alan T. DeKok [Mon, 16 Oct 2017 18:53:06 +0000 (14:53 -0400)] 
%f is double

8 years agocast to double
Alan T. DeKok [Mon, 16 Oct 2017 18:52:08 +0000 (14:52 -0400)] 
cast to double

8 years agosimplify the translation rules
Alan T. DeKok [Mon, 16 Oct 2017 18:44:38 +0000 (14:44 -0400)] 
simplify the translation rules

8 years agoport relay fixes from 3.0
Alan T. DeKok [Mon, 16 Oct 2017 18:30:07 +0000 (14:30 -0400)] 
port relay fixes from 3.0

8 years agosort by FD first, not filter.
Alan T. DeKok [Fri, 13 Oct 2017 17:17:03 +0000 (13:17 -0400)] 
sort by FD first, not filter.

there are really only 2 filters used, but multiple FDs

8 years agodon't free children in parallel state destructor
Alan T. DeKok [Fri, 13 Oct 2017 13:58:56 +0000 (09:58 -0400)] 
don't free children in parallel state destructor

they're already either parented from the request, or linked
to the request via request_data_add.  And will therefore be
freed as necessary.

Plus, if they're detached, we definitely DON'T want to free them
when the parallel section exits

8 years agouse correct enum value
Alan T. DeKok [Fri, 13 Oct 2017 13:53:13 +0000 (09:53 -0400)] 
use correct enum value

8 years agoparallel clones by default
Alan T. DeKok [Fri, 13 Oct 2017 13:49:58 +0000 (09:49 -0400)] 
parallel clones by default

but can be empty via 'parallel empty'

which likely needs a better name

8 years agofree children on DONE signal
Alan T. DeKok [Fri, 13 Oct 2017 13:21:09 +0000 (09:21 -0400)] 
free children on DONE signal

8 years agodelete the reply after receiving it
Alan T. DeKok [Fri, 13 Oct 2017 11:21:45 +0000 (07:21 -0400)] 
delete the reply after receiving it

8 years agoconnection may be NULL
Alan T. DeKok [Fri, 13 Oct 2017 02:12:13 +0000 (22:12 -0400)] 
connection may be NULL

8 years agoremove unused variable
Alan T. DeKok [Fri, 13 Oct 2017 01:40:25 +0000 (21:40 -0400)] 
remove unused variable

8 years agodereference correct variable
Alan T. DeKok [Fri, 13 Oct 2017 01:39:46 +0000 (21:39 -0400)] 
dereference correct variable

8 years agomake ourselves active if we read and there's pending packets
Alan T. DeKok [Thu, 12 Oct 2017 19:15:18 +0000 (15:15 -0400)] 
make ourselves active if we read and there's pending packets

this is likely imperfect, but it's not entirely wrong

8 years agodouble-check idle handling
Alan T. DeKok [Thu, 12 Oct 2017 19:04:12 +0000 (15:04 -0400)] 
double-check idle handling

8 years agomore cleanups and sanity checks
Alan T. DeKok [Thu, 12 Oct 2017 18:57:34 +0000 (14:57 -0400)] 
more cleanups and sanity checks

8 years agogo over status-server retransmission checks
Alan T. DeKok [Thu, 12 Oct 2017 18:30:41 +0000 (14:30 -0400)] 
go over status-server retransmission checks

8 years agogo over zombie timeout checks
Alan T. DeKok [Thu, 12 Oct 2017 18:12:36 +0000 (14:12 -0400)] 
go over zombie timeout checks

8 years agoand more cleanups
Alan T. DeKok [Wed, 11 Oct 2017 20:10:04 +0000 (16:10 -0400)] 
and more cleanups

the basics work.  But (again) the corner cases need to be checked.

8 years agomore cleanups
Alan T. DeKok [Wed, 11 Oct 2017 19:39:15 +0000 (15:39 -0400)] 
more cleanups

8 years agostart of cleanup and change to better state transitions
Alan T. DeKok [Wed, 11 Oct 2017 19:16:40 +0000 (15:16 -0400)] 
start of cleanup and change to better state transitions

8 years agoMerge pull request #2091 from bmork/unisphere-vsas-for-v4.0.x
Alan DeKok [Wed, 11 Oct 2017 17:58:50 +0000 (13:58 -0400)] 
Merge pull request #2091 from bmork/unisphere-vsas-for-v4.0.x

add new Juniper/Unisphere/ERX VSAs

8 years agoremove active_requests
Alan T. DeKok [Wed, 11 Oct 2017 16:08:25 +0000 (12:08 -0400)] 
remove active_requests

we can calculate it from the queued / sent heaps

8 years agotravis fix
Alan T. DeKok [Wed, 11 Oct 2017 13:25:12 +0000 (09:25 -0400)] 
travis fix

8 years agoclean up connection state on failure
Alan T. DeKok [Wed, 11 Oct 2017 12:50:53 +0000 (08:50 -0400)] 
clean up connection state on failure

8 years agoalways add Event-Timestampt to status packets
Alan T. DeKok [Tue, 10 Oct 2017 19:26:40 +0000 (15:26 -0400)] 
always add Event-Timestampt to status packets

and always update it when sending those packets

8 years agodon't update Acct-Delay-Time for status check packets
Alan T. DeKok [Tue, 10 Oct 2017 19:20:29 +0000 (15:20 -0400)] 
don't update Acct-Delay-Time for status check packets

8 years agoenforce limits on retransmissions
Alan T. DeKok [Tue, 10 Oct 2017 19:18:04 +0000 (15:18 -0400)] 
enforce limits on retransmissions

and make status check packets use the same retransmission path
as normal packets

8 years agouse local retry variable
Alan T. DeKok [Tue, 10 Oct 2017 18:59:46 +0000 (14:59 -0400)] 
use local retry variable

8 years agowe can send reply to network after max_request_time
Alan T. DeKok [Tue, 10 Oct 2017 18:54:44 +0000 (14:54 -0400)] 
we can send reply to network after max_request_time

8 years agodo proper state changes on retransmit
Alan T. DeKok [Tue, 10 Oct 2017 18:53:39 +0000 (14:53 -0400)] 
do proper state changes on retransmit

8 years agoadd new Juniper/Unisphere/ERX VSAs 2091/head
Bjørn Mork [Wed, 11 Oct 2017 12:01:26 +0000 (14:01 +0200)] 
add new Juniper/Unisphere/ERX VSAs

Importing new attributes from
https://www.juniper.net/documentation/software/junos/junos161/radius-dictionary/unisphereDictionary_for_JUNOS_v16-1.dct
using the exact attribute names Juniper use, following the precedence set
by the original conversion from dictionary.erx to dictionary.unisphere

Yes, Juniper *do* use four different attributes prefixes here:
 Unisphere, Pcp (sic), Jnpr and ERX(!)

Quite impressive.  And quite a mess.  But at least it's not *our* mess
if we just got with their names...

Signed-off-by: Bjørn Mork <bjorn@mork.no>
8 years agoReturn -1 from fr_event_filter_insert if fr_event_build_evset fails (instead of going...
Arran Cudbard-Bell [Wed, 11 Oct 2017 07:21:05 +0000 (13:21 +0600)] 
Return -1 from fr_event_filter_insert if fr_event_build_evset fails (instead of going into an infinite loop)

8 years agotrack active packets in a connection
Alan T. DeKok [Tue, 10 Oct 2017 18:43:12 +0000 (14:43 -0400)] 
track active packets in a connection