]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
9 years agoCommit 95% of the new module framework changes
Arran Cudbard-Bell [Wed, 14 Jun 2017 22:20:28 +0000 (18:20 -0400)] 
Commit 95% of the new module framework changes

It doesn't work yet, but the old tests pass and i'm tired.

9 years agodon't let it be equal to max code, either
Alan T. DeKok [Wed, 14 Jun 2017 21:17:45 +0000 (17:17 -0400)] 
don't let it be equal to max code, either

9 years agodoxygen
Alan T. DeKok [Wed, 14 Jun 2017 21:09:49 +0000 (17:09 -0400)] 
doxygen

9 years agoallow for unconnected sockets, too
Alan T. DeKok [Wed, 14 Jun 2017 20:23:22 +0000 (16:23 -0400)] 
allow for unconnected sockets, too

9 years agoCleanup calls to cf_log_err
Arran Cudbard-Bell [Wed, 14 Jun 2017 14:25:51 +0000 (10:25 -0400)] 
Cleanup calls to cf_log_err

9 years agostupid static analyser
Alan T. DeKok [Wed, 14 Jun 2017 13:44:56 +0000 (09:44 -0400)] 
stupid static analyser

9 years agofix up API to take entry, not packet, on delete
Alan T. DeKok [Tue, 13 Jun 2017 20:49:36 +0000 (16:49 -0400)] 
fix up API to take entry, not packet, on delete

9 years agoTidy up callback code
Arran Cudbard-Bell [Wed, 14 Jun 2017 02:43:50 +0000 (22:43 -0400)] 
Tidy up callback code

9 years agoAdd support for custom validation/parsing callbacks
Arran Cudbard-Bell [Wed, 14 Jun 2017 01:35:47 +0000 (21:35 -0400)] 
Add support for custom validation/parsing callbacks

9 years agoTypo
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:46:11 +0000 (20:46 -0400)] 
Typo

9 years agoMore travis fixes…
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:33:54 +0000 (20:33 -0400)] 
More travis fixes…

9 years agoMore travis fixes
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:22:57 +0000 (20:22 -0400)] 
More travis fixes

9 years agoMore includes...
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:18:43 +0000 (20:18 -0400)] 
More includes...

9 years agoMore includes..
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:16:02 +0000 (20:16 -0400)] 
More includes..

9 years agoReturn on rad_assert()
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:11:10 +0000 (20:11 -0400)] 
Return on rad_assert()

9 years agoMore travis fixes
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:08:50 +0000 (20:08 -0400)] 
More travis fixes

9 years agoTravis fixes
Arran Cudbard-Bell [Wed, 14 Jun 2017 00:03:55 +0000 (20:03 -0400)] 
Travis fixes

9 years agoDon’t use tabs in cf_log_* messages
Arran Cudbard-Bell [Tue, 13 Jun 2017 23:59:30 +0000 (19:59 -0400)] 
Don’t use tabs in cf_log_* messages

9 years agoAdd lispy dynamic config parsing
Arran Cudbard-Bell [Tue, 13 Jun 2017 23:46:59 +0000 (19:46 -0400)] 
Add lispy dynamic config parsing

9 years agoInclude cf_parse.h in client.c
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:56:08 +0000 (16:56 -0400)] 
Include cf_parse.h in client.c

9 years agoDon't install conf_file.h
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:46:14 +0000 (16:46 -0400)] 
Don't install conf_file.h

9 years agoReturn in non-dev builds
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:45:18 +0000 (16:45 -0400)] 
Return in non-dev builds

9 years agoCheck config
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:43:49 +0000 (16:43 -0400)] 
Check config

9 years agoMore nested preprocessor macros
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:42:41 +0000 (16:42 -0400)] 
More nested preprocessor macros

9 years agoNeed cf_parse.h for redis ippool tool
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:10:24 +0000 (16:10 -0400)] 
Need cf_parse.h for redis ippool tool

9 years agoExplicitly include modules.h?
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:06:37 +0000 (16:06 -0400)] 
Explicitly include modules.h?

9 years agoconstify cs in xlat_redundant_t
Arran Cudbard-Bell [Tue, 13 Jun 2017 20:05:27 +0000 (16:05 -0400)] 
constify cs in xlat_redundant_t

9 years agoAdd cf_data_add function for dealing with non-talloced data
Arran Cudbard-Bell [Tue, 13 Jun 2017 19:54:10 +0000 (15:54 -0400)] 
Add cf_data_add function for dealing with non-talloced data

9 years agoAutocast child in cf_item_add too
Arran Cudbard-Bell [Tue, 13 Jun 2017 19:53:53 +0000 (15:53 -0400)] 
Autocast child in cf_item_add too

9 years agotravis fixes
Alan T. DeKok [Tue, 13 Jun 2017 19:50:56 +0000 (15:50 -0400)] 
travis fixes

9 years agoremove STATIC_MODULES, and shared/static library configuration
Alan T. DeKok [Tue, 13 Jun 2017 18:04:45 +0000 (14:04 -0400)] 
remove STATIC_MODULES, and shared/static library configuration

It's 2017.  We always use shared libraries

9 years agoshould not be committed
Alan T. DeKok [Tue, 13 Jun 2017 17:45:00 +0000 (13:45 -0400)] 
should not be committed

9 years agoallow for multiple packet codes in the same tracking structure
Alan T. DeKok [Mon, 12 Jun 2017 14:45:33 +0000 (10:45 -0400)] 
allow for multiple packet codes in the same tracking structure

9 years agoupdate duplicate tracking API
Alan T. DeKok [Fri, 9 Jun 2017 18:04:20 +0000 (14:04 -0400)] 
update duplicate tracking API

It only deals with 256 packets.  i.e. one set of packets
for a connected socket.

todo

* add support for multiple kinds of packets on the same socket
* add support for Request Authenticator as an extended identifier

9 years agomake mr_array cleanup the same as the rb_array cleanup
Alan T. DeKok [Wed, 7 Jun 2017 21:44:11 +0000 (17:44 -0400)] 
make mr_array cleanup the same as the rb_array cleanup

9 years agoStupid compiler
Arran Cudbard-Bell [Tue, 13 Jun 2017 17:41:59 +0000 (13:41 -0400)] 
Stupid compiler

9 years agoMark check_config as extern
Arran Cudbard-Bell [Tue, 13 Jun 2017 17:11:21 +0000 (13:11 -0400)] 
Mark check_config as extern

9 years agoDeal with double const
Arran Cudbard-Bell [Tue, 13 Jun 2017 17:07:03 +0000 (13:07 -0400)] 
Deal with double const

9 years agoDoxygen
Arran Cudbard-Bell [Tue, 13 Jun 2017 17:02:26 +0000 (13:02 -0400)] 
Doxygen

9 years agoFix typo
Arran Cudbard-Bell [Tue, 13 Jun 2017 17:01:51 +0000 (13:01 -0400)] 
Fix typo

9 years agoAdd parsing callback in cf_parse
Arran Cudbard-Bell [Tue, 13 Jun 2017 17:00:50 +0000 (13:00 -0400)] 
Add parsing callback in cf_parse

9 years agoFormatting
Arran Cudbard-Bell [Tue, 13 Jun 2017 16:57:53 +0000 (12:57 -0400)] 
Formatting

9 years agoDoxygen
Arran Cudbard-Bell [Tue, 13 Jun 2017 16:46:09 +0000 (12:46 -0400)] 
Doxygen

9 years agoFix nested macro conditions
Arran Cudbard-Bell [Tue, 13 Jun 2017 16:45:05 +0000 (12:45 -0400)] 
Fix nested macro conditions

9 years agoSplit the horror into three
Arran Cudbard-Bell [Tue, 13 Jun 2017 16:30:49 +0000 (12:30 -0400)] 
Split the horror into three

9 years agoTypo
Arran Cudbard-Bell [Tue, 13 Jun 2017 14:35:59 +0000 (10:35 -0400)] 
Typo

9 years agoMinor fixes
Arran Cudbard-Bell [Tue, 13 Jun 2017 14:26:17 +0000 (10:26 -0400)] 
Minor fixes

9 years agoRemove many type specific functions from the conf_file api
Arran Cudbard-Bell [Tue, 13 Jun 2017 14:12:46 +0000 (10:12 -0400)] 
Remove many type specific functions from the conf_file api

Rework the internals of CONF_ITEMs, CONF_SECTIONs, CONF_DATA so they're simple/sane.

Allow nested CONF_DATA

Provide functions to iterate over CONF_DATA of the same type

Get CONF_DATA by type only

Get CONF_DATA by name only

9 years agoComma comma comma comma
Arran Cudbard-Bell [Fri, 9 Jun 2017 20:04:23 +0000 (16:04 -0400)] 
Comma comma comma comma

9 years agoMinor fixes
Arran Cudbard-Bell [Fri, 9 Jun 2017 01:16:48 +0000 (21:16 -0400)] 
Minor fixes

9 years agoDon't assume item.parent is a CONF_SECTION
Arran Cudbard-Bell [Thu, 8 Jun 2017 23:09:26 +0000 (19:09 -0400)] 
Don't assume item.parent is a CONF_SECTION

It could be a pair if the child is cf_data

9 years agoAdd new IO headers (not currently used)
Arran Cudbard-Bell [Thu, 8 Jun 2017 22:10:51 +0000 (18:10 -0400)] 
Add new IO headers (not currently used)

9 years agosimplify packing of rb array
Alan T. DeKok [Wed, 7 Jun 2017 21:27:42 +0000 (17:27 -0400)] 
simplify packing of rb array

Still need to do the same fixups for the message array

9 years agoMake it build again...
Arran Cudbard-Bell [Wed, 7 Jun 2017 20:13:27 +0000 (16:13 -0400)] 
Make it build again...

9 years agoSet type name for weird module's instance data
Arran Cudbard-Bell [Wed, 7 Jun 2017 20:13:00 +0000 (16:13 -0400)] 
Set type name for weird module's instance data

9 years agoAdd perr functions to print fr_strerror() stacks related to config issues
Arran Cudbard-Bell [Wed, 7 Jun 2017 20:01:13 +0000 (16:01 -0400)] 
Add perr functions to print fr_strerror() stacks related to config issues

9 years agoFinish moving io_ctx and io_op into a common structure and pass that around instead
Arran Cudbard-Bell [Wed, 7 Jun 2017 19:25:49 +0000 (15:25 -0400)] 
Finish moving io_ctx and io_op into a common structure and pass that around instead

In radius_schedule_test, move non-io related fields into fr_test_packet_ctx_t.  fr_test_packet_ctx_t is a global.

Use op->open for opening sockets, and op->fd to get the file descriptor

9 years agoFormatting
Arran Cudbard-Bell [Wed, 7 Jun 2017 19:22:32 +0000 (15:22 -0400)] 
Formatting

9 years agoConstify fr_io_t in some places
Arran Cudbard-Bell [Wed, 7 Jun 2017 19:22:05 +0000 (15:22 -0400)] 
Constify fr_io_t in some places

9 years agoEncode status server requests too
Arran Cudbard-Bell [Wed, 7 Jun 2017 19:07:36 +0000 (15:07 -0400)] 
Encode status server requests too

9 years agoWarn if the file contains no attributes
Arran Cudbard-Bell [Wed, 7 Jun 2017 18:53:43 +0000 (14:53 -0400)] 
Warn if the file contains no attributes

9 years agoPrint prefix even if there's no error message
Arran Cudbard-Bell [Wed, 7 Jun 2017 18:43:44 +0000 (14:43 -0400)] 
Print prefix even if there's no error message

9 years agoRename fr_packet_ctx_t to fr_radius_packet_ctx_t in the test utility
Arran Cudbard-Bell [Wed, 7 Jun 2017 17:12:45 +0000 (13:12 -0400)] 
Rename fr_packet_ctx_t to fr_radius_packet_ctx_t in the test utility

So it's less confusing...

Also add an fr_io_t value to the channel data.

9 years agoAdd packet_ctx to fr_channel_data_t
Arran Cudbard-Bell [Wed, 7 Jun 2017 17:11:53 +0000 (13:11 -0400)] 
Add packet_ctx to fr_channel_data_t

9 years agohacks for testing
Alan T. DeKok [Wed, 7 Jun 2017 15:45:35 +0000 (11:45 -0400)] 
hacks for testing

9 years agoFakeout fr_io_t in worker_test.c
Arran Cudbard-Bell [Wed, 7 Jun 2017 16:53:19 +0000 (12:53 -0400)] 
Fakeout fr_io_t in worker_test.c

9 years agoFormatting
Arran Cudbard-Bell [Wed, 7 Jun 2017 16:53:04 +0000 (12:53 -0400)] 
Formatting

9 years agoRemove fd and status from fr_io_t
Arran Cudbard-Bell [Wed, 7 Jun 2017 16:44:04 +0000 (12:44 -0400)] 
Remove fd and status from fr_io_t

9 years agomove everything to local ctx
Alan T. DeKok [Wed, 7 Jun 2017 15:32:30 +0000 (11:32 -0400)] 
move everything to local ctx

9 years agoonly start the scheduler for new sockets
Alan T. DeKok [Wed, 7 Jun 2017 15:32:10 +0000 (11:32 -0400)] 
only start the scheduler for new sockets

9 years agoensure "port_name" is initialized
Alan T. DeKok [Wed, 7 Jun 2017 15:29:56 +0000 (11:29 -0400)] 
ensure "port_name" is initialized

9 years agoproper check for return code
Alan T. DeKok [Wed, 7 Jun 2017 15:23:18 +0000 (11:23 -0400)] 
proper check for return code

9 years agoreturn if it IS verifying config
Alan T. DeKok [Wed, 7 Jun 2017 15:16:36 +0000 (11:16 -0400)] 
return if it IS verifying config

9 years agocreate a scheduler (always) with hard-coded values
Alan T. DeKok [Wed, 7 Jun 2017 15:05:48 +0000 (11:05 -0400)] 
create a scheduler (always) with hard-coded values

TODO: make it configurable

9 years agoadd port_name based on packet type, unless it already exists
Alan T. DeKok [Wed, 7 Jun 2017 14:45:10 +0000 (10:45 -0400)] 
add port_name based on packet type, unless it already exists

9 years agoUse 'port_name' if there's no 'port'. Otherwise, exit
Alan T. DeKok [Wed, 7 Jun 2017 14:44:32 +0000 (10:44 -0400)] 
Use 'port_name' if there's no 'port'.  Otherwise, exit

9 years agoput sockets into an rbtree
Alan T. DeKok [Wed, 7 Jun 2017 14:25:35 +0000 (10:25 -0400)] 
put sockets into an rbtree

so that they can be looked up and deleted quickly on error

9 years agoremove sockfd from the public API
Alan T. DeKok [Wed, 7 Jun 2017 14:14:04 +0000 (10:14 -0400)] 
remove sockfd from the public API

9 years agoadd and expose fd() function
Alan T. DeKok [Wed, 7 Jun 2017 14:04:35 +0000 (10:04 -0400)] 
add and expose fd() function

9 years agoadd port_name
Alan T. DeKok [Wed, 7 Jun 2017 13:51:18 +0000 (09:51 -0400)] 
add port_name

9 years agoDoxygen fixups
Arran Cudbard-Bell [Wed, 7 Jun 2017 14:01:48 +0000 (10:01 -0400)] 
Doxygen fixups

9 years agoreturn fr_network_t when adding a socket to a scheduler
Alan T. DeKok [Wed, 7 Jun 2017 12:34:18 +0000 (08:34 -0400)] 
return fr_network_t when adding a socket to a scheduler

so that the caller can push other things for that socket
to the network thread.

9 years agoupdate starent dictionary as posted to mailing list
Matthew Newton [Wed, 7 Jun 2017 09:58:47 +0000 (10:58 +0100)] 
update starent dictionary as posted to mailing list

9 years agoRename transport to IO
Arran Cudbard-Bell [Tue, 6 Jun 2017 21:45:11 +0000 (17:45 -0400)] 
Rename transport to IO

Rename a bunch of structures.

Use the standard module instantiation framework for fr_io_t

9 years agonotes on tls-cache
Alan T. DeKok [Tue, 6 Jun 2017 17:08:23 +0000 (13:08 -0400)] 
notes on tls-cache

9 years agonotes on caching
Alan T. DeKok [Tue, 6 Jun 2017 15:41:39 +0000 (11:41 -0400)] 
notes on caching

9 years agoThe presentation format of FR_TYPE_OCTETS comes with its own 0x
Arran Cudbard-Bell [Tue, 6 Jun 2017 14:38:42 +0000 (10:38 -0400)] 
The presentation format of FR_TYPE_OCTETS comes with its own 0x

9 years agonotes on Perl
Alan T. DeKok [Tue, 6 Jun 2017 14:29:50 +0000 (10:29 -0400)] 
notes on Perl

9 years agoas posted to the list
Alan T. DeKok [Tue, 6 Jun 2017 14:27:56 +0000 (10:27 -0400)] 
as posted to the list

9 years agoMore %pV
Arran Cudbard-Bell [Tue, 6 Jun 2017 14:17:29 +0000 (10:17 -0400)] 
More %pV

9 years agodon't put business logic into an "if debug" condition
Alan T. DeKok [Tue, 6 Jun 2017 14:07:27 +0000 (10:07 -0400)] 
don't put business logic into an "if debug" condition

9 years agoDon't need socket_type_from_proto anymore
Arran Cudbard-Bell [Mon, 5 Jun 2017 22:32:10 +0000 (18:32 -0400)] 
Don't need socket_type_from_proto anymore

9 years agoNull pointer dereference
Arran Cudbard-Bell [Mon, 5 Jun 2017 22:29:58 +0000 (18:29 -0400)] 
Null pointer dereference

9 years agoMove don't fragment to a function and set it for connected UDP sockets too
Arran Cudbard-Bell [Mon, 5 Jun 2017 21:36:47 +0000 (17:36 -0400)] 
Move don't fragment to a function and set it for connected UDP sockets too

9 years agoFix typo checking return code
Arran Cudbard-Bell [Mon, 5 Jun 2017 21:36:31 +0000 (17:36 -0400)] 
Fix typo checking return code

9 years agoTypo
Arran Cudbard-Bell [Mon, 5 Jun 2017 21:34:43 +0000 (17:34 -0400)] 
Typo

9 years agoRemove fr_socket()
Arran Cudbard-Bell [Mon, 5 Jun 2017 21:21:47 +0000 (17:21 -0400)] 
Remove fr_socket()

Most of the calls use fr_socket_server_udp now.  Which sort of works but isn't great.

The issue is a lot of the code assumes unconnected UDP sockets, whereas it should be updated to use connected ones.

Seems like connect()ing a UDP socket and then trying to set the destination IP address will probably produce obscure errors.

9 years agoCleanup socket.c
Arran Cudbard-Bell [Mon, 5 Jun 2017 20:26:06 +0000 (16:26 -0400)] 
Cleanup socket.c

Split the socket opening functions into udp and tcp, with the common logic in local functions

9 years agoMove UDP socket parsing entries into a CONF_PARSER array
Arran Cudbard-Bell [Mon, 5 Jun 2017 18:56:25 +0000 (14:56 -0400)] 
Move UDP socket parsing entries into a CONF_PARSER array

9 years agoFix typo
Philippe Wooding [Mon, 5 Jun 2017 11:01:55 +0000 (13:01 +0200)] 
Fix typo