]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
16 months agoRevert "maybe fix the redis test in CI"
Alan T. DeKok [Sat, 31 Aug 2024 19:37:19 +0000 (15:37 -0400)] 
Revert "maybe fix the redis test in CI"

This reverts commit 7568f6b2098d6b8fe8fd385df5a65d54dbb9cf7a.

nope

16 months agomaybe fix the redis test in CI
Alan T. DeKok [Sat, 31 Aug 2024 19:30:20 +0000 (15:30 -0400)] 
maybe fix the redis test in CI

16 months agoclean up uses of "set leaf num"
Alan T. DeKok [Sat, 31 Aug 2024 14:08:53 +0000 (10:08 -0400)] 
clean up uses of "set leaf num"

in most cases it's not necessary.  We instead initialize the
ar filter to NONE.

In other cases (now that we may have multiple kinds of filters),
we check that we're only setting the num for FILTER_INDEX.
and if we're clearing the num by setting it to NUM_UNSPEC, we
also set the filter to FILTER_NONE

Much of the code in the server assumed that it could always look
at ar->ar_num.  It would therefore behave "surprisingly" when
other filters are used.

16 months agoif we're setting a leaf num, ensure the filter type is correct
Alan T. DeKok [Sat, 31 Aug 2024 14:02:46 +0000 (10:02 -0400)] 
if we're setting a leaf num, ensure the filter type is correct

16 months agogive warning on 'foreach' not using [*]
Alan T. DeKok [Sat, 31 Aug 2024 13:56:08 +0000 (09:56 -0400)] 
give warning on 'foreach' not using [*]

16 months agoremove "auto", and allow just foreach foo (&bar) { ... }
Alan T. DeKok [Fri, 30 Aug 2024 19:59:36 +0000 (15:59 -0400)] 
remove "auto", and allow just foreach foo (&bar) { ... }

16 months agodocument that we can modify attributes
Alan T. DeKok [Fri, 30 Aug 2024 18:38:56 +0000 (14:38 -0400)] 
document that we can modify attributes

16 months agoallow modification of leaf attributes in "foreach"
Alan T. DeKok [Fri, 30 Aug 2024 18:26:28 +0000 (14:26 -0400)] 
allow modification of leaf attributes in "foreach"

16 months agolocal variables can't be list refs or request refs
Alan T. DeKok [Fri, 30 Aug 2024 17:58:34 +0000 (13:58 -0400)] 
local variables can't be list refs or request refs

16 months agocompile_children() frees the group on error
Alan T. DeKok [Fri, 30 Aug 2024 17:24:34 +0000 (13:24 -0400)] 
compile_children() frees the group on error

16 months agoadd 'const'
Alan T. DeKok [Fri, 30 Aug 2024 14:55:56 +0000 (10:55 -0400)] 
add 'const'

16 months agodocument new foreach syntax
Alan T. DeKok [Fri, 30 Aug 2024 14:41:34 +0000 (10:41 -0400)] 
document new foreach syntax

16 months agocreate and copy local key variable
Alan T. DeKok [Fri, 30 Aug 2024 14:12:56 +0000 (10:12 -0400)] 
create and copy local key variable

allegedly structural types should work, but it's untested. :)

16 months agodefine local variable via: foreach uint32 foo (...) { ... }
Alan T. DeKok [Thu, 29 Aug 2024 20:01:58 +0000 (16:01 -0400)] 
define local variable via: foreach uint32 foo (...) { ... }

the variable is defined, and references to it in the "foreach"
loop body work.

16 months agoparse new syntax for "foreach"
Alan T. DeKok [Thu, 29 Aug 2024 19:02:01 +0000 (15:02 -0400)] 
parse new syntax for "foreach"

nothing is compiled or intepreted as yet, but we're a step ahead

16 months agoUse current time rather than packet time in redis_ippool tests
Nick Porter [Thu, 29 Aug 2024 17:41:44 +0000 (18:41 +0100)] 
Use current time rather than packet time in redis_ippool tests

Sometimes, bringing the cluster up takes long enough to cause the test
to appear to fail.

Packet time starts before the cluster is reset, rather than when the
main test policy is run.

16 months agoBoth stop and disable apparmor
Nick Porter [Thu, 29 Aug 2024 16:23:22 +0000 (17:23 +0100)] 
Both stop and disable apparmor

16 months agoAdd platform to hostapd-cache key
Nick Porter [Thu, 29 Aug 2024 15:48:21 +0000 (16:48 +0100)] 
Add platform to hostapd-cache key

When building FreeRADIUS in a docker container, runner.os is the host
platform - so does not change to reflect the docker image the build is
running in.

16 months agoMove to latest eapol_test release
Nick Porter [Thu, 29 Aug 2024 15:39:32 +0000 (16:39 +0100)] 
Move to latest eapol_test release

16 months agowe only use OpenSSL stuff when it's built
Alan T. DeKok [Thu, 29 Aug 2024 15:36:49 +0000 (11:36 -0400)] 
we only use OpenSSL stuff when it's built

16 months agomore "shut up broken compiler"
Alan T. DeKok [Thu, 29 Aug 2024 15:33:12 +0000 (11:33 -0400)] 
more "shut up broken compiler"

16 months agoadd dbuff macro which initializes output buffers
Alan T. DeKok [Thu, 29 Aug 2024 14:02:39 +0000 (10:02 -0400)] 
add dbuff macro which initializes output buffers

and use it to quiet the compiler.

16 months agolibclang-rt-dev is needed for sanitizers
Nick Porter [Thu, 29 Aug 2024 13:46:42 +0000 (14:46 +0100)] 
libclang-rt-dev is needed for sanitizers

16 months agoUbuntu 24.04 docker image is missing /sbin/ip
Nick Porter [Thu, 29 Aug 2024 13:00:58 +0000 (14:00 +0100)] 
Ubuntu 24.04 docker image is missing /sbin/ip

Which broke the 389ds setup script

16 months agoDon't fail if apparmor is not installed
Nick Porter [Thu, 29 Aug 2024 12:26:33 +0000 (13:26 +0100)] 
Don't fail if apparmor is not installed

16 months agoShell required for run step
Nick Porter [Thu, 29 Aug 2024 12:21:07 +0000 (13:21 +0100)] 
Shell required for run step

16 months agoDisable apparmor
Arran Cudbard-Bell [Thu, 29 Aug 2024 12:03:22 +0000 (07:03 -0500)] 
Disable apparmor

16 months agoForward declaration return type should be an enum
Arran Cudbard-Bell [Thu, 29 Aug 2024 11:42:00 +0000 (06:42 -0500)] 
Forward declaration return type should be an enum

16 months agoSwap arguments to calloc
Arran Cudbard-Bell [Thu, 29 Aug 2024 11:40:02 +0000 (06:40 -0500)] 
Swap arguments to calloc

16 months agocb goes out of scope...
Arran Cudbard-Bell [Thu, 29 Aug 2024 11:30:41 +0000 (06:30 -0500)] 
cb goes out of scope...

16 months agoRevert "Fix request priorities"
Arran Cudbard-Bell [Thu, 29 Aug 2024 11:23:01 +0000 (06:23 -0500)] 
Revert "Fix request priorities"

This reverts commit 30f03974643064728fea95f0887b1a8211eb83d8.

16 months agoFail early means the logs aren't output from configure
Arran Cudbard-Bell [Thu, 29 Aug 2024 11:15:24 +0000 (06:15 -0500)] 
Fail early means the logs aren't output from configure

16 months agoDon't leave a stack marker linked in to the sbuff
Arran Cudbard-Bell [Thu, 29 Aug 2024 10:47:22 +0000 (05:47 -0500)] 
Don't leave a stack marker linked in to the sbuff

16 months agoConvince the compiler we know what we're doing
Arran Cudbard-Bell [Thu, 29 Aug 2024 10:42:39 +0000 (05:42 -0500)] 
Convince the compiler we know what we're doing

16 months agoA BAD DN result is pretty much the same as an empty result
Arran Cudbard-Bell [Wed, 28 Aug 2024 22:28:13 +0000 (17:28 -0500)] 
A BAD DN result is pretty much the same as an empty result

Especially now we can dynamically configure DNs...

16 months agoPrint out useful information when starting the LDAP server
Arran Cudbard-Bell [Wed, 28 Aug 2024 21:52:41 +0000 (16:52 -0500)] 
Print out useful information when starting the LDAP server

16 months agoWS
Arran Cudbard-Bell [Wed, 28 Aug 2024 21:45:49 +0000 (16:45 -0500)] 
WS

16 months agoFix request priorities
Arran Cudbard-Bell [Wed, 28 Aug 2024 21:45:32 +0000 (16:45 -0500)] 
Fix request priorities

16 months agovariable can't be NULL
Alan T. DeKok [Wed, 28 Aug 2024 22:03:01 +0000 (18:03 -0400)] 
variable can't be NULL

16 months agovariable should be static
Alan T. DeKok [Wed, 28 Aug 2024 21:56:53 +0000 (17:56 -0400)] 
variable should be static

16 months ago"out" can't be NULL
Alan T. DeKok [Wed, 28 Aug 2024 19:54:33 +0000 (15:54 -0400)] 
"out" can't be NULL

16 months agoand regenerate
Alan T. DeKok [Wed, 28 Aug 2024 19:46:53 +0000 (15:46 -0400)] 
and regenerate

16 months agomaybe pthread functions are in -lc?
Alan T. DeKok [Wed, 28 Aug 2024 19:41:16 +0000 (15:41 -0400)] 
maybe pthread functions are in -lc?

16 months agoWe need to be built with OpenSSL in order to do SSL for Redis
Arran Cudbard-Bell [Wed, 28 Aug 2024 18:11:33 +0000 (13:11 -0500)] 
We need to be built with OpenSSL in order to do SSL for Redis

16 months agoUpdate guess and sub
Arran Cudbard-Bell [Wed, 28 Aug 2024 17:57:56 +0000 (12:57 -0500)] 
Update guess and sub

16 months agomove fr_pair_print() to using ::enum-name
Alan T. DeKok [Wed, 28 Aug 2024 17:46:17 +0000 (13:46 -0400)] 
move fr_pair_print() to using ::enum-name

and update the regression tests to match.

Anything which reads the server output will need to be updated
to allow ::enum-name.

the value-box and tmpl functions already allow, but don't require
the "::" prefix for enum names.  So any server code will be OK.

i.e. radclient etc. will parse either ::enum-name or enum-name.

This change should only affect the unit tests, and the detail file
writer.

16 months agowe don't need signed ints for number of bits
Alan T. DeKok [Wed, 28 Aug 2024 17:45:31 +0000 (13:45 -0400)] 
we don't need signed ints for number of bits

16 months agoInclude extra header if HAVE_REDIS_SSL
Arran Cudbard-Bell [Wed, 28 Aug 2024 17:46:18 +0000 (12:46 -0500)] 
Include extra header if HAVE_REDIS_SSL

16 months agoQuiet clang analyzer
Arran Cudbard-Bell [Wed, 28 Aug 2024 17:45:54 +0000 (12:45 -0500)] 
Quiet clang analyzer

16 months agoQuiet clang
Arran Cudbard-Bell [Wed, 28 Aug 2024 17:17:55 +0000 (12:17 -0500)] 
Quiet clang

16 months agoBump LLVM and GCC versions
Arran Cudbard-Bell [Wed, 28 Aug 2024 17:05:13 +0000 (12:05 -0500)] 
Bump LLVM and GCC versions

16 months agoFreeBSD's pip is called pip
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:58:16 +0000 (11:58 -0500)] 
FreeBSD's pip is called pip

16 months agoNYI
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:56:35 +0000 (11:56 -0500)] 
NYI

16 months agoSwitch back to our internal docker image now it's been updated
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:46:27 +0000 (11:46 -0500)] 
Switch back to our internal docker image now it's been updated

16 months agoBump fuzzer OS image
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:36:10 +0000 (11:36 -0500)] 
Bump fuzzer OS image

16 months agoBump base ci Dockerfile image, and llvm/gcc versions
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:35:57 +0000 (11:35 -0500)] 
Bump base ci Dockerfile image, and llvm/gcc versions

16 months agoUse the env var, so old versions of pip don't break
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:29:17 +0000 (11:29 -0500)] 
Use the env var, so old versions of pip don't break

16 months agoWe _should_ setup a venv for this...
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:22:08 +0000 (11:22 -0500)] 
We _should_ setup a venv for this...

16 months agotypo
Alan T. DeKok [Wed, 28 Aug 2024 16:15:44 +0000 (12:15 -0400)] 
typo

16 months agoNo... doesn't like unterminated single quotes strings
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:13:29 +0000 (11:13 -0500)] 
No... doesn't like unterminated single quotes strings

16 months agoyaml doesn't allow inline comments?
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:04:25 +0000 (11:04 -0500)] 
yaml doesn't allow inline comments?

16 months agotemplates can have update sections
Alan T. DeKok [Wed, 28 Aug 2024 15:59:58 +0000 (11:59 -0400)] 
templates can have update sections

16 months agoadd "-w file" flag
Alan T. DeKok [Wed, 28 Aug 2024 15:11:12 +0000 (11:11 -0400)] 
add "-w file" flag

which will copy the input text to output file.  AND for the
"match" command, replace any incorrect "expected" text with
the "actual" output.

This functionality is useful when we're changing the print
routines, but none of the other outputs have changed.

16 months agoRun CI builds on a base ubuntu24 docker image for now, until we fix up the self-hoste...
Arran Cudbard-Bell [Wed, 28 Aug 2024 16:00:05 +0000 (11:00 -0500)] 
Run CI builds on a base ubuntu24 docker image for now, until we fix up the self-hosted image

16 months agoJust bump the runner to 24.04, we only run sanitizer on GitHub anyway...
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:56:10 +0000 (10:56 -0500)] 
Just bump the runner to 24.04, we only run sanitizer on GitHub anyway...

16 months agoBump FreeBSD version
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:53:45 +0000 (10:53 -0500)] 
Bump FreeBSD version

16 months agoBump sanitizer docker image to 24.04
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:51:35 +0000 (10:51 -0500)] 
Bump sanitizer docker image to 24.04

16 months agoRemove docker build scripts for rock8, ubuntu20, debian11
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:47:36 +0000 (10:47 -0500)] 
Remove docker build scripts for rock8, ubuntu20, debian11

16 months agoDrop ubuntu-20.04 and debian-11
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:39:51 +0000 (10:39 -0500)] 
Drop ubuntu-20.04 and debian-11

16 months agoDrop rocky 8
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:39:36 +0000 (10:39 -0500)] 
Drop rocky 8

16 months agoAdd back missing endif
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:39:23 +0000 (10:39 -0500)] 
Add back missing endif

16 months agoRemove OpenSSL < 3.0.x support
Arran Cudbard-Bell [Wed, 28 Aug 2024 15:19:50 +0000 (10:19 -0500)] 
Remove OpenSSL < 3.0.x support

16 months agoupdate packet length after encoding
Alan T. DeKok [Wed, 28 Aug 2024 14:56:16 +0000 (10:56 -0400)] 
update packet length after encoding

16 months agounify pair_print_secure() and pair_print_secret a bit more
Alan T. DeKok [Tue, 27 Aug 2024 21:51:21 +0000 (17:51 -0400)] 
unify pair_print_secure() and pair_print_secret a bit more

in preparation for adding ::enum printing

16 months agoStrings need quotes in lua redis.call
Nick Porter [Wed, 28 Aug 2024 09:55:41 +0000 (10:55 +0100)] 
Strings need quotes in lua redis.call

16 months agooutput of radsniff / radclient isn't yet :: friendly
Alan T. DeKok [Tue, 27 Aug 2024 20:37:39 +0000 (16:37 -0400)] 
output of radsniff / radclient isn't yet :: friendly

16 months agoadd :: for Service-Type
Alan T. DeKok [Tue, 27 Aug 2024 19:59:19 +0000 (15:59 -0400)] 
add :: for Service-Type

perl -p -i -e 's/Service-Type(\s+(:=|=|==)\s+)([a-zA-Z])/Service-Type$1::$3/'  $(git grep -l 'Service-Type' src/tests raddb/)

except we don't so src/tests/unit, as the printing routines don't
print :: before enum names.  and the parsing routines don't set
t_rules->enumv, so parsing the enum doesn't work

16 months agoand raddb too
Alan T. DeKok [Tue, 27 Aug 2024 19:49:11 +0000 (15:49 -0400)] 
and raddb too

16 months agouse ::enum
Alan T. DeKok [Tue, 27 Aug 2024 19:48:12 +0000 (15:48 -0400)] 
use ::enum

perl -p -i -e 's/Auth-Type(\s+(:=|=|==)\s+)(\w)/Auth-Type$1::$3/'  $(git grep -l 'Auth-Type' src/tests/)

16 months agoremove unused field
Alan T. DeKok [Tue, 27 Aug 2024 13:40:06 +0000 (09:40 -0400)] 
remove unused field

16 months agoclarify error messages
Alan T. DeKok [Tue, 27 Aug 2024 13:37:35 +0000 (09:37 -0400)] 
clarify error messages

16 months agomove parse check to before extra work
Alan T. DeKok [Mon, 26 Aug 2024 17:43:15 +0000 (13:43 -0400)] 
move parse check to before extra work

16 months ago%(...) has been forbidden for a while
Alan T. DeKok [Mon, 26 Aug 2024 13:45:56 +0000 (09:45 -0400)] 
%(...) has been forbidden for a while

16 months agoremove unused field
Alan T. DeKok [Mon, 26 Aug 2024 12:38:56 +0000 (08:38 -0400)] 
remove unused field

16 months agoAdd OpenWiFi dictionary from v3.2
Nick Porter [Mon, 26 Aug 2024 08:10:56 +0000 (09:10 +0100)] 
Add OpenWiFi dictionary from v3.2

16 months agoAdd ckey dictionary from v3.2
Nick Porter [Mon, 26 Aug 2024 08:06:18 +0000 (09:06 +0100)] 
Add ckey dictionary from v3.2

16 months agoAdd WBA attributes to dictionary.wispr
Nick Porter [Mon, 26 Aug 2024 08:01:28 +0000 (09:01 +0100)] 
Add WBA attributes to dictionary.wispr

"WBA-" and "WISPr-" attributes use the same vendor ID

https://github.com/wireless-broadband-alliance/RADIUS-VSA

16 months agoPort Starent dictionary fixes from v3.2
Nick Porter [Mon, 26 Aug 2024 07:59:01 +0000 (08:59 +0100)] 
Port Starent dictionary fixes from v3.2

16 months agoPort dictionary.iea update from v3.2
Nick Porter [Mon, 26 Aug 2024 07:27:32 +0000 (08:27 +0100)] 
Port dictionary.iea update from v3.2

Update dictionary.iea with Air Marshal RADIUS attributes found in
https://www.iea-software.com/docs/airmarshal2/airmarshalv2.pdf

16 months agomore things can have "update" sections
Alan T. DeKok [Sun, 25 Aug 2024 12:41:49 +0000 (08:41 -0400)] 
more things can have "update" sections

16 months agomore cleanups and rearrangements
Alan T. DeKok [Sun, 25 Aug 2024 12:08:44 +0000 (08:08 -0400)] 
more cleanups and rearrangements

16 months agotighten rules for parser even more
Alan T. DeKok [Sat, 24 Aug 2024 21:41:17 +0000 (17:41 -0400)] 
tighten rules for parser even more

16 months agoallow LHS xlat, string, etc. only in unlang sections
Alan T. DeKok [Sat, 24 Aug 2024 20:39:50 +0000 (16:39 -0400)] 
allow LHS xlat, string, etc. only in unlang sections

16 months agoadd location-specific errors
Alan T. DeKok [Sat, 24 Aug 2024 14:04:20 +0000 (10:04 -0400)] 
add location-specific errors

instead of just saying "error in line", we now point to the exact
character which caused the error.

16 months agorelax parser
Alan T. DeKok [Sat, 24 Aug 2024 13:08:23 +0000 (09:08 -0400)] 
relax parser

as detail "suppress" uses bare words.

16 months agobe politer to mistakes
Alan T. DeKok [Sat, 24 Aug 2024 12:51:42 +0000 (08:51 -0400)] 
be politer to mistakes

16 months agonarrow down the scope of bare words in the configuration files
Alan T. DeKok [Sat, 24 Aug 2024 12:23:25 +0000 (08:23 -0400)] 
narrow down the scope of bare words in the configuration files

only unlang (module references) and edit sections (lists of values)
can have bare words.

as a result, remove old configuration sections which haven't been
used for a while.

Outside of unlang (map, switch) name2 must be alphanumeric

16 months agoremove unnecessary code
Alan T. DeKok [Sat, 24 Aug 2024 12:14:40 +0000 (08:14 -0400)] 
remove unnecessary code

16 months agodon't allow <cast>
Alan T. DeKok [Sat, 24 Aug 2024 11:51:05 +0000 (07:51 -0400)] 
don't allow <cast>

The rest of the parser hasn't supported it for a while, so we also
remove it from tmpl_preparse()

16 months agostart of hacking up the parser for removing '&'.
Alan T. DeKok [Thu, 22 Aug 2024 18:57:14 +0000 (14:57 -0400)] 
start of hacking up the parser for removing '&'.

we likely need to do a lot more, and do more functions like
fr_skip_xlat() in order to pre-parse attribute LHS and RHS