]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
18 months agoNo need to escape boxes containing inherently safe data
Nick Porter [Wed, 17 Jul 2024 07:27:57 +0000 (08:27 +0100)] 
No need to escape boxes containing inherently safe data

18 months agoEnsure that all SQL queries have correct, driver specific escaping
Nick Porter [Tue, 16 Jul 2024 17:33:11 +0000 (18:33 +0100)] 
Ensure that all SQL queries have correct, driver specific escaping

18 months agoFreeBSD 13.2 has moved to Python 3.11
Nick Porter [Wed, 17 Jul 2024 07:52:59 +0000 (08:52 +0100)] 
FreeBSD 13.2 has moved to Python 3.11

18 months agoUpdate 3gpp2 dictionary
Nick Porter [Fri, 12 Jul 2024 13:40:38 +0000 (14:40 +0100)] 
Update 3gpp2 dictionary

According to https://frp.3gpp2.org/Public_html/X/VSA-VSE.cfm and packets
seen in the wild

18 months agoCorrect sort sequence for requests in runnable heap
Nick Porter [Fri, 12 Jul 2024 08:32:25 +0000 (09:32 +0100)] 
Correct sort sequence for requests in runnable heap

18 months agoSet request priority from channel data priority
Nick Porter [Fri, 12 Jul 2024 08:30:41 +0000 (09:30 +0100)] 
Set request priority from channel data priority

18 months agoSet inst->parent first in proto_load_step.c
Arran Cudbard-Bell [Thu, 11 Jul 2024 19:21:50 +0000 (15:21 -0400)] 
Set inst->parent first in proto_load_step.c

18 months agoAvoid unused variable warning when WITH_VERIFY_PTR not set
Nick Porter [Wed, 10 Jul 2024 12:44:58 +0000 (13:44 +0100)] 
Avoid unused variable warning when WITH_VERIFY_PTR not set

18 months ago"min" returns the oldest requests
Nick Porter [Wed, 10 Jul 2024 11:03:14 +0000 (12:03 +0100)] 
"min" returns the oldest requests

And don't remove from the heap unless the request is actually being
stopped.

18 months agoconst
Nick Porter [Tue, 9 Jul 2024 16:38:50 +0000 (17:38 +0100)] 
const

18 months agoblastradius mitigations
Arran Cudbard-Bell [Sun, 30 Jun 2024 20:03:17 +0000 (14:03 -0600)] 
blastradius mitigations

- Adds require_message_authenticator for responses from upstream proxies.
- Adds require_message_authenticator in radius listen sections.
- Adds require_message_authenticator == auto - Which automatically requires Message-Authenticator after on is received.
- Adds limit_proxy_state to client definitions and radius listen sections.  limit_proxy_state restricts whether Proxy-State can be present in a request without a Message-Authenitcator attribute.  It too has an auto mode, where if the first packet from a client does not contain Proxy-State, all subsequent packets from that client must either contain Message-Authenticator, or must not contain Proxy-State.

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:46 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:40 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:34 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:25 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

18 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:22 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

18 months agoRebuild docker images when the dock file changes
Arran Cudbard-Bell [Thu, 4 Jul 2024 20:42:37 +0000 (14:42 -0600)] 
Rebuild docker images when the dock file changes

18 months agoInstall some extra packages by default
Arran Cudbard-Bell [Thu, 4 Jul 2024 20:36:52 +0000 (14:36 -0600)] 
Install some extra packages by default

18 months agoDon't emit spurious global WARNs in rlm_cache
Arran Cudbard-Bell [Thu, 4 Jul 2024 15:30:40 +0000 (09:30 -0600)] 
Don't emit spurious global WARNs in rlm_cache

18 months agoAdd freeradiusClientGroupDN
Arran Cudbard-Bell [Thu, 4 Jul 2024 05:02:51 +0000 (23:02 -0600)] 
Add freeradiusClientGroupDN

18 months agoAllow the name of the instant client packages to be specified
Arran Cudbard-Bell [Tue, 2 Jul 2024 23:06:38 +0000 (17:06 -0600)] 
Allow the name of the instant client packages to be specified

18 months agoUse the new macro name
Arran Cudbard-Bell [Tue, 2 Jul 2024 20:53:29 +0000 (14:53 -0600)] 
Use the new macro name

18 months agoDon't set the oracle version by default
Arran Cudbard-Bell [Tue, 2 Jul 2024 20:16:21 +0000 (14:16 -0600)] 
Don't set the oracle version by default

18 months agoRevert "Take RPMBUILD_FLAGS in builddep too"
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:58:05 +0000 (12:58 -0600)] 
Revert "Take RPMBUILD_FLAGS in builddep too"

This reverts commit 675e4e3f41b326b4561ca89ee80bee444a7e019c.

18 months agoRevert "Pass in the oracle version explicitly"
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:57:48 +0000 (12:57 -0600)] 
Revert "Pass in the oracle version explicitly"

This reverts commit 2b1a72f8ffb1d7e526cd7c55c7319332b1733ff9.

18 months agoMove definitions to the top of the spec file
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:53:12 +0000 (12:53 -0600)] 
Move definitions to the top of the spec file

18 months agoPass in the oracle version explicitly
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:43:19 +0000 (12:43 -0600)] 
Pass in the oracle version explicitly

All the rpmbuild tools seem very broken

18 months agoTake RPMBUILD_FLAGS in builddep too
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:27:40 +0000 (12:27 -0600)] 
Take RPMBUILD_FLAGS in builddep too

18 months agorpmbuild doesn't like the separation
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:13:08 +0000 (12:13 -0600)] 
rpmbuild doesn't like the separation

18 months agoAccept --define _oracle_version
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:02:44 +0000 (12:02 -0600)] 
Accept --define _oracle_version

18 months agoRegenerate the _ORACLE_ configure script
Arran Cudbard-Bell [Tue, 2 Jul 2024 17:19:55 +0000 (11:19 -0600)] 
Regenerate the _ORACLE_ configure script

18 months agoUpdate rlm_sql_oracle configure scripts
Arran Cudbard-Bell [Mon, 1 Jul 2024 23:19:36 +0000 (17:19 -0600)] 
Update rlm_sql_oracle configure scripts

18 months agoConst
Arran Cudbard-Bell [Sun, 30 Jun 2024 22:33:55 +0000 (16:33 -0600)] 
Const

18 months agoWS
Arran Cudbard-Bell [Sun, 30 Jun 2024 20:00:27 +0000 (14:00 -0600)] 
WS

18 months agoRemove invalid assert that was triggered evaluating log messages
Arran Cudbard-Bell [Sun, 30 Jun 2024 19:33:28 +0000 (13:33 -0600)] 
Remove invalid assert that was triggered evaluating log messages

18 months agoSync require_message_authenticator field names, it's called three different things...
Arran Cudbard-Bell [Sat, 29 Jun 2024 03:55:50 +0000 (21:55 -0600)] 
Sync require_message_authenticator field names, it's called three different things at different places in the server

18 months agoSet a capacity for trunk backlog
Nick Porter [Fri, 28 Jun 2024 11:20:50 +0000 (12:20 +0100)] 
Set a capacity for trunk backlog

And allow requests to be allocated / enqueued even if the max
connections and requests per connection limit is reached, up to the
backlog limit.

Helps handle spikes in traffic, particularly where trunks are limited to
one request per connection, and there are server side limitations on the
number of connections that can be made - e.g. SQL servers.

18 months agoRun docker build on ubuntu-latest
Nick Porter [Fri, 28 Jun 2024 12:46:41 +0000 (13:46 +0100)] 
Run docker build on ubuntu-latest

Seems to resolve the issue with the debiansid container build hanging

18 months agoAlways mark trunk requests as complete when freeing query ctx
Nick Porter [Fri, 28 Jun 2024 09:43:12 +0000 (10:43 +0100)] 
Always mark trunk requests as complete when freeing query ctx

Due to query_ctx being re-used multiple times when running transactions
(e.g. allocating IPs in sqlippool) it is possible for the current query
to not be submitted, but there still to be a trunk request associated
with the query_ctx.

18 months agoTypo
Arran Cudbard-Bell [Fri, 28 Jun 2024 03:58:34 +0000 (21:58 -0600)] 
Typo

18 months agoRefactor LDAP URI xlat code so that we can call it easily from a future modify and...
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:44:00 +0000 (11:44 -0600)] 
Refactor LDAP URI xlat code so that we can call it easily from a future modify and delete xlats

18 months agoAdd API level support for deleting objects
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:43:20 +0000 (11:43 -0600)] 
Add API level support for deleting objects

This is just for completeness.  We don't currently have any use case for it, but it'll likely be called by a delete xlat in the near future.

18 months agoWhitespace fixes
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:42:12 +0000 (11:42 -0600)] 
Whitespace fixes

18 months agoFix struct names
Arran Cudbard-Bell [Thu, 27 Jun 2024 16:39:50 +0000 (10:39 -0600)] 
Fix struct names

18 months agos/memberof/group/g for group checking XLAT to allow redundant xlats over SQL and...
Arran Cudbard-Bell [Thu, 27 Jun 2024 16:19:05 +0000 (10:19 -0600)] 
s/memberof/group/g for group checking XLAT to allow redundant xlats over SQL and LDAP

18 months agoDo size calculation in appropriate type (CID #1604603)
James Jones [Thu, 27 Jun 2024 14:00:32 +0000 (09:00 -0500)] 
Do size calculation in appropriate type (CID #1604603)

In the error message in lst_expand(), the calculation of the size
has to be done in size_t. The cast of sizeof(void *) to uint32_t
causes it to be done in uint32_t, but that has the possibility of
overflow; note that n_capacity may be set to UINT_MAX, which would
guarantee it. The format conversion is changed to match.

18 months agocassandra start query is missing two escape characters
Stephen Blackwell [Wed, 26 Jun 2024 21:14:56 +0000 (15:14 -0600)] 
cassandra start query is missing two escape characters

18 months agoOnly add positive r values to total (CID #16046001)
James Jones [Wed, 26 Jun 2024 16:36:09 +0000 (11:36 -0500)] 
Only add positive r values to total (CID #16046001)

With the addition of r to total in the for loop header, the continue
for EINTR causes a negative value of r to be added to total. That's the
only thing that looks like it could cause an overflow and taint total.

18 months agoAdd open_query to MySQL queries.conf
Nick Porter [Wed, 26 Jun 2024 12:22:31 +0000 (13:22 +0100)] 
Add open_query to MySQL queries.conf

Particularly in the case of sqlippool use, it has been found that
setting the transaction isolation level to READ COMMITTED is needed to
avoid deadlocks.

18 months agoReinstate running open_query for MySQL
Nick Porter [Wed, 26 Jun 2024 12:17:15 +0000 (13:17 +0100)] 
Reinstate running open_query for MySQL

18 months agoCorrect enum case
Nick Porter [Wed, 26 Jun 2024 12:12:47 +0000 (13:12 +0100)] 
Correct enum case

18 months agoGuard allocation with MEM() (CID #1604618)
James Jones [Tue, 25 Jun 2024 16:37:32 +0000 (11:37 -0500)] 
Guard allocation with MEM() (CID #1604618)

18 months agoCorrect docs
Nick Porter [Tue, 25 Jun 2024 14:53:15 +0000 (15:53 +0100)] 
Correct docs

18 months agosqlippool query fixes
Nick Porter [Mon, 24 Jun 2024 18:23:34 +0000 (19:23 +0100)] 
sqlippool query fixes

18 months agoDon't attempt to run zero length queries
Nick Porter [Mon, 24 Jun 2024 17:35:32 +0000 (18:35 +0100)] 
Don't attempt to run zero length queries

Since these come from conf file entries it's all to easy for something
such as

alloc_requested = ''

to be set rather than commenting out the entry.

18 months agoAdd client_port to proto_dhcpv4_udp
Nick Porter [Mon, 24 Jun 2024 13:46:06 +0000 (14:46 +0100)] 
Add client_port to proto_dhcpv4_udp

18 months agoCorrect DHCP attribute sorting comparison function
Nick Porter [Fri, 21 Jun 2024 16:02:47 +0000 (17:02 +0100)] 
Correct DHCP attribute sorting comparison function

18 months agoadd more documentation
Alan T. DeKok [Fri, 21 Jun 2024 16:12:28 +0000 (12:12 -0400)] 
add more documentation

18 months agocorrect decode of length + offset fields in structs
Alan T. DeKok [Fri, 21 Jun 2024 16:04:41 +0000 (12:04 -0400)] 
correct decode of length + offset fields in structs

18 months agothe correct offset is 3
Alan T. DeKok [Fri, 21 Jun 2024 16:03:14 +0000 (12:03 -0400)] 
the correct offset is 3

18 months agothe offset here is 3
Alan T. DeKok [Fri, 21 Jun 2024 16:02:33 +0000 (12:02 -0400)] 
the offset here is 3

18 months agoadd tests for simple password auth type
Alan T. DeKok [Fri, 21 Jun 2024 14:53:44 +0000 (10:53 -0400)] 
add tests for simple password auth type

18 months agoRemove spurious debug message
Nick Porter [Fri, 21 Jun 2024 10:45:26 +0000 (11:45 +0100)] 
Remove spurious debug message

18 months agoFix error in dictionary documentation
Matthew Newton [Fri, 21 Jun 2024 09:06:39 +0000 (10:06 +0100)] 
Fix error in dictionary documentation

Fixes #5345

18 months agoMore const issues
Arran Cudbard-Bell [Fri, 21 Jun 2024 00:31:52 +0000 (18:31 -0600)] 
More const issues

18 months agoFix some missed renames
Arran Cudbard-Bell [Fri, 21 Jun 2024 00:06:36 +0000 (18:06 -0600)] 
Fix some missed renames

18 months agoConst issues
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:51:01 +0000 (17:51 -0600)] 
Const issues

18 months agoEvaluate all chained method groups when searching for methods or printing methods
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:36:01 +0000 (17:36 -0600)] 
Evaluate all chained method groups when searching for methods or printing methods

18 months agoCommon indent levels in module_rlm.h
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:18:02 +0000 (17:18 -0600)] 
Common indent levels in module_rlm.h

18 months agoRemove unused functions
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:16:42 +0000 (17:16 -0600)] 
Remove unused functions

18 months agoInitialise name
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:13:27 +0000 (17:13 -0600)] 
Initialise name

18 months agoCorrect example xlat calls
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:13:17 +0000 (17:13 -0600)] 
Correct example xlat calls

18 months agoFinal set of changes for making redundant xlat function registration not suck
Arran Cudbard-Bell [Thu, 20 Jun 2024 21:57:23 +0000 (15:57 -0600)] 
Final set of changes for making redundant xlat function registration not suck

We now group module xlats by name (all self-named module expansions are considered equal).

This allows:

redundant {
    sql
    linelog
}

Which would issue a query against SQL, and then log it to disk.

The instantiate code catches/disallows calls to incompatible module expansions in much the same way as C's _Generic does...

18 months agoTest attr_filter on reply list
Nick Porter [Thu, 20 Jun 2024 16:09:32 +0000 (17:09 +0100)] 
Test attr_filter on reply list

18 months agoUse correct context for pairs
Nick Porter [Thu, 20 Jun 2024 16:08:56 +0000 (17:08 +0100)] 
Use correct context for pairs

18 months agoAdd list name based methods to attr_filter
Nick Porter [Thu, 20 Jun 2024 15:53:26 +0000 (16:53 +0100)] 
Add list name based methods to attr_filter

18 months agoPython script to add an lldb command
James Jones [Tue, 4 Jun 2024 13:57:21 +0000 (08:57 -0500)] 
Python script to add an lldb command

This, once imported with an lldb "script" command, adds a "dd" command
to display certain types of values in an intelligible fashion using the
existing foo_debug() functions not only is it intelligible, it uses a
format people are used to.

The foo_debug() functions take a pointer to the structure. The dd command
will take names of variables that have the structure type as well, and
pass their address.

18 months agoAdd doc file for lldb
James Jones [Thu, 13 Jun 2024 21:47:26 +0000 (16:47 -0500)] 
Add doc file for lldb

Initially at least it concentrates on extending it with Python scripts,
though it does describe how to adapt the sample command line output
when a test fails to invoke lldb on the program being tested.

18 months agoDon't use MySQL read / write timeout options
Nick Porter [Thu, 20 Jun 2024 09:00:36 +0000 (10:00 +0100)] 
Don't use MySQL read / write timeout options

The model for async is different to the sync client.  Timeouts are
expected to be handled by the calling application rather than the client
library.

18 months agoBackticks
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:39:58 +0000 (14:39 -0600)] 
Backticks

18 months agoUse the correct context
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:37:35 +0000 (14:37 -0600)] 
Use the correct context

18 months agoPut the proxy reply in the right list...
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:11:52 +0000 (14:11 -0600)] 
Put the proxy reply in the right list...

18 months agoFix confusing name
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:11:40 +0000 (14:11 -0600)] 
Fix confusing name

19 months agoquiet coverity
Alan T. DeKok [Wed, 19 Jun 2024 12:49:17 +0000 (08:49 -0400)] 
quiet coverity

We can decode packets if there's no original request, but we
cannot verify the Response Authenticator

19 months agoStatus-Client has no definition and is never used
Alan T. DeKok [Wed, 19 Jun 2024 12:47:53 +0000 (08:47 -0400)] 
Status-Client has no definition and is never used

19 months agoadd connection_timeout to RADIUS client BIO
Alan T. DeKok [Wed, 12 Jun 2024 18:50:33 +0000 (14:50 -0400)] 
add connection_timeout to RADIUS client BIO

19 months agoremove UNUSED
Alan T. DeKok [Wed, 12 Jun 2024 18:08:30 +0000 (14:08 -0400)] 
remove UNUSED

variables are used.

19 months agofix compiler warning
Alan T. DeKok [Wed, 12 Jun 2024 18:07:05 +0000 (14:07 -0400)] 
fix compiler warning

19 months agoEnsure queries are freed before pool connection is released
Nick Porter [Tue, 18 Jun 2024 15:02:14 +0000 (16:02 +0100)] 
Ensure queries are freed before pool connection is released

19 months agoFix docs
Arran Cudbard-Bell [Tue, 18 Jun 2024 02:58:37 +0000 (20:58 -0600)] 
Fix docs

19 months agoFix "RADIUS checksum" mode in radsniff, when dealing with Access-Requests
Arran Cudbard-Bell [Tue, 18 Jun 2024 02:48:12 +0000 (20:48 -0600)] 
Fix "RADIUS checksum" mode in radsniff, when dealing with Access-Requests

19 months agoAdd 3GPP2 attributes
Nick Porter [Mon, 17 Jun 2024 16:04:18 +0000 (17:04 +0100)] 
Add 3GPP2 attributes

Found in 3GPP2 specification document A.S0008-C

19 months agoRecord which xlat registered the module instance
Arran Cudbard-Bell [Sun, 16 Jun 2024 04:53:42 +0000 (22:53 -0600)] 
Record which xlat registered the module instance

19 months agoNot supported by GCC
Arran Cudbard-Bell [Sun, 16 Jun 2024 04:39:00 +0000 (22:39 -0600)] 
Not supported by GCC

19 months agoWrap the module method array in a grouping structure
Arran Cudbard-Bell [Sun, 9 Jun 2024 22:46:00 +0000 (18:46 -0400)] 
Wrap the module method array in a grouping structure

19 months agoFix policy name
Nick Porter [Fri, 14 Jun 2024 11:56:54 +0000 (12:56 +0100)] 
Fix policy name

There is no preacct section or method any more