]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
23 months agoCorrect logic for resetting times
Nick Porter [Wed, 14 Feb 2024 13:55:52 +0000 (13:55 +0000)] 
Correct logic for resetting times

23 months agoConf options have CONF_FLAG_REQURED so will exist
Nick Porter [Wed, 14 Feb 2024 13:54:43 +0000 (13:54 +0000)] 
Conf options have CONF_FLAG_REQURED so will exist

23 months agoEnsure that sqlcounter queries return 0 if there are no matching records
Nick Porter [Wed, 14 Feb 2024 11:39:39 +0000 (11:39 +0000)] 
Ensure that sqlcounter queries return 0 if there are no matching records

23 months agosqlcounter start and end attributes are by default in the control list
Nick Porter [Wed, 14 Feb 2024 11:22:40 +0000 (11:22 +0000)] 
sqlcounter start and end attributes are by default in the control list

23 months agoFlags need to match what will be on the created DA
Nick Porter [Tue, 13 Feb 2024 17:19:25 +0000 (17:19 +0000)] 
Flags need to match what will be on the created DA

After inserting, tmpl_attr_tail_unresolved_add checks the resulting
flags and fails if they differ.

23 months agoAlign default attribute names with sample SQL
Nick Porter [Tue, 13 Feb 2024 16:48:08 +0000 (16:48 +0000)] 
Align default attribute names with sample SQL

And add quoting, needed to parse defaults correctly.

23 months agoAdd reply message attribute to sqlcounter call_env
Nick Porter [Tue, 13 Feb 2024 16:45:30 +0000 (16:45 +0000)] 
Add reply message attribute to sqlcounter call_env

23 months agoMove sqlcounter reply_attr to call_env
Nick Porter [Tue, 13 Feb 2024 15:41:46 +0000 (15:41 +0000)] 
Move sqlcounter reply_attr to call_env

23 months agoLess noisy debug
Nick Porter [Tue, 13 Feb 2024 15:36:11 +0000 (15:36 +0000)] 
Less noisy debug

23 months agoMore appropriate variable name
Nick Porter [Tue, 13 Feb 2024 15:34:48 +0000 (15:34 +0000)] 
More appropriate variable name

It's no longer a magic paircmp attribute

23 months agoUse value box cmp / cast to avoid duplicate code
Nick Porter [Tue, 13 Feb 2024 15:17:13 +0000 (15:17 +0000)] 
Use value box cmp / cast to avoid duplicate code

23 months agoAnd one more
Nick Porter [Thu, 15 Feb 2024 16:32:08 +0000 (16:32 +0000)] 
And one more

23 months agoMore doxygen fixes
Nick Porter [Thu, 15 Feb 2024 15:47:31 +0000 (15:47 +0000)] 
More doxygen fixes

23 months agoDoxygen fixes
Nick Porter [Wed, 14 Feb 2024 08:50:33 +0000 (08:50 +0000)] 
Doxygen fixes

23 months agoautofree talloc ctx is now used in all builds
Nick Porter [Wed, 14 Feb 2024 08:27:38 +0000 (08:27 +0000)] 
autofree talloc ctx is now used in all builds

23 months agoAdd function documentation
Nick Porter [Wed, 14 Feb 2024 08:26:31 +0000 (08:26 +0000)] 
Add function documentation

23 months agoCorrect function docs
Nick Porter [Wed, 14 Feb 2024 08:25:18 +0000 (08:25 +0000)] 
Correct function docs

23 months agostart moving radclient-ng to the new bio API
Alan T. DeKok [Wed, 14 Feb 2024 02:52:48 +0000 (21:52 -0500)] 
start moving radclient-ng to the new bio API

23 months agohoist socket name into common function
Alan T. DeKok [Wed, 14 Feb 2024 00:54:16 +0000 (19:54 -0500)] 
hoist socket name into common function

and get socket name after connect(), too

23 months agoset the bio type
Alan T. DeKok [Tue, 13 Feb 2024 17:58:11 +0000 (12:58 -0500)] 
set the bio type

23 months agostart moving configuration parameters to fr_bio_fd_config_t
Alan T. DeKok [Tue, 13 Feb 2024 13:14:31 +0000 (08:14 -0500)] 
start moving configuration parameters to fr_bio_fd_config_t

23 months agodon't open new sockets
Alan T. DeKok [Tue, 13 Feb 2024 13:05:47 +0000 (08:05 -0500)] 
don't open new sockets

23 months agoRemove repeat talloc_free
Nick Porter [Tue, 13 Feb 2024 18:04:15 +0000 (18:04 +0000)] 
Remove repeat talloc_free

23 months agoIf user is in radcheck but not radreply, still merge control items
Nick Porter [Tue, 13 Feb 2024 18:03:43 +0000 (18:03 +0000)] 
If user is in radcheck but not radreply, still merge control items

23 months agoEnsure test_connection_levels_max() requests are completed/cancelled
James Jones [Tue, 13 Feb 2024 16:25:53 +0000 (10:25 -0600)] 
Ensure test_connection_levels_max() requests are completed/cancelled

23 months agoAdd basic tests of mschap module
Nick Porter [Tue, 13 Feb 2024 11:07:07 +0000 (11:07 +0000)] 
Add basic tests of mschap module

23 months agoUse call_env for libwbclient auth in rlm_mschap
Nick Porter [Tue, 13 Feb 2024 10:56:30 +0000 (10:56 +0000)] 
Use call_env for libwbclient auth in rlm_mschap

23 months agoNT Password is not needed for external mschap methods
Nick Porter [Mon, 12 Feb 2024 18:00:43 +0000 (18:00 +0000)] 
NT Password is not needed for external mschap methods

23 months agoInclude rlm_unbound in packaging
Nick Porter [Mon, 12 Feb 2024 10:34:58 +0000 (10:34 +0000)] 
Include rlm_unbound in packaging

Same as v3.2

23 months agoAllow for differing versions of ub_event_callback_type
Nick Porter [Mon, 12 Feb 2024 15:34:05 +0000 (15:34 +0000)] 
Allow for differing versions of ub_event_callback_type

23 months agoAdd tests of rlm_winbind
Nick Porter [Mon, 12 Feb 2024 11:44:58 +0000 (11:44 +0000)] 
Add tests of rlm_winbind

23 months agoThese are not errors
Nick Porter [Mon, 12 Feb 2024 10:32:25 +0000 (10:32 +0000)] 
These are not errors

23 months agoUse call_env in %winbind.group() xlat
Nick Porter [Mon, 12 Feb 2024 10:29:18 +0000 (10:29 +0000)] 
Use call_env in %winbind.group() xlat

23 months agoMore appropriate debug message types / levels
Nick Porter [Fri, 9 Feb 2024 18:10:07 +0000 (18:10 +0000)] 
More appropriate debug message types / levels

23 months agoRemove unused option
Nick Porter [Fri, 9 Feb 2024 17:51:43 +0000 (17:51 +0000)] 
Remove unused option

23 months agoUse custom call_env parser to handle automatic domain lookup
Nick Porter [Fri, 9 Feb 2024 17:51:21 +0000 (17:51 +0000)] 
Use custom call_env parser to handle automatic domain lookup

23 months agoUse call_env in winbind mod_authorize
Nick Porter [Fri, 9 Feb 2024 17:21:02 +0000 (17:21 +0000)] 
Use call_env in winbind mod_authorize

23 months agoUse new xlat function syntax
Nick Porter [Fri, 9 Feb 2024 16:32:54 +0000 (16:32 +0000)] 
Use new xlat function syntax

23 months agoxlat_arg_parser for winbind.group is static const
Nick Porter [Fri, 9 Feb 2024 16:30:49 +0000 (16:30 +0000)] 
xlat_arg_parser for winbind.group is static const

There is no escape function needing access to inst

23 months agoUse a call_env for rlm_winbind mod_authenticate
Nick Porter [Fri, 9 Feb 2024 16:24:35 +0000 (16:24 +0000)] 
Use a call_env for rlm_winbind mod_authenticate

23 months agoTidy up
Nick Porter [Fri, 9 Feb 2024 12:43:46 +0000 (12:43 +0000)] 
Tidy up

23 months agoMove loading of rlm_files data to call_env
Nick Porter [Fri, 9 Feb 2024 12:36:17 +0000 (12:36 +0000)] 
Move loading of rlm_files data to call_env

23 months agoCorrect comment
Nick Porter [Fri, 9 Feb 2024 12:06:28 +0000 (12:06 +0000)] 
Correct comment

23 months agoFormatting
Nick Porter [Fri, 9 Feb 2024 09:32:04 +0000 (09:32 +0000)] 
Formatting

23 months agoTemporary &users list is not talloced, only its members are
Nick Porter [Fri, 9 Feb 2024 09:29:59 +0000 (09:29 +0000)] 
Temporary &users list is not talloced, only its members are

23 months agoAlign sample configuration with rlm_files only having one filename
Nick Porter [Fri, 9 Feb 2024 09:24:06 +0000 (09:24 +0000)] 
Align sample configuration with rlm_files only having one filename

23 months agoJust use a single filename in rlm_files
Nick Porter [Wed, 7 Feb 2024 20:01:57 +0000 (20:01 +0000)] 
Just use a single filename in rlm_files

If different data is used in different contexts, use multiple instances
of the module

23 months agonope. header length is 4
Alan T. DeKok [Fri, 9 Feb 2024 14:52:14 +0000 (09:52 -0500)] 
nope.  header length is 4

23 months agocheck for fragment with insufficient room for header
Alan T. DeKok [Fri, 9 Feb 2024 14:49:50 +0000 (09:49 -0500)] 
check for fragment with insufficient room for header

23 months agoadd test and example for eval
Alan T. DeKok [Wed, 7 Feb 2024 17:56:03 +0000 (12:56 -0500)] 
add test and example for eval

23 months agoadd output from fuzzer
Alan T. DeKok [Wed, 7 Feb 2024 13:56:15 +0000 (08:56 -0500)] 
add output from fuzzer

hopefully we can get a better error message running the normal
tests.

23 months agoRemove protocol prefixes from attribute references
Nick Porter [Wed, 7 Feb 2024 08:11:33 +0000 (08:11 +0000)] 
Remove protocol prefixes from attribute references

23 months agoUpdate sqlippool docs
Nick Porter [Fri, 2 Feb 2024 17:53:13 +0000 (17:53 +0000)] 
Update sqlippool docs

23 months agosqlippool should be called in `accounting ...` sections
Nick Porter [Fri, 2 Feb 2024 17:52:53 +0000 (17:52 +0000)] 
sqlippool should be called in `accounting ...` sections

So that the correct method is used.

23 months agoAdd tests of rlm_sqlippool
Nick Porter [Fri, 2 Feb 2024 14:50:19 +0000 (14:50 +0000)] 
Add tests of rlm_sqlippool

23 months agoConvert remaining sqlippool methods to use call_env
Nick Porter [Fri, 2 Feb 2024 14:37:32 +0000 (14:37 +0000)] 
Convert remaining sqlippool methods to use call_env

23 months agoMove the rest of sqlippool alloc to use call_env
Nick Porter [Fri, 2 Feb 2024 14:35:29 +0000 (14:35 +0000)] 
Move the rest of sqlippool alloc to use call_env

23 months agoAdd alloc queries to call_env
Nick Porter [Fri, 2 Feb 2024 14:25:06 +0000 (14:25 +0000)] 
Add alloc queries to call_env

23 months agoUpdate sqlippool query functions to expect pre-expanded queries and take an rlm_sql_t
Nick Porter [Fri, 2 Feb 2024 14:23:07 +0000 (14:23 +0000)] 
Update sqlippool query functions to expect pre-expanded queries and take an rlm_sql_t

23 months agoAdd sql escape uctx alloc / free functions for SQL IP Pool queries
Nick Porter [Fri, 2 Feb 2024 14:07:35 +0000 (14:07 +0000)] 
Add sql escape uctx alloc / free functions for SQL IP Pool queries

23 months agoDefine custom call_env parser for SQL IP Pool queries
Nick Porter [Fri, 2 Feb 2024 14:03:53 +0000 (14:03 +0000)] 
Define custom call_env parser for SQL IP Pool queries

23 months agoAdd box_escape_func to SQL module instance
Nick Porter [Fri, 2 Feb 2024 13:01:57 +0000 (13:01 +0000)] 
Add box_escape_func to SQL module instance

23 months agoMake module / xlat instance data available when parsing call_env
Nick Porter [Fri, 2 Feb 2024 13:00:36 +0000 (13:00 +0000)] 
Make module / xlat instance data available when parsing call_env

And pass it to the custom parsing function.

23 months agoAdd uctx for SQL escape functions
Nick Porter [Thu, 1 Feb 2024 17:56:55 +0000 (17:56 +0000)] 
Add uctx for SQL escape functions

Allows for passing of an exising connection handle

23 months agoPass safe_for to xlat_tokenize_input
Nick Porter [Thu, 1 Feb 2024 17:48:46 +0000 (17:48 +0000)] 
Pass safe_for to xlat_tokenize_input

23 months agoAdd rules for parsing literals in tmpls
Nick Porter [Tue, 6 Feb 2024 18:31:50 +0000 (18:31 +0000)] 
Add rules for parsing literals in tmpls

23 months agoUpdate sqlippool rcodes to match those returned by redis_ippool
Nick Porter [Mon, 22 Jan 2024 12:12:04 +0000 (12:12 +0000)] 
Update sqlippool rcodes to match those returned by redis_ippool

23 months agoMore helpful debug messages
Nick Porter [Fri, 19 Jan 2024 18:23:21 +0000 (18:23 +0000)] 
More helpful debug messages

23 months agoMove requested_address to call env
Nick Porter [Fri, 19 Jan 2024 18:17:27 +0000 (18:17 +0000)] 
Move requested_address to call env

23 months agoMove pool_name to call env
Nick Porter [Fri, 19 Jan 2024 17:32:29 +0000 (17:32 +0000)] 
Move pool_name to call env

23 months agoAdd initial call_env to sqlippool
Nick Porter [Fri, 19 Jan 2024 16:35:35 +0000 (16:35 +0000)] 
Add initial call_env to sqlippool

Just for allocated_address_attr to start with

23 months agoAdd tests of if using nested && and ||
Nick Porter [Wed, 7 Feb 2024 10:27:57 +0000 (10:27 +0000)] 
Add tests of if using nested && and ||

23 months agoReturn XLAT_ACTION_DONE on logical false
Nick Porter [Wed, 7 Feb 2024 09:50:00 +0000 (09:50 +0000)] 
Return XLAT_ACTION_DONE on logical false

XLAT_ACTION_FAIL is only when there is a failure, not when the return
from real evaluations is false

23 months agoadd test case to prevent regression
Alan T. DeKok [Tue, 6 Feb 2024 14:56:13 +0000 (09:56 -0500)] 
add test case to prevent regression

23 months agobetter catch malformed attributes
Alan T. DeKok [Tue, 6 Feb 2024 14:06:42 +0000 (09:06 -0500)] 
better catch malformed attributes

23 months agoremove -n and -p
Alan T. DeKok [Mon, 5 Feb 2024 14:02:43 +0000 (09:02 -0500)] 
remove -n and -p

23 months agoremove coa functionality
Alan T. DeKok [Mon, 5 Feb 2024 13:57:55 +0000 (08:57 -0500)] 
remove coa functionality

in the quest to get bios, we simply delete old code, which will be
eventually replaced with new code

23 months agouse correct function type to quiet ubsan complaints
Alan T. DeKok [Mon, 5 Feb 2024 13:44:10 +0000 (08:44 -0500)] 
use correct function type to quiet ubsan complaints

23 months agowe didn't call xlat init, so we don't call xlat free
Alan T. DeKok [Mon, 5 Feb 2024 02:31:15 +0000 (21:31 -0500)] 
we didn't call xlat init, so we don't call xlat free

23 months agoreference count init/free instead of using boolean
Alan T. DeKok [Mon, 5 Feb 2024 02:22:03 +0000 (21:22 -0500)] 
reference count init/free instead of using boolean

23 months agowe didn't call xlat init, we shouldn't call xlat free.
Alan T. DeKok [Mon, 5 Feb 2024 02:14:24 +0000 (21:14 -0500)] 
we didn't call xlat init, we shouldn't call xlat free.

23 months agonormalize names
Alan T. DeKok [Mon, 5 Feb 2024 02:00:37 +0000 (21:00 -0500)] 
normalize names

foo_global_init() and foo_global_free()

23 months agofor helping with fuzzer issues
Alan T. DeKok [Sun, 4 Feb 2024 21:39:49 +0000 (16:39 -0500)] 
for helping with fuzzer issues

23 months agoI do have loathing for compilers which don't produce error messages
Alan T. DeKok [Sun, 4 Feb 2024 17:28:28 +0000 (12:28 -0500)] 
I do have loathing for compilers which don't produce error messages

23 months agocomment out assertion to see if fuzzer will produce better error
Alan T. DeKok [Sun, 4 Feb 2024 17:17:35 +0000 (12:17 -0500)] 
comment out assertion to see if fuzzer will produce better error

23 months agomake sure to free tag ctx, too
Alan T. DeKok [Sun, 4 Feb 2024 16:12:44 +0000 (11:12 -0500)] 
make sure to free tag ctx, too

23 months agomake sure that we call library init / free
Alan T. DeKok [Sun, 4 Feb 2024 16:09:33 +0000 (11:09 -0500)] 
make sure that we call library init / free

23 months agofree tag ctx, too
Alan T. DeKok [Sun, 4 Feb 2024 15:46:41 +0000 (10:46 -0500)] 
free tag ctx, too

23 months agono longer any need to call init.
Alan T. DeKok [Sun, 4 Feb 2024 15:27:51 +0000 (10:27 -0500)] 
no longer any need to call init.

Missed in commit f7778c55206db

23 months agoAdd foreign tests to DHCPv6
Alan T. DeKok [Sun, 4 Feb 2024 15:24:09 +0000 (10:24 -0500)] 
Add foreign tests to DHCPv6

23 months agoclean up autofree
Alan T. DeKok [Sun, 4 Feb 2024 15:15:35 +0000 (10:15 -0500)] 
clean up autofree

The only remaining errors are:

test.unit.dns, which fails to clean up the DNS dictionaries.
All of the other protocols are fine, so there's some extra magic
here.

test.keywords: fr_dict_free() is asked to remove a dependency
which doesn't exist.  That _should_ be an assertion, but for now
it's a recoverable error which lets other people get work done.

23 months agojust call common function
Alan T. DeKok [Sun, 4 Feb 2024 13:11:15 +0000 (08:11 -0500)] 
just call common function

23 months agoadd dependency if we load the dictionary
Alan T. DeKok [Sun, 4 Feb 2024 13:10:28 +0000 (08:10 -0500)] 
add dependency if we load the dictionary

and thus we can call dict->proto->free()

23 months agoadd debug printing for dependencies
Alan T. DeKok [Sun, 4 Feb 2024 13:09:29 +0000 (08:09 -0500)] 
add debug printing for dependencies

23 months agodon't free dictionaries until we track down reference issues
Alan T. DeKok [Sun, 4 Feb 2024 03:17:29 +0000 (22:17 -0500)] 
don't free dictionaries until we track down reference issues

There are issues with calling proto->free() in the destructor
for the dictionaries

there are issues with foreign references.

23 months agoset loaded flag before calling proto->init()
Alan T. DeKok [Sun, 4 Feb 2024 03:16:29 +0000 (22:16 -0500)] 
set loaded flag before calling proto->init()

to prevent recursion

23 months agoadd assertion
Alan T. DeKok [Sun, 4 Feb 2024 03:16:16 +0000 (22:16 -0500)] 
add assertion

23 months agoremove unused code
Alan T. DeKok [Sun, 4 Feb 2024 02:58:56 +0000 (21:58 -0500)] 
remove unused code

23 months agoMove to init/free for library, and not for each test case
Alan T. DeKok [Sat, 3 Feb 2024 20:47:21 +0000 (15:47 -0500)] 
Move to init/free for library, and not for each test case

now that we (mostly) have library-based init/free, we do not need
to do that for every test case.  Either the library is properly
initialized and it works, or the library isn't initialized, and
the tests fail.

Some protocols still need to be converted to use fr_dict_protocol_t

ethernet, tacacs, tftp, vmps

23 months agodon't add the dependency twice
Alan T. DeKok [Sat, 3 Feb 2024 16:05:20 +0000 (11:05 -0500)] 
don't add the dependency twice